Fixed mishandling of an allocation failure in PHYSFS_openRead().

(Static analysis caught this one! Thanks clang!)
This commit is contained in:
Ryan C. Gordon 2020-05-12 15:19:01 -04:00
parent 291cad07b7
commit 235e31c420
1 changed files with 9 additions and 7 deletions

View File

@ -2731,13 +2731,15 @@ PHYSFS_File *PHYSFS_openRead(const char *_fname)
io->destroy(io);
PHYSFS_setErrorCode(PHYSFS_ERR_OUT_OF_MEMORY);
} /* if */
memset(fh, '\0', sizeof (FileHandle));
fh->io = io;
fh->forReading = 1;
fh->dirHandle = i;
fh->next = openReadList;
openReadList = fh;
else
{
memset(fh, '\0', sizeof (FileHandle));
fh->io = io;
fh->forReading = 1;
fh->dirHandle = i;
fh->next = openReadList;
openReadList = fh;
} /* else */
} /* if */
} /* if */