walkero
/
physfs
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Renamed a function to make Clang static analysis happy. 

"Object leaked: allocated object is returned from a function whose
 name ('cfallocDesc') does not contain 'Copy' or 'Create'.  This violates
 the naming convention rules given in the Memory Management Guide for
 Core Foundation"

(it doesn't actually leak, but okay, it's a reasonable naming convention.)
This commit is contained in:
Ryan C. Gordon 2014-02-07 16:17:48 -05:00
parent 5aa0dae5e2
commit 44fb6d5e2d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/platform_macosx.c
View File

@ -32,11 +32,11 @@
/* Wrap PHYSFS_Allocator in a CFAllocator... */ /* Wrap PHYSFS_Allocator in a CFAllocator... */
static CFAllocatorRef cfallocator = NULL; static CFAllocatorRef cfallocator = NULL;
static CFStringRef cfallocDesc(const void *info) static CFStringRef cfallocCopyDesc(const void *info)
{ {
return CFStringCreateWithCString(cfallocator, "PhysicsFS", return CFStringCreateWithCString(cfallocator, "PhysicsFS",
kCFStringEncodingASCII); kCFStringEncodingASCII);
} /* cfallocDesc */ } /* cfallocCopyDesc */
static void *cfallocMalloc(CFIndex allocSize, CFOptionFlags hint, void *info) static void *cfallocMalloc(CFIndex allocSize, CFOptionFlags hint, void *info)
@ -65,7 +65,7 @@ int __PHYSFS_platformInit(void)
/* set up a CFAllocator, so Carbon can use the physfs allocator, too. */ /* set up a CFAllocator, so Carbon can use the physfs allocator, too. */
CFAllocatorContext ctx; CFAllocatorContext ctx;
memset(&ctx, '\0', sizeof (ctx)); memset(&ctx, '\0', sizeof (ctx));
ctx.copyDescription = cfallocDesc; ctx.copyDescription = cfallocCopyDesc;
ctx.allocate = cfallocMalloc; ctx.allocate = cfallocMalloc;
ctx.reallocate = cfallocRealloc; ctx.reallocate = cfallocRealloc;
ctx.deallocate = cfallocFree; ctx.deallocate = cfallocFree;