Commit Graph

26 Commits

Author SHA1 Message Date
Ryan C. Gordon 1affc74230 From: Jorg Walter
To: icculus@clutteredmind.org
Subject: Bug in zip archiver
Date: Sat, 23 Jul 2005 22:19:09 +0200

Hi!

PhysFS has a bug in the ZIP archive module, function zip_find_start_of_dir.
Upon encountering a substring match, rc is set to a wrong value. The fix is
simple: swap both assignments like this:

[patch below  --Ed.]

Some additional info for testing: Symptoms when you encounter this bug: A dir
is reported as empty although it has files in it; prerequisites or
encountering it: two dirs, one a substring of another, like "data/txt" and
"data/txt2", laid out in a way so that variable "middle" points to a file in
txt2 at some point during zip_find_start_of_dir

By the way, if you're interested in where PhysFS is used: I found this bug
while writing a patch for DOSBox (http://dosbox.sourceforge.net) to support
ZIP files. And I'd love to see that enhanced PHYSFS_mount syntax in an
official release soon *hint* ;);)
2005-07-23 21:46:46 +00:00
Ryan C. Gordon 12353f5346 Backport from devbranch: mingw support. 2005-06-13 01:16:13 +00:00
Ryan C. Gordon cd065471c8 Spanish and Brazillian Portuguese translations. 2005-03-16 12:00:07 +00:00
Ryan C. Gordon 4b036dc0a2 strcpy/strcat fix, backported from devbranch. 2004-10-30 09:57:56 +00:00
Ryan C. Gordon c951ab5cb9 Updated. 2003-07-21 04:07:36 +00:00
Ryan C. Gordon 2829853aeb Updated. 2003-01-04 23:40:32 +00:00
Ryan C. Gordon 7b5f74c502 Updated. 2002-12-17 23:55:03 +00:00
Ryan C. Gordon 196edf5194 Updated. 2002-12-11 15:39:07 +00:00
Ryan C. Gordon b8b16e4d15 Updated. 2002-12-03 00:24:52 +00:00
Ryan C. Gordon acf93087be added Corona688. 2002-11-22 06:23:09 +00:00
Ryan C. Gordon 1c363d8833 Updated. 2002-08-29 21:09:23 +00:00
Ryan C. Gordon 3e3bdd28c2 Updated. 2002-08-09 19:46:08 +00:00
Ryan C. Gordon 39a42d3cc9 Updated. 2002-07-30 05:50:42 +00:00
Ryan C. Gordon abc7d83e6d Updated. 2002-07-30 05:20:49 +00:00
Ryan C. Gordon d4f7c5481e Spanish translation added by Pedro J. P?rez. 2002-07-30 01:42:29 +00:00
Ryan C. Gordon ca209195cb Updated. 2002-07-29 21:12:49 +00:00
Ryan C. Gordon 2086e0ed9c Updated. 2002-07-28 21:02:48 +00:00
Ryan C. Gordon 6c51693092 Updated. 2002-07-10 23:44:02 +00:00
Ryan C. Gordon 93367aa0ad Updated. 2002-06-11 09:07:42 +00:00
Ryan C. Gordon 7881931321 Updated. 2002-06-11 08:49:53 +00:00
Ryan C. Gordon d440f5891c Updated. 2002-05-16 02:45:19 +00:00
Ryan C. Gordon d143590e51 Mentioned MacOS Classic. 2002-04-05 18:16:12 +00:00
Ryan C. Gordon 72d3077167 Added Gregory S. Read. 2002-03-25 08:28:40 +00:00
Ryan C. Gordon 7484d7ccb1 Updated. 2002-03-05 01:37:04 +00:00
Ryan C. Gordon f2bb78075f Updated. 2001-09-26 03:11:55 +00:00
Ryan C. Gordon 70838fdc23 Initial add. 2001-09-14 22:57:02 +00:00