1affc74230
From: Jorg Walter
...
To: icculus@clutteredmind.org
Subject: Bug in zip archiver
Date: Sat, 23 Jul 2005 22:19:09 +0200
Hi!
PhysFS has a bug in the ZIP archive module, function zip_find_start_of_dir.
Upon encountering a substring match, rc is set to a wrong value. The fix is
simple: swap both assignments like this:
[patch below --Ed.]
Some additional info for testing: Symptoms when you encounter this bug: A dir
is reported as empty although it has files in it; prerequisites or
encountering it: two dirs, one a substring of another, like "data/txt" and
"data/txt2", laid out in a way so that variable "middle" points to a file in
txt2 at some point during zip_find_start_of_dir
By the way, if you're interested in where PhysFS is used: I found this bug
while writing a patch for DOSBox (http://dosbox.sourceforge.net ) to support
ZIP files. And I'd love to see that enhanced PHYSFS_mount syntax in an
official release soon *hint* ;);)
2005-07-23 21:46:46 +00:00
f3191d0e85
Off-by-one fix by Dieter Baron...fixes segfault in zip archive searching in
...
certain cases.
2003-07-20 21:13:25 +00:00
f4309f51e8
Tabs-to-spaces patch by James Turk.
2003-07-20 21:08:24 +00:00
b50342ad13
PocketPC fixes (thanks, David Hedbor!)
2003-05-18 07:52:28 +00:00
1344feceda
Fixed seeking in uncompressed zip entries and handle Java-created JAR files.
...
(Thanks to "Tree" for pointing out these bugs).
2003-03-30 18:44:59 +00:00
6f1d693fe8
Another attempt at type size correctness.
2003-03-12 06:19:37 +00:00
01505d8d58
Attempt at type correctness.
2003-03-12 05:39:51 +00:00
3a479b6cd8
Now compiles on CodeWarrior 6 for MacOS Classic again.
2003-01-31 04:07:48 +00:00
9d82110b57
Some cleanups for PocketPC port.
2002-11-22 06:24:10 +00:00
7606e3bf11
Win32 fixes.
2002-09-23 18:35:12 +00:00
ee077eabec
Fixed infinite loop bug, cleaned out tab chars.
2002-08-30 14:30:49 +00:00
f5e279536c
Fixed bug that prevented use when symlinks were disallowed.
...
More optimizations, too.
2002-08-28 23:32:29 +00:00
680de768b7
Fixes.
2002-08-28 08:27:27 +00:00
c5dfea18cf
ZIP_exists() now works with directories.
2002-08-21 22:33:30 +00:00
d40d951594
Minor signed/unsigned fix...ZIP_isDirectory() now seems to work.
2002-08-21 04:13:56 +00:00
1f5b571be7
Bunch of tedious corrections, optimizations, and cleanups.
2002-08-21 02:59:15 +00:00
1e2372b44c
Generalized sorting routines, and removed individual implementations.
2002-08-20 01:34:27 +00:00
912ca3266d
Fix for correct cleanup on read error.
2002-07-31 04:18:58 +00:00
d701627335
Patched memory leaks (thanks, Valgrind!)
2002-07-29 06:18:58 +00:00
42be0046aa
Natural language #defines and build system support.
2002-07-28 21:03:27 +00:00
0ab061308d
Initialized some variables to stop compiler whining.
2002-07-27 22:06:25 +00:00
1b29c3888c
More enumerate fixes.
2002-07-26 17:03:26 +00:00
3ae1f1fa80
Changed DirFunctions struct a little.
2002-07-26 06:19:09 +00:00
8eeaf6c6d7
Rewrote ZIP_enumerateFiles() again. Hopefully it sucks less this time.
2002-07-25 04:41:43 +00:00
7c80bcf537
Disabled shitty enumeration code. Will fix soon.
2002-07-23 22:55:47 +00:00
a4d07b8e10
More enumeration fixes. I still hate this code.
2002-07-23 22:09:35 +00:00
55b7638892
Fixed a double-free.
2002-07-23 21:26:51 +00:00
e460c9ce9a
Fixed ZIP_isArchive() to report correctly if it has to check for the
...
end of central directory record.
2002-07-23 18:05:50 +00:00
4765a364fe
Fixed enumerations that end with '/'.
2002-07-23 17:52:56 +00:00
e98615a7ca
My rewrite continues. I'm mostly satisfied with this code now, minus debugging.
2002-07-23 07:49:13 +00:00
f558dcfe4a
Seeking backwards in ZIP_seek() works now.
2002-07-17 16:05:39 +00:00
2fab3d9da4
Fixed symlink detection.
2002-07-15 13:20:34 +00:00
2ec465ffc4
Symlink fixes. Still broken, though.
2002-07-15 02:22:52 +00:00
480a259452
ZIP archiver rewrite.
2002-07-13 10:17:13 +00:00
959a15e27f
FIXME cleanups.
2002-07-11 21:37:30 +00:00
05b565422a
Implemeted getLastModTime method.
2002-06-06 05:38:47 +00:00
5386a5c6a2
Added PHYSFS_getLastModTime() API. (Thanks, John Hall!)
2002-05-25 09:41:14 +00:00
a2bec46a6b
Initial autoconf support.
2002-05-10 09:25:25 +00:00
748cbac1c0
Patches for correctness and cleaner win32 support.
2002-04-12 05:53:12 +00:00
a366cfe1a2
Approved zeph's comments, fixed a few of my screwups.
2002-04-03 07:40:27 +00:00
0217b7cdd7
-Added type casting that Ryan needs to approve.
...
-MSVC complained about implicit 64-bit to 32-bit conversions.
2002-04-03 04:20:07 +00:00
9982d89b5b
Removed now-unnecessary errno.h include.
2002-04-01 18:45:37 +00:00
5d2b8493f6
Patched to compile.
2002-03-30 01:57:53 +00:00
d8cf534bf2
Platform abstracted i/o, other bugfixes.
2002-03-29 08:20:06 +00:00
f2887cf047
Added typedefs and platform-specific i/o.
2002-03-24 19:47:33 +00:00
c7aad1afd6
Changed author credits to wrap email addresses in "<>" and not "()" chars.
2001-09-14 22:55:44 +00:00
ed2a43b2ea
Patched to compile with an ancient version of CodeWarrior.
2001-09-02 04:55:25 +00:00
7aa0c252a9
More win32 updates.
2001-08-23 16:02:51 +00:00
f0c09894c8
Updates, corrections and enhancements to get this ported to win32.
2001-08-23 15:23:21 +00:00
beb42ac451
Changed URL to physfs homepage.
2001-08-07 02:57:16 +00:00
Ryan C. Gordon
Gregory S. Read