Commit Graph

900 Commits

Author SHA1 Message Date
Ryan C. Gordon 49ebc305ac More minor OS/2 tweaks. 2005-07-23 22:01:03 +00:00
Ryan C. Gordon 8f3ab12d22 From: Jorg Walter
To: icculus@clutteredmind.org
Subject: Bug in zip archiver
Date: Sat, 23 Jul 2005 22:19:09 +0200

Hi!

PhysFS has a bug in the ZIP archive module, function zip_find_start_of_dir.
Upon encountering a substring match, rc is set to a wrong value. The fix is
simple: swap both assignments like this:

[patch below  --Ed.]

Some additional info for testing: Symptoms when you encounter this bug: A dir
is reported as empty although it has files in it; prerequisites or
encountering it: two dirs, one a substring of another, like "data/txt" and
"data/txt2", laid out in a way so that variable "middle" points to a file in
txt2 at some point during zip_find_start_of_dir

By the way, if you're interested in where PhysFS is used: I found this bug
while writing a patch for DOSBox (http://dosbox.sourceforge.net) to support
ZIP files. And I'd love to see that enhanced PHYSFS_mount syntax in an
official release soon *hint* ;);)
2005-07-23 21:46:07 +00:00
Ryan C. Gordon 507b099d5d Patched to compile on OS/2 again. 2005-07-21 18:10:17 +00:00
Ryan C. Gordon f114094fa8 Whoops, missed a zlib121 reference... 2005-07-13 15:21:21 +00:00
Ryan C. Gordon c794701885 Patched zlib security hole discussed here:
http://www.cve.mitre.org/cgi-bin/cvename.cgi?name=CAN-2005-2096
2005-07-13 15:10:00 +00:00
Ryan C. Gordon ec86fac0bb Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
Ryan C. Gordon 91319260b1 Added mingw support to the build process (thanks, Matze!). 2005-06-13 01:13:21 +00:00
Ryan C. Gordon af6fa158f0 Updated. 2005-03-16 13:10:40 +00:00
Ryan C. Gordon 63b29f78c1 Updated. 2005-03-16 13:07:22 +00:00
Ryan C. Gordon d18fb707b0 Changed CWProjects from SITX to SIT format, so OS9 users can unpack it. 2005-03-16 12:15:22 +00:00
Ryan C. Gordon 34f60ab12d Updated. 2005-03-16 12:11:44 +00:00
Ryan C. Gordon e9cf90feda Ehh...I lied. Reverting change. 2005-03-16 12:07:10 +00:00
Ryan C. Gordon 5c7308cdd3 Whoops, this goes here. 2005-03-16 12:06:18 +00:00
Ryan C. Gordon 8bfdf7c9e7 More translation patches. 2005-03-16 12:01:40 +00:00
Ryan C. Gordon 7a62100d99 Updated. 2005-03-16 11:48:10 +00:00
Ryan C. Gordon 12684647dc MacOS Classic fixes and MPW support (thanks, Chris!). 2005-03-16 11:42:54 +00:00
Ryan C. Gordon 16e00ed962 Added translation for WAD file type. 2005-03-16 11:27:31 +00:00
Ryan C. Gordon 3749633f88 Updated. 2005-03-16 11:20:43 +00:00
Ryan C. Gordon 3a0e6fa051 Builds on Mac Classic again. 2005-03-14 12:05:07 +00:00
Ryan C. Gordon d840403c1c All memory management now goes through allocation hooks instead of directly to
C runtime malloc/realloc/free...
2005-03-14 11:49:30 +00:00
Ryan C. Gordon 4787894ffa Updated. 2005-03-14 11:48:29 +00:00
Ryan C. Gordon c799a14c70 Commented out a printf() and cleaned up some mallocs. 2005-03-14 11:47:42 +00:00
Ryan C. Gordon 2211ea7240 Fixed an error string. 2005-03-14 07:33:37 +00:00
Ryan C. Gordon a2cc461727 More mountpoint work and other cleanups. 2005-03-14 07:15:40 +00:00
Ryan C. Gordon ae093ff0fc Added more entry points. 2005-03-14 07:14:58 +00:00
Ryan C. Gordon d992f4325a Cleaned up some mallocs. 2005-03-13 21:16:15 +00:00
Ryan C. Gordon 38a1c7f559 If rejecting an archive for not matching a mount point, set an error state,
otherwise, PHYSFS_openRead could fail with a null error message.
2005-03-13 21:03:31 +00:00
Ryan C. Gordon 67776da8cc Split off sanitizePlatformIndependentPath() from verifySecurity(), which makes
this faster and reduces malloc() pressure. Plus cleanups, and other mount
 work.
2005-03-13 12:03:05 +00:00
Ryan C. Gordon c557443265 Updated. 2005-03-13 12:01:59 +00:00
Ryan C. Gordon 71da6381ad Some mount functionality stuff. 2005-03-13 11:59:53 +00:00
Ryan C. Gordon 8786d07f5d Updated. 2005-03-13 09:16:26 +00:00
Ryan C. Gordon 93adbf1d88 First chunk of PHYSFS_mount() implementation. Incomplete! 2005-03-13 09:09:26 +00:00
Ryan C. Gordon 389a4d826a Cleaned up some minor bloat with my new evil GOTO_*_MACRO macros. 2005-03-13 03:33:11 +00:00
Ryan C. Gordon 9f9800928d Fixed unix.c to compile again on MacOS X. 2005-03-13 03:18:18 +00:00
Ryan C. Gordon bdb7f54bd9 Added evil GOTO_*_MACRO_* macros. 2005-03-13 03:04:04 +00:00
Ryan C. Gordon 0dd93d3c13 Updated. 2005-02-15 22:26:05 +00:00
Ryan C. Gordon ed5de27c73 Fixed incorrect comment. 2005-02-15 22:25:03 +00:00
Ryan C. Gordon 5c313d7a93 Fixed filename sorting, to fix lookups that shouldn't fail (thanks, Chris!). 2005-01-05 05:15:12 +00:00
Ryan C. Gordon d19d7b5a59 Fixed some documentation/header comment typos (thanks, Gaetan!) 2004-12-16 16:20:46 +00:00
Ryan C. Gordon e2c199b8ab Fixed infinite loop in enum code (thanks, Adam!) 2004-10-31 12:20:00 +00:00
Ryan C. Gordon a27c289f29 CFLAGS is used after PHYSFSCFLAGS, so you can override optimization flags, etc. 2004-10-30 23:45:29 +00:00
Ryan C. Gordon bdd4ca0d93 Fixed a strcpy bug. 2004-10-30 09:31:54 +00:00
Ryan C. Gordon 3e06b381e9 Removed profiling code. 2004-10-07 02:10:01 +00:00
Ryan C. Gordon 35ec4ba395 Updated. 2004-10-01 07:58:12 +00:00
Ryan C. Gordon 4b02bb0c64 Updated. 2004-10-01 07:47:32 +00:00
Ryan C. Gordon c2c71fb55f Removed LinkedStringList and related code. 2004-09-29 06:37:20 +00:00
Ryan C. Gordon 0492580bda Removed all the forward declaration cruft from the archivers. 2004-09-29 06:18:04 +00:00
Ryan C. Gordon c2765f8571 Added callback APIs and ripped up the internals everywhere to use them. 2004-09-29 06:09:29 +00:00
Ryan C. Gordon 80535e9b83 Updated. 2004-09-29 06:03:44 +00:00
Ryan C. Gordon 8641e4e7ef Changed PHYSFS_file to PHYSFS_File to match rest of API's naming
convention. This won't break binary compat (function signatures are
extern "C" so name mangling doesn't apply), and I've placed a typedef
for the old name to support legacy source code.
2004-09-26 13:17:54 +00:00