A portable, flexible file i/o abstraction.
Go to file
Ryan C. Gordon 8f3ab12d22 From: Jorg Walter
To: icculus@clutteredmind.org
Subject: Bug in zip archiver
Date: Sat, 23 Jul 2005 22:19:09 +0200

Hi!

PhysFS has a bug in the ZIP archive module, function zip_find_start_of_dir.
Upon encountering a substring match, rc is set to a wrong value. The fix is
simple: swap both assignments like this:

[patch below  --Ed.]

Some additional info for testing: Symptoms when you encounter this bug: A dir
is reported as empty although it has files in it; prerequisites or
encountering it: two dirs, one a substring of another, like "data/txt" and
"data/txt2", laid out in a way so that variable "middle" points to a file in
txt2 at some point during zip_find_start_of_dir

By the way, if you're interested in where PhysFS is used: I found this bug
while writing a patch for DOSBox (http://dosbox.sourceforge.net) to support
ZIP files. And I'd love to see that enhanced PHYSFS_mount syntax in an
official release soon *hint* ;);)
2005-07-23 21:46:07 +00:00
PBProjects Whoops, missed a zlib121 reference... 2005-07-13 15:21:21 +00:00
archivers From: Jorg Walter 2005-07-23 21:46:07 +00:00
debian Upped version to 0.1.9. 2003-07-23 04:13:21 +00:00
extras Changed PHYSFS_file to PHYSFS_File to match rest of API's naming 2004-09-26 13:17:54 +00:00
platform Patched to compile on OS/2 again. 2005-07-21 18:10:17 +00:00
test Commented out a printf() and cleaned up some mallocs. 2005-03-14 11:47:42 +00:00
zlib122 Patched zlib security hole discussed here: 2005-07-13 15:10:00 +00:00
CHANGELOG From: Jorg Walter 2005-07-23 21:46:07 +00:00
CREDITS From: Jorg Walter 2005-07-23 21:46:07 +00:00
CWProjects.sit Changed CWProjects from SITX to SIT format, so OS9 users can unpack it. 2005-03-16 12:15:22 +00:00
Doxyfile Last minute changes, fixes, and build system updates for 1.0. 2004-01-08 05:53:28 +00:00
INSTALL Updated. 2005-03-13 09:16:26 +00:00
LICENSE Switched to zlib license. 2003-07-20 20:57:55 +00:00
Makefile.am.newautomake Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
Makefile.am.oldautomake Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
TODO Updated. 2005-03-16 13:10:40 +00:00
acconfig.h Westwood MIX archive support. 2004-04-09 06:36:09 +00:00
bootstrap MacOS X build compatibility. 2004-04-09 06:35:49 +00:00
configure.in Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
makeos2.cmd Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
physfs.c Builds on Mac Classic again. 2005-03-14 12:05:07 +00:00
physfs.dsp Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
physfs.h All memory management now goes through allocation hooks instead of directly to 2005-03-14 11:49:30 +00:00
physfs.spec.in Added zlib_license_change.txt to RPM spec (thanks, Edward!) 2003-12-19 01:49:12 +00:00
physfs.vcproj Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
physfsMPW.make Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
physfs_byteorder.c MacOS Classic fixes and MPW support (thanks, Chris!). 2005-03-16 11:42:54 +00:00
physfs_internal.h Added translation for WAD file type. 2005-03-16 11:27:31 +00:00
physfs_static.dsp Updated zlib to 1.2.2. 2005-07-13 15:06:21 +00:00
test_physfs.dsp Initial add. 2002-06-11 01:17:13 +00:00
test_physfs.vcproj Initial add. 2002-08-28 23:30:26 +00:00
zlib_license_change.txt Updated. 2003-07-21 04:01:10 +00:00