From b04887ae1a6afe7dffdfbf6e18cb0c38c515a63d Mon Sep 17 00:00:00 2001
From: Carlos Alberto Lopez Perez <clopez@igalia.com>
Date: Thu, 14 May 2015 21:37:15 +0200
Subject: [PATCH] Some fixes for the --mini option.

 * Don't fetch speedtest.net configs when using a custom mini server.
   It don't makes sense and slows down the whole thing.

 * Add a mising decode() in the variable data, and set both decodes()
   to ignore encoding errors.
---
 speedtest_cli.py | 70 +++++++++++++++++++++++++-----------------------
 1 file changed, 36 insertions(+), 34 deletions(-)

diff --git a/speedtest_cli.py b/speedtest_cli.py
index 2beeb35..6780234 100755
--- a/speedtest_cli.py
+++ b/speedtest_cli.py
@@ -568,39 +568,41 @@ def speedtest():
         source = args.source
         socket.socket = bound_socket
 
-    if not args.simple:
-        print_('Retrieving speedtest.net configuration...')
-    try:
-        config = getConfig()
-    except URLError:
-        print_('Cannot retrieve speedtest configuration')
-        sys.exit(1)
+    if not args.mini:
+        if not args.simple:
+            print_('Retrieving speedtest.net configuration...')
+        try:
+            config = getConfig()
+        except URLError:
+            print_('Cannot retrieve speedtest configuration')
+            sys.exit(1)
 
-    if not args.simple:
-        print_('Retrieving speedtest.net server list...')
-    if args.list or args.server:
-        servers = closestServers(config['client'], True)
-        if args.list:
-            serverList = []
-            for server in servers:
-                line = ('%(id)4s) %(sponsor)s (%(name)s, %(country)s) '
-                        '[%(d)0.2f km]' % server)
-                serverList.append(line)
-            # Python 2.7 and newer seem to be ok with the resultant encoding
-            # from parsing the XML, but older versions have some issues.
-            # This block should detect whether we need to encode or not
-            try:
-                unicode()
-                print_('\n'.join(serverList).encode('utf-8', 'ignore'))
-            except NameError:
-                print_('\n'.join(serverList))
-            except IOError:
-                pass
-            sys.exit(0)
-    else:
-        servers = closestServers(config['client'])
+    if not args.mini:
+        if not args.simple:
+            print_('Retrieving speedtest.net server list...')
+        if args.list or args.server:
+            servers = closestServers(config['client'], True)
+            if args.list:
+                serverList = []
+                for server in servers:
+                    line = ('%(id)4s) %(sponsor)s (%(name)s, %(country)s) '
+                            '[%(d)0.2f km]' % server)
+                    serverList.append(line)
+                # Python 2.7 and newer seem to be ok with the resultant encoding
+                # from parsing the XML, but older versions have some issues.
+                # This block should detect whether we need to encode or not
+                try:
+                    unicode()
+                    print_('\n'.join(serverList).encode('utf-8', 'ignore'))
+                except NameError:
+                    print_('\n'.join(serverList))
+                except IOError:
+                    pass
+                sys.exit(0)
+        else:
+            servers = closestServers(config['client'])
 
-    if not args.simple:
+    if not args.simple and not args.mini:
         print_('Testing from %(isp)s (%(ip)s)...' % config['client'])
 
     if args.server:
@@ -624,9 +626,9 @@ def speedtest():
             print_('Invalid Speedtest Mini URL')
             sys.exit(1)
         else:
-            text = f.read()
+            text = f.read().decode(errors="ignore")
             f.close()
-        extension = re.findall('upload_extension: "([^"]+)"', text.decode())
+        extension = re.findall('upload_extension: "([^"]+)"', text)
         if not extension:
             for ext in ['php', 'asp', 'aspx', 'jsp']:
                 try:
@@ -636,7 +638,7 @@ def speedtest():
                 except:
                     pass
                 else:
-                    data = f.read().strip()
+                    data = f.read().decode(errors="ignore").strip()
                     if (f.code == 200 and
                             len(data.splitlines()) == 1 and
                             re.match('size=[0-9]', data)):