From c512684ffa2c1ceda07017867c8005a8943dd119 Mon Sep 17 00:00:00 2001 From: Matt Martz Date: Fri, 11 Nov 2016 10:00:24 -0600 Subject: [PATCH] Don't use mutable defaults as args for methods --- speedtest.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/speedtest.py b/speedtest.py index 0d2ea7d..c6d2139 100755 --- a/speedtest.py +++ b/speedtest.py @@ -779,10 +779,13 @@ class Speedtest(object): return self.config - def get_servers(self, servers=[]): + def get_servers(self, servers=None): """Retrieve a the list of speedtest.net servers, optionally filtered to servers matching those specified in the ``servers`` argument """ + if servers is None: + servers = [] + self.servers.clear() for i, s in enumerate(servers): @@ -951,7 +954,7 @@ class Speedtest(object): printer(self.closest, debug=True) return self.closest - def get_best_server(self, servers=[]): + def get_best_server(self, servers=None): """Perform a speedtest.net "ping" to determine which speedtest.net server has the lowest latency """