From 0910cd3db6bb5fba6070a1fef693462506f39e57 Mon Sep 17 00:00:00 2001 From: Guus Sliepen Date: Wed, 24 Aug 2011 14:42:59 +0200 Subject: [PATCH] Add const to all char * function parameters. --- code/ai.h | 2 +- code/aliens.h | 6 +++--- code/audio.cpp | 4 ++-- code/audio.h | 2 +- code/bullets.h | 4 ++-- code/cargo.h | 2 +- code/classes.h | 16 ++++++++-------- code/collectable.h | 2 +- code/comms.h | 4 ++-- code/events.cpp | 2 +- code/graphics.cpp | 2 +- code/graphics.h | 4 ++-- code/init.cpp | 2 +- code/init.h | 4 ++-- code/intermission.h | 10 +++++----- code/messages.cpp | 4 ++-- code/messages.h | 2 +- code/misc.cpp | 6 +++--- code/missions.h | 10 +++++----- code/player.h | 6 +++--- code/resources.cpp | 2 +- code/resources.h | 8 ++++---- code/script.h | 8 ++++---- code/shop.h | 2 +- code/title.h | 10 +++++----- code/unpack.cpp | 4 ++-- code/unpack.h | 2 +- code/weapons.h | 2 +- 28 files changed, 66 insertions(+), 66 deletions(-) diff --git a/code/ai.h b/code/ai.h index a6190ab..4baaa68 100644 --- a/code/ai.h +++ b/code/ai.h @@ -30,7 +30,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern void setRadioMessage(signed char face, char *in, int priority); +extern void setRadioMessage(signed char face, const char *in, int priority); extern object enemy[MAX_ALIENS]; extern object player; diff --git a/code/aliens.h b/code/aliens.h index 2507dc7..dbf94d4 100644 --- a/code/aliens.h +++ b/code/aliens.h @@ -38,13 +38,13 @@ extern void addEngine(object *craft); extern void fireRay(object *attacker); extern void addDebris(int x, int y, int amount); extern void playSound(int sid); -extern int locateDataInPak(char *file, signed char required); +extern int locateDataInPak(const char *file, signed char required); extern object *addCargo(object *owner, int cargoType); extern void addCollectable(float x, float y, int type, int value, int life); extern void updateMissionRequirements(int type, int id, int value); -extern void setInfoLine(char *in, int color); +extern void setInfoLine(const char *in, int color); extern void addBullet(object *theWeapon, object *attacker, int y, int dy); -extern void showErrorAndExit(int errorId, char *name); +extern void showErrorAndExit(int errorId, const char *name); extern globalEngineVariables engine; extern devVariables dev; diff --git a/code/audio.cpp b/code/audio.cpp index 46d5b4a..ec1c27c 100644 --- a/code/audio.cpp +++ b/code/audio.cpp @@ -56,7 +56,7 @@ void playSound(int sid) } } -Mix_Chunk *loadSound(char *filename) +Mix_Chunk *loadSound(const char *filename) { Mix_Chunk *chunk; @@ -70,7 +70,7 @@ Mix_Chunk *loadSound(char *filename) return chunk; } -void loadMusic(char *filename) +void loadMusic(const char *filename) { if (Mix_PlayingMusic()) Mix_HaltMusic(); diff --git a/code/audio.h b/code/audio.h index cd4a0eb..f2a73be 100644 --- a/code/audio.h +++ b/code/audio.h @@ -28,7 +28,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "defs.h" #include "structs.h" -extern void unpack(char *file, signed char fileType); +extern void unpack(const char *file, signed char fileType); extern void freePackBuffer(); extern globalEngineVariables engine; diff --git a/code/bullets.h b/code/bullets.h index 566aa5d..21b1b04 100644 --- a/code/bullets.h +++ b/code/bullets.h @@ -35,13 +35,13 @@ extern void updateMissionRequirements(int type, int id, int value); extern void addCollectable(float x, float y, int type, int value, int life); extern void addExplosion(float x, float y, int type); extern void generateShockWave(object *bullet); -extern void setInfoLine(char *in, int color); +extern void setInfoLine(const char *in, int color); extern void getKillMessage(object *ally); extern void getMissFireMessage(object *ally); extern void getPlayerHitMessage(object *ally); extern void checkMineBulletCollisions(object *bullet); extern void setKlineAttackMethod(object *theEnemy); -extern void setRadioMessage(signed char face, char *in, int priority); +extern void setRadioMessage(signed char face, const char *in, int priority); extern globalEngineVariables engine; extern devVariables dev; diff --git a/code/cargo.h b/code/cargo.h index 7dbc183..60012f7 100644 --- a/code/cargo.h +++ b/code/cargo.h @@ -30,7 +30,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "classes.h" extern void addCollectable(float x, float y, int type, int value, int life); -extern void setRadioMessage(signed char face, char *in, int priority); +extern void setRadioMessage(signed char face, const char *in, int priority); extern globalEngineVariables engine; extern Game currentGame; diff --git a/code/classes.h b/code/classes.h index 65a6486..ee90c15 100644 --- a/code/classes.h +++ b/code/classes.h @@ -18,7 +18,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -extern void showErrorAndExit(int errorId, char *name); +extern void showErrorAndExit(int errorId, const char *name); class Collision { @@ -333,7 +333,7 @@ class Graphics { In 16 bit mode this is slow. VERY slow. Don't write directly to a surface that constantly needs updating (eg - the main game screen) */ - int renderString(char *in, int x, int y, int fontColor, signed char wrap, SDL_Surface *dest) + int renderString(const char *in, int x, int y, int fontColor, signed char wrap, SDL_Surface *dest) { SDL_Rect area; area.x = x; @@ -379,7 +379,7 @@ class Graphics { return area.y; } - int drawString(char *in, int x, int y, int fontColor, signed char wrap, SDL_Surface *dest) + int drawString(const char *in, int x, int y, int fontColor, signed char wrap, SDL_Surface *dest) { renderString(in, x, y - 1, FONT_OUTLINE, wrap, dest); renderString(in, x, y + 1, FONT_OUTLINE, wrap, dest); @@ -390,14 +390,14 @@ class Graphics { return renderString(in, x, y, fontColor, wrap, dest); } - int drawString(char *in, int x, int y, int fontColor, SDL_Surface *dest) + int drawString(const char *in, int x, int y, int fontColor, SDL_Surface *dest) { if (x == -1) x = (dest->w - (strlen(in) * 9)) / 2; return drawString(in, x, y, fontColor, 0, dest); } - int drawString(char *in, int x, int y, int fontColor) + int drawString(const char *in, int x, int y, int fontColor) { if (x == -1) x = (800 - (strlen(in) * 9)) / 2; @@ -619,7 +619,7 @@ class Graphics { return newImage; } - SDL_Surface *textSurface(char *inString, int color) + SDL_Surface *textSurface(const char *inString, int color) { SDL_Surface *surface = createSurface(strlen(inString) * 9, 16); @@ -628,7 +628,7 @@ class Graphics { return setTransparent(surface); } - void textSurface(int index, char *inString, int x, int y, int fontColor) + void textSurface(int index, const char *inString, int x, int y, int fontColor) { strcpy(textShape[index].text, inString); textShape[index].x = x; @@ -654,7 +654,7 @@ class Graphics { return surface; } - void createMessageBox(SDL_Surface *face, char *message, signed char transparent) + void createMessageBox(SDL_Surface *face, const char *message, signed char transparent) { if (messageBox != NULL) { diff --git a/code/collectable.h b/code/collectable.h index 45e4749..aaf7fa4 100644 --- a/code/collectable.h +++ b/code/collectable.h @@ -30,7 +30,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "classes.h" extern void updateMissionRequirements(int type, int id, int value); -extern void setInfoLine(char *in, int color); +extern void setInfoLine(const char *in, int color); extern object *addCargo(object *owner, int cargoType); extern void addExplosion(float x, float y, int type); extern void playSound(int sid); diff --git a/code/comms.h b/code/comms.h index 7701843..93a1347 100644 --- a/code/comms.h +++ b/code/comms.h @@ -29,8 +29,8 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern int locateDataInPak(char *file, signed char required); -extern int getFace(char *face); +extern int locateDataInPak(const char *file, signed char required); +extern int getFace(const char *face); extern globalEngineVariables engine; extern Game currentGame; diff --git a/code/events.cpp b/code/events.cpp index a1a56e0..24286bd 100644 --- a/code/events.cpp +++ b/code/events.cpp @@ -55,7 +55,7 @@ void compareLastKeyInputs() {engine.cheatCredits = 1; memset(lastKeyEvents, ' ', 25);} } -void addKeyEvent(char *keyName) +void addKeyEvent(const char *keyName) { if (strlen(keyName) > 1) return; diff --git a/code/graphics.cpp b/code/graphics.cpp index 3b41cbc..fa90864 100644 --- a/code/graphics.cpp +++ b/code/graphics.cpp @@ -20,7 +20,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "graphics.h" -SDL_Surface *loadImage(char *filename) +SDL_Surface *loadImage(const char *filename) { SDL_Surface *image, *newImage; diff --git a/code/graphics.h b/code/graphics.h index e1ed8aa..390095f 100644 --- a/code/graphics.h +++ b/code/graphics.h @@ -29,8 +29,8 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern void unpack(char *file, signed char fileType); -extern void showErrorAndExit(int errorId, char *name); +extern void unpack(const char *file, signed char fileType); +extern void showErrorAndExit(int errorId, const char *name); extern Star star[200]; extern globalEngineVariables engine; diff --git a/code/init.cpp b/code/init.cpp index 8f9a0fd..ca45fc0 100644 --- a/code/init.cpp +++ b/code/init.cpp @@ -48,7 +48,7 @@ Something went wrong. This stops the game, present the error message and prompts the user to press space or ctrl to exit the game. This is unlikely to be seen by people unless something really stoopid happens! */ -void showErrorAndExit(int errorId, char *name) +void showErrorAndExit(int errorId, const char *name) { graphics.clearScreen(graphics.black); diff --git a/code/init.h b/code/init.h index 48b266e..96c10d9 100644 --- a/code/init.h +++ b/code/init.h @@ -40,8 +40,8 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. extern void freeSound(); extern void resetLists(); extern void getPlayerInput(); -extern void drawString(char *in, int x, int y, int fontColor); -extern SDL_Surface *loadImage(char *filename); +extern void drawString(const char *in, int x, int y, int fontColor); +extern SDL_Surface *loadImage(const char *filename); extern globalEngineVariables engine; extern Game currentGame; diff --git a/code/intermission.h b/code/intermission.h index abb8582..4b4c47f 100644 --- a/code/intermission.h +++ b/code/intermission.h @@ -30,7 +30,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern SDL_Surface *loadImage(char *filename); +extern SDL_Surface *loadImage(const char *filename); extern void doStarfield(); extern void getPlayerInput(); extern void showShop(); @@ -38,15 +38,15 @@ extern void initShop(); extern int initSaveSlots(); extern int showSaveSlots(SDL_Surface *savesSurface, signed char saveSlot); extern void saveGame(int slot); -extern void loadMusic(char *filename); -extern void loadBackground(char *filename); +extern void loadMusic(const char *filename); +extern void loadBackground(const char *filename); extern void createCommsSurface(SDL_Surface *comms); extern void updateCommsSurface(SDL_Surface *comms); extern void createSavesSurface(SDL_Surface *savesSurface, signed char clickedSlot); extern void checkForBossMission(); extern void doComms(SDL_Surface *comms); -extern int locateDataInPak(char *file, signed char required); -extern int getFace(char *face); +extern int locateDataInPak(const char *file, signed char required); +extern int getFace(const char *face); extern void flushInput(); extern globalEngineVariables engine; diff --git a/code/messages.cpp b/code/messages.cpp index b01ed50..da11fe1 100644 --- a/code/messages.cpp +++ b/code/messages.cpp @@ -146,9 +146,9 @@ void getKillMessage(object *ally) setRadioMessage(faceToUse, in, 0); } -char *getKlineInsult() +const char *getKlineInsult() { - static char insult[][40] = { + static const char insult[][40] = { "Pathetic", "How very disappointing...", "Heroic. And stupid", "Fool", "And now you're nothing but a DEAD hero" }; diff --git a/code/messages.h b/code/messages.h index 2f6b8c2..ed94a58 100644 --- a/code/messages.h +++ b/code/messages.h @@ -28,7 +28,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "defs.h" #include "structs.h" -extern void setRadioMessage(signed char face, char *in, int priority); +extern void setRadioMessage(signed char face, const char *in, int priority); char killMessage[10][50]; char deathMessage[6][50]; diff --git a/code/misc.cpp b/code/misc.cpp index ec3b8b9..2c129e9 100644 --- a/code/misc.cpp +++ b/code/misc.cpp @@ -41,7 +41,7 @@ string and colors. It will set the information to the first free infoline it finds (top to bottom). If it doesn't find any free ones, it will push all the other info lines down one and add itself to the top. */ -void setInfoLine(char *in, int color) +void setInfoLine(const char *in, int color) { int index = -1; @@ -70,7 +70,7 @@ Sets a radio message that appears at the top of the screen. Used for script events, etc. We send a message priority too, since we don't want Phoebe or Ursula's banter to interrupt an important message */ -void setRadioMessage(signed char face, char *in, int priority) +void setRadioMessage(signed char face, const char *in, int priority) { if ((graphics.textShape[3].life > 0) && (priority == 0)) return; @@ -400,7 +400,7 @@ void doInfo() } } -int getFace(char *face) +int getFace(const char *face) { for (int i = 0 ; i < 7 ; i++) { diff --git a/code/missions.h b/code/missions.h index 1f69128..6c64422 100644 --- a/code/missions.h +++ b/code/missions.h @@ -29,16 +29,16 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern SDL_Surface *loadImage(char *file_name); +extern SDL_Surface *loadImage(const char *file_name); extern void playRandomTrack(); extern void getPlayerInput(); -extern void setInfoLine(char *in, int color); +extern void setInfoLine(const char *in, int color); extern void loadGameGraphics(); extern void killAllAliens(); -extern int locateDataInPak(char *file, signed char required); -extern void setRadioMessage(signed char face, char *in, int priority); +extern int locateDataInPak(const char *file, signed char required); +extern void setRadioMessage(signed char face, const char *in, int priority); extern void syncScriptEvents(); -extern void loadMusic(char *filename); +extern void loadMusic(const char *filename); extern void setTarget(int index); extern void flushInput(); diff --git a/code/player.h b/code/player.h index d06984f..15770c8 100644 --- a/code/player.h +++ b/code/player.h @@ -33,10 +33,10 @@ extern void fireBullet(object *attacker, int weaponType); extern void addExplosion(float x, float y, int type); extern void playSound(int sid); extern void addEngine(object *craft); -extern void addKeyEvent(char *keyName); +extern void addKeyEvent(const char *keyName); extern void addDebris(int x, int y, int amount); -extern void setRadioMessage(signed char face, char *in, int priority); -extern void setInfoLine(char *in, int color); +extern void setRadioMessage(signed char face, const char *in, int priority); +extern void setInfoLine(const char *in, int color); extern void getPlayerDeathMessage(); extern void playSound(int sid); extern void setTarget(int index); diff --git a/code/resources.cpp b/code/resources.cpp index 8c24121..3ffe902 100644 --- a/code/resources.cpp +++ b/code/resources.cpp @@ -20,7 +20,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "resources.h" -void loadBackground(char *filename) +void loadBackground(const char *filename) { if (graphics.background != NULL) { diff --git a/code/resources.h b/code/resources.h index 913ec86..15f693f 100644 --- a/code/resources.h +++ b/code/resources.h @@ -29,10 +29,10 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern void unpack(char *file, signed char fileType); -extern SDL_Surface *loadImage(char *filename); -extern Mix_Chunk *loadSound(char *filename); -extern int locateDataInPak(char *file, signed char required); +extern void unpack(const char *file, signed char fileType); +extern SDL_Surface *loadImage(const char *filename); +extern Mix_Chunk *loadSound(const char *filename); +extern int locateDataInPak(const char *file, signed char required); extern void setAlienShapes(); extern void setWeaponShapes(); extern void loadGameGraphics(); diff --git a/code/script.h b/code/script.h index f1f3f1e..7ffc1c9 100644 --- a/code/script.h +++ b/code/script.h @@ -32,14 +32,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. extern void doStarfield(); extern void getPlayerInput(); extern void loadGameGraphics(); -extern void loadBackground(char *filename); -extern void setRadioMessage(signed char face, char *in, int priority); +extern void loadBackground(const char *filename); +extern void setRadioMessage(signed char face, const char *in, int priority); extern void doExplosions(); extern void addEngine(object *craft); extern void doExplosions(); extern void resetLists(); -extern int getFace(char *face); -extern int locateDataInPak(char *file, signed char required); +extern int getFace(const char *face); +extern int locateDataInPak(const char *file, signed char required); extern void flushInput(); extern Game currentGame; diff --git a/code/shop.h b/code/shop.h index 886d74e..d8f4b58 100644 --- a/code/shop.h +++ b/code/shop.h @@ -29,7 +29,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern int locateDataInPak(char *file, signed char required); +extern int locateDataInPak(const char *file, signed char required); extern object player; extern globalEngineVariables engine; diff --git a/code/title.h b/code/title.h index b2462fc..3dfd272 100644 --- a/code/title.h +++ b/code/title.h @@ -29,9 +29,9 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern SDL_Surface *loadImage(char *filename); -extern void unpack(char *file); -extern void loadMusic(char *filename); +extern SDL_Surface *loadImage(const char *filename); +extern void unpack(const char *file); +extern void loadMusic(const char *filename); extern void doStarfield(); extern void doExplosions(); extern void addEngine(object *craft); @@ -41,9 +41,9 @@ extern signed char loadGame(int slot); extern int initSaveSlots(); extern void newGame(); extern void loadGameGraphics(); -extern void loadBackground(char *filename); +extern void loadBackground(const char *filename); extern void doCredits(); -extern int locateDataInPak(char *file, signed char required); +extern int locateDataInPak(const char *file, signed char required); extern void flushInput(); extern globalEngineVariables engine; diff --git a/code/unpack.cpp b/code/unpack.cpp index 963ee5b..775f3f2 100644 --- a/code/unpack.cpp +++ b/code/unpack.cpp @@ -24,7 +24,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. Searches the pak file for the required data. When it is found, the data is read into a character buffer. */ -void unpack(char *file, signed char fileType) +void unpack(const char *file, signed char fileType) { unsigned char *packBuffer; char packFilename[60]; @@ -105,7 +105,7 @@ void unpack(char *file, signed char fileType) Search the data package for the required file. When it is found, return the location. */ -int locateDataInPak(char *file, signed char required) +int locateDataInPak(const char *file, signed char required) { //printf("Looking for %s...", file); diff --git a/code/unpack.h b/code/unpack.h index 899b58f..a7a24bc 100644 --- a/code/unpack.h +++ b/code/unpack.h @@ -30,6 +30,6 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "defs.h" #include "structs.h" -extern void showErrorAndExit(int errorId, char *name); +extern void showErrorAndExit(int errorId, const char *name); extern globalEngineVariables engine; diff --git a/code/weapons.h b/code/weapons.h index f0a596d..283756d 100644 --- a/code/weapons.h +++ b/code/weapons.h @@ -29,7 +29,7 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. #include "structs.h" #include "classes.h" -extern int locateDataInPak(char *file, signed char required); +extern int locateDataInPak(const char *file, signed char required); extern Graphics graphics; extern object weapon[MAX_WEAPONS];