From cbdbf94498c9cd535634ed0172f878d9541db209 Mon Sep 17 00:00:00 2001 From: Julie Marchant Date: Sat, 21 Apr 2018 10:44:33 -0400 Subject: [PATCH] Replaced some uses of sprintf with snprintf. --- src/engine.cpp | 12 ++++++------ src/engine.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/engine.cpp b/src/engine.cpp index 1904ea5..9584f53 100644 --- a/src/engine.cpp +++ b/src/engine.cpp @@ -174,25 +174,25 @@ void engine_setupConfigDirectory() strcpy(dir, ""); - sprintf(dir, "%s/.config", userHome); + snprintf(dir, PATH_MAX, "%s/.config", userHome); #ifdef _WIN32 if ((mkdir(dir) != 0) && (errno != EEXIST)) engine_showError(2, dir); - sprintf(dir, "%s/.config/starfighter", userHome); + snprintf(dir, PATH_MAX, "%s/.config/starfighter", userHome); if ((mkdir(dir) != 0) && (errno != EEXIST)) engine_showError(2, dir); #else if ((mkdir(dir, S_IRWXU|S_IRWXG|S_IROTH|S_IXOTH) != 0) && (errno != EEXIST)) engine_showError(2, dir); - sprintf(dir, "%s/.config/starfighter", userHome); + snprintf(dir, PATH_MAX, "%s/.config/starfighter", userHome); if ((mkdir(dir, S_IRWXU|S_IRWXG|S_IROTH|S_IXOTH) != 0) && (errno != EEXIST)) engine_showError(2, dir); #endif - sprintf(engine.configDirectory, "%s/.config/starfighter/", userHome); + snprintf(engine.configDirectory, PATH_MAX, "%s/.config/starfighter/", userHome); } /* @@ -218,7 +218,7 @@ void engine_setMode() int autoPause = 0; FILE *fp; - sprintf(filename, "%sconf", engine.configDirectory); + snprintf(filename, PATH_MAX, "%sconf", engine.configDirectory); fp = fopen(filename, "r"); if (fp != NULL) @@ -382,7 +382,7 @@ void engine_cleanup() // Save the config using current settings FILE *fp; - sprintf(filename, "%sconf", engine.configDirectory); + snprintf(filename, PATH_MAX, "%sconf", engine.configDirectory); fp = fopen(filename, "w"); if (fp != NULL) { diff --git a/src/engine.h b/src/engine.h index d241923..574ffde 100644 --- a/src/engine.h +++ b/src/engine.h @@ -91,7 +91,7 @@ typedef struct Engine_ { int fullScreen; int autoPause; - char configDirectory[1024]; + char configDirectory[PATH_MAX]; char keyState[KEY_LAST];