2009-01-31 19:24:48 +01:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2010-04-13 21:23:17 +02:00
|
|
|
* Copyright (C) 2007-2010 Daniel Marjamäki and Cppcheck team.
|
2009-01-31 19:24:48 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
2009-09-27 17:08:31 +02:00
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2009-01-31 19:24:48 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
2009-10-25 12:49:06 +01:00
|
|
|
#include "tokenize.h"
|
|
|
|
#include "checkdangerousfunctions.h"
|
2009-01-31 19:24:48 +01:00
|
|
|
#include "testsuite.h"
|
|
|
|
|
|
|
|
#include <sstream>
|
|
|
|
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
|
|
|
|
class TestDangerousFunctions : public TestFixture
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
TestDangerousFunctions() : TestFixture("TestDangerousFunctions")
|
|
|
|
{ }
|
|
|
|
|
|
|
|
private:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void check(const char code[])
|
|
|
|
{
|
|
|
|
// Tokenize..
|
|
|
|
Tokenizer tokenizer;
|
|
|
|
std::istringstream istr(code);
|
|
|
|
tokenizer.tokenize(istr, "test.cpp");
|
|
|
|
tokenizer.simplifyTokenList();
|
|
|
|
|
|
|
|
// Assign variable ids
|
|
|
|
tokenizer.setVarId();
|
|
|
|
|
|
|
|
// Fill function list
|
|
|
|
tokenizer.fillFunctionList();
|
|
|
|
|
|
|
|
// Clear the error buffer..
|
|
|
|
errout.str("");
|
|
|
|
|
2009-05-22 07:51:30 +02:00
|
|
|
// Check for dangerous functions..
|
2010-04-10 14:05:33 +02:00
|
|
|
Settings settings(Settings::testSettings());
|
2009-07-13 16:00:15 +02:00
|
|
|
CheckDangerousFunctions checkDangerousFunctions(&tokenizer, &settings, this);
|
2009-01-31 19:24:48 +01:00
|
|
|
checkDangerousFunctions.dangerousFunctions();
|
|
|
|
}
|
|
|
|
|
|
|
|
void run()
|
|
|
|
{
|
|
|
|
TEST_CASE(testmktemp);
|
|
|
|
TEST_CASE(testgets);
|
|
|
|
TEST_CASE(testscanf);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void testmktemp()
|
|
|
|
{
|
|
|
|
check("void f()\n"
|
|
|
|
"{\n"
|
|
|
|
" char *x = mktemp(\"/tmp/zxcv\");\n"
|
|
|
|
"}\n");
|
2009-05-31 21:48:55 +02:00
|
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Found 'mktemp'. You should use 'mkstemp' instead\n", errout.str());
|
2009-01-31 19:24:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void testgets()
|
|
|
|
{
|
|
|
|
check("void f()\n"
|
|
|
|
"{\n"
|
|
|
|
" char *x = gets();\n"
|
|
|
|
"}\n");
|
2009-05-31 21:48:55 +02:00
|
|
|
ASSERT_EQUALS("[test.cpp:3]: (style) Found 'gets'. You should use 'fgets' instead\n", errout.str());
|
2009-01-31 19:24:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void testscanf()
|
|
|
|
{
|
|
|
|
check("void f()\n"
|
|
|
|
"{\n"
|
|
|
|
" char *x;\n"
|
2009-01-31 19:54:34 +01:00
|
|
|
" scanf(\"%s\", x);\n"
|
2009-01-31 19:24:48 +01:00
|
|
|
"}\n");
|
2009-05-31 21:48:55 +02:00
|
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) Found 'scanf'. You should use 'fgets' instead\n", errout.str());
|
2009-01-31 19:24:48 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
};
|
|
|
|
|
|
|
|
REGISTER_TEST(TestDangerousFunctions)
|
|
|
|
|
|
|
|
|