2009-01-31 20:29:27 +01:00
|
|
|
/*
|
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2009-05-30 07:48:12 +02:00
|
|
|
* Copyright (C) 2007-2009 Daniel Marjamäki and Cppcheck team.
|
2009-01-31 20:29:27 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
2009-09-27 17:08:31 +02:00
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
2009-01-31 20:29:27 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#ifndef CheckOtherH
|
|
|
|
#define CheckOtherH
|
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
|
2009-03-20 18:16:21 +01:00
|
|
|
#include "check.h"
|
|
|
|
#include "settings.h"
|
2009-01-31 20:29:27 +01:00
|
|
|
|
2009-03-20 18:16:21 +01:00
|
|
|
class Token;
|
|
|
|
|
2009-07-17 10:49:01 +02:00
|
|
|
/// @addtogroup Checks
|
|
|
|
/// @{
|
|
|
|
|
2009-03-20 18:16:21 +01:00
|
|
|
class CheckOther : public Check
|
2009-01-31 20:29:27 +01:00
|
|
|
{
|
|
|
|
public:
|
2009-03-21 07:53:23 +01:00
|
|
|
/** This constructor is used when registering the CheckClass */
|
2009-03-20 18:16:21 +01:00
|
|
|
CheckOther() : Check()
|
|
|
|
{ }
|
|
|
|
|
2009-03-21 07:53:23 +01:00
|
|
|
/** This constructor is used when running checks.. */
|
2009-03-20 18:16:21 +01:00
|
|
|
CheckOther(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
|
|
|
: Check(tokenizer, settings, errorLogger)
|
|
|
|
{ }
|
|
|
|
|
|
|
|
|
|
|
|
void runChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
2009-03-21 07:53:23 +01:00
|
|
|
{
|
|
|
|
CheckOther checkOther(tokenizer, settings, errorLogger);
|
2009-03-27 15:55:14 +01:00
|
|
|
|
2009-09-29 15:38:05 +02:00
|
|
|
checkOther.nullPointer();
|
2009-03-27 15:55:14 +01:00
|
|
|
if (settings->_checkCodingStyle)
|
|
|
|
{
|
2009-07-05 22:16:43 +02:00
|
|
|
checkOther.warningOldStylePointerCast();
|
|
|
|
checkOther.checkUnsignedDivision();
|
|
|
|
checkOther.checkCharVariable();
|
2009-10-06 17:45:28 +02:00
|
|
|
checkOther.checkVariableScope();
|
2009-10-17 17:36:55 +02:00
|
|
|
checkOther.checkStructMemberUsage();
|
2009-03-27 15:55:14 +01:00
|
|
|
}
|
2009-03-21 07:53:23 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void runSimplifiedChecks(const Tokenizer *tokenizer, const Settings *settings, ErrorLogger *errorLogger)
|
2009-03-20 18:16:21 +01:00
|
|
|
{
|
|
|
|
CheckOther checkOther(tokenizer, settings, errorLogger);
|
|
|
|
|
|
|
|
if (settings->_checkCodingStyle)
|
|
|
|
{
|
2009-07-05 22:16:43 +02:00
|
|
|
checkOther.warningRedundantCode();
|
|
|
|
checkOther.checkConstantFunctionParameter();
|
|
|
|
checkOther.checkIncompleteStatement();
|
2009-09-08 21:41:11 +02:00
|
|
|
if (settings->_showAll)
|
|
|
|
{
|
|
|
|
checkOther.postIncrement();
|
|
|
|
}
|
2009-03-20 18:16:21 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
checkOther.strPlusChar();
|
2009-07-05 22:16:43 +02:00
|
|
|
checkOther.invalidFunctionUsage();
|
|
|
|
checkOther.checkZeroDivision();
|
2009-12-06 18:41:28 +01:00
|
|
|
|
|
|
|
// New type of check: Check execution paths
|
|
|
|
checkOther.executionPaths();
|
2009-03-20 18:16:21 +01:00
|
|
|
}
|
2009-01-31 20:29:27 +01:00
|
|
|
|
2010-01-11 22:28:07 +01:00
|
|
|
|
|
|
|
// TODO move CheckUninitVar?
|
|
|
|
static void analyseFunctions(const Token * const tokens, std::set<std::string> &func);
|
|
|
|
|
|
|
|
|
2009-01-31 20:29:27 +01:00
|
|
|
// Casting
|
2009-07-05 22:16:43 +02:00
|
|
|
void warningOldStylePointerCast();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Redundant code
|
2009-07-05 22:16:43 +02:00
|
|
|
void warningRedundantCode();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Invalid function usage..
|
2009-07-05 22:16:43 +02:00
|
|
|
void invalidFunctionUsage();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Check for unsigned division that might create bad results
|
2009-07-05 22:16:43 +02:00
|
|
|
void checkUnsignedDivision();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Check scope of variables
|
2009-07-05 22:16:43 +02:00
|
|
|
void checkVariableScope();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Check for constant function parameter
|
2009-07-05 22:16:43 +02:00
|
|
|
void checkConstantFunctionParameter();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Check that all struct members are used
|
2009-07-05 22:16:43 +02:00
|
|
|
void checkStructMemberUsage();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Using char variable as array index / as operand in bit operation
|
2009-07-05 22:16:43 +02:00
|
|
|
void checkCharVariable();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Incomplete statement. A statement that only contains a constant or variable
|
2009-07-05 22:16:43 +02:00
|
|
|
void checkIncompleteStatement();
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
/** str plus char */
|
|
|
|
void strPlusChar();
|
|
|
|
|
2009-03-27 17:19:34 +01:00
|
|
|
/** possible null pointer dereference */
|
|
|
|
void nullPointer();
|
|
|
|
|
2009-12-06 18:41:28 +01:00
|
|
|
/** new type of check: check execution paths */
|
|
|
|
void executionPaths();
|
2009-10-29 21:34:43 +01:00
|
|
|
|
2009-03-28 07:49:47 +01:00
|
|
|
/** Check zero division*/
|
2009-07-05 22:16:43 +02:00
|
|
|
void checkZeroDivision();
|
2009-03-28 07:49:47 +01:00
|
|
|
|
2009-07-25 00:36:15 +02:00
|
|
|
/** Check for post increment/decrement in for loop*/
|
|
|
|
void postIncrement();
|
|
|
|
|
2009-07-05 22:16:43 +02:00
|
|
|
void lookupVar(const Token *tok1, const char varname[]);
|
2009-01-31 20:29:27 +01:00
|
|
|
|
|
|
|
// Redundant condition
|
|
|
|
// if (haystack.find(needle) != haystack.end())
|
|
|
|
// haystack.remove(needle);
|
|
|
|
void redundantCondition2();
|
2009-03-21 17:58:13 +01:00
|
|
|
|
2009-10-29 21:34:43 +01:00
|
|
|
|
2009-03-21 17:58:13 +01:00
|
|
|
// Error messages..
|
|
|
|
void cstyleCastError(const Token *tok);
|
|
|
|
void redundantIfDelete0Error(const Token *tok);
|
|
|
|
void redundantIfRemoveError(const Token *tok);
|
|
|
|
void dangerousUsageStrtolError(const Token *tok);
|
|
|
|
void sprintfOverlappingDataError(const Token *tok, const std::string &varname);
|
|
|
|
void udivError(const Token *tok);
|
|
|
|
void udivWarning(const Token *tok);
|
|
|
|
void unusedStructMemberError(const Token *tok, const std::string &structname, const std::string &varname);
|
|
|
|
void passedByValueError(const Token *tok, const std::string &parname);
|
|
|
|
void constStatementError(const Token *tok, const std::string &type);
|
|
|
|
void charArrayIndexError(const Token *tok);
|
|
|
|
void charBitOpError(const Token *tok);
|
|
|
|
void variableScopeError(const Token *tok, const std::string &varname);
|
|
|
|
void conditionAlwaysTrueFalse(const Token *tok, const std::string &truefalse);
|
|
|
|
void strPlusChar(const Token *tok);
|
2009-12-30 17:42:41 +01:00
|
|
|
void nullPointerError(const Token *tok); // variable name unknown / doesn't exist
|
2009-08-11 17:18:01 +02:00
|
|
|
void nullPointerError(const Token *tok, const std::string &varname);
|
2009-08-21 12:42:40 +02:00
|
|
|
void nullPointerError(const Token *tok, const std::string &varname, const int line);
|
2010-02-05 17:35:18 +01:00
|
|
|
void uninitstringError(const Token *tok, const std::string &varname);
|
2009-11-07 09:10:15 +01:00
|
|
|
void uninitdataError(const Token *tok, const std::string &varname);
|
2009-10-29 21:34:43 +01:00
|
|
|
void uninitvarError(const Token *tok, const std::string &varname);
|
2009-03-29 18:47:05 +02:00
|
|
|
void zerodivError(const Token *tok);
|
2009-07-25 00:36:15 +02:00
|
|
|
void postIncrementError(const Token *tok, const std::string &var_name, const bool isIncrement);
|
2009-03-21 17:58:13 +01:00
|
|
|
|
2009-03-22 08:20:15 +01:00
|
|
|
void getErrorMessages()
|
|
|
|
{
|
2009-10-04 13:46:37 +02:00
|
|
|
// error
|
|
|
|
sprintfOverlappingDataError(0, "varname");
|
|
|
|
udivError(0);
|
|
|
|
nullPointerError(0, "pointer");
|
2010-02-05 17:35:18 +01:00
|
|
|
uninitstringError(0, "varname");
|
2009-11-07 09:10:15 +01:00
|
|
|
uninitdataError(0, "varname");
|
2009-10-29 21:34:43 +01:00
|
|
|
uninitvarError(0, "varname");
|
2009-10-04 13:46:37 +02:00
|
|
|
zerodivError(0);
|
|
|
|
|
|
|
|
// style
|
2009-03-22 08:20:15 +01:00
|
|
|
cstyleCastError(0);
|
|
|
|
redundantIfDelete0Error(0);
|
|
|
|
redundantIfRemoveError(0);
|
|
|
|
dangerousUsageStrtolError(0);
|
|
|
|
udivWarning(0);
|
2009-08-11 17:18:01 +02:00
|
|
|
unusedStructMemberError(0, "structname", "variable");
|
|
|
|
passedByValueError(0, "parametername");
|
2009-03-22 08:20:15 +01:00
|
|
|
constStatementError(0, "type");
|
|
|
|
charArrayIndexError(0);
|
|
|
|
charBitOpError(0);
|
|
|
|
variableScopeError(0, "varname");
|
|
|
|
conditionAlwaysTrueFalse(0, "true/false");
|
|
|
|
strPlusChar(0);
|
2009-10-04 13:46:37 +02:00
|
|
|
|
|
|
|
// optimisations
|
2009-07-25 00:36:15 +02:00
|
|
|
postIncrementError(0, "varname", true);
|
2009-03-22 08:20:15 +01:00
|
|
|
}
|
|
|
|
|
2009-06-12 15:20:08 +02:00
|
|
|
std::string name() const
|
|
|
|
{
|
|
|
|
return "Other";
|
|
|
|
}
|
|
|
|
|
2009-06-12 12:19:37 +02:00
|
|
|
std::string classInfo() const
|
|
|
|
{
|
|
|
|
return "Other checks\n"
|
2009-10-04 13:46:37 +02:00
|
|
|
|
|
|
|
// error
|
2010-01-17 14:56:56 +01:00
|
|
|
"* [[OverlappingData|bad usage of the function 'sprintf' (overlapping data)]]\n"
|
|
|
|
"* division with zero\n"
|
|
|
|
"* null pointer dereferencing\n"
|
|
|
|
"* using uninitialized variables and data\n"
|
2009-10-04 13:46:37 +02:00
|
|
|
|
2009-10-29 21:34:43 +01:00
|
|
|
// style
|
2010-01-17 14:56:56 +01:00
|
|
|
"* C-style pointer cast in cpp file\n"
|
|
|
|
"* redundant if\n"
|
|
|
|
"* bad usage of the function 'strtol'\n"
|
|
|
|
"* [[CheckUnsignedDivision|unsigned division]]\n"
|
|
|
|
"* unused struct member\n"
|
|
|
|
"* passing parameter by value\n"
|
|
|
|
"* [[IncompleteStatement|Incomplete statement]]\n"
|
|
|
|
"* [[charvar|check how signed char variables are used]]\n"
|
|
|
|
"* variable scope can be limited\n"
|
|
|
|
"* condition that is always true/false\n"
|
|
|
|
"* unusal pointer arithmetic. For example: \"abc\" + 'd'\n"
|
2009-10-04 13:46:37 +02:00
|
|
|
|
|
|
|
// optimisations
|
2010-01-17 14:56:56 +01:00
|
|
|
"* optimisation: detect post increment/decrement\n";
|
2009-06-12 12:19:37 +02:00
|
|
|
}
|
2009-10-11 17:10:20 +02:00
|
|
|
|
|
|
|
private:
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Does one part of the check for nullPointer().
|
|
|
|
* Locate insufficient null-pointer handling after loop
|
|
|
|
*/
|
|
|
|
void nullPointerAfterLoop();
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Does one part of the check for nullPointer().
|
|
|
|
* looping through items in a linked list in a inner loop..
|
|
|
|
*/
|
|
|
|
void nullPointerLinkedList();
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Does one part of the check for nullPointer().
|
|
|
|
* Dereferencing a struct pointer and then checking if it's NULL..
|
|
|
|
*/
|
|
|
|
void nullPointerStructByDeRefAndChec();
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Does one part of the check for nullPointer().
|
|
|
|
* Dereferencing a pointer and then checking if it's NULL..
|
|
|
|
*/
|
|
|
|
void nullPointerByDeRefAndChec();
|
2009-10-19 17:32:43 +02:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Does one part of the check for nullPointer().
|
|
|
|
* 1. initialize pointer to 0
|
|
|
|
* 2. conditionally assign pointer
|
|
|
|
* 3. dereference pointer
|
|
|
|
*/
|
|
|
|
void nullPointerConditionalAssignment();
|
2009-01-31 20:29:27 +01:00
|
|
|
};
|
2009-07-17 10:49:01 +02:00
|
|
|
/// @}
|
2009-01-31 20:29:27 +01:00
|
|
|
//---------------------------------------------------------------------------
|
|
|
|
#endif
|
|
|
|
|