2008-12-18 22:28:57 +01:00
|
|
|
/*
|
2009-01-21 21:04:20 +01:00
|
|
|
* Cppcheck - A tool for static C/C++ code analysis
|
2009-05-30 07:48:12 +02:00
|
|
|
* Copyright (C) 2007-2009 Daniel Marjamäki and Cppcheck team.
|
2008-12-18 22:28:57 +01:00
|
|
|
*
|
|
|
|
* This program is free software: you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
2009-01-06 15:18:36 +01:00
|
|
|
#include "../src/tokenize.h"
|
|
|
|
#include "../src/checkclass.h"
|
2008-12-18 22:28:57 +01:00
|
|
|
#include "testsuite.h"
|
|
|
|
|
|
|
|
#include <sstream>
|
|
|
|
|
|
|
|
extern std::ostringstream errout;
|
|
|
|
|
|
|
|
class TestUnusedPrivateFunction : public TestFixture
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
TestUnusedPrivateFunction() : TestFixture("TestUnusedPrivateFunction")
|
|
|
|
{ }
|
|
|
|
|
|
|
|
private:
|
|
|
|
void run()
|
|
|
|
{
|
2009-01-05 16:49:57 +01:00
|
|
|
TEST_CASE(test1);
|
2009-02-25 19:03:17 +01:00
|
|
|
TEST_CASE(test2);
|
2009-03-02 18:16:02 +01:00
|
|
|
TEST_CASE(test3);
|
2009-03-02 21:40:24 +01:00
|
|
|
TEST_CASE(test4);
|
2008-12-18 22:28:57 +01:00
|
|
|
|
|
|
|
// [ 2236547 ] False positive --style unused function, called via pointer
|
2009-01-05 16:49:57 +01:00
|
|
|
TEST_CASE(func_pointer);
|
2009-04-14 21:46:13 +02:00
|
|
|
|
|
|
|
TEST_CASE(ctor);
|
2008-12-18 22:28:57 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-01-05 16:49:57 +01:00
|
|
|
void check(const char code[])
|
2008-12-18 22:28:57 +01:00
|
|
|
{
|
|
|
|
// Tokenize..
|
|
|
|
Tokenizer tokenizer;
|
|
|
|
std::istringstream istr(code);
|
2009-01-05 16:49:57 +01:00
|
|
|
tokenizer.tokenize(istr, "test.cpp");
|
2008-12-18 22:28:57 +01:00
|
|
|
|
|
|
|
// Clear the error buffer..
|
|
|
|
errout.str("");
|
|
|
|
|
|
|
|
// Check for unused private functions..
|
|
|
|
Settings settings;
|
|
|
|
settings._checkCodingStyle = true;
|
2009-03-20 17:30:24 +01:00
|
|
|
CheckClass checkClass(&tokenizer, &settings, this);
|
2008-12-20 09:48:52 +01:00
|
|
|
checkClass.privateFunctions();
|
2008-12-18 22:28:57 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void test1()
|
|
|
|
{
|
2009-01-05 16:49:57 +01:00
|
|
|
check("class Fred\n"
|
|
|
|
"{\n"
|
|
|
|
"private:\n"
|
|
|
|
" unsigned int f();\n"
|
|
|
|
"public:\n"
|
|
|
|
" Fred();\n"
|
|
|
|
"};\n"
|
|
|
|
"\n"
|
|
|
|
"Fred::Fred()\n"
|
|
|
|
"{ }\n"
|
|
|
|
"\n"
|
|
|
|
"unsigned int Fred::f()\n"
|
|
|
|
"{ }\n");
|
|
|
|
|
2009-05-31 21:48:55 +02:00
|
|
|
ASSERT_EQUALS("[test.cpp:4]: (style) Unused private function 'Fred::f'\n", errout.str());
|
2008-12-18 22:28:57 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-02-25 19:03:17 +01:00
|
|
|
void test2()
|
|
|
|
{
|
|
|
|
check("class A {\n"
|
|
|
|
"public:\n"
|
|
|
|
" A();\n"
|
|
|
|
"\n"
|
|
|
|
" void a() const\n"
|
|
|
|
" { b(); }\n"
|
|
|
|
"private:\n"
|
|
|
|
" void b( ) const\n"
|
|
|
|
" { }\n"
|
|
|
|
"};\n"
|
|
|
|
"\n"
|
|
|
|
"A::A()\n"
|
|
|
|
"{ }\n");
|
|
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-03-02 18:16:02 +01:00
|
|
|
void test3()
|
|
|
|
{
|
|
|
|
check("class A {\n"
|
|
|
|
"public:\n"
|
|
|
|
" A() { }\n"
|
|
|
|
" ~A();\n"
|
|
|
|
"private:\n"
|
|
|
|
" void B() { }\n"
|
|
|
|
"};\n"
|
|
|
|
"\n"
|
|
|
|
"A::~A()\n"
|
|
|
|
"{ B(); }\n");
|
|
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-03-02 21:40:24 +01:00
|
|
|
void test4()
|
|
|
|
{
|
|
|
|
check("class A {\n"
|
|
|
|
"public:\n"
|
|
|
|
" A();\n"
|
|
|
|
"private:\n"
|
|
|
|
" bool _owner;\n"
|
|
|
|
" void b() { }\n"
|
|
|
|
"};\n"
|
|
|
|
"\n"
|
|
|
|
"A::A() : _owner(false)\n"
|
|
|
|
"{ b(); }\n");
|
|
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-02-25 19:03:17 +01:00
|
|
|
|
2008-12-18 22:28:57 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
void func_pointer()
|
|
|
|
{
|
2009-01-05 16:49:57 +01:00
|
|
|
check("class Fred\n"
|
|
|
|
"{\n"
|
|
|
|
"private:\n"
|
|
|
|
" typedef void (*testfp)();\n"
|
|
|
|
"\n"
|
|
|
|
" testfp get()\n"
|
|
|
|
" {\n"
|
|
|
|
" return test;\n"
|
|
|
|
" }\n"
|
|
|
|
"\n"
|
|
|
|
" static void test()\n"
|
|
|
|
" { }\n"
|
|
|
|
"\n"
|
|
|
|
"public:\n"
|
|
|
|
" Fred();\n"
|
|
|
|
"};\n"
|
|
|
|
"\n"
|
|
|
|
"Fred::Fred()\n"
|
|
|
|
"{}\n");
|
|
|
|
|
2009-05-31 21:48:55 +02:00
|
|
|
ASSERT_EQUALS("[test.cpp:6]: (style) Unused private function 'Fred::get'\n", errout.str());
|
2008-12-18 22:28:57 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2009-04-14 21:46:13 +02:00
|
|
|
void ctor()
|
|
|
|
{
|
|
|
|
check("class PrivateCtor\n"
|
|
|
|
"{\n"
|
|
|
|
"private:\n"
|
|
|
|
" PrivateCtor(int threadNum) :\n"
|
|
|
|
" numOfThreads(threadNum)\n"
|
|
|
|
" {\n"
|
|
|
|
" }\n"
|
|
|
|
"\n"
|
|
|
|
" int numOfThreads;\n"
|
|
|
|
"};\n");
|
|
|
|
|
|
|
|
ASSERT_EQUALS(std::string(""), errout.str());
|
|
|
|
}
|
|
|
|
|
2008-12-18 22:28:57 +01:00
|
|
|
|
|
|
|
};
|
|
|
|
|
2009-01-05 16:49:57 +01:00
|
|
|
REGISTER_TEST(TestUnusedPrivateFunction)
|
2008-12-18 22:28:57 +01:00
|
|
|
|