walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

gui: ThreadHandler::check() remove unused parameter "all". 

Was:
threadhandler.cpp:78:58: warning: unused parameter ‘all’ [-Wunused-parameter]
 void ThreadHandler::check(const Settings &settings, bool all)
                                                          ^~~
This commit is contained in:
Matthias Krüger 2017-08-03 22:12:12 +02:00
parent 67043b3524
commit 0e40a4cc39
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gui/mainwindow.cpp
View File

@ -415,7 +415,7 @@ void MainWindow::doAnalyzeProject(ImportProject p)
if (mProjectFile) if (mProjectFile)
mThread->setAddons(mProjectFile->getAddons()); mThread->setAddons(mProjectFile->getAddons());
mThread->setProject(p); mThread->setProject(p);
mThread->check(checkSettings, true); mThread->check(checkSettings);
} }
void MainWindow::doAnalyzeFiles(const QStringList &files) void MainWindow::doAnalyzeFiles(const QStringList &files)
@ -471,7 +471,7 @@ void MainWindow::doAnalyzeFiles(const QStringList &files)
} }
mThread->setCheckFiles(true); mThread->setCheckFiles(true);
mThread->check(checkSettings, true); mThread->check(checkSettings);
} }
void MainWindow::analyzeCode(const QString& code, const QString& filename) void MainWindow::analyzeCode(const QString& code, const QString& filename)
@ -975,7 +975,7 @@ void MainWindow::reAnalyzeSelected(QStringList files, bool all)
// considered in "Modified Files Check" performed after "Selected Files Check" // considered in "Modified Files Check" performed after "Selected Files Check"
// TODO: Should we store per file CheckStartTime? // TODO: Should we store per file CheckStartTime?
QDateTime saveCheckStartTime = mThread->getCheckStartTime(); QDateTime saveCheckStartTime = mThread->getCheckStartTime();
mThread->check(getCppcheckSettings(), all); mThread->check(getCppcheckSettings());
mThread->setCheckStartTime(saveCheckStartTime); mThread->setCheckStartTime(saveCheckStartTime);
} }
@ -999,7 +999,7 @@ void MainWindow::reAnalyze(bool all)
qDebug() << "Rechecking project file" << mProjectFile->getFilename(); qDebug() << "Rechecking project file" << mProjectFile->getFilename();
mThread->setCheckFiles(all); mThread->setCheckFiles(all);
mThread->check(getCppcheckSettings(), all); mThread->check(getCppcheckSettings());
} }
void MainWindow::clearResults() void MainWindow::clearResults()

2
gui/threadhandler.cpp
View File

@ -75,7 +75,7 @@ void ThreadHandler::setCheckFiles(QStringList files)
} }
} }
void ThreadHandler::check(const Settings &settings, bool all) void ThreadHandler::check(const Settings &settings)
{ {
if (mResults.getFileCount() == 0 || mRunningThreadCount > 0 || settings.jobs == 0) { if (mResults.getFileCount() == 0 || mRunningThreadCount > 0 || settings.jobs == 0) {
qDebug() << "Can't start checking if there's no files to check or if check is in progress."; qDebug() << "Can't start checking if there's no files to check or if check is in progress.";

2
gui/threadhandler.h
View File

@ -105,7 +105,7 @@ public:
* @param settings Settings for checking * @param settings Settings for checking
* @param all true if all files, false if modified files * @param all true if all files, false if modified files
*/ */
void check(const Settings &settings, bool all); void check(const Settings &settings);
/** /**
* @brief Set files to check * @brief Set files to check