iwyu.yml: made `include-what-you-use` output more verbose / cleaned up includes (#5540)

.github/workflows/iwyu.yml

@@ -82,7 +82,7 @@ jobs:
       - name: iwyu_tool
         run: |
           PWD=$(pwd)
-          iwyu_tool -p cmake.output -j $(nproc) -- -w -Xiwyu --mapping_file=$PWD/qt5.imp > iwyu.log
+          iwyu_tool -p cmake.output -j $(nproc) -- -w -Xiwyu --max_line_length=1024 -Xiwyu --comment_style=long -Xiwyu --quoted_includes_first -Xiwyu --update_comments -Xiwyu --mapping_file=$PWD/qt5.imp > iwyu.log
 
       - uses: actions/upload-artifact@v3
         if: success() || failure()

Makefile

@@ -833,7 +833,7 @@ test/testsizeof.o: test/testsizeof.cpp lib/addoninfo.h lib/check.h lib/checksize
 test/teststl.o: test/teststl.cpp lib/addoninfo.h lib/check.h lib/checkstl.h lib/color.h lib/config.h lib/errorlogger.h lib/errortypes.h lib/importproject.h lib/library.h lib/mathlib.h lib/platform.h lib/settings.h lib/standards.h lib/suppressions.h lib/templatesimplifier.h lib/token.h lib/tokenize.h lib/tokenlist.h lib/utils.h lib/vfvalue.h test/fixture.h
 	$(CXX) ${INCLUDE_FOR_TEST} $(CPPFLAGS) $(CXXFLAGS) -c -o $@ test/teststl.cpp
 
-test/teststring.o: test/teststring.cpp externals/simplecpp/simplecpp.h lib/addoninfo.h lib/check.h lib/checkstring.h lib/color.h lib/config.h lib/errorlogger.h lib/errortypes.h lib/importproject.h lib/library.h lib/mathlib.h lib/platform.h lib/settings.h lib/standards.h lib/suppressions.h lib/templatesimplifier.h lib/token.h lib/tokenize.h lib/tokenlist.h lib/utils.h lib/vfvalue.h test/fixture.h test/helpers.h
+test/teststring.o: test/teststring.cpp lib/addoninfo.h lib/check.h lib/checkstring.h lib/color.h lib/config.h lib/errorlogger.h lib/errortypes.h lib/importproject.h lib/library.h lib/mathlib.h lib/platform.h lib/settings.h lib/standards.h lib/suppressions.h lib/templatesimplifier.h lib/token.h lib/tokenize.h lib/tokenlist.h lib/utils.h lib/vfvalue.h test/fixture.h test/helpers.h
 	$(CXX) ${INCLUDE_FOR_TEST} $(CPPFLAGS) $(CXXFLAGS) -c -o $@ test/teststring.cpp
 
 test/testsummaries.o: test/testsummaries.cpp lib/addoninfo.h lib/check.h lib/color.h lib/config.h lib/errorlogger.h lib/errortypes.h lib/importproject.h lib/library.h lib/mathlib.h lib/platform.h lib/settings.h lib/standards.h lib/summaries.h lib/suppressions.h lib/templatesimplifier.h lib/token.h lib/tokenize.h lib/tokenlist.h lib/utils.h lib/vfvalue.h test/fixture.h

cli/cppcheckexecutorsig.cpp

@@ -30,6 +30,7 @@
 #include <cstdio>
 #include <cstdlib>
 #include <cstring>
+//#include <features.h> // __USE_DYNAMIC_STACK_SIZE
 #include <map>
 #include <string>
 #include <unistd.h>
@@ -48,7 +49,7 @@
 #   include <ucontext.h>
 #endif
 
-
+// TODO: __USE_DYNAMIC_STACK_SIZE is depedent on the features.h include and not a built-in compiler define, so it might be problematic to depedent on it
 #ifdef __USE_DYNAMIC_STACK_SIZE
 static const size_t MYSTACKSIZE = 16*1024+32768; // wild guess about a reasonable buffer
 #else

gui/resultstree.cpp

@@ -23,6 +23,7 @@
 #include "common.h"
 #include "config.h"
 #include "erroritem.h"
+#include "errortypes.h"
 #include "path.h"
 #include "projectfile.h"
 #include "report.h"

gui/resultstree.h

@@ -20,7 +20,6 @@
 #ifndef RESULTSTREE_H
 #define RESULTSTREE_H
 
-#include "errortypes.h"
 #include "showtypes.h"
 
 #include <QObject>
@@ -40,6 +39,7 @@ class ThreadHandler;
 class QContextMenuEvent;
 class QKeyEvent;
 class QSettings;
+enum class Severity;
 
 /// @addtogroup GUI
 /// @{

gui/showtypes.cpp

@@ -19,6 +19,7 @@
 #include "showtypes.h"
 
 #include "common.h"
+#include "errortypes.h"
 
 #include <QSettings>
 

gui/showtypes.h

@@ -19,10 +19,10 @@
 #ifndef SHOWTYPES_H
 #define SHOWTYPES_H
 
-#include "errortypes.h"
-
 #include <QVariant>
 
+enum class Severity;
+
 /// @addtogroup GUI
 /// @{
 

lib/astutils.h

@@ -23,6 +23,7 @@
 //---------------------------------------------------------------------------
 
 #include <functional>
+#include <list>
 #include <stack>
 #include <string>
 #include <type_traits>

lib/checkio.cpp

@@ -19,6 +19,7 @@
 //---------------------------------------------------------------------------
 #include "checkio.h"
 
+#include "errortypes.h"
 #include "library.h"
 #include "mathlib.h"
 #include "platform.h"

lib/checkio.h

@@ -23,7 +23,6 @@
 
 #include "check.h"
 #include "config.h"
-#include "errortypes.h"
 #include "tokenize.h"
 
 #include <ostream>
@@ -34,6 +33,7 @@ class Settings;
 class Token;
 class Variable;
 class ErrorLogger;
+enum class Severity;
 
 /// @addtogroup Checks
 /// @{

lib/checkmemoryleak.cpp

@@ -21,6 +21,7 @@
 
 #include "astutils.h"
 #include "errorlogger.h"
+#include "errortypes.h"
 #include "library.h"
 #include "mathlib.h"
 #include "platform.h"

lib/checkmemoryleak.h

@@ -34,7 +34,6 @@
 
 #include "check.h"
 #include "config.h"
-#include "errortypes.h"
 #include "tokenize.h"
 
 #include <list>
@@ -46,6 +45,8 @@ class Settings;
 class Token;
 class Variable;
 class ErrorLogger;
+struct CWE;
+enum class Severity;
 
 /// @addtogroup Core
 /// @{

lib/checkstl.cpp

@@ -41,7 +41,6 @@
 #include <set>
 #include <sstream>
 #include <tuple>
-#include <type_traits>
 #include <unordered_map>
 #include <utility>
 #include <vector>

lib/config.h

@@ -159,6 +159,7 @@ static const std::string emptyString;
 #define USE_WINDOWS_SEH
 #endif
 
+// TODO: __GLIBC__ is depedent on the features.h include and not a built-in compiler define, so it might be problematic to depedent on it
 #if !defined(NO_UNIX_BACKTRACE_SUPPORT) && defined(__GNUC__) && defined(__GLIBC__) && !defined(__CYGWIN__) && !defined(__MINGW32__) && !defined(__NetBSD__) && !defined(__SVR4) && !defined(__QNX__)
 #define USE_UNIX_BACKTRACE_SUPPORT
 #endif

lib/keywords.cpp

@@ -20,8 +20,6 @@
 
 #include "utils.h"
 
-#include <cassert>
-
 // see https://en.cppreference.com/w/c/keyword
 
 #define C90_KEYWORDS \

lib/library.cpp

@@ -19,6 +19,7 @@
 #include "library.h"
 
 #include "astutils.h"
+#include "errortypes.h"
 #include "mathlib.h"
 #include "path.h"
 #include "symboldatabase.h"
@@ -31,7 +32,6 @@
 #include <algorithm>
 #include <cctype>
 #include <climits>
-#include <cstddef>
 #include <cstring>
 #include <list>
 #include <memory>

lib/library.h

@@ -23,7 +23,6 @@
 
 #include "config.h"
 #include "mathlib.h"
-#include "errortypes.h"
 #include "standards.h"
 
 #include <map>
@@ -37,6 +36,7 @@
 
 class Token;
 class Settings;
+enum class Severity;
 
 namespace tinyxml2 {
     class XMLDocument;

lib/pathanalysis.cpp

@@ -26,7 +26,6 @@
 #include <algorithm>
 #include <string>
 #include <tuple>
-#include <type_traits>
 
 const Scope* PathAnalysis::findOuterScope(const Scope * scope)
 {

lib/symboldatabase.cpp

@@ -48,7 +48,6 @@
 #include <stack>
 #include <string>
 #include <tuple>
-#include <type_traits>
 #include <unordered_map>
 #include <unordered_set>
 //---------------------------------------------------------------------------

lib/symboldatabase.h

@@ -36,7 +36,6 @@
 #include <map>
 #include <set>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>
 

lib/tokenize.cpp

@@ -21,6 +21,7 @@
 
 #include "check.h"
 #include "errorlogger.h"
+#include "errortypes.h"
 #include "library.h"
 #include "mathlib.h"
 #include "platform.h"
@@ -50,7 +51,6 @@
 #include <sstream> // IWYU pragma: keep
 #include <stack>
 #include <stdexcept>
-#include <type_traits>
 #include <unordered_map>
 #include <unordered_set>
 #include <utility>

lib/tokenize.h

@@ -22,7 +22,6 @@
 //---------------------------------------------------------------------------
 
 #include "config.h"
-#include "errortypes.h"
 #include "tokenlist.h"
 
 #include <cassert>
@@ -40,6 +39,7 @@ class TemplateSimplifier;
 class ErrorLogger;
 class Preprocessor;
 class VariableMap;
+enum class Severity;
 
 namespace simplecpp {
     class TokenList;

lib/utils.h

@@ -31,6 +31,7 @@
 #include <limits>
 #include <stdexcept>
 #include <string>
+#include <type_traits>
 #include <vector>
 
 struct SelectMapKeys {

test/fixture.h

@@ -24,7 +24,6 @@
 #include "color.h"
 #include "config.h"
 #include "errorlogger.h"
-#include "errortypes.h"
 #include "library.h"
 #include "platform.h"
 #include "settings.h"
@@ -39,6 +38,8 @@
 
 class options;
 class Tokenizer;
+enum class Certainty;
+enum class Severity;
 
 class TestFixture : public ErrorLogger {
 private:

test/testcmdlineparser.cpp

@@ -16,11 +16,13 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include "cmdlinelogger.h"
 #include "cmdlineparser.h"
 #include "config.h"
 #include "cppcheckexecutor.h"
 #include "errortypes.h"
 #include "helpers.h"
+#include "importproject.h"
 #include "platform.h"
 #include "redirect.h"
 #include "settings.h"
@@ -33,8 +35,11 @@
 #include <cstdint>
 #include <cstdio>
 #include <list>
+#include <memory>
 #include <set>
+#include <stdexcept>
 #include <string>
+#include <unordered_set>
 #include <vector>
 
 class TestCmdlineParser : public TestFixture {

test/testprocessexecutor.cpp

@@ -26,7 +26,6 @@
 #include "library.h"
 
 #include <algorithm>
-#include <cstddef>
 #include <cstdlib>
 #include <list>
 #include <map>

test/testsingleexecutor.cpp

@@ -27,7 +27,6 @@
 #include "timer.h"
 
 #include <algorithm>
-#include <cstddef>
 #include <cstdlib>
 #include <list>
 #include <map>

test/teststring.cpp

@@ -28,8 +28,6 @@
 #include <string>
 #include <vector>
 
-#include <simplecpp.h>
-
 class TestString : public TestFixture {
 public:
     TestString() : TestFixture("TestString") {}

test/testthreadexecutor.cpp

@@ -26,7 +26,6 @@
 #include "timer.h"
 
 #include <algorithm>
-#include <cstddef>
 #include <cstdlib>
 #include <list>
 #include <map>