walkero
/
cppcheck
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Fix false positives ignoredReturnValue about some posix interfaces. Remove redundant strsignal() output from signal handler

This commit is contained in:
Alexander Mai 2015-04-06 18:16:37 +02:00
parent 9876cf2312
commit bacc5ac1cc
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cfg/posix.cfg
View File

@ -1695,7 +1695,6 @@
</function> </function>
<!-- char *asctime_r(const struct tm *tm, char *buf); --> <!-- char *asctime_r(const struct tm *tm, char *buf); -->
<function name="asctime_r"> <function name="asctime_r">
<use-retval/>
<noreturn>false</noreturn> <noreturn>false</noreturn>
<leak-ignore/> <leak-ignore/>
<arg nr="1"> <arg nr="1">
@ -1708,7 +1707,6 @@
</function> </function>
<!-- char *ctime_r(const time_t *timep, char *buf); --> <!-- char *ctime_r(const time_t *timep, char *buf); -->
<function name="ctime_r"> <function name="ctime_r">
<use-retval/>
<noreturn>false</noreturn> <noreturn>false</noreturn>
<leak-ignore/> <leak-ignore/>
<arg nr="1"> <arg nr="1">
@ -1721,7 +1719,6 @@
</function> </function>
<!-- struct tm *gmtime_r(const time_t *timep, struct tm *result); --> <!-- struct tm *gmtime_r(const time_t *timep, struct tm *result); -->
<function name="gmtime_r"> <function name="gmtime_r">
<use-retval/>
<noreturn>false</noreturn> <noreturn>false</noreturn>
<leak-ignore/> <leak-ignore/>
<arg nr="1"> <arg nr="1">

3
cli/cppcheckexecutor.cpp
View File

@ -346,14 +346,11 @@ static void CppcheckSignalHandler(int signo, siginfo_t * info, void * context)
} }
#endif #endif
const char * const signame = signal_name(signo); const char * const signame = signal_name(signo);
const char * const sigtext = strsignal(signo);
bool bPrintCallstack=true; bool bPrintCallstack=true;
const bool isaddressonstack = isAddressOnStack(info->si_addr); const bool isaddressonstack = isAddressOnStack(info->si_addr);
FILE* f = (CppCheckExecutor::getExceptionOutput()=="stderr") ? stderr : stdout; FILE* f = (CppCheckExecutor::getExceptionOutput()=="stderr") ? stderr : stdout;
fputs("Internal error: cppcheck received signal ", f); fputs("Internal error: cppcheck received signal ", f);
fputs(signame, f); fputs(signame, f);
fputs(", ", f);
fputs(sigtext, f);
switch (signo) { switch (signo) {
case SIGBUS: case SIGBUS:
switch (info->si_code) { switch (info->si_code) {

4
test/cfg/posix.c
View File

@ -182,4 +182,8 @@ void timet_h() {
struct timespec* ptp; struct timespec* ptp;
// cppcheck-suppress uninitvar // cppcheck-suppress uninitvar
clock_settime(CLOCK_REALTIME, ptp); clock_settime(CLOCK_REALTIME, ptp);
time_t clock = time(0);
char buf[26];
ctime_r(&clock, buf);
} }