Commit Graph

1090 Commits

Author SHA1 Message Date
Martin Ettl 03e7914c98 partial fix of ticket #997; added check for write() two testcases 2009-11-28 13:41:24 +01:00
Daniel Marjamäki f75c9619d1 Fixed #1021 (Out-of-bounds access false positive) 2009-11-28 12:51:23 +01:00
Reijo Tomperi 2c51542cf1 Fix #1018 (strcat(strcat()) causes assertion in Tokenizer::validate)
Test case provided by povaddict
http://sourceforge.net/apps/trac/cppcheck/ticket/1018
2009-11-27 23:21:13 +02:00
Daniel Marjamäki c94ecfe1a3 Fixed #1015 (SIGABRT: Tokenizer::validate for openttd/src/ai/ai_config.cpp) 2009-11-27 17:32:53 +01:00
Daniel Marjamäki 7616246597 Fixed #1014 (Preprocessor: Invalid preprocessing of '#define some_delete(x) delete x;') 2009-11-26 17:32:18 +01:00
Reijo Tomperi 12a87fa3a4 Fix #1007 (False positive array index out of bounds concerning a switch statement in a for loop)
Bailout if switch is found in for loop.
http://sourceforge.net/apps/trac/cppcheck/ticket/1007
2009-11-25 22:40:51 +02:00
Daniel Marjamäki 128b2b8c59 Fixed #989 (CppCheck crashes on Win XP when scanning large directories/subdirectories) 2009-11-23 18:59:50 +01:00
Daniel Marjamäki 9b397afeca Temporary fix for #994 (cppcheck cannot check my sources with segfaulting) 2009-11-22 13:38:45 +01:00
Daniel Marjamäki 7f6f41fd53 Fixed #993 (Latest Git drop aborts at 63% of wine tree) 2009-11-22 09:06:39 +01:00
Daniel Marjamäki 092f64b77a Fixed #982 (Preprocessor: detects and remove conditions which always true) 2009-11-21 19:53:07 +01:00
Reijo Tomperi 9bdf4502ed Fix #995 (false positive: buffer access out of bounds when using fgets)
http://sourceforge.net/apps/trac/cppcheck/ticket/995
2009-11-21 15:45:52 +02:00
Reijo Tomperi 6417704577 Fix #985 (Detect buffer overrun with read())
http://sourceforge.net/apps/trac/cppcheck/ticket/985
2009-11-20 23:47:06 +02:00
Daniel Marjamäki 531d0fa685 Fixed #965 (Division by zero false positive with nested macros) 2009-11-20 20:42:28 +01:00
Slava Semushin 41b2a52915 Fixed #990 (Tokenizer::simplifyIfAddBraces() handle case where statement after if doesn't end by semicolon)
http://sourceforge.net/apps/trac/cppcheck/ticket/990
2009-11-21 01:40:46 +06:00
Daniel Marjamäki 91f7c15c24 Fixed #960 (Tokenizer::validate() assertion failure with mismatched brackets) 2009-11-20 20:10:42 +01:00
Daniel Marjamäki 7890589693 Fixed #912 (### Unlogged error at Tokenizer::syntaxError: Invalid number of character (()) 2009-11-20 19:18:57 +01:00
Slava Semushin 5369965e55 Fixed #983 (Tokenizer::simplifyTypedef() incorrectly substitute type inside namespace)
http://sourceforge.net/apps/trac/cppcheck/ticket/983
2009-11-20 00:02:16 +06:00
Reijo Tomperi 7ddc4f4e02 Fix #971 (Preprocessor: Handle partial macro in macro)
http://sourceforge.net/apps/trac/cppcheck/ticket/971
2009-11-19 00:34:00 +02:00
Daniel Marjamäki 42ffea4f16 Fixed #968 (False positive when TEMP_FAILURE_RETRY used) 2009-11-18 17:17:37 +01:00
Reijo Tomperi 8f07e2711c Added a few TODO test cases for #971 (Invalid number of characters (())
http://sourceforge.net/apps/trac/cppcheck/ticket/971
2009-11-18 00:21:21 +02:00
Reijo Tomperi bd2ca8babd astyle fix 2009-11-17 22:15:25 +02:00
Daniel Marjamäki a3a3ff4349 fixed testcase so it's valid syntax 2009-11-17 19:06:53 +01:00
Slava Semushin 42c5025000 Fixed #970 (Tokenizer: Incorrect comparison order simplification)
Revert changes from 11cb7b4710 commit
for lib/tokenize.cpp (fixed it by another way).

Teach unsignedint() to expand "unsigned" in casts.

http://sourceforge.net/apps/trac/cppcheck/ticket/970
2009-11-18 00:05:18 +06:00
Daniel Marjamäki d866c174cf Fixed 2009-11-15 20:26:07 +01:00
Daniel Marjamäki 469a8e4032 Fixed #925 (uninitialized deletion not detected) 2009-11-15 20:01:57 +01:00
Reijo Tomperi 9275b49688 Fix #964 (Integer division by zero exception)
http://sourceforge.net/apps/trac/cppcheck/ticket/964
2009-11-15 17:44:30 +02:00
Daniel Marjamäki 2b1b7f78f5 Fixed #883 (Add new command line argument --enable) 2009-11-15 15:24:33 +01:00
Slava Semushin 6669a50634 Fixed #842 (out of bounds: when buffer is allocated with malloc)
http://sourceforge.net/apps/trac/cppcheck/ticket/842
2009-11-15 18:38:57 +06:00
Slava Semushin 3911dd79cb Fixed #900 (Improve out-of-bounds check to detect error with "new char(x)")
http://sourceforge.net/apps/trac/cppcheck/ticket/900
2009-11-15 18:04:17 +06:00
Daniel Marjamäki 822f64ec9a Fixed #953 (false positive: 'uninitialized variable' with function pointer) 2009-11-15 12:42:04 +01:00
Daniel Marjamäki b5cbc509f3 Fixed #483 (False positive: found leak when foreach for lists used) 2009-11-15 10:30:00 +01:00
Daniel Marjamäki 14fd0154d2 memory leaks: simple code cleanup 2009-11-15 09:53:38 +01:00
Daniel Marjamäki 5dd7b054f9 Fixed #915 (false positive: memory leak for struct member (allocated in condition) 2009-11-15 09:28:08 +01:00
Daniel Marjamäki ebf907cbc0 Fixed #936 (false positive: uninitialized variable '.. else return; .. ') 2009-11-14 20:37:54 +01:00
Slava Semushin 11cb7b4710 Fixed #961 (Tokenizer: call simplifyCasts() before removing "unsigned" keyword)
http://sourceforge.net/apps/trac/cppcheck/ticket/961
2009-11-14 17:01:59 +06:00
Daniel Marjamäki fee96f3cd6 Fixed #944 (new false positives against Wine Git Tree) 2009-11-14 09:06:28 +01:00
Daniel Marjamäki ec6d66ff45 Fixed #913 (false positive: uninitialized variable) 2009-11-14 08:00:17 +01:00
Daniel Marjamäki a36c410d45 Preprocessor: When #error is encountered the result is an empty string => don't check configuration 2009-11-13 22:12:29 +01:00
Daniel Marjamäki 1187587521 Fixed #919 (possible memory leak not detected) 2009-11-13 20:22:28 +01:00
Slava Semushin 2ec5438186 Fixed #954 (Tokenizer: correctly simplify sizeof of class members)
http://sourceforge.net/apps/trac/cppcheck/ticket/954
2009-11-14 01:07:44 +06:00
Reijo Tomperi c4244ac9e8 Fix #945 (Array index out of bounds not detected, because of "int const")
http://sourceforge.net/apps/trac/cppcheck/ticket/945
2009-11-12 23:49:39 +02:00
Reijo Tomperi 3d5760b149 Fix #947 (Errors not detected when size_t is used instead of int)
http://sourceforge.net/apps/trac/cppcheck/ticket/947
2009-11-12 23:31:13 +02:00
Reijo Tomperi 0518eed937 Fix #946 (False positive: Buffer access out-of-bounds)
http://sourceforge.net/apps/trac/cppcheck/ticket/946
2009-11-12 23:24:44 +02:00
Daniel Marjamäki b2cec721c0 Fixed #951 (Preincremented struct member confused with numeric constant) 2009-11-12 22:16:24 +01:00
Reijo Tomperi d2db4d3a27 Test case for #903 (segmentation fault of cppcheck)
http://sourceforge.net/apps/trac/cppcheck/ticket/903
2009-11-12 21:04:11 +02:00
Daniel Marjamäki c337b4eb33 Fixed #950 (Bug in cppcheck tokenize.cpp) 2009-11-12 18:53:26 +01:00
Daniel Marjamäki 39614a699e Uninitialized variables: detect uninitialized pointer array 2009-11-10 19:35:54 +01:00
Daniel Marjamäki c301dc1907 Fixed #928 (false positive: member variable not initialized in constructor) 2009-11-10 19:30:37 +01:00
Daniel Marjamäki b470ea06b8 Fixed #931 (Invalid interator false positive with identical variable names) 2009-11-10 19:07:04 +01:00
Daniel Marjamäki e0b1303b50 Fixed #929 (Uninitialized variable false positive) 2009-11-10 18:05:55 +01:00
Daniel Marjamäki 51f983629b Fixed #932 (false positive: Dereferenced iterator 'i' has been erased) 2009-11-10 17:20:20 +01:00
Daniel Marjamäki d85fb9dd3d unit testing: minor syntax updates 2009-11-09 20:40:30 +01:00
Daniel Marjamäki 1fe94d74b8 unit testing: minor syntax fixes 2009-11-09 20:34:36 +01:00
Daniel Marjamäki 41e59d8348 Fixed #832 (Exception Safety: deallocating member pointer and then throwing exception) 2009-11-08 09:54:08 +01:00
Daniel Marjamäki 4b04ed9ad9 Fixed #910 (false positive: uninitialized variable for array) 2009-11-08 07:31:01 +01:00
Daniel Marjamäki 52eb32eb5b testbufferoverrun.cpp: fixed unit test error 2009-11-07 19:59:03 +01:00
Daniel Marjamäki 3b9b3b241e testbufferoverrun.cpp: minor updates to make it work better as extracted code 2009-11-07 19:51:18 +01:00
Daniel Marjamäki 3bd36226d6 testbufferoverrun: minor updates to make the code more easily compilable 2009-11-07 18:03:33 +01:00
Daniel Marjamäki d88c236efe uninitialized data: minor fix to handle 'new char [' better 2009-11-07 14:54:12 +01:00
Daniel Marjamäki 60caefe069 uninitialized data: added more checking for allocated data 2009-11-07 09:10:15 +01:00
Daniel Marjamäki 0c8d327809 Fixed #907 (Tokenizer: known result of strlen) 2009-11-07 08:25:39 +01:00
Reijo Tomperi b222ef89be Fix #903 (false positive: buffer access out of bounds)
http://sourceforge.net/apps/trac/cppcheck/ticket/903
2009-11-07 00:58:33 +02:00
Daniel Marjamäki 77b676937d cleanup in testbufferoverrun.cpp 2009-11-06 19:15:59 +01:00
Daniel Marjamäki c561a36cc7 uninitialized variables: better checking of strncpy 2009-11-06 19:06:45 +01:00
Daniel Marjamäki 7397bfc765 Fixed #904 (false positive: uninitialized variable) 2009-11-06 16:50:02 +01:00
Daniel Marjamäki 53f7b12b4f Fixed #902 (false positive: uninitialized variable when variable is initialized in macro) 2009-11-06 16:02:13 +01:00
Daniel Marjamäki 58c54d2ed4 Fixed #898 (Tokenizer: remove unneeded const after *) 2009-11-05 21:30:05 +01:00
Daniel Marjamäki 442584151b Fixed #897 (false positive: uninitialized variable when assigning pointer to array to struct member) 2009-11-05 21:07:04 +01:00
Reijo Tomperi de4ca924b5 Fixed #896 (False positive with --all when return value of open() is positive in a loop)
http://sourceforge.net/apps/trac/cppcheck/ticket/896
2009-11-05 00:58:15 +02:00
Daniel Marjamäki 141b91ae08 updated error message when memory leaks upon exception 2009-11-04 20:45:26 +01:00
Reijo Tomperi 9a55f4ca43 Add one more test case for #895 (false positive: Suspicious pointer subtraction) 2009-11-04 21:38:40 +02:00
Reijo Tomperi 80c66f8ebc Fix #895 (false positive: Suspicious pointer subtraction)
http://sourceforge.net/apps/trac/cppcheck/ticket/895
2009-11-04 21:36:27 +02:00
Reijo Tomperi 00b62442b6 Fix #894 (Invalid line number in "Invalid number of character")
http://sourceforge.net/apps/trac/cppcheck/ticket/894
2009-11-03 22:21:28 +02:00
Daniel Marjamäki c3dff9a6d3 Fixed #893 (False Positive: Uninitialized variable b in a[0] = b[0] = '\0';) 2009-11-03 21:02:16 +01:00
Daniel Marjamäki 68f63fdd75 Exception safety: added check for unsafe reallocation of member pointer 2009-11-03 20:26:52 +01:00
Daniel Marjamäki 616a760b6c Exception Safety: detect unsafe multiple new in a execution path (#831) 2009-11-03 19:43:51 +01:00
Daniel Marjamäki 797e9aeaf5 Fixed #890 (false positive: Uninitialized variable when pointer takes the address to array) 2009-11-03 17:03:53 +01:00
Reijo Tomperi 7fc72484ec Fix #881 (Tokenizer: Something seems to be wrong in Tokenizer::simplifyKnownVariables)
http://sourceforge.net/apps/trac/cppcheck/ticket/881
2009-11-03 00:07:15 +02:00
Daniel Marjamäki 87800185c4 STL: refactoring and fixing 2009-11-02 21:53:01 +01:00
Daniel Marjamäki 89d94895a4 Refactoring 2009-11-02 21:17:33 +01:00
Daniel Marjamäki bc3b12db72 astyle formatting 2009-11-02 20:25:08 +01:00
Daniel Marjamäki df3ffa2eda STL: added check for dangerous usage of std::find (#829) 2009-11-02 20:24:38 +01:00
Daniel Marjamäki 8d57cef7f9 Fixed #764 (usage of unitialized variable not detected) 2009-11-02 19:58:49 +01:00
Daniel Marjamäki 169bcfcff2 Fixed #882 (false positive: uninitialized variable) 2009-11-02 18:31:22 +01:00
Daniel Marjamäki 4abbe9ffd4 Fixed #889 (false positive: uninitialized variable) 2009-11-02 16:28:15 +01:00
Daniel Marjamäki 3e4dd22eed fixed todo testcase 2009-11-01 21:00:43 +01:00
Reijo Tomperi 618eed3d59 Fixed segmentation fault.
Had to change one test case to TODO for now.
2009-11-01 21:49:43 +02:00
Daniel Marjamäki 319cdc2b43 Fixed #880 (Tokenizer: The Tokenizer::simplifyTemplates doesn't handle recursive templates) 2009-11-01 19:03:52 +01:00
Daniel Marjamäki fec7acdc27 Templates: Better handling of recursive templates 2009-11-01 15:56:00 +01:00
Reijo Tomperi eebbc1b906 Fix #884 (False positive: Possible null pointer reference about a non-pointer)
http://sourceforge.net/apps/trac/cppcheck/ticket/884
2009-11-01 13:08:37 +02:00
Daniel Marjamäki 543d5cbf45 Fixed #831 (Exception safety: multiple new in a simple execution path) 2009-10-31 18:58:42 +01:00
Daniel Marjamäki c83d9cd786 Fixed #843 (new check: Passing uninitialized array to strlen/strdup/strcpy/strcat/etc) 2009-10-31 16:36:56 +01:00
Daniel Marjamäki 395ce30d81 Fixed #877 (False positive: After insert, iterator may be invalid) 2009-10-31 15:27:33 +01:00
Daniel Marjamäki a337708ae5 Fixed #430 (Tokenizer: handle templates with partial specialisation) 2009-10-31 12:34:52 +01:00
Daniel Marjamäki 266291baf4 Fixed #876 (false positive: uninitialized variable) 2009-10-31 10:30:32 +01:00
Daniel Marjamäki 45df223bfb Fixed #875 (Uninitialized variable: initialization in subfunction) 2009-10-30 18:28:01 +01:00
Daniel Marjamäki 7dbf22aa3f null pointer: fixed false positive when condition checks if pointer is ok 2009-10-30 15:14:24 +01:00
Daniel Marjamäki feb065abc8 Fixed #867 (unused member function warning) 2009-10-30 15:00:13 +01:00
Daniel Marjamäki 2cf849a9b8 uninitialized variables: fixed false positive when switch is used 2009-10-30 14:52:20 +01:00
Daniel Marjamäki 765c824c6f Uninitialized pointers: It's allowed to dereference uninitialized non-pointer variables 2009-10-30 14:31:37 +01:00
Daniel Marjamäki 44a9c9b458 Fixed #874 (false positive: uninitialized variable) 2009-10-30 14:06:40 +01:00
Daniel Marjamäki 768225bb1b uninitialized variables: fixed false positives for member variables 2009-10-30 13:43:00 +01:00
Daniel Marjamäki c424d4c8af uninitialized variables: Added TODO testcase for removing false positives 2009-10-29 22:51:08 +01:00
Daniel Marjamäki c6d7fad84f uninitialized variables: added check 2009-10-29 21:34:43 +01:00
Reijo Tomperi 4a61bd0432 Fix #870 (The CheckClass::getVarList method detects 'const' as a variable name.)
http://sourceforge.net/apps/trac/cppcheck/ticket/870
2009-10-29 21:54:51 +02:00
Reijo Tomperi 504ae8e22d Fix #868 (False positive - buffer access out of bounds in for loop)
http://sourceforge.net/apps/trac/cppcheck/ticket/868
2009-10-29 16:04:23 +02:00
Reijo Tomperi 9db22d9b48 Modify CheckBufferOverrun::checkGlobalAndLocalVariable() to use varid only.
Also add some TODO test cases.
2009-10-28 22:42:54 +02:00
Daniel Marjamäki ffb5bbd4d1 Visual Studio: Manually edited the vcproj files. The absolute paths were replaced with relative paths 2009-10-28 20:15:56 +01:00
Daniel Marjamäki cba94feded Restructuring: Updated the Visual Studio project files. They are now generated by qmake 2009-10-28 17:37:38 +01:00
Daniel Marjamäki 0682db47a7 Memory leaks: Detect simple leak 2009-10-27 23:08:11 +01:00
Daniel Marjamäki 45b0758e71 Fixed #860 (Improve double delete detection) 2009-10-27 21:28:03 +01:00
Reijo Tomperi 0e695ea527 Test case for #863 (false positive memset array of pointers)
http://sourceforge.net/apps/trac/cppcheck/ticket/863
2009-10-27 20:54:35 +02:00
Reijo Tomperi 59acfbc4df Fix #863 (false positive memset array of pointers)
http://sourceforge.net/apps/trac/cppcheck/ticket/863
Also fix test cases for 64 bit systems.
2009-10-27 20:23:45 +02:00
Daniel Marjamäki 2525b0131a Restructuring: Updated test/test.pro 2009-10-26 22:20:25 +01:00
Daniel Marjamäki 09859c1019 refactoring the folder structure 2009-10-25 12:49:06 +01:00
Daniel Marjamäki 26a81e82cc Fixed #253 (MemoryLeakInClass: False positive when memory is released in function, which is called from destructor) 2009-10-24 15:07:14 +02:00
Daniel Marjamäki 2c8a418c7e Memory leaks: Added and fixed testcase TestMemleakInClass::class13 2009-10-23 20:04:47 +02:00
Daniel Marjamäki 88070b044b Fixed #851 (Tokenizer: sizeof(*a) returns incorrect result) 2009-10-22 23:00:27 +02:00
Daniel Marjamäki 701d622ff0 Fixed #428 (Memory leak not detected with class) 2009-10-22 21:51:58 +02:00
Daniel b80a954f55 Fixed #844 (Tokenizer: Simplify 'sizeof *ptr' correctly) 2009-10-21 21:08:00 +02:00
Reijo Tomperi 9d42194562 Fix #767 (Tokenizer: Known variable variable not simplified)
http://sourceforge.net/apps/trac/cppcheck/ticket/767
2009-10-20 23:58:46 +03:00
Daniel e5f13b4de2 Fixed #839 (False positive: possible null pointer dereference after new) 2009-10-20 20:57:38 +02:00
Reijo Tomperi 6fbf873d25 Improved countSprintfLength() to detect more errors with %d.
Fixed some errors from test cases.
Added more test cases.
2009-10-20 00:48:29 +03:00
Daniel Marjamäki a36c31628d Fixed by #828 (Exception Safety: No throwing in destructors) 2009-10-19 20:57:11 +02:00
Daniel Marjamäki 857c95e7b5 Null pointers: Detect code where the assignment is conditional 2009-10-19 17:32:43 +02:00
Daniel Marjamäki 0e56e4cd37 STL: checking that containers are matching 2009-10-18 18:42:01 +02:00
Daniel Marjamäki 50e542c183 Fixed #827 (Tokenizer: sizeof is incorrectly simplified) 2009-10-18 18:06:32 +02:00
Daniel Marjamäki 58790eda82 Fixed #449 (false postive:: resource leak when using errno) 2009-10-18 13:17:05 +02:00
Reijo Tomperi aca743c9ed Fix #826 (False positive: sprintf with "f%s")
http://sourceforge.net/apps/trac/cppcheck/ticket/826
2009-10-18 13:58:48 +03:00
Daniel Marjamäki cb76061118 unused struct member: bail out when casting 2009-10-17 19:31:14 +02:00
Daniel Marjamäki 2ec1b676ea Pointer Aliasing: Handle pointer aliasing through the Tokenizer::simplifyKnownVariables 2009-10-17 18:21:13 +02:00
Daniel Marjamäki 2e9f7755ee Unused struct members: bail out upon casting 2009-10-17 17:36:55 +02:00
Daniel Marjamäki ffbf8e38ac stl: after vector::insert, iterators may become invalid 2009-10-15 21:29:56 +02:00
Daniel Marjamäki 01af70cc88 Fixed #823 (Buffer overrun with memcpy) 2009-10-15 19:36:48 +02:00
Daniel Marjamäki 91de8f399b Fixed #821 (Preprocessor: Wrong stringification in macros) 2009-10-14 20:40:17 +02:00
Reijo Tomperi be90d34962 Buffer overrun errors behind function call should be possible errors. 2009-10-14 00:09:37 +03:00
Reijo Tomperi 3dc45903bc Move buffer overrun errors behind --all
Fix one possible error issue with arrayindexoutofbounds
Make sure that possible errors are not shown without --all
2009-10-13 23:33:41 +03:00
Reijo Tomperi a3a55547d8 Merge branch 'master' of git@github.com:danmar/cppcheck 2009-10-13 22:41:21 +03:00
Reijo Tomperi 4036dd5eff arrayIndexOutOfBounds check is now done without --all
Errors with buf[1] are still listed only with --all due to false positive risk in them.
2009-10-13 22:39:51 +03:00
Daniel Marjamäki a33b4744a3 stl: better checking for invalid iterator after push_back 2009-10-13 20:55:33 +02:00
Daniel Marjamäki ed3860a0a7 Fixed #805 (False positive: Member functions not handled correctly) 2009-10-12 21:36:28 +02:00
Reijo Tomperi b6999d010f Fix #812 (False positive: sprintf with "%.4s" with --all)
http://sourceforge.net/apps/trac/cppcheck/ticket/812
2009-10-11 22:07:18 +03:00
Reijo Tomperi 59aad35137 Fix #694 (False (possible error) Buffer overrun with %-1s)
ashim2009 did most of the work
http://sourceforge.net/apps/trac/cppcheck/ticket/694
2009-10-11 21:36:22 +03:00
Reijo Tomperi 1401e3f668 Fix #810 (false positive: Division with signed and unsigned operators)
http://sourceforge.net/apps/trac/cppcheck/ticket/810
2009-10-11 17:52:35 +03:00
Reijo Tomperi ea36632ca3 Fix #808 (Segfault in Preprocessor)
http://sourceforge.net/apps/trac/cppcheck/ticket/808
2009-10-10 23:23:48 +03:00
Slava Semushin 237dcb9533 Fixed #809 (Tokenizer: don't replace sizeof() of unknown type to zero)
http://sourceforge.net/apps/trac/cppcheck/ticket/809
2009-10-10 19:26:03 +07:00
Daniel Marjamäki b67fe861b8 Added testcase for #807 (cppcheck crashes scanning ruby 1.9.1) 2009-10-10 10:13:56 +02:00
Daniel Marjamäki 67f53661a9 Fixed #806 (cppcheck crashes scanning openssl) 2009-10-09 21:11:29 +02:00
Reijo Tomperi a078c9353d More test cases for sprintf counter 2009-10-08 17:36:00 +03:00
Reijo Tomperi 5eee9af974 sprintf counter improvements 2009-10-08 16:27:46 +03:00