cb48aae594
buffer overrun: Remove bailout. There is no test case and I fail to produce false positives.
2018-06-24 09:50:55 +02:00
d0819e4792
Reuse isVariableChanged() in auto variables
2018-06-24 08:55:23 +02:00
cde63c7573
Use Variable::valueType instead of Variable::typeStartToken in auto variables
2018-06-24 08:25:19 +02:00
2beeca3ca2
Refactoring; use early continue
2018-06-23 23:26:37 +02:00
655a8b21b6
Fix false positive 'passedByValue' when address of argument is used
2018-06-23 23:25:06 +02:00
697aee143f
CheckOther: Use Variable::valueType() instead of Variable::typeStartToken
2018-06-23 16:52:40 +02:00
fc78530b3f
CheckOther: Use Variable::valueType() instead of Variable::typeStartToken
2018-06-23 16:49:26 +02:00
2a8296879c
CheckOther: Use Variable::valueType() instead of Variable::typeStartToken
2018-06-23 16:42:36 +02:00
ee335e5151
Fix compiler error
2018-06-23 16:07:02 +02:00
911020f601
Refactoring, use range for loop
2018-06-23 15:58:44 +02:00
d811a07aa3
CheckOther: Use Variable::valueType() instead of typeStartToken etc
2018-06-22 23:04:36 +02:00
d0614b9b36
varScope: Fix false negatives for references
2018-06-22 22:51:03 +02:00
d90c38802f
Fixed Cppcheck warnings (variable scope can be reduced)
2018-06-21 06:54:56 +02:00
439d4a4900
Use Variable::valueType() instead of Variable::typeStartToken()
2018-06-20 19:08:09 +02:00
10fc070f44
SymbolDatabase: Better handling of type aliases in ValueType
2018-06-20 14:49:55 +02:00
b62c562a89
Try to make Travis happy
2018-06-20 14:13:04 +02:00
0b65a52224
Add some missing errors to --errorlist output. ( #1292 )
...
Partly fixes https://trac.cppcheck.net/ticket/7772 .
2018-06-20 10:43:13 +02:00
929725f3aa
Code cleanup
2018-06-20 10:39:21 +02:00
b4cb2505c3
SymbolDatabase: Add Variable::valueType(). First step to reuse ValueType handling in Variable
2018-06-20 10:00:15 +02:00
eb978ee192
Refactoring: delete assignment operator
2018-06-19 14:00:50 +02:00
9edcae97fc
Fixed #8578 (Argument scope as global)
2018-06-19 08:50:32 +02:00
13cf93a322
Rename private variable maxtime
2018-06-18 09:49:00 +02:00
86872f81ba
Refactorings in CheckMemoryLeak
2018-06-18 09:40:27 +02:00
4ba9437bd5
Rename private member variables
2018-06-17 23:09:41 +02:00
96fc8efb4b
Refactoring: Use C++11 '=delete' to delete methods
2018-06-17 19:36:09 +02:00
9717a5afad
Rename private member variables
2018-06-17 19:24:40 +02:00
e962f57a99
Rename private member variables
2018-06-17 19:20:07 +02:00
a25461919c
Rename private member variables
2018-06-17 19:04:06 +02:00
2a495184d2
Rename private member variables
2018-06-17 18:58:27 +02:00
965fcf9303
Rename private member variables
2018-06-17 18:55:41 +02:00
e90c04cff9
Rename private member variable
2018-06-17 18:43:54 +02:00
19cf0d1fa4
Refactoring; use range for loop
2018-06-17 18:37:40 +02:00
ad4ce84cf7
Rename private member variables
2018-06-17 17:20:16 +02:00
0b74a90e75
symboldatabase: removed duplicate keywords in C++-keyword list.
2018-06-17 17:05:36 +02:00
aa17b1f79a
Rename private member variables
2018-06-17 17:04:34 +02:00
610b26bfbc
Rename private member _platform_types
2018-06-17 16:58:28 +02:00
074177fc6e
Rename private member variables
2018-06-17 16:55:02 +02:00
c25ab16f5d
V817 It is more efficient to seek '\t' character rather than a string. errorlogger.cpp 448 ( #1290 )
...
V817 It is more efficient to seek '}' character rather than a string. errorlogger.cpp 484
V817 It is more efficient to seek '\r' character rather than a string. errorlogger.cpp 497
V817 It is more efficient to seek '\r' character rather than a string. errorlogger.cpp 528
V817 It is more efficient to seek ';' character rather than a string. suppressions.cpp 187
V817 It is more efficient to seek ';' character rather than a string. suppressions.cpp 188
full log: http://www.fly-server.ru/pvs-studio/cppcheck/
2018-06-17 16:39:28 +02:00
dbf89856c0
Renamed Library private member variables
2018-06-17 16:39:10 +02:00
fb8e970419
Rename _alloc
2018-06-17 16:32:08 +02:00
fa8911a7d2
Renamed _suffixes
2018-06-17 13:47:18 +02:00
153838c254
Renamed _prefixes
2018-06-17 13:46:24 +02:00
9f191cd2dc
Renamed _blocks
2018-06-17 13:45:31 +02:00
fea58e5e54
Renamed _offset
2018-06-17 13:44:56 +02:00
743dcff036
Renamed _start and _end
2018-06-17 13:44:10 +02:00
0ca96f2a7d
Renamed private member file0
2018-06-17 09:06:16 +02:00
517d8f9684
Renamed private member tokenlists to mTokenLists
2018-06-17 08:58:56 +02:00
de0e22a1fb
Renamed private member directives
2018-06-17 08:45:45 +02:00
c102638970
astyle formatting
2018-06-17 08:45:26 +02:00
f8e96307f7
Refactoring, use range for loop
2018-06-17 08:40:25 +02:00
87b21f3e57
Renamed _terminated
2018-06-17 08:22:53 +02:00
bea6b32157
Renamed _enabled
2018-06-17 08:21:05 +02:00
37bcec8804
Renamed _fileName
2018-06-17 08:19:10 +02:00
8d66eecf47
Renamed _suppressions to mSuppressions
2018-06-17 08:16:37 +02:00
7517371203
Renamed private member analyzerInfoFile
2018-06-17 08:11:48 +02:00
9085373494
Rename private member fout
2018-06-17 08:09:59 +02:00
b12b7f93e4
Rename _symbolNames
2018-06-17 07:59:48 +02:00
d48876c3be
Renamed _verboseMessage
2018-06-17 07:55:47 +02:00
8d00c7ca81
Renamed _shortMessage
2018-06-17 07:54:50 +02:00
e8496f4fb5
Renamed _file and _info
2018-06-17 07:52:59 +02:00
fe0bd8ff6c
Renamed exitcode to mExitCode
2018-06-17 07:43:25 +02:00
6ff6f0ae45
Renamed cfg to mCurrentConfig
2018-06-17 07:40:13 +02:00
cb0bea1749
Renamed _simplify
2018-06-17 07:37:10 +02:00
b90d1bc020
Renamed member fileInfo to mFileInfo
2018-06-17 07:36:05 +02:00
c5e0576961
Renamed analyzerInformation
2018-06-17 07:31:34 +02:00
54ba0e58c1
Renamed _useGlobalSuppressions
2018-06-17 07:29:07 +02:00
b992b4a4f0
Renamed _errorList
2018-06-16 23:31:16 +02:00
d9aeeb1d09
Renamed private member cpp to mIsCpp
2018-06-16 23:30:00 +02:00
306b2a9810
Renamed private member defaultSignedness
2018-06-16 23:25:35 +02:00
678e3271d4
Rename private flags member to mFlags
2018-06-16 23:11:45 +02:00
ac28ae5788
Renamed Token::_str
2018-06-16 23:03:15 +02:00
33e718d59e
Rename Timer::_str
2018-06-16 22:49:51 +02:00
0e8a60f1ad
Renamed _start
2018-06-16 22:43:25 +02:00
ce78245f38
Renamed _showtimeMode
2018-06-16 22:40:11 +02:00
4b9c6a11a2
Renamed _stopped to mStopped
2018-06-16 22:34:50 +02:00
4f34a5145f
Renamed _clocks
2018-06-16 22:25:25 +02:00
94c7e28835
Renamed _numberOfResults
2018-06-16 22:24:44 +02:00
66785c238a
Renamed _timerResults
2018-06-16 22:14:59 +02:00
63e6d35cb6
Renamed _unnamedCount to mUnnamedCount
2018-06-16 22:09:18 +02:00
ef534c2d0d
Renamed _codeWithTemplates
2018-06-16 22:03:04 +02:00
5dc29a9a16
Renamed _configuration to mConfiguration
2018-06-16 21:57:48 +02:00
598a984071
Renamed _typeSize to mTypeSize
2018-06-16 21:56:05 +02:00
5e43366126
Rename members
2018-06-16 21:52:29 +02:00
237314fb51
Rename _values to mValues
2018-06-16 21:45:53 +02:00
0452c5a4e4
Renamed _bits to mBits
2018-06-16 21:43:44 +02:00
d468eca772
Renamed _valuetype to mValueType
2018-06-16 21:42:40 +02:00
82169b6247
Renamed _originalName to mOriginalName
2018-06-16 21:40:25 +02:00
15f7c26706
Renamed _blankTypes
2018-06-16 20:33:07 +02:00
56126d6e2d
Renamed _variableList to mVariableList
2018-06-16 20:31:47 +02:00
759097301b
Rename _link to mLink
2018-06-16 20:30:09 +02:00
e8a00a38ac
Rename _scope to mScope
2018-06-16 20:29:17 +02:00
7314fc7557
Rename _enumerator to mEnumerator
2018-06-16 20:27:49 +02:00
3ca8372b37
Rename _variable to mVariable
2018-06-16 20:27:13 +02:00
964841ba25
Rename _function to mFunction
2018-06-16 20:26:43 +02:00
78974e9267
Rename _type to mType
2018-06-16 20:25:54 +02:00
fc6f17ed87
Rename _dimensions to mDimensions
2018-06-16 20:23:58 +02:00
31f137f24d
Renamed _fileIndex, _linenr, _col
2018-06-16 16:43:54 +02:00
a6e4663445
Renamed _progressValue to mProgressValue
2018-06-16 16:41:25 +02:00
aeea2e7427
Renamed _tokType to mTokType
2018-06-16 16:40:02 +02:00
8e2b18a75a
Rename _varId to mVarId
2018-06-16 16:38:50 +02:00
23eb98d2ca
Renamed Check::_name
2018-06-16 16:31:07 +02:00
807fbfd318
Renamed _isC and _isCPP
2018-06-16 16:28:03 +02:00
d81fe83ca6
renamed _symbolDatabase to mSymbolDatabase
2018-06-16 16:25:27 +02:00
d08b6e02b7
renamed _files to mFiles
2018-06-16 16:23:55 +02:00
cc521bef99
renamed _tokensFrontBack to mTokensFrontBack
2018-06-16 16:22:35 +02:00
26d58ddbb9
rename _astOperand1, _astOperand2, _astParent
2018-06-16 16:18:50 +02:00
435aa70c3d
rename _previous and _next
2018-06-16 16:16:55 +02:00
363f4ca939
rename _flags to mFlags
2018-06-16 16:14:34 +02:00
67b111f11e
SymbolDatabase: rename _constness to mConstness
2018-06-16 16:13:26 +02:00
5154eb10c6
SymbolDatabase: rename _access
2018-06-16 16:12:27 +02:00
7dfd4f61a1
SymbolDatabase: rename _index
2018-06-16 16:11:40 +02:00
79ffe1d4fc
Rename _tokenizer, _settings, _errorLogger
2018-06-16 16:10:28 +02:00
8209c4aebd
SymbolDatabase: rename _start and _end
2018-06-16 16:03:36 +02:00
311454669f
SymbolDatabase: rename _name
2018-06-16 15:57:16 +02:00
593f7eee38
Fixed #8624 (Crash below CheckOther::checkDuplicateExpression)
2018-06-14 22:39:26 +02:00
a21c05edfe
1.84: Set versions
...
[ci skip]
2018-06-10 22:21:57 +02:00
45379a3aa6
Updated copyright year for modified files
...
[ci skip]
2018-06-10 22:07:21 +02:00
3029606342
CheckClass: Fix Cppcheck warning about mismatching function parameters
2018-06-10 22:04:22 +02:00
b9d03d0e23
astyle formatting
...
[ci skip]
2018-06-10 21:59:24 +02:00
daacf27c2e
Fix false positive from issue 8612 ( #1285 )
2018-06-10 00:05:23 +02:00
03b2e0eee7
inline suppressions: treat arithmetic operators as start-of-comment
2018-06-09 22:50:51 +02:00
db7d267c02
Refactoring: Add _ prefix to Token member variables ( #1280 )
2018-06-09 08:14:24 +02:00
8d53bcfd63
Fix FP when using non-const members and also check return type of function ( #1283 )
2018-06-09 08:05:19 +02:00
84f0a18053
passedByReference: avoid false positives for std::pair
2018-06-08 10:19:02 +02:00
44c78d1770
passedByReference: avoid false positives for std::function
2018-06-08 08:40:14 +02:00
de09c117bf
Fixed #8618 (False positive: shared_ptr is passed by reference by intention)
2018-06-07 22:39:21 +02:00
f947b3b025
Fix some doxygen warnings
2018-06-07 08:33:32 +02:00
1abc9008d8
Fixed #8573 (FP noCopyConstructor - derive from noncopyable class)
2018-06-06 16:02:25 +02:00
7c9b6d9bb0
checkother.cpp: Fix typo in symbol placeholder in error message. ( #1276 )
2018-06-05 10:24:19 +02:00
b9c1308a81
Fixed #8575 (false positive: longCastAssign)
2018-06-04 22:51:21 +02:00
7b106c067a
Fixed #8603 (SymbolDatabase: 2 scopes with same function)
2018-06-03 23:14:24 +02:00
df9b243227
Modernize: use ranged for loops in CheckNullPointer
2018-06-03 09:27:18 +02:00
0771a81969
Revert "tokenlist::iscast(): save a few pointer dereferences."
...
This reverts commit e187fdb696
2018-06-02 15:57:56 +02:00
d3b231214d
TemplateSimplifier optimisation. measured time improvement for cryptopp/test.cpp is ~8.4s => ~8.35s
2018-06-02 13:49:14 +02:00
558a2f0cc7
SymbolDatabase::createSymbolDatabaseFindAllScopes(): hoist _tokenizer->isC(PP) dereference out of loop.
2018-06-02 13:38:15 +02:00
e187fdb696
tokenlist::iscast(): save a few pointer dereferences.
2018-06-02 13:19:22 +02:00
7163210f72
Fixed #8605 (Segmentation fault below TemplateSimplifier::simplifyCalculations)
2018-06-01 23:03:53 +02:00
be6c273e6b
CheckBufferOverrun::checkScope_inner(): save a few pointer derefernces (NFC).
2018-05-31 12:28:34 +02:00
02f9ab38b4
simplifyCalculations: Made this function ~30% faster when analysing lib/tokenize.cpp
2018-05-31 06:36:59 +02:00
8d55d361ae
#8602 Template default parameter without name yields syntax error
2018-05-30 17:09:31 +02:00
7681bbf227
Fixed #8146 (false positive: enum initialized using class member initializer syntax in struct in struct) ( #1270 )
2018-05-30 15:40:16 +02:00
4c9bde277a
Refactoring: Use ranged for in TemplateSimplifier
2018-05-30 14:40:38 +02:00
f7148cbaa9
Refactoring: Renamed iterator
2018-05-30 14:33:55 +02:00
cc77a6aa62
Code refactoring
2018-05-29 22:41:37 +02:00
3982c81394
Add support for C++ attribute nodiscard for functions. ( #1269 )
2018-05-29 21:43:56 +02:00
14e60210c9
Optimize Tokenizer::setVarIdPass1
2018-05-29 18:41:05 +02:00
5861a3844a
Running astyle [ci skip].
2018-05-29 17:32:55 +02:00
de66eedd54
Improved const correctness of local variables.
2018-05-29 17:33:43 +02:00
7d4a80fbd2
astyle formatting
...
[ci skip]
2018-05-29 16:30:33 +02:00
33777c5b72
Improved const correcntess of local variables.
2018-05-29 13:24:48 +02:00
b94e5ab9cb
Fixed VS2017 C4101: unreferenced local variable.
2018-05-29 13:18:07 +02:00
bf20aa2330
token.h: Added const-qualifiers to some functions.
2018-05-29 11:46:07 +02:00
d7dfa29864
Preprocessor: only throw errors upon request.
2018-05-28 14:11:59 +02:00
c2c43ce8a7
Code cleanup, use '= delete'
2018-05-28 12:44:18 +02:00
02c8a1d61c
Tokenizer::setVarIdPass1 optimization
2018-05-28 11:32:47 +02:00
36f7585798
Fixed #8600 (false-positive/regression: confusion between copy constructors of internal classes and lack of explicit keyword) ( #1266 )
2018-05-27 10:53:34 +02:00
1914d5e630
Running astlye
2018-05-25 08:35:37 +02:00
42a65c5160
Fix crash bug #8579 ( #1238 )
...
* Added declaration for deletePrevious function
* Added definition for deletePrevious function
* Fixed crash from deleteThis invalidating pointers
The crash was caused by deleteThis() invalidating the pointer to a constant variable usage. This happened when a usage followed an assignment. This fixes bug #8579 .
* Added tokensFront to match tokensBack
This means deletePrevious can set the list's front if necessary.
* Initialised tokensFront in appropriate places
* Switched to using default Token constructor
* Switched to using Token default constructor
* Switched to using default constructor for Token
* Added missing argument to Token constructor
* Changed to use default constructor for Tokens
* Switched to using default constructor for Tokens
* Switched to using default constructor for Token
* Added new test for deleting front Token
Also made sure to use the correct constructor for Token in other tests.
* Syntax error
* Replaced tokensFront and tokensBack with a struct
This decreases the size of the Token class for performance purposes.
* Replaced tokensFront and tokensBack with a struct
* Added tokensFrontBack to destructor
* Reworked to use TokensBackFront struct
Also ran astyle.
* Reworked to use TokenList's TokensFrontBack member
* Reworked to use TokensFrontBack struct
* Reworked to use TokensFrontBack struct
* Reworked to work with TokensFrontBack struct
* Removed unnecessary scope operator
* Added missing parentheses
* Fixed syntax error
* Removed unnecessary constructor
* Default constructor now 0-initialises everything
This is safer for not using a temporary TokensFrontBack object, and doesn't use delegating constructors which aren't supported yet.
* Fixed unsafe null check
* Added missing explicit keyword
* Fixing stylistic nits
Removed default constructor as it has been superseded by the single-argument constructor with a default argument value.
Renamed listEnds to tokensFrontBack.
Fixed if statement that was supposed to be adding safety but would actually cause a crash if tokensFrontBack was null.
* Fixing stylistic nits
Removed default constructor and replaced it with a single-argument constructor with a default value.
* Fixing stylistic nits
Renamed _listEnds to _tokensFrontBack.
* Fixing stylistic nits
Renamed _listEnds to _tokensFrontBack.
2018-05-25 07:15:05 +02:00
9bf604c46c
timer.h: Improved const correctness of local variable.
2018-05-24 17:07:40 +02:00
d013cb2f0d
library.h: Improved const correctness of some function arguments.
2018-05-24 17:06:20 +02:00
2ffbb37cee
modernize cppcheck.cpp, use range for loops
2018-05-22 23:22:46 +02:00
fc1d62fd45
Fixed #7406 (Tokenizer::simplifyTypedef: array typedef used as template parameter) ( #1257 )
2018-05-22 17:31:58 +02:00
a3b02d6ece
Fixed #8262 : false positive memleak (`shared_ptr` in function argument) ( #1249 )
...
* Fixed #8262 .
checkleakautovar.cpp:
* added `isFunctionCall` (supports template functions)
* smart pointer check in `functionCall`
* updated test case
* Renamed "bracket" to "parenthesis"
* (#8262 ) Fixed broken test
* (#8262 ) Code review comments
* (#8262 ) Renamed `tokOpeningBr` to `tokOpeningPar`
2018-05-22 09:08:23 +02:00
8320be203d
Fixed #8258 (Incorrect diagnostics when using delegating consturctor with default values) ( #1255 )
2018-05-22 06:42:37 +02:00
5c15cd3981
Fix DACA2 SymbolDatabase bailout; unhandled code for final class ( #1253 )
...
* Fix DACA2 SymbolDatabase bailout; unhandled code for final class
* Replace Match with simpleMatch
2018-05-21 21:23:21 +02:00
406aa6cf1c
Improve support of using a lambda as a deleter ( #1246 )
...
* Improve support of using a lambda as a deleter
* Use simple match
2018-05-21 08:22:18 +02:00
42ed5a6b98
Fixed #8581 (Delegating contructor warns for unintialized variables) ( #1250 )
...
* Fixed #8581 (Delegating contructor warns for unintialized variables)
* Replace Token::Match with isStandardType
2018-05-20 22:58:05 +02:00
9b28499412
Import BCB6 projects ( #1245 )
...
* added support for reading borland c++ builder 6 projects
* add: fetch sysdefines from project
add: start providing bcb6 predefines (WIP)
* configure all the internal defines for BCB6
* make sure define strings don't start with ';'
* improvements on bwoesters BCB6 project support
- improved `*.bpr` XML handling by reducing the number of loops
- added `const` where aplicable
- optimized compiler argument parser performance
- reformatted code with provided astyle config
* - undo looping (keep it the same as the other implementations)
- keep parsing of cflags simple and separate from the synonym cleanup (no need for micro optimization in this place)
- move input validation to FileSettings::setDefines
- re-run astyle
* use [] instead of at() when comparing characters
2018-05-20 18:19:20 +02:00
2b14b71c93
Updated output when Cppcheck fails to find valid configurations
2018-05-17 10:27:05 +02:00
7062df5d78
#8585 --check-config aborts due to unhandled simplecpp::Output exception
2018-05-17 08:59:10 +02:00
2320034f4a
fix -Winconsistent-missing-override warnings reported by clang 6.0.
2018-05-17 08:47:19 +02:00
fe1b1d537e
Fix compiler warning by useless semicolon
2018-05-16 21:33:26 +02:00
d567b878ba
Fix template instantialion failure for qualified template type. ( #1237 )
2018-05-16 15:24:23 +02:00
ce50df8047
Fix override warnings. ( #1234 )
2018-05-15 16:37:40 +02:00
6bd4bdb0f9
Updated 'noValidConfiguration' message. It should not write this message when there is no code. It should be possible to see the preprocessor errors otherwise it is hard to fix the configuration.
2018-05-15 15:42:54 +02:00
f7746e4fb6
Revert "Missing override specifier warning on a pure virtual function makes no sense. ( #1230 )"
...
This reverts commit 348eb1c5c9
2018-05-15 10:48:34 +02:00
348eb1c5c9
Missing override specifier warning on a pure virtual function makes no sense. ( #1230 )
...
This fixes a large number of false positives for cppcheck source code.
2018-05-14 23:08:40 +02:00
d8622ea5f8
simplifyCalculations: Removed redundant goback variable
2018-05-14 23:06:10 +02:00
29dc42ff67
Removed unreachable code
2018-05-14 22:50:30 +02:00
e8bc955023
Optimized Tokenizer::simplifyFunctionReturn(): Replaced nested loops by two consecutive loops; execute second one only if necessary.
2018-05-14 20:51:09 +02:00
20b2574da8
Fixed false positive unusedPrivateFunction caused by recent commit
2018-05-14 16:20:46 +02:00
0090ae5cf2
Optimization in CheckUninitVar::checkStruct(): Replaced expensive inner loop on all scopes by loop on child scopes for faster lookup for inner unions.
...
This speeds up checking of very large code files; for example, it reduces checking time for SQLite amalgamation by more than 20%
2018-05-14 15:48:57 +02:00
c4b6beac4d
Fixed calculation precedence warning introduced in recent commit
2018-05-14 15:24:32 +02:00
4c8bb9ac6f
fix a few typos
2018-05-14 13:11:59 +02:00
3d860e6f36
Bump simplecpp
2018-05-14 13:00:22 +02:00
090a178ed6
Refactorization in SymbolDatabase: Do not redundantly store name in FriendInfo, and store FriendInfo in vector instead of list
2018-05-14 12:18:59 +02:00
4d549553b0
Small optimization in checkmemoryleak.cpp: Allow passing literals to addtoken()
...
Ran AStyle
2018-05-14 10:15:50 +02:00
7ef714b0c6
Fix FP with duplicate assignments by checking if the expression is unique ( #1223 )
...
* Fix FP with duplicate assignments by checking if the expression is unique
* Use array of pointers
* Reorder scope condition
2018-05-13 20:20:55 +02:00
5c06d08bfb
Fix many DACA2 SymbolDatabase bailout; unhandled code false positives ( #1225 )
2018-05-13 19:00:42 +02:00
513cdc144c
Optimization: Save up to 2 of 3 token list iterations in Tokenizer::simplifyKeyword()
2018-05-13 10:12:50 +02:00
9ee6068e20
Remove duplicate namespace aliases so they don't produce syntax errors. ( #1222 )
...
* Remove duplicate namespace aliases so they don't produce syntax errors.
DACA2 results showed new SymbolDatabase syntax errors when duplicate
namespace aliases were simplified improperly. The solution is to remove
them in the tokenizer when found.
* Add tests for deleting namespace aliases at end of token list.
* Use eraseTokens to delete multiple tokens at once.
2018-05-13 08:29:40 +02:00
723bacbf09
Fixed hang introduced in previous commit and further optimized Tokenizer::simplifyStaticConst(): Avoid redundant Token swapping
2018-05-12 21:35:54 +02:00
a16e99c710
Optimization: Save 2 of 3 token list iterations in Tokenizer::simplifyStaticConst()
2018-05-12 19:19:48 +02:00
16e1e1d8f9
Ticket #8550 : Properly simplify "typedef class A B;". ( #1224 )
2018-05-12 10:20:33 +02:00
98e3f373e9
Revert "Optimize usage of TemplateSimplifier::simplifyCalculations"
...
This reverts commit 3044612fe9
2018-05-11 21:26:28 +02:00
a3f1d28fa5
astyle formatting
...
[ci skip]
2018-05-11 21:25:41 +02:00
cf6e72b150
Optimised simplifyKnownVariables ( #1205 )
...
* Optimised simplifyKnownVariables
Changed the check for references to constant variables so instead of iterating through all tokens looking for references (which is very slow for large files), usages of each known variable are recorded so each usage can be checked for whether or not it is a reference. Just checking known usages is a lot quicker than checking through all tokens.
* Fixed test error caused by incorrect code
* Fixes to constant variable simplification optimisation
Indexing variables by varId is easier than by Token pointer, but means we also have to store a reference to the constant variable Token in another collection.
Switched to using unordered_map over map as it has slightly better find performance.
* Fixed incorrect simplification behaviour
This should remove constant variables correctly and efficiently. Requires additional functions, Token::deleteThisInPlace() and TokenList::front(Token*).
* Added setter for TokenList::first
This allows code that adds and removes Tokens from the list to do so without copying nodes into other nodes, which sometimes create difficulties.
* Added deleteThisInPlace function
This allows a token to delete itself without invalidating pointers to the node after it. If this token is the first or last in a list the calling code will have to remember to change the list's front or back.
* Added declaration for deleteThisInPlace()
* Removed premature MatchCompiler optimisation
* Added and removed some functions
Added declaration for deleteToken(Token*) which deletes a single token from the list
Removed public front(Token*) because it broke encapsulation
* Implemented deleteToken(Token*) function
* Removed 'delete this' from deleteThisInPlace
* Switched to using safer function
TokenList::deleteToken is better than calling straight into Token::deleteThisInPlace because it doesn't call delete this and doesn't break the TokenList's encapsulation.
* Replace constant variables in reverse order
This fixes the problem where you have two constant value assignment statements in a row. Replacing and deleting them in reverse order means we avoid the problem of deleteThis() potentially invalidating the pointer to the start of the next assignment statement
* Removed unneeded and unsafe deleteThisInPlace
* Removed unneeded and unsafe deleteThisInPlace
* Removed unneeded deleteToken
* Removed unneeded deleteToken
* Removed extra whitespace
2018-05-11 21:14:04 +02:00
ce30a3ca71
astyle formatting
...
[ci skip]
2018-05-11 14:49:31 +02:00
3044612fe9
Optimize usage of TemplateSimplifier::simplifyCalculations
2018-05-11 14:48:59 +02:00
c520735009
Improve checking of size condition against empty to avoid FPs ( #1213 )
...
* Improve checking of size condition against empty to avoid FPs
* Add const and todo for reverse conditions
2018-05-11 10:22:06 +02:00
1e7c1841f7
Fixed #8515 (Wrong info message about unmatched suppression)
2018-05-11 09:01:24 +02:00
7b6ddc50ae
astyle formatting
...
[ci skip]
2018-05-10 17:57:16 +02:00
184537884f
Don't remove the volatile keyword so we can properly overload functions. ( #1218 )
...
* Don't remove the volatile keyword so we can properly overload functions.
I fixed all the checks that had tests that use volatile. There will
probably be more changes needed due to lack of test coverage for
volatile in some checks.
* Fix unused private function warning.
2018-05-10 07:40:01 +02:00
5452c4dc4a
Fixed #8560 (Symboldatabase lacks entry for C++11 overloaded member function) ( #1217 )
2018-05-09 20:16:08 +02:00
129bdb2752
SymbolDatabase::createSymbolDatabaseSetTypePointers: Optimize ~90%
2018-05-09 13:48:55 +02:00
ab6167e3e6
TokenList::validateAst: optimised ~25%
2018-05-09 12:36:58 +02:00
ecccce0608
Tokenizer::setVarId: Made it ~5% faster
2018-05-09 10:25:29 +02:00
0197343e0c
Fix false positive when using null arithmetic with class type ( #1214 )
2018-05-09 09:06:49 +02:00
f5dbfce8ff
Fix false positive with oppositeExpression when using binary op ( #1211 )
...
* Fix false positive with oppositeExpression when using binary op
* Simplify conditional
2018-05-08 20:43:57 +02:00
c266688784
Fix syntax error
2018-05-08 10:21:03 +02:00
315dc2ad8a
only show information message when information messages are enabled
2018-05-08 09:47:14 +02:00
8b0b659965
Add support for namespace aliases and C++17 nested namespaces. ( #1210 )
...
* Add support for namespace aliases and C++17 nested namespaces.
These are implemented as tokenizer simplifications so changes are not
needed to the tokenizer and symbol database.
* Fix codacy warning.
2018-05-08 06:35:51 +02:00
8e8919e906
Fix comment
2018-05-07 22:06:23 +02:00
0bff08ca44
Fixed #1378 (#error macro makes unrelated errors undetectable)
2018-05-06 22:02:23 +02:00
3b8a3aa4ba
Fixed crashes in daca
2018-05-06 09:52:04 +02:00
8c2a5c9813
astyle formatting
...
[ci skip]
2018-05-06 09:50:53 +02:00
0561877182
Fix false positive with negative array index in issue 8536 ( #1202 )
...
* Fix FP with negative array index in valueflow
* Remove values when valueflow fails
* Add valueflow test
2018-05-06 08:35:29 +02:00
5d417bbfa1
SymbolDatabase: harden code for missing links ( #1207 )
...
* SymbolDatabase: harden code for missing links
Missing links for templates are common so check links before using them
to prevent crashes.
* SymbolDatabase: replace link check and single token match with match of two tokens
2018-05-06 08:23:07 +02:00
858e055c0e
ValueFlow: Wrote a few basic comments
2018-05-05 23:03:04 +02:00
067d82f0ea
Check for smart pointer release ( #1206 )
2018-05-05 18:06:49 +02:00
4408628107
Fixed #8538 (SymbolDatabase: wrong parsing of noexcept)
2018-05-05 08:31:56 +02:00
64b85b474c
Fixed #8542 (False positive: noOperatorEq)
2018-05-05 07:46:58 +02:00
7fb28b05f6
Check Class: Try to clarify the warnings for noCopyConstructor/noOperatorEq/noDestructor.
2018-05-04 15:39:23 +02:00
99003c2084
CheckClass: Better handling of defaulted and deleted functions in the noCopyConstructor/noOperatorEq/noDestructor
2018-05-04 14:58:38 +02:00
f2bb7397b3
astyle formatting
...
[ci skip]
2018-05-04 14:57:45 +02:00
cac68c6b81
Fix FP when using - as a binary operator ( #1201 )
2018-05-04 07:58:30 +02:00
f94e9c5447
Fix #8540 (Syntax error involving forward-declared 'enum class') ( #1203 )
2018-05-04 07:56:20 +02:00
59cc479855
Save bitfield bit counts
2018-05-02 20:55:11 +02:00
920b553ebf
astyle formatting
...
[ci skip]
2018-05-02 12:58:10 +02:00
7dfbe7389b
Clarify null pointer arithmetic message
2018-05-02 12:57:24 +02:00
f191a3e753
Improve checking of opposite expressions ( #1199 )
...
* Improve checking of opposite expressions
* Fix some formatting
2018-05-02 06:32:33 +02:00
b2343a2d4b
Fixed #8518 (Clarify warning for a NULL pointer which is received by a function call parameter.)
2018-05-01 17:30:29 +02:00
31148fdfed
Fixed #8523 (Clarify warning: noConstructor)
2018-05-01 15:50:03 +02:00
40b6f6b3dd
CheckClass: Fix the noDestructor warning
2018-05-01 15:31:13 +02:00
9710e819be
CheckClass: Disable noDestructor for now, we need to handle new better
2018-05-01 09:26:03 +02:00
42100fdf11
CheckClass: Better handling of non-copyable classes in the noCopyConstructor check
2018-05-01 08:33:23 +02:00
f0646d3754
checkunusedfunctions.cpp: Fix files.txt parsing ( #1197 )
...
On Windows searching for the last colon finds the colon which is part of
the path of the source file (e.g. "C:/projects/a.cpp"). Thus the path is
saved incomplete. This fix searches for the second instead of the last
colon and uses the data after the second colon as the path of the source
file.
2018-05-01 08:09:11 +02:00
c3c1abd05e
SymbolDatabase: improve checking of uninstantiated templates ( #1196 )
...
* SymbolDatabase: improve checking of uninstantiated templates
* Add bailout and debug warning for '>' token without a link in SymbolDatabase::findFunction()..
Don't crash on bad code simplification from tokenizer.
2018-05-01 07:32:19 +02:00
73b41455dd
CheckClass: If class has memory management it should have copy constructor, operator= and destructor
2018-04-30 23:13:33 +02:00
eb1571af81
Refactoring: use range for
2018-04-30 22:10:54 +02:00
fce7a0a128
dump: add Function::type
2018-04-30 16:52:51 +02:00
7015fb097e
SymbolDatabase::isFunction: better handling of return types
2018-04-29 15:35:31 +02:00
45c4456c24
Tokenizer: Code cleanup
2018-04-29 15:05:13 +02:00
ff732e41ac
SymbolDatabase: Remove unused Function constructor
2018-04-29 14:57:02 +02:00
e571e598b6
Fix false positive with inner conditions when using pointers ( #1195 )
2018-04-28 18:56:13 +02:00
521e3495b7
Adjustment for implementation of Token::insertToken() ( #1194 )
...
Three attributes are reset in this member function even if their values
are stored in the same token object.
Move a corresponding sanity check so that less assignments could be
performed eventually.
Link: https://trac.cppcheck.net/ticket/8532
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
2018-04-28 17:17:40 +02:00
ca8e19c96d
SymbolDatabase: Refactor SymbolDatabase: variable list
2018-04-28 09:38:33 +02:00
1a9e8c158d
CheckClass::copyconstructors: Use library to determine if function is a allocation function
2018-04-27 23:20:04 +02:00
c80c44ab20
Refactoring: use range for loop, early continue
2018-04-27 23:04:48 +02:00
f336c2efe7
Refactoring; Renamed Scope::classStart and Scope::classEnd
2018-04-27 22:36:30 +02:00
ed79f300f0
Refactoring; use range for loop, use early continue/break
2018-04-27 22:18:26 +02:00
e6a37ec0b7
Fixed #8531 (false positive: (style) The function 'foo' overrides a function in a base class but is not marked with a 'override' specifier.)
2018-04-27 21:49:18 +02:00
25599a76a7
Handle 'final' specifier better.
2018-04-27 14:57:43 +02:00
b830f462e6
Added missingOverride checker; Function 'f' overrides function in base class but does not have the 'override' keyword.
2018-04-27 11:12:09 +02:00
c7e5b941be
Symbol database: Minor tweaks
2018-04-27 10:35:11 +02:00
8304290f06
astyle formatting
...
[ci skip]
2018-04-27 10:29:27 +02:00
d15b945c9e
SymbolDatabase::isFunction: Fix wrong detection function
2018-04-27 10:24:02 +02:00
9fade65dbb
Ticket #8281 , #8417 : Properly detect the end of "switch" statements to accept all legitimate uses of "case". ( #1112 )
2018-04-26 22:26:26 +02:00
5384802e16
SymbolDatabase: Look for types in anonymous scopes
2018-04-26 17:55:04 +02:00
55983e2a0b
#8509 Uniform initialization ignored for iterator
2018-04-26 08:57:25 +02:00
d8634ca2a9
SymbolDatabase: Disable code for function pointers
...
This hopefully fixes all Travis crashes when running cppcheck:
[./test/Analysis/stack-addr-ps.c] (error) Internal error: Child process crashed with signal 11 [cppcheckError]
[./test/Index/complete-pointer-and-reference-to-functions.cpp] (error) Internal error: Child process crashed with signal 11 [cppcheckError]
[./test/SemaCXX/vararg-non-pod.cpp] (error) Internal error: Child process crashed with signal 11 [cppcheckError]
2018-04-25 18:48:26 +02:00
faf348306b
Escaped filename, which can contain invalid xml ( #1192 )
2018-04-25 18:28:04 +02:00
e95c6e3038
Travis: Fix segmentation fault
2018-04-25 16:02:42 +02:00
bd54986017
SymbolDatabase: Refactoring parsing of ) ... in functions
2018-04-25 14:35:09 +02:00
6efe118aa3
Fix Cppcheck warning
2018-04-25 14:29:34 +02:00
e97be9db2f
SymbolDatabase: Refactoring, move logic from SymbolDatabase to Function class. Add a Function::isOverride() method.
2018-04-25 12:05:49 +02:00
9aeb2aaa17
update doxygen comments
2018-04-25 10:14:57 +02:00
fac851192a
SymbolDatabase: fix problem where definition coudn't find forward declaration in class ( #1190 )
2018-04-24 22:43:47 +02:00
deaafd59d7
CheckClass: Undo the rule of 3 checker to avoid some warnings
2018-04-24 22:42:25 +02:00
995b496ddf
Add suppressions to the XML dump ( #1166 )
...
* Added parsing suppressions from dump xml.
* Added code to dump suppressions to an xml file
* Added declaration for dump function
* Suppressions will now be written to the xml file when a dump is requested
* Fixed syntax error
* Removed excess whitespace
* Fixed indentation to be consistent
* Fixed indentation to be consistent
* Fixed indentation to be consistent
* Added missing include for ErrorLogger::toXml
* Fixed suggestions from pull request #1166
Switched to using ranged for loop to iterate through suppressions.
Made the line number attribute optional, rather than 0 if not specified. This means when Python deserialises it it will be None, which is more pythonic.
* Implemented checking suppressions in reportError
This modification expects suppressions and a function to be called to write a line of output to be passed in. The function checks if any of the suppressions match the warning (with the new Suppression.isMatch function) and if so returns None. This change maintains the old behaviour of returning the warning text, but adds the possibility of returning None if the warning was suppressed.
* Fixed code quality warnings
* Removed more extraneous whitespace
2018-04-24 22:19:24 +02:00
485d3e0229
CheckClass: Tweak rule of 3 checker
2018-04-24 21:45:30 +02:00
5518247b96
Refactoring; use range for
2018-04-24 21:18:36 +02:00
b0b08a3bb0
Refactoring: Use range for loop
2018-04-24 18:17:47 +02:00
dbcdb19b73
Refactoring; Use range for
2018-04-24 18:02:36 +02:00
6fb25dcaa4
CheckClass: Changed checker for 'copy constructor' and 'operator=' to a 'rule of 3' checker
2018-04-24 16:07:58 +02:00
8310198cd5
SymbolDatabase: Refactoring and testing isImplicitlyVirtual
2018-04-24 13:53:58 +02:00
b94d8fd686
SymbolDatabase: Improve doxygen comments
2018-04-24 13:03:32 +02:00
c3cb0ddf8c
Refactoring; use range for loops
2018-04-24 11:13:19 +02:00
f7db818273
errorlogger: fix handling of {inconclusive}
2018-04-24 11:10:41 +02:00
22963f3ed8
Refactoring; use range for loop
2018-04-24 11:04:47 +02:00
bb227613bb
SymbolDatabase: Better type lookup in methods
2018-04-23 22:27:15 +02:00
f021094f75
minor refactorings in SymbolDatabase
2018-04-23 21:45:25 +02:00
e3a4ef795e
Refactoring: After conditional return the 'else' is not needed
2018-04-23 16:27:56 +02:00
6d86ad78ba
Refactoring, use early continue
2018-04-23 16:23:22 +02:00
84aaec26e6
--template: fixed {code} output with tabs
2018-04-23 14:11:33 +02:00
f058d9ad08
CLI: Added more fields for --template and added a new --template-location. The gcc predefined template now matches latest gcc better.
2018-04-23 12:21:18 +02:00
b44a40801b
ErrorLogger: add {column} and {code}
2018-04-23 09:18:32 +02:00
42c54f12fe
Refactoring: Use range for loops in CheckClass
2018-04-23 07:51:28 +02:00
e08683c009
Refactoring: Use range for loops in CheckFunctions
2018-04-23 07:49:38 +02:00
c6d834ae17
Refactoring: Use range for loops in CheckBool
2018-04-23 07:46:37 +02:00
b6e89f85d0
CheckOther: Use isLikelyStreamRead
2018-04-22 17:14:28 +02:00
b7a52c3811
CheckUnusedVar: Use isLikelyStreamRead
2018-04-22 17:08:23 +02:00
fba8208134
CheckUninitVar: Use isLikelyStreamRead
2018-04-22 17:04:54 +02:00
cc4977e140
Tweaking CheckUninitVar (<< and >> handling)
2018-04-22 16:39:57 +02:00
7b10375683
Try to make Travis happy
2018-04-22 14:00:03 +02:00
3d78320d04
CheckCondition: Use isLikelyStreamRead
2018-04-22 09:48:54 +02:00
0263452f5d
CheckClass: Use isLikelyStreamRead
2018-04-22 07:45:36 +02:00
be48de1be9
CheckClass: Use isLikelyStreamRead
2018-04-22 07:40:11 +02:00
121d4ff2ba
isLikelyStreamRead: when using & dont allow astParent
2018-04-22 07:30:45 +02:00
e1db4c0e2c
astyle formatting
...
[ci skip]
2018-04-21 13:28:31 +02:00
8cc7131ee9
Rename CppCheck::processFile to CppCheck::checkFile
2018-04-21 13:28:26 +02:00
a451a5b598
Ticket #8436 : Handle C++11 initializations within ternary operator. ( #1174 )
2018-04-21 11:30:07 +02:00
d939c6015a
Report opposite expressions ( #1182 )
...
* Report opposite expressions
* Skip assignment operator
2018-04-21 11:28:21 +02:00
bad66594d6
Fix double free regression with smart pointers ( #1184 )
2018-04-21 11:24:19 +02:00
2073bd02d8
Refactoring: Use range for loop
2018-04-20 22:13:05 +02:00
3fdb2da0d1
Refactoring: Use range for loop
2018-04-20 22:10:29 +02:00
46bb63ceaf
Refactoring: Use range for loop
2018-04-20 22:08:22 +02:00
d5fb529d4f
Fixed #8492 (Improve message: parameter should be passed by reference)
2018-04-20 17:33:42 +02:00
313b2a1755
Refactoring: Use ranged for loops
2018-04-19 22:31:36 +02:00
57019c0128
Fix comment in Tokenizer::simplifyMathFunctions ( #1179 )
...
In 9cea2d6df
2018-04-19 06:14:16 +02:00
b459da2ac3
Refactor Path::getRelativePath()
2018-04-18 22:23:38 +02:00
4b8769a9f5
astyle formatting
...
[ci skip]
2018-04-18 17:46:31 +02:00
7ee636b934
Refactoring: Reuse isLikelyStreamRead in isVariableChanged
2018-04-18 17:46:10 +02:00
26e36a1d6b
Fix FP uninitvar when stream bool operator is used
2018-04-18 16:13:24 +02:00
1b4f4d7130
Fixed #8495 (False positive: boolean result used in bitwise operation when & is overloaded)
2018-04-17 22:14:17 +02:00
219176c11c
Update isLikelyStreamRead ( #8494 )
2018-04-17 20:34:31 +02:00
7825eb8670
Refactoring; reuse isLikelyStreamRead
2018-04-17 19:51:27 +02:00
4f6bd5d607
Fix Travis
2018-04-17 14:54:12 +02:00
c84628c28a
Fixed #8494 (False positive: serialization class overloads operator)
2018-04-17 14:23:04 +02:00
7d5a1b1248
Fix shadow warning ( #1175 )
2018-04-17 08:37:41 +02:00
a4f8c44432
astyle formatting
...
[ci skip]
2018-04-16 12:55:37 +02:00
2a657cfd08
Check for double frees when using smart pointers ( #1172 )
...
* Check for double frees when using smart pointers
* Some updates from feedback
* Add test for mismatch allocation
* Constants
* Check smart pointer deleter
* Switch order
* Use next
* Add owned state
* Fix handling of leaks
* Use ast for checking addressof operator
* Remove stray character
* Add a test for mismatch allocator
* Add another test for deallocating with custom function
2018-04-16 11:11:13 +02:00
5c1540915d
Fix warning emitted by clang. ( #1173 )
2018-04-15 20:40:24 +02:00
9a0756c13f
CheckLeakAutoVar: clarify the code; replace magic values with constants, add a comment
2018-04-15 01:53:00 +02:00
6ecd638e49
chmod 644 checkinternal.*
...
[ci skip]
2018-04-14 19:45:42 +02:00
0a83c6b173
CheckInternal: Check that emplace is not used
2018-04-14 19:43:57 +02:00
e95ff8c7b6
Avoiding emplace
2018-04-14 19:24:35 +02:00
e73fe49d3c
4e820b6c4a
2018-04-14 15:46:55 +02:00
be78e44c3f
Revert "I see compilation problems with std::multimap::emplace on a old system so lets avoid that"
...
This reverts commit 4e820b6c4a
2018-04-14 15:43:14 +02:00
4e820b6c4a
I see compilation problems with std::multimap::emplace on a old system so lets avoid that
2018-04-14 15:19:04 +02:00
97c86ff0e6
Dumps: Added isVirtual/isImplicitlyVirtual info
2018-04-13 21:15:43 +02:00
f7d65cd735
SymbolDatabase: add constness attribute for Variable
2018-04-12 20:23:34 +02:00
c39a3e3f1c
windows string macros: Handle _T, _TEXT and TEXT internally, add tests ( #1163 )
...
Remove TEXT() macro from windows.cfg and handle it internally where it
can be correctly simplified (Ansi vs. Unicode).
Also add handling of _TEXT() macro which is just a synonym for _T().
Add tests to verify correct function and macro simplification.
2018-04-12 08:52:31 +02:00
b596b0d549
Refactorization: pass std::string directly to std::*fstream
2018-04-11 09:50:42 +02:00
d2146844dd
Refactorizations:
...
- Replace several push_back-calls by emplace_back
- Replace some x = x.substr(0, y) calls by x.erase(y)
2018-04-11 09:44:35 +02:00
a0c9de0048
Suppressions: Validate inline suppressions
2018-04-11 08:18:00 +02:00
87557afc43
Suppressions: Better XML formatting
2018-04-10 16:32:47 +02:00
a2b8eb7405
Suppressions: Report error if bad suppression element is used
2018-04-10 16:26:00 +02:00
1767fe525b
Addons: Fixed handling of noname arguments
2018-04-10 11:10:10 +02:00
8c082f1b3f
Remove lib/cxx11emu.h
2018-04-09 22:28:41 +02:00
c5923fbdd3
astyle formatting
2018-04-09 22:21:17 +02:00
8f84a493f4
remove foreach emulator
2018-04-09 22:09:10 +02:00
e6114a2321
glob patterns: wildcards also match path separators (like before)
2018-04-09 18:59:18 +02:00
8734e4dd38
Fix SymbolDatabase bailout to also support struct ( #1160 )
2018-04-09 18:53:55 +02:00
d8b3fa5c70
Fix #8482 : Regression with valueflow ( #1159 )
...
* Fix regression with valueflow
* Simplify test case
2018-04-09 16:13:17 +02:00
f677322c69
Suppressions: Allow symbol-based inline suppressions
2018-04-09 11:50:59 +02:00
17b4721bd2
C++17: Support "if constexpr" (by simplifying it to plain if() statement)
...
This might lead to complaints about constant expressions as if() statement, but should fix syntax errors.
2018-04-09 11:42:59 +02:00
b15cc3f236
Refactorization: Replace several push_back-sequences by initializer lists
2018-04-09 09:54:39 +02:00
6f9c115640
Refactoring: use range for loops
2018-04-09 08:00:11 +02:00
a0906140a6
Suppressions: New extensible Suppressions xml format that allow more attributes. To start with it also allows symbolName.
2018-04-09 06:43:48 +02:00
e2002db78d
Replaced make_container by C++11 initializer lists
2018-04-08 23:03:44 +02:00
ae3e649cc4
astyle formatting
...
[ci skip]
2018-04-08 20:29:52 +02:00
d9cbaa83d6
Extract common condition
2018-04-08 21:11:44 +03:00
95fc84a26b
Find duplicate expressions assigned to the same variable ( #1129 )
...
* Check for duplicate assignments
* Improve checking of expression
* Add more tests
* Use simple match
* Improve robustness of check
* check for null
* Reduce side effects by checking for side effects
* Improve verbose message
* Reword the error message
2018-04-08 14:43:19 +02:00
ee5c60e8f6
Refactoring, use early continue
2018-04-08 09:30:13 +02:00
795b9f5e0f
astyle formatting
2018-04-08 09:25:59 +02:00
aed84abfd5
Extend valueflow comparison ops ( #1153 )
...
* Handle else clause when doing a compare
* Break early
* Fix bug in checking no return else
* Escape quotes
* Add equal sign
* Simplify the logic
2018-04-08 09:24:01 +02:00
b85dda77da
Add a check for identical inner conditions ( #1156 )
2018-04-08 08:13:44 +02:00
541e255159
Remove inner identical condition
2018-04-08 08:12:56 +02:00
90983303f0
Fix #8477 (False positive caused by anonymous enum in method body) ( #1154 )
2018-04-08 08:00:12 +02:00
4f9073159a
Fix another SymbolDatabase bailout ( #1157 )
2018-04-08 07:29:19 +02:00
20f0784c06
Fix #8470 ((error) SymbolDatabase bailout; unhandled code) ( #1155 )
2018-04-07 16:41:39 +02:00
5a104cab6e
remove weird "#line 2" from valueflow.cpp
2018-04-06 23:26:08 +02:00
0daa3bba30
ValueType: Improved type handling of containers when [] operator is used
2018-04-06 22:26:35 +02:00
7e15e39f39
Fix some new SymbolDatabase bailout; unhandled code syntax errors. ( #1152 )
2018-04-06 21:32:32 +02:00
05acf9b352
Fixed #8470 ((error) SymbolDatabase bailout; unhandled code)
2018-04-06 16:03:58 +02:00
034296039c
Refactor lib/checkunusedvar.cpp
2018-04-06 08:07:15 +02:00
d2160f00b2
Refactor lib/checkuninitvar.cpp
2018-04-06 08:04:06 +02:00
15b5b7ebf4
Refactor lib/checkother.cpp
2018-04-06 08:00:10 +02:00
9f386d305a
Fixed #8280 (False positive uninitMemberVar - initialized from nested overloaded function) ( #1151 )
2018-04-06 07:53:05 +02:00
c5e14ad590
Refactor lib/checkmemoryleak.cpp
2018-04-05 21:41:31 +02:00
94048d93f6
Refactor lib/checkleakautovar.cpp
2018-04-05 15:58:28 +02:00
c367fc9f09
Refactor lib/checkio.cpp
2018-04-05 15:55:57 +02:00
17bd2f0c72
Refactor lib/checkcondition.cpp
2018-04-05 15:53:49 +02:00
043b64467b
Refactor lib/checkclass.cpp
2018-04-05 15:48:23 +02:00
4836df9b1d
Fix Token::Match pattern
2018-04-05 15:47:25 +02:00
e5db23fff3
project: import compile_commands.json generated by compiledb-generator
2018-04-05 15:40:59 +02:00
3ad6c7ebce
Refactoring, use early continue
2018-04-05 08:21:43 +02:00
67a71fa362
Refactor lib/checkbufferoverrun.cpp
2018-04-05 08:17:56 +02:00
e65c63e2bb
Refactor lib/astutils.cpp
2018-04-05 08:07:22 +02:00
214322d501
Refactor lib/tokenize
2018-04-05 08:02:59 +02:00
b871c85b67
Improve valeflow analysis with comparison operators ( #1131 )
...
* Improve valeflow analysis with comparison operators
* Use simple match
* Dont add 0 on comparisons
* Check reverse comparisons
* Use nullptr
* Remove duplicate code tests
2018-04-05 06:51:31 +02:00
54de7b48c9
Fix false positive when constructing with curly brace ( #1148 )
2018-04-05 06:47:59 +02:00
06133fa3ba
Refactor findFunction to unify two ValueFlow paths. ( #1149 )
2018-04-05 06:46:48 +02:00
0c6f184423
Fix false positive for opposite conditions when using different containers ( #1143 )
...
* Fix false positive for opposite conditions when using different containers
* Add additional test
2018-04-05 06:43:13 +02:00
b6504c70ca
Improve constness
2018-04-04 21:51:31 +02:00
a62c932a8f
Improve findFunction for function calls with function calls as arguments. ( #1147 )
...
Duplicate the existing logic for variable to variable type comparisons
for function return type to variable type comparisons.
2018-04-04 20:44:01 +02:00
0d434efc15
virtualCallInConstructor: Clarify warning message
2018-04-04 13:04:40 +02:00
b3b364b42f
virtualCallInConstructor: Updated warning message
2018-04-04 12:52:58 +02:00
3b07b749d6
Refactoring, use early return
2018-04-04 10:50:10 +02:00
fa968d75bd
Partial fix for #8291 : (False positive uninitMemberVar when calling delegated constructor) ( #1142 )
2018-04-04 08:29:12 +02:00
bce5fe5cef
Improve duplicate expressions in the ternary op by checking for equal values as well ( #1134 )
...
* Improve duplicate expressions in the ternary op by checking for equal values as well
* Use value instead of expression
2018-04-03 21:43:55 +02:00
d240a36a60
Extend nullPointerArithmetic to check for addition as well
2018-04-03 21:32:37 +02:00
ee22a325c7
virtual function call in constructor: don't warn about explicit scoped call
2018-04-03 14:02:59 +02:00
2a418fa0f5
Fixed #8466 (False Positive: Member variable is not initialized in the constructor. When using overloaded constructors) ( #1141 )
2018-04-02 18:32:45 +02:00
1046ca2120
Improve check: Warn about virtual function calls in constructor/destructor
2018-04-02 15:31:47 +02:00
e492932f19
Improve check: Variable is not initialized in private constructor (C++11 or later)
2018-04-02 15:26:15 +02:00
32a2060f14
Set version to 1.83.99/1.84 dev
...
Updated copyright year in version.h
2018-04-02 15:21:37 +02:00
9f92685b92
SymbolDatabase: Throw InternalError if parsing fails
2018-04-02 13:14:48 +02:00
c0272fc2ef
Fixed #8259 (Don't combine &= for anonymous reference parameters)
2018-04-01 10:27:16 +02:00
7260be81a6
Update version
2018-03-31 21:25:29 +02:00
7e4dba6a7e
Updated copyright year
2018-03-31 20:59:09 +02:00
4af2e517b9
Fixed #8465 (SymbolDatabase: bailout if there is 'struct A::B ab[5];')
2018-03-31 17:54:47 +02:00
ecfb4fd26c
Fix --dump output
2018-03-31 10:27:34 +02:00
da4fc25fee
Fixed #8432 (Problem with dump files and non-ASCII characters)
2018-03-30 22:34:55 +02:00
95ccd9483b
gcc 4.5 compatibility
2018-03-30 20:57:25 +02:00
dbe962ad5d
Compatibility fix for gcc 4.5
2018-03-29 22:00:04 +02:00
96167ffa51
Compatibility fixes for gcc 4.5
2018-03-29 17:37:06 +02:00
1bc8f7f29a
astyle formatting
2018-03-29 17:25:20 +02:00
70da3acb70
Add foreach emulation for older compilers ( #1138 )
2018-03-29 04:51:22 +02:00
210b921062
Fixed #8462 (AST: no ast created for 'e = { std::move(address),httpPort, (httpsPort) };')
2018-03-27 13:44:28 +02:00
e65a5529ad
astyle formatting
...
[ci skip]
2018-03-24 12:30:11 +01:00
43be20a824
Check more opposite conditions
2018-03-24 07:58:37 +01:00
5bc039b7da
Fix #6367 and #8439 (improve sizeof value flow support) ( #1132 )
2018-03-23 08:28:12 +01:00
5a444f764b
Fixed one more syntax error FP related to #8390
2018-03-22 15:20:37 +01:00
3d4b773fd1
Fixed #8390 (Syntax error from an MSVC internal header)
2018-03-22 09:07:58 +01:00
1ae75303a7
micro optimisation, use const reference
2018-03-19 09:53:14 +01:00
7699f6432b
Fixed #8288 (valueFlowGlobalVar: compound assignments)
2018-03-18 19:53:33 +01:00
f7d537ea26
Null pointers: better detection of null pointer dereference
2018-03-18 19:02:30 +01:00
ec6133aea2
Fixed #8182 (False positive uninitvar - variable initialized in function in ternary expression)
2018-03-16 19:13:48 +01:00
166e4cafcd
Check for functions calls in sizeof calculations ( #1111 )
...
* Check for functions calls in sizeof calculations
* Use seperate message and id for sizeofFunction
* Check for overloads
* Using decltype with a function should not be an error
* Fix warning
* Fix false positives when running pass the close paren
* Fix test error
* Try to fix more false positives
* Traverse using astOperand2
* Only check first argument
* Update fixes from feedback from PR
2018-03-15 10:24:17 +01:00
814828f436
dump: save if variable is const
2018-03-14 11:54:23 +01:00
2c3cd402ba
Thread safety: changed local static variable 'count' to member variable
2018-03-14 09:41:27 +01:00
9800e82d13
GUI: Allow that platform is selected in project dialog
2018-03-13 13:07:10 +01:00
0d2171a553
astyle formatting
2018-03-12 13:43:04 +01:00
31dd4ed787
use early continue
2018-03-12 12:50:33 +01:00
c0e14d0a5d
Added doxygen comment
2018-03-12 12:49:27 +01:00
3ef3a6088d
astyle formatting
2018-03-12 10:19:55 +01:00
a9b1f4c640
Taking care of operation overloading functions ( #1108 )
2018-03-12 10:25:30 +01:00
46307df9b6
Renamed method
2018-03-11 15:06:08 +01:00
380ecc408f
Fixed #8418 (AST: wrong ast for throw expression)
2018-03-10 22:30:21 +01:00
b1d943894b
Copy platforms/ directory to bin/
2018-02-27 09:09:12 +01:00
54d1490c89
platform.cpp: Fix that platform files on Windows are not found ( #1096 )
...
* platform.cpp: Fix that platform files on Windows are not found
I suggested this change here:
https://trac.cppcheck.net/ticket/8242#comment:7
* Use fromNativeSeparators() and only search for forwardslash
2018-02-26 13:51:02 +01:00
1628405869
Fix internal warning
2018-02-24 22:35:37 +01:00
7701e4594a
ValueFlowBeforeCondition: Fix wrong value in do-while condition when there is a break in the loop body
2018-02-24 22:07:34 +01:00
b7b376d901
checkTypes: Take into account type promotion to integer.
2018-02-19 23:55:38 +01:00
b1b3164259
checktype: Added handling of 'short'-type and added test cases.
2018-02-18 21:09:19 +01:00
50844aa7fc
checkType: Take into account the size of char.
2018-02-18 14:28:48 +01:00
5c44580528
Refactoring, use early continue and make code a bit more specific.
2018-02-16 22:59:38 +01:00
fcde1d80e9
Fix #8382 (Syntax error when scanning code with template and attribute) ( #1089 )
...
* Fix #8382 (Syntax error when scanning code with template and attribute)
This commit only addresses #8382 . There are issues concerning which
versions of C++ should be supported and also generic C++ 14 attribute
support which can be revisited later.
* Remove all C++ style attributes.
Remove all C++ style attributes when C++ version is 11 or greater.
Rename simplify function to simplifyCPPAttributes.
Handle more cases of roreturn function attribute.
2018-02-16 22:25:51 +01:00
03a222e926
Platform: Improve testability of platform file loading
2018-02-15 21:01:34 +01:00
b86b7175cb
cli:platforms: Added missing sizeof Boolean variable handling when platform file is loaded from XML.
2018-02-13 11:27:50 +01:00
1906067aac
cli:platforms: Fixed wrong loading of platform info.
2018-02-13 10:41:15 +01:00
69b50b274c
Try to make Travis happy
2018-02-11 22:54:14 +01:00
e62b9bdc77
Fixed #8348 (ValueFlow: wrong Uninit value with abort() in else-branch)
2018-02-11 22:14:44 +01:00
d68f07e50c
Add purgedConfiguration to list of error ids. ( #1087 )
...
purgedConfiguration was not showing up in the GUI supression list.
2018-02-10 22:30:49 +01:00
f5b91ffca8
Platform: Fix CFGDIR handling
2018-02-10 22:24:40 +01:00
db274e8308
Fix testrunner in cygwin
2018-02-10 15:34:49 +01:00
66d16b51f0
Ticket #8352 : Properly detect AST cycles. ( #1060 )
2018-02-10 14:39:57 +01:00
7c33207a72
astyle formatting
...
[ci skip]
2018-02-09 21:43:44 +01:00
e0e664f996
Fix permissions of certain non-executable files ( #1083 )
...
mode 0755 => 0644
2018-02-09 19:46:38 +01:00
b71c945ac4
fix build (CFG_DIR => CFGDIR) and run dmake.
2018-02-09 17:44:26 +01:00
780bd7e63e
More flexible loading of platform files, when using --platform it should not be necessary to provide the full path
2018-02-09 16:22:22 +01:00
85d8bbacb8
integerOverflow: Separate id for conditional integer overflows
2018-02-07 12:49:56 +01:00
58066b1f0c
Remove whole program analysis from 'uninitialized variables' and 'null pointer dereference' checkers. I think this logic can more or less be added in ValueFlow instead and then all ValueFlow checkers should get whole program analysis.
2018-02-06 14:56:17 +01:00
71511f3131
Refactor f487182
2018-02-06 08:59:36 +01:00
13daaac264
astyle formatting
...
[ci skip]
2018-02-06 08:10:28 +01:00
f487182075
Suppressed unused functions should not lead to nonzero exit code ( #1026 ) ( #1078 )
...
This is a fix of commit 97ffec8
2018-02-06 07:44:53 +01:00
8a3c25210d
SymbolDatabase: Remove useless break. As far as I know Tokenizer::syntaxError() throws an exception and therefore the break after the function call is unreachable
2018-02-05 23:28:33 +01:00
68eb6c4e6f
Refactoring: Add Tokenizer::findGarbageCode to time report. The method now calls syntaxError instead of returning an invalid token
2018-02-05 21:47:33 +01:00
dbc6771a0b
Uninitialized variables: Fix FP for unknown macro like 'list_for_each'
2018-02-04 22:30:08 +01:00
f009cfc845
fix some typos found by codespell.
2018-02-04 20:53:43 +01:00
4998248501
Null pointers: Fixed false positives when running whole program analysis. Copied the fix from the CheckUninitVar::isUnsafeFunction.
2018-02-04 15:29:57 +01:00
a61f21d1b6
Accept nested templates in tokenizer-simplify ( #1070 )
...
The following snippet triggerd the error:
template<typename DerivedT>
template<typename T>
auto ComposableParserImpl<DerivedT>::operator|( T const &other ) const -> Parser {
return Parser() | static_cast<DerivedT const &>( *this ) | other;
}
Whenever simplifyFunctionParameters was called on a templated class'
templated member function (and probably any nested template), the
tokenizer would recognise it as a syntax error, assuming that return
type *must* come after a template<> token.
2018-02-04 09:48:37 +01:00
d47b7726fa
Uninitialized variables: Fix potential false positives in subfunction if there is early return or conditional writes
2018-02-04 09:40:57 +01:00
1fe59faecb
changed message ids for uninitvar/nullpointer errors that was found by whole program analysis
2018-02-03 16:05:07 +01:00
d721c6aca5
Fixed #8386 (syntax error not found (segmentation fault)) ( #1081 )
2018-02-03 15:50:05 +01:00
82c963d3a2
symboldatabase: Fix null pointer dereference, introduced by ee1ba85e15 (comments).
2018-02-02 08:45:13 +01:00
ee1ba85e15
symboldatabase: Fix potential null pointer dereference ( #1072 )
...
There is a potential `nullPointer` dereference in symboldatabase. This PR attempts to fix this. Additionally, this could be detected by Cppcheck as well.
Here is a reduced and compilable testcase, where Cppcheck fails to detect a potential `nullPointer` dereference:
```
class Scope
{
public:
bool bar();
int *definedType;
};
int f(Scope *new_scope)
{
int ret = 1;
if (new_scope)
{
if (new_scope->bar())
{
if (!new_scope->definedType) {} // check for null
ret = *new_scope->definedType; // dereference
}
}
return ret;
}
```
The corresponding ticket on track, addressing the false negative: https://trac.cppcheck.net/ticket/8375
2018-01-31 11:00:42 +01:00
f5e6ef9fd2
checkio: Fixed potential usage of invalid iterator. ( #1066 )
...
* checkio: Fixed potential usage of invalid iterator.
* formatted the code.
A ticket about FN (invalidIterator1) is created at https://trac.cppcheck.net/ticket/8373
2018-01-30 08:43:15 +01:00
f5a11a6510
UninitVar: Speedup whole program analysis a bit
2018-01-29 15:15:35 +01:00
fb7f1efc49
token: Fixed potential null pointer dereference. ( #1062 )
2018-01-28 14:27:01 +01:00
21a35de0d2
Tokenizer: Refactoring garbage check
2018-01-27 22:26:43 +01:00
4d18d3948f
Fixes issue with case inside switch that is not a compound statement ( #1031 )
...
* Fixes issue with case inside switch that is not a compound statement was treated as garbage
This fixes an issue with the check for case keywords outside of switch
detection that would treat a case statement inside a switch that is not
a compound statement as garbage, but this is perfectly valid C++. This
construct is used in several libraries, i.e. Google Test.
* Tweak check and handle missing semicolon
Tweaks the check with feedback from danmar.
Handle the case where there is no semicolon and document it with a unit
test.
2018-01-27 22:21:26 +01:00
5b6ec49a6f
Pointer overflow: Fixed false positive
2018-01-27 22:09:43 +01:00
189e0b3890
Fix Cppcheck warning about uninitialized variable
2018-01-27 22:05:29 +01:00
bc40f5041d
Fixed #6356 (Improve checking: pointer arithmetic "ab.a + 100" overrun)
2018-01-27 15:39:39 +01:00
c110770481
Fixed #8325 (False negative: address of auto variable being returned when assigned to another variable first)
2018-01-27 14:48:45 +01:00
27d9aaa8f5
checkother: Removed statement that is always true. ( #1059 )
2018-01-26 22:49:07 +01:00
71ba513bdb
Ticket #8361 : Fix false positive in Tokenizer::findGarbageCode. ( #1061 )
2018-01-26 22:06:07 +01:00
3ebedcd7f5
Fixed VS crash for torture test
2018-01-26 16:05:43 +01:00
a5f202360a
Fixed crash for garbage code, found by fuzzing
2018-01-26 09:34:27 +01:00
cb297a00fc
Auto variables: Assign address of local variable to global pointer ( #6825 )
2018-01-25 22:50:41 +01:00
9109956c8c
UninitVar: Improve whole program analysis, used isVariableUsage()
2018-01-25 21:49:21 +01:00
51c2ded23f
Fix crash
2018-01-25 19:42:50 +01:00
1b3248b0fc
Dont write syntax error for lambda functions
2018-01-25 17:47:27 +01:00
4d66609173
Fix Cppcheck warning, uninitialized member variable
2018-01-25 17:29:08 +01:00
f73da16e94
Revert "UninitVar: Better checking in whole program analysis"
...
This reverts commit b2bdc2687b
2018-01-25 17:05:57 +01:00
b2bdc2687b
UninitVar: Better checking in whole program analysis
2018-01-25 15:56:46 +01:00
c04557eb73
Fix crashes detected with fuzzing
2018-01-25 15:53:58 +01:00
ce60b326f4
Whole program analysis: Improved handling of nested calls
2018-01-24 22:53:14 +01:00
599e038282
AutoVariables: Warn when address of local array is assigned to global pointer and pointer is not reassigned
2018-01-24 21:33:58 +01:00
8ce496a127
Fix possible null pointer dereference cppcheck warning. ( #1056 )
2018-01-24 21:19:52 +01:00
96e387a486
Fixed #8351 (segmentation fault on objective C code)
2018-01-24 18:06:11 +01:00
558e0757c2
Fix simplifyTypedef crash on lambda. ( #1054 )
2018-01-24 15:04:33 +01:00
0f561d0ed6
Fix crashes for garbage code, found by fuzzing
2018-01-24 13:53:03 +01:00
4710d80a40
Fix #5766 (FP: typedef array throws off parser) ( #1052 )
...
* Fix #5766 (FP: typedef array throws off parser)
* Fix travis build.
2018-01-24 09:51:22 +01:00
e6d285d3ca
Fixed #8357 (crash: cmake Tests/CMakeLib/testUTF8.cxx --debug --verbose) ( #1046 )
2018-01-22 08:06:56 +01:00
512b9f512c
Refactoring whole program analysis for CheckUninitVar and CheckNullPointer
2018-01-21 22:56:46 +01:00
3159d151d3
Fix symbol database crash on template type aliases by ignoring them. ( #1045 )
2018-01-21 21:22:26 +01:00
Daniel Marjamäki
Sebastian
orbitcowboy
Pavel Pimenov
Paul Fultz II
amai2012
amai2012
Matthias Krüger
rebnridgway
IOBYTE
umanamente
bwoester
PKEuS
Simon Martin
Markus Elfring
rikardfalkeborn
PKEuS
Dmitry-Me
jrp2014
Hinterwaeldlers
Lauri Nurmi
Ivan Maidanski
Jørgen Kvalsvik
orbitcowboy
David Hallas