Support GNU convention variables (prefix, bindir, man1dir) and DESTDIR

- Modify makefile to support GNU convention makefile variable names,
    including prefix, bindir, datarootdir, mandir, and man1dir.
    It is tweaked so that the older variable names (e.g., INSTALL_DIR)
    will continue to work.
  - DESTDIR support added.
  - Predefined a useful INSTALL_PROGRAM makefile variable; that means
    that users can redefine it if they want.

INSTALL.txt

@@ -16,13 +16,23 @@ So, here's how to do that.
     tar xvf flawfinder*.tar
     cd flawfinder-*
 
-* Decide where you want to put it.  Flawfinder normally installs
+* Decide where you want to put it.  Flawfinder normally installs everything
   in /usr/local, with the program in /usr/local/bin and the manual in
-  /usr/local/man, per GNU conventions.  You can override this
-  using the normal GNU conventions when installing (with "make install")
-  by setting INSTALL_DIR (defaults to /usr/local),
+  /usr/local/share/man/man1, per GNU conventions.  You can override this
+  when installing (with "make install") by setting some environment
+  variables.  You can do this by setting traditional GNU variables, e.g.,
+  make prefix=/usr install
+  will install the flawfinder program to /usr/bin/flawfinder
+  and the man page to /usr/share/man/man1/flawfinder.1.
+  You can override the specific manual page locations by setting
+  "bindir" and "man1dir" on the command line with make.
+
+  You can also use the older flawfinder makefile variables to control
+  installation; you can set INSTALL_DIR (defaults to /usr/local),
   INSTALL_DIR_BIN for the program location (defaults to INSTALL_DIR/bin), and
-  INSTALL_DIR_MAN for the manual location (defaults to INSTALL_DIR/man).
+  INSTALL_DIR_MAN for the manual location
+  (currently defaults to $(INSTALL_DIR)/share/man/man1 per GNU convention;
+  its former default location was $(INSTALL_DIR)/man/man1).
 
 * If you're using Cygwin on Windows, you can install it using "make install"
   but you need to tell the makefile to use the .py extension

makefile

@@ -16,9 +16,22 @@ ARCH=noarch
 
 SAMPLE_DIR=/usr/src/linux-2.2.16
 
-INSTALL_DIR=/usr/local
-INSTALL_DIR_BIN=$(INSTALL_DIR)/bin
-INSTALL_DIR_MAN=$(INSTALL_DIR)/man/man1
+# Flawfinder has traditionally used INSTALL_DIR, INSTALL_DIR_BIN, and
+# INSTALL_DIR_MAN.  Here we add support for GNU variables like prefix, etc.;
+# users who override the older flawfinder-specific variable names will
+# not notice any changes.  We define exec_prefix oddly so we can
+# quietly merge these 2 systems:
+
+prefix=/usr/local
+INSTALL_DIR=$(prefix)
+exec_prefix=$(INSTALL_DIR)
+bindir=$(exec_prefix)/bin
+INSTALL_DIR_BIN=$(bindir)
+
+datarootdir=$(INSTALL_DIR)/share
+mandir=$(datarootdir)/man
+man1dir=$(mandir)/man1
+INSTALL_DIR_MAN=$(man1dir)
 
 FLEX=flex
 
@@ -34,6 +47,8 @@ PYTHONEXT=
 
 RPMBUILD=rpmbuild
 
+DESTDIR=
+
 all: flawfinder.pdf flawfinder.1.gz
 	chmod -R a+rX *
 
@@ -42,6 +57,9 @@ all: flawfinder.pdf flawfinder.1.gz
 # and required by SUSv3 (and probably earlier, I haven't checked).
 MKDIR_P=mkdir -p
 
+INSTALL_PROGRAM=cp -p
+INSTALL_DATA=cp -p
+
 # This installer doesn't install the compiled Python bytecode.
 # It doesn't take long to compile the short Python code, so
 # it doesn't save much time, and having the source code available
@@ -49,14 +67,14 @@ MKDIR_P=mkdir -p
 # (admittedly rare) problem of bad date/timestamps causing the
 # compiled code to override later uncompiled Python code.
 install:
-	-$(MKDIR_P) $(INSTALL_DIR_BIN)
-	cp flawfinder$(PYTHONEXT) $(INSTALL_DIR_BIN)/flawfinder$(PYTHONEXT)
-	-$(MKDIR_P) $(INSTALL_DIR_MAN)
-	cp flawfinder.1 $(INSTALL_DIR_MAN)/flawfinder.1
+	-$(MKDIR_P) $(DESTDIR)$(INSTALL_DIR_BIN)
+	$(INSTALL_PROGRAM) flawfinder$(PYTHONEXT) $(DESTDIR)$(INSTALL_DIR_BIN)/flawfinder$(PYTHONEXT)
+	-$(MKDIR_P) $(DESTDIR)$(INSTALL_DIR_MAN)
+	$(INSTALL_DATA) flawfinder.1 $(DESTDIR)$(INSTALL_DIR_MAN)/flawfinder.1
 
 uninstall:
-	rm $(INSTALL_DIR_BIN)/flawfinder$(PYTHONEXT)
-	rm $(INSTALL_DIR_MAN)/flawfinder.1
+	rm -f $(DESTDIR)$(INSTALL_DIR_BIN)/flawfinder$(PYTHONEXT)
+	rm -f $(DESTDIR)$(INSTALL_DIR_MAN)/flawfinder.1
 
 flawfinder.1.gz: flawfinder.1
 	gzip -c9 < flawfinder.1 > flawfinder.1.gz