Commit Graph

122 Commits

Author SHA1 Message Date
David A. Wheeler 1de04d3dca Mass reformat of flawfinder source code to better comply with PEP 8
This reformats the source code's style to better comply with
Python PEP 8.

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
2017-07-30 20:06:39 -04:00
David A. Wheeler d06466bd2a Fix minor style issues identified by pylint
Pylint is a static analyzer of Python code.  It seems appropriate
to use a static analyzer to analyze a static analyzer :-).
None of the changes here fix a flaw in flawfinder.
The goal here is to follow PEP 008 more closely in the hope that
the changes make it easier for other developers to improve it further.

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
2017-07-30 16:49:11 -04:00
David A. Wheeler 595f45ad13 Add information about pylint
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
2017-07-30 16:35:45 -04:00
David A. Wheeler 9309aa9c63 Add CONTRIBUTING.md documentation
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
2017-07-29 17:46:15 -04:00
David A. Wheeler 02029816d4 Add rules to detect g_*rand* functions
Thanks to Michael McConville for this suggestion!

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
2017-07-29 16:35:06 -04:00
David A. Wheeler 6f399a0a25 Add support for generating CSV files
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
2017-07-29 16:21:00 -04:00
David A. Wheeler 872109f230 Change version number to 2.0.0 - use Semantic Versioning
This switches flawfinder's version naming conventions to comply with
Semantic Versioning.  We change the first digit to "2" because
there's a subtle change in how CWEs are reported - see the
ChangeLog or documentation for more information.

Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
2017-07-29 13:24:25 -04:00
David A. Wheeler 8f62d4290b flawfinder: remove some trailing whitespace 2014-09-07 14:14:55 -04:00
David A. Wheeler dc04172c52 flawfinder.1: Note that .makepp is also skipped by default 2014-09-07 14:14:34 -04:00
David A. Wheeler 94a20df2ee flawfinder.1: Tweak documentation about flag syntax 2014-09-07 14:05:52 -04:00
David A. Wheeler f6814c97c1 Reduce risk level to 0 of snprintf with constant format string
- snprintf is a useful *countermeasure* for buffer overflows,
    and unlike some alternatives it is standard and *widely* available.
    (strlcpy/strlcat are useful but not standard and not widely available;
    snprintf_s is standard but not widely available).
    Historically we warned about snprintf because old systems didn't
    implement it correctly, but at this point these old systems are
    more historical than anything else.
    Instead, let's specifically *mention* snprintf as a recommended
    potential solution for buffer overflows.
2014-09-01 15:14:55 -04:00
David A. Wheeler 6031b31f8c Add Microsoft banned list for string concatenation 2014-08-09 13:44:32 -04:00
David A. Wheeler aa2277b862 Add Microsoft banned functions for string copy and replacement 2014-08-09 13:32:37 -04:00
David A. Wheeler 0b432d2791 Change syntax of CWE mapping reports for CWE hierarchies (use "!" for map)
- The old syntax was very confusing.  Now just report
    higher-level/lower-level, with "!" after the CWE that is actually
    the mapping.
2014-08-09 13:06:50 -04:00
David A. Wheeler 0d56338062 flawfinder.1: Fix typo 2014-08-04 22:49:19 -04:00
David A. Wheeler 58749e78bc Change version number to 1.32
- Change version number early to prevent accidentally confusing
    this version with a released version.
2014-08-04 22:48:41 -04:00
David A. Wheeler aad0ac207c ChangeLog: Update release date 2014-08-03 18:31:02 -04:00
David A. Wheeler b8567a6702 makefile: Add an optional target to generate HTML documentation 2014-08-03 16:19:55 -04:00
David A. Wheeler bb09b9075b ChangeLog: Document better error reporting 2014-08-03 15:33:38 -04:00
David A. Wheeler 5156456c79 flawfinder: Improve error-handling. Warn of non-existent files (esp long dash)
- Provide a separate warning for filenames listed on the command line
    but do not actually exist.
  - Provide a SPECIAL warning for filenames that begin with
    the UTF-8 sequence of long dashes. Users might
    copy-and-paste from the pdf version of the man page, and that might
    produce long dashes (instead of normal dashes).  This problem
    can be hard to detect, so specially warning about it should help.
2014-08-03 15:29:05 -04:00
David A. Wheeler 547d1f3e17 Sending warnings to stderr, not stdout 2014-08-03 15:10:39 -04:00
David A. Wheeler 36b513af7c flawfinder.1: Update manual page date 2014-08-03 14:53:10 -04:00
David A. Wheeler 0017add313 README: Tweak so intro sentence similar to man page 2014-08-03 14:47:47 -04:00
David A. Wheeler d30fc2c1ac README: Rewrite to explain more. 2014-08-03 14:01:30 -04:00
David A. Wheeler ba844e7eea README: Fix spelling error 2014-08-03 13:18:51 -04:00
David A. Wheeler 2c383e37a7 flawfinder.1: Note that .git and .svn are examples of directories skipped 2014-08-03 13:17:43 -04:00
David A. Wheeler 1790331438 Update makefile: Don't use ",1" as temporary directory 2014-08-02 22:39:03 -04:00
David A. Wheeler 1d9000a8c3 README: Update contents 2014-08-02 22:36:00 -04:00
David A. Wheeler 9305afcb6e INSTALL.txt: Make it clear that you can simply run without installing. 2014-08-02 22:26:37 -04:00
David A. Wheeler 7727f10dce flawfinder.1: Trivial reformat 2014-08-02 22:25:20 -04:00
David A. Wheeler 75ce30e1c1 ChangeLog: Update for upcoming release 2014-08-02 22:15:51 -04:00
David A. Wheeler 4159de084a Document how to find all patterns that do NOT have a CWE mapping. 2014-08-02 22:05:23 -04:00
David A. Wheeler 16ac21ca1f Fix some warning text (CWE reference was in wrong place) 2014-08-02 21:59:28 -04:00
David A. Wheeler f05aa1270e flawfinder.1: Grammar fix 2014-08-02 21:56:19 -04:00
David A. Wheeler 8f9ccc47ea Add option "-H" as a synonym for "--html" to generate HTML 2014-08-02 21:50:21 -04:00
David A. Wheeler 4c36be0094 Reorder help information, help and version are really common requests 2014-08-02 21:46:29 -04:00
David A. Wheeler 24b7da535b flawfinder.1: Minor doc cleanups. Note that --listrules works with -D 2014-08-02 21:39:36 -04:00
David A. Wheeler 3b2f032f25 flawfinder.1: Specially document -QDSC example (useful for tool writers) 2014-08-02 21:07:42 -04:00
David A. Wheeler 4f363e6766 flawfinder: Document Python language version issues 2014-07-30 23:45:39 -04:00
David A. Wheeler fae254288c Tweak README to explain, in a little more detail, what it is. 2014-07-30 23:25:10 -04:00
David A. Wheeler 304225c9bd Use non-integer division (requires Python 2.2+)
- Add "from __future__ import division".  This is the default in
     Python 3, and has been long available in Python 2.
2014-07-29 08:43:27 -04:00
David A. Wheeler 7e655111a9 flawfinder: Make comments fit in 80 char columns 2014-07-29 08:39:30 -04:00
David A. Wheeler 43ada0aae8 Reformat comments to be less than 80 columns long. 2014-07-29 08:37:06 -04:00
David A. Wheeler f74076c2fa Remove unnecessary invocation of "apply"
- Remove unnecessary invocation of "apply".
    Python 2.4 deprecated "apply", and Python 3 removes it.
2014-07-29 08:29:02 -04:00
David A. Wheeler bc5eef939f flawfinder: Replace tabs with spaces, making indentation char consistent 2014-07-29 08:23:24 -04:00
David A. Wheeler f351b779ac flawfinder: Change constructs of form "d.has_key(d)" to "k in d".
- Change code to be more idiomatic and closer to Python 3,
    while staying in Python 2.  For more information, see:
    http://www.dwheeler.com/essays/python3-in-python2.html
2014-07-29 08:18:52 -04:00
David A. Wheeler bb6fa514c5 makefile: Tweak internal convenience target 2014-07-28 22:09:49 -04:00
David A. Wheeler 492130a44b ChangeLog: Document version differences 2014-07-28 22:06:55 -04:00
David A. Wheeler d769867375 Clearly document the license (GPLv2+) 2014-07-28 21:58:22 -04:00
David A. Wheeler cbb0a2426c INSTALL.txt: Simplify text. 2014-07-28 21:41:02 -04:00