walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add note about unsafe shape_plan->face 

Will fix by removing shape_plan->face completely.
This commit is contained in:
Behdad Esfahbod 2013-12-02 05:17:14 -05:00
parent aec468f01e
commit 8ffa528f28
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hb-shape-plan.cc
View File

@ -396,6 +396,8 @@ retry:
} }
/* Release our reference on face. */ /* Release our reference on face. */
/* XXX This is unsafe, since the face can be freed before us,
* and we will call hb_face_destroy() in our destroy()! */
hb_face_destroy (face); hb_face_destroy (face);
return hb_shape_plan_reference (shape_plan); return hb_shape_plan_reference (shape_plan);