walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "[map] Add hb_map_filter_invalid" 

This reverts commit 8d7e921117.

Surprisingly this slowed NotoNastaliqUrdu benchmark down by a couple
percent instead of speeding it up.
This commit is contained in:
Behdad Esfahbod 2022-12-04 11:13:39 -07:00
parent 8d7e921117
commit dbbb8e8006
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/OT/Layout/Common/Coverage.hh
View File

@ -147,8 +147,8 @@ struct Coverage
TRACE_SUBSET (this); TRACE_SUBSET (this);
auto it = auto it =
+ iter () + iter ()
| hb_filter (c->plan->glyph_map_gsub)
| hb_map_retains_sorting (c->plan->glyph_map_gsub) | hb_map_retains_sorting (c->plan->glyph_map_gsub)
| hb_filter (hb_map_filter_invalid)
; ;
// Cache the iterator result as it will be iterated multiple times // Cache the iterator result as it will be iterated multiple times

2
src/hb-map.hh
View File

@ -451,8 +451,6 @@ struct hb_map_t : hb_hashmap_t<hb_codepoint_t,
hb_map_t (const Iterable &o) : hashmap (o) {} hb_map_t (const Iterable &o) : hashmap (o) {}
}; };
static inline bool hb_map_filter_invalid (hb_codepoint_t _) { return _ != HB_MAP_VALUE_INVALID; }
template <typename K, typename V> template <typename K, typename V>
static inline static inline
hb_hashmap_t<K, V>* hb_hashmap_create () hb_hashmap_t<K, V>* hb_hashmap_create ()