walkero
/
harfbuzz
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't declare extern symbols as inline 

clang -O3 was completely removing _get_gdef(), causing link
failure when needed from another compilation unit.  Surprisingly,
"extern inline" didn't fix it.
This commit is contained in:
Behdad Esfahbod 2018-08-28 18:27:41 -07:00
parent 967741e4c4
commit fee0f41c6c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/hb-ot-layout.cc
View File

@ -56,7 +56,7 @@
// return *(data->base.get ()); // return *(data->base.get ());
// } // }
inline const OT::GDEF& _get_gdef (hb_face_t *face) const OT::GDEF& _get_gdef (hb_face_t *face)
{ {
if (unlikely (!hb_ot_shaper_face_data_ensure (face))) return Null(OT::GDEF); if (unlikely (!hb_ot_shaper_face_data_ensure (face))) return Null(OT::GDEF);
return *hb_ot_face_data (face)->GDEF->table; return *hb_ot_face_data (face)->GDEF->table;
@ -71,7 +71,7 @@ static inline const OT::GSUB& _get_gsub (hb_face_t *face)
if (unlikely (!hb_ot_shaper_face_data_ensure (face))) return Null(OT::GSUB); if (unlikely (!hb_ot_shaper_face_data_ensure (face))) return Null(OT::GSUB);
return *hb_ot_face_data (face)->GSUB->table; return *hb_ot_face_data (face)->GSUB->table;
} }
inline const OT::GSUB& _get_gsub_relaxed (hb_face_t *face) const OT::GSUB& _get_gsub_relaxed (hb_face_t *face)
{ {
return *hb_ot_face_data (face)->GSUB.get_relaxed ()->table; return *hb_ot_face_data (face)->GSUB.get_relaxed ()->table;
} }
@ -85,7 +85,7 @@ static inline const OT::GPOS& _get_gpos (hb_face_t *face)
if (unlikely (!hb_ot_shaper_face_data_ensure (face))) return Null(OT::GPOS); if (unlikely (!hb_ot_shaper_face_data_ensure (face))) return Null(OT::GPOS);
return *hb_ot_face_data (face)->GPOS->table; return *hb_ot_face_data (face)->GPOS->table;
} }
inline const OT::GPOS& _get_gpos_relaxed (hb_face_t *face) const OT::GPOS& _get_gpos_relaxed (hb_face_t *face)
{ {
return *hb_ot_face_data (face)->GPOS.get_relaxed ()->table; return *hb_ot_face_data (face)->GPOS.get_relaxed ()->table;
} }