80cd92326f
[Indic] Only apply basic features per-syllable
...
Free up syllables and let features work across syllables for the
presentation forms features and GPOS.
Fixed:
- 1 GURMUKHI test (remains 40)
- 12 KHMER tests (remains 18)
- 11 SINHALA tests (remains 121)
Regresses:
- 5 MALAYALAM tests (up to 312)
Current numbers:
BENGALI: 353996 out of 354285 tests passed. 289 failed (0.0815727%)
DEVANAGARI: 707339 out of 707394 tests passed. 55 failed (0.00777502%)
GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%)
GURMUKHI: 60769 out of 60809 tests passed. 40 failed (0.0657797%)
KANNADA: 951086 out of 951913 tests passed. 827 failed (0.0868777%)
KHMER: 299106 out of 299124 tests passed. 18 failed (0.00601757%)
LAO: 53611 out of 53644 tests passed. 33 failed (0.0615167%)
MALAYALAM: 1048104 out of 1048416 tests passed. 312 failed (0.0297592%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271726 out of 271847 tests passed. 121 failed (0.0445103%)
TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%)
TELUGU: 970558 out of 970573 tests passed. 15 failed (0.00154548%)
TIBETAN: 208469 out of 208469 tests passed. 0 failed (0%)
2012-08-23 12:06:14 -04:00
df5d5c68f3
Whitespace
2012-08-23 09:33:30 -04:00
2f1747ed7d
Add comment
2012-08-16 11:46:46 -04:00
bd08d5d126
[OT] Fix Arabic shaper OOB access
...
https://bugzilla.mozilla.org/show_bug.cgi?id=782908
2012-08-16 11:35:50 -04:00
daf0731865
[ICU] Fix includes
...
As reported by Steven Loomis, including uversion.h works everywhere.
2012-08-16 07:32:59 -04:00
a67ba9c0fe
Whitespace
2012-08-15 18:52:17 -04:00
45c1383cc7
Minor
2012-08-14 09:33:18 -04:00
4ac4c6f2e1
Fix ICU build with older ICUs
2012-08-13 10:52:52 -04:00
d5045a5f40
[ICU] Use new normalizer2 compose/decompose API
...
It's considerably faster than the fallback implementation we had
previously!
2012-08-11 21:27:15 -04:00
9f9f04c222
[OT] Unbreak Thai shaping and fallback Arabic shaping
...
The merger of normalizer and glyph-mapping broke shapers that
modified text stream. Unbreak them by adding a new preprocess_text
shaping stage that happens before normalizing/cmap and disallow
setup_mask modification of actual text.
2012-08-11 18:34:13 -04:00
e9f28a38f5
[OT] Add shape_plan to Arabic shaper
2012-08-11 18:20:54 -04:00
daf13afb08
[OT] Implement fallback mark positioning for "double" combining marks
2012-08-10 16:38:44 -04:00
d345313104
[OT] Fix fallback mark positioning with left-to-right text
...
Ouch!
2012-08-10 16:34:04 -04:00
f4cb476298
[OT] Slightly adjust normalizer
...
The change is very subtle. If we have a single-char cluster that
decomposes to three or more characters, then try recomposition, in
case the farther mark may compose with the base.
2012-08-10 03:51:44 -04:00
07d6828063
Minor
2012-08-10 03:28:50 -04:00
b00321ea78
[OT] Avoid calling get_glyph() twice
...
Essentially move the glyph mapping to normalization process.
The effect on Devanagari is small (but observable). Should be more
observable in simple text, like ASCII.
2012-08-09 22:33:32 -04:00
12c0875eaf
[OT] Remove redundant check
2012-08-09 22:02:54 -04:00
5c60b70c89
[OT] More code shuffling around
...
Preparing for merging map_glyphs() and normalize().
2012-08-09 21:58:07 -04:00
cd0c6e148f
Shuffle buffer variable allocations around
...
To room for more allocations, coming.
2012-08-09 21:48:55 -04:00
8d1eef3f32
Minor
2012-08-09 21:35:47 -04:00
56c9e7c004
Fill out combining class resetting for fallback shaping Thai/Lao/Tibetan
2012-08-09 21:14:23 -04:00
a321e1d51e
Revert "Reject lookups with no subTable"
...
This reverts commit 30ec9002d8
2012-08-09 18:30:34 -04:00
2eaf482b37
Revert "[GSUB/GPOS] Reject Context/ChainContext lookups with zero input"
...
This reverts commit 0981068b75
2012-08-09 18:30:05 -04:00
a02d86484b
Add check-exported-symbols.sh
...
And misc linking fixes.
2012-08-08 18:04:29 -04:00
4c8ac4f47e
Misc minor fixes
2012-08-08 17:44:19 -04:00
560d68af81
Use a export-file for Windows builds
...
Apparently even that doesn't make check-internal-symbols.sh happy with
mingw32. Going to disable that for DLLs again, but hopefully the
export-file is doing *something*.
2012-08-08 17:16:01 -04:00
f8751cf8e0
[hb-old] speed-up build
2012-08-08 17:15:44 -04:00
5f4c52867c
Minor
2012-08-08 16:53:37 -04:00
7e7d245b33
Make default_language threadsafe
2012-08-08 15:23:48 -04:00
06b192c458
Minor
2012-08-08 15:23:45 -04:00
37191ede75
Minor
2012-08-08 14:59:09 -04:00
6d9a329a8a
Adjust a couple source checks
2012-08-08 14:48:41 -04:00
9c929abdcf
Minor renaming
2012-08-08 14:33:37 -04:00
801298b590
Fix cast
...
https://bugs.freedesktop.org/show_bug.cgi?id=53233
2012-08-08 14:26:36 -04:00
21756934a1
[OT] Implement fallback positioning
...
Implemented for Arabic, Hebrew, and generic marks.
Activated if no GPOS table present.
2012-08-08 01:20:45 -04:00
fb56e76283
[hb-old] Fix warnings
2012-08-07 23:44:47 -04:00
affaf8a0e5
[OT] Start adding fallback positioning
...
Used when there is no GPOS.
2012-08-07 22:43:07 -04:00
7e4920fd15
Minor
2012-08-07 22:32:23 -04:00
472f229a63
[GSUB] Generalize would_apply()
...
Fixes logic also, where before we were always matching if glyphs_len==1
and a ligature started with the glyph.
2012-08-07 22:25:24 -04:00
6f3a300138
Add hb_font_glyph_from/to_string
2012-08-07 22:13:25 -04:00
eb56f6ae96
Minor
2012-08-07 21:44:25 -04:00
f4e48adcdd
[OT] Apply 'rclt' feature in horizontal mode
...
'rclt' is "Required Contextual Forms" being proposed by Microsoft.
It's like 'calt', but supposedly always on. We apply 'calt' anyway,
and now apply this too.
2012-08-07 21:12:49 -04:00
b1914b8bd0
Fix warnings
2012-08-07 16:57:48 -04:00
0f8881d6bb
More refactoring
2012-08-07 16:57:02 -04:00
428dfcab66
Minor refactoring
2012-08-07 16:51:48 -04:00
61f41849af
Add Hebrew presentation forms shaping
...
Lifted from https://bugzilla.mozilla.org/show_bug.cgi?id=728866
2012-08-07 16:45:27 -04:00
32d71dc133
[Graphite] Minor
2012-08-07 14:21:12 -04:00
030ac5022e
Remove enum trailing comma
...
...again.
2012-08-07 13:01:12 -04:00
368b4e7649
Minor
2012-08-06 23:06:04 -04:00
ade7459ea7
[util] Fix leaks
2012-08-06 19:49:42 -07:00
2fef993460
[Graphite] Fix graphite2 backend with RTL text
...
Patch from Martin Hosken.
2012-08-06 19:35:04 -07:00
e4992e13e1
[Graphite] Port graphite2 backend to new shaper infrastructure
2012-08-06 19:29:53 -07:00
66591ececf
Remove unnecessary lifecycle bits
...
We already set recount to INVALID when destroying.
This block was not necessary.
2012-08-06 17:07:19 -07:00
167b625d98
[Indic] Minor, move 'blwf' after 'half'
...
We don't apply them together anyway. Should not make any difference
right now.
2012-08-05 21:16:26 -07:00
048e3b596f
Speed up hb_set_digest_lowest_bits_t calcs
2012-08-04 20:46:45 -07:00
3d1b66a35e
Speed up hb_set_digest_common_bits_t calcs
2012-08-04 17:42:28 -07:00
25326c2359
Rewrite ARRAY_LENGTH as a template function
...
Such it wouldn't apply to pointers accidentally.
2012-08-04 16:43:18 -07:00
8ba8042821
[Indic] Fix consonant position font lookup logic
...
Oops. I broken this badly and the test suite did not notice. That
worries me. Have to investigate.
2012-08-03 18:54:54 -07:00
abd0c05f1f
Minor
2012-08-03 18:45:05 -07:00
46ee108ef8
Fix leak
2012-08-03 18:21:13 -07:00
71baea0062
[OT] Use general-category, not GDEF class, to decide to zero mark advances
...
At this point, the GDEF glyph synthesis looks pointless. Not that I
have many fonts without GDEF lying around.
As for mark advance zeroing when GPOS not available, that also is being
replaced by proper fallback mark positioning soon.
2012-08-03 17:40:07 -07:00
3a7e137a68
Dn't use gint
2012-08-03 17:23:40 -07:00
11b0e20ba4
[Indic] Add per-script configuration tables
...
This concludes the Indic shape_plan work. May do for Arabic also...
2012-08-02 14:21:40 -04:00
85fc6c483f
[Indic] Move more stuff to the shape_plan
...
Almost done. Need to add per-script static tables.
2012-08-02 12:21:44 -04:00
914ffaa40f
[Indic] Move more repeated work into shape_plan
2012-08-02 11:05:32 -04:00
a8c6da90f4
[OT] Add per-complex-shaper shape_plan data
...
Hookup some Indic data to it. More to come.
2012-08-02 10:46:34 -04:00
8bb5deba96
[OT] Pipe shape_plan down to pause_callbacks
2012-08-02 10:07:58 -04:00
3e38c0f288
More massaging
2012-08-02 09:44:18 -04:00
16c6a27b4b
[OT] Port complex_shaper to planner/plan
2012-08-02 09:38:28 -04:00
5393e3a62b
[OT] Minor refactoring
2012-08-02 09:24:35 -04:00
24eacf17c8
[Indic] Move consonant-position-setting into initial_reordering()
2012-08-02 08:42:51 -04:00
afbcc24be0
[GSUB] Wire the font, not just the face, down to substitute()
...
We need the font for glyph lookup during GSUB pauses in Indic shaper.
Could perhaps be avoided, but at this point, we don't mean to support
separate substitute()/position() entry points (anymore), so there is
no point in not providing the font to GSUB.
2012-08-02 08:36:40 -04:00
b0e6a26a10
[OT] Hide some API
...
It was impossible to meaningfully use them from the outside these days.
2012-08-02 08:11:14 -04:00
305246744e
Minor
2012-08-02 08:08:04 -04:00
8ef3d53255
[Indic] More refactoring of consonant position peeking in the font
...
To be moved to initial_reordering next...
2012-08-02 07:59:19 -04:00
3eb6f81fd3
[Indic] Refactor
...
Move all the logic that needs to eventually move into the indic table
into hb-ot-shape-complex-indic-private.hh.
2012-08-02 07:38:39 -04:00
3614ba242f
[Indic] Rename
2012-08-02 07:23:42 -04:00
610e5e8f71
[Indic] Streamline feature would_apply()
...
Comes with some 10% speedup for Devanagari even!
2012-08-02 05:41:18 -04:00
1d002048d5
[Indic] Minor
2012-08-02 05:02:53 -04:00
6f76113755
[GSUB/GPOS] Check array size before accessing digests
2012-08-02 04:00:31 -04:00
22148b8c4a
Use Coverage digests in would_apply
2012-08-02 03:51:51 -04:00
6c459c8fef
Minor
2012-08-02 03:45:53 -04:00
e2b8d75fa6
Use wider set digests on 64-bit archs
2012-08-01 22:17:48 -04:00
0120ce9679
[GSUB/GPOS] Remove unused get_coverage() methods
2012-08-01 21:56:35 -04:00
1336ecdf8e
[GSUB/GPOS] Use Coverage digests as gatekeeper
...
Gives me a good 10% speedup for the Devanagari test case. Less so
for less lookup-intensive tests.
For the Devanagari test case, the false positive rate of the GSUB digest
is 4%.
2012-08-01 21:46:36 -04:00
a878c58a8f
[GSUB/GPOS] Add add_coverage()
2012-08-01 21:46:19 -04:00
60a3035ac5
Add hb_set_digest_t
...
Implement two set digests, and one that combines the two.
2012-08-01 21:46:19 -04:00
c8accf1dd2
[OT] Templatize Coverage::add_coverage()
2012-08-01 21:05:57 -04:00
8fbfda920e
Inline font getters
2012-08-01 19:03:46 -04:00
6adf417bc1
Use a lookup table for modified_combining_class
2012-08-01 18:07:42 -04:00
208f70f055
Inline Unicode callbacks internally
2012-08-01 17:13:10 -04:00
7470315a3e
Move unicode accessors around
2012-08-01 17:01:59 -04:00
21fdcee001
Add hb_unicode_combining_class_t
2012-08-01 16:28:50 -04:00
84186a6400
Add commentary on the compatibility decomposition in the normalizer
2012-08-01 13:32:39 -04:00
0834d95201
[hb-old] Adjust mark positioning parameters
...
Fallback mark positioning works now... With hb-ft and hb-view /
hb-shape at least.
2012-08-01 00:21:09 -04:00
4ca743dfb8
[old] Implement fontMetrics
2012-08-01 00:03:41 -04:00
1e7d860613
[GPOS] Adjust mark advance-width zeroing logic
...
If there is no GPOS, zero mark advances.
If there *is* GPOS and the shaper requests so, zero mark advances for
attached marks.
Fixes regression with Tibetan, where the font has GPOS, and marks a
glyph as mark where it shouldn't get zero advance.
2012-07-31 23:41:06 -04:00
a8842e4a44
Remove some TODO items
2012-07-31 23:17:23 -04:00
2bc3b9a616
[OT] Zero mark advances if the shaper desires so
...
Enabled for all shapers except for Indic.
2012-07-31 23:17:22 -04:00
5fecd8b035
[OT] Synthesize glyph classes
2012-07-31 23:17:22 -04:00
03b09214c0
[GSUB] Minor
2012-07-31 22:43:58 -04:00
f0fc1df8fc
[hb-old] Implement getGlyphMetrics()
...
Still working on it.
2012-07-31 22:43:32 -04:00
378d279bbf
Implement Unicode compatibility decompositions
...
Based on patch from Philip Withnall.
https://bugs.freedesktop.org/show_bug.cgi?id=41095
2012-07-31 21:36:16 -04:00
321ec29cc2
Remove unused function
2012-07-31 21:10:16 -04:00
69cc492dc1
[buffer] Minor
2012-07-31 14:51:36 -04:00
693918ef85
[OT] Streamline complex shaper enumeration
...
Add a shaper class struct.
2012-07-30 21:08:51 -04:00
c2e42c3db6
Minor
2012-07-30 19:54:50 -04:00
03f67bc012
More refactoring glyph class access
2012-07-30 19:47:53 -04:00
300c7307eb
[OT] Don't crash if no GDEF available
2012-07-30 19:37:44 -04:00
3dcbdc2125
Minor
2012-07-30 19:32:42 -04:00
05bd1b6342
[GSUB/GPOS] Move glyph props matching around
2012-07-30 19:30:01 -04:00
2fca1426ca
[GSUB] Don't erase glyph classes if GDEF does not have glyph classes
2012-07-30 18:46:41 -04:00
fd42257f8c
Minor
2012-07-30 18:44:10 -04:00
7fbbf86efe
[GSUB] Minor
2012-07-30 18:36:42 -04:00
713914d320
[Uniscribe] Clean up a bit
2012-07-30 17:54:38 -04:00
301168dae7
[CoreText] Port to shape_plan infrastructure
2012-07-30 17:48:04 -04:00
6cdfd14bb1
Fix build on Mac
2012-07-30 17:22:17 -04:00
7e34601ded
Unbreak Hangul jamo composition
...
When we removed the separate Hangul shaper, the specific normalization
preference of Hangul was lost. Fix that. Also, the Thai shaper was
copied from Hangul, so had the fully-composed normalization behavior,
which was unnecessary. So, fix that too.
2012-07-30 14:53:41 -04:00
7afb14407e
[Indic] Recategorize Telugu length marks
...
Fixes 8 more Telugu tests. Failures at 15 (0.00154548%).
2012-07-30 13:54:46 -04:00
f2377155e3
[hb-old] Fix misc leaks
...
Backport (forward-port?!) from upstream:
commit 3ab7b37bdebf0f8773493a1fee910b151c4de30f
Author: Behdad Esfahbod <behdad@behdad.org>
Date: Mon Jul 30 10:50:22 2012 -0400
Fix misc leaks
https://bugs.freedesktop.org/show_bug.cgi?id=31992
https://bugs.freedesktop.org/show_bug.cgi?id=31993
https://bugs.freedesktop.org/show_bug.cgi?id=31994
https://bugs.freedesktop.org/show_bug.cgi?id=31995
2012-07-30 10:50:57 -04:00
3f4764bb56
Don't lock user_data set during destruction if empty
2012-07-30 10:06:42 -04:00
4ba647eecf
Fix leak
2012-07-30 09:53:06 -04:00
f860366456
[OT] Gain back some lost speed
2012-07-30 03:16:38 -04:00
11f4c87d01
[OT] Remove hb_ot_layout_ensure()
...
I didn't like it from the beginning.
2012-07-30 02:36:46 -04:00
578e42182b
Minor
2012-07-30 02:35:07 -04:00
a973b5ce86
[GSUB] Further adjustments to mark-attachment vs ligation interaction
...
The d1d69ec52e
2012-07-30 01:47:46 -04:00
0aef425e25
[GSUB] Minor
2012-07-30 00:55:15 -04:00
d1d69ec52e
[GSUB] Don't ligate glyphs attached to different components of ligatures
...
This concludes the mark-attachment vs ligating interaction fixes (for now).
2012-07-30 00:51:47 -04:00
4751dec8be
Minor
2012-07-30 00:42:07 -04:00
f24bcfbed1
Minor
2012-07-30 00:39:00 -04:00
fe20c0f84f
[GSUB] Fix mark component stuff when ligatures form ligatures!
...
See comments.
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=437633
2012-07-30 00:00:59 -04:00
2ec3ba46a3
[GSUB/GPOS] Minor
...
Start squeezing more out of lig_id/lig_comp.
2012-07-29 22:16:15 -04:00
ef6e9cec33
Fixup bb0e4ba3e9
2012-07-29 21:35:22 -04:00
cb3d340631
[GSUB] Don't set new lig_id on mark ligatures
...
If two marks form a ligature, retain their previous lig_id, such that
the mark ligature can attach to ligature components...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=676343
In fact, I noticed that we should not let ligatures form between glyphs
coming from different components of a previous ligature. For example,
if the sequence is: LAM,SHADDA,LAM,FATHA,HEH, the LAM,LAM,HEH form a
ligature, putting SHADDA and FATHA next to eachother. However, it would
be wrong to ligate them. Uniscribe has this bug also.
2012-07-29 20:37:38 -04:00
a15b70a81a
[hb-old] Fix cluster formation in RTL
...
Unlike Uniscribe, hb-old returns glyphs in logical order, so the logic
does not need to duplicated for RTL.
2012-07-29 20:09:22 -04:00
8a7e70ef65
[Minor]
2012-07-29 19:56:54 -04:00
bb0e4ba3e9
Minor
2012-07-29 17:34:14 -04:00
a00ad60bc0
[Uniscribe] Remove hb_uniscribe_font_ensure()
...
Wasn't a huge fan of putting the burden on the user. Just remove it and
do what we've got to do transparently.
2012-07-28 21:16:08 -04:00
5d874d566f
[GPOS] Fix mark-to-mark positioning when one of the marks is a ligature
...
This commit: a3313e5400
2012-07-28 21:05:25 -04:00
338fe662b5
[GSUB] Minor
2012-07-28 18:53:01 -04:00
e6f7479fe3
[GSUB] Simplify would-apply
2012-07-28 18:34:58 -04:00
dadede012e
Minor
2012-07-28 18:13:09 -04:00
0b99429ead
[GSUB/GPOS] Add get_coverage() and use it to speed up main loop
...
And use it to speed up the hotspot by checking coverage directly in
the main loop, not 10 functions deep in.
Gives me a solid 20% boost with Indic test suite. Less so for less
lookup-intensive scenarios.
Remove the "fast_path" hack from before.
2012-07-28 17:46:35 -04:00
30ec9002d8
Reject lookups with no subTable
2012-07-28 17:25:20 -04:00
0981068b75
[GSUB/GPOS] Reject Context/ChainContext lookups with zero input
2012-07-28 17:01:59 -04:00
2f87cebe10
Implement shape_plan caching
...
Should give us some performance boost.
2012-07-27 04:20:39 -04:00
e9eb9503e9
Add default_shaper_list to shape_plan
2012-07-27 03:16:22 -04:00
3b7c4e2706
Don't fail choosing shaper on planning failure
...
Shapers have a chance to reject a font in face shaper_data creation.
No need to allow failing during planning.
2012-07-27 03:12:23 -04:00
cfe9882610
Add hb_ot_layout_ensure() and hb_uniscribe_font_ensure()
2012-07-27 03:06:30 -04:00
c5b668fb92
Choose one shaper per plan
2012-07-27 02:49:39 -04:00
Behdad Esfahbod