Commit Graph

172 Commits

Author SHA1 Message Date
Behdad Esfahbod 0e13beeb93 Use git.mk 2009-04-17 17:39:15 -04:00
Behdad Esfahbod 9d870f2a55 Bug 577952 – Error loading {GDEF,GSUB,GPOS} table 0x6EAD
Detect TrueType Collections by checking the font data header instead
of checking for "face->num_faces >1".
2009-04-09 13:30:26 -04:00
Behdad Esfahbod d49caf1f77 [opentype] Protect against illegal access for arrays of length zero 2009-03-02 15:16:11 +03:30
Behdad Esfahbod 66871797af [opentype] Use size_t instead of uint for malloc wrappers 2009-03-02 14:20:20 +03:30
Behdad Esfahbod 3664e59c52 Fix Bug 572529 – Poor -I ordering can break build 2009-03-02 11:09:29 +03:30
Behdad Esfahbod aca4d11388 Allocate all array rows in a single ALLOC call. Saves over 100 alloc calls
2009-01-31  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-gpos.c (Load_Mark2Array),
        (Free_Mark2Array):
        Allocate all array rows in a single ALLOC call.  Saves over 100
        alloc calls when loading DejaVu Sans,
2009-02-02 00:13:07 +00:00
Behdad Esfahbod c561d69c72 Remove ClassDef->Defined field. This is the comment accompanying it:
2009-01-29  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-open.h:
        * pango/opentype/harfbuzz-gdef.c (Make_ClassRange),
        (HB_GDEF_Build_ClassDefinition):
        * pango/opentype/harfbuzz-gpos.c (Load_PosClassRule),
        (Load_ChainPosClassRule):
        * pango/opentype/harfbuzz-gsub.c (Load_SubClassRule),
        (Load_ChainSubClassRule):
        * pango/opentype/harfbuzz-open.c (Load_ClassDef1),
        (Load_ClassDef2), (_HB_OPEN_Load_ClassDefinition),
        (_HB_OPEN_Load_EmptyClassDefinition),
        (_HB_OPEN_Free_ClassDefinition):
        Remove ClassDef->Defined field.  This is the comment accompanying it:

          The `Defined' field is not defined in the OpenType specification
          but apparently needed for processing fonts like trado.ttf: This
          font refers to a class which contains not a single element.  We
          map such classes to class 0.

        The comment is correct that trado.ttf (MS Traditional Arabic) uses
        such classes.  However, in my testing I couldn't identify any
        problems with the font if the special handling is removed.  I also
        processed as many fonts as I could get my hand on and trado.ttf was
        the only not-totally-broken font hitting the special-case code.
        DejaVu fonts hit it too, but I'm sure they do not require the
        special-handling code.  Most probably, that code introduces bugs
        in them.

        The special-casing was consuming lots of memory.  EIGHT MEGABYTES
        for loading DejaVu Sans!  While this could be complete fixed, I
        decided to remove the special-handling code altogether.  I don't
        think it will make any real difference, and if it does, we'll fix
        fonts.  Such hacks will not be in harfbuzz-ng anyway.

        Bug originally reported by nsf.
2009-01-29 09:20:08 +00:00
Behdad Esfahbod 9372edd6f0 Use calloc(), instead of malloc()ing and memset()ing.
2009-01-29  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-impl.c (_hb_alloc): Use calloc(),
        instead of malloc()ing and memset()ing.
2009-01-29 09:19:56 +00:00
Behdad Esfahbod 94c21d26ba Remove old cruft.
2009-01-29  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-dump-main.c (main): Remove old cruft.
2009-01-29 09:19:43 +00:00
Behdad Esfahbod 0a47c4f78e Allocate all array rows in a single ALLOC call. Saves over 2000 alloc
2009-01-29  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-gpos.c (Load_BaseArray), (Free_BaseArray):
        Allocate all array rows in a single ALLOC call.  Saves over 2000
        alloc calls when loading DejaVu Sans!
2009-01-29 09:19:20 +00:00
Behdad Esfahbod 549be924bc Bug 469049 – Fix all compiler warnings
2008-12-25  Behdad Esfahbod  <behdad@gnome.org>

        Bug 469049 – Fix all compiler warnings

        * pango-view/viewer-pangocairo.c (render_callback):
        * pango/fonts.c (append_field), (pango_font_description_to_string):
        * pango/opentype/harfbuzz-dump.c:
        * pango/pango-bidi-type.c (pango_log2vis_get_embedding_levels):
        * pango/pango-coverage.c (pango_coverage_set):
        * pango/pango-markup.c (span_parse_func):
        * pango/pango-renderer.c
        (pango_renderer_default_draw_error_underline):
        * pango/pango-utils.c (pango_scan_string):
        * pango/pangocairo-render.c (pango_cairo_renderer_draw_trapezoid),
        (draw_error_underline), (pango_cairo_renderer_class_init):
        Fix all the remaining warnings.
2008-12-26 02:31:47 +00:00
Behdad Esfahbod 719f9eaa75 Fix more warnings.
2008-12-25  Behdad Esfahbod  <behdad@gnome.org>

        * pango/modules.c (pango_module_load), (script_info_free):
        * pango/opentype/harfbuzz-gpos.c (HB_Load_GPOS_Table):
        * pango/pango-bidi-type.c:
        * pango/pango-coverage.c (pango_coverage_ref),
        (pango_coverage_unref):
        * pango/pango-engine.c (pango_engine_shape_real_covers),
        (fallback_engine_shape), (fallback_engine_covers):
        * pango/pango-fontmap.c (pango_font_map_init):
        * pango/pango-ot-ruleset.c (pango_ot_ruleset_finalize),
        (pango_ot_ruleset_new):
        * pango/pangofc-decoder.c (pango_fc_decoder_init),
        (pango_fc_decoder_class_init):
        * pango/pangofc-font.c (pango_fc_font_find_shaper),
        (pango_fc_font_get_coverage):
        * pango/pangofc-fontmap.c (pango_fc_font_map_list_families),
        (pango_fc_make_pattern), (pango_fc_font_map_get_patterns),
        (get_first_font), (_pango_fc_font_map_get_coverage),
        (cleanup_font), (pango_fc_font_description_from_pattern),
        (pango_fc_face_list_sizes), (pango_fc_family_list_faces):
        * pango/pangoft2-fontmap.c (pango_ft2_font_map_get_resolution):
        * pango/pangoft2-render.c (pango_ft2_renderer_init),
        (pango_ft2_renderer_draw_trapezoid):
        * pango/pangoft2.c (pango_ft2_font_get_face),
        (pango_ft2_font_real_unlock_face),
        (pango_ft2_free_glyph_info_callback):
        Fix more warnings.
2008-12-26 02:31:35 +00:00
Behdad Esfahbod 21f7d507f4 Bug 528272 – "Error loading GPOS table 5503" when using katakana
2008-10-14  Behdad Esfahbod  <behdad@gnome.org>

        Bug 528272 – "Error loading GPOS table 5503" when using katakana
        characters

        * pango/opentype/harfbuzz-gpos.c (Load_Mark2Array): Skip parsing
        null anchor tables.
2008-10-15 03:45:29 +00:00
Behdad Esfahbod a26c6ae705 Fix left-to-right positioning. Reported by Peter Hunter.
2008-09-29  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-gpos.c (Position_CursiveChain):
        Fix left-to-right positioning.  Reported by Peter Hunter.
2008-09-29 22:28:47 +00:00
Behdad Esfahbod b6c06c56a3 Bug 540592 – Crash in HB_GSUB_Apply_String with Linux-Libertine font
2008-06-29  Behdad Esfahbod  <behdad@gnome.org>

        Bug 540592 – Crash in HB_GSUB_Apply_String with Linux-Libertine font

        * pango/opentype/harfbuzz-gsub.c (GSUB_Do_String_Lookup): Fix reverse
        loops for type 8 lookups.
2008-06-29 18:30:14 +00:00
Behdad Esfahbod 7d6b95b000 Remove unused macro 2008-01-24 04:42:24 +00:00
Behdad Esfahbod 17843245fd Remove COPYING.GPL and COPYING.FTL that are no longer there.
2008-01-16  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/Makefile.am: Remove COPYING.GPL and COPYING.FTL that
        are no longer there.
2008-01-16 20:39:29 +00:00
Behdad Esfahbod a2a9a023f6 HarfBuzz was relicensed to a more generous and simpler license. Adapt. See
2008-01-15  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*:
        HarfBuzz was relicensed to a more generous and simpler license.
        Adapt.  See pango/opentype/COPYING for the new license which is
        LGPL-compatible.
2008-01-15 22:46:32 +00:00
Behdad Esfahbod 4ccedd22ea Bug 501575 – Compile errors Patch from Jens Granseuer
2007-12-04  Behdad Esfahbod  <behdad@gnome.org>

        Bug 501575 – Compile errors
        Patch from Jens Granseuer

        * pango/opentype/harfbuzz-stream.c (_hb_font_goto_table):
        * pango/pango-utils.c (handle_alias_line):
        Fix C99ism.
2007-12-05 03:41:29 +00:00
Behdad Esfahbod cd55cfa2b0 Undo accidental change. 2007-11-30 04:31:29 +00:00
Behdad Esfahbod 3f05da638c Bug 485536 – underline_position can be zero
2007-11-29  Behdad Esfahbod  <behdad@gnome.org>

        Bug 485536 – underline_position can be zero

        * pango/pango-utils.c (pango_cairo_quantize_line_geometry):
        Document that returned position may be zero.

        * pango/pangocairo-win32font.c
        (pango_cairo_win32_font_create_metrics_for_context):
        * pango/pangofc-font.c (get_face_metrics):
        Handle case of underline_position==0 after rounding.
2007-11-30 04:29:58 +00:00
Behdad Esfahbod e58278fedb Remove unused macro.
2007-11-23  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-impl.c: Remove unused macro.
2007-11-24 01:40:13 +00:00
Behdad Esfahbod 3b047380ae Minor 2007-11-18 22:34:08 +00:00
Behdad Esfahbod 10d6a25a26 Remove dead code. 2007-11-07 10:04:11 +00:00
Behdad Esfahbod 47d2c33e3d And some more.
2007-11-07  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: And some more.
2007-11-07 09:59:18 +00:00
Behdad Esfahbod 78ef65ba08 Some more cleanup and merging.
2007-11-07  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: Some more cleanup and merging.
2007-11-07 08:06:01 +00:00
Behdad Esfahbod 5c9bd37995 Fix typo. 2007-10-29 23:51:48 +00:00
Behdad Esfahbod ef1f481752 Even more cleanup and more type renames.
2007-10-25  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: Even more cleanup and more type renames.
2007-10-25 23:37:11 +00:00
Behdad Esfahbod 282c60a0ee More cleanup, remove redundant error types.
2007-10-25  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: More cleanup, remove redundant error types.
2007-10-25 23:22:17 +00:00
Behdad Esfahbod 4280ec4df4 Rename ftglue.c to harfbuzz-impl.c and more type renames and moving code
2007-10-24  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: Rename ftglue.c to harfbuzz-impl.c and more
        type renames and moving code around.
2007-10-25 00:23:46 +00:00
Behdad Esfahbod 5716ae278a New header file harfbuzz-global.h. Rename FT_* int types to HB_* types.
2007-10-24  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: New header file harfbuzz-global.h.  Rename
        FT_* int types to HB_* types.
2007-10-24 22:44:47 +00:00
Behdad Esfahbod 2130d852c7 Add commented-out dummy struct for Extension lookups.
2007-10-24  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-gpos-private.h:
        * pango/opentype/harfbuzz-gsub-private.h:
        Add commented-out dummy struct for Extension lookups.
2007-10-24 21:35:03 +00:00
Behdad Esfahbod 13b2b96384 Bug 488840 – harfbuzz: protect against ligid overflow
2007-10-21  Behdad Esfahbod  <behdad@gnome.org>

        Bug 488840 – harfbuzz: protect against ligid overflow

        * pango/opentype/harfbuzz-buffer.c (_hb_buffer_allocate_ligid):
        Never return zero, even in case of overflow.

        * pango/opentype/harfbuzz-impl.h: Define dummy HB_LIKELY() and
        HB_UNLIKELY(), to be filled later.
2007-10-21 18:17:02 +00:00
Behdad Esfahbod 6b347138b5 Mark internal symbols as HB_INTERNAL and define that to static in
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: Mark internal symbols as HB_INTERNAL and
        define that to static in harfbuzz.c.

        * pango/opentype/harfbuzz-buffer-internal.h: New file.
2007-10-11 08:30:50 +00:00
Behdad Esfahbod 7cdfb61dee Remove FTGLUE_API/APIDEF cruft.
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/ftglue.[ch]: Remove FTGLUE_API/APIDEF cruft.
2007-10-11 07:46:33 +00:00
Behdad Esfahbod 61ddbafaaa Build harfbuzz.c instead of individual source files, to let compiler go
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/Makefile.am: Build harfbuzz.c instead of individual
        source files, to let compiler go wild with optimizations!
2007-10-11 07:45:26 +00:00
Behdad Esfahbod a219b3d003 Same here.
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz.c: Same here.
2007-10-11 07:34:08 +00:00
Behdad Esfahbod 6567e16e3b Don't include harfbuzz-dump.[ch] in libharfbuzz.a. Those are just used by
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/Makefile.am: Don't include harfbuzz-dump.[ch] in
        libharfbuzz.a.  Those are just used by the harfbuzz-dump tool.
2007-10-11 07:33:19 +00:00
Behdad Esfahbod 0b032549ba Some more cleanup.
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-buffer.c: Some more cleanup.
2007-10-11 07:24:47 +00:00
Behdad Esfahbod 7a26864308 Move some code around.
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-buffer.c: Move some code around.
2007-10-11 07:21:31 +00:00
Behdad Esfahbod 7a5405c826 Minor. 2007-10-11 07:15:16 +00:00
Behdad Esfahbod 986f4fd968 Rename buffer->inplace to buffer->separate_out with the inverted meaning,
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-buffer.[ch]: Rename buffer->inplace to
        buffer->separate_out with the inverted meaning, such that buffer
        is initialization is memset(0).
2007-10-11 07:12:49 +00:00
Behdad Esfahbod 06003908cc Allocate buffer->positions lazily.
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/*: Allocate buffer->positions lazily.
2007-10-11 07:05:09 +00:00
Behdad Esfahbod fc3d6f5758 Bug 485621 – Get rid of freetype memory allocator in harfbuzz
2007-10-11  Behdad Esfahbod  <behdad@gnome.org>

        Bug 485621 – Get rid of freetype memory allocator in harfbuzz

        * pango/opentype/*: Remove all occurences of FT_Memory.  Use
        malloc/realloc/free directly.

        * pango/pango-ot*: Update to above.
2007-10-11 06:52:07 +00:00
Behdad Esfahbod a8abb8b994 Bug 485559 – Boston Summit HarfBuzz optimizations
2007-10-10  Behdad Esfahbod  <behdad@gnome.org>

        Bug 485559 – Boston Summit HarfBuzz optimizations

        * pango/opentype/*: HarfBuzz hacking to:

          - Rename last remaining FT_Err stuff to HB_Err.

          - Fix a couple invalid table paths to be permissive so
            fonts work better.  Particularly GDEF table for Nafees
            Nastaliq is loaded and works great now.

          - Optimize harfbuzz buffer to not copy/swap for simple
          one-to-one and "copy" GSUB operations.

        * pango/pango-ot*: Update to FT_Err to HB_Err renaming.
2007-10-11 00:07:58 +00:00
Behdad Esfahbod dd810b76bc Bug 302952 – The placement of a diacritic marks for an arabic ligature
2007-08-29  Behdad Esfahbod  <behdad@gnome.org>

        Bug 302952 – The placement of a diacritic marks for an arabic ligature
        is not correct

        * pango/opentype/harfbuzz-buffer.c (hb_buffer_allocate_ligid): Don't
        use zero as allocated ligature id.  Zero means no ligature id.
2007-08-29 08:46:50 +00:00
Behdad Esfahbod e90d199194 Bug 463430 – Gets stuck while "formatting message"
2007-08-21  Behdad Esfahbod  <behdad@gnome.org>

        Bug 463430 – Gets stuck while "formatting message"

        * pango/opentype/harfbuzz-gpos.c (Lookup_PairPos1),
        (Lookup_PairPos2), (Lookup_PairPos), (Do_ContextPos):
        * pango/opentype/harfbuzz-gsub.c (Do_ContextSubst):
        Change type of intermediate index variable from FT_UShort to
        FT_ULong as it was overlowing with more than 65536 glyphs.
2007-08-21 08:03:26 +00:00
Behdad Esfahbod 13b86ee398 Don't ignore error return value of hb_buffer_copy_output_glyph(). Patch
2007-08-20  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-gsub.c (GSUB_Do_String_Lookup): Don't
        ignore error return value of hb_buffer_copy_output_glyph().  Patch
        sent to harfbuzz-list.
2007-08-21 01:38:07 +00:00
Behdad Esfahbod 6c49bebc70 Link freetype to harfbuzz-dump, for those systems that don't track
2007-04-30  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/Makefile.am: Link freetype to harfbuzz-dump, for
        those systems that don't track dependencies automatically.
2007-05-01 02:32:12 +00:00
Behdad Esfahbod 7341a11691 Copy fixes from harfbuzz stable branch. Includes a leak fix, a kerning
2007-04-03  Behdad Esfahbod  <behdad@gnome.org>

        * pango/opentype/harfbuzz-gdef.c (_HB_GDEF_Check_Property):
        * pango/opentype/harfbuzz-gpos.c (HB_Done_GPOS_Table),
        (Lookup_PairPos):
        * pango/opentype/harfbuzz-open.c (Get_Class1):
        Copy fixes from harfbuzz stable branch.  Includes a leak fix,
        a kerning fix, and an array out-of-bound access fix.
2007-04-03 22:45:29 +00:00