53543f8b3e
Ship UCDN and use it by default
...
So we are not relying on version of Unicode data in glib...
Fixes https://github.com/behdad/harfbuzz/issues/386
Fixes https://github.com/behdad/harfbuzz/issues/388
2017-01-05 20:12:32 -08:00
ae00af4a47
Move math-specific code from hb-ot-layout to hb-ot-math #235 ( #384 )
2017-01-02 23:55:09 -05:00
6cff753941
Remove Tibetan decomposition rules from Indic shaper
...
The decomposition is very obscure and unlikely to help
any fonts. Just remove it since Uniscribe probably doesn't
do this either.
Fixes https://github.com/behdad/harfbuzz/issues/382
2016-12-28 13:47:13 -05:00
f6ba63b2e8
Port decompositions from Indic to USE shaper
...
Part of https://github.com/behdad/harfbuzz/issues/382
2016-12-28 13:45:32 -05:00
e678b537f7
[indic] Remove Chakma decomposition rule from Indic shaper
...
This is now added to USE:
https://github.com/behdad/harfbuzz/pull/383
See:
https://github.com/behdad/harfbuzz/issues/381
https://github.com/behdad/harfbuzz/issues/382
2016-12-28 13:40:55 -05:00
49ba698124
[use] Special-case Chakma split-vowel decomp in the USE shaper. ( #383 )
2016-12-28 13:00:51 -05:00
c4ca49d55b
Revert "[indic] Remove redundant Chakma decomposition rule"
...
This reverts commit 805f76fc00https://github.com/behdad/harfbuzz/issues/381#issuecomment-269237796
2016-12-26 14:52:08 -05:00
805f76fc00
[indic] Remove redundant Chakma decomposition rule
...
This was not used BTW since Chakma doesn't go through Indic shaper
anymore.
See:
https://github.com/behdad/harfbuzz/issues/381
https://github.com/behdad/harfbuzz/issues/382
2016-12-26 14:12:39 -05:00
3cc48a46b5
[indix] Comment
2016-12-26 13:16:56 -05:00
7d1c5d8281
Compilation Error for ASSERT_STATIC on Some Compilers ( #380 )
...
* this pointer in type definitions is not interpreted as a constant.
This rule is not enforced strictly by all compilers, but the Green Hills Software compiler will regard this as an error.
* Merging branches for the DEFINE_SIZE_UNION macro
Adding check for the existence of static_size field in the tested member.
2016-12-23 19:46:37 -06:00
e2b878055b
Disable OTL processing for Hebrew if GPOS doesn't have Hebrew subtable
...
New approach to fix this:
69f9fbc420https://github.com/behdad/harfbuzz/issues/347#issuecomment-267838368
With U+05E9,U+05B8,U+05C1,U+05DC and Arial Unicode, we now (correctly) disable
GDEF and GPOS, so we get results very close to Uniscribe, but slightly different
since our fallback position logic is not exactly the same:
Before: [gid1166=3+991|gid1142=0+737|gid5798=0+1434]
After: [gid1166=3+991|gid1142=0@402,-26+0|gid5798=0+1434]
Uniscribe: [gid1166=3+991|gid1142=0@348,0+0|gid5798=0+1434]
2016-12-22 14:43:23 -06:00
1a0f4aa6df
Revert "Synthesize GDEF glyph class for any glyph that does not have one in GDEF"
...
This reverts commit 69f9fbc420https://github.com/behdad/harfbuzz/issues/347#issuecomment-268873401
Fixes https://github.com/behdad/harfbuzz/issues/347
2016-12-22 14:43:14 -06:00
4b4a1b9f23
Fix assert fail with contextual matching
...
As discovered by libFuzzer / Chromium fuzzing.
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=659496
CC https://github.com/behdad/harfbuzz/issues/139
2016-12-21 23:14:16 -06:00
df98ce5fc8
Improve debug output with really deep nesting
2016-12-21 19:27:30 -06:00
eab418c5e6
Avoid infinite loop in CoverageFormat2 iteration with bad fonts
...
Fixes https://github.com/behdad/harfbuzz/issues/363
2016-12-21 15:51:28 -06:00
7ed71eb347
Protect collect_glyphs() and closure() against malicious DDOS fonts
...
Fixes https://github.com/behdad/harfbuzz/issues/363
2016-12-20 15:01:16 -06:00
1c98ff87c7
Support building with older glib versions
...
It is desirable to be able to build against older versions of glib.
fd7a245aafe3950ef179e2
2016-12-18 01:37:07 -06:00
ad273881c5
Minor fixes to pacify Coverity code scan
...
Fixes https://github.com/behdad/harfbuzz/pull/377
2016-12-18 00:14:06 -06:00
1e1825bf47
[dwrite] Provide an experimental API for justification ( #279 )
2016-12-17 10:30:40 +03:30
219cb29c5d
Fix build after rebasing opentype-gx branch on top of MATH table
2016-12-16 19:06:26 -06:00
0aedfd59be
[GX] Apply 'rvrn' feature before any other feature
2016-12-16 19:06:26 -06:00
42c8142531
[GX] Fix build with older FreeType
2016-12-16 19:06:26 -06:00
72873cf522
Call hb_font_set_var_coords_normalized() from FT_Face coords
2016-12-16 19:06:26 -06:00
4ebbeb7c50
[GX] Make FeatureVariations actually work
...
Yay!!!!
2016-12-16 19:06:26 -06:00
72ada4f0c6
[GX] Hook up feature variations
...
Shape-plan caching is not implemented.
2016-12-16 19:06:26 -06:00
ec87ba9ba3
[GX] Add hb_ot_layout_feature_with_variations_get_lookups()
2016-12-16 19:06:26 -06:00
30c42b644e
[GX] Add hb_ot_layout_table_find_feature_variations()
2016-12-16 19:06:26 -06:00
7ceadbe981
Shuffle code around
2016-12-16 19:06:26 -06:00
bde5e3959c
Move add_lookups from map to map-builder
...
In prep for more changes.
2016-12-16 19:06:26 -06:00
26648cebcd
[GX] Remove (partial) support for anisotropic variations
...
It doesn't always work, not part of FreeType, and we were not going
to expose it in the API anyway. Can always be added later.
2016-12-16 19:06:26 -06:00
c22176d4ba
[GX] Handle setting var coords to NULL
2016-12-16 19:06:26 -06:00
59055b5494
[GX] Implement Feature Variations
...
Not hooked up to shaper yet.
2016-12-16 19:06:26 -06:00
85ec494434
[GX] Fix another x/y thinko
...
Thanks Werner!
2016-12-16 19:06:26 -06:00
cf3de4d8f7
[GX] Rename VarStore to VariationStore
2016-12-16 19:06:26 -06:00
1f6ed356e0
[GX] Fix build with some compilers
...
Eg. https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.48/job/o9mnd33kcdeeg30r
hb-open-type-private.hh:103:29: error: static data member 'OT::Device::<anonymous union>::<anonymous struct>::static_size' in unnamed class [-fpermissive]
2016-12-16 19:06:26 -06:00
250bcd6fb6
[GX] Skip tail zero entries when setting variation coordinates
2016-12-16 19:06:26 -06:00
1124d2ece5
[GX] Fix thinko
2016-12-16 19:06:26 -06:00
ad69e8f07c
[GX] Add new API hb_font_set_var_coords_normalized()
...
Will probably change.
2016-12-16 19:06:26 -06:00
151d93de8a
[GX] Hook up GPOS to Variation Store stored in GDEF
...
Untested.
2016-12-16 19:06:26 -06:00
dcfd309533
[GX] Change GDEF API to return varStore
2016-12-16 19:06:26 -06:00
49cb87850c
[GX] Pass apply-context down to get_anchor()
...
Needed to access GDEF for varStore.
2016-12-16 19:06:26 -06:00
f0c3fd8c9a
[GX] Add varStore member to GDEF
...
Still not hooked up from GPOS.
2016-12-16 19:06:26 -06:00
5c971f8dbc
Minor change to GDEF, in prep for new version
2016-12-16 19:06:26 -06:00
dc9f229799
[GX] Port variation stuff to Variation Store design
...
Not hooked up to GDEF yet.
2016-12-16 19:06:26 -06:00
a7edeb6f02
Make OffsetArrayOf take OffsetType template argument
2016-12-16 19:06:26 -06:00
8dddc231cf
[GX] Revert "[GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS"
...
This reverts commit 2859f1c7174d6f7ae5dcf0db5411bc0182b21594.
We are going in a different direction.
2016-12-16 19:06:26 -06:00
bb4d2e6ed5
[GX] Free GX coordinates
2016-12-16 19:06:26 -06:00
baa329c6a1
[GX] Add compact VariationDevice implementation
...
Add compact format that uses signed bytes instead of shorts.
2016-12-16 19:06:26 -06:00
71b06fd392
[GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS
...
Not hooked up to runtime yet.
2016-12-16 19:06:26 -06:00
976eeb8e02
[GX] Minor
2016-12-16 19:06:26 -06:00
ed8a9067ca
[GX] Minor
2016-12-16 19:06:26 -06:00
15c5ee6747
[GX] Minor rename
2016-12-16 19:06:26 -06:00
4c535a822f
[GX] Hookup VariationDevice to Device table implementation
2016-12-16 19:06:26 -06:00
a0c2366075
[GX] Break out early if factor is zero
...
Also disable sanity-checking of variation records.
2016-12-16 19:06:26 -06:00
ca28670316
[GX] Towards anisotropic interpolation
...
Also hookup to ValueRecord and Anchors.
2016-12-16 19:06:26 -06:00
6d9d3c55bb
[GX] Add data types for encoding numerical variations
2016-12-16 19:06:26 -06:00
e4bfccfb2a
[CBDT] Minor
2016-12-04 19:45:46 -08:00
b7068af423
[CBDT] Fix thinko!
2016-12-04 19:36:30 -08:00
a141d1da9b
[CBDT] Implement IndexSubtableFormat3
2016-12-04 19:26:54 -08:00
9eda74c92c
[cbdt] Move some more code around
2016-12-04 19:12:52 -08:00
654f9ab0d8
[cbdt] Fix sign bug
...
Was introduced in d495fc5e38
2016-12-04 18:56:24 -08:00
c27d6fcf8d
[cbdt] Last of sanitization fixes
...
Should be all good now..
2016-12-02 22:43:05 -08:00
d495fc5e38
[cbdt] Clean up some more
...
Almost there..
2016-12-02 21:52:33 -08:00
ce09e90e15
[cbdt] More sanitize work
2016-12-02 20:12:57 -08:00
70eb2ff682
Check for offset overflows during sanitize
2016-12-02 19:51:23 -08:00
4b58c9e326
[cbdt] Start fixing sanitization (or lack thereof)
2016-12-02 19:25:54 -08:00
b92ba7bafc
[CBDT] Use CHAR instead of int8_t
2016-12-02 15:21:43 -08:00
efca7bf97f
Rename 'ebdt' to 'cbdt' since we only support the PNG format
2016-12-02 15:11:37 -08:00
831852594b
Introduce get_extent support for color bitmap font. ( #351 )
...
hb_font_get_glyph_extents now works for color bitmap fonts.
Currently only font having index format 1 and image format 17
is supported.
2016-12-02 17:03:50 -06:00
2b117720c0
Use horizontal ascent as fallback vertical origin
2016-10-26 18:12:50 +02:00
a7b32f2057
Move code around
2016-10-26 18:08:41 +02:00
63635c763d
[hb-ot-font] Use ascent+descent as fallback vertical advance
2016-10-26 18:01:24 +02:00
9ee23c49a7
Fix vertical glyph origin with hb-ot-font
2016-10-26 18:01:24 +02:00
b3b0816d5f
Fix vertical font metrics
...
Ouch!
2016-10-26 18:01:20 +02:00
0e79ebb3ca
[gobject] Update for new MATH structs
2016-10-26 10:32:48 +02:00
bef240b36e
[ci] Whitelist more symbols and unbreak mac CI
...
Thanks to @khaledhosny, actually this is his work :)
2016-10-11 17:12:08 +03:30
d1c62370a0
Aim math API for 1.3.3 instead of 1.4.0
2016-10-04 14:47:12 -07:00
7adbc5dd62
Fix building math docs ( #335 )
2016-09-30 04:01:24 -07:00
c3e21a6620
[MATH] Fix more docs
2016-09-27 16:51:38 +02:00
46cc4a3a2a
[MATH] Rename hb_math_*_t types to hb_ot_math_*_t
...
With this, I believe MATH table API is not ready to be merged.
2016-09-27 16:44:22 +02:00
0762b35474
Document API for MathVariants ( #330 )
2016-09-27 15:28:35 +02:00
bc19f7fe20
[MATH] Add HB_OT_MATH_SCRIPT
2016-09-27 10:58:08 +02:00
86106c7528
[MATH] Rename all API to hb_ot_math_*
2016-09-26 22:14:29 +02:00
1ba767cd4e
[MATH] Move API from hb-ot-layout.h to hb-ot-math.h
2016-09-26 21:57:14 +02:00
97b72da600
Whitespace
2016-09-26 21:53:25 +02:00
559eb56447
[MATH] Wire up get_glyph_assembly()
2016-09-26 21:46:05 +02:00
353f455af7
[MATH] Wire up get_glyph_variants()
2016-09-26 21:25:00 +02:00
7fe0e28c22
[MATH] Start fleshing out glyph variant API
2016-09-26 17:51:47 +01:00
1f3327f210
[MATH] Clean up math variants
2016-09-26 16:10:08 +01:00
51da7a1cd6
MATH table: Add API to access math variants.
2016-09-26 15:18:16 +01:00
8d58e3433e
[MATH] Fix get_kerning() with negative y-scale
2016-09-26 13:39:58 +01:00
94f5df5626
[MATH] Clean up get_kerning()
2016-09-26 13:31:47 +01:00
17ff30e9af
[MATH] Clean up get_top_accent_attachment()
...
Note, the function now returns "half of horizontal advance width"
if top accent attachment for glyph is not explicitly defined.
This is what the spec requires. Updated tests.
2016-09-26 12:21:27 +01:00
8bcf517fe5
[MATH] Clean up get_italics_correction()
2016-09-26 12:13:14 +01:00
06003f71ba
[MATH] Clean up a bit more
2016-09-26 12:07:29 +01:00
54c0cc38fb
[MATH] Clean up get_math_constant implementation
2016-09-26 11:56:40 +01:00
8a8cfad9a0
[MATH] Cleanup previous commit a bit
2016-09-26 11:51:07 +01:00
d7182d1296
MATH Table: Add API to access glyph info.
2016-09-26 11:32:25 +01:00
6fd2fe418d
[MATH] Fixup math constants commit a bit more
2016-09-26 11:24:39 +01:00
1a381153a2
[MATH] Fixups for math constants commit
2016-09-26 11:15:59 +01:00
319ff59161
MATH Table: Add API to access math contants.
2016-09-26 10:49:09 +01:00
4d3892e9b0
[MATH] Fixups for previous commit
2016-09-26 10:45:58 +01:00
5fbcb992bd
MATH Table: Add API to check availability of math data.
2016-09-26 10:27:33 +01:00
fc4e671f31
[coretext] Use intended coretext version check logic ( #315 )
2016-09-09 11:58:28 -07:00
4867734528
Try to unbreak building on older macOS again ( #314 )
2016-09-07 18:44:37 -07:00
b717cd7be5
Do reconfigure the cascade list for Emoji font on OS X 10.9.5 ( #313 )
...
This seems to fix crash issues on 10.9.5 reported on Chrome, compare
crbug.com/549610
2016-09-07 13:56:57 -07:00
67e9fdf427
Blacklist Padauk 2.80 and 3.00 ( #311 )
...
According to comments in issue #305 broken GDEF tables lead
to incorrect rendering of Latin characters. Blacklisting
this font.
2016-09-05 01:27:25 -07:00
5362ce6a64
[dwrite] Minor, don't include unnecessary headers ( #309 )
2016-09-01 08:35:45 -07:00
3d976d20f1
Show the shaper name in the debug message ( #306 )
2016-08-27 16:38:42 +03:00
e7ecbba2cc
Support Americanist Phonetic Notation
...
OpenType language system tag: `APPH`
https://www.microsoft.com/typography/otspec/languagetags.htm
IETF BCP47 variant tag: `fonnapa`
http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
2016-08-18 14:13:26 +02:00
a0f1b44b6c
[coretext] Blind fix for build on MacOS 10.9
2016-08-16 03:09:04 +02:00
37f21bdbb7
Map Macao to ZHH lang tag
...
Fixes https://github.com/behdad/harfbuzz/issues/300
2016-08-08 17:57:06 -07:00
09c7a2d6bf
Limit bits-per-feature to eight
...
Limits number of alternatives per glyph per feature to 255, so be it.
That's better than possibly breaking shaping because of one bad feature
value.
2016-08-08 17:29:30 -07:00
333173103b
Fix sign of shift operators
...
This one:
map->mask = (1 << (next_bit + bits_needed)) - (1 << next_bit);
before the fix, the shift was done as an int, causing overflow
if it ever got to 1 << 31. Sprinkle 'u's around.
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=634805
2016-08-08 17:28:14 -07:00
10a0d4aa22
Map zh-Hant-HK to ZHH
...
Fixes https://github.com/behdad/harfbuzz/issues/300
2016-08-08 16:51:08 -07:00
489acf6c31
[coretext] "Fix" crashes on CoreText < 10.10
...
Fixes https://github.com/behdad/harfbuzz/issues/297
2016-07-22 17:41:43 -07:00
08c08af2f9
[ucdn] Update to Unicode 9.0.0
...
Fixes https://github.com/grigorig/ucdn/issues/12
2016-07-21 01:35:30 -07:00
f3f6c1ccbf
Blacklist GDEF tables of more fonts
...
This is based on bug reports that have been filed against Firefox since it
updated to a version of harfbuzz that uses zeroing by GDEF rather than by
Unicode. I'm sure there are a bunch more font versions that should also be
included; these are just the ones I have on hand and have confirmed as having
bad GDEF data.
Given how the list here is growing, I think we should reconsider the approach,
and perhaps revert to zeroing by Unicode instead.
Fixes https://github.com/behdad/harfbuzz/issues/264
Fixes https://github.com/behdad/harfbuzz/pull/266
2016-07-21 01:15:12 -07:00
34f9aa582c
Implement symbol cmap in ft and ot fonts
...
Fixes https://github.com/behdad/harfbuzz/issues/236
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=627953
2016-07-20 02:35:54 -07:00
6363d7df28
Clean up buffer area when rewinding
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=614647
If allocation fails, we might be leaving junk behind. At least
clear it up.
2016-07-20 01:44:47 -07:00
f80c34eb55
Whitespace
2016-07-12 11:18:26 -07:00
874421203e
[coretext] Speculative fix for CoreText nullptr access ( #288 )
2016-07-11 16:19:21 -07:00
6bf9db4f1e
[ft] Fix unsafe cast of FT_Done_Face in hb_ft_{face,font}_create_referenced ( #289 )
...
Prior to this change the function `FT_Error FT_Done_Face(FT_Face *)` was
called through a pointer with the signature `void (void *)` resulting in
undefined behaviour.
2016-07-11 13:38:23 -07:00
0b8f3ab022
clang in MSVC mode doesn't like when we redefine __attribute__ ( #283 )
2016-07-11 12:57:26 -07:00
e4d451ee55
[introspection] Fix hb_tag_from_string annotation
2016-07-02 00:04:57 +02:00
d3e2a06b0f
[python] Use utf-32 / utf-16 based on build of Python
...
Fixes https://github.com/behdad/harfbuzz/pull/271
2016-06-30 11:01:22 -07:00
fc9de44a03
Comments
2016-06-30 09:46:52 -07:00
1bea49eb4b
Merge branch 'master' into conflictingFontFix
2016-06-29 12:10:41 +02:00
70e72e5f61
[gobject] Fix a few warnings
...
Part of https://github.com/behdad/harfbuzz/issues/277
2016-06-28 21:15:36 -07:00
ae9054c740
Revert "use utf32"
2016-06-28 21:14:38 -07:00
7aa3631dd0
Merge branch 'master' into conflictingFontFix
2016-06-28 09:52:18 +02:00
8179ff5d7b
[dwrite] Don't allocate more than needed
...
Addressing Nikolay Sivov reviews on harfbuzz mailing list
2016-06-27 03:58:49 +04:30
07b724f341
[dwrite] Delete remained objects
...
No longer noticeable memory increase on create/destroy iterations,
highly better than current state of uniscribe backend
2016-06-24 14:29:24 +04:30
be565d1714
[dwrite] Release allocated blob on face destroy
...
This reduces memory consumption of my iterated font create/destroy cycle test
significantly and makes it much better than uniscribe backend even
2016-06-24 11:46:53 +04:30
f3f0ea980a
[dwrite] Remove ifdefs without breaking execution on old Windows versions
2016-06-23 17:26:55 +04:30
6b861dbd8b
[dwrite] Use stream font loader instead GDI interop
...
With help of
https://dxr.mozilla.org/mozilla-central/source/gfx/2d/NativeFontResourceDWrite.cpp
2016-06-23 15:57:34 +04:30
f7da0486ed
Merge branch 'master' into conflictingFontFix
2016-06-20 10:25:43 +03:00
07461d06d2
Use UTF-32 in Python sample
2016-06-19 01:46:38 +03:00
a0223274b9
Discard reconfigured CTFont if URL changes
...
Fixes https://github.com/behdad/harfbuzz/issues/267
2016-06-16 14:19:39 +02:00
4b8de1ea80
Round, not truncate, when scaling values
...
Fixes https://github.com/behdad/harfbuzz/issues/255
2016-06-06 23:08:54 -07:00
bed201d2b8
Update for latest Unicode 9 data files
2016-06-06 14:14:24 -07:00
aba4b0ca52
Add TODO
2016-06-01 16:57:29 -07:00
a2b03de5b3
[myanmar] Handle U+AA74..U+AA76
...
Fixes https://github.com/behdad/harfbuzz/issues/218
2016-05-06 17:56:07 +01:00
9b6312f945
[use] Update to draft spec from Andrew Glass from August 2015
2016-05-06 17:41:49 +01:00
3e4e7616a8
[use] Add a catch-all clause to the machine
2016-05-06 17:28:25 +01:00
d04e461fe3
[use] Fix 'Number-joiner terminated cluster' to use HN instead of H
...
From draft update to USE.
2016-05-06 17:17:00 +01:00
359dead960
Allow MultipleSubst to delete glyph
...
Fixes https://github.com/behdad/harfbuzz/issues/253
Hopefully we got the logic right.
2016-05-06 16:19:19 +01:00
3c1666cfb5
[indic] Remove more unused logic after Javanese is gone
2016-05-06 16:05:07 +01:00
8b5d6e755b
[indic] Remove unused Javanese bits
2016-05-06 15:59:27 +01:00
30e6e29f0f
[indic/use] Move Javanese from Indic shaper to USE
...
Fixes https://github.com/behdad/harfbuzz/issues/243
With javatext.ttf, the reodering medial Ra gets its advance width
zero'ed in Uniscribe implementation, and the font adds the advance
back. Our Indic shaper does not do that, but USE does. So, route
Javanese through USE. That's what Microsoft does anyway. Test:
U+A9A5,U+A9BA
This also seems to fix the following sequence, and variations thereof:
U+A99F,U+A9C0,U+A9A2,U+A9BF
2016-05-06 15:52:27 +01:00
01a30a6aa9
[indic] Remove data for scripts that don't go thorough this shaper
2016-05-06 12:10:07 +01:00
7cd9269f4e
Update tables to Unicode 9.0.0 beta
...
Fixes https://github.com/behdad/harfbuzz/issues/251
2016-05-06 12:10:03 +01:00
f718fe370e
Minor
2016-05-06 12:10:00 +01:00
691086f131
Add Unicode 9 beta scripts
...
These are frozen, so good time to add.
2016-05-06 12:09:53 +01:00
bc5198fe12
Whitespace
2016-05-06 12:09:49 +01:00
9879fc1db3
[ot-font] Remove unused 'post' table include for now
...
To make a release...
2016-05-02 10:29:12 +02:00
f00ab2a33a
[hb-ot-font] Make 'glyf' table loading lazy
...
Apparently some clients have reference-table callbacks that copy the table.
As such, avoid loading 'glyf' table which is only needed if fallback positioning
happens.
2016-05-02 10:24:00 +02:00
587d46227a
[ot-font] Start implementing 'post' table, for accessing glyph names
2016-04-30 19:20:56 +02:00
9abaaac409
Merge commit '264b7a728a41becfbf23ce258fc2a3af19d0cbbe' into HEAD
2016-04-27 03:38:24 -07:00
2f560ee44b
[tibetan] Reorder marks to better match Uniscribe
...
Fixes https://github.com/behdad/harfbuzz/issues/237
Note that Uniscribe enforces a certain syllable order. We don't.
But with this change, I get all of the tibetan contractions pass
with Microsoft Himalaya font.
2016-04-27 03:11:41 -07:00
adafdcddce
Mass-added “difficult” tags – to be curated.
2016-04-27 02:14:16 +02:00
3d6a2c0d7d
Initial import of missing OpenType 1.7 language tags.
2016-04-27 02:14:16 +02:00
7e2da035f6
Undo accidental change
2016-04-26 16:42:25 -07:00
b20305022a
Do NOT ignore Mongolian Free Variation Selectors during matching
...
Fixes https://github.com/behdad/harfbuzz/issues/234
2016-04-26 16:41:17 -07:00
21ab5501f5
Move ZWJ/ZWNJ bits to top byte of unicode_props()
...
To make room to remember Mongolian Free Variation Selectors.
Part of fixing https://github.com/behdad/harfbuzz/issues/234
2016-04-26 16:15:22 -07:00
29393884b9
Annotate blacklisted fonts with their sha1sum
2016-04-26 10:35:47 -07:00
5069062d0a
Unbreak build on Windows CE
...
0475ef2f97
2016-04-26 12:02:26 +04:00
1c625dff22
Minor
2016-04-09 12:53:23 -07:00
851b0db36d
Minor. We should never get to this branch, but fix it anyway.
2016-04-08 23:46:55 -07:00
4f3d59a187
Blacklist another set of timesi.ttf and timesbi.ttf
2016-04-08 13:41:20 -07:00
ef476be80d
Merge pull request #239 from ebraminio/dwfix
...
Improve DirectWrite backend
2016-04-08 13:16:33 -07:00
d3134a66ad
Fix when no feature is given
2016-04-05 21:42:37 +00:00
59089622db
[coretext] Clarify comment
2016-04-04 14:56:15 -07:00
6dd80faf0d
Fix FixedVersion::to_int()
...
Ouch. Had broken it in 9a13ed453ehttps://github.com/behdad/harfbuzz/issues/238
Will add test soon.
2016-04-04 14:34:25 -07:00
4a10402169
Hide justification behind HB_DIRECTWRITE_EXPERIMENTAL_JUSTIFICATION
2016-04-02 13:47:59 +00:00
63ee9ca5d8
Use standard types instead Windows favourites ones
2016-04-01 15:47:07 +00:00
adf20ba0d1
Limit GetJustifiedGlyphs only to scripts with custom justification character
2016-04-01 15:36:40 +00:00
32ae9d1b3f
Add justification support
2016-04-01 14:39:07 +00:00
10c3d9e415
Basic opentype features support
2016-04-01 01:39:15 +00:00
d129897120
Refactor and remove dupe getglyphs call
2016-03-31 13:47:32 +00:00
5f1a896100
Better glyph offset support
2016-03-31 12:43:37 +00:00
d691ba3f40
Don't fail when language is not set
2016-03-30 20:50:28 +00:00
1c00a46c7a
Make DirectWrite backend to work with different font sizes
...
Actually copyedited same logic from Uniscribe to make it just work
2016-03-30 20:15:09 +00:00
69f9fbc420
Synthesize GDEF glyph class for any glyph that does not have one in GDEF
...
Previously we only synthesized GDEF glyph classes if the glyphClassDef
array in GDEF was null. This worked well enough, and is indeed what
OpenType requires: "If the font does not include a GlyphClassDef table,
the client must define and maintain this information when using the
GSUB and GPOS tables." That sentence does not quite make sense since
one needs Unicode properties as well, but is close enough.
However, looks like Arial Unicode as shipped on WinXP, does have GDEF
glyph class array, but defines no classes for Hebrew. This results
in Hebrew marks not getting their widths zeroed. So, with this change,
we synthesize glyph class for any glyph that is not specified in the
GDEF glyph class table. Since, from our point of view, a glyph not
being listed in that table is a font bug, any unwanted consequence of
this change is a font bug :).
Note that we still don't get the same rendering as Uniscribe, since
Uniscribe seems to do fallback positioning as well, even though the
font does have a GPOS table (which does NOT cover Hebrew!). We are
not going to try to match that though.
Test string for Arial Unicode:
U+05E9,U+05B8,U+05C1,U+05DC
Before: [gid1166=3+991|gid1142=0+737|gid5798=0+1434]
After: [gid1166=3+991|gid1142=0+0|gid5798=0+1434]
Uniscribe: [gid1166=3+991|gid1142=0@348,0+0|gid5798=0+1434]
Note that our new output matches what we were generating until July
2014, because the Hebrew shaper used to zero mark advances based on
Unicode, NOT GDEF. That's 9e834e29e0
2016-03-17 11:59:43 -07:00
fef5dd9a72
Merge pull request #232 from c0nk/wip-icu
...
Add --with-icu=builtin option; fix compile error
2016-03-12 19:15:15 -08:00
3e10460a1d
Minor comment
2016-03-11 18:45:19 -08:00
d14fea4bdc
Remove default clause in minor switch statements
...
Bending to clang warnings...
https://bugs.chromium.org/p/chromium/issues/detail?id=593057
2016-03-08 12:16:41 -08:00
ce8ae99701
Merge pull request #231 from KonstantinRitt/post123buildfix
...
Fix build with HB_DISABLE_DEPRECATED
2016-03-04 17:20:35 -08:00
731a430cd3
Fix requiredFeature stage handling logic
...
Originally the way Jonathan had written this was correct in
"continue"ing:
35e28c7a73 (diff-ead86a33a5cc9ad7f6e6381031a0baddR199)da13293798 (diff-ead86a33a5cc9ad7f6e6381031a0baddR209)
2016-03-02 13:32:42 -08:00
68b6296d33
Add F2DOT14 type
2016-03-01 16:41:53 +09:00
082b79fe9f
Use FWORD and UFWORD when it makes sense
...
I had forgotten about those types.
2016-03-01 16:41:26 +09:00
5f995db103
Fix missing ICU #include
...
Fix compile error in hb-icu.cc when ICU configured with
U_NO_DEFAULT_INCLUDE_UTF_HEADERS=1
2016-02-26 00:36:17 +01:00
b424b6c372
Add --with-icu=builtin configure option
2016-02-26 00:35:15 +01:00
71248a843f
Fix build with HB_DISABLE_DEPRECATED
...
When HB_DISABLE_DEPRECATED is defined, no code from hb-deprecated.h
should be used, even from within HB itself.
2016-02-25 18:55:28 +04:00
0c7fb7419c
Speed up buffer variable allocation sanity check
...
This makes defining HB_NDEBUG much less relevant, to the
point of irrelevance. Sorry about all the fuss in previous
release!
2016-02-25 14:40:09 +09:00
91dd115652
Add HB_NDEBUG
...
API changes:
- If NDEBUG is defined, define HB_NDEBUG
- Disable costlier sanity checks if HB_NDEBUG is defined.
In 1.2.3 introduced some code to disable costly sanity checks if
NDEBUG is defined. NDEBUG, however, disables all assert()s as
well. With HB_NDEBUG, one can disable costlier checks but keep
assert()s.
I'll probably add a way to define HB_NDEBUG automatically in
release tarballs. But for now, production systems that do NOT
define NDEBUG, are encouraged to define HB_NDEBUG for our build.
2016-02-25 13:56:47 +09:00
988165021f
Disable internal buffer variable bookkeeping in NDEBUG builds
...
Saves some sweet time and binary size!
2016-02-25 12:23:02 +09:00
94dd0bb7e7
Add blacklist signature for Times New Roman (Bold) Italic on OS X
2016-02-25 11:31:03 +09:00
e23cf902e9
Blacklist GDEF table of timesi.ttf and timesbi.ttf on Win 7
...
See discussion:
https://lists.freedesktop.org/archives/harfbuzz/2016-February/005489.html
2016-02-25 11:11:15 +09:00
c335fd7986
In trampoline implementation of get_glyph(), don't destroy user data twice!
2016-02-25 09:16:05 +09:00
23335deaad
[ot-font] Accelerate cmap format4 get_glyph
2016-02-24 20:27:13 +09:00
e0f16a715b
[ot-font] Towards accelerating get_glyph()
2016-02-24 19:52:36 +09:00
5473ebfb84
[ot-font] Remove level of indirection in get_glyph_variant
2016-02-24 19:32:43 +09:00
8b5bc141cd
Add get_nominal_glyph() and get_variation_glyph() instead of get_glyph()
...
New API:
- hb_font_get_nominal_glyph_func_t
- hb_font_get_variation_glyph_func_t
- hb_font_funcs_set_nominal_glyph_func()
- hb_font_funcs_set_variation_glyph_func()
- hb_font_get_nominal_glyph()
- hb_font_get_variation_glyph()
Deprecated API:
- hb_font_get_glyph_func_t
- hb_font_funcs_set_glyph_func()
Clients that implement their own font-funcs are encouraged to replace
their get_glyph() implementation with a get_nominal_glyph() and
get_variation_glyph() pair. The variation version can assume that
variation_selector argument is not zero.
2016-02-24 19:05:23 +09:00
ebd7431f82
Partially revert 86c68c7a2c
...
That commit moved the advance adjustment for mark positioning to
be applied immediately, instead of doing late before. This breaks
if mark advances are zeroed late, like in Arabic. Also, easier to
hit it in RTL scripts since a single mark with non-zero advance is
enough to hit the bug, whereas in LTR, at least two marks are needed.
This reopens https://github.com/behdad/harfbuzz/issues/211
The cursive+mark interaction is broken again. To be fixed in a
different way.
2016-02-24 15:53:40 +09:00
815bdd7700
In cluster-level=0, group ZWJ/ZWNJ with previous cluster
...
This better emulates Unicode grapheme clusters.
Note that Uniscribe does NOT do this, but should be harmless with most clients,
and improve fallback with clients that use HarfBuzz cluster as unit of fallback.
Fixes https://github.com/behdad/harfbuzz/issues/217
2016-02-22 18:22:44 +09:00
89137e325a
Minor
2016-02-22 16:00:59 +09:00
15063b12f7
[coretext] Move CTFont construction to face_data
2016-02-22 15:56:29 +09:00
ba3d49d9a5
[coretext] Move code around
2016-02-22 15:50:12 +09:00
90194efb84
[coretext] Move code around
2016-02-22 15:42:53 +09:00
9a13ed453e
Make FixedVersion a template
2016-02-22 15:38:44 +09:00
238b943e85
[coretext] Fix leak!
2016-02-22 15:31:22 +09:00
e561122856
[coretext] Move code around
2016-02-22 15:28:37 +09:00
04c6443153
[coretext] Ignore PPEM in font size selection
2016-02-22 15:12:27 +09:00
62c2711121
[coretext] Limit grapheme-cluster forming to cluster-level=0
2016-02-22 15:07:20 +09:00
061105ec44
[coretext] Fix shaping with varying font size
...
Fixes https://github.com/libass/libass/issues/212
2016-02-22 14:59:39 +09:00
b87e36f6f1
Avoid buffer->move_to() in case of buffer error
...
Fixes https://github.com/behdad/harfbuzz/issues/223
Right now we cannot test this because it has to be tested using hb-fuzzer.
We should move all fuzzing tests from test/shaping/tests/fuzzed.tests to
test/fuzzing/ and have its own test runner. At that point, should add
test from this issue as well.
2016-02-19 14:52:31 +07:00
568a0c60e8
Remove pointless overflow check in pointer math
...
Fixes https://github.com/behdad/harfbuzz/issues/227
2016-02-18 19:31:51 +07:00
aae2847099
Emoji skin tone modifiers need to be treated as combining marks
...
Fixes https://github.com/behdad/harfbuzz/issues/169
2016-02-18 17:06:25 +07:00
da41e48f0a
[USE] Zero mark advances by GDEF early
...
This is what Microsoft's implementation does. Marks that need advance
need to add it back using 'dist' or other feature in GPOS. Update tests to
match.
2016-02-16 17:16:33 +07:00
86c68c7a2c
[GPOS] Fix interaction of mark attachments and cursive chaining
...
Fixes https://github.com/behdad/harfbuzz/issues/211
What happens in that bug is that a mark is attached to base first,
then a second mark is cursive-chained to the first mark. This only
"works" because it's in the Indic shaper where mark advances are
not zeroed.
Before, we didn't allow cursive to run on marks at all. Fix that.
We also where updating mark major offsets at the end of GPOS, such
that changes in advance of base will not change the mark attachment
position. That was superior to the alternative (which is what Uniscribe
does BTW), but made it hard to apply cursive to the mark after it
was positioned. We could track major-direction offset changes and
apply that to cursive in the post process, but that's a much trickier
thing to do than the fix here, which is to immediately apply the
major-direction advance-width offsets... Ie.:
https://github.com/behdad/harfbuzz/issues/211#issuecomment-183194739
If this breaks any fonts, the font should be fixed to do mark attachment
after all the advances are set up first (kerning, etc).
Finally, this, still doesn't make us match Uniscribe, for I explained
in that bug. Looks like Uniscribe applies minor-direction cursive
adjustment immediate as well. We don't, and we like it our way, at
least for now. Eg. the sequence in the test case does this:
- The first subscript attaches with mark-to-base, moving in x only,
- The second subscript attaches with cursive attachment to first subscript
moving in x only,
- A final context rule moves the first subscript up by 104 units.
The way we do, the final shift-up, also shifts up the second subscript
mark because it's cursively-attached. Uniscribe doesn't. We get:
[ttaorya=0+1307|casubscriptorya=0@-242,104+-231|casubscriptnarroworya=0@20,104+507]
while Uniscribe gets:
[ttaorya=0+1307|casubscriptorya=0@-242,104+-211|casubscriptnarroworya=0+487]
note the different y-offset of the last glyph. In our view, after cursive,
things move together, period.
2016-02-16 16:07:20 +07:00
80c8855cfe
Minor
2016-02-12 12:50:17 +07:00
6ab920224c
[GPOS] Minor
...
No effect.
2016-02-11 16:57:52 +07:00
cbc3a76c5a
[GPOS] Merge fixing of offsets for cursive and mark attachments
...
Part of fixing https://github.com/behdad/harfbuzz/issues/211
2016-02-11 16:48:13 +07:00
7d8d58ac81
[GPOS] Divide position_finish() into two phases, for advances and offsets
...
Right now the position_finish_advances() is empty. To be used for
spacing attachments proposal later.
2016-02-11 16:34:28 +07:00
8474231567
[ot] Minor shuffling code around
2016-02-11 16:27:41 +07:00
b0b11614e9
[GPOS] Add harmless recursion in fix_mark_attachment()
...
Will do nothing. Just useful for merging two functions.
2016-02-11 15:28:55 +07:00
686567baab
[GPOS] Merge attach_chain() and cursive_chain()
...
Differentiate, using new attach_type().
2016-02-11 15:25:28 +07:00
806ad8dc65
[GPOS] Minor shuffling
2016-02-11 14:53:11 +07:00
0f6278d1fb
[GPOS] Negate sign of attach_lookback(), and rename it to attach_chain()
...
No behavior change. Preparing to unify how cursive and mark attachments
work.
2016-02-11 14:49:10 +07:00
660c9d3fc2
Remove font-dependent ASCII-only perf hack
...
Is confusing. I already hit it myself. Remove. We can optimize
ASCII based on Unicode properties. But should not do based on
assumptions on the font.
2016-02-11 12:14:27 +07:00
eaadcbbc53
Remove now-unused mark zeroing BY_UNICODE
2016-02-10 18:29:54 +07:00
b3582a8ee8
Change default mark advance zeroing behavior from Unicode to GDEF
...
See thread at:
https://lists.freedesktop.org/archives/harfbuzz/2016-February/005462.html
2016-02-10 18:10:15 +07:00
c679285455
build: Build the DirectWrite sources if requested
...
This adds to the autotools build system so that the (experimental)
DirectWrite support for HarfBuzz is built (and dist'ed).
2016-02-03 20:14:42 +08:00
35ded3af74
build: Move source listings into separate Makefile snippets
...
This moves all the source listings in src/Makefile.am,
src/hb-ucdn/Makefile.am and util/Makefile.am into separate Makefile
snippets, so that they may be shared between different Makefile-based
build systems, such as NMake for Visual Studio.
2016-02-03 18:14:29 +08:00
b894a85ad1
Fix more hangs in case of buffer allocation errors
...
Hopefully
fixes https://github.com/behdad/harfbuzz/issues/214
2016-02-02 16:39:19 +08:00
9a6a33ccbe
Merge pull request #216 from mhosken/master
...
Refactor graphite2 to make ovleraps into negative width spaces
2016-01-18 12:47:18 +01:00
146fe252c3
Refactor graphite2 to make ovleraps into negative width spaces
2016-01-16 17:24:00 -06:00
d05b783322
Fix compiler warning
...
Fixes https://github.com/behdad/harfbuzz/issues/212
2016-01-12 16:17:21 +00:00
d163dc18e6
Minor
2016-01-12 13:05:01 +00:00
3e704521f6
[OT] Get list of lookup subtables once and loop through them
...
This speeds up shaping the Amiri font by over 15%.
This was primarily needed for my work on OpenType GX, since
we will be collecting only sublookups that are "active" for
current font instance; but it's a nice boost in general as
well.
We might, in the future, collect subtables in the lookup_accel.
That would also allow us to do a per-subtbale set-digest, which
should speed things up some more, specially for ContextChainFormat3
lookups... Amiri, for example, contains one lookup with 53
subtables!
2016-01-11 17:38:41 +00:00
97624d9244
[docs] Minor fixes.
2016-01-11 12:58:45 +00:00
a39ff95fce
[coretext] Speed up CoreText font fallback
...
Fixes https://code.google.com/p/chromium/issues/detail?id=547912
2016-01-11 12:28:37 +00:00
25671466d2
Add 9 reserved entries to hb_font_extents_t
...
Might add italic-angle, underline/strikethrough-position/thickness
in the future. Do this before new struct goes into a release.
2016-01-07 19:13:47 +00:00
e6d5e4c310
[uniscribe] Fix negative advance
...
This happens with at least one test font I have.
2016-01-06 12:29:50 +00:00
53c47c8582
Increase sanitize edit count from 8 to 32
...
See previous commit.
2016-01-05 13:26:20 +00:00
da2fcfdc51
Don't count fixing-up FeatureParams offset as error
...
The font Garamond Premier Pro Caption (and possibly many other
Adobe fonts), have many FeatureParamsSize tables with the old
wrong offset. We handle fixing those up, but they were still
contributing to edit_count, and when I reduced HB_SANITIZE_MAX_EDIT
from 100 to 8 in 14c2de3218
2016-01-05 13:23:45 +00:00
d0adc80965
Check magicNumber in head table during sanitize
2016-01-02 13:25:36 +00:00
9ab9f974d4
[docs] More buffers documentation
2016-01-01 20:38:21 +04:00
bfdf684f79
Merge pull request #205 from khaledhosny/more-docs
...
More docs
2015-12-30 22:20:14 +01:00
a7f0e25daf
Remove unused HB_SHAPER_DATA_ENSURE_DECLARE lines.
...
The coretext_aat shaper delegates to the regular coretext_..._ensure() functions, so coretext_aat_..._ensure() functions defined by these macros are unused. The compiler warns about them, which in turn can confuse people to think that the coretext_aat_..._ensure() functions weren't called by accident.
2015-12-30 16:05:52 -05:00
9cffe329f1
[docs] Typo
2015-12-30 22:50:08 +04:00
b758e5ea22
Merge pull request #203 from nico/patch-1
...
Remove unused `retry:` label.
2015-12-30 16:44:19 +01:00
fb192c263e
[docs] A bit more buffers documentation
2015-12-30 17:59:01 +04:00
8ab797c5b8
[docs] A bit more buffers documentation
2015-12-30 17:59:01 +04:00
f18d2226b6
[docs] Some documentation on buffers
...
Some of it (create, reference, destroy) are adapted from Cairo docs.
2015-12-30 17:59:01 +04:00
d7bf9d05c5
[docs] Fix comment syntax
...
To lower the number of gtk-doc warnings.
2015-12-30 17:58:53 +04:00
8b1224f0ee
Remove unused `retry:` label.
...
Fixes a -Wunused-label warning when building harfbuzz with clang -Wall.
2015-12-28 21:31:28 -05:00
fc38e6034c
[layout] Collect coverage glyphs in PairPos
...
Apparently class=0 is used for ClassDef1. See:
https://github.com/adobe-type-tools/afdko/issues/90
2015-12-23 14:50:53 +01:00
8718dae818
[python] Hook up sample debugger
2015-12-18 19:53:40 +00:00
0475ef2f97
[buffer] Add debugging, aka, message, API
...
Currently just announces lookup applications. Message-API *will* change.
hb-shape / hb-view are updated to print-out messages to stder if --debug
is specified.
2015-12-18 19:29:06 +00:00
9ea0aa43ac
Don't deserialize positions if buffer has no positions
2015-12-18 17:30:57 +00:00
862b1644e9
[use] Only set syllable-based topographical features if not Arabic-joining
2015-12-18 13:54:06 +00:00
45b7ec3652
[indic] Followup fix for Malayalam context matching
...
We regeressed Malayalam in 508cc3d3cf
2015-12-18 13:47:16 +00:00
2813e3049a
[indic] Update data tables to Unicode 8.0
...
Test stats remain unchanged, except for Malayalam, which we investigate:
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
MALAYALAM: 1047584 out of 1048334 tests passed. 750 failed (0.0715421%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
Myanmar, compared to Windows 10 mmrtext.ttf:
MYANMAR: 1123865 out of 1123883 tests passed. 18 failed (0.00160159%)
2015-12-18 11:05:11 +00:00
fc06cff40f
Remove HB_OT_SHAPE_ZERO_WIDTH_MARKS_DEFAULT
...
The DEFAULT naming wasn't helpful, so just remove it.
2015-12-17 17:47:35 +00:00
508cc3d3cf
[indic] Allow context when matching for Malayalam new-spec
...
Test sequence:
U+0995,U+09CD,U+09B0
With Nirmala shipped on Windows 10, this failed to form the below form.
Works now.
Reported by Sairus.
2015-12-17 17:31:17 +00:00
eaf1e93ef1
[uniscribe] Handle E_NOT_SUFFICIENT_BUFFER as well as E_OUTOFMEMORY
...
On Windows 10 we are seeing that other error message...
Test sequence: U+0995,U+-9CD,U+09B0
With Nirmala shipped on Windows 10, this failed to form the below form.
Works now.
Reported by Sairus.
2015-12-17 17:28:35 +00:00
100fbeaf19
Fix ligature component of a mark happening after a ligature within a ligature!
...
Say, if we are ligating "A B_C m D", then previously 'm' was being
attached to 'B' in the combined A_B_C_D ligature. Now we attach it
to 'C'. No test for this though :(.
2015-12-17 15:23:09 +00:00
2f02fc79a5
Improve ligature-component handling
...
We use three bits for lig_id these days, so we finally got a report of
two separate ligatures with the same lig_id happening adjacent to each
other, and then the component-handling code was breaking things.
Protect against that by ignoring same-lig-id but lig-comp=0 glyphs after
a new ligature.
Fixes https://github.com/behdad/harfbuzz/issues/198
2015-12-17 15:21:14 +00:00
2ab0de9fbd
[use] Fix halant detection
...
Before, we were just checking the use_category(). This detects as
halant a ligature that had the halant as first glyph (as seen in
NotoSansBalinese.) Change that to use the is_ligated() glyph prop
bit. The font is forming this ligature in ccmp, which is before
the rphf / pref tests. So we need to make sure the "ligated" bit
survives those tests. Since those only check the "substituted" bit,
we now only clear that bit for them and "ligated" survives.
Fixes https://github.com/behdad/harfbuzz/issues/180
2015-12-17 11:59:15 +00:00
86bcbd65b0
[arabic] Use glyph advance width in apply_stch() instead of extents
...
That seems to be what Windows is doing, and makes more sense.
2015-12-17 11:04:33 +00:00
f11c11a1f1
Fix Since: tags for new API
...
e1d4d0f1db (commitcomment-15006653)
2015-12-16 17:08:36 +01:00
a13b023dbf
AIX fixes
...
- use '-w' instead of '\<...\>' for check-header-guards
grep manpage says these are the same
- put '-q' first in the grep options
- move VAR into hb-private.hh
- hb-font-private.hh - use [VAR] instead of [] for variable array
2015-12-12 17:44:44 -08:00
49e72634af
Limit use of AIX intrinsics to IBM's compiler
2015-12-10 17:44:19 +01:00
e1d4d0f1db
Merge branch 'font-extents'
...
Fixes https://github.com/behdad/harfbuzz/pull/165
2015-12-10 16:56:07 +01:00
31fa389294
[ft] Use ftface->size->metrics for font extent info
2015-12-10 16:38:29 +01:00
3ad16048fd
[ot-font] Respect OS/2 fsSelection USE_TYPO_METRICS bit
2015-12-10 16:37:49 +01:00
70b33edae7
Add atomic ops for AIX
...
Patch from Volker Simonis.
2015-12-10 15:54:42 +01:00
98460779ba
Remove final pause from Arabic shaper
...
Back in the old days, we used to apply 'calt' and 'cswh' in Arabic shaper,
with a pause in between. Then we disabled the 'cswh' because Microsoft
disabled it, but forgot to remove the unnecessary pause. Do that now.
This has the benefit that it fixes shaping with monbaiti from Windows 10.
In that version of that font, the lookups from 'calt' are duplicated in
'rclt', and Mongolian was changed to go through Universal Shaping Engine.
We still use the Arabic shaper for Mongolian. With a pause after 'calt',
we were applying the duplicate lookups from 'calt' and 'rclt' twice. It
happened to be the case that these lookups were NOT idempotent. So we
were getting wrong shaping. See thread "Windows 10 monbaiti.ttf upgrade
(5.01 -> 5.51) caused loss of diacritical marks when shaped with harfbuz"
on the mailing list. This fixes that.
2015-12-07 21:38:47 +01:00
dee0fbf9e2
Merge pull request #192 from behdad/jfkthame-stch
...
[issue 191] Make apply_stch() give a more precise fit
2015-12-07 10:44:08 +01:00
255df68012
Fix undefined behavior in cmp function
...
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93274
2015-12-07 10:34:47 +01:00
fcf9e61bad
Fix sorting order of ot_languages array
...
Looks like the original sort was wrongly done.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93275
2015-12-07 10:30:43 +01:00
70952ddb5a
Add test to make sure ot-languages array is sorted
...
Currently fails. Part of
https://bugs.freedesktop.org/show_bug.cgi?id=93275
2015-12-07 10:28:46 +01:00
8c37556f73
Merge pull request #134 from ebraminio/dwrite
...
Add working but less prefect DirectWrite backend
2015-12-07 09:34:58 +01:00
a7ffe35358
Make apply_stch() give a more precise fit
...
This aims to make Syriac Abbr Mark sizing more accurate when repeating segments are used, by adding an extra repeat and tightening up the spacing slightly rather than leaving a shortfall corresponding to a partial repeat-width.
2015-12-05 17:47:37 +00:00
8e5f902656
src/test.cc: wrong field printed
...
Fixes https://github.com/behdad/harfbuzz/issues/188
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93182
2015-11-30 16:53:21 -08:00
6f2e6de1fa
Get font ascender and descender metrics from OS/2 table.
2015-11-27 16:03:54 -05:00
097c998a0c
Parse the OS/2 table.
2015-11-26 19:58:13 -05:00
35d18585fc
Fix a few docs blocks
2015-11-26 19:30:37 -05:00
0e38c918b6
[introspection] Make scanner happy with HB_EXTERN
2015-11-26 19:26:26 -05:00
ea512f7108
Use C-style casts instead of compare to 0, to convert hb_bool_t to bool
2015-11-26 19:22:22 -05:00
67a36a725e
Fix vertical GPOS
...
This was brorken earlier, though, it's really hard to notice it.
Unlike the glyph_h_origin(), an unset glyph_v_origin() does NOT
mean that the vertical origin is at 0,0.
Related to https://github.com/behdad/harfbuzz/issues/187
2015-11-26 18:49:54 -05:00
c41c145c73
Make nil glyph_h_origin() function return true
...
Fixes https://github.com/behdad/harfbuzz/issues/187
Funcs implementations that have a non-zero horizontal origin must
implement the glyph_h_origin() callback, nothing new here.
Other implementations (all I know of!) can simply not set
glyph_h_origin() now. I did that for hb-ot and hb-ft in
44f8275080
2015-11-26 18:43:15 -05:00
766963adba
Merge pull request #114 from ThePhD/vc++-fixes
...
Fix all VC++ warnings and errors
2015-11-24 15:38:43 -06:00
b344af80ca
Merge pull request #177 from fanc999/exporting
...
Enable use of compiler directives to export symbols
2015-11-24 15:30:27 -06:00
1979f6fedc
Fix y_scale problems in hb-gr
2015-11-23 10:04:13 +07:00
835bbdc7c9
Public headers: Decorate public symbols with HB_EXTERN
...
This prepares the headers for exporting symbols using visibility
attributes or __declspec(dllexport), so that we do not need to maintain
symbols listing files, as this is what was and is done in GLib and GTK+.
2015-11-23 11:03:11 +08:00
f798b8e2d6
c-style cast
2015-11-21 16:57:26 -05:00
a699181365
Merge pull request #176 from behdad/missing-braces
...
Add braces for subobject initializer in _hb_font_funcs_nil
2015-11-20 13:28:42 -08:00
1dc32ea4d2
Whitespace
2015-11-20 13:24:19 -08:00
f94c0ecbb1
Define HB_MARK_AS_FLAG_T as a macro instead of using templates
...
The generic template operator overloading was causing more problems than it
solved. Eg:
https://github.com/behdad/harfbuzz/pull/163
https://github.com/behdad/harfbuzz/issues/175
So, just use macros.
Fixes https://github.com/behdad/harfbuzz/issues/175
Fixes https://github.com/behdad/harfbuzz/pull/178
2015-11-20 13:21:29 -08:00
f19c6db18e
Add braces for subobject initializer in _hb_font_funcs_nil
...
To avoid triggering -Wmissing-braces; see https://bugzilla.mozilla.org/show_bug.cgi?id=1226175#c8
2015-11-20 08:43:49 +00:00
9cc1ed4fa6
Do not allow recursiving to same position and same lookup
...
This is just to make it harder to be extremely slow. There definitely
are ways still, just harder. Oh well... how do we tame this problem
without solving halting problem?!
Fixes https://github.com/behdad/harfbuzz/issues/174
2015-11-19 12:39:09 -08:00
13188cba7f
Revert "Fix hang in OOM situations"
...
This reverts commit f0599db761abadc1717d
2015-11-19 11:59:47 -08:00
18e1c6b6ef
Revert "Make sure we make progress in OOM situations"
...
This reverts commit 68b507a3c3abadc1717d
2015-11-19 11:50:58 -08:00
63fe05c8b1
Fix make distcheck
2015-11-18 23:52:51 -08:00
37b40cd8a1
Fix another move_to assertion failure
...
If buf->idx is at end, don't set end past it...
Fixes https://github.com/behdad/harfbuzz/issues/173
2015-11-18 23:04:45 -08:00
abadc1717d
Try to better handle OOM situations
...
Fixes assert fail in https://github.com/behdad/harfbuzz/issues/161
with libharfbuzz-fuzzing.
2015-11-18 17:52:08 -08:00
ff16ef3379
Enable building a bounded version of the library for fuzzing
...
test/fuzzing/hb-fuzzer links against libharfbuzz-fuzzing.so now.
2015-11-18 16:27:32 -08:00
e0082ae60d
Move things around
2015-11-17 18:42:13 -08:00
167c327177
Fix build on MSVC >= 2012
...
Use the DEFINE_ENUM_FLAG_OPERATORS macro in winnt.h on Visual Studio,
which defines the bitwise operators for the enumerations that we want to
mark as hb_mark_as_flags_t, which will take care of the situation on newer
Visual Studio (>= 2012), where the build breaks with C2057 errors as the
underlying types of the enumerations is not clear to the compiler when we
do a bitwise op within the declaration of the enumerations themselves.
Also disable the C4200 (nonstandard extension used : zero-sized array in
struct/union) and C4800 ('type' : forcing value to bool 'true' or 'false'
(performance warning)) warnings as the C4200 is the intended scenario and
C4800 is harmless but is so far an unavoidable side effect of using
DEFINE_ENUM_FLAG_OPERATORS.
2015-11-17 12:19:22 +08:00
4d27bb8746
hb-ot-shape-complex-arabic.cc: Fix build on Visual Studio
...
Visual Studio does not like declaring a enum variable within a for
statement, so fix the build by declaring the enum before doing the for
loop.
2015-11-16 23:04:36 +08:00
d5f0d7c9fb
Merge pull request #167 from KonstantinRitt/unicode_cp_opt
...
Micro optimizations to UTF-16 and UTF-32 codecs
2015-11-07 07:50:58 -08:00
04ff23e73d
[arabic] Improve stretch length calculation
...
Err on the side of being too short, than too wide. Reduces chance
of overlaps with neighboring glyphs.
2015-11-06 16:29:44 -08:00
59821ab8b4
[arabic] Don't stretch over cased letters
...
Addresses
6e6f82b6f3 (commitcomment-14248516)
2015-11-06 16:27:44 -08:00
5337db29af
Revert "Don't process lookups if buffer is in error"
...
This reverts commit f92bd86cc8
2015-11-06 16:18:09 -08:00
529a933128
Micro optimization to hb_utf16_t and hb_utf32_t ::prev()
...
Implement reverse lookup instead of re-using next()
2015-11-07 02:00:04 +04:00
44ae9be7a2
Nano optimization to hb_utf16_t and hb_utf32_t ::next()
2015-11-07 01:58:38 +04:00
f1c4adbcd3
Fix typo
2015-11-06 09:46:05 -08:00
68b507a3c3
Make sure we make progress in OOM situations
2015-11-06 00:09:26 -08:00
f0599db761
Fix hang in OOM situations
...
Fixes https://github.com/behdad/harfbuzz/issues/161
2015-11-05 23:55:51 -08:00
f92bd86cc8
Don't process lookups if buffer is in error
2015-11-05 23:52:29 -08:00
4301703bdd
Limit buffer max size growth
...
https://github.com/behdad/harfbuzz/issues/161
2015-11-05 23:44:59 -08:00
6e6f82b6f3
Implement SYRIAC ABBREVIATION MARK with 'stch' feature
...
The feature is enabled for any character in the Arabic shaper.
We should experiment with using it for Arabic subtending marks.
Though, that has a directionality problem as well, since those
are used with digits...
Fixes https://github.com/behdad/harfbuzz/issues/141
2015-11-05 17:46:34 -08:00
c743ec5886
[ft] Fix extents with negative scales
...
Fixes https://github.com/behdad/harfbuzz/issues/162
2015-11-05 17:38:27 -08:00
73fec3992a
Reserve a few scratch-flags bits for complex shapers
2015-11-05 15:22:18 -08:00
136863371c
Add new shaper method postprocess_glyphs()
...
Unused currently. To be used for Syriac stretch implementation.
https://github.com/behdad/harfbuzz/issues/141
2015-11-05 13:24:15 -08:00
e95eb23a4e
Don't try zeroing marks by GDEF if there are no non-ASCII
...
This one is a hack, but should be ok.
2015-11-04 22:59:28 -08:00
7fa54ed75a
Don't try zeroing mark attachments by Unicode if there's no non-ASCII
2015-11-04 22:59:24 -08:00
550bd14d2b
Actually commit changes for previous commit
2015-11-04 22:58:58 -08:00
ff31b3c1b8
Skip GPOS cursive / attachment adjustmnent if none happened
...
I'm starting to really like how free these new scratch_flags are.
2015-11-04 22:47:30 -08:00
0f407325f6
Minor
2015-11-04 22:28:44 -08:00
497a6c2071
Skip forming clusters if text is all ASCII
2015-11-04 22:24:19 -08:00
28de104f15
Move variable-sized struct member to end
...
Hopefully makes clang build happy
2015-11-04 22:03:09 -08:00
5bc28b5f68
Optimize positioning for when h_origin is nil
2015-11-04 21:53:16 -08:00
762770c964
Add font->has_...() to check for individual nil font funcs
...
Hopefully this wouldn't break any compiler. There was some magic
moments to getting this to compile...
2015-11-04 21:49:19 -08:00
88e9a9bcae
Minor reshaping of hb_font_funcs_t implementation
...
In anticipation of further changes. No functional changes.
2015-11-04 21:16:26 -08:00
a6a7715bac
Comments
2015-11-04 20:51:21 -08:00
6c48ec830f
[ot] Remove font funcs that do nothing
2015-11-04 20:47:42 -08:00
75ea2daa1d
[ot] Port ot font funcs to allocated object
2015-11-04 20:43:59 -08:00
44f8275080
[ft] Remove font funcs that do nothing
2015-11-04 20:43:43 -08:00
7918c261ef
[ft] Port ft font funcs to allocated object
2015-11-04 20:37:49 -08:00
da29b43794
Separate nil font-funcs from parent-peeking font-funcs
...
API change: all fonts created with hb_font_create() now inherit from
(ie have parent) hb_font_get_empty().
2015-11-04 20:22:44 -08:00
bee901b38e
Optimize positioning direction calculations
...
It makes the binary smaller AND faster. Yumm!
2015-11-04 19:28:17 -08:00
e3e4bb011a
Don't do fractions if buffer is ASCII-only
2015-11-04 18:58:02 -08:00
6986208ba3
Optimize runs without Default_Ignorable's
...
Now that we have a buffer-wide scratch flags facility, use it to
optimize away a few passes.
2015-11-04 18:46:41 -08:00
14c2de3218
Limit max edits during sanitize to 8
...
Used to be 100. If a tabe needs more than one or two edits, it's
probably completely bogus...
Might help with speeding up fuzzing for
https://github.com/behdad/harfbuzz/issues/157
2015-11-04 18:00:57 -08:00
9cbc39aef9
Minor
2015-11-04 18:00:53 -08:00
52e6c4e158
If font doesn't support U+2011, fall back to U+2010
...
Test passes now.
2015-11-04 17:45:56 -08:00
75483aafa6
Untangle if/else waterfall
2015-11-04 17:43:36 -08:00
49ef630936
Adjust the width of various spaces if font does not cover them
...
See discussion here:
81ef4f407dhttps://github.com/behdad/harfbuzz/issues/153
2015-11-04 17:27:07 -08:00
aa7044de0c
Generalize flags types
2015-11-04 16:25:57 -08:00
7793aad946
Normalize various spaces to space if font doesn't support
...
This resurrects the space fallback feature, after I disabled
the compatibility decomposition. Now I can release HarfBuzz
again without breaking Pango!
It also remembers which space character it was, such that later
on we can approximate the width of this particular space
character. That part is not implemented yet.
We normalize all GC=Zs chars except for U+1680 OGHA SPACE MARK,
which is better left alone.
2015-11-04 15:51:41 -08:00
8565839480
Protect against possible invalid-memory access after OOM
2015-11-04 14:46:52 -08:00
4cc80bed25
Fix typo!
...
Ouch! Fortunately that function was unused.
2015-11-04 14:46:10 -08:00
9ac4b9656d
Add Unicode space category
...
Unused so far.
2015-11-04 14:19:25 -08:00
8249ec3f86
Make top-byte of unicode_props available to be used differently per-GC
2015-11-04 13:26:17 -08:00
cc5d3a3388
Towards using top-byte of unicode-props for more things
2015-11-04 13:22:33 -08:00
2f38dde5a1
Add _hb_glyph_info_is_unicode_mark()
...
Unused right now.
2015-11-04 13:17:33 -08:00
90d75f93bb
Tighten ccc-setting a bit and document it
2015-11-03 12:58:12 -08:00
df698f3299
[ot-font] Fix hmtx table length checking, *again*
...
Exactly the same problem that I fixed in
63ef0b41dc67f8821fb2https://github.com/behdad/harfbuzz/issues/139#issuecomment-153449473
Fixes https://github.com/behdad/harfbuzz/issues/156
2015-11-03 12:15:12 -08:00
ed2024ef93
[perf] Micro-optimize
2015-11-02 18:03:38 -08:00
76a5310a83
Remove irrelevant comment
...
I tried moving the is_default_ignorable() function to an INTERNAL
function. That made the binary size grow by 5k AND things got a
tad bit slower!
2015-11-02 17:52:45 -08:00
8259669fbd
Minor
2015-11-02 17:44:05 -08:00
9382c471ea
Combine unicode_props0/1 into a uint16
...
Slightly faster. In prep for more changes.
2015-11-02 17:36:51 -08:00
7127718545
[perf] Only call combining_class() for marks
...
Saves some time. Also preparing for reusing the ccc byte for other stuff.
2015-11-02 17:27:48 -08:00
5ba450407b
Make max context-length and max nesting level configurable
...
...at compile time.
2015-11-02 15:43:39 -08:00
67f8821fb2
[ot] Make bad-hmtx handling match FreeType
...
Also route fuzzing-related tests through hb-ot-font, to reduce dependency
on FreeType behavior for badly-broken fonts. Fixes failing test with
FreeType master.
2015-11-02 15:37:29 -08:00
672ca3b4e6
Use templates for making sure expression is constant
2015-10-26 14:05:05 -07:00
5c8174eda3
Update comments for removal of compat decompositions
2015-10-21 18:51:40 -02:00
f679970040
Disable compatibility decomposition usage during normalization
...
Fixes https://github.com/behdad/harfbuzz/issues/152
2015-10-21 17:20:55 -02:00
ce889189c1
Fix two more -Wshadow warnings
...
https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
2015-10-21 11:23:12 -02:00
4a6b1eedbb
Fix one more -Wshadow warning
...
https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
2015-10-21 11:20:55 -02:00
6f932bc8f9
Fix a few more -Wshadow-local warnings
...
https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
2015-10-21 11:16:49 -02:00
b90cb366d7
Fix one -Wshadow-compatible-local warning
...
From https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
2015-10-21 11:13:21 -02:00
50e5750bd8
Avoid unnecessary cast to 64-bit
...
Fixes https://github.com/behdad/harfbuzz/issues/146
Or I think it should.
2015-10-21 11:10:40 -02:00
305d2fbf5a
Add HB_FALLTHROUGH
...
Borrowed from https://bugzilla.mozilla.org/show_bug.cgi?id=1215411
2015-10-21 11:04:28 -02:00
f35b3e931d
Add a prototype of DirectWrite as a shaping backend
2015-10-20 22:20:47 +03:30
ca97ea7aa2
[ft] Revert change-of-behavior of hb_ft_font_create() introduced in 1.0.5
...
The default FreeType load flags where changed from FT_LOAD_NO_HINTING
to FT_LOAD_DEFAULT in 2a9627c564https://github.com/behdad/harfbuzz/issues/143
2015-10-15 20:20:22 -03:00
63ef0b41dc
[ot-font] Fix hmtx wrong table length check
...
Discovered by libFuzzer. Ouch!
https://github.com/behdad/harfbuzz/issues/139#issuecomment-148289957
2015-10-15 12:54:28 -03:00
613e630617
Reduce max nesting level from 8 to 6
...
We probably should implement better system to catch cyclic lookups.
But for now, this speeds up worst case behavior with broken fonts
considerably without compromising legitimate usecases.
https://github.com/behdad/harfbuzz/issues/139#issuecomment-147788447
2015-10-13 23:33:28 -03:00
ed13e2ce50
[ot-font] Fix leak
...
https://github.com/behdad/harfbuzz/issues/139#issuecomment-147616887
2015-10-13 10:32:56 -03:00
f966649747
Fix another memory access issue discovered by libFuzzer
...
Fixes https://github.com/behdad/harfbuzz/issues/139#issuecomment-146984679
2015-10-13 00:30:50 -04:00
cc6ea308d4
Extern "C" custom-allocator declerations
2015-10-12 17:21:52 -04:00
50f489a0a0
Typo
2015-10-11 20:59:29 -04:00
ee9b0b6cb5
Fix another sanitize bug
...
Also discovered by "libFuzzer".
2015-10-09 14:23:15 -04:00
f396fbb000
Fix return value of sanitize when subformat is not readable
...
This is a fix on top of the previous issue fixed in
c917965b9e
2015-10-09 12:25:55 -04:00
77a1a2bc18
Add hb_dispatch_context_t
2015-10-09 12:20:58 -04:00
3e905e396b
Add hb_font_set_parent()
...
No reason to not have it. Makes life easier later.
We (hb-ft, hb-ot-font, etc) can use this API to inject new
parent into a font...
2015-10-08 12:51:02 -04:00
edeb3dabf4
[ft] Add version for new API
2015-10-08 12:47:15 -04:00
2a9627c564
[ft] API: Add hb_font_[sg]et_load_flags() API
...
This changes the default load_flags of fonts created using
hb_ft_font_create() from NO_HINTING to DEFAULT. Hope that doesn't
break too much client code.
Code calling hb_ft_font_set_funcs() is unaffected.
2015-10-07 17:39:37 -04:00
3224a594dc
Minor
2015-10-07 17:33:02 -04:00
52b418555b
Allow compiling with custom allocators
...
User can define hb_malloc_impl, etc, to name of custom allocator functions
that have the same signature as malloc.
2015-10-03 13:20:55 +01:00
88da7bba9f
Default font scale to face upem
...
Makes for a better default and avoids nasty inheritance issues.
See mailing list thread "Default hb_font_t scale".
2015-10-02 14:38:20 +01:00
1866e17114
Make hb_font_create_sub_font() NOT make parent immutable
...
We don't rely on that. However, whenever hb_font_make_immutable()
is called, it makes its parenting chain immutable.
2015-10-02 14:21:29 +01:00
980e25cad2
Fix hb-ot-shape-normalize with empty buffer
...
Part of https://github.com/behdad/harfbuzz/issues/136
2015-10-02 08:21:12 +01:00
a5efaac4ff
Replace a couple of malloc()s with calloc()
2015-10-02 08:02:29 +01:00
26ba4d1e1f
Fix segfault with empty buffer in hb_shape_plan_execute()
...
Move the empty-buffer check from hb_shape_full() to hb_shape_plan_execute().
Reported by Simon Cozens.
2015-10-02 07:25:52 +01:00
b47159011c
Define return_trace()
...
Not functional change (expected!).
2015-09-29 14:57:02 +01:00
c917965b9e
Add missing returns
...
Fixes possible invalid read of two bytes.
Reported by Behzad Najjarpour Jabbari, Secunia Research.
2015-09-29 14:45:35 +01:00
f3159ba514
Micro-optimize hb_language_from_string()
...
As measured / improved by Benson Limketkai.
2015-09-29 14:34:56 +01:00
f2ad935e19
Handle language tags that indicate phonetic IPA transcription
...
The BCP-47 registry defines a variant subtag "fonipa" that can be used
in combination with arbitrary other language tags. For example,
"rm-CH-fonipa-sursilv" indicates the Sursilvan dialect of Romansh
as used in Switzerland, transcribed used the International Phonetic
Alphabet.
http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
2015-09-29 14:32:06 +01:00
b8811429b6
Fix Since tags
...
Fixes https://github.com/behdad/harfbuzz/issues/103
2015-09-03 15:53:22 +04:30
5d74ff02ab
Fix Since: version tags on font and face APIs
...
A while back we marked every API as version:1.0. We should fix them all
to reflect real version they were introduced. This is a start.
Patch from Nikolay Sivov.
2015-09-03 14:55:59 +04:30
5828c45d7a
[indic] Add comments to merge_clusters calls
2015-09-01 16:34:12 +01:00
bdc8215949
[thai] Respect cluster-level > 0
2015-09-01 16:24:54 +01:00
5b31fe383e
[use] Merge /before/ reordering
2015-09-01 16:24:34 +01:00
0d438f89bd
[hangul] Merge /before/ reordering
2015-09-01 16:24:13 +01:00
f883de664f
[OT] Merge /before/ reordering
2015-09-01 16:23:40 +01:00
c403d63200
[myanmar] Use buffer->sort() to sort cluster
...
This can possibly produce more granular clusters.
2015-09-01 16:15:25 +01:00
e995d33c10
[OT] Merge clusters when reordering marks for normalization
...
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=541608
and cluster test.
2015-09-01 16:13:32 +01:00
93099748e3
Minor
2015-09-01 16:11:27 +01:00
85846b3de7
Use insertion-sort instead of bubble-sort
...
Needed for upcoming merge-clusters fix.
2015-09-01 15:07:52 +01:00
326b5ebf57
Poison freed objects such that double-free is detected
...
Previously we were setting refcount of freed objects to the inert value, which
was harmful because it caused further destroy()s of the freed object to NOT
call free() and hence hide the bug. Indeed, after eb0bf3ae66
2015-08-30 17:29:21 +01:00
6578575cc8
[GPOS] Fix cursive connection with mix of RTL and non-RTL lookups
...
See thread "Issue with cursive attachment" started by Khaled.
Turned out fixing this wasn't as bad as I had assumed. I like the
new code better; we now have a theoretical model of cursive
connections that is easier to reason about.
2015-08-25 20:29:36 +01:00
58f2a73fb9
[GPOS] Rewrite cursive attachment slightly differently
...
In anticipation for upcoming fix for bug reported by
Khaled in thread "Issue with cursive attachment".
2015-08-25 18:58:24 +01:00
fdd1770e00
Add API/cmdline to show glyph extents when serializing buffer
...
New API: HB_BUFFER_SERIALIZE_FLAG_GLYPH_EXTENTS
hb-shape now accepts --show-extents.
Patch from Simon Cozens.
2015-08-24 13:49:55 +01:00
2cee5b68a0
[ot-font] Fix short-offset calculation
2015-08-24 13:45:12 +01:00
b50fcfa829
[ot-font] Implement glyph_extents() for TrueType fonts
...
This brings ot-fonts into almost-complete shape and mostly in par with
ft font.
2015-08-23 14:42:20 +01:00
0299b45000
Make BYTE a real type
2015-08-21 12:44:36 +01:00
ed6962c795
[coretext] Use i32 instead of u32 as well
...
Shouldn't cause *any* functional changes, but is more correct.
2015-08-20 15:39:53 +01:00
163c435f18
[uniscribe] Fix negative offsets
...
Ouch!
2015-08-20 15:39:06 +01:00
958c268fa3
[coretext] Add TODO item
2015-08-19 13:22:12 +01:00
7c5bee09d9
[uniscribe] Fix font scale handling
...
By default shape at upem (or ppem), and scale results.
Similar to work done in CoreText backend, but using upem as default.
2015-08-19 13:20:31 +01:00
902e74a098
Commented-out code to print buffer before each lookup
...
To be turned into a useful HB_DEBUG_SHAPE infrastructure...
2015-08-18 18:55:03 +01:00
75504a5048
Allow serializing buffer with output-buffer being used
...
Ie, don't call get_positions() if positions are not
requested for serialization.
2015-08-18 18:47:02 +01:00
e47b772a56
[ot] Change buffer content type right after we map to glyphs
...
Needed for upcoming debug output changes.
2015-08-18 18:42:47 +01:00
ddd6bf12f1
Don't declare dependency on freetype in harfbuzz.pc
...
See comments.
2015-08-18 15:55:09 +01:00
2c8b3b2e53
[debug] Print lookup index in debug-apply output
2015-08-18 14:36:43 +01:00
50ad7788ee
[coretext] Remove assert that kicks in on Mac OS 10.6
...
http://crbug.com/419769
2015-08-18 10:22:16 +01:00
2b646fa07f
Remove unused function
2015-08-17 16:03:28 +02:00
23237b0279
Last apparent boolean fix!
2015-08-14 01:19:08 -04:00
5c99cf93d6
Merge branch 'master' into vc++-fixes
2015-08-14 01:02:00 -04:00
539a610e2e
Add Libs.private and Requires.private to harfbuzz.pc
...
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=64501
2015-08-11 12:58:49 +02:00
c7dfe316f8
Don't rely on .cluster in _hb_ot_shape_normalize()
...
Fixes https://github.com/behdad/harfbuzz/pull/124
2015-08-09 18:26:27 +02:00
9099e48e29
Don't rely on .cluster field in fallback_position
...
Fixes tests/cluster.
Fixes https://github.com/behdad/harfbuzz/pull/123
2015-08-08 18:03:38 +02:00
bd22a5cfae
Bug 91559 - HarfBuzz 1.0.1: Inconsistent DLL files specified/created...
...
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=91559
2015-08-07 11:13:27 +02:00
f1c20e1ba5
[USE] Fix out-of-bounds static array access
2015-07-27 12:16:02 +02:00
260442346a
1.0.0
2015-07-26 23:39:10 +02:00
df6cb84449
Merge branch 'use'
2015-07-26 19:40:55 +02:00
23e56e088a
Fix broken sentence
2015-07-25 17:38:21 +02:00
91a2e5d287
Update UCDN to upstream commit 8af93f30
...
This adds support for Unicode 8.0 and fixes a bug with wrong properties
for ranges of codepoints.
2015-07-25 17:32:16 +02:00
0f98fe88f4
[ot] Search globally for 'vert' feature if not found in specified script/lang
...
Fixes https://github.com/behdad/harfbuzz/issues/63
2015-07-23 11:52:11 +01:00
f327aacfa1
[ot] Minor
2015-07-23 11:32:59 +01:00
d78463c801
Minor debug output fix
2015-07-23 10:11:35 +01:00
d99f50bde0
Add missing TRACE_RETURN
2015-07-23 10:08:48 +01:00
2dc8e3f470
[ot] Add missing return!
2015-07-23 10:07:21 +01:00
8cfbc304ee
Fix hide-default-ignorables after f0010dfd01
...
We can't delete things before hb_ot_layout_position_finish(). So,
just zero the advance before it, and remove later.
2015-07-22 18:41:10 +01:00
2dbd3d29d6
Fix hide-ignorables if font doesn't have space glyph
...
Was broken by 82b521aeb7
2015-07-22 18:29:47 +01:00
4ba796b26e
Refactor _hb_glyph_info_is_default_ignorable()
2015-07-22 17:41:31 +01:00
f0010dfd01
[ot] Hide default-ignorables before finishing off positioning
...
For example, fixes the following sequence with Arial XP:
628 25cc 651 25cc 64e 3a 20 628 651 34f 64e
628 25cc 64e 25cc 651 3a 20 628 64e 34f 651
Discovered as part of:
https://bugs.freedesktop.org/show_bug.cgi?id=85873
2015-07-22 17:36:23 +01:00
376d587f36
Implement more granular cluster-merging
...
TODO: Documentation.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=71445
2015-07-22 16:51:12 +01:00
a60e2cfa39
[ot] Don't rely on cluster numbers for ensure_native_direction()
2015-07-22 15:49:08 +01:00
701112dad9
[ot] Simplify form_clusters()
2015-07-22 15:42:20 +01:00
7b8b63adc5
[ot] Don't mirror character if font doesn't support mirrored character!
2015-07-22 15:24:26 +01:00
97d7c3a100
[graphite2] Fix bunch of stuff
...
Based on patch from Martin Hosken, with review from Jonathan and I.
2015-07-22 14:28:25 +01:00
ea7f8414e3
[graphite2] Enlarge buffer for output glyphs!
2015-07-22 13:53:45 +01:00
9cd59db1af
[USE] Implement topographical features for non-Arabic-joining scripts
...
This works per-syllable as per the spec, but we think it should be per
spacing/base/??? glyph instead.
2015-07-22 13:31:07 +01:00
ecb0b24ef3
Use foreach_cluster in Indic shaper
2015-07-22 12:02:09 +01:00
56f71ff988
Use foreach_syllable in Myanmar shaper
2015-07-22 11:58:11 +01:00
ac596511a8
Add foreach_syllable
...
Use it in USE.
2015-07-22 11:54:02 +01:00
8ba9e68968
[USE] Do Arabic-like shaping
2015-07-22 11:17:34 +01:00
9daf2dfb6b
Add hb-ot-shape-complex-arabic-private.hh
2015-07-22 10:49:13 +01:00
a51a661fe1
[USE] Only reorder the first component of a split left mark
2015-07-21 18:24:21 +01:00
a08a278b15
[USE] Don't compose split matras
...
Same logic as in Indic shaper.
2015-07-21 18:09:40 +01:00
21cb08a417
Remove unused SEA shaper
2015-07-21 17:47:06 +01:00
db1e9cdd41
Retire SEA shaper in favor of USE
2015-07-21 17:46:06 +01:00
87dde9c647
[USE] Only use USE shaper if script system is not DFLT
...
Same logic as Indic and SEA.
2015-07-21 17:31:43 +01:00
29832d797f
Route misc untested scripts through USE shaper instead of Indic
...
These were never tested with Indic shaper, and indeed wouldn't work there
because they didn't have their viramas and other config defined. They are
all also supported by MS through USE, so route them there.
2015-07-21 17:24:18 +01:00
40c4a991c7
[USE] Implement dotted-circle
...
This makes USE feature-complete as far as the Indic-like features
are concerned.
2015-07-21 17:14:54 +01:00
7ce03ebe7c
[USE] Move pref
2015-07-21 16:55:26 +01:00
2d4b62ead9
[USE] Fix-up variation selectors and word joiner in table
2015-07-21 16:46:37 +01:00
ad7178227f
[USE] Use a couple warnings
2015-07-21 16:43:27 +01:00
a85c4da9b1
[USE] Move rphf
2015-07-21 16:07:10 +01:00
5b5617e066
Add FLAG_UNSAFE()
...
Unused right now.
2015-07-21 15:52:15 +01:00
f8160a4959
Add FLAG_SAFE() for values known to be small-enough
...
And add check to FLAG()
2015-07-21 15:50:02 +01:00
366aeaad00
Add note re ASSERT_STATIC_EXPR_ZERO()
2015-07-21 15:45:48 +01:00
d6adca9fbb
Remove unused macro ASSERT_STATIC_EXPR()
2015-07-21 15:17:27 +01:00
1025e1a9e7
Use unsigned in FLAG()
2015-07-21 15:05:35 +01:00
cf59c7589c
[USE] Use use_category() for rphf/pref memory
2015-07-21 14:51:45 +01:00
595936ec25
[USE] Hook of rphf and pref custom processing
...
Still no reordering.
2015-07-21 14:15:35 +01:00
ba72801325
[USE] Add CGJ to table
2015-07-21 11:57:23 +01:00
4febed61ed
[USE] Set up features
2015-07-21 10:38:48 +01:00
52a9577956
[USE] Hook up new scripts to USE shaper
...
Don't reroute scripts that we were routing to other shapers
before (just yet).
2015-07-21 10:02:04 +01:00
b4c0829bc1
[USE] Remove unused Unicode data enums from USE C++ side
2015-07-21 09:31:19 +01:00
44910cef62
[USE] Finish converting Unicode positional categories to USE
...
Even compiles.
2015-07-20 18:01:10 +01:00
ad72555252
[USE] Map from Unicode data to USE syllabic categories
...
Positional sub-categories not applied yet.
2015-07-20 17:00:06 +01:00
20e246e674
[USE] Start moving Unicode-to-USE mapping into Python code
2015-07-20 15:56:19 +01:00
eb74535cc2
[USE] Fix Number clusters
...
The spec wrongly has "H" where "HN" is meant.
2015-07-20 15:33:25 +01:00
a9663958fe
[USE] Start putting together the shaper body
2015-07-20 14:24:55 +01:00
e0eabd7f67
[USE] Put a Ragel machine together
...
Grammar from the spec!
2015-07-20 13:50:38 +01:00
fd74b939b1
Minor
2015-07-20 13:30:45 +01:00
5e5c8560cc
[USE] Minor optimization of USE table
2015-07-20 12:01:20 +01:00
c48ff28852
[USE] Build Universal Shaping Engine data table from Unicode 8 files
2015-07-20 11:46:17 +01:00
e2c95116e1
[USE] Add Universal Shaping Engine to Makefile
2015-07-20 11:33:27 +01:00
41a29af805
Update Arabic shaping table for Unicode 8.0
2015-07-15 01:39:57 +01:00
64a2726e2c
Add Unicode 8.0 scripts
...
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1183209
2015-07-15 01:36:39 +01:00
9ae156b768
Fix pragma usage
...
https://bugs.freedesktop.org/show_bug.cgi?id=91228
Commit cdcdfe61b9
2015-07-05 22:43:17 +01:00
8ad89f057d
Spelling words is not my strong point.
2015-06-23 09:09:24 -04:00
e0a828ecbd
Back to using regular `strdup`, with an `hb-private.hh` fix that special-cases VC++'s
...
definition and usage of the words
2015-06-23 09:07:17 -04:00
8e545d5961
Fix all VC++ warnings and errors in the current commit's builds.
2015-06-22 22:29:04 -04:00
5f13bbd9d4
When removing default-ignorables, merge clusters
...
Fixes test-shape, and:
https://code.google.com/p/chromium/issues/detail?id=497578
2015-06-19 13:31:49 -07:00
82b521aeb7
Rewrite hide_default_ignorables
...
Separate the loops for the two cases of replacing with space
and deleting. For deleting, use the out-buffer machinery.
Needed for upcoming cluster merge fix.
2015-06-19 13:26:03 -07:00
351f68f4e0
[bindings] Fix hb_language_get_default() and hb_ot_tag_to_language()
...
Part of https://github.com/behdad/harfbuzz/issues/91
2015-06-12 17:46:06 -07:00
a5e4f6d608
Fix warnings: "member call on null pointer of type"
...
https://bugzilla.mozilla.org/show_bug.cgi?id=1167119
2015-06-10 10:57:46 -07:00
8dacb7f8b4
Add include check to hb-ot-font.h
2015-06-03 11:53:42 -07:00
01c3a88543
Fix "Since:" tags
...
Based on data from http://upstream-tracker.org/versions/harfbuzz.html
Resolves #103
2015-06-01 13:25:27 +02:00
f1b44303df
Fix unary minus operator applied to unsigned int
...
Applying unary minus operator to unsigned int causes the following
warning on MSVS:
warning C4146: unary minus operator applied to unsigned type, result still unsigned
Based on patch from Koji Ishi.
Fixes https://github.com/behdad/harfbuzz/pull/110
2015-05-21 14:00:15 -07:00
1ae6cdb365
[gobject] Remove hb_language_t workarounds for g-i shortcomings
...
Using latest gobject-introspection, I don't seem to be having this
problem anymore:
https://bugzilla.gnome.org/show_bug.cgi?id=707656
Removing that kludge makes language_t behave more like the way I expect it
in Python.
Also fixes:
https://github.com/behdad/harfbuzz/issues/91
2015-05-19 17:42:30 -07:00
ece434fa0f
[gobject] Macroize value types
...
Fixes user_data_t
2015-05-19 17:20:58 -07:00
9df099b483
[ft] Don't set *glyph in get_glyph() if glyph not found
2015-05-18 18:37:46 -07:00
5801521532
Add note re OpenType 1.7 language tags
2015-05-06 00:40:31 -07:00
f6266ad291
[minor] Remove comment about Navajo OpenType code.
...
Apparently the code is already standardized:
https://www.microsoft.com/typography/otspec/languagetags.htm
2015-05-05 22:39:04 -07:00
42b00118ea
Merge pull request #102 from roozbehp/master
...
Add OpenType language tag 'NAV ' for Navajo.
2015-05-05 14:49:47 -07:00
be66ec5373
Use TRUE/FALSE instead of true/false in docs
2015-04-30 18:27:13 -04:00
d055e1fc78
Some attempt into initial hb-shape documentation
...
Very anaemic, needs to descripe the format understood by
hb_feature_from_string() etc., but it is just start.
2015-04-30 18:24:45 -04:00
81bedda58c
New API: hb_buffer_reverse_range()
2015-04-30 13:04:16 -04:00
cfeb0562eb
Add OpenType language tag 'NAV ' for Navajo.
...
The code is not standardized yet, but is used in some Google fonts.
2015-04-29 09:32:42 -07:00
f724cc3516
Don't apply Arabic shaping to vertical text.
2015-04-24 12:19:02 -07:00
97942420bb
Update check-libstdc++ for clang
2015-04-23 18:56:24 -07:00
39851ce84e
[coretext] Oops; fix issue number for previous commit
2015-04-21 19:23:27 -07:00
24f17afeaf
[coretext] Fix positioning with trailing whitespace
...
Fixes https://code.google.com/p/chromium/issues/detail?id=476913
2015-04-21 19:21:32 -07:00
dba482fc44
[ot-font] Accept MS Symbol cmap if nothing else found
2015-04-17 13:08:08 -07:00
3029e8b59d
Revert "Add MSVC pragma for UTF-8 source code"
...
This reverts commit 89cbd4d953https://bugzilla.gnome.org/show_bug.cgi?id=747772
2015-04-14 13:32:22 -07:00
89cbd4d953
Add MSVC pragma for UTF-8 source code
...
Not sure we have any right now; motivated by this:
https://bugzilla.gnome.org/show_bug.cgi?id=747772
2015-04-13 12:27:08 -07:00
713f99ff61
Merge pull request #99 from khaledhosny/introspection-fixes2
...
More ntrospection fixes
2015-04-10 14:34:05 -07:00
22524a514f
[bindings] Fix hb_buffer_get_segment_properties
...
Annotate the output parameter.
2015-04-10 22:57:38 +02:00
1086f21e54
Merge branch 'hb-fc'
2015-04-10 12:21:04 -07:00
04f89e8f7d
[bindings] Fix ownership of returned hb_language_t
...
It should not be freed by the caller.
2015-04-10 18:17:02 +02:00
855a5d7cb8
Fix build on WEC2013
...
Based on patch from Björn Breitmeyer
2015-04-10 17:18:01 +04:00
eb0bf3ae66
Relax inert checks
...
Previously, when creating an object from inert inputs (eg:
"hb_font_create(hb_face_get_empty())") we returned the inert
empty object. This is not helpful as there are legitimate
usecases to do that.
We now never return the inert object unless allocation failed.
Tests are revised to reflect.
2015-04-09 19:16:57 -07:00
9c974360fe
Minor rename
2015-04-09 12:04:14 -07:00
f3b170bdd9
Minor
2015-04-08 16:26:24 -07:00
2958f2c147
Fixup
2015-04-08 16:26:16 -07:00
b931e0b0ce
Fix warnings
...
Part of https://github.com/behdad/harfbuzz/pull/68
2015-04-08 14:43:33 -07:00
cdcdfe61b9
Err, instead of warn, if mutex / atomic / unicode funcs are missing
...
Hopefully this results in fewer badly built HarfBuzz integrations.
2015-04-08 13:25:04 -07:00
fc3c59a1d7
Fix unused var warnings
2015-04-08 13:04:29 -07:00
3f174cd020
Minor refactoring to the atomics implementation
...
s/atomic_int/atomic_int_impl/ and s/atomic_ptr/atomic_ptr_impl/
to bring it in par with hb_mutex_impl_t, then re-introduce
hb_atomic_int_t as a wrapper around hb_atomic_int_impl_t.
In hb_reference_count_t, make it clear the non-atomic get and set
are intentional due to nature of the cases they are used in
(comparison to -1 and the debug output/tracing).
2015-04-08 13:04:22 -07:00
24930d544e
Minor
2015-04-08 12:52:06 -07:00
45a8b46f47
Allow implementing atomic and mutex ops in config
...
Motivated by
https://github.com/behdad/harfbuzz/pull/92
2015-04-08 12:49:38 -07:00
3fe4e92bc5
Minor
2015-04-08 12:49:23 -07:00
ce01ad7c2f
MSVC 2015 supports snprintf and not _snprintf
2015-04-01 11:05:59 -07:00
560718862f
Move WinCE define to better place
2015-04-01 11:04:58 -07:00
aee685086c
Fix VC++ /analyze warnings
...
out\debug\hb-buffer-deserialize-text.rl(47) : warning C6001: Using
uninitialized memory 'pos'.
2015-03-26 14:13:53 -04:00
a394bb6670
[bindings] Fix *_from_string functions
...
Without the element-type they will be getting garbage, at least with
Python.
2015-03-22 20:29:10 +02:00
9e401f6890
Fix reverse_range() for empty range
...
Fixes coretext notdef loop consisting of all default_ignorable glyphs
https://code.google.com/p/chromium/issues/detail?id=464755
2015-03-20 16:08:38 -04:00
98e3ea8e34
Fix hb-uniscribe build
2015-03-04 12:03:39 -08:00
8ac345e5c0
Fix reverse_range() to only reverse alt array if positions are used
...
In hb-coretext, when we were using scratch buffer for book-keeping,
a reverse_range() caused by the notdef-insertion loop could mess up
our log_clusters. Ouch!
2015-03-02 16:06:55 -08:00
5f541f8f7b
Minor refactoring
2015-02-25 15:43:35 -08:00
Behdad Esfahbod
Frédéric Wang
jfkthame
nvelinov
Mike Hommey
Volker H. Simonis
ebraminio
Sascha Brawer
Seigo Nonaka
Khaled Hosny
Dominik Röttsches
Birunthan Mohanathas
Steve Lhomme
Kelvin
Dominik Röttsches
Arthur Reutenauer
Konstantin Ritt
Kal Conley
Chun-wei Fan
Martin Hosken
Nico Weber
Steven R. Loomis
Simon Cozens
ThePhD
Grigori Goronzy
Roozbeh Pournader