5d874d566f
[GPOS] Fix mark-to-mark positioning when one of the marks is a ligature
...
This commit: a3313e5400
2012-07-28 21:05:25 -04:00
338fe662b5
[GSUB] Minor
2012-07-28 18:53:01 -04:00
e6f7479fe3
[GSUB] Simplify would-apply
2012-07-28 18:34:58 -04:00
dadede012e
Minor
2012-07-28 18:13:09 -04:00
0b99429ead
[GSUB/GPOS] Add get_coverage() and use it to speed up main loop
...
And use it to speed up the hotspot by checking coverage directly in
the main loop, not 10 functions deep in.
Gives me a solid 20% boost with Indic test suite. Less so for less
lookup-intensive scenarios.
Remove the "fast_path" hack from before.
2012-07-28 17:46:35 -04:00
30ec9002d8
Reject lookups with no subTable
2012-07-28 17:25:20 -04:00
0981068b75
[GSUB/GPOS] Reject Context/ChainContext lookups with zero input
2012-07-28 17:01:59 -04:00
2f87cebe10
Implement shape_plan caching
...
Should give us some performance boost.
2012-07-27 04:20:39 -04:00
e9eb9503e9
Add default_shaper_list to shape_plan
2012-07-27 03:16:22 -04:00
3b7c4e2706
Don't fail choosing shaper on planning failure
...
Shapers have a chance to reject a font in face shaper_data creation.
No need to allow failing during planning.
2012-07-27 03:12:23 -04:00
cfe9882610
Add hb_ot_layout_ensure() and hb_uniscribe_font_ensure()
2012-07-27 03:06:30 -04:00
c5b668fb92
Choose one shaper per plan
2012-07-27 02:49:39 -04:00
e82061e8db
Move ot shaper completely to shape_plan
2012-07-27 02:29:32 -04:00
ea278d3895
Partially switch ot shaper to shape_plan
2012-07-27 02:12:28 -04:00
b6b7ba1313
Switch old and uniscribe backends to shape_plan
2012-07-27 01:37:18 -04:00
c32c096a42
Switch to shape_plan
...
Not optimized yet. Eats babies. And no shaper uses the shape_plan.
2012-07-27 01:13:53 -04:00
5b95c148cc
Start implementing shape_plan
2012-07-27 01:02:24 -04:00
bd26b4d21f
Minor
2012-07-26 22:18:24 -04:00
027857d041
Start adding a unified shaper access infrastructure
...
Add global shape_plan. Unused so far.
2012-07-26 21:14:02 -04:00
fa2dfcd560
Fix visibility warnings with MinGW32
2012-07-26 16:06:16 -04:00
ac2085d4b3
[CoreText] Ensure cluster indices in output buffer are non-decreasing.
...
Does not provide Uniscribe-compatible results, but should at least avoid
breaking hb-view due to out-of-order cluster values.
For RTL runs, ensure cluster values are non-increasing (instead of
non-decreasing).
2012-07-26 15:58:45 -04:00
441d3bb7de
Minor
2012-07-26 12:01:12 -04:00
2e7f223054
[hb-old] Fix Arabic cursive positioning
...
Backporting from upstream:
commit b847f24ce855d24f6822bcd9c0006905e81b94d8
Author: Behdad Esfahbod <behdad@behdad.org>
Date: Wed Jul 25 19:29:16 2012 -0400
[arabic] Fix Arabic cursive positioning
This was clearly broken in testing. Who knows... Fixes for me.
Test with a Nastaleeq font, or with Arabic Typesetting.
Backporting from Chromium.
2012-07-25 19:30:15 -04:00
9550a8c4e8
[hb-old] Fixup not-enough-space handling
2012-07-25 19:22:57 -04:00
91e721ea86
[hb-old] Fix clusters
...
Unlike its "documentation", hb-old's log_clusters are, well, indeed
logical, not visual. Fixup. Adapted / copied from hb-uniscribe.
2012-07-25 19:20:34 -04:00
a3313e5400
[GPOS] Fix MarkMarkPos applied to results of MultipleSubst
...
This was broken as a result of 7b84c536c1
2012-07-25 18:37:51 -04:00
35bdab3cf1
Minor
2012-07-25 11:59:52 -04:00
8fe4c7405b
[hb-old] Add HarfBuzz.old shaper
...
Choose using shaper name "old".
2012-07-25 11:11:22 -04:00
5e1987005e
[hb-old] Define Unicode funcs in terms of new HarfBuzz
2012-07-25 11:11:22 -04:00
4a31166b28
[hb-old] Shovel out the line-breaking / word-segmentation stuff
2012-07-25 11:11:22 -04:00
0bcbe88cf3
[hb-old] Add visibility attributes
2012-07-25 11:11:22 -04:00
6a9d43c317
[hb-old] Remove unused header file
2012-07-25 11:11:22 -04:00
fb47209c5b
[hb-old] Rename hb_buffer_* to HB_Buffer_*
2012-07-25 11:11:22 -04:00
1512a73575
[hb-old] Start adding HarfBuzz-old as a new backend
2012-07-25 11:11:16 -04:00
478fd0529b
Minor
2012-07-24 17:09:01 -04:00
8979a7f6f2
[Mongolian] Remove Mongolian Vowel Separator at the end of shaping
...
Results match Uniscribe now.
2012-07-24 17:03:55 -04:00
aa6d849838
[CoreText] Add basic Core Text backend for comparison with our native shaping
...
Does not attempt to handle clusters in a Uniscribe- or HarfBuzz-compatible way;
just returns the original string indexes that CT maintains. These may even be
out-of-order in the case of reordrant glyphs.
2012-07-24 15:52:32 -04:00
ec8d249469
Make data members of various OpenType structs protected instead of private
...
Should fix warnings generated when building with -Wunused-private-field.
Based on patch from Jonathan Kew.
2012-07-24 15:40:37 -04:00
97aa0b738a
Minor const correctness shuffling
2012-07-24 15:02:34 -04:00
6411e74caf
[Indic] Reposition Gurmukhi top matras to after post
...
The font is forming a post-base consonant in some samples, and Uniscribe
positions top matra on the post-base. Do the same.
Gurmukhi failures down from 59 to 41 (0.0674242%).
2012-07-24 13:48:49 -04:00
65c43accdc
[Indic] Better position left-matra in Malayalam
...
Just put it before base, which is what's expected.
Malayalam failures down from 1559 to 1197 (0.114172%).
BENGALI: 353988 out of 354285 tests passed. 297 failed (0.0838308%)
DEVANAGARI: 693571 out of 693628 tests passed. 57 failed (0.00821766%)
GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%)
GURMUKHI: 60750 out of 60809 tests passed. 59 failed (0.0970251%)
KANNADA: 950956 out of 951913 tests passed. 957 failed (0.100534%)
KHMER: 299094 out of 299124 tests passed. 30 failed (0.0100293%)
MALAYALAM: 1047219 out of 1048416 tests passed. 1197 failed (0.114172%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271699 out of 271847 tests passed. 148 failed (0.0544424%)
TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%)
TELUGU: 970524 out of 970573 tests passed. 49 failed (0.00504856%)
2012-07-24 03:36:47 -04:00
88f413b56f
[Indic] Implement Reph+Ya-Phalaa interaction
...
The sequence Ra,H,Ya in Bengali is ambigious and Unicode encoded that to
get Ya-Phalaa, one would place ZWJ before Halant. Ie. a ZWJ,H sequence
requests subjoining, while a H,ZWJ requests Half form. Implement that.
Bengali failures go down from 377 to 297 (0.0838308%).
Gujarati is down by 4 to 17 (0.0046384%).
Kannada is down by 226 to 957 (0.100534%).
Current status:
BENGALI: 353988 out of 354285 tests passed. 297 failed (0.0838308%)
DEVANAGARI: 693571 out of 693628 tests passed. 57 failed (0.00821766%)
GUJARATI: 366489 out of 366506 tests passed. 17 failed (0.0046384%)
GURMUKHI: 60750 out of 60809 tests passed. 59 failed (0.0970251%)
KANNADA: 950956 out of 951913 tests passed. 957 failed (0.100534%)
KHMER: 299094 out of 299124 tests passed. 30 failed (0.0100293%)
MALAYALAM: 1046857 out of 1048416 tests passed. 1559 failed (0.148701%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271699 out of 271847 tests passed. 148 failed (0.0544424%)
TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%)
TELUGU: 970524 out of 970573 tests passed. 49 failed (0.00504856%)
2012-07-24 03:04:36 -04:00
dff0ece11d
[Indic] Limit matras to 4 per syllable
...
Also limit joiners.
This limits our syllable length to a constant, and is
closer to what Uniscribe does anyway.
Two Devanagari tests regressed, but who cares about tests with 20
joiners in a row?! Devanagari at 57 (0.00821766%) now.
2012-07-24 02:37:42 -04:00
330b329c89
[Indic] Unmark U+17D1 KHMER SIGN VIRIAM to NOT be a Virama
...
Fixes another 1 Khmer failure. Down to 30 (0.0100293%) now.
2012-07-24 02:25:26 -04:00
6824a7194e
[Indic] Recategorize Khmer various signs as top matras
...
Khmer failures down from 39 to 31 (0.0103636%).
2012-07-24 02:22:18 -04:00
d90b8e841e
[Indic] Reposition Khmer prebase-reordering Ra around split matras
...
In Khmer coeng model, a V,Ra can go *after* matras. If it goes after a
split matra, it should be reordered to *before* the left part of such matra.
Khmer failures down from 136 to 39 (0.0130381%).
2012-07-24 02:11:18 -04:00
0afb84c125
[Indic] Fix minor bug in pre-base Ra positioning
2012-07-24 01:44:47 -04:00
7573799126
[Indic] Position Khmer U+17CE
...
Fixes another 6 Khmer failures. Now at 136 (0.0454661%).
2012-07-24 01:32:07 -04:00
8d00e8d0e7
[Indic] Don't reposition Khmer Bindu
...
Khmer Bindu doesn't like to move to syllable end. Leave it where it
was.
Brings down Khmer failures from 510 to 142 (0.047572%).
2012-07-24 01:15:34 -04:00
2278eefcdb
[Indic] In Sinhala, form forced Reph even if no other consonant found
...
Fixes another 10 Sinhala failures. Down to 148 (0.0544424%).
2012-07-24 00:31:10 -04:00
71fd5e80ad
[Indic] Further adjust base algorithm for Sinhala
...
Apparently if there is C,V,ZWJ,C, the first C will be base, but if
it's C,ZWJ,V,C, the second one will be.
Note that Uniscribe implements this differently, by breaking syllable in
the case of C,ZWJ,V,C and putting the first consonant in one syllable
and the rest in the next syllable.
Sinhala failures down from 208 to 158 (0.0581209%). No changes to
Khmer.
2012-07-24 00:21:16 -04:00
73d71cc527
[Indic] End Vowel-based syllable at ZWJ
...
One Devanagari test regressed, plus 10 Malayalam (at 1545 now).
Fixed 120 Sinhala failures. Now at 208 (0.0765136%).
2012-07-24 00:09:12 -04:00
34c215036f
[Indic] Improve Sinhala base algorithm and reph positioning
...
Sinhala does not have half forms. And most (all?) consonants can be
base, except when preceded by ZWJ, which would request a subjoined form.
Hence switch the base algorithm to categorize with Khmer, start search
at start, and stop at a ZWJ.
Also, mark all pos=base consonants after base to be subjoined. Mark
base itself to have pos=base.
Finally, adjust Sinhala's reph position to after-main.
Brings down Sinhala failures from 455 to 328 (0.120656%).
2012-07-23 23:51:29 -04:00
2ec934c6c2
[Indic] Change "unknown" position to end of syllable
2012-07-23 23:49:04 -04:00
b70021f7c8
When removing zero-width marks, don't remove ligatures
...
If a mark ligated, it probably should NOT be removed.
2012-07-23 20:18:17 -04:00
49c5ec5144
Minor refactoring
2012-07-23 20:14:13 -04:00
c3e6fdc379
[Indic] Improve check on ligatures
...
Only skip actual ligatures, not marks in-between ligature components.
2012-07-23 20:11:42 -04:00
771a8f5028
[Indic] exclude ligatures when matching on Indic category
...
If, say, a H,ZWJ,C ligature was formed, we don't want the code to detec
that as a Halant. So, ignore ligatures when matching category in
final_reordering.
Sinhala failures down from 514 to 455 (0.167374%).
2012-07-23 20:09:30 -04:00
d1af9e82e5
[GSUB/GPOS] Const correctness
2012-07-23 19:55:35 -04:00
baacd090df
[Indic] Minor refactoring
2012-07-23 19:51:48 -04:00
c7c4de2fb9
[Indic] Remove syllable length check before sorting
...
We now limit syllable lengths in the machine. No need to match here.
2012-07-23 18:25:02 -04:00
9fa052733e
[Indic] Limit syllables to at most five consonants
...
Seems to be about what Uniscribe does. Not exactly. But close enough.
More consonants will start a new cluster.
A few scripts went way down in failures. In particular:
- Devanagari failures went down from 490 to 56.
- Telugu went down from 113 to 49.
Other scripts went down slightly or didn't change. New numbers:
BENGALI: 353908 out of 354285 tests passed. 377 failed (0.106412%)
DEVANAGARI: 693572 out of 693628 tests passed. 56 failed (0.00807349%)
GUJARATI: 366485 out of 366506 tests passed. 21 failed (0.00572978%)
GURMUKHI: 60750 out of 60809 tests passed. 59 failed (0.0970251%)
KANNADA: 950730 out of 951913 tests passed. 1183 failed (0.124276%)
KHMER: 298613 out of 299124 tests passed. 511 failed (0.170832%)
MALAYALAM: 1046881 out of 1048416 tests passed. 1535 failed (0.146411%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271333 out of 271847 tests passed. 514 failed (0.189077%)
TAMIL: 1091837 out of 1091837 tests passed. 0 failed (0%)
TELUGU: 970524 out of 970573 tests passed. 49 failed (0.00504856%)
Some of the remaining Telugu and Devanagari issues seem to be Uniscribe
eating Anusvara when placed before a non-joiner. Ouch!
2012-07-23 18:19:17 -04:00
093cd58326
[Thai] Fix SARA AM handling
...
Oops, thinko.
2012-07-23 14:04:42 -04:00
42848453bf
[Thai] Reorder U+0E3A THAI VOWEL SIGN PHINTHU
...
Uniscribe reorders U+0E3A to be after U+0E38 and U+0E39. We do that by
modifying the ccc for U+0E3A.
Fixes the two remaining Thai failures (see previous commit).
2012-07-23 13:52:07 -04:00
4a7f4f3e56
[Thai] Adjust SARA AM reordering to match Uniscribe
...
Adjust the list of marks before SARA AM that get the reordering
treatment. Also adjust cluster formation to match Uniscribe.
With Wikipedia test data, now I see:
- For Thai, with the Angsana New font from Win7, I see 54 failures out
of over 4M tests (0.00129107%). Of the 54, two are legitimate
reordering issues (fix coming soon), and the other 52 are simply
Uniscribe using a zero-width space char instead of an unknown
character for missing glyphs. No idea why. The missing-glyph
sequences include one that is a Thai character followed by an Arabic
Sokun. Someone confused it with Nikhahit I assume!
- For Lao, with the Dokchampa font from Win7, 33 tests fail out of
54k (0.0615167%). All seem to be insignificant mark positioning
with two marks on a base. Have to investigate.
2012-07-23 13:15:33 -04:00
2cc933aff9
[Indic] Fix cluster formation with left-matras and conjunct forms
...
Test case was: <U+0D15,U+0D4D,U+0D15,U+0D4A>.
2012-07-23 08:23:44 -04:00
e6b01a878c
[Indic] Further streamline cluster formation
...
This should address all possible cluster misformations that I had in
mind.
2012-07-23 00:11:26 -04:00
7b2a7dadd6
[Indic] Merge clusters before sorting
...
This should fix any instabilities in cluster formation that we were
speculating may happen with surrounding syllables. Or most of it
perhaps.
2012-07-22 23:58:55 -04:00
abb3239ef9
[Indic] Update clusters for left-matra even if matra didn't move
...
Fixes crashes reported with left matra under
non-uniscribe-bug-compatibilty mode.
2012-07-22 23:55:19 -04:00
92a1ad7bef
[Indic] Stop searching for base if a post form is found before below form
...
Improves Bengali and Gurmukhi. Malayalam regressed a bit. We will deal
with that later.
2012-07-20 18:55:15 -04:00
4c450c703f
[Indic] Recompose Bengali Ya,Nukta
...
This is a bunch of hacks for now.
Improves Bengali a bit.
2012-07-20 18:13:04 -04:00
e9c0f152a3
[Uniscribe] Fix script fallback
...
Gurmukhi failures half now. Others changed slightly.
2012-07-20 17:37:48 -04:00
5791f32915
[Indic] Allow a ZWNJ after SM's
...
Malayalam failures go way down. Other scripts benefitted slightly too.
Sinhala had one or two test regressions, but...
2012-07-20 16:26:55 -04:00
34ae336f3f
[Indic] Improve Reph AfterMain positioning
...
Fixes 20 out of 48 failing Oriya tests. Failure rate down to 0.066% now.
2012-07-20 16:17:28 -04:00
bdd080431a
[Indic] Reposition Oriya Candrabindu
...
Oriya failures down from 0.65% to 0.20%.
2012-07-20 16:03:09 -04:00
5f0eaaad12
[Indic] Fix base search in final_reordering
...
Fixes most Malayalam failures. Down from 1.6% to 0.38% now. Fixes a
few more in other scripts too.
2012-07-20 15:47:24 -04:00
81202bd860
[Indic] Don't attach SM/VD to other characters
2012-07-20 15:14:51 -04:00
efb4ad7356
Fix compiler warnings
...
If x is not constant, we cannot ASSERT_STATIC on it.
2012-07-20 14:27:38 -04:00
f31d97e44e
[Indic] Form Telugu Reph out of Ra,Virama,ZWJ
...
Apparently this was approved in Feb 2012. No font yet.
2012-07-20 14:13:35 -04:00
2e193b240e
[Indic] Don't split U+0AC9
...
Althought IndicMatraCategory.txt classifies it as Top_And_Right matra,
it does not have Unicode decomposition, and Uniscribe does not do
anything special about it either.
Gujarati failures down from 0.672% to 0.0130966%.
2012-07-20 14:02:35 -04:00
30c3d5e9fc
[Indic] Simplify Uniscribe cluster emulation
...
Now that we break syllables on Halant,ZWNJ, this code can be simplified.
2012-07-20 13:56:32 -04:00
decf6ffca4
[Indic] Minor!
2012-07-20 13:51:31 -04:00
9e4f94a72c
[Indic] Break syllables at Halant,ZWNJ
...
That's really what Uniscribe does, and explains a lot of pecularities of
Halant,ZWNJ before the base.
Sent Telugu from 1% failures to 0.03%. Improved Kannada and Malayalam
slightly. Fixed half of Bengali, and did NOT break anything!
2012-07-20 13:48:03 -04:00
2c372b80f6
[Indic] Better check for applying 'init'
...
Specifically, don't apply 'init' if previous char is a joiner.
Fixes some more of Bengali.
2012-07-20 13:37:48 -04:00
34a7440b7c
[GPOS] Don't zero mark advances
...
Fixes more of Telugu, Kannada, and Oriya.
May break things (outside Indic...), but we cannot think of any font relying
on this immediately.
2012-07-20 12:40:39 -04:00
8ed248de77
[Indic] Minor
2012-07-20 11:42:24 -04:00
d0e68dbd0b
[Indic] Implement reph positioning step 5
...
Not tuned, just copied from step 2. Fixes another 0.5% of Kannada
failures. 1% to go.
2012-07-20 11:25:41 -04:00
a9e45c32e4
[Indic] Don't let ZWNJ at the end of syllable affect base search
...
Fixes a few Devanagari, half of remaining Kannada failures, quarter for
Telugu, and others slightly improved or unchanged.
2012-07-20 11:04:15 -04:00
20b68e699f
[Indic] Apply 'cjct' globally
...
Fixes 5 Devanagari failures, and no regressions.
2012-07-20 10:47:46 -04:00
51e764de44
[Indic] Unbreak old scriptures
...
Brings down failures with Lohit-Telugu from 57% to 1.40%.
2012-07-20 10:30:24 -04:00
900cf3d449
Minor
2012-07-20 10:18:23 -04:00
87cd63266e
[Indic] Recategorize some Kannada right matras
...
Kannada failures down from 3.5% to 2.93%.
2012-07-19 21:25:46 -04:00
3604d64ced
[Indic] Recategorize GURMUKHI ADDAK
...
It's not in IndicSyllabicCategory.txt. Fixes most of Gurmukhi failures.
Failures down from 7.7% to 0.222%!
2012-07-19 21:13:04 -04:00
8932858123
Minor
2012-07-19 21:02:38 -04:00
47ef931f13
[buffer] Make sure out_info = info during GPOS
2012-07-19 20:52:44 -04:00
ae63cf2062
Print line number during return when tracing
2012-07-19 20:45:41 -04:00
5249f3aee1
[Indic] Unbreak Khmer
...
For Khmer, all consonants are subjoining. No need to look in the font.
We were looking in the wrong order anyway.
2012-07-19 20:30:22 -04:00
e0475345d5
[Indic] Apply 'akhn' globally
...
Fixes 1.5% more failures for Telugu, 2% for Kannada.
Breaks one test in Devanagari.
2012-07-19 20:24:14 -04:00
fa247ebe52
[Indic] Better position U+0CD5
...
Fixes another 5% of Kannada failures.
2012-07-19 19:52:19 -04:00
f055442716
[Indic] Lookup consonant position in the font
...
Fixes most failures of Oriya, and improves others a bit.
2012-07-19 16:20:21 -04:00
74d1d88781
[GSUB] Fix would_apply() for LigatureSubst
2012-07-19 16:14:23 -04:00
be73a5f936
Add src/test-would-substitute tool
2012-07-19 15:12:18 -04:00
e72b360ac6
Refactor / finish would_apply() operation
...
Untested.
2012-07-19 14:44:46 -04:00
8c973ebf0f
[Indic] Implement per-script matra positioning
...
Following what the spec says.
Brings down Telugu failures from 40% to 3.75%, and Kannada failures from
44% to 10%. Does NOT affect other scripts' test results.
2012-07-19 13:25:08 -04:00
8bb32458f9
[Indic] More refactoring
2012-07-19 13:04:44 -04:00
9ccc6382ba
[Indic] Minor refactoring
2012-07-19 12:45:31 -04:00
f83aaa3133
[Indic] Minor
2012-07-19 12:23:23 -04:00
be8b9f5f71
[Indic] Start refactoring different matra positions per script
2012-07-19 12:11:12 -04:00
b01d9b3d90
[Indic] Disallow decomposition of a couple characters
...
This is a hack for now. Will be fixed when we do complex-shaper-driven
normalization properly.
The results with or without decomposition are the same, but Uniscribe
does not normalize, so this matches better.
2012-07-19 11:25:49 -04:00
422ecd2d3c
[Indic] Accept a forced Rakar sequence at the end of syllable
...
In Sinhala, Rakar is formed by Al-Lakuna,ZWJ,Ra. If you put that at the
end of a Consonant,Matra syllable, you get a dotted-circle from
Uniscribe. Apparently adding a ZWJ before the Al-Lakuna "fixes" that.
And people have been encoding that sequence... So, allow a forced
"ZWJ,Virama,ZWJ,Ra" sequence at the of syllables.
Fixes some 100 or more of Sinhala failures. Now at 622 only (0.23%).
2012-07-18 23:25:58 -04:00
6fc1732003
[Indic] Allow joiners on both sides of Halant at the same time
...
The sequence <ZWJ,Al-Lakuna,ZWJ> is used in Sinhala to explicitly ask
for Rakar. Fixes two-thousand Sinhala tests. Not many left.
2012-07-18 17:49:19 -04:00
10cdc94eee
[Indic] In final reordering, find base, even if it disappeared
...
POS_BASE can disappear if base ligated backward. Define base as last
with position not after base.
Fixes a few hundred of Sinhala failures with Iskoola Pota.
2012-07-18 17:43:23 -04:00
9c4d24a3a6
[Indic] Minor
2012-07-18 17:29:10 -04:00
3285e107c9
[Indic] Implement Sinhala "Al Lakuna" Reph behavior
...
In Sinhala, Reph is formed only explicitly, by the presence of a ZWJ.
2012-07-18 17:22:14 -04:00
91cade7555
[Indic/Unicode] Decompose Sinhala split matras the way Uniscribe likes
...
Makes no visual difference.
Fixes most of the failures. Down from 15% to 1.3%!
2012-07-18 16:50:41 -04:00
d8942dcbb4
Apply Tibetan (global) features.
...
Fixes all Tibetan failures. All 180k of them!
Merges back Hangul into the default shaper.
2012-07-18 16:34:10 -04:00
552d19b7a1
[Indic] Treat Register Shifters like Nukta
...
Really this time.
Fixes another 18 Khmer tests.
2012-07-18 16:02:33 -04:00
e8cd81f76d
[Indic] Minor
2012-07-18 16:00:20 -04:00
69f26bf39c
[Indic] Fix Matra reordering when base is at end of syllable
...
For example: U+915,U+200c,U+93f
Fixes last Tamil failure!
2012-07-18 15:47:51 -04:00
d16ccc4ae7
Leave one extra item at the end of buffer allocation
...
Just in case, for the times we do out-of-bounds access.
jk
2012-07-18 15:43:55 -04:00
075d671f10
[Indic] Fix out-of-bounds array access
2012-07-18 15:41:53 -04:00
dcb527242b
[Indic] Allow joiners before matras
...
Fixes 1 more Devanagari test!
2012-07-18 15:32:26 -04:00
391cc03317
[Indic] Allow halant group in Vowel and placeholder syllables
...
Fixes 2 out of 560 Devanagari failures. AND:
Fixes 1 out of 2 Tamil failures.
2012-07-18 15:12:49 -04:00
ca4e3d3eab
[Indic] Streamline halant/joiner in grammar
2012-07-18 15:05:40 -04:00
418d00dffd
[Indic] Minor
2012-07-18 14:57:28 -04:00
4c3691d2a3
[Indic] Hopefully minor!
...
Refactoring Indic machin. No semantic change.
2012-07-18 14:23:55 -04:00
e092c556fb
[Indic] Minor
2012-07-18 14:09:25 -04:00
14dbdd9e39
[Indic] Unbreak Tamil
...
Tamil has only about 150 failures now!
2012-07-18 13:13:03 -04:00
db8981f1e0
[Indic] Position Khmer Robat
...
It's a visual Repha.
Still not positioning logical Repha as occurs in Malayalam.
Another 200 Khmer failures fixed. 547 to go. That's better than
Devanagari!
2012-07-17 23:42:04 -04:00
25bc489498
[Indic] Better categorize Register Shifters and Khmer Various signs
...
Down another 500 or so Khmer failures!
2012-07-17 17:53:03 -04:00
39b17837b4
Add hb_buffer_normalize_glyphs() and hb-shape --normalize-glyphs
...
This reorders glyphs within the cluster to a nominal order. This should
have no visible effect on the output, but helps with testing, for
getting the same hb-shape output for visually-equal glyphs for each
cluster.
2012-07-17 17:09:29 -04:00
25e302da9a
[Indic] Minor
2012-07-17 14:25:14 -04:00
5d32690a34
[Indic] For scripts without Half forms, always choose first consonant as base
...
In such scripts (ie. Khmer), a ZWJ/ZWNJ shouldn't stop the search for
base. So, instead just choose the first consonant as base directly.
Test sequence:
U+1798,200c,U+17C9,U+17D2,U+179B,U+17C1,U+17C7
2012-07-17 14:23:28 -04:00
34b5714906
[Indic] Treat Khmer Register Shifters more like Nuktas
...
Except that there may be a ZWNJ before a Register Shifter.
2012-07-17 14:09:32 -04:00
11e2a601b1
[Indic] Minor
2012-07-17 14:02:28 -04:00
0201e0a464
[Indic] Apply 'cfar' for Khmer
...
Mark stuff after a pre-base reordering Ro 'cfar'. Used in Khmer.
This allows distinguishing the following cases with MS Khmer fonts:
U+1784,U+17D2,U+179A,U+17D2,U+1782
U+1784,U+17D2,U+1782,U+17D2,U+179A
2012-07-17 13:56:24 -04:00
55f70ebfb9
[Indic] Position final subjoined consonants (and vowels) after matras
...
In Khmer, a final subjoined consonant or independent vowel can occur
after matras. This final subjoined thing should NOT be reordered to
before the matra even though it's subjoined.
Fixes another 1k of the Khmer failures. Not much left really.
2012-07-17 12:50:13 -04:00
c50ed71e9a
[Indic] Recategorize Khmer coeng sign as a separate category OT_Coeng
...
Amend the syllable structure to allow a final subscripted consonant
(Coeng+C) and a final subscripted independent vowel (Coeng+V).
Fixes another 2k of Khmer failures.
2012-07-17 11:54:28 -04:00
deb521dee4
[Indic] Add a separate Coeng class
...
No characters recategorized yet. No semantic change.
2012-07-17 11:37:32 -04:00
74ccc6a132
[Indic] Move Halant with after-base consonants
...
Normally, we attach the Halant to the previous character and move it
with it. For after-base consonants however, the Halant "belongs" to the
consonant after, so attach it so.
This fixes Bengali sequences involving post-base consonant Ya, which
should ligate with the Halant to form Ya Phala, but previously a
reordered matras was blocking the ligation.
2012-07-17 11:16:19 -04:00
d5c4edcdd6
[Indic] Apply presentation-forms features all at once
...
Seems like this is what Uniscribe is doing, and does not break any fonts
we tested (with Devanagari, Malayalam, Khmer, and Bengali), while fixing
some Ra Phala sequences for Bengali with Vrinda. Fixes another 2% of
Bengali failures (a couple more to go).
2012-07-17 10:40:59 -04:00
559f706678
Fix MarkAttachmentType matching
...
Fixes issue reported by Khaled Hosny with his Hussaini Nastaleeq font
and sequences like those added in the previous commit.
2012-07-16 22:46:52 -04:00
ad4494759f
Minor
2012-07-16 22:40:21 -04:00
af92b4cc90
[Indic] Disable 'kern' in Uniscribe bug compatibility mode
...
Uniscribe does not apply 'kern' in the Indic module. Some of the Khmer
fonts they ship have small adjustments in the 'kern' table. Disable
'kern' in the Indic module under Uniscribe bug compatibility mode.
Fixes some 10% of the Khmer failures. Remains under 3% (excluding
dotted-circle ones).
2012-07-16 20:31:24 -04:00
d96838ef95
Allow complex shapers overriding common features
...
In a new callback... Currently unused by all complex shapers.
2012-07-16 20:26:57 -04:00
df50b84740
[Indic] Categorize other Khmer marks
...
Mark them the same as the Register Shifters for now. Need to rename
that category to something more sensible after all is settled.
Fixes another percent of Khmer failures. Down to under 3%!
2012-07-16 20:14:50 -04:00
8e7b5882fb
[Indic] Recognize pre-base reordering Ra anywhere in the syllable
...
We were doing that only immediately after base.
Fixes another percent in the Khmer failures. About three more to go...
2012-07-16 17:04:46 -04:00
7d09c98a1f
[Indic] Recognizer Register Shifter marks
...
Fixes another 6% of the Khmer failures.
2012-07-16 16:45:22 -04:00
60da763dfa
[GSUB/GDEF] Guess glyph classes after substitution only if no GDEF
...
Brings down Khmer failures with Daun Penh font from 36% to 20%.
2012-07-16 16:14:40 -04:00
fcdc5f1c88
[Indic] Categorize Khmer Ro
...
Khmer failures down from 58% to 36%.
2012-07-16 15:52:54 -04:00
78818124b1
[Indic] Reoder pre-base reordering Ra
...
Brings down Malayalam failures from 14% down to 3%.
2012-07-16 15:49:08 -04:00
1a1dbe9a27
[Indic] Rename
2012-07-16 15:41:33 -04:00
46e645ec4b
[Indic] Start implementing pre-base reordering
2012-07-16 15:30:05 -04:00
921ce5b17d
[Indic] Rename
...
No semantic change.
2012-07-16 15:26:56 -04:00
b504e060f0
[Indic] Implement After-Main Reph positioning
...
Almost...
2012-07-16 15:21:12 -04:00
17d7de91d7
[Indic] Apply 'pref' to pre-base reodering Ra
...
No reordering yet.
2012-07-16 15:20:15 -04:00
362d3db8d3
[Indic] Minor
...
Should not be any semantic change. In preparation for implementing
pre-base reordering Ra.
2012-07-16 15:15:28 -04:00
70fe77bb9a
Minor
2012-07-16 14:52:18 -04:00
2f903215c5
Minor
2012-07-16 13:54:43 -04:00
a3e04bee2c
[Indic] Reorder virama only for old Indic spec
2012-07-16 13:47:19 -04:00
0de771b72d
[Indic] Categorize Khmer consonants
2012-07-16 13:39:36 -04:00
d487fff266
Split matras without a Unicode decomposition
...
This is a hack for now, to get us going with Khmer. This will be
refactored properly later to move the complex logic into complex
shapers.
2012-07-16 13:25:57 -04:00
8aa801a6fd
[Indic] Adjust position for split matras
...
We are going to split matras without a Unicode decompositions in a way
that the second half takes the codepoint of the whole matra. So,
position them where the second half is supposed to end up.
2012-07-16 13:24:26 -04:00
1feb8345a5
[GSUB] Allow 1-to-1 ligature substitutions!
...
Apparently Uniscribe allows these, and they are used in some Khmer fonts
shipped with Windows, namely, Daun Penh.
2012-07-16 13:23:40 -04:00
29f106d7fb
[Indic] Apply Above Forms
2012-07-16 12:05:35 -04:00
fa2bd9fb63
Further simplify atomic ops on Visual Studio
2012-07-14 12:15:54 -04:00
0a49235701
Minor
2012-07-13 13:20:49 -04:00
11c4ad439e
Add -Wcast-align
2012-07-13 11:29:31 -04:00
a98d0ab186
Make sure HB_BEGIN_DECLS / HB_END_DECLS is only used in public headers
...
So we can use them to switch default visibility to internal if desired,
and use these to make only declared symbols public.
2012-07-13 10:19:10 -04:00
5c5bc96216
Allow overriding HB_BEGIN_DECLS / HB_END_DECLS
2012-07-13 10:15:37 -04:00
50a4e78b53
Check for exported weak symbols
...
Ouch, all our C++ inline functions are being exported (weakly) already.
Fix coming.
2012-07-13 09:48:39 -04:00
b5aeb95afe
Make hb_in_range() static
2012-07-13 09:45:54 -04:00
271c8f8907
Minor
2012-07-13 09:32:30 -04:00
391f1ff5d8
Fix _InterlockedCompareExchangePointer on x86
2012-07-13 09:04:07 -04:00
2023e2b54d
[ft] Disable ppem setting
...
The calculations were wrong.
FreeType makes it really hard to set size and ppem independently.
For now, disable it. Need to come up with a fix later.
2012-07-11 19:01:26 -04:00
cdf7444505
[ft] Use unfitted kerning if x_ppem is zero
2012-07-11 18:52:39 -04:00
6d08c7f1b3
Revert "Towards templatizing common Lookup types"
...
This reverts commit 727135f3a9
2012-07-11 18:01:27 -04:00
552bf3a9f9
Bump WINNT version requested from 500 to 600
...
Since we use the OpenType versions of Uniscribe functions, we are
relying on that version of the WINNT API. Otherwise, usp10.h will hide
those symbols.
2012-07-11 18:00:28 -04:00
9a5b421a64
Fix build with no Unicode funcs implementations provided
2012-07-11 18:00:28 -04:00
727135f3a9
Towards templatizing common Lookup types
2012-07-11 18:00:28 -04:00
12f5c0a222
Fix check for Intel atomic ops
2012-06-26 11:16:13 -04:00
6932a41fb6
Use octal-escaped UTF-8 characters instead of plain text
...
https://bugs.freedesktop.org/show_bug.cgi?id=50970
2012-06-26 10:46:31 -04:00
8c0ea7bcb4
Disable introspection again
...
Until I figure out the build issues. Sigh...
2012-06-24 13:20:56 -04:00
49f8e0cd9a
GStaticMutex is deprecated
2012-06-16 15:40:03 -04:00
1bc1cb3603
Make source more digestable for gobject-introspection
2012-06-16 15:21:55 -04:00
84d781e54c
Flesh out gobject-introspection stuff a bit
2012-06-16 15:21:41 -04:00
2cf301968c
Add hb_object_lock/unlock()
2012-06-09 14:58:01 -04:00
f211d5c291
More Oops! Fix fast-path with sub-type==0
2012-06-09 03:11:22 -04:00
b1de6aa1f3
Oops!
2012-06-09 03:07:59 -04:00
b12e2549cb
Minor
2012-06-09 03:05:20 -04:00
faf0f20253
Add sanitize() logic for fast-paths
2012-06-09 03:02:36 -04:00
4e766ff28d
Add fast-path for GPOS too
...
Shaves another 3% for DejaVu Sans long Latin strings.
2012-06-09 02:53:57 -04:00
993c51915f
Add fast-path to GSUB to check coverage
...
Shaves a good 10% off DejaVu Sans with simple Latin text for me.
Now, DejaVu is very ChainContext-intensive, but it's also a very
popular font!
2012-06-09 02:48:16 -04:00
f19e0b0099
Match input before backtrack
...
Makes more sense, optimization-wise.
2012-06-09 02:26:57 -04:00
67bb9e8cea
Add set add_coverage() to Coverage()
2012-06-09 02:02:46 -04:00
4952f0aa5b
Minor
2012-06-09 01:43:20 -04:00
ad6a6f2240
Minor
2012-06-09 01:43:20 -04:00
46617a4213
Fix cache implementation
2012-06-09 01:43:20 -04:00
ce47613889
Micro-optimize
...
I know...
2012-06-09 01:43:15 -04:00
70416de298
Minor
2012-06-09 00:56:41 -04:00
99159e52a3
Use linear search for small counts
...
I see about 8% speedup with long strings with DejaVu Sans.
2012-06-09 00:50:40 -04:00
caf0412690
Minor
2012-06-09 00:26:32 -04:00
0f8fea71a6
Minor. Hide _hb_ot_layout_get_glyph_property()
2012-06-09 00:24:38 -04:00
44b8ee0c90
Minor
2012-06-09 00:23:24 -04:00
7b84c536c1
In MarkBase attachment, only attach to first of a MultipleSubst sequence
...
This is apparently what Uniscribe does. Test case is:
SEEN FATHA TEH ALEF
with Arabic Typesetting. Originally reported by Khaled Hosny.
2012-06-08 22:04:23 -04:00
ec57e0c565
Set lig_comp for MultipleSubst components
...
To be used for correct mark attachment to first component of a
MultipleSubst output. That's what Uniscribe does.
2012-06-08 21:47:23 -04:00
e085fcf7ca
Remove unused buffer->replace_glyphs_be16
2012-06-08 21:45:00 -04:00
3ec77d6ae0
Don't use replace_glyphs_be for MultipleSubst
2012-06-08 21:44:06 -04:00
4b7192125f
Minor
2012-06-08 21:41:46 -04:00
4508789f4b
Add test for static initializers and other C++ stuff
2012-06-08 21:32:43 -04:00
56bd259b9a
Minor
2012-06-08 21:29:18 -04:00
bc8357ea7b
Merge clusters during normalization
2012-06-08 21:01:20 -04:00
fe3dabc08d
Minor
2012-06-08 20:56:05 -04:00
e88e14421a
Use merge_clusters instead of open-coding
2012-06-08 20:55:21 -04:00
330a2af3ff
Use merge_clusters when forming Unicode clusters
2012-06-08 20:40:02 -04:00
bd300df9ad
Minor
2012-06-08 20:36:37 -04:00
e51d2b6ed1
Extend into main buffer if extension hit end of out-buffer merging clusters
2012-06-08 20:36:33 -04:00
5ced012d9f
Extend end when merging clusters in out-buffer
2012-06-08 20:31:32 -04:00
72c0a18783
Extend clusters backward in out-buffer
2012-06-08 20:30:03 -04:00
cd5891493d
Extend clusters backwards, into the out-buffer too
2012-06-08 20:28:59 -04:00
77471e0371
Clear output buffer before calling GSUB pause functions
2012-06-08 20:21:02 -04:00
cafa6f3727
When merging clusters, extend the end
2012-06-08 20:17:10 -04:00
28ce5fa454
Merge clusters when ligating
2012-06-08 20:17:06 -04:00
2bb1761ccb
Minor, use next_glyph()
2012-06-08 19:29:44 -04:00
5f68f8675e
Minor
2012-06-08 19:23:43 -04:00
8729691267
Increase Uniscribe MAX_ITEMS
2012-06-08 14:39:31 -04:00
dbffa4c83d
Fix Uniscribe charset matching
...
Previously was failing to match fonts that didn't support CHARSET_ANSI.
There still remains a problem with the Uniscribe backend, in that if a
font with the same family name is installed, and is newer, the native
one is preferred over the font we provide. Fixing it requires rewriting
the name table with a unique family name...
2012-06-08 14:39:31 -04:00
82e8bd8628
Remove unused code
2012-06-08 14:39:31 -04:00
6da9dbff21
Remove zero-width chars in the fallback shaper too
2012-06-08 10:53:35 -04:00
68b76121f8
Fix regressions introduced by sed. Ouch!
...
Introduced in 99c2695759
2012-06-08 10:47:00 -04:00
0dd86f9f68
Whitespace
2012-06-08 10:23:03 -04:00
8e7beba7c3
Fix Uniscribe clusters with direction-overriden Arabic
2012-06-08 10:22:06 -04:00
b069c3c31b
Really fix override-direction in Uniscribe
2012-06-08 10:10:29 -04:00
fcd6f53261
Unbreak Uniscribe
...
Oops. hb_tag_t and OPENTYPE_TAG have different endianness. Perhaps
something to add API for in hb-uniscribe.h
2012-06-08 09:59:43 -04:00
29eac8f591
Override direction in Uniscribe backend
...
Matches OT backend now.
2012-06-08 09:26:17 -04:00
1c1233e576
Make Uniscribe backend respect selected script
2012-06-08 09:20:53 -04:00
0bb0f5d419
Add note re _NullPool
2012-06-07 17:42:48 -04:00
2a3d911fe0
Fix alignment-requirement missmatch
...
Detected by clang and lots of cmdline options.
2012-06-07 17:31:46 -04:00
6095de1635
Fix clang warning with NO_MT path
2012-06-07 15:48:18 -04:00
a18280a8ce
Fix warnings produced by clang analyzer
2012-06-07 15:44:12 -04:00
73cb02de2d
Minor
2012-06-06 11:29:25 -04:00
79e2b4791f
Fix ASSERT_POD on clang
...
As reported by bashi. Not tested.
2012-06-06 11:27:17 -04:00
6220e5fc0d
Add ASSERT_POD for most objects
2012-06-06 03:30:09 -04:00
a00a63b5ef
Add macros to check that types are POD
2012-06-06 03:07:01 -04:00
61eb60c129
Don't link to libstdc++
...
New try.
2012-06-05 21:22:36 -04:00
81a4b9fd4e
Remove unused hb_static_mutex_t
2012-06-05 20:53:00 -04:00
4a3a9897b3
Disable Intel atomic ops on mingw32
...
Apparently the configure test is not enough...
2012-06-05 20:39:07 -04:00
0594a24484
Cleanup TRUE/FALSE vs true/false
2012-06-05 20:35:40 -04:00
e1ac38f8dd
Fix inert buffer set_length() with zero
...
Oops!
2012-06-05 20:31:49 -04:00
04bc1eebe7
Add configure tests for Intel atomic intrinsics
2012-06-05 20:16:56 -04:00
f64b2ebf82
Remove last static initializer
...
We're free! Lazy or immediate...
2012-06-05 20:15:27 -04:00
04aed572f1
Make hb-ft static-initializer free
2012-06-05 18:45:36 -04:00
be4560a3b5
Undo default unicode-funcs to avoid static initializer again
2012-06-05 18:43:57 -04:00
093171ccec
Implement lock-free hb_language_t
...
Another static-initialization down. One more to go.
2012-06-05 18:00:45 -04:00
6843ce01be
Add atomic-pointer functions
...
Gonig to use these for lock-free linked-lists, to be used for
hb_language_t among other things.
2012-06-05 17:27:20 -04:00
cdafe3a7d8
Add gcc intrinsics implementations for atomic and mutex
2012-06-05 16:40:23 -04:00
d970d2899b
Add gcc implementation for atomic ops
2012-06-05 16:06:28 -04:00
0e253e97af
Add a mutex to object header
...
Removes one more static-initialization. A few more to go.
2012-06-05 15:54:43 -04:00
a2b471df82
Remove static initializers from indic
2012-06-05 15:17:44 -04:00
f06ab8a426
Better hide nil objects and make them const
2012-06-05 14:49:14 -04:00
bf93b636c4
Remove constructor from hb_prealloced_array_t
...
This was causing all object types to be non-POD and have static
initializers. We don't need that!
Now, most nil objects just moved from .bss to .data. Fixing for that
coming soon.
2012-06-05 14:17:32 -04:00
f1971a2174
Fix warnings
2012-06-05 14:06:04 -04:00
9fc7a11469
Remove comma at the end of enum
...
As reported by Jonathan Kew on the list.
2012-06-04 08:28:19 -04:00
3b8fd9c48f
Remove const from ref_count.ref_count
...
According to Tom Hacohen this was breaking build with some compilers.
In file included from hb-buffer-private.hh:35:0,
from hb-ot-map-private.hh:32,
from hb-ot-shape-private.hh:32,
from hb-ot-shape.cc:29:
hb-object-private.hh: In constructor '_hb_object_header_t::_hb_object_header_t()':
hb-object-private.hh:97:8: error: uninitialized const member in 'struct hb_reference_count_t'
hb-object-private.hh:51:25: note: 'hb_reference_count_t::ref_count' should be initialized
In file included from hb-ot-shape.cc:33:0:
hb-set-private.hh: In constructor '_hb_set_t::_hb_set_t()':
hb-set-private.hh:37:8: note: synthesized method '_hb_object_header_t::_hb_object_header_t()' first required here
hb-ot-shape.cc: In function 'void hb_ot_shape_glyphs_closure(hb_font_t*, hb_buffer_t*, const hb_feature_t*, unsigned int, hb_set_t*)':
hb-ot-shape.cc:521:12: note: synthesized method '_hb_set_t::_hb_set_t()' first required here
2012-06-03 15:54:19 -04:00
70600dbf62
Minor
2012-06-03 15:52:51 -04:00
96a9ef0c9f
Remove tab character like other "zero-width" characters
...
Uniscribe does that, this make comparing results to Uniscribe
easier.
2012-06-01 13:46:26 -04:00
0558d55bac
Remove hb_atomic_int_set/get()
...
We never use them in fact...
I'm just adjusting these as I better understand the requirements of
the code and the guarantees of each operation.
2012-05-28 10:46:47 -04:00
bce095524b
Add hb_font_get_glyph_name() and hb_font_get_glyph_from_name()
2012-05-28 10:45:50 -04:00
bc145658bd
Warn if no Unicode functions implementation is found
2012-05-28 10:45:50 -04:00
a3547330fa
Cleanup atomic ops on OS X
2012-05-27 10:20:47 -04:00
e4b6d503c5
Don't use atomic ops in hb_cache_t
...
We don't care about linearizability, so unprotected int read/write
are enough, no need for expensive memory barriers. It's a cache,
that's all.
2012-05-27 10:11:13 -04:00
819faa0530
Minor
2012-05-27 10:09:18 -04:00
303d5850ec
Fix Windows atomic get/set
...
According to:
http://msdn.microsoft.com/en-us/library/65tt87y8.aspx
MemoryBarrier() is the right macro to protect these, not _ReadBarrier()
and/or _WriteBarrier().
2012-05-27 10:01:13 -04:00
29ce446d31
Add set iterator
2012-05-25 14:17:54 -04:00
62c3e111fc
Add set symmetric difference
2012-05-25 13:48:00 -04:00
27aba594c9
Minor
2012-05-24 15:00:01 -04:00
cde1c0114b
Fix hb_atomic_int_set() implementation for HB_NO_MT
...
As pointed out by Jonathan Kew.
2012-05-24 10:46:39 -04:00
ed2f1363a3
Fix substitution glyph class propagation
...
The old code was doing nothing.
Still got to find an example font+string that makes this matter, but
need this for fixing synthetic GDEF anyway.
2012-05-22 22:12:22 -04:00
20fdb0f41d
Add a lock-free cache type for int->int functions
...
To be used for cmap and advance caching if desired.
2012-05-17 22:04:45 -04:00
bd908b4f10
Implement hb_atomic_int_set() for OS X
2012-05-17 22:02:08 -04:00
022a05ae90
Minor
2012-05-17 21:53:24 -04:00
22afd66a30
Add hb_atomic_int_set() again
2012-05-17 21:23:49 -04:00
4aa7258cb1
Fix type conflicts on Windows without glib
2012-05-17 21:01:04 -04:00
f039e79d54
Don't use min/max as function names
...
They can be macros on some systems. Eg. mingw32.
2012-05-17 20:55:12 -04:00
34961e3198
Prefer native atomic/mutex ops to glib's
2012-05-17 20:50:38 -04:00
ec3ba4b96f
Move atomic ops into their own header
2012-05-17 20:30:46 -04:00
1d6846db9e
[Indic] Apply vatu feature after cjct
...
Testing with old Deva spec this reduces failures.
Test sequence: U+0915,U+094D,U+0930.
2012-05-13 18:09:29 +02:00
617f4ac46f
Refactor
2012-05-13 16:48:03 +02:00
5e4e21fce4
Revert "[Indic] Refactoring"
...
This reverts commit 0831061efb
2012-05-13 16:46:08 +02:00
3f18236a03
Fix more warnings
2012-05-13 16:20:10 +02:00
9f377ed321
Fix more unused-var warnings
2012-05-13 16:13:44 +02:00
d993e72331
Fix hb_face_set_index()
2012-05-13 16:04:36 +02:00
93345edcbe
Fix warnings
2012-05-13 16:01:08 +02:00
eace47b173
Minor
2012-05-13 15:54:43 +02:00
99c2695759
Add accessort to buffer for current info, current pos, and prev info
2012-05-13 15:45:18 +02:00
6736f3c5b0
Minor
2012-05-13 15:21:06 +02:00
5df809b655
[GSUB/GPOS] Remove context_length
...
The spec doesn't say contextual matching should be done this way,
and AOTS doesn't do it either. It was inherited from old HarfBuzz.
Remove it.
2012-05-13 15:17:51 +02:00
28b9d502bb
Minor
2012-05-13 15:04:00 +02:00
737dded2e0
Fix compiler warnings
2012-05-12 15:40:11 +02:00
7f852b644b
Fix compiler warnings
2012-05-11 23:10:31 +02:00
f7e8dcfd4f
[Indic] Unbreak Devanagari
...
And this, concludes the HarfBuzz Massala Hackfest.
I like to specially thank Jonathan Kew for doing all the decription and
letting me get commit points.
2012-05-11 22:01:33 +02:00
6a091df9b4
[Indic] Disambiguate sub vs post vs above matras
...
Bengali is at *just* above 5% now.
2012-05-11 21:42:27 +02:00
9d0d319a4a
[Indic] Position Bengali Reph before matras
2012-05-11 21:36:32 +02:00
f893672511
[Indic] Start categorizing Reph per script
2012-05-11 21:10:03 +02:00
a913b024d8
[Indic] Apply 'init' feature for Bengali
...
Error down from 20% to 7%.
2012-05-11 20:59:26 +02:00
eed903b164
[Indic] Refactor for the arrival of 'init' feature
...
Yep, on Bengali now!
2012-05-11 20:50:53 +02:00
18c06e189b
[Indic] Add Uniscribe bug feature for dotted circle
...
For dotted-circle independent clusters, Uniscribe does no Reph shaping
for the exact sequence Ra+Halant+25CC. Which also is the only possible
sequence with 25CC at the end.
2012-05-11 20:02:14 +02:00
0831061efb
[Indic] Refactoring
2012-05-11 19:07:58 +02:00
7ea58db311
Minor
2012-05-11 18:58:57 +02:00
9c09928989
[Indic] Allow multiple Consonants in Vowel/NBSP syllables
...
Uniscribe allows multiple Halant+Consonant after a Vowel.
Tests:
↦ * U+0905,U+094D,U+092B,U+094D,930,94d,930
2012-05-11 18:46:35 +02:00
8c0aa486f3
[Indic] Allow two Nuktas per consonant
...
Uniscribe allows up to two nuktas per consonant and one per matra. It does so
indepent of whether the consonant already has a nukta in it. Tests:
* U+0916,U+093C,U+0941
* U+0959,U+093C,U+0941
* U+0916,U+093C,U+093C,U+0941
* U+0959,U+093C,U+093C,U+0941
* U+0916,U+093C,U+093C,U+093C,U+0941
* U+0959,U+093C,U+093C,U+093C,U+0941
* 915,93c,93c,,94d,U+0916,U+093C,U+093C,U+093e,93c,93c
2012-05-11 18:13:42 +02:00
3399a06e70
[Indic] Fix U+0952 and similar classification to match Uniscribe
...
See comments.
2012-05-11 17:54:26 +02:00
11aa3ef18d
[Indic] Treat U+0951..U+0954 all similar to U+0952
2012-05-11 17:30:48 +02:00
5f131d3226
[GSUB/GPOS/Indic] Apply GSUB/GPOS within syllables only
...
This does not apply to the context matchings.
This regresses tests right now. And we are not sure whether this is
the right thing to do for GPOS. But we'll figure out.
2012-05-11 17:29:40 +02:00
8fd83aaf6e
[GSUB/GPOS] Fix wrong buffer access in backward skippy mask matching
2012-05-11 17:18:37 +02:00
ff24d1081a
[Indic] Don't use syllable serial value 0
2012-05-11 17:07:08 +02:00
892eb78782
[Indic] Implement Uniscribe Reph+Matra+Halant bug feature
2012-05-11 16:54:40 +02:00
67ea29af49
[Indic] Add example of different Uniscribe behavior
2012-05-11 16:51:23 +02:00
ebe29733d4
[Indic] Add runtime Uniscribe bug compatibility mode!
...
Enable by setting envvar:
HB_OT_INDIC_OPTIONS=uniscribe-bug-compatible
Plus, LeftMatra+Halant "feature".
2012-05-11 16:43:12 +02:00
616e692e29
[Indic] Add #define UNISCRIBE_BUG_COMPATIBLE 1
2012-05-11 16:25:02 +02:00
6782bdae3b
[Indic] Fix Left Matra + Halant reordering
...
As can be seen in: U+092B,U+093F,U+094D
2012-05-11 16:23:43 +02:00
3c2ea9481b
Minor
2012-05-11 16:23:38 +02:00
203d71069c
[GSUB/GPOS] Check all glyph masks when matching input
2012-05-11 16:01:44 +02:00
668c6046c1
[Indic] Apply Reph mask to all POS_REPH glyphs
...
Needed for upcoming changes to GSUB/GPOS mask matching.
2012-05-11 15:34:13 +02:00
4be46bade2
[Indic] Fix state machine to backtrack
2012-05-11 14:39:01 +02:00
cee7187447
[Indic] Move syllable tracking from Indic to generic layer
...
This is to incorporate it into GSUB/GPOS processing.
2012-05-11 11:41:39 +02:00
3bf27a9f0e
[Indic] Disable conjuncts when a ZWJ happens
...
Not that the code makes any difference since the presence of ZWJ itself
causes the ligature to fail to match anyway.
2012-05-11 11:17:23 +02:00
c6d904d67d
[Indic] Fix bitops typo!
...
Another 1000 down!
2012-05-11 11:07:40 +02:00
55fe2cf79b
Make APPLY debug output print current index and codepoint
...
Yay!
2012-05-11 03:56:33 +02:00
7bd2b04fea
Minor
2012-05-11 03:40:58 +02:00
cf26510dbb
Some more...
...
Done. I promise.
2012-05-11 03:35:08 +02:00
9659523ca3
More beauty in debug output!
2012-05-11 03:33:36 +02:00
cf26e88a5a
Finish off debug output beautification
2012-05-11 03:16:57 +02:00
d7bba01a35
Only print class name in debug output if there's one available
2012-05-11 02:46:26 +02:00
85f73fa8da
Only printout class name in tracing, if one is available
...
Makes debug output much more pleasant.
2012-05-11 02:40:42 +02:00
98619ce4fa
Minor
2012-05-11 02:34:06 +02:00
acea183e98
Add return annotation for APPLY
2012-05-11 02:33:11 +02:00
5ccfe8e215
/Minor/
2012-05-11 02:19:41 +02:00
0ab8c86217
Annotate SANITIZE return values
...
More to come, for APPLY, CLOSURE, etc.
2012-05-11 02:11:52 +02:00
829e814ff3
Minor
2012-05-11 00:52:16 +02:00
6eec6f406d
Code reshuffling
2012-05-11 00:50:38 +02:00
1e08830b4f
Beautify debug output
2012-05-11 00:43:57 +02:00
6f45538017
More massaging trace messaging
2012-05-10 23:24:43 +02:00
b5fa37cb69
Minor
2012-05-10 23:09:48 +02:00
208109703c
Better trace message support infrastructure
...
We have varargs in the trace interface now. To be used soon...
2012-05-10 23:06:58 +02:00
02b2922fbf
[Indic] Towards better Reph positioning
...
Fixed for Deva cases with two full-form consonants. Failures **way** down.
Not much left to go :-).
2012-05-10 21:44:50 +02:00
74e54cf446
[Indic] Add Ra back for scripts without Reph
...
We now check that the 'rphp' table exists before forming Reph, so
we don't need to comment out Ra for those scripts.
2012-05-10 21:22:58 +02:00
2b70df5cc0
[Indic] Add note re Uniscribe clusters
2012-05-10 18:38:22 +02:00
21d2803133
[Indic] Do clustering like Uniscribe does
...
Hindi Wikipedia failures down to 6639 (0.938381%)!
2012-05-10 18:34:34 +02:00
8df5636968
[Indic] Reorder Reph to before the Halant after Matras
...
Uniscribe doesn't do it, but we want to do as it gives the Reph the
opportunity to interact with the Matras. Test with mangal for example.
Sequence: <0930,094d,0915,094b,094d>
In test suite already.
2012-05-10 15:41:04 +02:00
daf3234bdc
[Indic] Don't clear the mask for Reph
...
This was removing the mandatory global 1 bit in the mask and hence
disabling GPOS for Reph!
2012-05-10 15:28:27 +02:00
7708ee23cb
[Indic] Improve Left Matra repositioning
...
Move its dependents too.
2012-05-10 14:48:25 +02:00
dbb105883c
[Indic] Do Reph repositioning in final reordering like the spec says
...
This introduced a failure, which we tracked down to a test case like this:
U+092E,U+094B,U+094D,U+0930
The final character is a Ra that should be put in a syllable of it's
own. And we do. But it will interact with the Halant before it. So
now we finally are convinced that we have to limit features to syllable
boundaries. That's coming after lunch!
2012-05-10 13:45:52 +02:00
4705a70269
Minor
2012-05-10 13:09:08 +02:00
4ac9e98d9d
[Indic] Reorder left matras to be closer to base
2012-05-10 12:53:53 +02:00
1a1fa8c655
[Indic] Treat the standalone cluster case reusing the consonant logic
2012-05-10 12:21:30 +02:00
190eb31a16
[Indic] Minor
2012-05-10 12:21:30 +02:00
c5306b6861
[Indic] Handle Vowel syllables
...
Reusing the consonant logic!
2012-05-10 12:21:30 +02:00
6d8e0cb74c
[Indic] Simplify Reph logic
2012-05-10 11:41:51 +02:00
3d25079f8d
[Indic] Don't form Reph is Ra is the only consonant in the syllable
2012-05-10 11:37:42 +02:00
b99d63ae11
[Indic] Increase max syllable length
...
20 was way too low, one could hit a syllable with 7ish consonants with it.
2012-05-10 11:32:52 +02:00
a391ff50b9
[Indic] Adjust base after sorting
2012-05-10 11:31:20 +02:00
d3637edb24
[Indic] Don't return for long syllables. Just not sort.
2012-05-10 10:51:38 +02:00
dfa0cade7f
Fix Uniscribe clusters with multiple items
2012-05-09 19:10:07 +02:00
86e5dd386a
[Indic] Don't give up syllable parsing upon junk
2012-05-09 18:57:37 +02:00
ef24cc8c8e
[Indic] Towards multi-cluster syllables and final reordering
2012-05-09 18:10:20 +02:00
a9844d41c6
Combine lig_id and lig_comp into one byte, to free up one for Indic
2012-05-09 17:53:13 +02:00
92332e5116
Minor
2012-05-09 17:40:00 +02:00
dbccf87eef
[Indic] Make room for more reordering positions
2012-05-09 17:24:39 +02:00
d4480ace7f
[Indic] Improve matra vs consonant ordering
...
Another 1.5% down.
2012-05-09 15:59:47 +02:00
33c92e7695
[Indic] Categorize Anudatta
2012-05-09 15:41:51 +02:00
19d984edaa
[Indic] Make sure Reph jumps over all matras to the right
...
Another 12 thousand failures gone! (78 to go)
2012-05-09 15:21:13 +02:00
9034641333
[Indic] Keep Vedic signs at the right too
2012-05-09 15:04:58 +02:00
d1deaa2f5b
Replace zerowidth invisible chars with a zero-advance space glyph
...
Like Uniscribe does.
2012-05-09 15:04:13 +02:00
49e5da1591
[indic] Keep the syllable modifier marks to the right
...
Shaping failures on Hindi Wikipedia go down from 25% to 14%!
2012-05-09 13:23:27 +02:00
5b12609093
Minor
2012-05-09 12:37:27 +02:00
9ce939232b
Minor
2012-05-09 12:03:09 +02:00
76b3409de6
[indic] Better Reph matching
2012-05-09 11:52:32 +02:00
df6d45c693
Minor
2012-05-09 11:38:31 +02:00
412b91889d
[indic] Apply Indic features in order
2012-05-09 11:07:18 +02:00
1ac075b227
[indic] Apply rakaar forms
...
Fixes 10% of the failures against all of Hindi Wikipedia!
2012-05-09 11:06:47 +02:00
1a2a4a0078
Fix warning and build issues
...
As reported by Jonathan Kew on the list.
2012-05-05 22:38:20 +02:00
a5e39fed85
Minor
2012-04-25 00:14:46 -04:00
1827dc208c
Add hb_ot_shape_glyphs_closure()
...
Experimental API for now.
2012-04-24 16:56:37 -04:00
bb09f0ec10
Minor
2012-04-24 16:02:12 -04:00
29a7e306e3
Minor
2012-04-24 16:01:30 -04:00
6c6ccaf575
Add a few more set operations
...
TODO: Tests for hb_set_t.
2012-04-24 14:23:01 -04:00
5caece67ab
Make closure() return void
2012-04-23 23:03:12 -04:00
0b08adb353
Add hb_set_t
2012-04-23 22:44:59 -04:00
5b93e8d94f
Update copyright headers
2012-04-23 22:26:27 -04:00
6a9be5bd35
Rename hb_glyph_map_t to hb_set_t
2012-04-23 22:23:17 -04:00
a4385f0b0a
Improve clustering
2012-04-23 22:20:14 -04:00
8e3715f8a1
Minor
2012-04-23 22:18:54 -04:00
d2984a241e
Add map->substitute_closure()
2012-04-23 17:21:14 -04:00
31081f7390
Implement closure() for Context and ChainContext lookups
2012-04-23 16:54:58 -04:00
c64ddab3c3
Flesh out closure() for GSUB
...
The GSUBGPOS part still missing.
2012-04-23 15:28:35 -04:00
0da132bde4
Fix Coverage iters
2012-04-23 14:21:33 -04:00
3e32cd9570
Minor
2012-04-23 13:22:50 -04:00
650ac00da3
Minor refactoring
2012-04-23 13:17:09 -04:00
f94b0aa646
Add "closure" operation stubs to GSUB
...
Filling in.
2012-04-23 13:04:38 -04:00
7d50d50263
Add Coverage iterators
2012-04-23 13:04:05 -04:00
3ed4634ec3
Add Indic inspection tool
2012-04-19 22:35:01 -04:00
a06411ecf9
Minor matra renumbering
...
Should have no visible effect.
2012-04-19 22:28:25 -04:00
36608941f3
Add GSUB "would_apply" API
...
To be used in the Indic shaper later. Unused for now.
2012-04-19 22:21:38 -04:00
a5e40542ab
Make font immutable in hb_shape()
2012-04-17 12:37:19 -04:00
3cde23664f
Minor note re Graphite
2012-04-17 11:44:49 -04:00
4dc2449d92
Fix leak in graphite
2012-04-17 11:39:48 -04:00
9ceca3aeb1
Fix ragel regexp in vowel-based syllable
...
As reported by datao zhang on the mailing list.
2012-04-16 21:05:51 -04:00
b870afcd1b
Rewrite ragel expression to better match the one on MS spec
...
https://www.microsoft.com/typography/otfntdev/devanot/shaping.aspx
2012-04-16 21:05:11 -04:00
a5f1834f57
Apply 'liga' for vertical writing mode too
...
Apparently that's what Kazuraki uses to form vertical ligatures,
which suggests that it's what Adobe does.
2012-04-16 15:55:13 -04:00
e74616b889
Add comment
2012-04-15 14:12:13 -04:00
683b503f30
Minor
2012-04-14 20:47:14 -04:00
b9f199c8e3
Move code around
2012-04-14 20:25:37 -04:00
38a83019e6
Minor
2012-04-14 19:40:18 -04:00
d4adade217
Add assert
2012-04-14 19:23:17 -04:00
fe28b997fb
Add HB_DIRECTION_IS_VALID
2012-04-14 19:19:26 -04:00
5e88aa6682
Remove public enum names again
...
As was reported to me, glib-mkenum does not understand named enums,
so remove for now.
2012-04-14 18:51:50 -04:00
4bf90f6483
Make HB_DIRECTION_INVALID be zero
...
This changes all the HB_DIRECTION_* enum member values, but is
nicer, in preparation for making hb_segment_properties_t public.
2012-04-12 17:38:23 -04:00
6bd9b479b8
Hide backend-specific shape functions
...
Also remove shaper_options argument to hb_shape_full(). That was
unused and for "future". Let it go.
More shaper API coming in preparation for plan/planned API.
2012-04-12 14:53:53 -04:00
c6035cf802
Add names to enums
...
gdb was showing <anonymous enum> instead of useful stuff, so name
all our enums.
2012-04-12 13:23:59 -04:00
d1c9eb458c
Make it an error to include non-top-level headers
...
Users should #include <hb.h> (or hb-ft.h, hb-glib.h, etc), but
never things like hb-shape.h directly. This makes it easier to
refactor headers later on without breaking compatibility.
2012-04-12 13:17:44 -04:00
323190c27b
Minor
2012-04-12 12:29:10 -04:00
0e3361464b
Fix bug with not setting Unicode props of the first character
...
Fixes Mongolian shaping issue:
https://bugs.freedesktop.org/show_bug.cgi?id=45695
2012-04-12 10:06:52 -04:00
c65662b71e
Fix left-matra positioning in Indic
...
Fixes 200 failures out of previous 4290 cases in the OO.o Indic
dictionary (of ~16000 entries).
2012-04-12 09:31:55 -04:00
029a82d81d
[hangul] Apply *jmo features to all Hangul chars
...
This is what old HB does. Morever, fixes rendering with Win8 malgun
font. The Win7 version doesn't compose with either Uniscribe nor HB,
but Win8 version works as expected, like Uniscribe, with this change.
Lets call Hangul done for now.
2012-04-11 22:00:46 -04:00
41ae674f68
Don't create hb_apply_context_t per glyph!
...
I couldn't measure significant performance gains out of this; maybe
about 5% (with one million Malayalam strings). Still, not bad.
But reminds me that optimizing this codebase without profiling first
is simply not going to work. Oh well...
2012-04-11 17:13:50 -04:00
4a1e02ef79
Fix shape to presentation forms font check
...
As reported by Jonathan Kew on the list.
2012-04-11 14:37:53 -04:00
6062f5f014
Fix build with some compilers
...
As reported by Jonathan Kew on the list.
2012-04-11 14:19:55 -04:00
acd88e659f
In Arabic fallback shaping, check that the font has glyph for new char
2012-04-10 18:02:20 -04:00
7752aa73e7
Minor
2012-04-10 17:22:14 -04:00
939c010211
Implement Arabic fallback shaping mandatory ligatures
2012-04-10 17:20:05 -04:00
b7d04eb606
Do Arabic fallback shaping
2012-04-10 16:44:38 -04:00
ae4a2b9365
Generate fallback Arabic shaping table
...
Not hooked up yet.
2012-04-10 16:25:08 -04:00
3b26f96ebe
Add Thai shaper that does SARA AM decomposition / reordering
...
That's not in the OpenType spec, but it's what MS and Adobe do.
2012-04-10 10:52:07 -04:00
d4cc44716c
Move code around, in prep for Thai/Lao shaper
2012-04-07 21:52:28 -04:00
c9a841f445
Add simple Hangul shaper that recomposes Jamo when feasible
...
Previously, we were NOT actually recomposing Hangul Jamo. We do now.
The two lines in:
test/shaping/texts/in-tree/shaper-default/script-hangul/misc/misc.txt
Now render the same with the UnDotum.ttf font. Previously the second
linle was rendering boxes.
We can also start applying OpenType Jamo features later. At this time,
I have no idea how the 'ljmo', 'vjmo', 'tjmo' features are supposed to
work. Maybe someone can explain them to me?
2012-04-07 15:06:55 -04:00
9683184553
Implement normalization mode HB_OT_SHAPE_NORMALIZATION_MODE_COMPOSED_FULL
...
In this mode we try composing CCC=0 with CCC=0 characters. Useful for
Hangul.
2012-04-07 15:06:47 -04:00
bec2ac4fde
Bring normalization algorithm closer to the spec
...
No logical difference so far.
2012-04-07 14:51:17 -04:00
e02d925786
Flip logic around
2012-04-07 14:49:13 -04:00
11138ccff7
Add normalize mode
...
In preparation for Hangul shaper.
2012-04-05 17:25:19 -04:00
6769f21d57
More moving code around
2012-04-05 16:46:46 -04:00
2db2a56682
Move code around
2012-04-05 16:40:37 -04:00
cad3821f3d
More sorting by Unicode version
...
This is the most convenient way to browse scripts.
2012-03-07 17:13:25 -05:00
317b9504d7
Minor
2012-03-07 16:51:29 -05:00
fa2673c1ee
More Unicode script age annotation, and a couple more RTL scripts
...
Cross-checked with Mark Davis's spreadsheet at http://goo.gl/x9ilM
2012-03-07 15:52:02 -05:00
6d4016f1ba
Make src tests pass again
2012-03-07 15:33:14 -05:00
7da435f08c
Separate Unicode 3.1 and Unicode 3.2 additions
2012-03-07 15:20:20 -05:00
f91136cb52
Route three Unicode 6.1 scripts through Indic shaper
2012-03-07 12:56:22 -05:00
f32c0012ad
Add Unicode 6.1.0 scripts
2012-03-07 12:53:34 -05:00
50e810cd0e
Lydian and Kharoshthi are right-to-left
2012-03-07 12:49:08 -05:00
a52835635e
Whitespace
2012-03-07 12:38:39 -05:00
183224684a
Use generic shaper for Buhid
...
As requested by Jonathan Kew.
We need to devise a better mechanism to choose which scripts to
pass through the Indic shaper. Moreover, currently we are storing
data for some scripts in the Indic shaper that are not even going
through that shaper. Need to find a better way...
2012-03-07 12:21:28 -05:00
cdc8b491a8
Update Indic table to Unicode 6.1 data
2012-03-07 12:08:33 -05:00
e3b2e077f5
Typo
2012-03-07 10:21:24 -05:00
c346671b6b
Minor doc fixes
2012-03-06 20:47:50 -05:00
461b9b6347
Fix cluster formation in Indic
...
Makes number of failures against Uniscribe with hi_IN dictionary from
OO.o to go down from 6334 to 4290. Not bad for a one-line change!
Mozilla Bug 729626 - ASAN: heap-buffer-overflow HTML
2012-03-01 18:11:19 -08:00
bc71ad4973
Fix atomic-int op on Apple
...
The OSAtomicAdd32Barrier operator returns the new value, we want the
old value.
2012-03-01 17:30:29 -08:00
a1970d9afc
Add support for atomic int and mutex on Apple systems
...
So, apparently there's no atomic int 'get' method on Apple. You have to
add(0) to get. And that's not const-friendly. So switch inert-object
checking to a non-atomic get. This, however, is safe, and a negligible
performance boost too.
2012-02-24 16:19:52 -05:00
8004429102
Remove unused hb_atomic_int_set()
...
Apparently it can't be implemented on OS X. We weren't using it anyway.
2012-02-24 16:19:52 -05:00
45227c10e4
Add hb-warning.cc. Oops!
2012-02-23 19:47:43 -05:00
bd7ff1dec5
Allow disabling multi-threaded support
...
By defining HB_NO_MT.
Also, only warn once per missing MT feature support.
Mozilla Bug 666661 - gfx/harfbuzz/src/hb-prive.h - compiler warnings on mac
2012-02-23 15:06:16 -05:00
634c9e3423
Minor
2012-02-22 16:43:21 -05:00
514b6f8866
Followup: Reorder Hebrew combining classes for better rendering
...
Patch from Jonathan Kew.
Bug 662055 - advanced Hebrew diacritics are shown correctly only in
particular order.
2012-02-22 16:34:37 -05:00
6e78607ea7
Reorder Hebrew combining classes for better rendering
...
Patch from Jonathan Kew.
Bug 662055 - advanced Hebrew diacritics are shown correctly only in particular order
2012-02-22 16:31:15 -05:00
134aa7bc7e
Make checks more OS X friendly
2012-01-27 02:23:22 -05:00
6152199368
Fix check-header-guards on OS X
2012-01-27 02:23:22 -05:00
71632c96da
Fallback to Latin script if the font has no other usable scripts
...
Patch and description from Jonathan Kew:
It turns out that some legacy Thai fonts provide OpenType substitution
features to implement mark positioning, but (incorrectly) put those
features/lookups under the 'latn' script tag instead of using 'thai' (or
possibly 'DFLT'). See
https://bugzilla.mozilla.org/show_bug.cgi?id=719366 for an example and
more detailed description.
Although this is really a font bug, I suggest that we could improve the
rendering of such fonts by looking for the 'latn' as a fallback if
neither the requested script nor "default" is found in
hb_ot_layout_table_choose_script. Suggested patch against harfbuzz
master is attached.
This does _not_ affect the other kind of legacy Thai font, where custom
code to support vendor-specific PUA codepoints would be needed. I'm not
keen to go down that path; IMO, such fonts should be ruthlessly stamped
out in favour of standards-based solutions. :)
JK
2012-01-22 15:31:44 -05:00
7a4a848db2
Minor
2012-01-19 15:15:21 -05:00
3b5c22c39b
Remove src/test.cc
...
Not really useful.
2012-01-19 14:28:11 -05:00
889caa52fa
[icu] Use U_FAILURE
2012-01-18 22:32:52 -05:00
36a4f4a482
Replace u_strlen() with u_countChar32()
...
The latter is what I meant.
2012-01-18 22:16:49 -05:00
c521e793bd
Fix OOB in replace_glyph()
...
Patch from Kenichi Ishibashi.
2012-01-18 21:51:05 -05:00
03408ce73d
Fix more possible buffer overruns
...
I have this function, but can't clean up it to my satisfaction.
2012-01-18 21:28:34 -05:00
7d479900cd
Refactor the two remaining uses of _hb_ot_layout_skip_mark()
2012-01-18 21:19:32 -05:00
506ffeb8e7
Further mark skippy fixes from Jonathan Kew
...
We should be in good shape now.
2012-01-18 16:07:53 -05:00
a4a48fe6d4
Fix mark skipping regression
...
Ouch!
2012-01-17 18:08:41 -05:00
4ab9731154
Refactor mark skipping
2012-01-16 22:20:31 -05:00
370f03e9c6
Minor
2012-01-16 17:06:59 -05:00
4d3aeb8cb2
[GSUB/GPOS] Fix mark skip indexing issues
...
Mozilla bug 701637 and 714067 combined.
Patch from Jonathan Kew.
2012-01-16 16:43:26 -05:00
e8eedf2687
Avoid enum trailing commas
...
Based on patch from Jonathan Kew.
2012-01-16 16:39:40 -05:00
299ae0c3a3
[icu] Remove glib-ism
2012-01-14 21:29:45 -05:00
af92135424
Minor
2011-10-21 09:18:43 -07:00
89d89646e8
Fix intrin.h b0rkage with older MSVC
...
Reported by Jonathan Kew.
2011-10-17 11:50:54 -07:00
af913c5788
Fix infinite loop in normalization code with variation selectors
...
Reported by Jonathan Kew.
2011-10-17 11:39:28 -07:00
55deff7595
Add comments
2011-09-28 16:20:09 -04:00
52ebdff49d
Fix GSUB lookuptype 1 subtype 1 delta wrapping
2011-09-27 12:38:16 -04:00
b95324cdd2
Minor
2011-09-21 16:50:39 -04:00
0cd33592ab
Fix possible leaks
2011-09-21 16:49:33 -04:00
d606daa4cc
Whitespace
2011-09-20 14:34:06 -04:00
f83f0f4836
[graphite] Add note about graphite shaker brokenness
2011-09-19 18:51:48 -04:00
0a965eee88
Minor
2011-09-19 16:53:47 -04:00
5c29934311
[uniscribe] Various improvements
2011-09-19 14:53:26 -04:00
5ddd9cc499
Minor
2011-09-16 16:40:44 -04:00
947c9a778c
Minor
2011-09-16 16:33:18 -04:00
d5476a30a1
Minor
2011-09-16 12:30:50 -04:00
36b10f58cc
Minor
2011-09-15 16:29:51 -04:00
c4611cb66f
Fix test
2011-09-15 00:32:39 -04:00
bc187e5ac7
Refine Indic scripts, following Martin Hosken's recommendation
2011-09-08 13:35:17 -04:00
738d096a06
Pass through unknown ISO 639-3 language tags to OpenType engine
...
In hb_ot_tag_from_language(), if first component of an unknown
language is three letters long, use it directly as OpenType language
tag (after case conversion and padding).
2011-09-02 13:31:19 -04:00
ea02cbf03c
[graphite] Don't preload glyphs
...
Doesn't seem to be slower.
2011-09-02 12:39:20 -04:00
210a06f3d7
Minor
2011-08-26 13:39:49 +02:00
4a8d2e379a
[graphite2] Chop a few more lines
2011-08-26 09:40:54 +02:00
81ec289da7
Minor
2011-08-26 09:33:06 +02:00
3380de5abb
[graphite] Use buffer->replace_glyphs()
2011-08-26 09:30:49 +02:00
9ebe8c0286
Add buffer->replace_glyphs()
2011-08-26 09:29:42 +02:00
a5edb1031c
Minor
2011-08-26 09:27:13 +02:00
290e3ee517
[graphite] Only pass the first part language tag to graphite
...
Still not sure about:
1) Case. We pass lowercase for now. Would be nice if graphite was
uppercase 3letter like OpenType,
2) Padding. IMO, tag padding is always with spaces, but Martin was
talking about NUL bytes.
2011-08-26 09:25:04 +02:00
4c9fe88d30
[API] Make all _from_string() functions take a len parameter
...
Can be -1 for NUL-terminated string. This is useful for passing parts
of a larger string to a function without having to copy or modify the
string first.
Affected functions:
hb_tag_t hb_tag_from_string()
hb_direction_from_string()
hb_language_from_string()
hb_script_from_string()
2011-08-26 09:22:12 +02:00
a499bdea5c
[graphite2] Bail if grface is NULL
2011-08-25 22:46:21 +02:00
3007ffa9e5
Reorder combining-class to better suit Arabic shadda mark-mark positioning
...
As reported by Khaled on the list:
"After the introduction of canonical reordering of combining marks
(commit 34c22f8http://unicode.org/faq/normalization.html#8
http://unicode.org/faq/normalization.html#9
2011-08-25 09:08:53 +02:00
74ef81a0b0
Fix make distcheck
2011-08-24 19:36:50 +02:00
24bcdbcc06
Add hb-ot-hmtx-table.hh
...
Oops!
2011-08-24 19:13:15 +02:00
a3bd8a0e18
[graphite] Rewrite properly
2011-08-24 03:25:57 +02:00
5072934c35
Minor
2011-08-24 02:24:27 +02:00
71388b3ee7
[uniscribe] Minor
2011-08-24 02:09:04 +02:00
cd2b901027
[graphite] Minor
2011-08-24 01:48:03 +02:00
834af3b48a
[graphite] Remove hb_graphite2_feature_check()
...
I don't see how this function can be useful.
2011-08-24 01:45:47 +02:00
1f49cf32c9
Add graphite2 integration from Martin Hosken
...
To be modified, a lot.
2011-08-24 01:32:41 +02:00
0e6d36d8a3
Minor
2011-08-24 01:31:29 +02:00
efde811325
Add a constructor for hb_prealloced_array_t
...
Fixes build with MSVC.
2011-08-23 00:04:57 +02:00
d75333f166
Add gobject enum support, but disabled for now
...
need to figure out the naming. The generated code doesn't have the
right name.
2011-08-19 19:59:24 +02:00
7d235d272f
Flesh out tt funcs a bit
2011-08-19 19:23:28 +02:00
b9415e76d7
[API] Add hb_font_set_funcs_data()
2011-08-19 19:20:30 +02:00
e6c09cdf43
Remove the pre_allocate argument from hb_buffer_create()
...
For two reasons:
1. User can always call hb_buffer_pre_allocate() themselves, and
2. Now we do a pre_alloc in add_utfX anyway, so the total number of
reallocs is limited to a small number (~3) anyway. This just makes the
API cleaner.
2011-08-19 19:20:26 +02:00
187bdeaa6c
Do (nothing for) hmtx sanitize
2011-08-17 19:03:06 +02:00
d6016e4910
Fix name-table sanitize
2011-08-17 15:00:18 +02:00
ae9877dea6
Add hhea-table support
2011-08-17 15:00:10 +02:00
7a750ac33e
Rename table files from eg maxp-private.hh to maxp-table.hh
2011-08-17 14:19:59 +02:00
0b7e4d9f20
[ft] FT_Get_Advance() for advance-width callbacks
...
Using graphite2's comparerenderer suggests that this makes hb-ft 15
times faster. No caching layer needed anymore.
2011-08-15 20:41:59 +02:00
4e9ff1dd6e
Pre-allocate buffers when adding string
...
We do a conservative estimate of the number of characters, but still,
this limits the number of buffer reallocs to a small constant.
2011-08-15 16:21:22 +02:00
553bc3de82
Minor
2011-08-15 16:21:06 +02:00
254142bb67
[ft] FT_Select_Charmap() when we create face
2011-08-15 16:15:44 +02:00
a4cbd03dd1
Apply 'locl' with 'ccmp' in Arabic shaper
...
According to Peter Constable this is indeed what Uniscribe has been
doing for years.
Mozilla Bug 667166 - wrong shape of letter when it comes at the end of
word in the arabic version of Firefox 5.0
2011-08-15 09:52:05 +02:00
c214cff55c
Start adding gobject-introspection support
2011-08-14 15:17:51 +02:00
9527fb200f
Fix missing return
2011-08-13 19:03:48 +02:00
77a3287695
Minor
2011-08-13 17:16:45 +02:00
d6660356dd
Add uniscribe font getters
2011-08-10 22:08:36 +02:00
01ec13a1d9
Implement hb_ft_font_get_face
2011-08-10 22:00:35 +02:00
0501573ded
Fix const correctness in the API
2011-08-10 16:25:56 +02:00
511a136f0c
Move hb-view into util/
2011-08-09 15:03:00 +02:00
d753ac78da
[uniscribe] Remove zerowidth glyphs from output
2011-08-09 14:03:12 +02:00
ddd247b0c5
Minor
2011-08-09 11:44:42 +02:00
1b8196c986
Add fallback shaper
2011-08-09 11:37:46 +02:00
13a601fe99
[FT] Don't make font immutable
2011-08-09 11:36:54 +02:00
38b2118724
[API] Add hb_ft_font_set_funcs(), remove hb_ft_get_font_funcs()
...
Remove hb_ft_get_font_funcs() as it cannot be used by the user anyway.
Add hb_ft_font_set_funcs(). Which will make the font internally use
FreeType. That is, no need for the font to have created using the
hb-ft API. Just create using hb_face_create()/hb_font_create() and
then call this on the font (after having set font scale). This
internally creates an FT_Face and attached to the font.
2011-08-09 11:10:32 +02:00
255f176fdc
Minor
2011-08-09 08:35:07 +02:00
a9057eb3f3
[uniscribe] Unbreak
2011-08-09 00:47:55 +02:00
33ccc77902
[API] Make set_user_data() functions take a replace parameter
...
We need this to set data on objects safely without worrying that some
other thread unsets it by setting it at the same time.
2011-08-09 00:43:24 +02:00
944b2ba1ce
[buffer] Make API take signed int length
...
Since we already switched to accepting -1 as 'zero-terminated'.
2011-08-09 00:23:58 +02:00
de1e1cf9bc
[FT] Adapt to new face API
2011-08-09 00:19:38 +02:00
bf3eef540f
[uniscribe] Cleanup backend
2011-08-09 00:14:22 +02:00
3897335c76
[API] Sort out get_blob API
...
hb_face_get_blob() renamed to hb_face_reference_blob(), returns a
reference now.
hb_face_[sg]et_index() added.
hb_face_set_upem() added.
2011-08-08 23:37:41 +02:00
e715784be3
Rename get_table to reference_table in all API
2011-08-08 21:43:06 +02:00
670c873499
Fix shaper ordering logic
2011-08-08 21:36:24 +02:00
cc797e0d53
Minor
2011-08-08 03:50:38 +02:00
826e22732d
[uniscribe] Fix blob lifecycles
2011-08-07 03:53:42 -04:00
ff199ba356
Fix shaper_list manipulation, aaaaaaaaaaaaargh
2011-08-07 03:43:46 -04:00
577326b86a
[uniscribe] Fix cluster calculation
2011-08-07 01:04:40 -04:00
f6d83b2dcf
Minor
2011-08-07 00:59:58 -04:00
2eb474afb4
[uniscribe] Fix shaper
...
It's kinda working finally!
2011-08-07 00:59:38 -04:00
f22e661147
[glib] Protect against invalid characters
2011-08-07 00:59:12 -04:00
144cd49a0e
[buffer] Accept -1 for text_length and item_length
...
A -1 text_length means: zero-terminated string.
A -1 item_length means: to the end of string.
2011-08-07 00:51:50 -04:00
e9c71fab30
Fix name-table lookup
...
Oops!
2011-08-07 00:01:04 -04:00
3fd2b5bece
[uniscribe] Use font size directly
2011-08-06 22:59:54 -04:00
892eb2e462
[uniscribe] Make font selection work
...
Not tested yet.
2011-08-06 22:32:07 -04:00
b492299eb3
Start implementing the 'name' table
2011-08-05 20:34:50 -04:00
4538efacca
Skip tests by returning 77
...
automake test runner understands this.
2011-08-05 20:11:06 -04:00
54eb65538d
Fix check on OS X sh
2011-08-05 20:09:25 -04:00
9da554504e
Add hb_shape_list_shapers()
2011-08-05 19:59:02 -04:00
d7bf473ef2
Minor
2011-08-05 19:59:02 -04:00
c62a8f10f3
Free all static memory upon exit
2011-08-05 19:59:02 -04:00
c4d63ef744
Fix env parsing code
...
Also changed the separator to comma instead of colon.
2011-08-05 19:59:02 -04:00
3931837beb
Change hb_shape() API back to what it was, add hb_shape_full()
...
I disliked changing hb_shape() API, and disliked the fact that it was
returning a bool now. So, reverted. Added new API for the extra
functionality.
2011-08-05 19:59:02 -04:00
3ca6c4ecc2
Change hb_shape() API back to what it was, add hb_shape_full()
...
I disliked changing hb_shape() API, and disliked the fact that it was
returning a bool now. So, reverted. Added new API for the extra
functionality.
2011-08-05 17:22:19 -04:00
02aeca985b
[API] Changes to main shape API
...
hb_shape() now accepts a shaper_options and a shaper_list argument.
Both can be set to NULL to emulate previous API. And in most situations
they are expected to be set to NULL.
hb_shape() also returns a boolean for now. If shaper_list is NULL, the
return value can be ignored.
shaper_options is ignored for now, but otherwise it should be a
NULL-terminated list of strings.
shaper_list is a NULL-terminated list of strings. Currently recognized
strings are "ot" for native OpenType Layout implementation, "uniscribe"
for the Uniscribe backend, and "fallback" for the non-complex backend
(that will be implemented shortly). The fallback backend never fails.
The env var HB_SHAPER_LIST is also parsed and honored. It's a
colon-separated list of shaper names. The fallback shaper is invoked if
none of the env-listed shapers succeed.
New API hb_buffer_guess_properties() added.
2011-08-04 22:38:09 -04:00
57692adf12
Make test.cc do something more useful
...
Hardcoded to the uniscribe backend for now. Will fix soon.
2011-08-04 20:49:16 -04:00
c605bbbb6d
Remove C++ guards from source files
...
Where causing issues for people with MSVC.
2011-08-04 20:00:53 -04:00
8336186a52
Zero map objects
2011-08-04 19:49:05 -04:00
c747f509bc
More out-of-tree build fixes
2011-08-04 01:51:30 -04:00
20dde61016
Minor
2011-08-04 01:07:33 -04:00
44b4f50d05
Fix typo
2011-08-04 00:52:20 -04:00
0fbb2dc831
Add draft experimental Uniscribe backend
...
Not complete yet, font selection doesn't work. But hey it shapes!
This is not supposed to be a production backend, more like a testing
backend.
2011-08-03 19:55:04 -04:00
e62df43649
Add internal hb_buffer_t::get_scratch_buffer()
2011-08-03 17:38:54 -04:00
bf8c57ba74
[API] Add hb_face_get_blob()
...
Need to think more about it.
2011-08-03 17:38:04 -04:00
2118fdb9f5
Fix fallback shaping
...
Broke it a few commits ago.
2011-08-02 14:06:51 -04:00
f60271c0c2
Add mingw32 support
...
With these changes, on Ubuntu I can do:
./configure --host=i586-mingw32msvc && make
2011-08-02 10:00:55 -04:00
f5414cf0a2
Use missing script for calling ragel
2011-08-01 16:34:16 -04:00
a91c58bf98
[Indic] Disable CJCT-disabling logic
...
Read comment.
2011-08-01 16:30:11 -04:00
5e72071062
[Indic] Stop looking for base upon seeing joiners
...
Not sure where this is documented, but I remember this being the desired
behavior.
test-shape-complex failures are down from 48 to 46. Meh.
2011-07-31 17:52:44 -04:00
281683995a
Cosmetic
2011-07-31 16:00:35 -04:00
6b37bc8084
[Indic] Fix ZWJ/ZWNJ application
...
Not quite working just yet. False alarm re 10 failures. It was
crashing. Ouch! Back to 48 failures.
2011-07-31 15:57:00 -04:00
e7be057024
[Indic] Add Final Reordering rules into comments
...
Not applied yet.
2011-07-31 15:22:46 -04:00
cfd4382ec1
[Indic] Handle Reph when determining base consonant
2011-07-31 15:08:40 -04:00
97158392a5
[Indic] Ra is a consonant too
2011-07-31 15:01:28 -04:00
0d8f8a177c
[Indic] Fix reph inhibition logic
2011-07-31 14:57:59 -04:00
9da0487cd4
[Indic] Support ZWJ/ZWNJ
...
Brings test-shape-complex failures down from 52 to 10!
I hereby declare harfbuzz-ng supporting Indic!
2011-07-31 13:46:44 -04:00
9ee27a928a
[Indic] Suppress reph formation upon joiners
2011-07-31 11:10:14 -04:00
8354e004e5
Un-Ra U+09F1. According to the test suite this is correct.
...
But I'm not sure... Down from 54 failures to 52.
2011-07-31 02:24:51 -04:00
ba7e85c104
Cosmetic
2011-07-30 21:11:53 -04:00
f5bc2725cb
[Indic] For old-style Indic tables, move Halant around
...
In old-style Indic OT standards, the post-base Halants are moved after
their base. Emulate that by moving first post-base Halant to
post-last-consonant.
Brings test-shape-complex failures down from 88 to 54. Getting there!
2011-07-30 21:08:10 -04:00
c47a31fb47
[OT] Save chosen script tag
2011-07-30 20:57:01 -04:00
fd06bf5611
[Indic] Handle initial Ra+Halant in scripts that support Reph
...
Brings test-shape-complex failures down from 104 to 92. Way to go!
2011-07-30 20:14:44 -04:00
ee58f3bc75
Minor
2011-07-30 19:15:53 -04:00
352372ae5e
[Indic] Categorize Ra in scripts that have Reph
...
Is the categorization correct? I don't know.
2011-07-30 19:04:02 -04:00
45d6f29f15
[Indic] Reorder matras
...
Number of failing shape-complex tests goes from 125 down to 94.
Next: Add Ra handling and it's fair to say we kinda support Indic :).
2011-07-30 14:44:30 -04:00
911bf32aca
Bug 39686 - Add '-no-undefined' to libharfbuzz LDFLAGS
2011-07-30 11:16:00 -04:00
8f0b64fb69
Minor
2011-07-29 17:02:48 -04:00
743807a3ce
[Indic] Apply Indic features
...
Find the base consonant and apply basic Indic features accordingly.
Nothing complete, but does something for now. Specifically:
no Ra handling right now, and no ZWJ/ZWNJ.
Number of failing shape-complex tests goes from 174 down to 125.
Next: reorder matras.
2011-07-29 16:46:09 -04:00
9f9bcceca6
Register buffer vars in Indic shaper
2011-07-28 17:07:50 -04:00
be09bf6b79
Oops. This should have gone into the previous commit
2011-07-28 17:03:43 -04:00
b65c06025d
Formalize buffer var allocations
2011-07-28 16:49:29 -04:00
a9ad3d3460
Move more code around
...
Buffer var allocation coming into shape
2011-07-28 15:42:18 -04:00
cc06c243d8
Streamline debugging infrastructure even more
2011-07-25 20:34:17 -04:00
43ff203d8e
Use variadic macros for debugging
...
Looks *so* much nicer!
2011-07-25 17:35:24 -04:00
decd4e3e16
Add sugar syntax for debug messages
...
Buffer debugging coming soon.
2011-07-25 16:47:02 -04:00
3a81b1db89
Minor, fix leak from my previous refactorings
2011-07-25 16:30:32 -04:00
f4a579bc42
Add internal API for buffer var allocation
2011-07-25 16:26:05 -04:00
651e8dd79e
Start cleaning up buffer var allocation
...
I've messed up a lot of stuff recently, different parts of the
shaping process are stumbling on eachother's toes because
manually tracking what's in which buffer var is hard. I'm
going to add some internal API to track those such that mistakes
are discovered as soon as they are introduced.
2011-07-25 14:54:08 -04:00
c86f932015
Move code around
2011-07-25 00:44:50 -04:00
18c42850c9
Shrink space used for ligature ids
...
This frees 16bits in the glyph_info struct during the ot_layout process.
We can use the freed space in the shapers now.
2011-07-25 00:43:39 -04:00
d8787493c9
Minor
2011-07-25 00:36:01 -04:00
c311d85208
Keep Unicode props updated as we go so we avoid a scan later
2011-07-23 23:43:54 -04:00
5389ff4dbc
Implement the Unicode Canonical Composition algorithm
...
Fallback normalization is complete and working now!
2011-07-22 20:22:49 -04:00
dcdc51cdc0
Handle singleton decompositions
2011-07-22 17:14:46 -04:00
34c22f8168
Implement Unicode Canonical Reordering Algorithm
2011-07-22 17:04:20 -04:00
4ff0d2d9df
Decomposition works now!
2011-07-22 16:15:32 -04:00
468e9cb25c
Move buffer methods into the object
2011-07-22 14:49:14 -04:00
45412523dc
More normalization kick
2011-07-22 11:07:05 -04:00
63c0ef4a07
Fix decompose() implementations to work with non-starter non-composables
...
Add tests.
2011-07-21 20:58:42 -04:00
5d90a342e3
Document normalization design
2011-07-21 15:25:01 -04:00
02cdf743c2
Add prefer_decomposed() complex-shaper callback
...
This allows the Indic shaper to request decomposed characters. This will
handle split matra for free. Other shapers prefer precomposed
characters.
2011-07-21 12:23:12 -04:00
d6b9c6d200
More kicking
2011-07-21 12:16:45 -04:00
192445aef2
Remove intermittent_glyph()
...
Lets not worry about performance for now...
2011-07-21 12:13:04 -04:00
d63adfc7d0
No need to handle variation-selectors seperately, they are GC=Mn
2011-07-21 11:48:57 -04:00
aa7264123a
Only form clusters if we are reversing
...
This produces more accurate cluster mappings. Cluster mappings are
minimal now. Combining marks get their own cluster value most of
the time.
2011-07-21 11:34:59 -04:00
5c6f5982d7
Towards normalization
2011-07-21 11:31:08 -04:00
cf7f43ec33
Remove stale comment
2011-07-21 01:12:26 -04:00
54d1a0d2b2
Form clusters before ensuring native direciton
...
This is essential as ensure_native_direction uses cluster info that
is set by form_clusters().
2011-07-21 01:11:09 -04:00
9111b21ef9
Add _hb_buffer_output_glyph() and _hb_buffer_skip_glyph()
2011-07-21 00:59:15 -04:00
655586fe5e
Towards normalization
2011-07-21 00:52:42 -04:00
49741c8633
Include variation-selectors in cluster calculation
2011-07-21 00:35:37 -04:00
dd89d958c1
Fix cluster calculation for non-LTR text
2011-07-21 00:28:57 -04:00
4a68684654
When forming clusters, participate all mark types
2011-07-21 00:14:01 -04:00
5157e12a55
Rename HB_UNICODE_GENERAL_CATEGORY_COMBINING_MARK to HB_UNICODE_GENERAL_CATEGORY_SPACING_MARK
...
Spacing_Mark is the current Unicode long-name for this property value.
The previous name was wrongly carried from glib.
2011-07-21 00:12:33 -04:00
7b08b0a7f2
Minor
2011-07-20 23:59:07 -04:00
498e1a9be6
[icu] Implement compose()/decompose()
2011-07-20 23:19:49 -04:00
ffd4a436f7
Add tests for compose()/decompose()
...
Adjust glib fallback implementation.
The tests are not hooked up for ICU yet.
2011-07-20 22:31:23 -04:00
fca0923b04
Minor
2011-07-20 22:16:13 -04:00
26b6024962
[glib] Use g_unicode_script_to/from_iso15924() if available
2011-07-20 22:16:01 -04:00
22fdc66712
[glib] Add compose() and decompose() implementations with fallback
2011-07-20 21:51:37 -04:00
a54a5505a3
Minor
2011-07-20 16:42:10 -04:00
22989c5ffc
Distribute hb-ot-shape-complex-indic-machine.rl
2011-07-12 11:54:58 -04:00
f6fd3780e1
Let shapers decide when to apply ccmp and locl
...
Instead of always applying those two features before the complex shaper,
let the complex shaper decide whether they should be applied first.
Also add stub for Indic's final_reordering().
2011-07-08 00:22:40 -04:00
c4641723fb
[API] Add compose() and decompose() unicode funcs, rename other ones
...
Add compose() and decompose() unicode funcs. These implement
pair-wise canonical composition/decomposition.
The glib/icu implementations are lacking for now. We are adding
API for this to glib, but I cannot find any useful API in ICU.
May end of implementing these in-house.
Changed all unicode_funcs callback names to remove the "_get" part.
Eg, hb_unicode_get_script_func_t is now hb_unicode_script_func_t,
and hb_unicode_get_script() is hb_unicode_script() now.
2011-07-08 00:09:31 -04:00
d05dded167
More code generation through preprocessor
2011-07-07 23:43:47 -04:00
891c4755ba
Humm, undo some shuffling
...
In preparation for adding more advanced unicode funcs.
2011-07-07 23:27:27 -04:00
4b6317c4f4
More code shuffling
2011-07-07 23:14:42 -04:00
3361c9a323
Minor
2011-07-07 22:35:17 -04:00
76f76812ac
Shuffle code around, remove shape_plan from complex shapers
2011-07-07 22:25:25 -04:00
e88bff9b4d
Minor, use function typedefs
2011-07-07 22:03:02 -04:00
359dcaa0d3
Update copyright headers
2011-07-07 21:55:05 -04:00
d8d0c480c8
Refactor some code common to GSUB and GPOS
2011-07-07 21:22:08 -04:00
b70c96dbe4
Enable applying GSUB/GPOS features in multiple segments
...
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=644184
among others.
Shapers now can request segmented feature application by calling
add_gsub_pause() or add_gpos_pause(). They can also provide a
callback to be called at the pause. Currently the Arabic shaper
uses pauses to enforce certain feature application. The Indic
shaper can use the same facility to pause and do reordering in the
callback.
2011-07-07 21:12:15 -04:00
f6d7a9bb4c
Shuffle code around
2011-07-07 16:20:35 -04:00
2e18c6dbdf
Fix reverse_range() position loop
...
Mozilla Bug 669175 - Slow rendering of text sometimes in this case,
using direction: rtl
2011-07-06 16:05:45 -04:00
fa2befa46f
Minor
2011-07-04 17:18:57 -04:00
d69d5ceaa0
[Indic] Well, at least finding syllables works now :)
...
Still not much there.
2011-07-04 12:56:38 -04:00
4ec30aec30
[Indic] Optimize Indic table storage
2011-06-28 14:13:38 -04:00
c4a59de6d8
[Indic] Generate a single data table instead of multiple ones
2011-06-28 14:03:29 -04:00
8fdba506f0
[Indic] Define indic_position_t
2011-06-24 20:45:55 -04:00
65988a145b
[Indic] Add a table of consonant positions
...
Copied form HarfBuzz.old Indic data. These are below and post
consonants. This is temporary. Read the comment in the patch.
2011-06-24 19:05:52 -04:00
c7fe56a1d5
[Indic] Some of the basic features are global; Mark them so
2011-06-24 19:05:34 -04:00
867361c3ad
[indic] Add syllable recognition state machine
...
Using an incredible tool called Ragel.
2011-06-17 18:35:46 -04:00
422e08dbb8
Better categorize Indic character classes
...
Matches OT types now.
2011-06-15 17:22:48 -04:00
31f18abecb
Minor compiler warning fixes
2011-06-15 09:49:58 -04:00
e3693b72f0
Change a couple strstr() to strchr()
2011-06-15 09:33:52 -04:00
b9452bfc16
Fix compiler warnings with -pedantic
2011-06-14 14:47:07 -04:00
970e092dc2
Remove extra semicolon
2011-06-14 14:35:44 -04:00
8142680802
Cosmetic
2011-06-13 16:12:56 -04:00
902ab866f2
GNOME Bug 652227 - Unconditional use of stdint.h
2011-06-10 23:08:54 -04:00
20503ccd57
More Indic data shuffling
2011-06-07 17:02:48 -04:00
63b177e45c
Minor
2011-06-07 15:51:40 -04:00
b9ddbd5593
[Indic] Start an Indic shaper
...
Nothing functional in there yet.
So far, we're parsing IndicSyllabicCategory.txt and IndicMatraCategory.txt
fils from Unicode Character Database and store them in an array to be used
by the shaper. Also hooked up the shaper, but it does not do anything
right now.
2011-06-02 17:43:12 -04:00
697a65c5f5
Minor
2011-06-01 23:15:48 -04:00
9de1481f2b
Update to ArabicShaping-6.1.0d2.txt
2011-06-01 20:45:14 -04:00
9d49433efb
Minor rename
2011-06-01 18:10:10 -04:00
89a2bc9ba6
[Vertical] Apply vertical features
...
We apply all of vert, vrt2, vkrn, valt, and vpal.
2011-05-31 15:18:13 -04:00
0c6a9767c8
[hb-view] Add --face-index to choose a face in a TrueType Collection
2011-05-31 12:59:17 -04:00
4f28fbdd80
Fix TTC header handling
...
Also change the Version type to avoid similar bugs in the future.
Reported by Grigori Goronzy.
2011-05-31 12:33:11 -04:00
21deab2bdc
Fixed inifinite loop introduced in 7403e055cd
...
k is the index, not j.
Reported by Tom Hacohen.
2011-05-30 11:08:40 -04:00
51881a61ca
Shrink code size
2011-05-27 18:15:56 -04:00
90645fb24b
[OT] Separate map_builder from the actual map
...
Respectively, separate planner from the actual plan.
2011-05-27 18:13:31 -04:00
5560a19e2b
Minor
2011-05-27 17:49:16 -04:00
5bc18195d5
Add check-includes.sh
2011-05-27 15:58:54 -04:00
376dafa6ed
Hide internal symbols
2011-05-27 03:40:04 -04:00
329c15714b
Add libtool versioning
...
The versioning is automatic. For now, soname-major is 0. With
the 1.0.0 release it will jump to 1 and stay there forever.
2011-05-25 16:07:07 -04:00
2d8ebcb9d0
[API] One last font-funcs API change
...
Now that vertical text works correctly, I'm doing a last round
modification of the font-funcs API to simplify. Expect no more
changes around here.
2011-05-25 11:27:33 -04:00
7403e055cd
[Vertical] fix vertical gpos
...
Wow, it took me a few days to find the right fix!
We now set the advance for attached marks to zero, but we
do this in the _finish() state of gpos, so it shouldn't
regress with fonts like DejaVuSansMono that explicitly
decrease the mark advance width to set it to zero.
2011-05-25 10:52:15 -04:00
3b0bb855e0
[Vertical] GPOS x/y advance adjustments only apply in hori/vert respectively
2011-05-20 15:59:59 -04:00
cc2086d67c
[Vertical] Fix GPOS y-advance direction
2011-05-19 19:19:50 -04:00
67d51ff961
[Vertical] Do fallback origin calculation
2011-05-19 19:08:57 -04:00
60fbb36096
[Vertical] GPOS is always done with horizontal origin
2011-05-19 18:46:15 -04:00
8b38faeede
More vertical
...
Starting to get there, but not without yet another round of changes.
I think I know wheere to go now.
2011-05-19 13:08:00 -04:00
e609aeb1e2
[hb-view] Add --annotate
...
Currently it only marks glyph origins.
2011-05-18 10:17:02 -04:00
b8d76dd74e
Vertical: Adjust origin in glyph_extents() and glyph_contour_point()
...
The base for vertical is almost ready now.
2011-05-17 23:31:00 -04:00
190981851f
Cosmetic
2011-05-17 23:27:22 -04:00
2c3f51a11c
Minor
2011-05-17 23:23:27 -04:00
7e2c85de30
[API] Vertical support, take 2
...
I like this API *much* better. Implementation still incomplete, but
horizontal works.
2011-05-17 17:55:03 -04:00
744970af4d
[API] Add support for vertical text
...
Design not final yet, and in fact I'm going to change it immediately,
but this is an standalone change for itself.
2011-05-17 17:12:34 -04:00
4053f3f788
Cosmetic
2011-05-16 17:03:27 -04:00
56d12e0356
Remove unnecessary TODO item
2011-05-16 16:01:58 -04:00
1883af3796
[hb-view] Start work on vertical support
2011-05-16 15:18:16 -04:00
9aa6f96af5
[hb-view] No need to allocate an extra glyph item at the end
2011-05-16 15:08:31 -04:00
1a64f6e19a
[API] Add HB_LANGUAGE_INVALID
2011-05-13 22:55:32 -04:00
40b5c2e86c
[test/test-ot-tag] Test hb-ot-tag.h, fix many bugs
...
I'm in awe with how many bugs this test revealed. All fixed.
2011-05-13 22:46:36 -04:00
7fc5a30cb4
[API] Add hb_face_make/is_immutable()
2011-05-12 17:48:20 -04:00
20c8b908dd
Finish off previous change
2011-05-12 15:19:33 -04:00
0fd8c2f1be
[API] Make get_glyph() callback return a boolean
...
We need to know whether the glyph exists, so we can fallback to
composing / decomposing. Assuming that glyph==0 means "doesn't exist"
wouldn't work for applications like Pango that want to use different
"doesn't exist" glyph codes for different characters. An explicit
return value fixes that.
2011-05-12 15:14:13 -04:00
805af72405
Rename get_kernings() arguments from first/second_glyph to left/right_glyph
...
Makes it clear that kerning is in visual order.
2011-05-12 12:39:40 -04:00
df077fadd7
[object] Make object inert during destruction
...
Such that user_data and other finalizers cannot resurrect object
2011-05-12 01:19:39 -04:00
52df150efe
Fix font subclass chainup
...
Test passing now.
2011-05-12 00:46:57 -04:00
7033518f75
[API] Pass face to get_table()
2011-05-11 23:31:15 -04:00
b467827806
[API] Remove const from font user_data
2011-05-11 23:25:28 -04:00
9a14688e40
[API] Rename hb_face_create_for_data() to hb_face_create()
2011-05-11 22:49:29 -04:00
46d6a21cc8
[API] Add hb_ot_layout_substitute_start/finish()
2011-05-11 22:33:13 -04:00
c84d15f52e
Remove unused hb_set_t
2011-05-11 22:23:15 -04:00
389a7c9e67
Remove hb_static_threadsafe_set_t
2011-05-11 22:21:38 -04:00
e06d4eda7b
Use constructor/destructor for hb_ot_shape_plan_t
2011-05-11 22:18:31 -04:00
daa446f184
Fix compile with no mutex available
2011-05-11 21:31:25 -04:00
1e56c476c1
Free static mutex'es
2011-05-11 21:28:01 -04:00
831886a9b4
Streamline mutex stuff
2011-05-11 21:27:52 -04:00
438c4eee35
Remove unused hb_mutex_trylock()
2011-05-11 21:14:34 -04:00
80a6833b03
[API] Add hb_*_get_empty() for all objects
2011-05-11 18:21:58 -04:00
d3b30be378
[API] Add HB_UNTAG()
...
Useful in C API only.
2011-05-11 18:06:12 -04:00
3cc6e9dcb4
Minor
2011-05-11 18:02:48 -04:00
4101ca7dbb
Plug more leaks
...
All good now.
2011-05-11 14:30:56 -04:00
6a7ac79e26
Plug leaks
2011-05-11 14:19:18 -04:00
7aa12ebdff
[unicode] Simplify method setting
2011-05-11 11:55:11 -04:00
d5bfd02721
Minor
2011-05-11 11:48:28 -04:00
6a4e7e1372
Add maxp table
...
Not used for anything right now. Will use to get num_glyphs in the future.
2011-05-11 10:31:33 -04:00
a513dbcf73
[API] Change signature of get_contour_point and get_kerning ffuncs
...
get_contour_point now takes glyph id before point_index.
get_kerning now takes a vector to fill-in.
2011-05-11 00:38:22 -04:00
63d646fb29
[font] Do user-space conversion when chaining up to parent font
2011-05-11 00:15:37 -04:00
b6f902a1a9
Minor
2011-05-11 00:04:15 -04:00
abcfe9b59b
Remove hb_ot_layout_context_t, simplify code
2011-05-11 00:02:02 -04:00
1ded6d8bbf
Make default font-funcs chain-up to the parent
2011-05-10 20:50:06 -04:00
b9d975b931
[API] Pass down closure user_data to font funcs
2011-05-10 20:41:13 -04:00
446df9cdb1
Whitespace
2011-05-10 20:14:44 -04:00
686c2d165d
[API] Remove font_funcs func getter functions
2011-05-10 20:04:26 -04:00
defc45be6d
[API] Add hb_font_create_sub_font() and hb_font_get_parent()
...
Not quite useful just yet.
2011-05-10 20:02:49 -04:00
11bb8fe7b3
[font] Fix internal sign of x/y_scale
...
Should have been done as part of da97541988
2011-05-10 19:57:00 -04:00
85e6218e33
[API] Remove broken-by-design hb_font_unset_funcs()
2011-05-10 19:40:44 -04:00
74f1d896f2
Add hb_font_make/is_immutable()
2011-05-10 19:39:32 -04:00
8c7a100a4d
Fix build without mutex
2011-05-10 19:21:07 -04:00
19d3035c40
Remove duplicate atomic_int implementation
2011-05-10 19:18:12 -04:00
45bfa99034
Fix set implementation to be truly threadsafe even with destroy() callbacks
...
The test/object test is passing again, instead of deadlocking.
2011-05-10 19:15:49 -04:00
1c9f8717eb
[API] Simplify blob API, remove lock
2011-05-06 22:59:42 -04:00
a0f337a1cc
Remove unused hb_blob_try_writable_inplace()
2011-05-06 19:20:52 -04:00
08611d5194
Add note re deadlocks
2011-05-06 16:28:10 -04:00
34fb5521a5
[API] Add hb_language_get_default()
...
It uses locale information to detect default language. It's used by
hb_shape() whenever language is not set on the buffer.
Not sure how to properly test it in the test suite. Tested by observing
that with DejaVu Sans we select the proper local glyph version for U+431
under Serbian locale. See http://www.pango.org/ScriptGallery
2011-05-06 00:05:08 -04:00
c78f448558
[API] Add version macros and functions
...
Step version up to 0.5.0.
Also, fix to pass "make distcheck"
2011-05-05 21:31:04 -04:00
3935af1c0d
[buffer] Remove wrong optimization
...
While the cluster fields of the glyph string are usually sorted, they
wouldn't be in special cases (for example for non-native direction).
Blindly using bsearch is plain wrong. If we want to reintroduce this
optimization we have to make sure we know the buffer clusters are
monotonic and in which direction. Not sure it's worth it though.
2011-05-05 16:09:45 -04:00
46df682851
Make user_data access threadsafe
...
For now, by taking a global user_data mutex.
2011-05-05 15:33:19 -04:00
218e67b9ee
Shrink code
2011-05-05 15:28:37 -04:00
b8d6183ebc
Use threadsafe set implementation for hb_language lookups
...
Note that the static variable has to be a global static, as gcc
implements local statics differently and that would require linking
to libstdc++, which we don't want.
2011-05-05 15:14:04 -04:00
d37486d87b
Add hb_threadsafe_set_t
2011-05-05 15:07:54 -04:00
b45f32ee4e
Use hb_array_t for hb_language_t mapping
2011-05-05 15:00:43 -04:00
21d2c92fdf
Move code around
2011-05-05 14:47:53 -04:00
265ac614ea
Replace fixed-size lookup_maps array with hb_array_t
2011-05-05 14:38:16 -04:00
6843569d2c
Replace fixed-size feature_maps array with hb_array_t
2011-05-05 14:30:51 -04:00
44b0a4d2fc
Replace fixed-size feature_infos array with hb_array_t
2011-05-05 13:42:19 -04:00
b214ec3ac0
Minor
2011-05-05 13:24:07 -04:00
811482bd65
Replace hb_map_t with hb_set_t which is more intuitive and flexible
2011-05-05 13:21:04 -04:00
478a42536f
Make array/map implementation more generic
2011-05-05 12:39:51 -04:00
b81bd42951
Make hb_mutex_*() macros take a pointer
...
More intuitive.
2011-05-05 00:21:16 -04:00
a4b1900913
Add hb_static_mutex_t
2011-05-05 00:17:43 -04:00
56eb5ad6f9
Move code around
...
Mutex (and Windows.h by extension) are fairly isolated now.
2011-05-04 19:27:37 -04:00
d292885893
[ft] Fix font->face handling
...
Don't use _cached()
2011-05-03 01:03:53 -04:00
2000179487
Move Win32 thread-safety stuff to hb-object-private.h
...
The Win32 definitions for LONG, ULONG, etc conflicts with
hb-open-type.h. Avoid that by making sure hb-object-private.h
and hb-open-type.h are not included in the same compilation unit.
2011-05-03 00:49:06 -04:00
266b34418c
Refactor to keep hb-object-private.h and hb-open-type.h separate
...
Needed to be able to include <Windows.h> from hb-object-private.h.
2011-05-03 00:35:53 -04:00
d4141a44b9
[blob] Implement sub_blob() in terms of create()
...
Fixes problem with uninitialized sub_blob->mutex among other things.
Reported by Bradley Grainger.
2011-05-03 00:19:18 -04:00
fc52e9e44c
Implement win32 thread-safety stuff
...
Patch from Bradley Grainger.
2011-05-03 00:09:16 -04:00
f55272ecde
Add hb_mutex_free() and use it
...
Based on patch by Bradley Grainger.
2011-05-02 20:57:28 -04:00
8d5186484b
Cosmetic
2011-05-02 20:52:21 -04:00
72657e4ce7
[API] Make hb_font_create() take a face and reference it
2011-05-02 20:47:23 -04:00
cec6611c5c
Protect NULL in a couple places
2011-05-02 20:18:58 -04:00
5a5030366e
Fix bug in array growth implementation
...
With this, test/object is now passing. Yay!
2011-05-02 19:54:29 -04:00
16123e1070
Fix bug in map implementation
2011-05-02 19:54:17 -04:00
1cd5969f25
[object] Fix bug in get_user_data() implementation
2011-05-02 19:53:39 -04:00
4911062d5b
[API] Rename hb_blob_create_empty() to hb_blob_get_empty()
2011-05-02 19:36:39 -04:00
1ab1d3e38c
[face] Return nil face if blob is inert
2011-05-02 19:35:53 -04:00
e87867cb88
[buffer] Fail in _create() if we cannot pre-allocate the requested size
2011-05-02 19:35:05 -04:00
c784c67a28
[unicode] Make _get_parent() return _nil object instead of NULL
2011-05-02 15:59:57 -04:00
03034acb8a
[icu] Make sure we return script UNKNOWN instead of INVALID
2011-05-02 12:37:45 -04:00
d02985ec5a
ISO 15924 fixes
...
Update to http://unicode.org/iso15924
Fixes some of the test failures in test-unicode with ICU. Still
one more to fix before the test passes.
2011-05-02 12:35:14 -04:00
6af9cff5e1
[test/unicode] Use text fixture instead of static variables
2011-04-29 12:12:37 -04:00
243673d601
[test/buffer] Add more extensive UTF-8 test data from glib
2011-04-28 19:37:51 -04:00
c7ffe2ad5f
[API Remove hb_font_funcs_copy()
...
Will be adding font_funcs subclassing instead.
2011-04-28 16:03:29 -04:00
30f34d08d4
[TODO] Remove finished items
2011-04-28 16:02:40 -04:00
080a0eb7d8
Add _hb_unsigned_int_mul_overflows
2011-04-28 16:01:01 -04:00
3264042873
[test/buffer] Test pre_allocate() and allocation_successful()
2011-04-28 14:24:16 -04:00
123aa04f7b
Fix possible but improbable overflow in hb_array_t
2011-04-28 12:58:28 -04:00
e0db4b868f
[buffer] More error handling
...
Should be all set now.
2011-04-28 12:56:49 -04:00
5fa849b77d
[API] Add _set/get_user_data() for all objects
2011-04-27 21:46:01 -04:00
852e08ec8f
Move code around
2011-04-27 21:45:51 -04:00
29c67d3f70
Add initial implementation of user_data to objects
2011-04-27 21:27:40 -04:00
47e71d9661
[object] Remove unnecessary use of macros
2011-04-27 16:41:08 -04:00
8be1420f8f
[blob] Use HB_FUNC instead of __FUNCTION__
2011-04-27 16:16:43 -04:00
ae008b90cf
[object] Add tracing support back in
2011-04-27 16:16:39 -04:00
39a840ae65
[API] Add hb_direction_from/to_string()
...
And hb-view --direction argument.
2011-04-27 14:48:19 -04:00
f1425a549f
Rename hb-view.c and test.c to .cc files
2011-04-27 12:15:06 -04:00
65e0063eae
Make buffer size growth start from 32 instead of 8
2011-04-27 09:38:23 -04:00
d4bee9f813
[API] Add hb_unicode_funcs_get_default()
2011-04-27 09:38:19 -04:00
153142dac8
Replace simple macros with inline functions for better type safety
...
Now that we use C++ for all source code, lets benefit from it!
The hb_be_int16/32_get/put/eq() macros grow code size if replaced with
inline functions, so leave them as is.
2011-04-27 02:07:46 -04:00
40a9b8154f
Add TODO item
2011-04-27 01:48:56 -04:00
ebdc83467c
Don't return in void function
...
Would have been nice if gcc had warned...
2011-04-27 01:41:24 -04:00
ec6f9c2fd0
Further simplify object handling
2011-04-21 18:35:58 -04:00
fca368c468
Add hb_object_header_t which is the common part of all objects
...
Makes way for adding arbitrary user_data support.
2011-04-21 18:24:02 -04:00
a9f24c8029
Move hb_reference_count_t to hb-private.h
2011-04-21 17:18:22 -04:00
2409d5f8d7
Update Copyright headers
2011-04-21 17:14:28 -04:00
08da7a3841
[hb-view] Accept numbers in feature tag name
...
Reported by Adam Twardoch.
2011-04-21 16:59:10 -04:00
24229eb132
Remove obsolete comment
...
Talking to Ryan Lortie, he thinks my comment doesn't make sense.
So I'm making the getter const. Note that g_atomic_int_get()
casts that away itself, so we don't need to worry about that
(which kinda makes me uncomfortable actually).
2011-04-21 16:55:17 -04:00
dcb7026f33
Add ASSERT_STATIC_EXPR macro
...
Unused right now.
2011-04-21 16:34:22 -04:00
3e8bdbf941
Cleanup hb_refrence_count_t
2011-04-21 16:16:21 -04:00
783a7d6969
[TODO] Remove finished items
2011-04-21 16:03:59 -04:00
da97541988
[API] Allow negative font x_scale/y_scale
...
I was reconsidering whether y should grow down, since all three/four
times I've used this API I was tricked and got that wrong in my use.
So I was very inclined to make y grow down instead of up. However,
considering that the font space has y up and it would be very confusing
for callbacks to work against that, I decided that what I really want
is for the user to be able to set y_scale to a negative number to imply
that user-space y grows down.
Changing x_scale/y_scale from unsigned int to int allows that, and I've
made pango to use that instead of negating glyph y_offset later. hb-ft
however still has y group up. I *guess* that's how FreeType works?
I'm not sure, FreeType docs don't make this clear...
I'm happy with the resolution :-).
2011-04-21 15:15:02 -04:00
4d559cddbb
[icu] Remove big script switch(), rely on reverse-lookup
2011-04-21 14:58:23 -04:00
d18431b4cd
Move hb_reference_count_t from macros to inline methods
2011-04-20 18:59:10 -04:00
c57d454acc
Rename all private sources and headers to C++ files
...
So we can liberally use the simple features of C++ that parts of the
codebase is already using.
2011-04-20 18:50:27 -04:00
f19f4f9b09
Rename hb-blob.c to hb-blob.cc in preparation of more changes
2011-04-20 18:25:56 -04:00
9417c1c0d2
[API] Make hb_face_reference_table() return empty blob instead of NULL
...
The idea here is that:
- Like pretty much all other API in harfbuzz, user does not have to
check for NULL.
- In any caller code, the case of missing table should be handled
exactly the same way that a too-short table is handled. Turning
a non-existent talbe into a table of size 0 makes the user code
safer.
2011-04-20 17:21:23 -04:00
c035812feb
[API] Rename hb_face_get_table() to hb_face_reference_table()
...
That correctly reflects the reference ownership transfer happening.
2011-04-20 17:03:00 -04:00
2d7b61a4b0
[TODO] Remove done items
2011-04-20 16:40:56 -04:00
af02933739
[API] Remove hb_*_get_reference_count()
...
This was a bizzare piece of API that I inherited from cairo. It has
been wrong adding them to cairo in the first place. Remove them before
someone uses them!
2011-04-20 15:49:31 -04:00
440a76b630
[OT] Fix script to ot-script-tag conversion
2011-04-20 14:20:00 -04:00
a3036a3e97
Minor
2011-04-20 14:13:23 -04:00
5668189c12
[API] font: move user_data before destroy()
...
This is the common convention for language binding tools.
2011-04-20 03:03:32 -04:00
e5847f75fb
[API] blob: move user_data before destroy()
...
This is the common convention for language binding tools.
2011-04-20 02:59:28 -04:00
f144a8ea84
[icu] Add two-way script conversion functions
...
Also optimizes the common-direction script lookup.
2011-04-20 02:54:42 -04:00
0809aadd4b
[glib] Add two-way script conversion functions
...
Also optimizes the common-direction script lookup to be an array lookup.
2011-04-20 02:44:29 -04:00
5c8c1b680c
Remove verbose comments
2011-04-20 02:29:22 -04:00
fb194b8794
unicode: Cleanup implementation
2011-04-20 02:27:39 -04:00
ecfb773829
Cosmetic
2011-04-20 01:34:51 -04:00
2fd0c577e3
[API] unicode: rework virtual functions for subclassing
...
Unicode data providers can now be subclassed, including support for
chain-up. The interface should now be nicely bindable, as well.
Also fix glib unicode funcs that where broken after hb_script_t
changes. Nicely caught by the test-unicode.c added in this commit.
2011-04-20 00:19:20 -04:00
f85faee9b3
[API] Rename hb_buffer_add_glyph() to hb_buffer_add()
2011-04-19 00:38:01 -04:00
aab0de50e2
[API] Add hb_buffer_allocation_successful()
...
Returns the error status of the buffer.
2011-04-19 00:32:19 -04:00
02a534b23f
[API] Rename hb_buffer_ensure() to hb_buffer_pre_allocate()
...
The new name is self-documenting.
2011-04-19 00:05:43 -04:00
70566befc5
[API} hb_buffer_get_glyph_{infos,positions}: Add length out parameter
...
Return the length, whenever we return an array. Makes it easier on the
language bindings.
2011-04-19 00:03:44 -04:00
62879eebd9
[API] Use ISO 15924 tags for hb_script_t
...
This simplifies the code, reduces static data, and makes the design
more extensible to future additions of new scripts.
2011-04-18 23:40:21 -04:00
c0af193c8e
Change buffer default properties to invalid
...
This includes HB_DIRECTION_INVALID and HB_SCRIPT_INVALID.
The INVALID will cause a "guess whatever from the text" in hb_shape().
While it's not ideal, it works better than the previous defaults at
least (HB_DIRECTION_LTR and HB_SCRIPT_COMMON).
2011-04-15 19:26:24 -04:00
00bec2c969
Move enum types to hb-common.h
2011-04-15 19:16:54 -04:00
b54cd07b26
Mark internal buffer variables private
2011-04-15 19:12:01 -04:00
0e8d35c093
Add hb_script_from_string()
2011-04-15 19:08:43 -04:00
8f0d7e0c3f
Remove hb_buffer_clear_positions(), add hb_ot_layout_position_start()
2011-04-15 19:08:43 -04:00
2fc56edff6
[API] Remove hb_buffer_clear()
...
One should use hb_buffer_reset() really.
2011-04-15 19:08:38 -04:00
5814dfa3f5
Cosmetic
2011-04-15 14:41:04 -04:00
3cbdf70e0a
Make hb_language_t typesafe
2011-04-15 12:33:14 -04:00
c910bec863
Add hb_buffer_reset() and hb_buffer_set_length()
2011-04-13 15:49:06 -04:00
69ea23cb5d
Minor
2011-04-13 15:02:40 -04:00
8e4bb3cacc
Fold hb-language.[ch] into hb-common.[ch]
2011-04-11 17:55:58 -04:00
316b7a1afb
Make hb_language_from_string("") return NULL language
2011-04-11 17:49:10 -04:00
99b74760a4
Rename hb_category_t to hb_unicode_general_category_t
2011-04-11 15:47:40 -04:00
4188096a77
Make HB_TAG_CHAR4 private
...
It's just sugar.
2011-04-11 14:58:28 -04:00
7ff7401c92
Make hb_tag_from_string(NULL) return HB_TAG_NONE
2011-04-11 13:27:30 -04:00
db5227c40e
Move macros around
2011-04-11 13:16:08 -04:00
07233581c9
Rename HB_TAG_STR() to HB_TAG_CHAR4()
...
The problem with HB_TAG_STR() was that it expected a string of size 4
exactly, and unlike hb_tag_from_string() it doesn't pad the tag with
space characters. So, the new name is more appropriate.
2011-04-11 13:12:37 -04:00
d77b76200e
Add few more paratheses to the HB_TAG macro
...
Never hurts.
2011-04-11 12:29:52 -04:00
b13640de69
A few more ASSERTs
2011-04-11 12:29:31 -04:00
ae9eeaff93
Remove warning message from public header file
...
Since we now assert thos in hb-private.h, the int types cannot be wrong.
(Except for when someone else includes hb-common.h in a very broken
configuration, but that's not our problem!)
Plus, we don't use inline in the public headers, so remove that too.
2011-04-11 12:09:13 -04:00
6fd5364bdc
Assert int types
2011-04-11 11:47:14 -04:00
a71b9c8579
Disable 'cswh' by default except for Arabic shaper
...
That better matches OpenType spec. Note that we enable it for all
Arabic-shaper scripts. Ie. we enable it by default for Syriac too,
but the SyriacOT spec does not require it. I think this is a more
useful compromise than special-casing for Arabic script alone.
2011-04-06 14:04:56 -04:00
cab6f65bba
[hb-view] setlocale (LC_ALL, "")
...
For now we don't use anything from the locale, but we should default
to using $LANG, etc, if --language is not specified. Right?
2011-04-04 15:36:51 -04:00
fb9ca1bfab
[hb-view] Rewrite --features parsing, with range support
...
The --features parsing handles errors now. More importantly, it
allos limiting individual features to specific byte ranges. The
format is Python-esque. Here is how it all works:
Syntax: Value: Start: End:
Setting value:
"kern" 1 0 ∞ # Turn feature on
"+kern" 1 0 ∞ # Turn feature off
"-kern" 0 0 ∞ # Turn feature off
"kern=0" 0 0 ∞ # Turn feature off
"kern=1" 1 0 ∞ # Turn feature on
"kern=2" 2 0 ∞ # Choose 2nd alternate
Setting index:
"kern[]" 1 0 ∞ # Turn feature on
"kern[:]" 1 0 ∞ # Turn feature on
"kern[5:]" 1 5 ∞ # Turn feature on, partial
"kern[:5]" 1 0 5 # Turn feature on, partial
"kern[3:5]" 1 3 5 # Turn feature on, range
"kern[3]" 1 3 3+1 # Turn feature on, single char
Mixing it all:
"kern[3:5]=0" 1 3 5 # Turn feature off for range
2011-04-04 14:50:09 -04:00
ccc6745afa
[hb-view] Use cached hb-ft face creation
...
Avoids recreating the face the second time we call draw().
2011-04-04 14:49:50 -04:00
1b4a2cc095
[hb-view] Add --debug
...
Frees all allocated memory before exiting. Useful for valgrind run.
2011-04-04 14:45:28 -04:00
b2da26d1e3
[hb-view] Support --features
...
Accepts values like:
--features="-mkmk,aalt=2,calt=1,+cswh"
A minus sign means "=0", a plus sign means "=1". Default is "=1".
A minus sign overrides an explicit value.
2011-04-01 15:48:43 -04:00
f48ff19b62
Sort options for clarity
2011-04-01 14:19:10 -04:00
5d91c3d547
Add script to/from ISO 15924 tag support
...
Also adds --script support to hb-view.
If a script tag is not known to us, we pass the ISO 15924 tag around.
Right now, the OT layer ignores that, but we can fix it to blindly
convert that to an OT script tag.
2011-03-16 17:36:32 -03:00
3286fc0e9a
Let hb_shape() guess script and direction...
...
- Rename HB_SCRIPT_INVALID_CODE to HB_SCRIPT_INVALID
- Add HB_DIRECTION_INVALID
- Make hb_script_get_horizontal_direction() public
- Make hb_shape() guess script from buffer text (first non-common
non-inherit script) if buffer script is set to HB_SCRIPT_INVALID (this
is NOT the default.)
- Make hb_shape() guess direction from buffer script if buffer direction
is set to HB_DIRECTION_INVALID (this is NOT the default.)
- Make hb-view.c set INVALID script and direction on the buffer.
The above changes are meant to make hb-view fairly useful for uni-script
uni-direction text. The guessing behavior however is NOT the default of
hb_shape() and must be asked for explicitly. This is intended, because
the guess is not a suitable substitute to full-fledged bidi and script
segmentation. It's just a testing tool.
2011-03-16 14:53:32 -03:00
b7b29684df
[hb-view] Handle write_to_png errors
2011-03-02 01:01:03 -05:00
c2cb98c818
[hb-view] Link with -lm
2011-03-01 23:18:09 -05:00
b5dd44e246
Fix possible overflow
2011-02-28 10:13:52 -08:00
a4b781e93a
Default background color shall either be white or transparent
...
Definitely not black!
2011-02-23 12:47:56 -05:00
5353bf439c
Add initial hb-view tool
...
Currently doesn't handle script or direction.
2011-02-22 18:06:19 -05:00
82438c6ad5
Fix #pragma message for MSVC.
...
__LOC__ was renamed to _HB__LOC__ in cd7555 but the corresponding
change wasn't made in hb-private.h.
2011-02-15 18:37:29 -05:00
ba9ab8d6d9
Fix language extension matching
2011-01-10 07:45:41 -05:00
7bbe14bed8
Fix 'make distcheck'
2011-01-09 22:29:14 -05:00
cc1a8a938b
Fix ChanContext backtrack matching with GPOS
...
Reported on mailing list by Keith Stribley and Khaled Hosny.
2011-01-06 14:58:52 -05:00
1c3183027f
Remove unused realloc
...
We always allocate and grow str and pos together.
2011-01-06 14:44:14 -05:00
756f794a1f
Remove Graphite backend
...
It was unmaintained and the code has to be replaced to use the new
grphite-ng code base.
2010-12-26 20:52:40 -05:00
f3d9d98793
Docs
2010-12-22 01:39:29 -05:00
d86a5b3c57
Bug 32274 - classic mongolian shaper
...
Add support for classic Mongolian script to the Arabic shaper.
Still work to be done around U+180E MONGOLIAN VOWEL SEPARATOR as it
should not be included in the final glyph stream the same way that
ZWNJ, etc should not appear in the final glyph stream.
But the joining part should be done.
There remains the question of how should the U+18A9 MONGOLIAN LETTER ALI
GALI DAGALGA be handled as it has General Category NSM but a letter
nonetheless. For now, our generic logic makes this a joining T instead
of joining D as other Mongolian letters are.
2010-12-21 18:36:25 -05:00
b0e7378fa9
Reroute Mandaic shaping through the Arabic shaper
...
We added Mandaic joining data to the Arabic shaper a while ago, but
were not actually using the Arabic shaper for Mandaic. Fixed.
2010-12-21 14:19:32 -05:00
88e7f37488
Annotate the Arabic joining table with block information
2010-12-21 14:18:24 -05:00
1482a39e56
Rename remaining metrics uses to extents
2010-12-17 20:15:05 -05:00
22c537657c
Rename TableDirectory to TableRecord as per OpenType 1.6
2010-12-14 23:51:29 -05:00
33e8b86197
Update 'head' table to OpenType 1.6
2010-12-13 15:54:56 -05:00
b768333514
Disallow ligature substitutions replacing one glyph
2010-12-13 14:22:35 -05:00
7eb875118d
Mozilla Bug 618592 - freeze on typekit
...
Fix apply_lookup() for zero-input broken fonts.
2010-12-13 14:13:35 -05:00
bbbbe80ec9
Rename original_direction to target_direction
2010-12-07 16:22:02 -05:00
ee8aaf976a
Fix arabic shaping of LTR text
...
We should ensure-direction before doing any complex work. The only
exception is mirroring that needs to see the original / final direction,
not the native. Handle that.
2010-12-07 16:20:42 -05:00
4f9e4a40bc
Fix failing checks
2010-11-22 11:30:32 -05:00
9da26d6669
Remove email address from Copyright headers
2010-11-22 11:03:18 -05:00
a45f000192
Clarify copyright notice
2010-11-18 13:59:10 -05:00
0884a8d9cd
Move generated table to its own file
2010-11-17 16:58:21 -05:00
14d784116b
Update Arabic joining table to include Mandaic
...
Mandaic was added to Unicode 6.0, but the joining data was not updated.
Draft ArabicShaping.txt from 6.1 includes the joining data for Mandaic.
Use that.
2010-11-17 16:52:58 -05:00
43bf2f7f1e
Add OpenType script tags for Unicode 5.2 and Unicode 6.0 scripts
...
Based on tags proposed by Microsoft for inclusion in OpenType.
2010-11-17 14:49:40 -05:00
afab01cf7c
Add Unicode 6.0 scripts
2010-11-17 14:35:34 -05:00
f234b68d18
Change HB_SCRIPT_MEITEI_MAYEK to HB_SCRIPT_MEETEI_MAYEK
...
The new name matches the Unicode name. Reported by Jonathan Kew.
2010-11-17 14:25:44 -05:00
300cb41417
Add XXX marks
2010-11-17 12:57:23 -05:00
3a852ae7fe
Save general category and combining class in the buffer for reuse
2010-11-03 16:37:24 -04:00
a5ab682b9b
More "unreached code" warning fixes
...
Ugly :(.
2010-11-03 16:10:12 -04:00
4e22c7e941
Add comment
2010-11-03 16:10:12 -04:00
0342034d1c
Pedantic
2010-11-03 16:10:12 -04:00
4a2d844c2f
Minor code shuffling
2010-11-03 15:28:56 -04:00
11e3ec444a
Fix a few more "unreachable code" warnings
2010-11-03 15:11:04 -04:00
2304856340
Remove another couple lines of dead code
2010-11-03 12:47:27 -04:00
b8783c85ac
Fix unreachable-code warning
2010-11-03 11:51:43 -04:00
c2709119c8
Move things around some more
2010-11-02 19:12:59 -04:00
194d4566ec
Move buffer var allocation local
2010-11-02 19:12:59 -04:00
1e7c1fcbc3
Move code around
2010-11-02 19:12:59 -04:00
bf94b3ad22
Move some more code around
2010-11-02 19:12:59 -04:00
6334658fe7
Simplify mark skipping logic
2010-11-02 19:12:59 -04:00
8c69e65abe
Rename lookup_flags to lookup_props since it's more than just flags
2010-11-02 19:12:59 -04:00
98370e89d1
WIP removing external synthesized GDEF support and implementing it internally
2010-11-02 19:12:58 -04:00
870e2d6eac
Remove unused function
2010-11-02 19:12:58 -04:00
1115890b90
More cleanup
2010-11-02 19:12:58 -04:00
dbf56b1d94
More lig-id cleanup
2010-11-02 19:12:58 -04:00
f6a23a0b91
More removal of lig-id code from buffer
2010-11-02 19:12:58 -04:00
dd2ffd282c
Minor renaming
2010-11-02 19:12:58 -04:00
fe263272a2
Move setting lig_id/component out of buffer and to the gsub code
2010-11-02 19:12:58 -04:00
2e2b2480c0
Always allocate new ligature id
...
No practical point in reusing ligature ids.
2010-11-02 19:12:58 -04:00
bf07d5a29c
Set component=0 for ligature glyph
2010-11-02 19:12:58 -04:00
37ab877149
Remove comment
2010-11-02 19:12:58 -04:00
88474c6fda
Get rid of the OpenType-specific internal buffer representation
...
Add variant integers to buffer item types. More cleanup coming.
2010-11-02 19:12:58 -04:00
6cb8c34930
Add hb_var_int_t
2010-11-02 19:12:57 -04:00
f22802431a
Remove trailing comma
2010-11-02 19:12:57 -04:00
13528d0c78
Supposedly implement vertical support in GPOS
...
Not tested at all.
2010-10-27 14:09:27 -04:00
9624de5b49
Clarify cursive_chain (and change its sign)
2010-10-27 13:44:59 -04:00
d6c9eadb88
Remove more pointless LONGTERMTODO items
2010-10-27 12:34:50 -04:00
e204674fe3
Rename hb_ot_layout_get_lig_carets() to hb_ot_layout_get_ligature_carets()
2010-10-27 12:32:02 -04:00
3357d145f8
Implement vertical support in get_lig_carets()
2010-10-27 12:30:46 -04:00
8eeed7eddc
Remove LONGTERMTODO item that I'll never fix
2010-10-27 12:07:49 -04:00
184a5279c6
Remove unused macro
2010-10-27 12:00:49 -04:00
af5d02a269
Rewrite Cursive joining to act more like other pair lookups
...
Look forward for next character instead of joining to the last character.
2010-10-27 11:54:26 -04:00
ea22c749c7
Fix Cursive positioning
...
Test case: "مرا" rendered using IranNastaliq.
2010-10-27 11:09:48 -04:00
aefdb64689
Fix segfault with Arabic combining marks
2010-10-27 10:40:39 -04:00
248e3c2ba4
Oops, remove extra mask setting that broke complex shaping
2010-10-27 01:23:14 -04:00
502f4cba3e
Divide get_metrics into get_advance and get_extents
...
Graphite module not updated.
Bump version to 0.3.
2010-10-27 01:13:56 -04:00
ec6c0e54d3
Fix blob leak
2010-10-26 11:28:14 -04:00
bd7378b2ef
Massage mask setting a bit more
...
Still finding the exact correct way the masks should be set.
2010-10-13 18:33:16 -04:00
961f9baa7b
Oops, actually set global mask
2010-10-13 17:17:00 -04:00
39dede9fff
Make sure boolean features always use value=1
...
Previously boolean features turned on the entire feature mask. This is
wrong if feature is Alternate and user has provided values bigger than one.
Though, I don't think other engines support such corner cases.
2010-10-13 15:54:06 -04:00
3506b2e78d
Return early if mask is 0
2010-10-13 15:38:52 -04:00
5c1c8c9c50
Make sure feature values don't leak out of their mask
2010-10-13 15:36:38 -04:00
852912fc2d
Fix applying default-value for features
...
Previously if a default global feature was overrided by a non-global
user feature, we were not setting any default mask for the feature,
essentially disabling the feature by default. Fix that.
2010-10-13 15:34:50 -04:00
2989be4919
Set user masks after complex masks
2010-10-13 15:18:29 -04:00
3111b8a0d5
Fix stupid bug, oops
2010-10-13 10:41:53 -04:00
758f68b860
Fix Arabic shaper
...
It's tested now. It works!
2010-10-12 17:37:44 -04:00
13403bc67a
Hookup Arabic shaper!
...
Not tested yet.
2010-10-12 17:23:54 -04:00
57ac0ecb78
Merge clearing masks and setting global masks
2010-10-12 17:07:02 -04:00
fc96596b7c
Form clusters before setting masks
2010-10-12 17:00:40 -04:00
1e80782244
Clear masks before setting them up, not after!
2010-10-12 17:00:07 -04:00
fd3d32d31c
Add hb_ot_shape_execute()
...
Not public yet.
2010-10-12 16:57:47 -04:00
49baa1f69e
Add hb_ot_complex_shaper_t stuff and start hooking Arabic shaper up
2010-10-12 16:50:36 -04:00
605ed468f3
Add hb_ot_shape_plan_t
...
This is the object that a separate plan/execute shaping API will use in
between the two stages.
2010-10-12 16:19:38 -04:00
895fb5d364
Refactor, in a different direction
2010-10-12 16:00:21 -04:00
d2ba016ca1
More refactoring
2010-10-12 15:35:45 -04:00
66e487dfbf
Update Arabic shaping table to Unicode 6.0.0.
2010-10-12 13:51:19 -04:00
f4792d99ee
Fix infinite loop!
...
Untested code is indeed buggy code.
Mozilla bug #603352 .
2010-10-12 12:32:18 -04:00
993d1e786a
Fix missing negation in unreachable code!
...
Mozilla bug #603346
2010-10-12 11:17:30 -04:00
52601275d5
More separation
2010-10-08 20:38:46 -04:00
6b7e675862
Minor
2010-10-08 20:30:04 -04:00
aa9c450bb2
Enable 'rtlm' mirroring
2010-10-08 20:27:38 -04:00
36925f695d
Rename hb_mask_allocator_t to hb_ot_map_t
...
hb_ot_plan_t may be a better name, donno.
2010-10-08 20:21:09 -04:00
f5dd3be46b
Improve checks
2010-10-08 20:16:23 -04:00
5a2b0b3878
Add hb-ot-map.cc
2010-10-08 20:14:57 -04:00
ecc4550ed7
Fix feature overriding
2010-10-08 20:05:29 -04:00
8f08c32750
Minor cleanup
2010-10-08 19:51:03 -04:00
a806762a31
Add hb-ot-shape-private.hh
2010-10-08 19:21:46 -04:00
4924affe0f
Add hb-ot-map-private.hh
2010-10-08 19:18:16 -04:00
a7c5046d6b
Add private hb_segment_properties_t
2010-10-08 18:47:47 -04:00
b897c607d9
Flip the OT bit-allocation vs gsub/gpos inside-out
...
We now build our entire attack plan before jumping in.
2010-10-08 18:41:57 -04:00
e89b7d2a61
Logically separate feature collection
2010-10-08 12:29:59 -04:00
5b88908f12
Minor
2010-10-08 12:23:01 -04:00
5360ce0c5c
Move some more code around
2010-10-07 21:21:11 -04:00
d9c7260788
Minor
2010-10-07 21:19:54 -04:00
efe0d682e8
Simplify compiling lookups
2010-10-07 21:12:46 -04:00
476c94218b
Rename
2010-10-07 17:47:33 -04:00
34db6f031d
Add XXX note
2010-10-07 01:21:19 -04:00
98aa3f6544
Call hb_ot_shape_setup_lookups_complex()
2010-10-06 00:23:36 -04:00
f1d07885dc
Rename setup_lookups()
2010-10-06 00:21:37 -04:00
affc5abac7
Move table_tag to hb_ot_shape_context_t
2010-10-06 00:18:16 -04:00
967240dd8b
Add internal hb_ot_shape_context_t
2010-10-05 23:00:05 -04:00
3eb936f153
Add Arabic/Syriac/N'ko shaping logic
...
Not hooked up just yet.
2010-10-05 19:22:06 -04:00
e81d7afe6e
Add hb_face_get_upem()
2010-10-04 18:18:48 -04:00
bd361945a8
Add API comments
2010-10-04 17:22:57 -04:00
645f6f265b
Add is_mutable() functions
...
Correspond to the make_mutable() ones.
2010-10-04 17:01:01 -04:00
19c0eab8cf
Add getters for all setter APIs
...
One in particular is not a straight getter: hb_font_unset_funcs() is
special because of the specific needs of the lifecycle management of
the user_data object.
2010-10-04 16:45:21 -04:00
f0feb084b0
Minor
2010-10-03 19:09:39 -04:00
ac0c1663fa
Avoid div-by-zero, validate upem
2010-10-01 19:09:23 -04:00
Behdad Esfahbod
Jonathan Kew
Ryan Lortie
Bradley Grainger