ce114d6b27
minor, tweak spaces
2019-12-31 15:53:02 +03:30
33c3d63a0a
Merge pull request #1594 from harfbuzz/var-subset
...
Issue 1558: [subset] TrueType/CFF2 variable font
2019-12-31 13:52:50 +03:30
68c1798a67
[coretext] Use kCTFontOpenTypeFeatureTag
...
Instead of trying to map OpenType features to AAT feature selectors
which only works for a small subset of OpenType features, use the
simpler kCTFontOpenTypeFeatureTag with OpenType feature tags directly.
With this change, features like cvXX can be enabled in coretext shaper,
while they were previously ignored due to missing mapping.
This seems to work even with AAT fonts that don’t have OpenType layout
tables, which suggests that CoreText is doing the mapping itself in this
case.
kCTFontOpenTypeFeatureTag seems to have been introduced in macOS 10.10
and iOS 8.0, though, so its use is conditional on version check for now.
Not sure how to check iOS version, so I left this out.
2019-12-22 06:27:48 -08:00
b28c282585
Check to avoid overflows
2019-12-16 18:08:22 -08:00
d70afb1e5a
Clamp max_ops to upper bound in hb-sanitize.hh
2019-12-16 18:08:22 -08:00
b79ceac3c6
Prefer UINT_MAX instead of uint overflow.
...
Also, prefer HB_FEATURE_GLOBAL_START and HB_FEATURE_GLOBAL_END.
2019-12-15 11:46:05 -08:00
b618e0ae13
Remove non-breaking spaces from comments.
...
`0xC2A0` was used, for some reasons. It's not really a problem, but Qt Creator
constatly trying to replace them with regular spaces, so I have to edit those
files separately.
2019-12-15 10:12:22 -08:00
780d640c02
Remove unnecessary check in hb_buffer_t::set_masks.
...
Bounds are already checked by the caller.
Closes #2073
2019-12-15 10:08:38 -08:00
34ed8e7218
Prefer _hb_glyph_info_is_unicode_mark where possible.
2019-12-13 08:55:34 +03:30
3e1a2632dc
[unscribe] fix leak issue
...
with no user_data provided, `free` will be called with `(0)` thus silently having a leak
2019-12-12 15:48:27 +03:30
4ef597e170
Fix unary minus operator applied to unsigned int
...
Applying unary minus operator to unsigned int causes the following error on MSVS: error C4146
This patch fixes the error.
2019-12-11 09:19:28 -06:00
1770493cf5
Fix unary minus operator applied to unsigned int
...
Applying unary minus operator to unsigned int causes the following error on MSVS: error C4146
This patch fixes the error.
2019-12-11 09:19:19 -06:00
a061e47fcc
Change a few HB_INTERNAL static methods to static inline
2019-12-10 13:31:50 -06:00
dd3972a364
[GSUB] Simplify Extension is_reverse()
...
We don't allow extension lookups to chain to another extension lookup.
Simplify code for that.
2019-12-10 13:28:39 -06:00
858b627984
[machinery] Remove CastR<>()
2019-12-10 13:18:32 -06:00
b84ceb2fcf
[machinery] Remove CastP
2019-12-10 13:02:48 -06:00
85574ec287
[machinery] Minor
2019-12-10 12:52:32 -06:00
6a60ca117c
[algs] Fold last other bsearch() in
...
Now truly have only one bsearch implementation.
2019-12-10 12:32:59 -06:00
39afe608b4
[algs] Fold one more custom bsearch() in
...
One more to go.
2019-12-10 12:13:40 -06:00
b1dc676eaa
[algs] Reduce one more bsearch() impl
...
Ouch, there were three more left. Down one. Two to go.
2019-12-10 12:13:40 -06:00
f47cbade18
[aat] Adjust fallback positioning logic
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1528
Wish could add a test...
$ ./hb-view --font-file Thonburi.ttc --unicodes U+0E17,U+0E35,U+0E48,U+0E4A --shaper ot
▃
▂▃▃▄▃▂▁▊ ▃ ▃ ▎
▗ ▅▆▆▅ ▌ ▆▆▅▆▙ ▌▗
▗ ▙ ▂ ▎▗ ▟
▅▆▆▆▇▇▇▇▇▇▇▆▆▅▄ ▇▅▅▅ ▙▆▇
▁▁▂▁ ▁▁
▖ ▖ ▂▂
▉ ▁ ▆▆ ▌ ▆ ▙▄ ▁▁
▙ ▉ ▃▖ ▟
▊ ▉ ▅▟ ▗▄
▊ ▉ ▗ ▏ ▇▆
▊ ▟ ▉ ▆ ▖
▊ ▉ ▌ ▂
▊ ▏ ▉ ▌ ▗ ▄▟
▊ ▆
2019-12-09 18:11:04 -06:00
fa7edf87c9
[bsearch] Massage API some more
2019-12-09 17:51:41 -06:00
70aa5071d8
[algs] Adjust return value of hb_ctz(0) to be 32 instead of 0
2019-12-09 17:48:10 -06:00
eefb78f674
Minor
2019-12-09 17:46:56 -06:00
9fb030585a
Rename start/end to first/last in RangeRecord
...
Because that's what they are.
2019-12-09 17:46:08 -06:00
9b1d5c4a59
[number] fix where strtod_l not available
2019-12-09 12:29:28 +03:30
5c8f960289
[number] minor, include the renamed header
2019-12-09 10:48:43 +03:30
48eef2724c
[algs/array] Consolidate the last two bsearch implementations!
...
Yay! Seems to work.
2019-12-06 05:04:11 +00:00
ed35dea8c0
Fourth try... sighs
2019-12-06 04:37:11 +00:00
9168310bb4
Fix build, third times...
2019-12-06 04:28:06 +00:00
34f5cc2cc8
Second try at fixing build
2019-12-06 04:09:33 +00:00
14ce5ab0b7
First try at fixing build errors
2019-12-06 03:54:46 +00:00
2274270c6a
[algs] Streamline bsearch some more
2019-12-06 03:42:21 +00:00
bd55d4b49f
[algs] Streamline bsearch() API more towards hb_array_t::bsearch_impl()
...
Preparing to merge the two finally!
2019-12-06 03:35:24 +00:00
fd6df520a1
[array] Isolate bsearch implementation more
2019-12-06 03:01:34 +00:00
06d3c2019f
[array] Simplify bfind() positioning
...
I had copied the old scheme from fontconfig's fccharset.c. I just
convinced myself that this change is correct and produces exact
same results. But I also am skeptical. Anyone else feel like
convincing themselves as well please?
2019-12-06 02:52:54 +00:00
d67ba649a3
Rename hb_array_t::in_range to hb_array_t::check_range
2019-12-06 02:27:23 +00:00
72d83a0280
Make hb_array_t::in_range similar to hb_sanitize_context_t::check_range
2019-12-06 02:27:23 +00:00
2dc20e632e
Implement fallback vertical shaping from Firefox
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/355
2019-12-05 15:28:42 +00:00
b6d0f1529d
[indic] Fix old-spec base-finding logic w vatu feature
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1587
2019-12-05 12:19:52 +00:00
0414341ac5
Prefer AAT shaping over OT if both available
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1529
2019-12-05 11:26:39 +00:00
82545c5e2b
more coding style fixes
2019-11-26 18:34:06 +00:00
2e7c1239c8
minor: coding style
2019-11-26 18:34:06 +00:00
ab525ac66d
fix HB_TINY buid
2019-11-26 18:34:06 +00:00
ff64652cf6
fix shape-fuzzer failure
2019-11-26 18:34:06 +00:00
a333b0f717
add hb-ot-cff1-std-str.hh to Makefile.sources
2019-11-26 18:34:06 +00:00
61707266a3
fix get_sid crash
2019-11-26 18:34:06 +00:00
4c4e08a1ef
add cff1::accelerator_t::fini
2019-11-26 18:34:06 +00:00
ff87465b40
add get_glyph_from_name & test. use hb_string_array
2019-11-26 18:34:06 +00:00
51e7728521
minor
2019-11-26 18:34:06 +00:00
6d9eb9c040
fixed failure with language-tags.tests
2019-11-26 18:34:06 +00:00
59fe379797
fixed hb-shape-fuzzer failures in get_sid
2019-11-26 18:34:06 +00:00
e26df436bc
fix test-ot-face crash
2019-11-26 18:34:06 +00:00
7b49042ef4
add cff1::get_glyph_name
2019-11-26 18:34:06 +00:00
ea8fdfa079
Merge branch 'master' into var-subset
2019-11-22 15:59:09 -08:00
d5338ba189
[ft] Add locking FT_Face API
...
Now that we mutex our internal FT_Face, share it with clients.
New API:
- hb_ft_font_lock_face()
- hb_ft_font_unlock_face()
2019-11-22 16:22:27 -05:00
e5c7ee9f75
[set] Fix undefined-behavior shift in _previous()
...
harfbuzz/src/hb-set.hh:138:43: runtime error: shift exponent 64 is too large for 64-bit type 'hb_set_t::page_t::elt_t' (aka 'unsigned long long')
2019-11-20 14:22:01 -05:00
5fddc5f169
Use foreach_cluster
2019-11-20 13:07:26 -05:00
e4a101ed38
[ft] Fix for HB_NO_VAR build
2019-11-19 20:04:00 -05:00
76c27462c2
Don’t modify a ccc to 6
...
ccc=6 will be used in Unicode 13.0.
2019-11-19 17:16:27 -05:00
8fdafee2a6
undef HB_STRING_ARRAY_LENG_NAME
2019-11-19 01:13:00 -05:00
5e9863f3c6
ARRAY_LENGTH fails with -Wglobal-constructors
2019-11-19 01:13:00 -05:00
a75983690d
calculate hb_string_array length automatically
2019-11-19 01:13:00 -05:00
57da16bc59
[cff] Check rcurveline and rlinecurve arguments
...
Make sure the number of arguments is not too many or too few, otherwise
skip the command.
2019-11-18 20:46:05 +02:00
9f1524ce83
[cff] Fix a typo in processing rlinecurve
...
We want to process all pairs of arguments except the last 6 as lines, so
should have been subtracting 6 here, otherwise if the number of
arguments happens to be multiples of 6 they will be all treated as
curves.
See https://github.com/harfbuzz/harfbuzz/pull/2016#issuecomment-554640098
2019-11-18 20:46:05 +02:00
78d5eca813
[set] Fix range-based-loop condition
...
Alternative to https://github.com/harfbuzz/harfbuzz/pull/2046
2019-11-18 13:09:29 -05:00
4dae7cee4b
[minor] Fix common typos: substition, the the.
...
s/substition/substitution/
s/the the/the/
2019-11-13 18:38:35 +03:30
e6351d9b2c
Add ms-use/IndicShapingInvalidCluster.txt
2019-11-11 14:51:34 -08:00
b372c3e956
Insert a dotted circle within <U+0B85, U+0BC2>
2019-11-11 14:51:34 -08:00
64a45be519
[ubsan] Don't decrease pointer if match_glyph_data is null ( #2048 )
...
Similar to fix on https://github.com/harfbuzz/harfbuzz/pull/2022
Fixes https://crbug.com/1023070
2019-11-09 12:25:33 +03:30
486754a888
[serialize] Extract iterable copy, copy_all
2019-10-31 13:31:11 -07:00
35218c488c
Minor
...
Allow empty HB_VAR_ARRAY definition. Though, doesn't compile with any
compiler I know of.
2019-10-31 13:19:44 -07:00
1a1d64bc6f
If applying morx, apply kern table even if GPOS is present and has kern
...
Since we won't be applying GPOS if morx...
To be adjusted as I receive more information from Ned. But for now
fixes this:
$ ./hb-shape GillSans.ttc Ty
[T=0+1109|y=1@-128,0+769]
Fixes https://github.com/harfbuzz/harfbuzz/issues/1982 for now.
2019-10-31 12:51:40 -07:00
3a74ee5282
2.6.4
2019-10-29 12:49:28 -07:00
3958f6fb23
Add in_range in hb_bytes_t to merge range_checker_t with it
2019-10-29 23:16:05 +03:30
aa3831e295
[glyf] Use contour_bounds_t::empty to simplify get_extents logic
2019-10-29 22:34:14 +03:30
d59ae5836d
[glyf] Refactor contour_bounds_t use to make its fields protected
2019-10-29 22:34:14 +03:30
773ee8041e
Merge pull request #2038 from ebraminio/glyf-contour
...
Remove contour_point_t so we won't need to zero its unused var
2019-10-29 10:58:56 -07:00
0efbda7a40
Remove contour_point_t so we won't need to zero its unused var
2019-10-29 21:03:26 +03:30
47b4074d5f
Merge pull request #2034 from khaledhosny/cmap-notdef
...
[cmap] Check GID before adding ranges in format 4 & 12
2019-10-29 03:16:34 -07:00
dd8a846037
Use proper y-scale factor for height value
2019-10-29 09:20:41 +00:00
7152ac3fcf
Fix build
...
$ make CPPFLAGS="-DHB_TINY -DHB_NO_OT_FONT" libharfbuzz-subset.la
2019-10-28 17:12:55 -07:00
dd288840d6
[cmap] Check GID before adding ranges in format 4 & 12
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2031
2019-10-29 02:09:13 +02:00
fd71c045b4
Hopefully fix up previous commit and bots
2019-10-28 17:06:53 -07:00
e832dc4c64
[config] Make HB_NO_ERRNO work with systems defining errno as a macro
2019-10-28 17:02:40 -07:00
ce11df1b5b
2.6.3
2019-10-28 14:46:59 -07:00
5a59de2b98
Actually add +hb_font_get_nominal_glyphs()
...
New API:
+hb_font_get_nominal_glyphs()
2019-10-28 14:46:59 -07:00
03028a5fe5
Revert "Don't include codepoint 0 in the results of collect_unicodes."
...
This reverts commit 14ad96ffbfhttps://github.com/harfbuzz/harfbuzz/issues/2031
2019-10-28 13:46:56 -07:00
14ad96ffbf
Don't include codepoint 0 in the results of collect_unicodes.
...
It is always assumed to be the notdef glyph.
2019-10-28 12:56:04 -07:00
aca6390281
[gpos] Don't move pointer when match_glyph_data is not set
2019-10-28 22:17:48 +03:30
defe9b6da0
crash fix : Heap-buffer-overflow READ 2
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18513
2019-10-25 13:09:47 -07:00
b2fcca6e14
fuzzer crash fix
...
https://oss-fuzz.com/testcase-detail/5643107869917184
2019-10-24 16:11:30 -07:00
5e489670e1
Remove hb-warning.cc
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/2005
2019-10-22 15:03:47 -07:00
05bcdb39d8
Add a specialization of array_t:hash for hb_bytes_t and hb_ubytes_t.
2019-10-22 13:33:50 -07:00
95ab110cd9
Optimize intersects_array to fix fuzzer timeout.
2019-10-22 13:33:50 -07:00
be5cdcdfa2
Store the hash value of a key in item_t in hb_map to reduce the number of hash computations.
2019-10-22 13:33:41 -07:00
b33a0d628e
fuzzer crash fix: Null-dereference WRITE
...
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=18363
2019-10-22 01:01:08 +03:30
1f0a9d9be9
[subset] GPOS Lookup Type 2: PairPos
2019-10-21 12:35:28 -07:00
b66094ada0
[subset] GSUB Lookup Type 6: ChainContextSubst
2019-10-18 16:52:55 -07:00
eff91bbb4b
Add missing pop() for the failure case of script subsetting.
2019-10-18 15:10:30 -07:00
eab191fd9c
Rewrite hash and == function for hb_array_t as a plain loop.
...
Profling showed that the current implementation were accounting for nearly all processing time in some cases. These implementations look to be about 10x faster.
2019-10-18 15:10:30 -07:00
831daf4c76
Enforce HB_MAX_LANGSYS limit during layout subsetting.
2019-10-18 15:10:30 -07:00
9871461bce
Enforce HB_MAX_SCRIPTS during subsetting of the script table.
2019-10-18 15:10:30 -07:00
029775bcbd
[buffer] Minor; improve HB_NO_BUFFER_MESSAGE
2019-10-17 10:00:40 -07:00
9a68e6b901
[doc] minor
...
Addresses https://github.com/harfbuzz/harfbuzz/pull/2013/files#r335196908
2019-10-16 13:28:15 +03:30
453050ad30
Merge remote-tracking branch 'upstream/master' into var-subset
2019-10-13 08:45:29 +03:30
b0b8551afc
[glyf] Use range_checker_t in composite_iter_t
2019-10-13 07:17:03 +03:30
06e35ce052
[glyf] minor
2019-10-13 07:17:03 +03:30
d13bb4bd94
[glyf] other cleanups
2019-10-13 07:17:03 +03:30
e7aa8c5d22
[glyf] Introduce glyf::Glyph, a hb_bytes_t/GlyphHeader pair
2019-10-13 07:17:03 +03:30
546ffc9faf
[glyf] minor
2019-10-13 07:17:03 +03:30
4299ea266e
[glyf] Move get_contour_points to GlyphHeader
2019-10-13 07:17:03 +03:30
b918cd8c76
Document hb_feature_t.
...
This documents hb_feature_t. This is motivated mostly by the ambiguity
of the units for 'start' and 'end' (clusters) and whether they are
inclusive or exclusive. This also documents that for lookup type 3 the
value is the one based index into the alternates and that in a list of
features later feature values override previous feature values with the
same tag.
2019-10-11 20:54:06 +03:30
e637a4b3de
Merge pull request #2012 from harfbuzz/lepcha-oo
...
Reorder U+1C29 LEPCHA VOWEL SIGN OO
2019-10-11 10:28:58 +07:00
670fec231d
Minor, add a zero length tolerant memset, hb_memset
2019-10-10 09:21:08 +03:30
e4464f4484
Reorder U+1C29 LEPCHA VOWEL SIGN OO
2019-10-09 20:55:52 -04:00
e17e744300
Convert existing uses of serialize_append in gsub subsetting to use subset_offset_array.
2019-10-09 13:52:04 -07:00
36f18cecbb
Add subset_offset_array helper function which simplifies subsetting offset arrays during stream operations.
2019-10-09 13:52:04 -07:00
dc45f22521
[ot-metrics] Don't use mixed scaled and not scaled for generating extents
2019-10-08 23:27:39 +03:30
b068e25f8f
[glyf] Address Behdad's reviews
...
Addresses https://github.com/harfbuzz/harfbuzz/pull/1999#issuecomment-539298559
* Don't check against Null pool
* Remove cryptic _tt suffix
2019-10-08 16:29:19 +03:30
6961766db2
[glyf] fix scaling direction
2019-10-08 16:26:48 +03:30
0527fda4c7
minor
2019-10-08 16:19:39 +03:30
b2628f1a3e
[glyf] Move glyph bytes drop hints logic to GlyphHeader
2019-10-08 15:40:29 +03:30
1fb9c3b646
[glyf] Implement depth limit for add_gid_and_children
2019-10-08 15:40:29 +03:30
be0eddd418
[glyf] Move add_gid_and_children to glyf table
2019-10-08 15:40:29 +03:30
c7621cf211
Minor, replace hb_set_add with private API
2019-10-08 15:40:29 +03:30
ad86806dcb
[glyf] Move subset related methods inside GlyphHeader
2019-10-08 15:40:29 +03:30
7839e23558
[glyf] minor
2019-10-08 15:40:29 +03:30
cbefbb2439
[glyf] Move padding removal logic to GlyphHeader
2019-10-08 15:40:29 +03:30
1ab8f9aa7a
[glyf] minor
2019-10-08 15:40:29 +03:30
13fb5612ad
[glyf] Aggregate get_offsets uses
2019-10-08 15:40:29 +03:30
5179b96958
[cff] minor on number_t
2019-10-08 11:11:18 +03:30
d73cdcf361
[ot-font] Apply font scaling before turning to int
2019-10-08 11:11:18 +03:30
d7df7db160
Merge remote-tracking branch 'upstream/master' into var-subset
2019-10-06 17:18:59 +03:30
74a2dbbced
minor
2019-10-06 17:18:55 +03:30
f2339964b7
[glyf] minor, remove GlyphHeader::simple_* helpers
2019-10-06 16:58:38 +03:30
2d7ca6a76a
[glyf] Move get_instruction_length inside GlyphHeader struct
2019-10-06 16:58:38 +03:30
50aef4d7f8
[glyf] cleanup
2019-10-06 16:58:38 +03:30
ee3f4630d7
[glyf] Remove get_composite_iter and refactor bytes_for_glyph for shape uses
2019-10-06 16:58:38 +03:30
8378ab96e2
[glyf] Rewrite composite iterator to new iterators convention
2019-10-06 13:49:45 +03:30
100dbccaa5
Merge remote-tracking branch 'upstream/master' into var-subset
2019-10-06 09:18:22 +03:30
21c80d955f
[gvar] minor
2019-10-06 08:59:12 +03:30
5752863640
[glyf][gvar] Make HB_NO_VAR buildable
2019-10-06 08:59:12 +03:30
8e33510343
[gvar] minor
2019-10-06 08:59:12 +03:30
b3afa81644
[glyf] Use common convention of other tables access, format
2019-10-06 08:59:12 +03:30
88bd342c0f
[glyf] minor
2019-10-06 08:59:12 +03:30
ee7610181c
[hmtx] Use more conventional internal API style
2019-10-06 08:59:12 +03:30
c9577a630f
[hmtx] Use more optimal way to access glyf table
2019-10-06 08:59:12 +03:30
b9ff43c162
Implement gvar table and variable glyf
...
Split from Ariza's "[subset] TrueType/CFF2 variable font" work on #1594
2019-10-06 08:58:40 +03:30
79ec65ae10
[ot-font] Use var vmtx side bearing in calculating v-origin
2019-10-03 14:27:51 +03:30
19d45dcab7
Merge remote-tracking branch 'upstream/master' into var-subset
2019-10-03 13:39:17 +03:30
3fd555be54
[hmtx] Prepare to fix and minor fixes
2019-10-03 13:34:43 +03:30
6d09b5a8a0
Implement hmtx/vmtx metrics read from hvar/vvar
2019-10-03 13:34:43 +03:30
2d7221a0e3
[cff] minor
2019-10-01 15:05:02 +03:30
0558413f27
Minor, tweak spaces
2019-10-01 13:50:11 +03:30
51b720f686
Fix -Wsizeof-array-div clang warning
2019-10-01 12:40:41 +03:30
faace9437e
Merge pull request #1807 from harfbuzz/subset-varstore
...
VariationStore serializer
2019-09-30 13:34:05 -07:00
e48ef0804a
2.6.2
2019-09-30 12:39:06 -07:00
d6ad613159
[docs] Misc fixes
2019-09-30 10:40:25 -07:00
2dce85ed06
[icu] Remove HB_ICU_STMT ( #1993 )
...
And ignore extra semicolon error to ICU versions < 65
2019-09-26 10:45:59 -07:00
d6a83abd6a
Define HB_UNUSED for clang
2019-09-26 14:12:20 +03:30
c4567968cd
[dwrite] Fix extra semicolon issue
2019-09-26 13:05:27 +03:30
b0c3eb06b6
[subset] GPOS Lookup Type 3: CursivePos
2019-09-25 05:43:25 +09:00
68d39ea486
Revert previous change and fix -Wrange-loop-analysis complains
2019-09-24 13:52:46 +03:30
cbc0646a6c
Minor, normalize for each calls
2019-09-24 12:09:20 +03:30
22b6c6a5c7
[serialize] use for each as #resolve_links, format
2019-09-24 12:06:28 +03:30
512551f276
memory leak fix in serializer ( #1988 )
2019-09-23 17:28:16 -07:00
f0a7677993
[gpos] minor
2019-09-23 21:09:39 +03:30
035ec3d1b4
[cmap] remove has_format14, minor format
...
fixes #1986
2019-09-23 20:51:43 +03:30
c1a585fab0
[gpos] minor
2019-09-21 23:36:29 +04:30
d87d38998a
Fix clang -Wrange-loop-analysis complains
...
./hb-ot-layout-gpos-table.hh:674:43: error: loop variable '_' is always a copy because the range of type 'hb_zip_iter_t<hb_iter_type<hb_array_t<const OT::IntType<unsigned short, 2> > &>, hb_iter_type<hb_array_t<const OT::IntType<unsigned short, 2> > &> >' (aka 'hb_zip_iter_t<hb_array_t<const OT::IntType<unsigned short, 2> >, hb_array_t<const OT::IntType<unsigned short, 2> > >') does not return a reference [-Werror,-Wrange-loop-analysis]
for (const hb_pair_t<Value, Value>& _ : hb_zip (val_iter, first_val_iter))
^
./hb-ot-layout-gpos-table.hh:674:12: note: use non-reference type 'hb_pair_t<OT::Value, OT::Value>' (aka 'hb_pair_t<IntType<unsigned short, 2>, IntType<unsigned short, 2> >')
for (const hb_pair_t<Value, Value>& _ : hb_zip (val_iter, first_val_iter))
and
In file included from hb-subset.cc:44:
./hb-ot-vorg-table.hh:87:34: error: loop variable '_' is always a copy because the range of type 'hb_map_iter_t<hb_filter_iter_t<hb_sorted_array_t<const OT::VertOriginMetric>, const hb_set_t *, OT::HBGlyphID OT::VertOriginMetric::*, nullptr>, (lambda at ./hb-ot-vorg-table.hh💯 15), hb_function_sortedness_t::NOT_SORTED, nullptr>' does not return a reference [-Werror,-Wrange-loop-analysis]
for (const VertOriginMetric& _ : it)
^
./hb-ot-vorg-table.hh:113:17: note: in instantiation of function template specialization 'OT::VORG::serialize<hb_map_iter_t<hb_filter_iter_t<hb_sorted_array_t<const OT::VertOriginMetric>, const hb_set_t *, OT::HBGlyphID OT::VertOriginMetric::*, nullptr>, (lambda at ./hb-ot-vorg-table.hh💯 15), hb_function_sortedness_t::NOT_SORTED, nullptr>, nullptr>' requested here
vorg_prime->serialize (c->serializer, it, defaultVertOriginY);
^
./hb-ot-vorg-table.hh:87:10: note: use non-reference type 'OT::VertOriginMetric'
for (const VertOriginMetric& _ : it)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-09-21 17:52:01 +04:30
6e42a418c8
Minor, turn more of hb_apply to for each
2019-09-21 17:52:01 +04:30
385741d565
[cmap] Turn hb_apply into foreach where possible
2019-09-21 15:33:02 +04:30
1023c2cc6d
[cmap] minor
2019-09-21 15:33:02 +04:30
ead46eefe3
minor, use internal API instead public hb_set_has
2019-09-21 15:33:02 +04:30
d8af4e7701
[cmap] minor, turn 8 spaces to tab
2019-09-21 15:33:02 +04:30
4315666283
[subset] updates according to review comments
2019-09-20 07:55:11 +09:00
2583afa0eb
[subset] subsetting cmap14
2019-09-20 07:55:11 +09:00
078ddbd0f6
[subset] glyph closure for CMAP14
2019-09-20 07:55:11 +09:00
bbe878006d
Avoid bitwise negate of enum value
...
Fixes this -fno-sanitize-recover=undefined fail,
hb-ot-map.hh:188:1: runtime error: load of value 4294967294, which is not a valid value for type 'hb_ot_map_feature_flags_t'
#0 0x7f62bfa9b227 in operator&=(hb_ot_map_feature_flags_t&, hb_ot_map_feature_flags_t) /home/ebrahim/Desktop/harfbuzz/src/./hb-ot-map.hh:188:1
#1 0x7f62bfa9b227 in hb_ot_map_builder_t::compile(hb_ot_map_t&, hb_ot_shape_plan_key_t const&) /home/ebrahim/Desktop/harfbuzz/src/hb-ot-map.cc:194
#2 0x7f62bface650 in hb_ot_shape_planner_t::compile(hb_ot_shape_plan_t&, hb_ot_shape_plan_key_t const&) /home/ebrahim/Desktop/harfbuzz/src/hb-ot-shape.cc:108:7
#3 0x7f62bfacec1e in hb_ot_shape_plan_t::init0(hb_face_t*, hb_shape_plan_key_t const*) /home/ebrahim/Desktop/harfbuzz/src/hb-ot-shape.cc:225:11
#4 0x7f62bfae1318 in hb_shape_plan_create2 /home/ebrahim/Desktop/harfbuzz/src/hb-shape-plan.cc:232:7
#5 0x7f62bfae1d2a in hb_shape_plan_create_cached2 /home/ebrahim/Desktop/harfbuzz/src/hb-shape-plan.cc:489:33
#6 0x7f62bfae2527 in hb_shape_full /home/ebrahim/Desktop/harfbuzz/src/hb-shape.cc:135:33
#7 0x55ed360b6588 in shape_options_t::shape(hb_font_t*, hb_buffer_t*, char const**) /home/ebrahim/Desktop/harfbuzz/util/./options.hh:242:10
#8 0x55ed360b5d9c in shape_consumer_t<output_buffer_t>::consume_line(char const*, unsigned int, char const*, char const*) /home/ebrahim/Desktop/harfbuzz/util/./shape-consumer.hh:67:19
#9 0x55ed360b549f in main_font_text_t<shape_consumer_t<output_buffer_t>, 2147483647, 0>::main(int, char**) /home/ebrahim/Desktop/harfbuzz/util/./main-font-text.hh:81:16
#10 0x55ed360b4e23 in main /home/ebrahim/Desktop/harfbuzz/util/hb-shape.cc:189:17
#11 0x7f62bf104ee2 in __libc_start_main (/usr/lib/libc.so.6+0x26ee2)
#12 0x55ed3608f7ad in _start (/home/ebrahim/Desktop/harfbuzz/util/.libs/lt-hb-shape+0xd7ad)
2019-09-18 23:16:52 +04:30
e6909ee58d
minor
2019-09-18 23:16:52 +04:30
bb41b74fd1
Don't rely on undefined left shift of negative value behavior
...
Fixes this -fno-sanitize-recover=undefined check,
hb-ft.cc:869:27: runtime error: left shift of negative value -16384
#0 0x7ff8f47da843 in hb_ft_font_set_funcs /home/ebrahim/Desktop/harfbuzz/src/hb-ft.cc:869:27
#1 0x55f20a66c7d6 in font_options_t::get_font() const /home/ebrahim/Desktop/harfbuzz/util/options.cc:731:3
#2 0x55f20a668c1f in shape_consumer_t<output_buffer_t>::init(hb_buffer_t*, font_options_t const*) /home/ebrahim/Desktop/harfbuzz/util/./shape-consumer.hh:47:42
#3 0x55f20a668441 in main_font_text_t<shape_consumer_t<output_buffer_t>, 2147483647, 0>::main(int, char**) /home/ebrahim/Desktop/harfbuzz/util/./main-font-text.hh:75:14
#4 0x55f20a667f91 in main /home/ebrahim/Desktop/harfbuzz/util/hb-shape.cc:180:21
#5 0x7ff8f3df7ee2 in __libc_start_main (/usr/lib/libc.so.6+0x26ee2)
#6 0x55f20a6427ad in _start (/home/ebrahim/Desktop/harfbuzz/util/.libs/lt-hb-shape+0xd7ad)
2019-09-18 23:16:52 +04:30
b73313ade7
Don't seek of out-of-bound value even if the result is not used
...
Fixes this -fno-sanitize-recover=undefined fail,
/set/iter: hb-algs.hh:1016:60: runtime error: index 4294967295 out of bounds for type 'unsigned long long const[8]'
#0 0x4d1e09 in hb_vector_size_t<unsigned long long, 64u>::operator[](unsigned int) const /home/user/code/harfbuzz/src/./hb-algs.hh:1016:60
#1 0x4d8b5f in hb_set_t::page_t::previous(unsigned int*) const /home/user/code/harfbuzz/src/./hb-set.hh:139:53
#2 0x4d0ada in hb_set_t::previous(unsigned int*) const /home/user/code/harfbuzz/src/./hb-set.hh:602:36
#3 0x4cd76f in hb_set_previous /home/user/code/harfbuzz/src/hb-set.cc:494:15
#4 0x4ca8af in test_set_iter /home/user/code/harfbuzz/test/api/test-set.c:310:3
#5 0x7f3a4f3e0f49 (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72f49)
#6 0x7f3a4f3e0e7a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72e7a)
#7 0x7f3a4f3e1121 in g_test_run_suite (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73121)
#8 0x7f3a4f3e1140 in g_test_run (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73140)
#9 0x4c8894 in hb_test_run /home/user/code/harfbuzz/test/api/./hb-test.h:88:10
#10 0x4c8894 in main /home/user/code/harfbuzz/test/api/test-set.c:408:10
#11 0x7f3a4e3d2b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
#12 0x41e7d9 in _start (/home/user/code/harfbuzz/test/api/test-set+0x41e7d9)
2019-09-18 23:16:52 +04:30
d8af9ee017
Don't rely on nullptr deref recovery
...
Fixes this -fno-sanitize-recover=undefined fail,
/types/language: hb-common.cc:385:20: runtime error: member access within null pointer of type 'const struct hb_language_impl_t'
#0 0x4caa34 in hb_language_to_string /home/user/code/harfbuzz/src/hb-common.cc:385:20
#1 0x4c9be8 in test_types_language /home/user/code/harfbuzz/test/api/test-common.c:205:3
#2 0x7f9557e72f49 (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72f49)
#3 0x7f9557e72e7a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72e7a)
#4 0x7f9557e73121 in g_test_run_suite (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73121)
#5 0x7f9557e73140 in g_test_run (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73140)
#6 0x4c88a3 in hb_test_run /home/user/code/harfbuzz/test/api/./hb-test.h:88:10
#7 0x4c88a3 in main /home/user/code/harfbuzz/test/api/test-common.c:224:10
#8 0x7f9556e64b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
#9 0x41e7d9 in _start (/home/user/code/harfbuzz/test/api/test-common+0x41e7d9)
2019-09-18 23:16:52 +04:30
bfb155a5f1
Don't call memset when length is zero
...
Fixes this -fno-sanitize-recover=undefined check,
/buffer/positions/empty: hb-buffer.cc:327:11: runtime error: null pointer passed as argument 1, which is declared to never be null
/usr/include/string.h:60:62: note: nonnull attribute specified here
#0 0x4cf31c in hb_buffer_t::clear_positions() /home/user/code/harfbuzz/src/hb-buffer.cc:327:3
#1 0x4d4dd4 in hb_buffer_get_glyph_positions /home/user/code/harfbuzz/src/hb-buffer.cc:1418:13
#2 0x4cb553 in test_buffer_positions /home/user/code/harfbuzz/test/api/test-buffer.c:305:3
#3 0x7f324187bf49 (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72f49)
#4 0x7f324187be7a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72e7a)
#5 0x7f324187be7a (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72e7a)
#6 0x7f324187c121 in g_test_run_suite (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73121)
#7 0x7f324187c140 in g_test_run (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73140)
#8 0x4c8bd3 in hb_test_run /home/user/code/harfbuzz/test/api/./hb-test.h:88:10
#9 0x4c8bd3 in main /home/user/code/harfbuzz/test/api/test-buffer.c:884:10
#10 0x7f324086db96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
#11 0x41e919 in _start (/home/user/code/harfbuzz/test/api/test-buffer+0x41e919)
2019-09-18 23:16:52 +04:30
c930ae2bd8
Avoid stdint.h in Kernel module compiles
2019-09-17 20:58:32 +04:30
412d6cac3a
Extract an avoid errno compile flag
2019-09-17 20:58:13 +04:30
8a16d6f1c1
[doc] fix minor typo
2019-09-15 20:43:33 +04:30
f3214df6f6
[coretext] Fix double promotion warnings by making casts explicit
2019-09-14 11:55:53 +04:30
6e4736a3c5
[name] Undef entry_{index,score} to avoid collision in amalgam builds
2019-09-14 11:55:53 +04:30
d512087e4d
Rename GlyphID to HBGlyphID
...
Avoid collision with macOS's ATSUnicodeTypes.h GlyphID
2019-09-14 11:55:53 +04:30
229ef1d29d
Rename Fixed to HBFixed
...
Fixes(!!) https://github.com/harfbuzz/harfbuzz/issues/1966
2019-09-10 10:31:07 -07:00
170b5dd856
[aat] Minor
2019-09-09 10:52:54 -04:00
a0695687eb
[aat] Minor
2019-09-09 10:52:54 -04:00
4905a2198b
[number] Add static to hb-number-parser.hh functions
2019-09-09 13:14:42 +04:30
30e5cdfbf1
[number] Optimize _pow10 constants ( #1963 )
2019-09-09 00:28:16 +04:30
3f2cdf07a4
Change HB_VAR_ARRAY to 1 again
...
To fix MSVC bots, while I work on changing this to 0 permanently.
2019-09-08 15:08:02 -04:00
39cf8e21be
[number] Add overflow checks used to be done in parse_bcd
...
Which were removed in 1083df8
2019-09-07 15:27:30 +04:30
47d82713a1
Replace strtod with a ragel implementation
...
Use a ragel based number parser when strtod_l couldn't be found
as libc's strtod may is locale sensetivity which we need to not.
2019-09-07 15:02:52 +04:30
80613e5b9e
Minor, remove unused header
2019-09-07 14:25:54 +04:30
5902198cee
[kerx] Fix offset issue in kern format 2
...
Fixes tests with HB_VAR_ARRAY != 1, as done in previous commit.
2019-09-06 21:36:31 -04:00
861547d531
Change HB_VAR_ARRAY from 1 to 0
...
Going to see which compilers it breaks and special-case those...
2019-09-06 16:55:00 -04:00
0e294c455e
Rename VAR to HB_VAR_ARRAY
2019-09-06 16:54:27 -04:00
c379faed2b
Fix a few struct size declarations
...
Was wrong. As excercised by defining VAR to other than 1 in hb.hh.
2019-09-06 16:41:12 -04:00
3aceee2527
Revert "[null] Silence undefined-behavior complaints with too-small null bytes"
...
This reverts commit 911c76abcd
2019-09-06 12:17:18 -04:00
911c76abcd
[null] Silence undefined-behavior complaints with too-small null bytes
...
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1577584
2019-09-06 11:53:11 -04:00
3c81246f66
[subset] Use newer iter tools in SinglePosFormat1
2019-09-04 11:28:40 -04:00
9510e918f7
[iter] Partialize hb_zip()
2019-09-04 11:28:40 -04:00
cad698568a
Use roundf to fix cast to int difference of msys2 w64
2019-09-04 11:18:37 +04:30
1083df8b80
Use hb_parse_double in CFF::dict_opset_t::parse_bcd
2019-09-04 02:04:09 +04:30
57f88e11d4
[number] Turn hb_parse_float into hb_parse_double
2019-09-04 02:04:09 +04:30
65690b5a4b
[number] Add whole buffer check and test it
2019-09-04 02:04:09 +04:30
3661eb6105
Don't check null terminaion of source in hb_codepoint_parse
...
This isn't what intended originally, just checking if consumed
all the buffer is enough.
2019-09-04 02:04:09 +04:30
3a16272750
[test] resolve msvc complain on signedness comparing
2019-09-04 02:04:09 +04:30
005389beb5
Use hb_parse_uint in deserializer token parser
2019-09-04 02:04:09 +04:30
3d5b1df7ab
[number] Add test
2019-09-04 02:04:09 +04:30
b5e6805ee7
[number] Minor tweak on parser related codes
2019-09-04 02:04:09 +04:30
e2cecf1f34
[number] Remove parsing code duplication of the calls using lambda
2019-09-04 02:04:09 +04:30
a77bb7eb41
Move hb_codepoint_parse to hb_parse_uint
2019-09-04 02:04:09 +04:30
43372fbb5a
Merge and aggregate number parsing logics to form hb-number
2019-09-04 02:04:09 +04:30
d50d2fcbc7
Fallback if roundf didn't exist, like in dietlibc ( #1953 )
2019-09-02 19:32:05 -05:00
d3b984d379
Revert in-house pow10 ( d80a3ea) and fix oss-fuzz/16922
...
Probably can be fixed but merging it was wrong so let's revert.
2019-09-02 18:28:03 +04:30
41d6e95b0d
[subset] Use internal API of hb_set_t
2019-09-02 01:58:37 +04:30
8ccf328d54
[subset] Run once for a tag
2019-09-02 01:09:41 +04:30
0954c8f7a0
[ft] Prefer symbol cmap subtable if found ( #1948 )
...
Similar to commit d304d60e4d
2019-09-01 10:09:07 -05:00
d80a3ea983
[cff] Implement in-house power of 10
...
A minimal power only for natural numbers exponents of ten, for portability.
Found the idea in Tcl/Tk but wrote it myself after weeks and it turned out
being a different implementation, reverse direction, constexpr, etc.
2019-09-01 14:05:16 +04:30
f441a7c008
Don't allow reference blob be accessed using empty tag in hb_face_reference_table ( #1947 )
2019-08-31 16:48:09 -05:00
c9eb913f4c
[iter] Simplify hb_chop()
2019-08-31 15:21:02 -05:00
67ec9fa9e4
[iter] Add hb_chop()
2019-08-31 14:51:49 -05:00
5828d8e83c
[iter] Add hb_take() specialization for arrays
2019-08-31 14:36:44 -05:00
398b296f3b
[iter] Add hb_len()
2019-08-31 12:44:24 -05:00
875131d478
[iter] Add hb_take()
2019-08-31 12:42:52 -05:00
1f88dae9f5
[iter] Make iota() accept invokable for increasing to next item
2019-08-31 12:24:56 -05:00
3bc86fb237
[algs] Fix hb_inc/dec signature
2019-08-31 12:24:56 -05:00
b1378d8a21
[iter] Add hb_repeat()
2019-08-31 12:24:56 -05:00
966a18b92a
[iter] Remove some &&
2019-08-31 12:24:56 -05:00
de45775c37
[iter] Use hb_ridentity instead of lazy +
2019-08-31 12:24:56 -05:00
ce4d63beec
[iter] Separate hb_iota implementation from hb_range
2019-08-31 12:24:56 -05:00
814dc3cbe5
[iter] Rename
...
Moving towards making iota useful for non-integers.
2019-08-31 12:24:56 -05:00
2d5643aed4
[algs] Add hb_inc() and hb_dec())
2019-08-31 12:24:56 -05:00
7eafe94705
Revert "[array] Add chop()"
...
This reverts commit 545fe9d9f0
2019-08-31 12:24:56 -05:00
28c8dcb53f
[subset] minor
2019-08-31 12:27:14 +04:30
545fe9d9f0
[array] Add chop()
...
Takes n, and returns iterator of iterators that contain up to
n items each. Basically cuts the array into subarrays of size n.
The last sub-array might contain fewer.
Ideally this should become a generic iter tool, not array-specific,
so we can use it in GPOS to chop a value matrix into rows and elements.
2019-08-29 15:48:21 -07:00
c72589f13f
[iter] Change item_size to get_item_size()
...
By moving access to hb_static_size(Type) into a function instead of
a class-const, we can refer to iter types of incomplete types, which
come handy when a method of hb_array_t wants to return iterator
of hb_array_t. That kind of stuff. Next commit needs this to
build on clang...
2019-08-29 15:45:21 -07:00
d58e248df6
[array] Add truncate() method
2019-08-29 15:23:48 -07:00
a06edf1430
[array] Use injected class name more
2019-08-29 15:21:18 -07:00
e0e0c8c109
Minor
2019-08-29 14:58:16 -07:00
0313ef86e3
bug fix in optimizing coverage table format ( #1942 )
...
We are comparing number of shorts, NOT number of bytes.
2019-08-29 14:09:05 -07:00
38f95baf6b
[subset] in SingleSubst subsetting, check for substitute in glyphset
...
That matches what fonttools does and allows for specifying exact
glyphset for subset.
2019-08-29 13:40:46 -07:00
8106ba7f88
[glyf] Reapply use of hb_bytes_t.as<GlyphHeader> ()
2019-08-29 20:33:38 +04:30
9e80fc6836
[glyf] Reapply common moving logic to GlyphHeader struct
2019-08-29 20:17:50 +04:30
852c9aa0e3
[glyf] Reapply style fixes
2019-08-29 20:12:53 +04:30
9ff32b79b3
Merge remote-tracking branch 'upstream/master' into glyf-rebase
2019-08-29 19:53:18 +04:30
499029644f
[gsub] Fix clang's semicolon complains
2019-08-29 15:09:39 +04:30
875985cd48
[subset] Don't allow malicious fonts to insert unlimited table headers
...
Fixes https://crbug.com/oss-fuzz/16810
2019-08-29 14:51:22 +04:30
dc9222b1dd
[subset] Implement AlternateSubst subsetting
2019-08-28 15:38:46 -07:00
23681b6da4
Minor
2019-08-28 15:30:37 -07:00
33c8e2303c
[subset] Implement MultipleSubst subsetting
2019-08-28 15:25:55 -07:00
5c43a7ba7e
[GSUB] Use dagger in Ligature::intersects()
2019-08-28 15:10:38 -07:00
b8c642c1f5
Minor
2019-08-28 15:06:45 -07:00
dc2c9aa0c3
Rename
2019-08-28 15:05:49 -07:00
bc5ef765a8
[subset] Subset ligature substitutes!
...
Test with:
$ ./hb-subset -o out.ttf NotoSansArabic-Regular.ttf --drop-tables= سلام && ./hb-view out.ttf سلام
2019-08-28 14:52:13 -07:00
42d887bd22
Beef up HeadlessArrayOf<>
...
Should be merged with ArrayOf...
https://github.com/harfbuzz/harfbuzz/issues/1937
2019-08-28 14:47:14 -07:00
3ca809e362
Add ArrayOf::pop()
2019-08-28 13:49:35 -07:00
307bd6d79f
Add arithmetic operators to IntType<>
2019-08-28 13:49:17 -07:00
2e1d00c85b
[debug] Minor
2019-08-28 13:49:04 -07:00
062cad5e28
Add ArrayOf::serialize_append
2019-08-28 13:48:55 -07:00
b66076812d
Adjustments to the generated Indic table output ( #1936 )
...
* Add empty parentheses after print call
* Minor: newlines. Move #pragma pop down one; #endif up one
* Adjust #define ISC/IMC output
* Regenerate Indic table
2019-08-28 04:31:27 -07:00
4ef08dbce1
Use hb_bytes_t as<T> in hb_blob_t
2019-08-27 17:38:09 +04:30
dce42cef2b
[glyf] Move GlyphHeader::from_bytes to hb_bytes_t, introduce .as<T> ()
2019-08-27 17:38:09 +04:30
6e82d59b4f
[glyf] Revert the way indexToLocFormat is set
2019-08-27 12:33:42 +04:30
88e9db19d2
[subset] Remove subset table size assertion
...
As https://github.com/harfbuzz/harfbuzz/pull/1930#issuecomment-525036802
2019-08-27 02:44:26 +04:30
a0b4ac4dce
Turn 8 spaces to tab across the project
...
According to the current code style of the project
2019-08-27 02:40:41 +04:30
269a120f13
[subset] Raise the bar in new vs old table size
...
https://crbug.com/oss-fuzz/16740
This is actually an interesting thing that {h,v}mtx allocates as
much as a font pretends to have glyphs but the solution is not
that obvious as regular fonts can have less than actually containing
metrics in their {h,v}mtx. This change raises the bar to consider this
hmtx 4 byte for every glyph case.
Initially we wanted to just find things allocating crazy amount of
memory but having the assert has led to interesting findings also
so let's don't remove the assert and see what we can find elsewhere.
2019-08-25 20:37:00 +04:30
2f8e823331
[glyf] minor
2019-08-25 12:37:40 +04:30
07e467a30e
[glyf] Move GlyphHeader size checking to a static method
2019-08-25 01:10:37 +04:30
139d14dc89
[glyf] Move GlyphHeader related logics to its, making its fields protected
2019-08-24 17:50:25 +04:30
d57819cbdb
[glyf] format source
2019-08-24 17:00:54 +04:30
2aef3013f3
[subset] Consider instruction length place itself
...
Now fixes https://crbug.com/oss-fuzz/16639 completely
2019-08-24 16:11:21 +04:30
922898c814
[subset] Fail on table grow more than 16x+4096
2019-08-24 16:11:21 +04:30
28aba780c4
[subset] Fix blob leak of _subset2 when returns early
...
Fixes https://crbug.com/oss-fuzz/16639
2019-08-24 16:11:21 +04:30
541f3c2d7d
[debug] Fix extra semicolon issue
...
https://github.com/harfbuzz/harfbuzz/issues/1923
2019-08-23 12:25:58 -07:00
4dcaca8411
Whitespace
2019-08-23 12:24:15 -07:00
569426d861
[debug] Fix build with HB_DEBUG
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1923
2019-08-23 11:54:39 -07:00
be97e9d678
2.6.1
2019-08-22 15:52:24 -07:00
d304d60e4d
[ot-font] Prefer symbol cmap subtable if found
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1918
Hopefully doesn't break anyone...
2019-08-21 12:30:22 -07:00
2a3d4987a7
Remove hb_directwrite_shape_experimental_width public API
...
I had specially exposed the API as I didn't know how to embed harfbuzz
easily elsewhere but now with harfbuzz.cc it has become very easy
and I don't like to see its use anywhere as it has a bad naming and
its Kashida adding is bogus and only useful to check where it should
be added, not visually useful however.
2019-08-21 03:02:01 +04:30
aaa85931f3
[font] Update multipliers when creating sub_font
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1910
2019-08-20 13:06:10 -07:00
bbad1b8298
[trak] minor, use roundf instead round to normalize the use
...
The change to `round` wasn't intended
2019-08-20 14:46:48 +04:30
37de38adea
Merge branch 'master' into remove-coretext-96dpi-assumption
2019-08-20 12:59:33 +04:30
5ee1e451cf
Minor touch-up for recent change
2019-08-19 14:23:17 -07:00
3348992844
[avar] Implement inverse map, unmap
2019-08-19 14:22:15 -07:00
981f5a54c3
[fvar] Implement inverse normalize, unnormalize
2019-08-19 14:22:15 -07:00
dcb4cd400f
Minor
2019-08-19 11:35:37 -07:00
ca54440324
Remove continuous development helper script
...
Not have used it personally for a long time, lets remove it
2019-08-18 11:58:04 +04:30
40aef1b473
[ot-shape] Keep horizontal_features array sorted
2019-08-16 02:17:32 +02:00
da5118da77
[ot-shape] Enable abvm/blwm features by default
...
Core Text seems to apply them to Latin text, but Uniscribe doesn’t.
See https://github.com/harfbuzz/harfbuzz/pull/1908#issuecomment-521819343
2019-08-16 02:17:32 +02:00
2164bd6f29
[ot-shape] Enable dist feature by default ( #1908 )
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1907
2019-08-16 00:28:41 +02:00
bc27f86ffe
Move HB_NO_VAR to a better place in hb-font.cc
...
Needed for other works
2019-08-14 22:37:00 +04:30
1cc844da66
minor
...
Use hb_font_t coords directly
2019-08-14 19:10:02 +04:30
6a194b6876
Minor, remove trailing spaces in hb-font.{cc,h} as .editorconfig
2019-08-14 18:49:57 +04:30
3ae44645d6
Fix caret_count value when AAT is disabled
...
Set caret_count to zero as that is what we want to happen inside lcar when
there is no result.
2019-08-14 17:58:30 +04:30
a5aa67b9f2
[lcar] Use multiformat convention
2019-08-14 17:58:30 +04:30
bfffe85dd7
[opbd] Use multiformat convention on the table
2019-08-14 15:45:57 +04:30
d6206dbcc4
[opbd] Turn OpticalBounds fields to FWORD
2019-08-14 15:45:57 +04:30
6461143b44
2.6.0
2019-08-13 22:20:54 -07:00
e56d4ff43b
Rename hb_ot_meta_get_entries() to +hb_ot_meta_get_entry_tags()
2019-08-13 21:02:47 -07:00
aade9b70aa
[pool] Fix alignment assertion
...
I *think* it should fix https://github.com/harfbuzz/harfbuzz/issues/1901
Ie. if on a system, alignof(void*) < sizeof(void*)...
2019-08-13 16:10:03 -07:00
60d9f00975
Implement opbd table parsing
...
https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6opbd.html
2019-08-11 16:15:19 +04:30
8762676e34
[os2] Replace null pool addr compare by checking vital fields ( #1896 )
2019-08-10 01:26:55 +04:30
1f926fb2b6
[fvar] Use roundf instead hardcoding round logic
2019-08-09 11:05:48 -07:00
60485ab047
[os2] Get defined lower/upper optical size
2019-08-07 23:23:06 +04:30
321d5588d4
[subset] Add subsetting for GPOS Lookup Type 1: Single Adjustment Positioning Subtable
2019-08-06 14:06:35 -07:00
37572882e7
[subset] cmap table to use _subset2 and new iterator frameworks
2019-08-05 11:26:34 -07:00
5848c890cf
[metrics] Add metrics tags documentation
2019-08-03 14:19:28 +04:30
4d1872b8e0
[base] Add documentation for baseline tags from ot spec
2019-08-03 14:06:46 +04:30
bbeee84a7f
[meta] Add metadata tags documentation from ot spec
2019-08-03 13:47:55 +04:30
6b3e093911
Merge branch 'master' into var-subset
2019-07-31 16:04:48 -07:00
07f27accb9
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-07-31 14:58:53 -07:00
521c7013ab
[cpal] revert port to dagger
...
It has a different semantic, maybe we should just do a zero memset,
letting Behdad to decide.
2019-07-30 18:10:40 +04:30
8014ce198a
[cpal] port to dagger ( #1887 )
2019-07-30 17:31:34 +04:30
d67201da5a
[colr] minor
2019-07-30 17:20:18 +04:30
e5cf9718c0
[colr][feat][meta] Port sub_array iteration to dagger ( #1868 )
2019-07-30 04:44:23 +04:30
9f2b4956b4
[base] Add hb_ot_layout_get_baseline API
2019-07-30 04:42:51 +04:30
40a4b6ddbd
[var] Add a new API, hb_font_set_var_named_instance
2019-07-29 16:23:47 -07:00
b6a2281f1a
[meta] Make values match their enum type naming
2019-07-30 03:48:23 +04:30
20072a2eca
[metrics] Make values match their enum type naming
2019-07-30 03:48:23 +04:30
ed2965a852
[base] Don't use enum inside the table
2019-07-30 03:34:10 +04:30
388fa9b326
[lcar] flip for and switch position
2019-07-29 15:19:33 -07:00
f0dd724c1e
Merge branch 'master' into subset-varstore
2019-07-29 14:21:05 -07:00
6e3bfecf35
Merge branch 'master' into var-subset
2019-07-29 12:25:43 -07:00
4e1da6bb61
[metrics] Rename hb_ot_metrics_t to hb_ot_metrics_tag_t
2019-07-29 22:43:09 +04:30
2c2a2b97db
[meta] Rename hb_ot_meta_t to hb_ot_meta_tag_t
2019-07-29 22:43:09 +04:30
7bcc5dfa97
[iter] Fix accumulate to accept const types
2019-07-28 20:55:50 -07:00
87454c447d
[base] fix logic
2019-07-28 20:46:47 +04:30
69655d5bc3
[base] minor
2019-07-28 20:39:20 +04:30
d9c44e7239
[base] Check if the returned base_coord is valid
2019-07-28 20:35:32 +04:30
53853c044a
[meta] minor
2019-07-28 20:23:48 +04:30
ed126d8c37
[base] fix build
2019-07-28 20:21:59 +04:30
c7b22b96cc
[base] minor
2019-07-28 19:46:57 +04:30
a157342fce
[base] Fix use of bsearch
2019-07-28 18:54:13 +04:30
eddd456532
[base] minor spacing
2019-07-28 02:21:54 +04:30
0a18efd766
Minor
2019-07-26 14:34:26 -07:00
d3d99f8bb6
[metrics] Expose raw OS2/HHEA asc/dsc values using private tags ( #1867 )
2019-07-26 16:46:04 +04:30
aaffe41094
[meta] minor, simplify iterator
2019-07-25 17:49:51 -07:00
62932c14bd
[meta] Rename ot-metadata to ot-meta per review
2019-07-25 17:49:51 -07:00
821d9e9034
Use .sub_array for DataMap tags iteration
2019-07-25 17:49:51 -07:00
a250af98ae
[meta] Add max value to hb_ot_metadata_t
2019-07-25 17:49:51 -07:00
80e246a1f2
[meta] Add a test program for metadata
2019-07-25 17:49:51 -07:00
bc65ebbce7
[meta] hb_ot_metadata_get_entries, tags iteration API
2019-07-25 17:49:51 -07:00
3ac03bd67c
[meta] New API, hb_ot_metadata_reference_entry for fetching meta entries
2019-07-25 17:49:51 -07:00
aab8e08487
minor spacing fix ( #1869 )
2019-07-26 02:19:22 +04:30
d791446a93
[feat] minor
2019-07-26 02:12:06 +04:30
a744fdc6c8
Add _MAX_VALUE to hb_ot_metrics_t ( #1861 )
2019-07-25 14:49:02 +04:30
069872c51b
minor
2019-07-25 14:27:43 +04:30
737eb85a4e
Add _MAX_VALUE to disabled baseline types enum
2019-07-25 14:26:30 +04:30
dd9a0ed3f0
Replace 0x7FFFFFFFu in enums with HB_TAG_MAX_SIGNED
2019-07-24 00:47:19 +04:30
5988ab8a4e
Merge branch 'master' into var-subset
2019-07-22 14:36:16 -07:00
636ae42237
minor, comment out meta table in list till its use
2019-07-22 22:50:21 +04:30
04c11a19b7
Merge pull request #1851 from khaledhosny/fix-sbix-extents
...
Fix sbix glyph extents
2019-07-22 16:44:47 +02:00
41ab56e095
Implement meta table parsing
2019-07-22 18:46:52 +04:30
a51aa951b5
[metrics] Fix _get_variation API to works with actual coord values
2019-07-22 18:35:55 +04:30
77141dff7d
[metrics] _-prefix internal symbol
2019-07-22 07:48:32 -04:00
89228ccb9a
Fix warning on IBM compilers
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1852
2019-07-22 07:07:37 -04:00
c9796d15e1
Fix sbix glyph extents
...
* The ‘height’ needs to be negated since the API returns “distance from
top to bottom side”.
* Similarly, the ‘y_offset‘ needs to be added to the height to get the
‘y_bearing’, since sbix’s offset is “the point in the glyph relative
to its lower-left corner which corresponds to the origin” while
‘y_bearing’ is the “top side of glyph from origin”.
With these changes the sbix glyph metrics return values similar to other
tables, as they were otherwise unusable.
2019-07-22 05:42:34 +02:00
759f3bd486
[metrics] Don't use metrics API in _common
...
As it is exposed with a different condition
2019-07-22 02:06:07 +04:30
eb8bd2f7ec
Add hb_gdi_face_create API
...
Based on Konstantin Ritt work posted on mailing list
2019-07-21 14:22:19 -07:00
3d03bb84d4
[metrics] minor, tweak comment
2019-07-21 12:38:04 +04:30
e540d402f6
[docs] Minor
2019-07-20 12:09:34 -07:00
00e13985fb
Revert hhea fallback to OS/2 to its reverse way
...
As searching number of hhea having fonts beats the number of OS/2
having ones in macOS 10.14.2
2019-07-20 12:09:26 -07:00
c13ef9cc64
Bring back asc/desc abs logic used to be in hmtx table
2019-07-20 12:09:26 -07:00
772e62688c
Make HB_TINY builds work again by separating the always needed part
2019-07-20 12:09:26 -07:00
cb70433740
Merge _get_position_internal into _get_position
2019-07-20 12:09:26 -07:00
ac3518af58
Define post table only when used
2019-07-20 12:09:26 -07:00
471f798ace
Merge ot-metrics-internal.cc with ot-metrics now that isn't needed in subset
2019-07-20 12:09:26 -07:00
29444d7e9f
Don't cache ascender/descender metrics
2019-07-20 12:09:26 -07:00
5e28c2654d
[doc] minor, improve hb-ot-metrics doc a bit
2019-07-20 14:08:11 +04:30
08b48e89d3
[os2] minor spacing tweaks
2019-07-20 12:53:40 +04:30
54b9ab704d
Fallback hhea's ascender/descender to OS2
2019-07-20 12:51:38 +04:30
ec8dde8142
[metrics] Fall back to hhea if OS2 metrics are empty
...
Reinstates previous logic, even if it might be unnecessary.
2019-07-19 11:14:20 -07:00
2e5b49d11d
Add HB_NO_METRICS and fix HB_TINY build ( #1839 )
2019-07-19 11:41:07 +04:30
2bd953ff4f
[metrics] Fix weird use of xor
...
I believe that was a try to use one approach as fallback to other. But
felt wrong. Just believe what's in OS/2 table to be correct.
2019-07-18 14:25:45 -07:00
9675a067bf
[ot-metrics] Touch up
2019-07-18 14:16:11 -07:00
87e628436e
Implement a simple API for fetching opentype metrics
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1432
2019-07-18 14:15:58 -07:00
ed67efcc8c
Revert "[Myanmar] Prevent reordering between Asat and Dot below"
...
This reverts commit 1c8654ead4
2019-07-18 10:42:20 -07:00
a76d8b0d55
Merge commit '504bb17287c978d60a4a515555852465319f74ed' into var-subset
2019-07-17 14:12:06 -07:00
6157bbe512
Revert "Revert previous change"
...
This reverts commit b8e90ca1a1
2019-07-17 11:20:08 -07:00
576065b442
[iter] Fix reduce type deduction
2019-07-17 11:19:34 -07:00
b8e90ca1a1
Revert previous change
...
Interestingly all of the bots disagreed with the change and the complain is... weird.
2019-07-17 21:38:19 +04:30
ee05627aff
Improve syntax to make out linux-arm64 a little happy
...
Decided to apply is we did the same on other places however this won't
fix all of its complains
2019-07-17 21:28:25 +04:30
6a6bf7b7bc
Downgrade -Wdeprecated-declarations to warning
...
Fixes #1834 at least till fix of #1829
2019-07-17 21:22:38 +04:30
25e2562fdf
[amalgam] Fix redundant-declaration warning/error
2019-07-17 09:35:56 -07:00
c184180228
Fix C++20 compile warning on implicit capture of this with '=' default capture ( #1833 )
...
Happens when compiled with -std=c++2a, the fix just makes the captures explicit to resolve the issue. Just adding this in addition to = doesn't work in C++11.
src/hb-ot-layout-gpos-table.hh:737:18: warning: implicit capture of 'this' with a capture default of '=' is deprecated [-Wdeprecated-this-capture]
{ return (this+_).intersects (glyphs, valueFormat); })
^
src/hb-ot-layout-gpos-table.hh:736:16: note: add an explicit capture of 'this' to capture '*this' by reference
| hb_map ([=] (const OffsetTo<PairSet> &_)
^
, this
2019-07-16 22:10:24 +04:30
1f94388516
[usp] define atfree callback only if used
2019-07-16 11:24:29 +04:30
68ac767e43
added skip(), get_next_value() to inc_bimap to subset VarStore with retain-gids
2019-07-12 23:02:29 -07:00
670768e5b9
fix inc-bimap for subsetting VarStore with retain-gids
2019-07-12 16:14:23 -07:00
4730b350b7
Revert "Update Graphite API to latest ( #1215 )"
...
This reverts commit e4e74c2751https://github.com/harfbuzz/harfbuzz/issues/1829
2019-07-12 15:38:35 -07:00
7a9d643c29
Fix unintialized memory read in cmap subset ( #1826 )
2019-07-11 01:35:07 +04:30
a6065d05cf
Don't call memcpy when a table is empty
2019-07-10 23:38:07 +04:30
0eef8113d8
retain gids in HVAR so in sync with fontTools
...
regenerate Comfortaa subset test results
2019-07-09 11:43:59 -07:00
a87fbb872b
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-07-09 10:25:54 -07:00
6e35668b45
fix var-subset build
2019-07-09 09:47:54 -07:00
8bf989ea70
update from master
2019-07-08 17:13:29 -07:00
2e7021da7d
Revert "Minor" - revert moving extern "C" definitions in-function
...
This reverts commit 62e60322cbhttps://github.com/harfbuzz/harfbuzz/issues/1821 .
2019-07-08 10:51:47 +03:00
f18ea1dd3a
[font] Remove division when scaling
...
Yoohoo. This seems to be precise enough! Let's see if it sticks.
I'm asking Dominik to run this in Chrome test suite and report.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1801
2019-07-05 13:56:45 -07:00
b847769292
[font] Keep font-space to user-space multiplier
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1801
2019-07-05 13:52:09 -07:00
df6edcd44c
Make face immutable in hb_font_set_face()
2019-07-05 13:45:15 -07:00
0d425e1eea
[ot-font] Optimize rounding
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1801
The assumption that compiler optimizes "upem/2" to a shift only
works if upem is unsigned... Anyway, spoon-feed the compiler.
2019-07-05 13:42:02 -07:00
ffa736f151
hb_set_previous_range docs: fix presumed copy/paste error
2019-07-05 08:09:25 -07:00
641f337380
Docs typo fix: slower → lower
2019-07-05 08:09:09 -07:00
9fea6b4dd4
[amalgam] Use it in cmake port and fix conflicts ( #1812 )
2019-07-05 18:46:41 +04:30
b240d701fd
[amalgam] Include integration source files as well
...
Just for those that are normally built into libharfbuzz itself.
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-03 12:17:57 -07:00
d515242045
[amalgam] Rename hb.cc to harfbuzz.cc
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-03 12:10:03 -07:00
4cb180d227
Revert "Use constexpr to replace passthru_ bools"
...
This reverts commit c4aa10ebc8
2019-07-02 19:44:18 -07:00
c4aa10ebc8
Use constexpr to replace passthru_ bools
2019-07-02 19:15:03 -07:00
2e48fd0779
Sprinkle constexpr around
...
Being conservative. Also not sure it makes any real difference
in our codebase.
2019-07-02 17:55:58 -07:00
df4448064e
Remove unused 'inline' specifier
2019-07-02 17:11:09 -07:00
04a4957040
[amalgam] Add hb.cc to git
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-02 16:19:18 -07:00
62e60322cb
Minor
2019-07-02 16:08:53 -07:00
ceb4c212dc
[amalgam] Fix UCD issue
...
This actually makes it build now!
Part https://github.com/harfbuzz/harfbuzz/issues/1809
Keeping open to add tests, CI, etc.
2019-07-02 16:08:53 -07:00
7ca54811f4
[amalgam] Fix CFF
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-02 16:00:58 -07:00
3724f13ba0
[amalgam] Finish fixing Indic-like shapers
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-02 15:40:11 -07:00
eb37bc9d93
[use] Remove Syriac features
...
This was non-standard, and unused anyway.
2019-07-02 15:21:11 -07:00
dc480fc471
[amalgam] More Indic-like issues
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-02 15:17:56 -07:00
d8b5353e07
[amalgam] More
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-02 15:09:26 -07:00
d115a9e022
[amalgam] Fix most duplicate-id instances in Indic-like shapers
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-02 14:58:52 -07:00
c073233f45
Add make rule to build hb.cc
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1809
2019-07-02 14:26:45 -07:00
f1d20d9b4d
Add ucd-table make target
2019-07-02 14:18:38 -07:00
634390ecaf
added VariationStore serializer to be used by HVAR/VVAR subsetters
2019-07-01 18:52:57 -07:00
5763a92749
Merge branch 'master' into var-subset
2019-07-01 15:17:19 -07:00
040b261dee
add bimap test along with bug fix/tweaks
2019-07-01 13:54:36 -07:00
4ab2d1d676
[dwrite] Apply minor style improves
2019-07-01 19:30:21 +04:30
5ebd265e66
Fix error rised by GCC8+
2019-07-01 16:06:43 +02:00
693dacbb1c
Use lower case file name with #include
...
I tried to cross compile harfbuzz for Windows and an error was generated because `DWrite_1.h` was not found.
This happened because the filesystem is case sensitive and for this reason that include file was not found.
The right name of the file to be used is `dwrite_1.h`, with all letters not capitalized:
https://docs.microsoft.com/en-us/windows/desktop/api/dwrite_1/
I also verified in the installation of VS2017 with Windows Kit v10 and in that place it was also lower case.
So, in my opinion it should be better to change this.
2019-07-01 13:31:26 +02:00
601b6825b0
Dynamically load DWRITE
...
Also checks if DWriteCreateFactory() has been executed successfully.
2019-06-30 15:03:44 +02:00
ad341d5f16
[config] Fix CoreText build with NO_AAT
2019-06-28 16:01:09 -07:00
3f806673fb
Apply some minor improves on CFFIndex
2019-06-29 00:00:00 +04:30
ddd29e5594
minor, reuse StructAtOffset logic in StructAtOffsetOrNull
2019-06-28 23:44:14 +04:30
9db7ce73d7
minor style improve in hb-cff-interp-common.hh
2019-06-28 23:11:52 +04:30
9a7b7bd9fc
style fix for pylint complain
2019-06-28 22:53:51 +04:30
01832fd16b
alternate fix for https://crbug.com/971933
2019-06-26 15:59:00 -07:00
cd65305b05
[config] Don't disable emoji sequences in HB_TINY
...
It makes sense to disable this code these if editing is not needed.
However, this is also necessary to correctly display emoji sequences
in right-to-left direction. For that reason, don't auto-disable it.
2019-06-26 14:57:48 -07:00
7298716a3c
[config] Compile out modified combining-class if HB_NO_OT_SHAPE
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-06-26 14:51:41 -07:00
1cdd0fa60d
[emoji] Port generator to packtab
2019-06-26 14:49:15 -07:00
5130c90ac0
[config] Add HB_NO_EMOJI
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-06-26 14:29:39 -07:00
9d5b5348c7
[config] Add HB_NO_SHAPER
...
Don't know who would want when why. But makes sense to have.
2019-06-26 13:58:40 -07:00
8fe15485cb
[config] Add HB_NO_OT_TAG
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-06-26 13:49:42 -07:00
7dcf8e126e
[config] Fix build with HB_NO_OT_LAYOUT
2019-06-26 13:44:23 -07:00
2804790bce
[config] Add dependency
2019-06-26 13:38:14 -07:00
b0fd16eec6
[config] Add dependency
2019-06-26 13:31:51 -07:00
Ebrahim Byagowi
Khaled Hosny
Marcel Fabian Krüger
Evgeniy Reizner
Daeren
Behdad Esfahbod
blueshade7
David Corbett
Michiharu Ariza
Hal Canary
jfkthame
Garret Rieger
Qunxin Liu
Ben Wagner
Iceflower
Qunxin Liu
Adrian Wong
Ali Javadi
Dominik Röttsches
Simon Sapin
Carlo Bramini