254933c397
When sanitizing, delay making writable
...
Before, as soon as we needed to make an edit, we tried to make the blob
writable inplace. That grows code unnecessarily though. We can simply
fail, make writable, then start again. That's indeed what the fallback
was doing anyway.
2010-04-23 13:57:10 -04:00
d632ec4000
Cosmetic
2010-04-22 18:42:05 -04:00
a3263aa773
Convert the last set of cast macros to templates
2010-04-22 18:42:01 -04:00
c38188a191
Remove unused macro
2010-04-22 16:52:09 -04:00
dc228048a8
Remove integrity check in Tag sanitize
...
Serves no useful purpose.
2010-04-22 13:22:41 -04:00
c293581e96
Add coment
2010-04-22 11:20:28 -04:00
1faa76c6e8
Remove unnecessary casts
2010-04-22 10:54:26 -04:00
565c80bd29
Make sure semicolon is expected after DEFINE_NULL_DATA()
2010-04-22 10:26:35 -04:00
e5546a4352
Watch for overflow in Array sanitize
2010-04-22 00:48:54 -04:00
4f5f1c34dd
Rename const_sub_array to sub_array since all consts are implicit now
2010-04-22 00:27:39 -04:00
c755cb3e3a
Change header comment
2010-04-22 00:11:43 -04:00
243d20e011
More cast simplification
2010-04-21 23:57:01 -04:00
0dfcc13a46
Rename ConstCharP to CharP (overloaded now)
2010-04-21 23:41:26 -04:00
62c0fd7573
Cleanup de-const-casting during sanitize
2010-04-21 23:30:48 -04:00
dd15587056
Add more comments
2010-04-21 23:13:33 -04:00
c85c362067
Add comment
2010-04-21 23:12:54 -04:00
2467c669c2
Add comment
2010-04-21 23:11:45 -04:00
29c3f5e1b6
Improve comment
2010-04-21 23:01:00 -04:00
01c01618e9
Further simplify IntType struct defs
2010-04-21 22:49:56 -04:00
2cb08458f6
Rename const_array() to array() (overloaded)
2010-04-21 22:37:31 -04:00
2e2f43edf2
Remove ArrayAfter, use StructAfter in place
2010-04-21 22:30:36 -04:00
e961c86c57
Convert NEXT() and ARRAY_AFTER() macros to templates
2010-04-21 15:56:11 -04:00
198facdc55
Use templates for const char * casts
2010-04-21 13:35:36 -04:00
e032ed9f75
Use templates for defining int typess
2010-04-21 04:51:55 -04:00
2c9fd2adce
Remove unused macro
2010-04-21 02:15:39 -04:00
7a52f28117
Rename macros
2010-04-21 02:14:44 -04:00
40d73bc68d
Improve comments
2010-04-21 01:55:20 -04:00
394bad41a7
Remove stale TODO item
2010-04-21 01:55:17 -04:00
9d3677899f
Use a function template instead of struct template for Null
2010-04-21 01:55:12 -04:00
ffd321afd9
Simplify Tag struct
2010-04-21 01:55:09 -04:00
00e23fcc6f
Cosmetic
2010-04-21 01:55:03 -04:00
f9b3772798
Add couple consts to operators
2010-04-21 01:54:53 -04:00
53d237ec63
Remove ASSERT_SIZE_DATA
2010-04-21 01:54:49 -04:00
0e206de986
Fix warnings
2010-04-21 01:48:41 -04:00
d5943407a4
Fix debug build
2010-04-21 01:42:11 -04:00
4b8487d83e
Fix the mystery bug!
...
A couple bugs joined forces to exhibit the mystery behavior of
crashes / infinite loops on OS X / wrong kerning / invalid memory
access. Pooh!
The bugs were involved:
- Wrong pointer math with ValueRecord in PairPosFormat1
- Fallout from avoiding flex arrays, code not correctly updated
to remove sizeof() usage.
We strictly never use sizeof() directly now. And the PairPos code
is cleaned up. Should fix them all. Bugs are:
Bug 605655 - Pango 1.26.2 introduces kerning bug
Bug 611229 - Pango reads from uninitialized memory
Bug 593240 - (pangoosx) Crash / infinite loop with Mac OS X
We were also doing wrong math converting Device adjustments to
hb_position_t. Fallout from FreeType days. Should shift 16, not
6. Fixed that too.
There's still another bug: we don't sanitize Device records
referenced from value records. Fixing that also.
2010-04-21 01:41:29 -04:00
9b39755d10
Typo
2010-04-15 14:00:25 -04:00
f85ec1c7da
Cosmetic
2010-03-10 04:14:40 -05:00
ecd2e996d2
Improve the alignment for NullPool
2010-02-23 02:42:00 -05:00
807b8aa486
Another C++ strictness fix
...
Pango Bug 602408 - Invalid C++ code breaks compile with Sun C++ Compiler
(Error: A union member cannot have a user-defined assignment operator)
According to the bug:
C++ Programming Language by Bjarne Stroustrup: Chapter 10.4.12 forbids
explicitly using of union members with constructors, destructors or assignment
operations.
So we use a set() method instead of the assignment operator. Ugly, but hey,
that's life.
2009-11-19 20:35:01 -05:00
d0351314cd
Include stdio.h if debugging
2009-11-05 16:16:06 -05:00
1e91434569
Minor
2009-11-04 18:12:09 -05:00
48de3730cd
Fix previous commit, ouch!
2009-11-04 16:59:50 -05:00
d3480ba37f
Don't use zero-sized arrays
...
It's not part of the standard and MSVC doesn't like it. It makes the code
a lot less elegant than it used to be, but I think it should work now.
2009-11-03 10:47:29 -05:00
3e2401f6c5
[HB] Rename DEBUG to TRACE where appropriate
2009-11-02 14:40:48 -05:00
95e202403f
[HB] Allow enabling different debug facilities individually
2009-11-02 14:40:48 -05:00
8b53461304
[HB] Fix more casts
2009-11-02 14:40:47 -05:00
977eeb7144
[HB] s/writeable/writable/g
2009-11-02 14:40:46 -05:00
cd33cb9ed8
[HB] More minor shuffling
2009-11-02 14:40:43 -05:00
80e2aa2e1b
[HB] Move code around
2009-11-02 14:40:43 -05:00
3564ee5216
[HB] Correctly sanitize LigatureAttach
2009-11-02 14:40:43 -05:00
815a73e420
[HB] Fix possible int overflows during sanitize
2009-11-02 14:40:43 -05:00
ae728e51e9
[HB] Debug output for SANITIZE_MEM()
2009-11-02 14:40:43 -05:00
41895506cb
[HB] Use inline function for SANITIZE_MEM()
2009-11-02 14:40:43 -05:00
95528131b5
[HB] Use SANITIZE_THIS() when applicable
2009-11-02 14:40:43 -05:00
5ccf1ba339
[HB] Fixed signedness warnings
2009-11-02 14:40:41 -05:00
20b035dad4
[HB] Put C++ inline's back
...
Apparetly in C++, inline means a totally different thing.
2009-11-02 14:40:36 -05:00
284899ccbe
[HB] Add a NEXT() macro
2009-11-02 14:40:35 -05:00
7f96b39a9d
[HB] Fix bug introduced recently
2009-11-02 14:40:34 -05:00
bff3c0fde5
[HB] Remove clumsy macros and improve API
2009-11-02 14:40:34 -05:00
d0b657379b
[HB] Fix various XXX issues
2009-11-02 14:40:34 -05:00
9e826ea283
[HB] Fix unaligned access
2009-11-02 14:40:33 -05:00
71a8344a5e
[HB] Remove a few 'inline's, though the compiler mostly ignores them
2009-11-02 14:40:32 -05:00
9b76a290a9
[HB] Improve debug output
2009-11-02 14:40:32 -05:00
0d77ab8a73
[HB] Improve debug output
2009-11-02 14:40:32 -05:00
7acb389569
[HB] Improve debug output and fix mprotect bug
2009-11-02 14:40:31 -05:00
4f3ad9115a
[HB] More debugging output
2009-11-02 14:40:30 -05:00
8cd6fa28d1
[HB] Fix fatal Sanitizer bug
2009-11-02 14:40:30 -05:00
b28815c1f6
[HB] Add sanitize debugging facilities
2009-11-02 14:40:30 -05:00
7edb430f91
[HB] Rename open-types to open-type; beauty
2009-11-02 14:40:30 -05:00
Behdad Esfahbod