c479a59988
[subset] Assemble font
2018-02-07 21:26:04 -06:00
34ac3548b7
[set] Respect stride
...
Ouch!
2018-02-07 18:07:45 -06:00
577becaf7b
[subset] Fixup
2018-02-07 17:38:40 -06:00
c9acab3cfb
Whitespace
2018-02-07 17:28:43 -06:00
7fd0b61dee
[subset] Create new face and copy all tables to it
...
test-subset fails now because subset-face does not know how to compile itself.
2018-02-07 17:28:43 -06:00
4e1abe2ce0
Refactor subset glyf to remove multiple calls to glyf.fini()
2018-02-07 17:28:43 -06:00
0a5d1440f8
Add implementation of glyf subsetting.
2018-02-07 17:28:43 -06:00
05d65baa1b
Extract glyf offset calculation into it's own method.
2018-02-07 17:28:43 -06:00
6d7c6e19dc
Fix two undefined-behavior issues
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/761
Fixes https://github.com/harfbuzz/harfbuzz/issues/762
2018-02-07 14:09:56 -06:00
b87cbe2bec
Try fixing build for platforms that have no visibility attributes
2018-02-07 14:11:26 -05:00
6804b61d2e
[subset] Add hb_subset_face
...
It's a hb_face_t that has add_table() and in the future knows how to
compile itself into a font blob.
2018-02-07 13:47:35 -05:00
af02812fc5
[subset] Change hb_subset API to remove hb_subset_face_t
2018-02-07 13:07:46 -05:00
2da0d87e76
Remove NullPool visibility hack
...
We keep a separate private NullPool in libharfbuzz-subset.so
This can fire back later since now there are two separate null objects,
and comparisons to the null pool can be confused. Something to deal
with when it comes up. Ouch!
2018-02-07 12:44:35 -05:00
b95aa204ee
glyph ids to retain should most likely keep the glyph id not the codepoint
2018-02-07 12:41:21 -05:00
91428713bd
Remove \ns leftover from fprintf
2018-02-07 12:41:21 -05:00
eb485bb9e9
Horrid hack to assign new gids. Use DEBUG_MSG over fprintf
2018-02-07 12:41:21 -05:00
8b80cbb1dd
Add a subset debug category
2018-02-07 12:41:21 -05:00
ee433d36fa
[aat] Set debug lookup_index
2018-02-07 12:41:21 -05:00
38df1ec8e0
TEMPORARY: remove HB_INTERNAL from null pool so subset builds again
2018-02-07 12:41:21 -05:00
53aa0e9542
Add an instance of glyf::accelerator_t to hb-subset-glyf.
2018-02-07 12:41:21 -05:00
ef62dfed3f
add back assert_pod
2018-02-07 12:41:21 -05:00
d0ce3c66e2
Resolve codepoints:glyph ids. Does not compile; undefined reference to OT::_hb_NullPool
2018-02-07 12:41:21 -05:00
6a45e5df24
Add skeleton of hb-subset-glyf, call if from hb_subset(...)
2018-02-07 12:41:21 -05:00
31ec3c2ec4
Create a subset plan in hb_subset.
2018-02-07 12:41:21 -05:00
25e9173fe8
Make hb-subset-plan private.
2018-02-07 12:41:21 -05:00
af46a4da5a
Move definition of hb_subset_input into hb-subset-private.hh.
2018-02-07 12:41:21 -05:00
7481f0ce21
Add codepoints to subset input.
2018-02-07 12:41:21 -05:00
1cfe650f02
Add a basic sketch of hb-subset-plan.
2018-02-07 12:41:21 -05:00
126ffdbe95
[aat] Fix debug compile
2018-02-07 12:26:57 -05:00
2971e9da49
[aat] Adjust unsafe-to-break logic some more
...
I believe I'm happy with it now.
2018-02-06 11:48:04 -05:00
f49256d80f
[aat] Simplify unsafe-to-break logic
2018-02-06 11:39:36 -05:00
cc1e0840ba
[buffer] Tweak diff re glyph_flags again
...
We expect the buffer to have no flags that the reference doesn't...
Meh. Makes MORX tests pass now. Need to better define the behavior.
2018-02-06 10:20:48 -05:00
d49ae5154e
Fix hb-buffer logic error
2018-02-06 10:13:11 -05:00
f41b92134a
Fix fallthrough compiler warning with gcc >= 7
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/755
2018-02-05 19:51:09 -05:00
0ff007daaa
[subset] Minor
2018-02-05 19:36:38 -05:00
ae39fc8171
[subset] Build hb-subset into separate libharfbuzz-subset.so
2018-02-04 20:18:52 -05:00
257022b178
Merge pull request #745 from googlefonts/master
...
Interface for hb_subset, skeleton for the hb-subset cli, and basic testing rigging.
2018-02-04 20:01:35 -05:00
54e6efadd6
[aat] Fix unsafe-to-break
...
At any position, if state is not zero, mark unsafe-to-break before,
unless we can reason it safe.
At any position, if there's an action entry for end-of-text, mark
unsafe to break.
Also changes buffer diff impl to allow for flag differences as long
as the buffer glyph flags are superset of reference glyph flags.
With this, all MORX tests pass.
2018-02-04 17:18:54 -05:00
f83a43b561
Add CMake configuration for all of the new subsetting code.
2018-02-04 12:57:34 -08:00
34fa7b3ad2
Whitespace
2018-02-04 12:57:34 -08:00
8c3a672737
Get test-subset to pass.
2018-02-04 12:57:34 -08:00
74d39ed263
Attach add a hb_face_t to hb_subset_face_t.
2018-02-04 12:57:34 -08:00
a2965f2ea5
Add a basic implementation of hb-subset to enable compilation of test-subset.
2018-02-04 12:57:33 -08:00
cf403e1a53
Add hb-subset.h to hb.h
2018-02-04 12:57:33 -08:00
c02573516c
Fix typo in hb-subset.h
2018-02-04 12:57:33 -08:00
9ccb8366f6
Start to sketch APIs for subsetting
2018-02-04 12:57:33 -08:00
89b1906d99
[aat] More adjustment to ContextualSubtable
...
See comment.
With this, MORX-20 passes if I turn --verify off. Our unsafe-to-break
logic is currently broken in presence of end-of-text actions. That's,
ugh, extra work to fix. Let me try...
2018-02-04 14:45:02 -05:00
8be596f0b7
[aat] In ContextualSubstitute, apply end-of-text action to last glyph
2018-02-04 14:40:17 -05:00
c0b1c7eb2e
[aat] Remove unneeded check
2018-02-04 14:19:41 -05:00
aed32589af
[aat] In ContextualSubtable, mark mark after substituting mark
...
Fixes MORX-21.
2018-02-04 12:36:54 -05:00
fe5f9b1ae3
[aat] Fix ContextualSubtable sanitization
...
Fixes MORX-18, MORX-19, and MORX-22.
2018-02-04 12:36:54 -05:00
e8859fca3e
Enable use of atexit() on macOS and related platforms.
...
The atexit() man page indicates that this is expected to behave
in the expected way on unloading of shared libraries.
2018-02-03 19:20:40 -08:00
a89573770b
Use nullptr, not NULL.
2018-02-03 21:26:58 +02:00
ccb0367dae
Let VS1 follow U+1031 MYANMAR VOWEL SIGN E
2018-02-02 12:41:07 -08:00
c6dbf6e77c
Allow optional ZWJ in virama terminated cluster
2018-01-31 14:16:25 -08:00
dae20fb5a7
Use nullptr instead of 0.
2018-01-31 08:18:48 -08:00
90218fa93c
Fix typos.
2018-01-31 08:18:15 -08:00
148ca61075
[ot-layout] Fix nullptr dereference.
...
If the `calloc` for `gsub_accels` or `gpos_accels` fails, then the
unlikely branch afterwards can be taken, which frees up the
`hb_ot_layout_t`, but since those fields can now be `nullptr`, then
we don't want to dereference them.
2018-01-31 08:05:25 -08:00
0c66043a92
[coretext] Fix memory leaks.
...
In `reference_table`, if the data is empty and we return early,
we still need to release the data object.
In `hb_coretext_shape`, there two edge cases where an early
return should release the attributed string.
2018-01-31 08:04:15 -08:00
e89df6e1ae
[aat] Limit number of DontAdvance transitions
...
Remove the faulty loop-detection logic. Use max-ops for breaking
out of infinite loops or heavy work.
https://twitter.com/behdadesfahbod/status/958065026262183936
2018-01-30 11:01:18 -08:00
55cae0d72e
[test] Use 'otool -L' where ldd doesn't exist (macOS) ( #732 )
2018-01-29 18:05:24 +03:30
2ec7dd1f6c
Fix Travis build on macOS ( #731 )
2018-01-29 02:18:28 +03:30
12757b6929
Misc warning fixes
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/712
2018-01-26 18:14:05 -08:00
85be365ed9
Use KernSubTableFormat2::rightClassTable
...
Issue originally reported at http://cppfiles.com/chromium.txt .
This fixes what appears to be a copy - paste issue which causes both
KernSubTableFormat2::rightClassTable and the 'right' argument to
KernSubTableFormat2::get_kerning to go unused.
2018-01-26 15:20:18 -08:00
19a93fcf19
Fix typos.
2018-01-21 10:33:54 -08:00
51ce3828e6
[aat] Fix Ligature matching
...
I hope... Makes "ffi" work with Zapfino. I'm not sure if doing it correctly though...
2018-01-19 18:37:58 -08:00
bef509855c
[aat] Add TODO
2018-01-19 18:24:00 -08:00
e6f283ed7d
[aat] Implement LigatureSubtable
...
We form the Zapfino ligature now. Yay! No further testing done.
2018-01-19 18:09:48 -08:00
f07ce661a2
[aat] Embed a sanitizer context in hb_aat_apply_context_t
...
For run-time checking.
2018-01-19 16:52:01 -08:00
046690a4df
[aat] Add hb_aat_apply_context_t
2018-01-19 16:40:13 -08:00
fd03449094
Rename hb_apply_context_t to hb_ot_apply_context_t
2018-01-19 16:40:13 -08:00
94b49beee9
Whitespace
2018-01-19 16:40:13 -08:00
c8f2a4f5b9
hb-common.cc: Hatran script is right-to-left ( #714 )
...
"Hatran is written from right to left horizontally"
http://www.unicode.org/L2/L2012/12312-n4324-hatran.pdf
This ancient script was added with Unicode 8.0.
Also this spreadsheet (referenced in an inline comment in the
source code) has it as RTL: http://goo.gl/x9ilM
2018-01-19 01:19:40 +03:30
00806149b9
Improve avoiding C++ linkage, definition creation and cmake tests ( #710 )
2018-01-19 01:12:31 +03:30
461a605fde
[aat] Allocate set dynamically
2018-01-17 10:02:48 -08:00
949f6af289
Disallow sanitize recursing into Extension subtables multiple times
...
Fixes https://oss-fuzz.com/v2/testcase-detail/5216838347653120
which is a stack overflow, not by way of infinite recursion, just
being deep. That's disallowed anyway, so catch it as it happens,
not afterwards.
2018-01-15 20:44:10 -05:00
bcb6f1ae0a
Whitespace
2018-01-15 20:34:05 -05:00
12fffce10e
[aat] Sanitize classTable in StateTable
2018-01-15 15:41:51 -05:00
e6263c7142
[aat] Wire up table length to apply()
2018-01-15 15:37:55 -05:00
679ae744d0
[aat] Towards implementing LigatureSubtable
2018-01-14 15:03:31 -05:00
c9e12a2b9b
Fix set initializer
2018-01-13 17:05:12 +00:00
9009b341c4
[aat] Fix some struct sizes
...
I hate it that with my compiler at least, it doesn't catch totally uncompilable
statements in templates if they are not used...
2018-01-12 12:04:53 +01:00
57051b4f67
[aat] Flush rest of buffer if state machine failed
2018-01-12 11:42:25 +01:00
25364c4f00
[aat] Fix symbol visibility
...
Not sure why only one of the bots sees this as visible...
2018-01-12 11:31:20 +01:00
ee16b9d8d3
Revert accidental morx enablement
2018-01-12 11:28:09 +01:00
cdfa801ff4
[aat] Tweak previous commit
2018-01-12 11:12:20 +01:00
f7600228a4
[aat] Detect infinite-loops in state machine
2018-01-12 11:09:21 +01:00
dd38db523a
[aat] Fix more builds
...
Maybe I should disable C++11 detection such that my compiler also catches
these. Doesn't look like we can switch to it for a while anyway...
2018-01-12 09:45:42 +01:00
72cb2b1f57
[aat] Fix builds
2018-01-12 09:38:55 +01:00
e3a15d0c6d
Update _POSIX_C_SOURCE to the latest version
...
Defining _POSIX_C_SOURCE to an old version on FreeBSD can cause C99 to
be disabled in libc.
2018-01-12 09:19:41 +01:00
c70d58f97d
[aat] Port RearrangementSubtable to StateTableDriver
2018-01-12 00:08:22 +01:00
117cfe7bb7
[aat] Add StateTableDriver and convert ContextualSubtable to it
2018-01-12 00:01:36 +01:00
1f1c85a54a
[aat] Remove 'mort' support
...
It's dead, Jim!
2018-01-11 22:43:57 +01:00
7e2fed6d73
[aat] Allow DontAdvance
...
Apparently CoreText does allow these. To be done: detect infinite
loops.
Fixes MORX-12 test.
2018-01-11 19:25:21 +01:00
17f01aff91
[aat] Sanitize ContextualSubtable
2018-01-11 18:54:49 +01:00
9b82aa19d8
More warning fixes
2018-01-11 18:19:42 +01:00
680cbc2eb3
[aat] Sanitize StateTable
2018-01-11 18:15:53 +01:00
0e3b3379a0
[aat] Actually fix d887f93148
2018-01-11 18:01:10 +01:00
3f291ffd5a
[buffer] Fix compiler warnings
...
line 323: Warning: info hides hb_buffer_t::info
...
2018-01-11 17:57:46 +01:00
d887f93148
[aat] Make bots happy
...
Don't know why this is not caught by my compiler. Looks like clang catches it
while gcc doesn't.
In file included from ../src/hb-aat-layout-morx-table.hh:31:
../src/hb-aat-layout-common-private.hh:523:30: error: no member named 'static_size' in 'AAT::ContextualSubtable<AAT::MorxTypes>::EntryData'
DEFINE_SIZE_STATIC (4 + T::static_size);
~~~^
2018-01-11 17:41:34 +01:00
Behdad Esfahbod
Garret Rieger
Rod Sheeter
Ebrahim Byagowi
Bruce Mitchener
David Corbett
punchcutter
bungeman
Cosimo Lupo
Ting-Wei Lan