Behdad Esfahbod
c85c362067
Add comment
2010-04-21 23:12:54 -04:00
Behdad Esfahbod
2467c669c2
Add comment
2010-04-21 23:11:45 -04:00
Behdad Esfahbod
29c3f5e1b6
Improve comment
2010-04-21 23:01:00 -04:00
Behdad Esfahbod
01c01618e9
Further simplify IntType struct defs
2010-04-21 22:49:56 -04:00
Behdad Esfahbod
2cb08458f6
Rename const_array() to array() (overloaded)
2010-04-21 22:37:31 -04:00
Behdad Esfahbod
2e2f43edf2
Remove ArrayAfter, use StructAfter in place
2010-04-21 22:30:36 -04:00
Behdad Esfahbod
e961c86c57
Convert NEXT() and ARRAY_AFTER() macros to templates
2010-04-21 15:56:11 -04:00
Behdad Esfahbod
198facdc55
Use templates for const char * casts
2010-04-21 13:35:36 -04:00
Behdad Esfahbod
e032ed9f75
Use templates for defining int typess
2010-04-21 04:51:55 -04:00
Behdad Esfahbod
2c9fd2adce
Remove unused macro
2010-04-21 02:15:39 -04:00
Behdad Esfahbod
7a52f28117
Rename macros
2010-04-21 02:14:44 -04:00
Behdad Esfahbod
40d73bc68d
Improve comments
2010-04-21 01:55:20 -04:00
Behdad Esfahbod
394bad41a7
Remove stale TODO item
2010-04-21 01:55:17 -04:00
Behdad Esfahbod
9d3677899f
Use a function template instead of struct template for Null
2010-04-21 01:55:12 -04:00
Behdad Esfahbod
ffd321afd9
Simplify Tag struct
2010-04-21 01:55:09 -04:00
Behdad Esfahbod
00e23fcc6f
Cosmetic
2010-04-21 01:55:03 -04:00
Behdad Esfahbod
f9b3772798
Add couple consts to operators
2010-04-21 01:54:53 -04:00
Behdad Esfahbod
53d237ec63
Remove ASSERT_SIZE_DATA
2010-04-21 01:54:49 -04:00
Behdad Esfahbod
0e206de986
Fix warnings
2010-04-21 01:48:41 -04:00
Behdad Esfahbod
d5943407a4
Fix debug build
2010-04-21 01:42:11 -04:00
Behdad Esfahbod
4b8487d83e
Fix the mystery bug!
...
A couple bugs joined forces to exhibit the mystery behavior of
crashes / infinite loops on OS X / wrong kerning / invalid memory
access. Pooh!
The bugs were involved:
- Wrong pointer math with ValueRecord in PairPosFormat1
- Fallout from avoiding flex arrays, code not correctly updated
to remove sizeof() usage.
We strictly never use sizeof() directly now. And the PairPos code
is cleaned up. Should fix them all. Bugs are:
Bug 605655 - Pango 1.26.2 introduces kerning bug
Bug 611229 - Pango reads from uninitialized memory
Bug 593240 - (pangoosx) Crash / infinite loop with Mac OS X
We were also doing wrong math converting Device adjustments to
hb_position_t. Fallout from FreeType days. Should shift 16, not
6. Fixed that too.
There's still another bug: we don't sanitize Device records
referenced from value records. Fixing that also.
2010-04-21 01:41:29 -04:00
Behdad Esfahbod
9b39755d10
Typo
2010-04-15 14:00:25 -04:00
Behdad Esfahbod
f85ec1c7da
Cosmetic
2010-03-10 04:14:40 -05:00
Behdad Esfahbod
ecd2e996d2
Improve the alignment for NullPool
2010-02-23 02:42:00 -05:00
Behdad Esfahbod
807b8aa486
Another C++ strictness fix
...
Pango Bug 602408 - Invalid C++ code breaks compile with Sun C++ Compiler
(Error: A union member cannot have a user-defined assignment operator)
According to the bug:
C++ Programming Language by Bjarne Stroustrup: Chapter 10.4.12 forbids
explicitly using of union members with constructors, destructors or assignment
operations.
So we use a set() method instead of the assignment operator. Ugly, but hey,
that's life.
2009-11-19 20:35:01 -05:00
Behdad Esfahbod
d0351314cd
Include stdio.h if debugging
2009-11-05 16:16:06 -05:00
Behdad Esfahbod
1e91434569
Minor
2009-11-04 18:12:09 -05:00
Behdad Esfahbod
48de3730cd
Fix previous commit, ouch!
2009-11-04 16:59:50 -05:00
Behdad Esfahbod
d3480ba37f
Don't use zero-sized arrays
...
It's not part of the standard and MSVC doesn't like it. It makes the code
a lot less elegant than it used to be, but I think it should work now.
2009-11-03 10:47:29 -05:00
Behdad Esfahbod
3e2401f6c5
[HB] Rename DEBUG to TRACE where appropriate
2009-11-02 14:40:48 -05:00
Behdad Esfahbod
95e202403f
[HB] Allow enabling different debug facilities individually
2009-11-02 14:40:48 -05:00
Behdad Esfahbod
8b53461304
[HB] Fix more casts
2009-11-02 14:40:47 -05:00
Behdad Esfahbod
977eeb7144
[HB] s/writeable/writable/g
2009-11-02 14:40:46 -05:00
Behdad Esfahbod
cd33cb9ed8
[HB] More minor shuffling
2009-11-02 14:40:43 -05:00
Behdad Esfahbod
80e2aa2e1b
[HB] Move code around
2009-11-02 14:40:43 -05:00
Behdad Esfahbod
3564ee5216
[HB] Correctly sanitize LigatureAttach
2009-11-02 14:40:43 -05:00
Behdad Esfahbod
815a73e420
[HB] Fix possible int overflows during sanitize
2009-11-02 14:40:43 -05:00
Behdad Esfahbod
ae728e51e9
[HB] Debug output for SANITIZE_MEM()
2009-11-02 14:40:43 -05:00
Behdad Esfahbod
41895506cb
[HB] Use inline function for SANITIZE_MEM()
2009-11-02 14:40:43 -05:00
Behdad Esfahbod
95528131b5
[HB] Use SANITIZE_THIS() when applicable
2009-11-02 14:40:43 -05:00
Behdad Esfahbod
5ccf1ba339
[HB] Fixed signedness warnings
2009-11-02 14:40:41 -05:00
Behdad Esfahbod
20b035dad4
[HB] Put C++ inline's back
...
Apparetly in C++, inline means a totally different thing.
2009-11-02 14:40:36 -05:00
Behdad Esfahbod
284899ccbe
[HB] Add a NEXT() macro
2009-11-02 14:40:35 -05:00
Behdad Esfahbod
7f96b39a9d
[HB] Fix bug introduced recently
2009-11-02 14:40:34 -05:00
Behdad Esfahbod
bff3c0fde5
[HB] Remove clumsy macros and improve API
2009-11-02 14:40:34 -05:00
Behdad Esfahbod
d0b657379b
[HB] Fix various XXX issues
2009-11-02 14:40:34 -05:00
Behdad Esfahbod
9e826ea283
[HB] Fix unaligned access
2009-11-02 14:40:33 -05:00
Behdad Esfahbod
71a8344a5e
[HB] Remove a few 'inline's, though the compiler mostly ignores them
2009-11-02 14:40:32 -05:00
Behdad Esfahbod
9b76a290a9
[HB] Improve debug output
2009-11-02 14:40:32 -05:00
Behdad Esfahbod
0d77ab8a73
[HB] Improve debug output
2009-11-02 14:40:32 -05:00