f2908b4d8f
Implement subset --regain-gids option with CFF1/2
...
along with api tests & expected results
2019-01-31 14:16:37 -08:00
dc04261a5b
[subset] Update the subset fuzzer to determine which options to use based on data in the fuzzing test case.
...
Add support for toggling retain_gids.
2019-01-30 15:23:19 -08:00
e6ffcc5904
[subset] Add expected files for retain-gids integration tests.
2019-01-29 13:19:21 -08:00
a903f9c228
[subset] Add some subsetting integration tests covering retain gids.
2019-01-29 13:19:21 -08:00
ccc59dc612
[subset] Add unit test for glyf subsetting and retain gids.
2019-01-29 13:19:21 -08:00
a9321cb5f8
Fix mac test
2019-01-25 16:11:45 +01:00
06358ae974
[AAT] Add test for recent Ligature stack fix, using Zapfino on Mac
2019-01-25 15:11:47 +01:00
00f06d1aa6
Fix test
2019-01-24 16:11:05 +01:00
9f31417733
Form cluster for Emoji sub-region tag sequences
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1556
2019-01-24 16:08:33 +01:00
5034f8f2ab
Fix macos tests with previous commit
2019-01-24 12:50:38 +01:00
3ecda71041
Adjust mark offsets when zeroing from fallback mark positioning code
...
Adjust tests.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1532
2019-01-24 12:28:24 +01:00
cbe0ed117a
[AAT] Re-enable tests MORX-31 and MORX-41
2019-01-23 20:45:18 +01:00
410731d3fb
[test/text-rendering-tests] Update from upstream
2019-01-23 20:31:06 +01:00
789396ed6b
Remove wrongly added files
2019-01-22 10:51:21 +01:00
28917e58f9
init interp_env_t::hintmask_size
...
fixes issue #1547
2019-01-18 09:43:51 -08:00
6879efc2c1
[AAT] Fix anchor bound checking, again
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
2019-01-17 14:08:02 -05:00
f401f85a5a
Remove assumption about Core Text working in 96 DPI
...
Core Text doesn't actually have a concept of DPI internally, as it
doesn't rasterize anything by itself, it just generates vector paths
that get passed along to Core Graphics.
In practice this means Core Text operates in the classical macOS
logical DPI of 72, with one typographic point corresponding to one
point in the Core Graphics coordinate system, which for a normal
bitmap context then corresponds to one pixel -- or two pixels for
a "retina" context with a 2x scale transform.
Scaling the font point sizes given to HarfBuzz to an assumed DPI
of 96 is problematic with this in mind, as fonts with optical
features such as 'trak' tables for tracking, or color glyphs,
will then base the metrics off of the wrong point size compared
to what the client asked for.
This in turn causes mismatches between the metrics of the shaped
text and the actual rasterization, which doesn't include the 72
to 96 DPI scaling.
If a 96 DPI is needed, such as on the Web, the scaling should be
done outside of HarfBuzz, allowing the client to keep the DPI of
the shaping in sync with the rasterization.
The recommended way to do that is by scaling the font point size,
not by applying a transform to the target Core Graphics context,
to let Core Text choose the right optical features of the target
point size, as described in WWDC 2015 session 804:
https://developer.apple.com/videos/play/wwdc2015/804/
2019-01-15 13:26:35 +01:00
91d774712f
[test] Add test for previous commit
2019-01-14 15:31:31 -05:00
7a6686a589
[AAT] Fix mort ContextualSubtable offset access
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12312
2019-01-14 15:09:14 -05:00
a3fa7d3336
[AAT] Fix ankr table access
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=918340
2019-01-14 14:37:36 -05:00
26c5b54fb0
CircleCI: Test for Python 3 syntax errors and undefined names ( #1522 )
...
Catch missing imports and errors like #1520 and #1521
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org ) issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2018-12-31 07:00:43 +03:30
686e6f2e40
Fix automake warnings
...
[skip ci]
2018-12-30 11:28:06 -05:00
b5c12b9f4d
print() is a function in Python 3 ( #1520 )
2018-12-30 15:37:28 +03:30
3ee4ea9456
Fix build on older Visual Studio versions ( #1499 )
...
* src/hb-cff-interp-dict-common.hh: Use ull for unsigned int64_t
The llu suffix does not work for older Visual Studio versions
(pre-2013), but ull works for all the compilers that we attempt to
support.
* test/api: Fix build on pre-C99 compilers
Ensure variables are declared at the top of the block.
* src/hb-dsalgs.hh: Add specialization for hb_is_signed<> for __int8
Pre-Visual Studio 2010 does not consider __int8 (which is typedef'ed to
int8_t) to be equivilant to signed char, so the compiler cannot find the
corresponding hb_is_signed<> specialization that is needed.
The interesting thing is unsigned __int8 is considered to be equivilant
to unsigned char, so as the other types (short, int, long) that we look
for here, so only the specialization for __int8 is added here.
This will fix builds on Visual Studio 2008 at least.
2018-12-19 22:26:54 -05:00
798e98c47b
[CFF] bad offset in Index ( #1476 )
...
* Update hb-ot-cff-common.hh
* fix bug
* bummer fix wasn't hit. refix
* additional sanity check
* Added test cases for oss-fuzz issues 11805, 11806
2018-12-12 21:08:15 -05:00
bcb4ecaf68
[CFF] check out of range FD index ( #1477 )
...
* add fd index checks to subr subsetter
also added oss-fuzz test case
* undid SubrSubsetParam::is_valid
because already validated by SubrClosures.valid
2018-12-12 20:36:01 -05:00
a33f238f88
Merge pull request #1474 from fanc999/master.msvc
...
Few fixes for Visual Studio builds
2018-12-12 12:44:06 +03:30
9844c880e2
Minor
2018-12-11 17:28:04 -05:00
2941208f1e
[CFF] oss-fuzz issue 11690 ASSERT: substr.offset >= opStart ( #1461 )
...
* fix oss-fuzz 11690: substr.offset >= opStart
detect recursive subroutine call & handle as error
* fix build failure
* add minimized test case for oss-fuzz 11690
* removed asserts
2018-12-11 15:21:24 -05:00
b225593d6b
Correct REPLACEMENT CHARACTER's code point to FFFD ( #1471 )
2018-12-11 13:19:17 -05:00
1e09add232
test/api: Fix building on pre-C99 compilers
...
Ensure variables are declared at the top of the block.
2018-12-12 01:32:01 +08:00
ae087d10c2
add minimized test case for oss-fuzz issue 11714
2018-12-05 21:47:34 -08:00
f95324a335
Merge pull request #1457 from harfbuzz/cff-varstore-sanitize
...
[CFF] oss-fuzz issue 11713 (CFF2VariationStore::serialize)
2018-12-06 08:33:44 +03:30
9d8f3b0dfb
add minimized test case for oss-fuzz issue 11713
2018-12-05 17:14:51 -08:00
34e3ef8ff3
Merge branch 'master' into cff-subr-sanitize
2018-12-05 15:50:05 -08:00
72d8f76368
add minimized test case for oss-fuzz issue 11691
2018-12-05 15:49:11 -08:00
d9dabc00e9
Merge pull request #1454 from harfbuzz/cff-fixbcd
...
[CFF] fix oss-fuzz issue 11674: parse_bcd
2018-12-05 15:39:34 -08:00
6708c5595f
fix oss-fuzz issue 11675 (ASSERT: count <= str.len)
...
Also added an additional error check to avail ()
2018-12-05 12:51:18 -08:00
010e2ddb38
minimized test case for oss-fuzz issue 11674
2018-12-05 12:23:58 -08:00
79e7e3445e
Merge pull request #1449 from harfbuzz/cff-fixcharset
...
[CFF] fix for oss-fuzz 11657: Charset overrun
2018-12-05 13:25:18 +03:30
cf4b7db6b1
Merge pull request #1448 from harfbuzz/cff-leak
...
[CFF] fix leak: oss-fuzz 11662
2018-12-05 13:23:23 +03:30
32cc46c75a
[CFF] fix oss-fuzz issue 11670: NULL dereference ( #1450 )
...
* guard against no subr access
* code tweak
* add minimized testcase for oss-fuzz 11670 (Null deference)
2018-12-05 09:02:34 +03:30
78f639b8bf
added minimized testcase for oss-fuzz issue 11657
2018-12-04 14:17:03 -08:00
b61f74f69a
added minimized test case for oss-fuzz issue 11662
2018-12-04 10:30:35 -08:00
c968869f21
Merge pull request #1441 from harfbuzz/cff-doublenum
...
use double as CFF Number implementation
2018-12-04 04:14:13 -05:00
c48f53d309
more double changes
2018-12-03 16:59:41 -08:00
9424e80526
added minimized test cases
2018-12-03 16:18:10 -08:00
5fff6ab002
additional precision made a difference in extents test
2018-12-03 16:06:58 -08:00
01f628cf55
[aat] Expose hb_aat_layout_has_tracking API
2018-12-03 22:27:26 +03:30
84efe0438e
[aat] Fix division sign fallout
...
Happened after 11d2f49af8
2018-12-02 12:39:14 -05:00
967a204ee9
Minor
2018-12-01 19:28:17 -05:00
9ae954f43a
Merge branch 'master' into cff-subset
2018-11-30 15:00:52 -08:00
bf738ba3ba
[test][aat] Remove extra --shaper ot
...
As run-tests.py already adds it
2018-11-30 00:06:40 +03:30
1a182e97ee
[test/text-rendering-tests] Update from upstream
2018-11-29 12:39:52 -05:00
e0307de818
[test][aat.kern] More ( #1427 )
2018-11-29 11:36:05 +03:30
32d291ae89
Merge branch 'master' into cff-subset
2018-11-28 16:27:45 -08:00
7b78d2233d
[test][aat] Update expectency
...
It is not visually noticeable but apparently affected by kern format2 correct implementation.
I should've checked CoreText result which can't as CircleCI outage.
2018-11-29 00:55:05 +03:30
5155067e10
[test] Add test for format2 kern ( #1423 )
2018-11-29 00:07:00 +03:30
19863c8059
[test][aat] Add a test and make macOS runners faster ( #1422 )
2018-11-28 20:28:42 +03:30
97eaedca5d
[test][aat] Enable Tamil MN test ( #1414 )
2018-11-26 16:58:58 +03:30
0e3a48e542
[test][aat] fix 10.13.6 Helvetica expectation
2018-11-25 13:37:23 +03:30
cbc541b426
[aat] Add m grave test ( #1412 )
2018-11-25 12:50:30 +03:30
fa26ad0f48
[aat] Fix macos expectation
2018-11-25 11:25:17 +03:30
926f512f35
[aat.feat] Rework API and implementation
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1346
2018-11-25 01:16:02 -05:00
2cb235d021
[aat.feat] Fix enum namespace
2018-11-25 01:16:02 -05:00
e20f81f4fa
[aat] Rename feat API a bit more
2018-11-25 01:16:02 -05:00
54f4c17f0a
[feat] Rename API uses of setting to selector
2018-11-25 01:16:02 -05:00
9c64b216ec
[feat] Apply renamings and add documentation
2018-11-25 01:16:02 -05:00
4009a05ca7
[feat] Address Behdad comments
2018-11-25 01:16:02 -05:00
19b6025534
[feat] Address @behdad comments
2018-11-25 01:16:02 -05:00
fbad794bd2
[feat] Add feature iteration API
2018-11-25 01:16:02 -05:00
7a0471aa35
[feat] Turn AAT feature id into enum
2018-11-25 01:16:02 -05:00
a157b3e4eb
[feat] Apply @behdad comments
2018-11-25 01:16:02 -05:00
3aff3f822f
[feat] Apply @drott and @jfkthame comments
2018-11-25 01:16:02 -05:00
b791bbbae4
[feat] Apply @jfkthame reviews
2018-11-25 01:16:01 -05:00
95abd53758
[feat] Expose public API
...
* hb_aat_get_feature_settings
2018-11-25 01:16:01 -05:00
264c4a539c
[test] Reorder test suites
...
aots is less interesting. Run text-rendering-tests before aots.
2018-11-25 01:16:01 -05:00
248ce22857
[tests] Minor
2018-11-24 22:01:06 -05:00
e6877e28cd
[test] Add the missed aots fonts
2018-11-25 02:14:41 +03:30
825ea5a460
[test] Merge 10.12.6 and 10.13.6 tests, update to Apple Chancery fix
2018-11-25 02:14:41 +03:30
b518e5af9f
Add 10.13.6 aat fonts tests and bot ( #1409 )
2018-11-25 01:39:00 +03:30
b7f7950e8f
[aat] Add test for recent regression
2018-11-24 15:56:17 -05:00
ea9512e61a
[tests] Redo test runner logging a bit
2018-11-24 15:49:33 -05:00
5020affc38
[tests] Minor
2018-11-24 15:42:11 -05:00
ee3a3e10d4
[tests/shaping] Allow comments in test files
...
Line should start with "# ".
2018-11-24 15:40:50 -05:00
ed900ee9af
[tests] Rename
2018-11-24 15:22:09 -05:00
3cc14e78ae
[test] Enable more of aots tests ( #1408 )
...
The ones commented out in this change should've be passed :/
a closer look is needed.
2018-11-24 20:49:21 +03:30
24887d1115
Add Adobe AOTS tests ( #1395 )
...
Annotated OpenType Specification or aots, https://github.com/adobe-type-tools/aots
provides a set of tests for OpenType specification, this change add those tests in addition
to modified version of their HarfBuzz test runner for generating harfbuzz project specific tests.
2018-11-24 20:07:24 +03:30
1204a247a5
[fuzzing] Add tests for previous commit
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11526
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11522
2018-11-24 09:49:21 -05:00
018ba46e4d
Don't canonicalize '@' to '-' in language tags
...
Fixes #1406 .
2018-11-23 13:21:22 -05:00
c9cc96c0cf
[aat] Update expectation
2018-11-23 19:58:56 +03:30
341851efe1
[aat] Add macOS specific tests ( #1404 )
2018-11-23 15:40:05 +03:30
8280459e74
Merge pull request #1291 from harfbuzz/use-reordering
...
[use] Fix reordering
2018-11-22 22:39:12 -05:00
2c8188bf59
[kerx] Make sure subtables are non-zero-length
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11400
2018-11-22 22:02:19 -05:00
8982830d3e
[subset] add fuzzer testcase.
2018-11-22 21:30:01 -05:00
264439c6c3
Test U+111C9 SHARADA SANDHI MARK
2018-11-21 16:33:45 -05:00
f48bb9a393
[var] Deprecated axis enumeration API and add new version
...
New version has axis flags.
New API:
+hb_ot_var_axis_info_t
+hb_ot_var_find_axis_info()
+hb_ot_var_get_axis_infos()
Deprecated API:
-HB_OT_VAR_NO_AXIS_INDEX
-hb_ot_var_axis_t
-hb_ot_var_find_axis()
-hb_ot_var_get_axes()
2018-11-20 20:46:14 -05:00
1ecbf4d3e3
Merge branch 'master' into cff-subset
2018-11-20 17:19:05 -08:00
831ba74382
Fix Codacy "issues"
2018-11-20 01:16:08 -05:00
3c7792ca32
[use] Fix reordering
...
Fixes #1235 .
2018-11-19 16:49:40 -05:00
515f1a1614
Merge branch 'master' into cff-subset
2018-11-16 17:38:47 -08:00
cff4c6087f
Fix vertical fallback space sign
...
Ouch!
Follow-up to cf203af8a3https://github.com/harfbuzz/harfbuzz/issues/1343
2018-11-16 15:04:41 -08:00
b67a7c731f
drop dotsection as hint along with test case
2018-11-16 12:28:24 -08:00
072c7aba92
use 2-byte offset instead of 4-byte for local subrs
...
more than enough since local subrs immediately follow its corresponding private dict, as the result 2-byte redunction for each font dict with local subrs
updated api test expected subset fonts accordingly
2018-11-15 15:41:46 -08:00
892ab37e7c
Merge branch 'master' into cff-subset
2018-11-14 13:54:07 -08:00
3787c07856
Implemented seac for extents & subset along with API tests
2018-11-14 13:38:03 -08:00
e543e1a085
Add Grantha test
2018-11-13 20:44:27 -08:00
5212cd8af2
[fuzzing] Add new test
2018-11-12 14:25:18 -05:00
d6666b3866
[fuzzing] Remove limited-edition build of libraries
...
Use normal, production, shared libraries.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1237
2018-11-12 13:21:14 -05:00
a549aa14a0
[kerx] Protect against stack underflow
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11367
2018-11-12 13:02:39 -05:00
41a8bc7fd9
Merge branch 'master' into cff-subset
2018-11-12 08:49:00 -08:00
0dfa584cb4
changed Adobe company name
2018-11-12 08:47:07 -08:00
752bd8a192
[kerx] Fix Format1 tupleKern sanitization
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11312
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11305
2018-11-10 21:13:32 -05:00
f9e0552deb
[fuzzing] Make "make lib" faster and more usable
2018-11-10 21:06:56 -05:00
fb2a037f54
Merge branch 'master' into cff-subset
2018-11-10 16:23:11 -08:00
3a9fa8c026
[qsort] Fix O(N^2) behavior if all array elements are the same
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11327
Reported as https://github.com/noporpoise/sort_r/issues/7
2018-11-10 01:58:26 -05:00
f51bb6ee7b
Merge pull request #1358 from ebraminio/lcar
...
Hook AAT's lcar to _get_ligature_carets
2018-11-08 14:42:40 -05:00
b986fead0a
Hook AAT's lcar to _get_ligature_carets
2018-11-08 23:06:26 +03:30
9fae611740
[test/text-rendering-tests] Update from upstream
2018-11-08 12:26:38 -05:00
26c291aaa0
Merge branch 'master' into cff-subset
2018-11-08 09:06:49 -08:00
0bf76154f1
[fuzzing] Take whatever text we can
2018-11-07 19:12:27 -05:00
0996c0ff62
implented no-desubroutinize with CFF2 along with API test
...
replaced AdobeVFPrototype.abc.otf with a hinted (maually) & subroutinized copy
replaced expected results as well
2018-11-07 14:48:37 -08:00
43ee0e4d00
Merge branch 'master' into cff-subset
2018-11-06 09:57:17 -08:00
5c3ccbc634
Another missing backlash
...
Did this ever work?
2018-11-06 18:10:56 +02:00
d29602b962
Add missing backslash
2018-11-06 18:07:47 +02:00
8790b2740a
[fuzzing] Fix test
2018-11-06 10:24:54 -05:00
3af0a7edd0
[fuzzing] Add make check-valgrind
2018-11-06 10:20:57 -05:00
b062378ce6
[test] Minor
2018-11-06 10:20:36 -05:00
b6112e5ea4
[test] Fix -Weverything bot complain
2018-11-06 11:42:47 +03:30
a49df419f0
[test] Test hb_ot_name_{list_names,get_utf8} on test-ot-name
2018-11-06 11:26:30 +03:30
6482fda519
[fuzzing] Fuzz glyph-id etc in test-ot-face
2018-11-05 15:03:18 -05:00
1682d1bbec
Merge branch 'master' into cff-subset
2018-11-04 13:25:41 -08:00
d8fadec098
added desubroutinize full font test profiles & expected fonts
...
modified subset_test_suite.py to apply desubroutinize profiles to CFF only (not to TT)
2018-11-04 13:12:20 -08:00
bce437cf0b
[test] Call test-ot-face.c test from hb-shape-fuzzer
...
Should increase coverage...
2018-11-04 02:53:25 -05:00
777c22425c
[test] More funcs in test-ot-face
2018-11-04 02:40:20 -05:00
9779e602ed
[test] Add test for empty face
2018-11-03 20:50:56 -04:00
b8a78ce201
[BASE] Improvements ( #1347 )
2018-11-03 22:28:30 +03:30
c560ca9251
[fuzz] A new testcase
2018-11-03 13:03:36 +03:30
34b06d994a
fixed FDSelect size calcluation
2018-11-02 16:40:20 -07:00
481fdfdc23
Merge branch 'cff-subset' of https://github.com/harfbuzz/harfbuzz into cff-subset
2018-11-02 15:28:09 -07:00
1bc710a8c9
added CFF1 desubr api test cases & bug fixes
2018-11-02 15:28:01 -07:00
e600e5440b
Merge branch 'master' into cff-subset
2018-11-01 16:13:56 -07:00
cad90be4ea
[test] minor
2018-11-01 13:39:06 +03:30
f928931948
[test] Minor
2018-10-31 18:27:09 -07:00
cf203af8a3
Implement space fallback in vertical direction
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1343
2018-10-31 18:27:09 -07:00
69297bb216
[fuzzing] Call hb-ot-color API
2018-10-30 19:07:38 -07:00
a7aba99baa
[name] Rename hb_name_id_t to hb_ot_name_id_t
...
https://github.com/harfbuzz/harfbuzz/pull/1254
2018-10-30 14:04:09 -07:00
0af3d176a6
[sbix] Fix memory leak in early return
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11210
2018-10-30 17:05:28 +02:00
56738429d6
[test] Fix warnings
2018-10-30 01:33:22 -07:00
64e41d2c89
[test] Fix Python3
2018-10-30 01:08:34 -07:00
Michiharu Ariza
Garret Rieger
Behdad Esfahbod
Tor Arne Vestbø
cclauss
fanc999
Ebrahim Byagowi
David Corbett
Chun-wei Fan
punchcutter
Khaled Hosny