7d497a3a92
[debug] Allow return_trace() to return any type
2019-05-02 16:20:03 -07:00
91176d5b77
[serialize] Check offset base is within (possibly end of) object
2019-05-02 15:12:07 -07:00
0f1a6ce826
[name] Fix format of susbetted table to 0
2019-05-02 15:03:41 -07:00
87810fc958
[name] Use variable forwarding to simplify sanitize()
2019-05-02 14:45:57 -07:00
bf91b418b0
[name]
2019-05-02 14:43:22 -07:00
998b0b68ac
[serializer] Add copy() to (Unsized)ArrayOf
2019-05-02 14:39:52 -07:00
88a4147240
[serializer] Accept exact type in serialize_subset/copy()
2019-05-02 14:22:31 -07:00
88fdeeecc0
[serialize] Take arguments in copy()
2019-05-02 14:14:33 -07:00
273ed6127b
[serializer] Add serialize_copy()
2019-05-02 14:04:51 -07:00
bf22338f49
Remove dead code
2019-05-02 13:51:52 -07:00
157a414bd9
fix mixup of TRACE_SUBSET/SERIALIZE
2019-05-02 11:25:10 -07:00
14e1fabc41
Sync gen-vowel-constraints.py with current output
2019-05-01 21:29:06 -04:00
026ab825c8
Add dotted circles to more broken clusters
2019-05-01 13:59:34 -07:00
92588782d7
Remove space between right angle brackets now that we have C++11 ( #1689 )
2019-04-30 13:05:10 -07:00
f27fdca4aa
[doc] Add documentation to hb_color_get_* and hb_directwrite_face_* ( #1690 )
2019-04-30 13:01:04 -07:00
c52294eb28
renaming & arg reorder
2019-04-30 10:40:45 -07:00
fe4a0ac707
Fix some dead links
2019-04-30 13:35:50 -04:00
1223a352b7
Merge branch 'master' into var-subset
2019-04-29 16:43:48 -07:00
9542bdd0ed
Add color channels getters ABI ( #1513 )
...
So can be used with language wrappers
2019-04-29 14:52:28 -07:00
4aa546b70a
Allow some Balinese Po & So as aksara modre bases
2019-04-29 11:37:35 -07:00
6977a95fed
[subset] Don't crash if subsetting GSUB/GPOS fails
...
Fixes fuzzer issue.
2019-04-27 10:05:25 -07:00
2b051e7aa1
[subset] Check error after calling serializer end
2019-04-27 10:01:11 -07:00
750b65e9a9
[meta] Add hb_type_identity<>
...
To block template argument deduction.
2019-04-26 17:14:25 -07:00
8c8922a019
[subset] Updates due to changes in resolve_links() on master branch
2019-04-26 15:24:47 -07:00
2f6ec35344
Move implementations of hb-ot-name-language.cc into a hb-static.cc
2019-04-26 15:24:47 -07:00
19afd25004
[subset] Update to use _subset2() for name table
2019-04-26 15:24:47 -07:00
1ca4b5c770
[subset] Add unit test for str de-dup
...
Also move the implementation of some methods from the .cc to the .hh
2019-04-26 15:24:47 -07:00
9ad14f56b6
[subset] update name table subsetting with new serializer
2019-04-26 15:24:47 -07:00
e501ea143d
[subset] Subset name table step 3, add --nameids option to guide the
...
selection of which name records to keep in the subset method.
2019-04-26 15:24:47 -07:00
2637a81615
[subset] subset name table step 2, add implementation for collecting subset
...
elements and serialize method
2019-04-26 15:24:47 -07:00
408c1daeb4
[subset] subset name table step 1, write out table unmodified, use accelerator to access
...
string
2019-04-26 15:24:47 -07:00
3a7f5bdd18
Rewrite hb_is_signed()
2019-04-26 14:40:01 -07:00
73c82f2301
[iter] Fix hb_is_iterator_of() to actually check item type
2019-04-26 13:16:48 -07:00
c51f15ddfc
[array] Adjust hb_sorted_array_t copy constructor/assignment to match hb_array_t
2019-04-26 13:04:06 -07:00
b2758c360c
[array] Use hb_is_cr_convertible_to()
2019-04-26 13:04:06 -07:00
8ecae793aa
[meta] Add hb_is_cr_convertible_to()
2019-04-26 13:04:06 -07:00
52bb0346d3
[meta] Add hb_decay<>
2019-04-26 13:04:06 -07:00
474f3587cd
copy retain_gids from input to plan
2019-04-26 10:12:38 -07:00
c69f02784a
Fix sign-compare error on 32-bit systems
2019-04-24 16:31:37 -07:00
59a8fa5353
[iter] Add tests for casting to hb_iter_t<> base class for hb_sorted_array_t<>
...
Something's phishy about hb_sorted_array_t<>. Can't get it work nicely with
change I'm making. Ugh..
2019-04-24 12:49:58 -04:00
714307cc43
[iter] Remove fixed TODO
2019-04-24 10:56:12 -04:00
22da12318a
[map] Fix TODO
2019-04-24 10:53:47 -04:00
4c6136e976
[mutex] Remove TODO
2019-04-24 10:53:44 -04:00
0268db1196
[map] Use hb_invoke() with pointer-to-method
2019-04-24 10:53:39 -04:00
8f79a5750e
[algs] Add more hb_forward<>()'s
2019-04-24 10:32:49 -04:00
42526d1697
[serialize] Fix SingleSubstFormat1 failure
2019-04-24 10:24:33 -04:00
6cc9707c9c
[serialize] Rename
2019-04-24 10:22:06 -04:00
085793d6cd
Remove wrong TODOs
2019-04-24 10:15:59 -04:00
915b9ea5f4
[serialize] Add c->check_assign()
...
To check for assignment overflows.
2019-04-24 10:07:19 -04:00
00a00bc1f2
Fix two TODOs
2019-04-24 10:01:30 -04:00
11ab889a8d
Rename a few test programs
2019-04-24 09:55:24 -04:00
12017db0bf
Move test code around
2019-04-24 09:24:38 -04:00
27377a7e28
Rely on variadic parameter pack more
2019-04-24 09:22:14 -04:00
3ad20c38ad
[serialize] Fix a few overflow TODO items
2019-04-24 09:09:00 -04:00
175bdad8bf
One more variadic parameter pack use
2019-04-23 23:57:11 -04:00
441cca2354
Use hb_forward() when forwarding parameter pack
2019-04-23 23:51:59 -04:00
20f3134789
Use variadic templates in OffsetTo<> and various ArrayOf<>s
2019-04-23 12:59:17 -04:00
64ca2ffa4c
Fix clang's -Wmain complain ( #1678 )
2019-04-23 01:10:46 -07:00
25dd88efc6
Err, fix hb_invoke() variadic
2019-04-22 17:47:07 -04:00
c862a532df
Add variadic arguments to hb_invoke()
2019-04-22 17:32:19 -04:00
9c724e48a2
[serializer] Add err_propagaged_error()
2019-04-22 17:21:42 -04:00
ae8da4b61b
Minor
2019-04-22 15:25:11 -04:00
24da1d0860
Use variadic template args for propagate_error()
...
Let's see if bots happy.
Not sure where else we can use these. Mm. Maybe in hb_invoke().
2019-04-22 15:20:25 -04:00
9bab398462
Simplify propagate_error()
2019-04-22 15:16:35 -04:00
42f4bd6b80
Minor warning fix again
2019-04-18 19:06:07 -04:00
267fb9c716
add spaces
2019-04-18 18:18:05 -04:00
ba0386060d
fix oss-fuzz issue 14345
2019-04-18 18:18:05 -04:00
63a2108480
silence MVC warnings 3rd attempt
2019-04-18 13:54:58 -07:00
705dde57fe
silence MVC warnings 2nd attempt
2019-04-18 11:32:10 -07:00
dd4c37529b
silence MVC warnings
2019-04-18 10:38:57 -07:00
518e6e07f2
Minor
2019-04-18 12:21:25 -04:00
91d958acc0
[array] Simplify copy assignment/constructor
...
To fix bogus MSVC warnings:
c:\projects\harfbuzz\src\hb-array.hh(189): warning C4521: 'hb_array_t<Type>': multiple copy constructors specified [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
c:\projects\harfbuzz\src\hb-array.hh(189): warning C4522: 'hb_array_t<Type>': multiple assignment operators specified [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
2019-04-18 10:04:10 -04:00
693d91cd49
[serialize] Fix offset calculation
2019-04-17 17:59:39 -04:00
db0c9a1485
[subset] Assert offsets are zero during relocation
...
If they're not, it's a bug in our subsetting logic somewhere. So check.
2019-04-17 17:58:13 -04:00
aa3ac59245
fix build
2019-04-17 12:43:53 -07:00
c87488b46d
Merge branch 'master' into var-subset
2019-04-17 12:07:15 -07:00
efbba7ad26
[serializer] Add copy()
...
Calls obj.copy() or obj.operator=() in that order.
2019-04-17 11:00:08 -04:00
c67a0d581f
Add HB_RETURN
2019-04-17 10:29:10 -04:00
6745a600bf
Comment out ot_languages where fallback suffices
2019-04-17 10:28:59 -04:00
5daeff3e68
Fix "hb_script_" doc typo
2019-04-17 10:06:13 -04:00
6916b77863
One more auto return type
2019-04-16 18:33:51 -04:00
5b33427f2c
Rename HB_AUTO_RETURN_EXPR to HB_AUTO_RETURN
2019-04-16 18:28:17 -04:00
da293b0e59
Use HB_AUTO_RETURN_EXPR in hb_min/max
2019-04-16 18:27:25 -04:00
0241a40f2a
Use auto return type for hb_first/hb_second
2019-04-16 18:26:30 -04:00
fe30fcd228
Use hb_deref_pointer() to reduce number of overloads
2019-04-16 17:34:06 -04:00
c918a6706f
Properly prioritize hb_hash()
2019-04-16 17:28:18 -04:00
75fd845a4a
Move around
2019-04-16 17:22:29 -04:00
973717175d
Fix priorities
2019-04-16 16:50:07 -04:00
54ece299bc
Use type aliasing for meta-functions, ie. those returning a type
2019-04-16 16:45:53 -04:00
6cde814a36
Merge branch 'master' into var-subset
2019-04-16 11:35:07 -07:00
007bb3e0d1
retain-gids in HVAR/VVAR (unused deltas retained)
2019-04-16 10:33:51 -07:00
1ce11b4437
Reduce LangTag from 3 language system tags to 1
2019-04-16 11:41:01 -04:00
155e92f259
Reduce NullPool size
2019-04-16 11:35:09 -04:00
4fc2d2d724
[meta] Flesh out hb_invoke()
2019-04-16 11:24:42 -04:00
e03d9395aa
Comment
2019-04-16 11:20:16 -04:00
b8e763fd71
[meta] Add hb_invoke()
2019-04-16 10:54:24 -04:00
a3fcb9a370
[meta] Add HB_AUTO_RETURN_EXPR, HB_VOID_RETURN_EXPR, hb_priority, hb_has(), hb_get()
...
The first three based on range-v3.
2019-04-16 10:45:57 -04:00
ff68be31bf
Add hb_void_tt<> ala std::void_t
2019-04-16 09:59:51 -04:00
eb348fc5c0
optimize out regions & region index lists & short count
2019-04-15 16:24:22 -07:00
89fea21697
Fix copyright
2019-04-15 17:36:09 -04:00
07776b6096
More tweaks to previous commit
...
Delete assignment operator of OffsetTo<> instead of Offset<>.
In simple ArrayOf<>::sanitize() assert that Type has assignment operator.
Ideally we should SFINAE this and fallback to calling Type::sanitize()
if assignment operator is not available. But we don't have a case of
that in the codebase.
2019-04-15 16:43:34 -04:00
699de689e9
Delete default assignment operator Offset<>
2019-04-15 16:00:20 -04:00
02d864aa26
Add HB_FUNCOBJ()
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1651
2019-04-15 15:39:30 -04:00
38b1d0b9b2
Move static const to post-struct for a function object
...
Just sending this to bots to see if all happy, then turn it into macro and
apply everywhere.
Part of https://github.com/harfbuzz/harfbuzz/issues/1651
2019-04-15 12:45:21 -04:00
19e800c9d8
Ugh. Another try, to unbreak gcc this time!
...
Jenga.
2019-04-15 12:07:00 -04:00
3a88f55c15
Move location of HB_UNUSED to make MSVC happy
2019-04-15 11:59:57 -04:00
1ae265888e
Fix gcc warning
2019-04-15 11:31:40 -04:00
cd9889cac3
Docs: update and extended GTK-Doc comments for hb-ot-math.
2019-04-14 15:33:56 +01:00
3f74b7a14b
Docs: Regularize GTK-Doc comments for hb-ot-color.
2019-04-14 15:20:56 +01:00
47e538a35f
Add HB_NO_SUBSET_LAYOUT
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 22:54:15 -04:00
a98e4068e7
Revert "Hide symbols in hb-iter"
...
This reverts commit 98f14c4cdb
2019-04-12 22:42:44 -04:00
dab92bdd46
Revert "Hide more symbols"
...
This reverts commit 2e86d50915
2019-04-12 22:39:38 -04:00
98f14c4cdb
Hide symbols in hb-iter
...
Painful. All template methods need to be explicitly hidden :(.
Maybe we should switch to -fvisibility=hidden pragma.
A LOT more to go.
2019-04-12 18:12:06 -04:00
2e86d50915
Hide more symbols
...
Exposed by:
$ make -j5 CPPFLAGS="-O0" CXXFLAGS=-flto=thin LDFLAGS=-lc++ && ./check-symbols.sh
2019-04-12 18:07:42 -04:00
caa20e4ef9
Hide a few more symbols
...
Exposed by:
$ make CPPFLAGS=-O0
2019-04-12 18:00:58 -04:00
95df00aec1
Hide a few static methods
...
Looks like static methods that do not get inlined end up exported.
We have a lot more. Need to protect all at some point. Wish there
was an easier way, like the visibility flag we pass that automatically
hides all inline methods.
Was exposed by check-symbols.sh when compiling on OS X 10.14 with:
$ make CPPFLAGS=-Oz CXXFLAGS=-flto=thin LDFLAGS=-lc++
2019-04-12 17:51:14 -04:00
2f4be4ba54
Add HB_NO_OPTIONS
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 16:21:58 -04:00
3e524bf772
fix VarData serialize to remove unused data sets
...
add api test case for that
2019-04-12 12:48:48 -07:00
079d2dcbb2
Add HB_NO_NAME_TABLE_AAT
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 15:00:37 -04:00
60a58aa61c
Add HB_NO_OT_FONT_BITMAP
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 14:58:53 -04:00
160c4d8b2d
Add HB_NO_OT_FONT_CFF
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 14:57:49 -04:00
35f3b97fac
Add HB_NO_OT_SHAPE_COMPLEX_HEBREW_FALLBACK
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 10:16:12 -04:00
414c5de26b
Add HB_NO_OT_SHAPE_FALLBACK
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 10:12:11 -04:00
fe0018f7ef
Add HB_NO_OT_SHAPE_COMPLEX_THAI_FALLBACK
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 09:35:29 -04:00
9ddbfa006d
Add HB_NO_OT_LAYOUT_BLACKLIST
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-12 09:33:25 -04:00
571fad4cf1
Add HB_NO_OT_SHAPE_COMPLEX_VOWEL_CONSTRAINTS
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-11 19:42:05 -04:00
a90e4916df
Merge branch 'master' into var-subset
2019-04-11 15:57:32 -07:00
3db227265b
Update gtk-doc annotations for inout counts on various getter functions.
2019-04-12 00:00:47 +02:00
c08ddbd91b
[Docs] Minor edits to gtk-doc inline comment review.
2019-04-12 00:00:47 +02:00
af5230bce3
[Docs] Minor; fix formatting for gtk-doc multiple-annotations.
2019-04-12 00:00:47 +02:00
6c0a1e8cd6
[Docs] Annotate gtk-doc formatting with some un-annotated (out)s.
2019-04-12 00:00:47 +02:00
5122805c74
[Docs] Fix gtk-doc formatting for (out) and (inout).
2019-04-12 00:00:47 +02:00
d3178aa52a
[Docs] Fix gtk-doc references to 'kern' table functions, clarifying that GPOS is not examined.
2019-04-12 00:00:47 +02:00
3449031fad
[Docs] Add inline gtk-doc documentation of GDEF glyph classes.
2019-04-12 00:00:47 +02:00
930f6fc3da
[Docs] Add inlind gtk-doc comments for hb-ot-layout functions.
2019-04-12 00:00:47 +02:00
945737026d
tweak: moved xshift code out of get_points_var
2019-04-11 10:52:11 -07:00
e814083202
undo hb_ot_ge_glyph_v_origin to fix test failures
2019-04-11 09:59:13 -07:00
b52c0e54b9
Use injected class name to simplify macros
2019-04-11 11:20:10 -04:00
baf1e79075
[C++11] Use deleted methods
2019-04-11 11:18:04 -04:00
824fd342d5
Rename a few macros
2019-04-11 11:16:01 -04:00
9e79285ef3
Merge branch 'master' into var-subset
2019-04-10 17:24:29 -07:00
6d79a25bed
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-04-10 17:23:00 -07:00
ab9d30965d
Add tt var metrics test cases & bug fixes
2019-04-10 17:21:37 -07:00
edfc6be4a0
[arabic] Disable fallback shaping if HB_NO_OT_SHAPE_COMPLEX_ARABIC_FALLBACK defined
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-10 16:10:54 -04:00
4d31662b5d
Don't install ot-font funcs on new fonts if HB_NO_OT_FONT defined
...
Currently linker cannot GC hb-ot-font completely because we install
it on fonts by default. Don't do that if HB_NO_OT_FONT defined.
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-10 15:40:55 -04:00
b111b3de02
Don't use any default unicode funcs if HB_NO_UNICODE_FUNCS is defined
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1652
2019-04-10 15:39:48 -04:00
c5509be93a
[coretext] Fix unused-variable error
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1659
2019-04-08 14:50:58 -04:00
196481ccb9
shift glyph horizontally at top level, not components
2019-04-05 16:37:12 -07:00
8a92ffd9bb
fix failure to check glyf recursion
2019-04-05 15:04:23 -07:00
4c19aa2620
Fix MSVC C4068 warning ( #1656 )
2019-04-05 11:46:27 -07:00
a96d003d6e
Fix MSVC C4138 warning ( #1657 )
2019-04-05 02:29:56 -07:00
c68eb7002f
Minor
2019-04-03 16:24:12 -07:00
85adf4ad5c
[GDEF] Don't assume glyphlist is sorted
...
As was hit by the fuzzer.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=14032
2019-04-03 16:07:36 -07:00
ecabdffc61
[algs] Add hb_min() and hb_max()
2019-04-03 16:06:34 -07:00
7b863142ce
[serialize] Make putting breakpoint on out-of-memory easier
2019-04-03 15:48:27 -07:00
2bd2750234
[iter] Tweak SFINAE again
...
Don't think we need hb_is_same().
2019-04-03 15:31:53 -07:00
f02ebc89ec
[array] Add compy assignment operator since copy constructor is explicit
2019-04-03 15:23:06 -07:00
20a73da2c9
[array] Add default copy constructor
...
MSVC seems to need it.
2019-04-03 14:32:15 -07:00
d419a9a437
[iter] Use different SFINAE scheme to make MSVC happy
...
From Orvid King: TLDR; MSVC has some issues using sizeof(declval<T>()) for
SFINAE of templated types, so I just used SFINAE in a different context where
MSVC doesn't have the issue.
2019-04-03 14:18:19 -07:00
2778df7972
[meta] Add hb_is_same()
2019-04-03 14:15:01 -07:00
b999ce9bf0
Merge branch 'master' into var-subset
2019-04-03 10:34:09 -07:00
c2d727a479
fix xshift by (lsb - xMin)
2019-04-03 10:33:55 -07:00
6215fb8e68
[serialize] Actually reclaim storage from duplicate objects
2019-04-02 23:10:03 -07:00
3305a2cad2
[serialize] Port to use object pool
...
Tested, but feels fragile :(.
2019-04-02 22:58:49 -07:00
5efbc01174
[pool] Uses memset() instead of assigning Null()
...
Assignment is invalid on invalid object.
2019-04-02 22:41:06 -07:00
434d78bf91
Add hb_pool_t<> for pooled memory allocation
2019-04-02 21:46:40 -07:00
8e4df1a152
[serialize] Disable packed_map again
...
Ugh. Need to think of something else.
2019-04-02 20:20:53 -07:00
31c1a83899
[map] Protect more against pointer deref
2019-04-02 20:17:27 -07:00
5bffa9e375
More
2019-04-02 20:13:16 -07:00
5b66b033fd
[serialize] Fix hb_hashmap_t<> for pointers and use in packed_map
2019-04-02 19:30:22 -07:00
42ab32cbba
[iter] Remove passing pointer to hb_iter()
...
While doable with hb_deref_pointer() as well, we also would then
need to do it in a ton of places. Not worth it / messy.
2019-04-02 18:42:51 -07:00
d0da547b37
[array] Use dagger for hashing array
...
Also switch to better mixing.
2019-04-02 18:23:05 -07:00
b6f29bf141
[iter] Accept pointers in hb_iter()
...
No idea how to avoid dupicating code. Was hoping hb_deref_pointer()
would do it, but looks like a pointer can't bind to a universal
reference T&&. Humm.
2019-04-02 18:12:01 -07:00
fc24bb9046
[serialize] Towards maintaining packed_map
2019-04-02 17:49:52 -07:00
aa2293a55e
[serialize] Minor
2019-04-02 17:42:10 -07:00
e42b82c828
[serialize] Handle non-nullable offsets
2019-04-02 17:23:16 -07:00
e04518bafc
[serialize] Movce empty-object handling earlier
2019-04-02 17:20:04 -07:00
7f73c9744e
[serialize] Minor
2019-04-02 17:12:24 -07:00
27d3bac8ef
fix 2x2 component transform
2019-04-02 17:02:11 -07:00
5a3de4f4f8
[serialize] Allow offset links that have base offset from the object base
...
Rarely used, but used, in name table or similar constructs.
2019-04-02 16:53:42 -07:00
edad6b2c45
[test][iter] minor, fix double promotion warning
2019-04-03 00:48:59 +04:30
8801b80d72
refix: orig_points must be saved before any adjustment
2019-04-02 13:10:36 -07:00
ee58f6012e
infer gvar deltas for each region (not after accumulation)
2019-04-02 11:24:29 -07:00
2c31652c8a
fix private_indices vs shared_indices
2019-04-02 10:07:43 -07:00
062f5d6e7a
[test] minor, c style comments
2019-04-02 20:27:00 +04:30
afdbf960d6
[iter][test] Add another test for hb_reduce
...
Different initial and accumulator types
2019-04-02 20:25:06 +04:30
bfa02bef45
[serialize] Switch to tetris-packing
2019-04-01 21:36:13 -07:00
f0ea3ac17b
[serialize] Fix linking
2019-04-01 21:36:03 -07:00
7c0e2054e0
[serialize] Minor
2019-04-01 21:32:29 -07:00
dce9e5e622
fix get_start_tuple, get_end_tuple
2019-04-01 20:55:02 -07:00
64d0f08938
[cmap] Minor
2019-04-01 16:56:41 -07:00
2e675cc7b5
[subset] Call serialize start/end around it
...
To be cleaned up.
2019-04-01 16:56:41 -07:00
abe33c6149
[serialize] Assert stack
2019-04-01 16:56:41 -07:00
72e9b2c16c
[serialize] Add add_link() to add link
2019-04-01 16:56:41 -07:00
74addbecac
[serialize] Add default template type to push()
2019-04-01 16:56:41 -07:00
b8642087e6
[iter] hb_reduce, accumulator with a different type
2019-04-01 16:56:29 -07:00
e526414c75
[iter] Implement hb_reduce
2019-04-01 16:56:29 -07:00
72545cb839
fixed off by one bug in apply_deltas_to_points()
2019-04-01 16:49:15 -07:00
f3aca6aa26
[serialize] Implement linking
...
Untested!
2019-03-31 21:37:14 -07:00
17f0cfa7ea
Move BEInt to hb.hh
...
I knows...
2019-03-31 21:34:19 -07:00
78fc43f293
[iter] Fix up build, ouch
...
Yeah, some things not very clear...
2019-03-31 19:17:07 -07:00
e5d6fe9782
Don't skip setting the .end field of the first range
...
Fixes a bug in CoverageFormat2::serialize whereby the first range
was not serialized correctly if it consists of only a single glyph ID.
This broke shaping of U+0626 in the Arabic fallback shaper, because it
is not found in the coverage table of the 'init' and 'medi' lookups.
Also fix similar bug in ClassDefFormat2::serialize, noted during code
inspection (I haven't observed a case that was actually affected by
this, but it looks broken).
Fixes https://github.com/harfbuzz/harfbuzz/issues/1504
2019-03-31 19:02:47 -07:00
8a8d45b924
[iter] Adjust hb_copy() and use it
...
Untested.
2019-03-31 19:00:09 -07:00
ba4b7be455
Remove coretext_aat shaper ( #1581 )
...
coretext_aat was a temporary shaper to redirect shaping of AAT fonts
to CoreText and leaving the rest for HarfBuzz. As HarfBuzz now supports
AAT and Chrome now actually ships that on a stable version on macOS,
we no longer care about such use-case. If a client really wants 100%
metrics compatibility with CoreText better to use it directly or through
our API. Replicating the same behavior still is possible using
hb_shape_full, something we don't care or like to offer anymore.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1478
2019-03-31 01:32:30 -07:00
ef11305bfd
fixed tt var extents
...
max bounds were not correctly initialized
2019-03-31 00:23:58 -07:00
f7700fc479
Merge branch 'master' into var-subset
2019-03-30 20:49:34 -07:00
d6005b49b3
[serialize] Start implementing linking
2019-03-30 19:49:56 -07:00
313b3057c3
[serializer] Implement dedup!
2019-03-30 19:46:35 -07:00
b189bbc48f
Implement hashing of objects
...
Should be improved for hb_bytes_t.
2019-03-30 19:41:48 -07:00
d6b28057a5
Fix hb_hash(pointer)
2019-03-30 19:31:51 -07:00
d74dc3ef65
[serialize] Don't insert empty object into tree
2019-03-30 19:26:37 -07:00
7fd8228326
[serialize] Towards maintaining hashmap
2019-03-30 19:16:20 -07:00
f254f45a1e
[serialize] Only pack main object if there are other objects
...
Avoids a memmove for tables that don't use the object packing mechanism.
2019-03-30 19:05:51 -07:00
946d446f9b
[serialize] Copy both sides of the buffer
2019-03-30 19:03:55 -07:00
8512dc565d
[serialize] Simplify copy
2019-03-30 19:01:23 -07:00
43725d3632
Merge branch 'master' into var-subset
2019-03-30 18:51:15 -07:00
0b1fe7b716
[serializer] Unbreak for now
2019-03-30 18:48:26 -07:00
10f062234e
[map] Shuffle fini code
2019-03-30 18:44:01 -07:00
e6b78003ef
[vector] Add move semantics
2019-03-30 18:33:30 -07:00
4c4d3c3ed5
[vector] Add some move and forwarding
2019-03-30 18:30:50 -07:00
7c9ceabcef
[meta] Add hb_move and hb_forward ala std::
2019-03-30 18:23:24 -07:00
9a19b885f9
[serialize] Flesh out packing
2019-03-30 18:14:30 -07:00
357c7c611c
[vector] Add copy constructor and assignment operator
2019-03-30 18:13:57 -07:00
6f69c9d26f
[serialize] Minor
2019-03-30 18:00:03 -07:00
a43290192b
[serialize] Add packed_map
2019-03-30 17:57:33 -07:00
bed150bd2e
[serialize] Start fleshing out object stack
2019-03-30 17:43:43 -07:00
63c3565189
[serialize] Simplify propagate_error()
2019-03-30 17:12:40 -07:00
dbe9ba6711
[serialize] Add object_t, link_t, and snapshot_t
2019-03-30 17:10:59 -07:00
38d57b9a66
[map] Add another TODO item
2019-03-30 16:38:06 -07:00
7fd940f899
[map] Add TODO
2019-03-30 16:29:19 -07:00
6dcf7c4017
[serialize] Add unused 'tail'
2019-03-30 15:08:39 -07:00
fe05e48086
[serialize] Add ran_out_of_room
2019-03-30 15:06:25 -07:00
a7c63cd8f8
Split sanitize and dispatch into their own files
2019-03-30 14:59:40 -07:00
be66b575fc
Move serializer to hb-serialize.hh
2019-03-30 14:53:54 -07:00
bb22462f29
Whitespace
2019-03-30 14:46:54 -07:00
ef33b5d1f6
[map] Deref pointers before equality check
2019-03-30 14:39:21 -07:00
c98f51da71
[map] Templatize hb_map_t
...
Template name is hb_hashmap_t<K,V>.
2019-03-30 14:32:52 -07:00
294d520f65
more iter changes from master
2019-03-30 13:58:22 -07:00
4b7f4dbc0c
Add hb_deref_pointer()
2019-03-30 13:48:32 -07:00
8f2ce82f76
hb.hh from master
2019-03-30 11:50:24 -07:00
3bfd3a367c
fix build
2019-03-30 00:27:02 -07:00
c7ca8853ae
more change set() to =
2019-03-30 00:11:58 -07:00
d75b73a309
fix rebase errors
2019-03-30 00:06:54 -07:00
3fbd242ba6
replace .set() with =
...
remove .gitignore
2019-03-29 23:53:06 -07:00
cc94a9ed3b
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
...
rebase master
2019-03-29 23:37:50 -07:00
e530692799
[iter] Fix bug in hb_any() and hb_none()
2019-03-29 23:31:39 -07:00
ce6093a96b
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-03-29 23:24:12 -07:00
a1177fec8f
Merge branch 'master' into var-subset
...
rebase master
2019-03-29 23:23:49 -07:00
f505b5d5c9
[iter] Port remaining "for (auto" instances to daggers
2019-03-29 22:55:02 -07:00
668d2d562f
[iter] One more dagger
2019-03-29 22:48:38 -07:00
d51452500f
[iter] Remove more wrong &&'s
...
Sigh...
2019-03-29 22:48:12 -07:00
05f2130a1c
[iter] More daggers
2019-03-29 22:43:12 -07:00
22ec4c3aa5
[iter] More daggers
2019-03-29 22:29:00 -07:00
688069bbfb
[iter] One more dagger
2019-03-29 22:17:31 -07:00
90b60bd690
Remove HB_DEBUG_WOULD_APPLY
...
Not that useful.
2019-03-29 22:12:42 -07:00
4d28267e59
[iter] Port more to daggers
2019-03-29 22:04:15 -07:00
9d8c72042b
Whitespace
2019-03-29 21:59:28 -07:00
418e9d07e2
Simplify code
2019-03-29 21:57:26 -07:00
f5ef8a7347
[iter] Port one more function to dagger
2019-03-29 21:57:17 -07:00
bcab098c8f
[iter] Port more code to daggers
2019-03-29 21:49:18 -07:00
4c75158e18
[iter] Port two more functions to daggers
2019-03-29 21:46:13 -07:00
e70ccbe9ed
Fix pair signature
...
Oh well. Again, who does fully understand what is right???
2019-03-29 21:45:49 -07:00
6237b47f0c
[iter] Add hb_unzip()
2019-03-29 21:36:49 -07:00
f1dad91eb3
Whitespace
2019-03-29 21:17:08 -07:00
896b31670d
[iter] Port two more loops to dagger
2019-03-29 21:16:30 -07:00
8e34cb251a
[iter] Remove unneeded &&
...
Next commit needs this. I never fully get this, sigh.
2019-03-29 21:14:20 -07:00
12a4c0441f
Whitespace
2019-03-29 21:06:10 -07:00
4c38a9f601
Remove hb_assign()
...
Not needed anymore. We just use operator= now.
2019-03-29 20:23:07 -07:00
b986c6a321
[C++11] Remove IntType::set() in favor of operator=
2019-03-29 20:21:21 -07:00
58ad357951
[vector] Accept all types in push(...)
...
Let assignment operator worry about conversion.
2019-03-29 20:05:19 -07:00
489faf826c
[C++11] Use type aliases for template partial instantiations
2019-03-29 20:01:37 -07:00
435bc7f3e2
Update hb-ot-var-gvar-table.hh
2019-03-29 18:39:30 -07:00
8fdb8fcf80
fix rebase errors
2019-03-29 18:39:27 -07:00
1ccb457cbb
fix gvar fuzz bug
2019-03-29 18:28:25 -07:00
3f84589232
2.4.0
2019-03-29 18:27:21 -07:00
282c76d9a0
Use internal bsearch() for language tags
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1639
2019-03-29 18:27:21 -07:00
3bed03dc6a
[indic] Add back medial-consonant to grammar
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1592
2019-03-29 18:27:21 -07:00
f8803fbace
[khmer] Add trailing Coeng to syllable grammar
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1541
2019-03-29 18:27:21 -07:00
f84342c094
minor
2019-03-29 18:27:21 -07:00
3e18447c64
fixed a fuzzer bug
2019-03-29 18:27:21 -07:00
4774283a2c
Fix shell syntax error
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1612
2019-03-29 18:27:21 -07:00
4b763affa6
Comment
2019-03-29 18:27:21 -07:00
d9d6649bf2
Override USE category for Grantha and Tirhuta visargas to allow marks
2019-03-29 18:27:21 -07:00
13ae138af3
Disable unwanted C++ definitions for MSVC.
...
MSVC does not set __cplusplus to the latest standard and also it does not like redefining some keywords.
2019-03-29 18:27:21 -07:00
53d40426e1
tweaked recursion checks
2019-03-29 18:27:21 -07:00
4f351754bb
add recursion checks
2019-03-29 18:27:21 -07:00
0008963b28
add support of anchor point & SCALED/UNSCALED_COMPONENT_OFFSET
...
some code cleanup
2019-03-29 18:27:21 -07:00
ea281aa8d0
Use class templates for Null objects
...
This allows partial-instantiating custom Null object for template Lookup<T>.
Before, this had to be handcoded per instantiation. Apparently I missed
adding one for AAT::ankr.lookupTable, so it was getting the wrong (generic)
null for Lookup object, which is wrong and unsafe.
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=944346
2019-03-29 18:27:21 -07:00
1dfc2dfff5
[aat] Add missing check to ankr table
...
Isn't absolutely needed. But helps.
2019-03-29 18:27:21 -07:00
2f97cd7a52
completely remove lines that are commented out
2019-03-29 18:27:21 -07:00
e74d646d9e
update arguments in_populate_gids_to_retain() and _create_old_gid_to_new_gid_map()
...
so they don't use deprecated variable
2019-03-29 18:27:21 -07:00
b12a5daad7
try to remove deprecated variable from struct definition
2019-03-29 18:27:21 -07:00
ae3db1f4e3
added api test for subset VVAR & bug fix
...
added a mod copy of SourceSerifVariable-Roman.ttf with VVAR as a test font
2019-03-29 18:27:08 -07:00
fe5aa8b36c
added TT VF full font test & fixed bugs
...
updated CFF2 VF api test results too
2019-03-29 18:26:46 -07:00
212dcb758c
add api test cases for HVAR with index map (and fix)
2019-03-29 18:26:20 -07:00
6ee71166b0
add api tests for subset gvar & HVAR; bug fixes
2019-03-29 18:26:20 -07:00
84d0af456b
move rounding advance width to glyf
2019-03-29 18:26:20 -07:00
10f264da75
fix empty glyf's advance width
2019-03-29 18:26:20 -07:00
511518c759
add api test for tt var advance widths
...
stripped HVAR from SourceSansVariable-Roman.abc.ttf so glyf gets parsed
2019-03-29 18:26:20 -07:00
bee8d86671
fix build
2019-03-29 18:26:20 -07:00
f74712a4e0
fix composite glyf extents
2019-03-29 18:26:20 -07:00
cd817e7955
fix unpack_points
2019-03-29 18:26:20 -07:00
a35e3dfc77
fix infer_delta
...
code cleanup
2019-03-29 18:26:20 -07:00
4f4fbb1d5e
added explicit casts to metrics
2019-03-29 18:25:52 -07:00
c302ec6d94
moved most of var code from gvar to glyf
...
initialize phantom points from metrics from htmx/vmtx & glyf bbox before execution
added source file hb-ot-hmtx-table.cc to call glyf from hmtx/vmtx indirectly & temporarily, workaround a cyclic reference between the two
2019-03-29 18:25:52 -07:00
bd040a4354
add components transformation
2019-03-29 18:25:35 -07:00
139e87b56c
fix tt var extents & add test
2019-03-29 18:25:35 -07:00
9584b090bb
cff2 subset fuzzer issues ( #1619 )
...
* add check to FDArray::serialize
* add test files
* fix off by one
2019-03-29 18:25:21 -07:00
161e61fc3b
minor edits
2019-03-29 18:25:06 -07:00
ebbfe36510
calculate VF advance widths from gvar & glyf
2019-03-29 18:24:24 -07:00
9690461a91
Added hb-ot-var-gvar-table.hh
...
implemented sanitize()
placeholder subset()
some code cleanup
2019-03-29 18:22:32 -07:00
9168b32a1b
renamed hb_map2_t to hb_bimap_h in its own .hh
2019-03-29 18:21:50 -07:00
d102c7a652
unuse set in hb_map2_t impl
...
also some code cleanup
2019-03-29 18:21:15 -07:00
dd67214210
subset HVAR
...
Re-implemented & repurposed CFF:remap_t as hb_map2_t (moved to hb-ot-layout-common.hh) for two-way mapping for use by index map subsetting.
Hooked up HVAR subsetter through _subset2.
Some renaming in CFF code.
2019-03-29 18:20:22 -07:00
5bbe78a0f3
Allow zero length ranges in sanitization ( #1617 )
...
Fixes fvar table sanitization where there are no named instance
by allowing zero length ranges starting from Null() address.
Fixes #1607
2019-03-29 18:15:00 -07:00
5d7725ad1a
Categorize U+09FC as Consonant_Placeholder
2019-03-29 18:15:00 -07:00
628d457c87
add gvar::get_extents
2019-03-29 18:15:00 -07:00
7b27fe5255
Remove redundant hb_ot_layout_lookup_would_substitute_fast
2019-03-29 18:15:00 -07:00
56164f754f
[doc] Add placeholder since version for new flag
2019-03-29 18:15:00 -07:00
cb758f2669
Remove obsolete overrides from Indic/USE scripts
2019-03-29 18:15:00 -07:00
40c4bd3e12
Update generation code for hb-ot-shape-complex-vowel-constraints.cc. Remove 'unlikely'
2019-03-29 18:15:00 -07:00
ce7f2c4da3
Fix coding style.
2019-03-29 18:15:00 -07:00
a86356913e
Add a flag to hb_buffer_t to prevent the insertion of dotted circles on incorrect character sequences.
...
Current behavior unchanged if this flag is not set (and it isn't by default).
2019-03-29 18:15:00 -07:00
4a19d3b080
Update to Unicode 12.0.0
2019-03-29 18:15:00 -07:00
4f03d5c79d
[indic] Remove superfluous ZWNJ check in final reorder of pre-base matras
2019-03-29 18:15:00 -07:00
7b7852efa5
Fix hb_atomic_* variants based on C++11 atomics
...
I stumbled over this when trying to upgrade the version of HarfBuzz used by
LibreOffice to 3.2.1 (see <https://gerrit.libreoffice.org/plugins/gitiles/core/
+/b7ddc514bff9bdf682abae537f990aa01dc2c0fb%5E!/> "Upgrade to latest
HarfBuzz 2.3.1"), where building with MSVC 2017 failed like
> c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2440: 'reinterpret_cast': cannot convert from 'const int *' to 'std::atomic<int> *'
> c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): note: Conversion loses qualifiers
> c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2227: left of '->load' must point to class/struct/union/generic type
(see <https://ci.libreoffice.org/job/gerrit_windows/29916/ >).
I added all the necessary "const" to make building of HarfBuzz 2.3.1 with
MSVC 2017 succeed for me. There may be more missing at least conceptually.
2019-03-29 18:14:59 -07:00
7296242046
Fix offset drift in graphite integration
2019-03-29 18:14:59 -07:00
5fc99b3d34
fix build
2019-03-29 18:14:59 -07:00
696b841a5a
minor edits
2019-03-29 18:14:59 -07:00
14be8b9e87
build fix attempt
2019-03-29 18:14:59 -07:00
618de1c7f9
more build fixes
2019-03-29 18:14:59 -07:00
f2c556594a
fix build attempt
2019-03-29 18:14:59 -07:00
40dfca7213
calculate VF advance widths from gvar & glyf
2019-03-29 18:14:59 -07:00
d0b6d539f6
Make hb_subset_input_glyph_set () actually do something.
2019-03-29 18:14:59 -07:00
a842fdfbf0
gvar::subset()
2019-03-29 18:14:59 -07:00
c2e9d75035
[dwrite] hb_directwrite_face_create, a new API
...
It makes a hb_face_t from IDWriteFontFace, useful when using
DirectWrite facilities for font selection, loading and rendering
but using harfbuzz for shaping.
2019-03-29 18:14:59 -07:00
2c5ed7f152
Added hb-ot-var-gvar-table.hh
...
implemented sanitize()
placeholder subset()
some code cleanup
2019-03-29 18:14:59 -07:00
087b9a0ad0
Fix or document unsupported font-feature-settings
2019-03-29 18:14:59 -07:00
f1e97c189e
renamed hb_map2_t to hb_bimap_h in its own .hh
2019-03-29 18:14:59 -07:00
655bc96bc2
subset VVAR & outer indices
2019-03-29 18:14:59 -07:00
6ecfaaa6d5
unuse set in hb_map2_t impl
...
also some code cleanup
2019-03-29 18:14:59 -07:00
a762cf5033
fixed compiler gripes
2019-03-29 18:14:59 -07:00
a00d1d5e74
fix CFF2 local subr subsetting
...
bug exposed by impl change of fdmap
also fixed name of subr_remap_ts as subr_remaps_t
2019-03-29 18:14:59 -07:00
8bd9d28e2a
fix HVAR & VarStore subsetting
2019-03-29 18:14:59 -07:00
4fd02f6ee5
Remove unused line
2019-03-29 17:58:23 -07:00
9a5b15dc1e
[C++11] Replace BEInt.set() with operator=
2019-03-29 17:58:19 -07:00
0aa59b1de3
[C++11] Add operator= to IntType<>
...
Now that we require C++11 we can do this.
2019-03-29 17:58:15 -07:00
eca466e6b1
Err. Fixup C++11 polyfill removal
...
Fixes 1d75db19fb
2019-03-29 15:59:04 -07:00
3f36c89f2e
Inline explicit_operator macro
...
Now that we require C++11, no need to macro.
2019-03-29 15:22:46 -07:00
1d75db19fb
Remove C++<11 polyfill
...
Leaving hb-atomic.hh as is since harmless and other projects might
copy from that file.
2019-03-29 15:20:34 -07:00
8e7887ca5f
Merge branch 'master' into iter
2019-03-29 14:37:04 -07:00
b292772e6e
[dwrite] A new API, hb_directwrite_face_get_font_face ( #1600 )
...
Can be useful when using HarfBuzz for font loading and shaping
but using DirectWrite for rendering.
2019-03-29 13:00:56 -07:00
59f36f3682
Replace REPLACEME's left out of 2.4.0
...
https://github.com/harfbuzz/harfbuzz/issues/1641
2019-03-29 10:55:12 -07:00
443db2a246
[iter] Remove hb_len()
...
Not planning on using it. So remove. Can add later if needed.
2019-03-29 10:47:13 -07:00
ddb84dcece
fix gvar fuzz bug
2019-03-29 10:32:42 -07:00
bdd5a9c48d
Add hb_hash()
...
I don't like the hb_remove_reference() hack, but necessary.
2019-03-28 21:58:07 -07:00
343e6063dc
Add hb_is_integer(T)
2019-03-28 21:44:12 -07:00
f639b9a8ea
[iter] Add hb_len() function-object
2019-03-28 21:34:47 -07:00
a030ce4ff8
Merge branch 'master' into iter
2019-03-28 21:26:50 -07:00
d6fc1d49aa
2.4.0
2019-03-28 21:21:26 -07:00
d2db71fdc4
Use internal bsearch() for language tags
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1639
2019-03-28 21:04:34 -07:00
21bb80ebf2
[indic] Add back medial-consonant to grammar
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1592
2019-03-28 20:50:04 -07:00
5ab6de7a6f
[khmer] Add trailing Coeng to syllable grammar
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1541
2019-03-28 20:23:12 -07:00
58c8c7a495
Merge branch 'master' into var-subset
2019-03-28 16:17:41 -07:00
485fe06f74
minor
2019-03-28 16:17:36 -07:00
5f36771c2a
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-03-28 15:07:53 -07:00
99f0c107f7
fixed a fuzzer bug
2019-03-28 15:07:49 -07:00
160b4a2b01
Fix shell syntax error
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1612
2019-03-28 13:44:59 -07:00
8665b9b0a2
Comment
2019-03-28 13:44:59 -07:00
a7eed7e41d
Override USE category for Grantha and Tirhuta visargas to allow marks
2019-03-28 13:31:45 -07:00
cf040c0fef
Disable unwanted C++ definitions for MSVC.
...
MSVC does not set __cplusplus to the latest standard and also it does not like redefining some keywords.
2019-03-28 11:10:42 -07:00
061bd0a99b
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-03-27 08:53:50 -07:00
67175987bd
tweaked recursion checks
2019-03-27 08:52:46 -07:00
feb712d8d8
add recursion checks
2019-03-26 20:35:01 -07:00
bcd689bb10
Merge branch 'master' into var-subset
2019-03-26 17:13:31 -07:00
49f9359632
add support of anchor point & SCALED/UNSCALED_COMPONENT_OFFSET
...
some code cleanup
2019-03-26 17:10:46 -07:00
ec2a5dc859
Use class templates for Null objects
...
This allows partial-instantiating custom Null object for template Lookup<T>.
Before, this had to be handcoded per instantiation. Apparently I missed
adding one for AAT::ankr.lookupTable, so it was getting the wrong (generic)
null for Lookup object, which is wrong and unsafe.
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=944346
2019-03-26 16:23:40 -07:00
96f1237794
[aat] Add missing check to ankr table
...
Isn't absolutely needed. But helps.
2019-03-26 16:17:45 -07:00
2d9034491e
completely remove lines that are commented out
2019-03-26 13:39:33 -07:00
3147133b61
update arguments in_populate_gids_to_retain() and _create_old_gid_to_new_gid_map()
...
so they don't use deprecated variable
2019-03-26 13:39:33 -07:00
79a6c25849
try to remove deprecated variable from struct definition
2019-03-26 13:39:33 -07:00
3c4f041e9e
fix uninitialized memory bug
2019-03-22 10:26:48 -07:00
d2a0149c29
added api test for subset VVAR & bug fix
...
added a mod copy of SourceSerifVariable-Roman.ttf with VVAR as a test font
2019-03-21 18:09:37 -07:00
8ec279072e
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-03-21 10:38:12 -07:00
0593a95e28
refix short count
2019-03-21 10:36:53 -07:00
5390e39342
Merge branch 'var-subset' of https://github.com/harfbuzz/harfbuzz into var-subset
2019-03-21 10:21:50 -07:00
084be9a0f4
Merge branch 'master' into var-subset
2019-03-21 10:21:31 -07:00
5f15fca662
fix short count optimization
2019-03-21 10:18:03 -07:00
325918172e
added TT VF full font test & fixed bugs
...
updated CFF2 VF api test results too
2019-03-20 15:10:59 -07:00
1051faf7aa
add api test cases for HVAR with index map (and fix)
2019-03-19 16:00:01 -07:00
2e6038a209
add api tests for subset gvar & HVAR; bug fixes
2019-03-19 00:41:41 -07:00
560bcd7744
move rounding advance width to glyf
2019-03-18 17:50:20 -07:00
c7edd14dc9
fix empty glyf's advance width
2019-03-18 17:16:43 -07:00
9d3a252030
add api test for tt var advance widths
...
stripped HVAR from SourceSansVariable-Roman.abc.ttf so glyf gets parsed
2019-03-18 15:39:10 -07:00
9d9d5c706b
fix build
2019-03-18 10:48:53 -07:00
b6cc838888
fix composite glyf extents
2019-03-17 22:49:18 -07:00
597ad4df0c
fix unpack_points
2019-03-17 18:45:30 -07:00
cabe22fc69
fix infer_delta
...
code cleanup
2019-03-17 17:48:10 -07:00
c8b31773a6
added explicit casts to metrics
2019-03-17 16:01:49 -07:00
8a7998fd6c
moved most of var code from gvar to glyf
...
initialize phantom points from metrics from htmx/vmtx & glyf bbox before execution
added source file hb-ot-hmtx-table.cc to call glyf from hmtx/vmtx indirectly & temporarily, workaround a cyclic reference between the two
2019-03-17 15:36:26 -07:00
00b2653ac3
add components transformation
2019-03-16 16:27:33 -07:00
434ea06841
fix tt var extents & add test
2019-03-16 00:08:03 -07:00
bcb4e505d6
cff2 subset fuzzer issues ( #1619 )
...
* add check to FDArray::serialize
* add test files
* fix off by one
2019-03-15 13:46:25 -07:00
d23c201f5d
add gvar::get_extents
2019-03-14 16:58:02 -07:00
dde8bb1f6d
fix build
2019-03-14 16:58:02 -07:00
5ec65f779b
minor edits
2019-03-14 16:58:02 -07:00
2d7ad3f28b
build fix attempt
2019-03-14 16:58:02 -07:00
cf2ef92c74
more build fixes
2019-03-14 16:58:02 -07:00
ae0a557c2e
fix build attempt
2019-03-14 16:58:02 -07:00
baf2ccf147
calculate VF advance widths from gvar & glyf
2019-03-14 16:58:02 -07:00
0b1ae2385b
gvar::subset()
2019-03-14 16:58:02 -07:00
eddbc9d0db
Added hb-ot-var-gvar-table.hh
...
implemented sanitize()
placeholder subset()
some code cleanup
2019-03-14 16:58:02 -07:00
f289ffe5ea
renamed hb_map2_t to hb_bimap_h in its own .hh
2019-03-14 16:58:02 -07:00
8563169291
subset VVAR & outer indices
2019-03-14 16:58:02 -07:00
08dc86594b
unuse set in hb_map2_t impl
...
also some code cleanup
2019-03-14 16:58:02 -07:00
1b13cc775c
fixed compiler gripes
2019-03-14 16:58:02 -07:00
c485b77c7c
fix CFF2 local subr subsetting
...
bug exposed by impl change of fdmap
also fixed name of subr_remap_ts as subr_remaps_t
2019-03-14 16:58:02 -07:00
c9b07c75a1
fix HVAR & VarStore subsetting
2019-03-14 16:58:02 -07:00
c8420109cc
subset HVAR
...
Re-implemented & repurposed CFF:remap_t as hb_map2_t (moved to hb-ot-layout-common.hh) for two-way mapping for use by index map subsetting.
Hooked up HVAR subsetter through _subset2.
Some renaming in CFF code.
2019-03-14 16:58:02 -07:00
8aaab78efc
Allow zero length ranges in sanitization ( #1617 )
...
Fixes fvar table sanitization where there are no named instance
by allowing zero length ranges starting from Null() address.
Fixes #1607
2019-03-14 16:49:42 -07:00
7de9f92ee9
Categorize U+09FC as Consonant_Placeholder
2019-03-13 12:59:56 -07:00
e52ec3fc23
Remove redundant hb_ot_layout_lookup_would_substitute_fast
2019-03-11 18:09:51 -07:00
c2442c90d6
[doc] Add placeholder since version for new flag
2019-03-12 01:10:52 +02:00
8c42f03215
Remove obsolete overrides from Indic/USE scripts
2019-03-11 16:07:52 -07:00
b38bab8622
Update generation code for hb-ot-shape-complex-vowel-constraints.cc. Remove 'unlikely'
2019-03-11 16:06:41 -07:00
44a67ddeb8
Fix coding style.
2019-03-11 16:06:41 -07:00
30d7c40f8c
Add a flag to hb_buffer_t to prevent the insertion of dotted circles on incorrect character sequences.
...
Current behavior unchanged if this flag is not set (and it isn't by default).
2019-03-11 16:06:41 -07:00
e723c04de1
Update to Unicode 12.0.0
2019-03-07 10:15:31 -08:00
2f125b0fa7
[indic] Remove superfluous ZWNJ check in final reorder of pre-base matras
2019-03-05 16:41:49 -08:00
d936ad4582
Fix hb_atomic_* variants based on C++11 atomics
...
I stumbled over this when trying to upgrade the version of HarfBuzz used by
LibreOffice to 3.2.1 (see <https://gerrit.libreoffice.org/plugins/gitiles/core/
+/b7ddc514bff9bdf682abae537f990aa01dc2c0fb%5E!/> "Upgrade to latest
HarfBuzz 2.3.1"), where building with MSVC 2017 failed like
> c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2440: 'reinterpret_cast': cannot convert from 'const int *' to 'std::atomic<int> *'
> c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): note: Conversion loses qualifiers
> c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2227: left of '->load' must point to class/struct/union/generic type
(see <https://ci.libreoffice.org/job/gerrit_windows/29916/ >).
I added all the necessary "const" to make building of HarfBuzz 2.3.1 with
MSVC 2017 succeed for me. There may be more missing at least conceptually.
2019-03-05 12:11:32 -08:00
731b13e4e9
Fix offset drift in graphite integration
2019-03-03 22:10:46 -08:00
4f37ab63de
Make hb_subset_input_glyph_set () actually do something.
2019-03-01 10:49:46 -08:00
45149eb34f
[dwrite] hb_directwrite_face_create, a new API
...
It makes a hb_face_t from IDWriteFontFace, useful when using
DirectWrite facilities for font selection, loading and rendering
but using harfbuzz for shaping.
2019-02-26 15:42:38 -08:00
45adc18526
Fix or document unsupported font-feature-settings
2019-02-25 17:48:16 -05:00
09df17e71b
subset HVAR
...
Re-implemented & repurposed CFF:remap_t as hb_map2_t (moved to hb-ot-layout-common.hh) for two-way mapping for use by index map subsetting.
Hooked up HVAR subsetter through _subset2.
Some renaming in CFF code.
2019-02-20 15:48:29 -08:00
93739242e1
minor edit
2019-02-20 13:23:12 -08:00
eebc21c8de
fix crash in hb_map_t::clear()
...
in case called immediately after init()
2019-02-20 12:43:18 -08:00
d29c8424c8
Typo ( #1588 )
...
Fixed a small typo.
[skip ci]
2019-02-19 20:05:00 +03:30
6bd4c082e4
[doc] Document hb_feature_from_string() syntax
...
Copied and edited from the util option documentation. The docbook table
syntax is too verbose, but that is the best I can come up with.
2019-02-18 17:00:44 -08:00
11456b2d9c
WHitespace
2019-02-15 16:58:43 -08:00
77060bcda2
[iter] Add hb_all, hb_any, hb_none
2019-02-15 16:55:08 -08:00
72dd5e34e0
[iter] Make hb_iter() into function-object
2019-02-15 16:15:50 -08:00
98be7bd77a
[iter] Make hb_map into function-object
2019-02-15 16:09:29 -08:00
c1e5ba81fe
Merge remote-tracking branch 'origin/master' into iter
2019-02-15 16:06:03 -08:00
b8b3b3e38b
[iter] Add hb_enumerate() and use it
2019-02-15 16:05:36 -08:00
3da79dd5b9
Merge pull request #1557 from harfbuzz/cff-more-arrayof-fixes
...
CFF more arrayof fixes
2019-02-15 15:54:51 -08:00
d8a68728a0
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-15 14:48:10 -08:00
90c8bbf987
Merge branch 'master' into cff-retain-gids
2019-02-15 14:47:38 -08:00
5c2bb1de8d
Support xlclang++ on AIX. ( #1584 )
2019-02-15 21:53:46 +03:30
1558a43342
[test] Minor
2019-02-14 20:46:13 -08:00
fa373584de
[algs] Test pair more
2019-02-14 20:15:07 -08:00
0d7af5fb02
[algs] Use universal references for hb_pair()
...
Such that it carries lvalues inside.
2019-02-14 19:37:57 -08:00
5b99c92d4c
[iter] Use more
2019-02-14 17:10:04 -08:00
72c1b59588
[iter] Use in more places
2019-02-14 15:43:20 -08:00
40cce41eae
[iter] Use in a couple more intersects() calls
2019-02-14 15:14:37 -08:00
bafdf1829d
[iter] Use in a couple more closure() calls
2019-02-14 15:13:16 -08:00
fa35d3fd81
[iter] Add hb_drain
2019-02-14 14:04:05 -08:00
f4cfd6b6ad
[iter] A couple more hb_apply() + lambda uses
2019-02-14 13:45:52 -08:00
7514a49f21
[iter] Use hb_apply() with lambda functions in a few places
2019-02-14 13:16:33 -08:00
0670e1a6f5
[iter] Remove excess use of universal references
...
Every time I have to study these to understand why a change is right..
2019-02-14 11:53:40 -08:00
773d75637c
[iter] Add hb_apply()
2019-02-14 11:40:22 -08:00
00db94095d
[iter] Make hb_filter() a function-object
2019-02-14 11:10:13 -08:00
aa4c321262
[iter] Make hb_zip() a function-object
2019-02-14 11:07:12 -08:00
f8fcfb263e
[iter] Accept pointers to hb_sink()
2019-02-14 11:03:29 -08:00
b530573ad9
[iter] Make hb_sink function-object
2019-02-14 11:00:10 -08:00
bb139cb8d0
[iter] Back to dagger formatting for pipelines
2019-02-14 10:52:02 -08:00
5fa52e62b1
[iter] Accept iterator, not iterable, in hb_sink()()
2019-02-14 10:51:02 -08:00
0f292ea85f
[iter] Accept iterator, not iterable, in hb_filter()()
2019-02-14 10:49:31 -08:00
345bfbb207
[iter] Accept iterator, not iterable, in hb_map()()
2019-02-14 10:48:20 -08:00
16cc313dcd
[iter] Use hb_sink()
2019-02-14 10:40:05 -08:00
b702a0cbf8
[iter] Add hb_sink()
2019-02-14 10:39:58 -08:00
1cb1d5d7fb
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-14 10:09:19 -08:00
6f1dfd082c
Merge branch 'master' into cff-retain-gids
2019-02-14 10:08:16 -08:00
7d2376de33
Merge branch 'master' into iter
2019-02-13 22:13:37 -08:00
890d0ee77f
Minor, use a meaningful naming in template parameter ( #1582 )
2019-02-14 00:27:01 +03:30
8a568a8858
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-13 11:25:00 -08:00
b1dbc77fa6
Merge branch 'master' into cff-retain-gids
2019-02-13 11:24:38 -08:00
1e1d0e63df
Fix djgpp complains by tweaking templates ( #1579 )
...
For some reasons djgpp doesn't understand "unsigned int" can be same
with one of uint*_t anyway so lets do that for it explicitly.
Just to note, our CI's djgpp is based GCC 7.2.0 and isn't old.
2019-02-13 12:58:01 +03:30
bc33c617b8
Merge branch 'master' into cff-retain-gids
2019-02-12 15:10:50 -08:00
c6af846178
tweaked --desubroutinize to remove hintmask only subrs
2019-02-12 15:10:43 -08:00
c83412e4ce
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-11 14:16:25 -08:00
fdfa3d29b7
hb-coretext.cc: remove TARGET_OS_MAC from test ( #1578 )
...
it is always true when building on APPLE systems
and this file only builds on APPLE systems
2019-02-11 11:16:05 +03:30
e2856c2d85
retain FDSelect & FDArray with --retain-gids
...
so in sync with fonttools behavior
2019-02-07 15:32:32 -08:00
1239b6b2b4
Merge branch 'master' into cff-more-arrayof-fixes
2019-02-07 10:29:40 -08:00
a5fa76977b
Merge branch 'master' into cff-retain-gids
2019-02-07 10:28:13 -08:00
214d0b024b
minor change
2019-02-07 10:27:43 -08:00
7859decdd0
hb-coretext.cc: clean up macosx test
...
TARGET_OS_OSX was introduced only in late OS versions
so always returns as "0" on older systems.
if !TARGET_OS_IPHONE can work, as it returns as !0 on older
systems where TARGET_OS_IPHONE is not defined, but is not
specific
if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
is both specific and accurate on all systems.
2019-02-05 20:26:49 -08:00
30b781f20a
Merge branch 'master' into cff-retain-gids
2019-02-01 14:50:34 -08:00
c12862657f
added desubroutinize & retain-gids full test cases with CFF fonts
...
and CFF retain-gids fixes
2019-02-01 14:50:01 -08:00
f2908b4d8f
Implement subset --regain-gids option with CFF1/2
...
along with api tests & expected results
2019-01-31 14:16:37 -08:00
1e06282105
Adjust hb_is_signed<>
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1535
2019-01-31 13:57:17 -08:00
21ea1c9152
Remove stale comment
2019-01-31 13:57:17 -08:00
9f80eb0177
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-31 12:54:36 -08:00
2d940946d5
[iter] Fix mystery crash
...
Fuzzer caught it:
==14==ERROR: AddressSanitizer: stack-use-after-return on address 0x7fca2ed7a3e0 at pc 0x0000006057aa bp 0x7ffc3290f1d0 sp 0x7ffc3290f1c8
READ of size 4 at 0x7fca2ed7a3e0 thread T0
SCARINESS: 55 (4-byte-read-stack-use-after-return)
#0 0x6057a9 in OT::SingleSubstFormat2::subset(hb_subset_context_t*) const /src/harfbuzz/src/./hb-ot-layout-gsub-table.hh:194:40
#1 0x5ff921 in hb_subset_context_t::return_t OT::SingleSubst::dispatch<hb_subset_context_t>(hb_subset_context_t*) const /src/harfbuzz/src/./hb-ot-layout-gsub-table.hh:256:13
I can't reproduce locally, but many of the bots are failing because of this
as well.
It's a pity that operator-> must return pointer. Ugh. Why?!
2019-01-30 16:03:16 -08:00
cbe2118c58
Merge branch 'master' into iter
2019-01-30 15:07:09 -08:00
7c292c0853
[iter] Warning fix
...
Not sure why I don't get it, but this warning:
warning: base class ‘struct hb_iter_fallback_mixin_t<hb_array_t<const OT::UVSMapping>, const OT::UVSMapping&>’ should be explicitly initialized in the copy constructor [-Wextra]
2019-01-30 14:54:23 -08:00
d983c529b6
Merge pull request #1564 from googlefonts/retain_gids
...
[subset] Add --retain-gids option to the subsetter.
2019-01-30 17:17:59 -05:00
55d1d7c8bc
2.3.1
2019-01-30 13:54:15 -08:00
e799004e9f
[iter] Whitespace
2019-01-29 17:15:12 -08:00
849a0f1758
[iter] Add hb_iter_with_fallback_t instead
2019-01-29 17:10:19 -08:00
4d40ed9d1a
[iter] Add hb_iter_with_mixin_t<>
2019-01-29 13:55:23 -08:00
6521d5b201
[iter] Export operator << / >>
2019-01-29 13:44:39 -08:00
84a25d79c6
[iter] Rename
2019-01-29 13:39:19 -08:00
198859bb37
[subset] For retain gids don't truncate glyphs past the highest requested subset glyph.
2019-01-29 13:19:21 -08:00
05e99c86ba
[subset] A few small fixes for the new subset plan api.
2019-01-29 13:19:21 -08:00
bdbe047d6c
[subset] Update hb-subset-plan.cc to match hb-subset-plan.hh.
2019-01-29 13:19:21 -08:00
74c44ffeba
[subset] Update hb-subset-glyf.cc to use new hb-subset-plan API.
2019-01-29 13:19:21 -08:00
4842294b86
[subset] Update gsub to use glyphset() method of subset plan.
2019-01-29 13:19:21 -08:00
853b1f1aa5
[subset] Correct maxp num glyph's to use new subset plan method.
2019-01-29 13:19:21 -08:00
846e05a298
[subset] Re-add glyphs array to subset plan, with new name 'glyphs_deprecated'. Switch CFF subsetting to use it.
2019-01-29 13:19:21 -08:00
03e88eab5c
Re-implement HMTX/VMTX subsetting. Update it to support glyph renumbering and simplify the implementation.
2019-01-29 13:19:21 -08:00
925be29223
Update hb-ot-vorg-table and hb-ot-layout-common to use the updated subset plan api.
2019-01-29 13:19:21 -08:00
4af3be6ef8
Remove glyph array from subset plan, make num_glyphs and glyphset private.
2019-01-29 13:19:21 -08:00
23f364429d
[subset] Fix hdmx subsetting when retain gids is enabled.
2019-01-29 13:19:21 -08:00
2da1654aef
[subset] Compute num_glyphs during subset plan construction.
...
Update maxp to use the correct num glyphs.
2019-01-29 13:19:21 -08:00
96b038f375
[subset] fix failure to init instruction ranges values for an invalid glyph.
2019-01-29 13:19:21 -08:00
4b1ac3a2fa
[subset] Do some refactoring in hb-subset-glyf.cc.
...
- Extract code out into helper methods in several places.
- Bundle loca address, size and is short into a struct.
2019-01-29 13:19:21 -08:00
b7f971884e
Add retain_gids option to subset input. Update glyf and loca handling to respect retain_gids.
2019-01-29 13:19:21 -08:00
b379900755
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-29 12:19:57 -08:00
e75b22039f
Move hb_addressof() to hb-meta.hh
2019-01-28 21:26:23 -05:00
71157a4520
[meta] Remove _ft struct names
...
Using decltype() instead.
2019-01-28 21:20:12 -05:00
9103bd056f
[pair] Use decltype
2019-01-28 21:16:51 -05:00
a30e13469e
[iter] Add operator << to set / vector
2019-01-28 16:39:01 -05:00
d438e61042
[iter] Fix operator() impls
2019-01-28 16:34:04 -05:00
57795bc8dd
[iter] Add operator>> and operator<<
2019-01-28 16:23:12 -05:00
8bd96be994
[iter] Use auto c = C.iter() internally
2019-01-28 16:17:36 -05:00
073fa4ac5a
Merge branch 'master' into iter
2019-01-28 14:35:41 -05:00
9a1df82e3f
[uniscribe] Whitelist function type cast
2019-01-28 14:15:18 -05:00
6e1c3eaf70
Fix sign comparison error
2019-01-28 14:12:41 -05:00
9db7a7da63
Fix warning
...
c:\projects\harfbuzz\src\hb-ot-color-cbdt-table.hh(59): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
2019-01-28 14:09:59 -05:00
51b584880e
[pragma] Silence MSVC unknown-pragma warning
2019-01-28 14:09:45 -05:00
d592bd16cd
Try fixing MSVC build
2019-01-28 13:41:40 -05:00
0363ce650b
[iter] Accept C arrays in hb_iter()
2019-01-27 01:06:32 +01:00
b62e7f9223
[test] Test unary operator+
...
"Test" as in compiles..
2019-01-27 00:51:57 +01:00
778c96b8d7
[iter] Fix hb_iter()
2019-01-27 00:50:54 +01:00
2f5b1a9104
[iter] Add unary operator+ that returns a copy
2019-01-27 00:49:37 +01:00
fbab07f9b3
[iter] Add hb_bool() and make hb_filter default to it for predicate
2019-01-27 00:44:45 +01:00
313d63e240
[meta] Back to using _ft suffix for function-object types
...
Seprate namespace, cleaner, more clear.
2019-01-26 22:58:26 +01:00
2aff6d9625
[iter] Test that default-constructed iterators are empty
2019-01-26 22:54:25 +01:00
f35e7eabf1
pragma GCC diagnostic error "-Winjected-class-name"
...
See 6b6783e158
2019-01-26 22:50:00 +01:00
509353357c
[iter] Use hb_declval() instead of Null() to get instance
...
I had used Null to make one of the bots happy before. Not going
to bend to such demands anymore..
2019-01-26 22:47:35 +01:00
6b6783e158
[iter/meta] Fix build on newer clang
...
The mystery failure had to do with SFINAE failure because the template
function involved was accessing ::iter_t of a type that was also named iter_t.
In this context, apparently:
warning: ISO C++ specifies that qualified reference to 'iter_t' is a
constructor name rather than a type in this context, despite preceding 'typename' keyword
[-Winjected-class-name]
We use a new macro, also called hb_iter_t(), to get iterator type of
a type. This uses declval/hb_decltype, and has the added benefit
that it returns correct type for const vs non-const objects, if they
have different iterators.
2019-01-26 22:44:09 +01:00
5adb113baf
[meta] Mark function-objects as const
2019-01-26 22:15:59 +01:00
ac90f17c55
Merge branch 'master' into iter
2019-01-26 14:05:39 +01:00
60022ecced
Fix -Wcast-function-type warnings in util/ with gcc 4.8
2019-01-26 14:04:51 +01:00
f398097529
More static constexpr
2019-01-25 16:08:25 +01:00
090fe56dc6
Merge branch 'master' into iter
2019-01-25 16:06:52 +01:00
c685644386
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-24 13:19:18 -08:00
e970de48bc
[AAT] Minor sign
2019-01-24 18:16:17 +01:00
a371a28cda
[AAT] Use a ring buffer for ligature stack
...
I think Apple does very similarly, but probably with a stack size of 16.
We do it with a stack size that is currently set to 64.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1531
2019-01-24 18:12:25 +01:00
7886b1578f
Whitespace
2019-01-24 18:06:17 +01:00
b976940243
[AAT] Handle transition errors during machine operation
...
Before we used to give up. Now, just ignore error and continue processing.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1531
2019-01-24 18:01:07 +01:00
0bd0a3311c
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-24 08:53:28 -08:00
e234bb6a42
[AAT] Ignore machine errors and continue
2019-01-24 17:23:11 +01:00
1ec90514f6
[AAT] Minor
2019-01-24 17:21:41 +01:00
299eca0c3b
[AAT] Handle out-of-bounds classes
2019-01-24 17:17:00 +01:00
c4623db4a3
[AAT] Minor
2019-01-24 17:10:12 +01:00
c4e36f97b6
[AAT] Minor
2019-01-24 17:06:16 +01:00
f60282c5bf
More pragma control
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=924848
2019-01-24 16:29:09 +01:00
fd0889f903
Comment
2019-01-24 16:12:52 +01:00
9f31417733
Form cluster for Emoji sub-region tag sequences
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1556
2019-01-24 16:08:33 +01:00
3ecda71041
Adjust mark offsets when zeroing from fallback mark positioning code
...
Adjust tests.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1532
2019-01-24 12:28:24 +01:00
12cd3171ba
Merge branch 'master' into cff-more-arrayof-fixes
2019-01-23 14:05:42 -08:00
261a742181
more rewriting with ArrayOf<>
...
CFF1 Encoding0, Encoding1, CFF1SuppEncData
2019-01-23 14:04:29 -08:00
36fb2b4da9
[AAT] In InsertionChain, set mark to previous-position if inserting
...
Fixes MORX-31
2019-01-23 20:53:57 +01:00
baf4d6a68a
[AAT] Remove mark_set from InsertionChain
2019-01-23 20:36:07 +01:00
0b2fa342de
More of previous
2019-01-22 16:36:00 +01:00
a5e5dd8b42
Fix sign-compare error resulted from promoting unsigned integers to signed larger ints
...
Clang and gcc know not to warn in these cases, but not nonmainstream compilers
2019-01-22 16:30:07 +01:00
32379bbf10
Cast HB_UNTAG results to uint8_t
2019-01-22 12:55:29 +01:00
83d4aa5ca9
More -Wcast-error fix
2019-01-22 12:52:23 +01:00
447323b85a
Better fix for -Wcast-align errors
2019-01-22 12:50:12 +01:00
81ec543d80
More -Wcast-error fixes
2019-01-22 12:43:12 +01:00
9077272549
pragma GCC diagnostic error "-Wsign-compare"
2019-01-22 12:40:18 +01:00
8d05bf7dc0
Fix cast-align error
...
If compiler doesn't inline StructAtOffset, this was an error since we
only disable cast-align at call-site. So, move the cast out.
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:146:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:147:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-01-22 12:34:05 +01:00
70a52d6bd8
Convert all other enum class consts to static constexpr
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
5d4b0377b9
Convert unsigned enum class consts to static constexpr
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
ef00654962
Convert tag enum class consts to static constexpr
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
39e1b6d03f
Convert boolean enum class consts to static constexpr
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
2019-01-22 12:17:26 +01:00
271cb7c1c0
Make some enum constants unsigned
2019-01-22 12:17:26 +01:00
3d9a6e6266
Whitespace
2019-01-22 12:17:26 +01:00
c81f02fd06
pragma GCC diagnostic error "-Wvla"
2019-01-22 12:17:26 +01:00
380c3cffb9
Use enum for class constant
2019-01-22 10:51:20 +01:00
6d042a18e7
[CFF] Use enum for tableTag
2019-01-22 10:51:20 +01:00
c1cbbb9459
Use static constexpr for large class constants
2019-01-22 10:51:20 +01:00
21c0713a1c
Whitespace
2019-01-20 20:12:12 -05:00
934d3fa2a7
Use more iter pipelines
2019-01-20 20:12:12 -05:00
420d8ac350
[algs] Add hb_iter()
...
Makes it nicer in pipelines.
2019-01-20 20:12:12 -05:00
54ec48ea20
Use iter pipelines more
2019-01-20 20:12:12 -05:00
83cecd80d9
[iter] Default projection to identity
2019-01-20 20:12:12 -05:00
a699c6b17c
[algs] Add hb_identity
2019-01-20 20:12:12 -05:00
463cfb426f
Fix unused-variable warnings
...
inline variables are not C++11, so mark them unused...
2019-01-20 20:12:12 -05:00
f4cbb1ee0c
WIP
2019-01-20 20:12:12 -05:00
471e96e55d
[iter] Use forwarding references
2019-01-20 20:12:12 -05:00
528ea66f24
[algs] Fix hb_first() / hb_second()
2019-01-20 20:12:12 -05:00
343f5a4bfc
[iter] Misc fixes to get piping almost work
2019-01-20 20:12:12 -05:00
7cedf7f64c
Change hb_first() and hb_second() to function objects
2019-01-20 20:12:12 -05:00
f35568d603
[iter] Add hb_filter()
...
Untested.
2019-01-20 20:12:12 -05:00
1733e4702c
[iter] Add hb_map()
...
Untested.
2019-01-20 20:12:12 -05:00
f7fcc47641
[iter] Make hb_zip() take const references
2019-01-20 20:12:12 -05:00
ede1a71b31
Minor rename
2019-01-20 20:12:12 -05:00
93551669c5
Remove unused Coverage::iter_t::get_coverage()
2019-01-20 20:12:12 -05:00
af2067e87b
Use hb_zip() moooore
2019-01-20 20:12:12 -05:00
0d1fdf939d
Use hb_zip() some mooore
2019-01-20 20:12:12 -05:00
af6c190235
Use hb_zip() some moore
2019-01-20 20:12:12 -05:00
83ad0b6d0f
Use hb_zip() some more
2019-01-20 20:12:12 -05:00
f0dd0656b8
Use hb_zip() some
2019-01-20 20:12:12 -05:00
200cdb721b
[iter] Rename hb_zip_t to hb_zip_iter_t
2019-01-20 20:12:12 -05:00
3290c181c1
[algs] Whitespace
2019-01-20 20:12:12 -05:00
014c50292b
[iter] Move code
2019-01-20 20:12:12 -05:00
6e3ad650d1
Rename hb-dsalgs to hb-algs
2019-01-20 20:12:12 -05:00
f27607580e
[algs] Add hb_first() and hb_second()
2019-01-20 20:12:12 -05:00
a7de144df3
Implement uniform map interface
...
Coverage, ClassDef, hb_set_t, and hb_map_t implement.
2019-01-20 20:12:12 -05:00
7987095e64
[meta] Remove hb_enable_if_t
...
It was only used for C++<11 which does not allow default parameters
in function templates. Looks like we cannot support <11 anyway, so,
start cleaning up.
2019-01-20 20:12:12 -05:00
15a6928436
[iter] Implement operator-> unconditionally
...
The right condition to check for would have been "is_struct", which
we don't have.
2019-01-20 20:12:12 -05:00
8f52a827e7
Allow rvalues in hb_addressof()
2019-01-20 20:12:12 -05:00
a4ea0d3680
[iter] Change from const_iter_t/iter_t to iter_t/writer_t
2019-01-20 20:12:12 -05:00
7798e4fcc3
[iter] Change Coverage iterator to only return glyph-id
2019-01-20 20:12:12 -05:00
84e5d00229
[iter] Add hb_zip()
2019-01-20 20:12:12 -05:00
636786ecaf
[iter] Rename __item_type__ to __item_t__
2019-01-20 20:12:12 -05:00
6caf76f4a8
Tighten Coverage iteration
2019-01-20 20:12:12 -05:00
ff3a7ce1e7
[subset] Minor
2019-01-20 20:12:12 -05:00
42bf80e578
[iter] More semicolon
2019-01-20 20:12:12 -05:00
f78f837ef1
[iter] Use aliasing using for types
...
Fix ambiguity of hb_sorted_array_t::item_t with gcc. No idea if that's a gcc bug
or what spec requires, but using aliasing using seems to fix it. It probably breaks
our non-C++11 bots, in which case I have to condition the change. Testing.
2019-01-20 20:12:12 -05:00
3fc03e42ce
[iter] Use static_assert with hb_is_random_access_iterator()
...
Both, checks constexpr'ness, and fixes build with cra**y implementations
of assert() macro:
test-iter.cc:108:11: error: too many arguments provided to function-like macro invocation
assert (hb_is_random_access_iterator (array_iter_t<int>));
^
./hb-iter.hh:186:42: note: expanded from macro 'hb_is_random_access_iterator'
hb_is_random_access_iterator_of (Iter, typename Iter::item_t)
^
/usr/include/x86_64-linux-gnu/sys/cdefs.h:89:9: note: macro '__STRING' defined here
\#define __STRING(x) #x
^
test-iter.cc:108:3: error: use of undeclared identifier '__STRING'
assert (hb_is_random_access_iterator (array_iter_t<int>));
^
/usr/include/assert.h:91:21: note: expanded from macro 'assert'
: __assert_fail (__STRING(expr), __FILE__, __LINE__, __ASSERT_FUNCTION))
^
2019-01-20 20:12:12 -05:00
6af9c5f18e
[iter] Remove stray semicolons
2019-01-20 20:12:12 -05:00
74ca7b580c
[OT] Implement operator[] for Coverage and ClassDef
2019-01-20 20:12:12 -05:00
6c548b6657
[iter] Add TODO
2019-01-20 20:12:12 -05:00
362d4e7cc3
[iter] Implement for OT::ArrayOf / OT::SortedArrayOf
2019-01-20 20:12:12 -05:00
2f837a365c
[SortedArrayOf] Fix sub_array() return type
2019-01-20 20:12:12 -05:00
54c30e949e
[iter] Constrain hb_fill() and hb_copy()
2019-01-20 20:12:12 -05:00
dc0a98cbe7
[iter] Add TODO
2019-01-20 20:12:12 -05:00
2658e40ffb
[iter] Add hb_is_random_access_iterator()
2019-01-20 20:12:12 -05:00
445364d80a
[iter] Rename hb_is_[sorted_]iterator() -> hb_is_[sorted_]iterator_of()
2019-01-20 20:12:12 -05:00
a6c013b1bf
[meta] Add hb_declval() macro
2019-01-20 20:12:12 -05:00
adc5910a63
[iter] Syntax
2019-01-20 20:12:12 -05:00
ca6adcd1ad
[iter] Test hb_is_iterable / hb_is_iterator
2019-01-20 20:12:12 -05:00
8237809f06
[serialize] Make SortedArrayOf:;serialize() take sorted-iterator
2019-01-20 20:12:12 -05:00
47333c8a30
[iter] Fix operator->
2019-01-20 20:12:12 -05:00
177a8af380
[array] SFINAE fun
2019-01-20 20:12:12 -05:00
8414f16787
[meta] Rename
2019-01-20 20:12:12 -05:00
8e0a58e1b3
[array] Remove construction that was removing constness
2019-01-20 20:12:12 -05:00
85969e357a
[iter] Fix test
2019-01-20 20:12:12 -05:00
da49961836
[iter] Remove comment
2019-01-20 20:12:12 -05:00
815cde9fa3
[iter] Use is_sorted_iterator
2019-01-20 20:12:12 -05:00
ed4336680d
[iter] Handhold hb_is_iterator() type deduction
...
by partial-instantiating on Iter.
2019-01-20 20:12:12 -05:00
cb5011d364
Revert "[iter] Add hb_iter_of_t<>"
...
This reverts commit d6cbe96e2fc7bc8f1c10e631b52b1ef31ff9a6f5.
Isn't useful, as duplicate inheritance of same type results in ambiguity
errors...
2019-01-20 20:12:12 -05:00
c132cda9d9
[iter] Fix warnings
2019-01-20 20:12:12 -05:00
c9d8a07e30
[iter] Add hb_iter_of_t<>
2019-01-20 20:12:12 -05:00
b5d6fe1a45
[iter] Remove hb_sorted_iter_t
...
Not enforcing it using type hierarchy.
2019-01-20 20:12:12 -05:00
255085bd59
[iter] Const correctness
2019-01-20 20:12:12 -05:00
415f3f4320
Add operator= to IntType, commented out
...
https://github.com/harfbuzz/harfbuzz/pull/1510
2019-01-20 20:12:12 -05:00
183be8f452
[iter] Minor
2019-01-20 20:12:12 -05:00
6cd96ba1ac
[iter] Make is_random_access_iterator a constant
...
We cannot rely on constexpr functions...
2019-01-20 20:12:12 -05:00
a685bfe8fc
Separate GlyphID from HBUINT16
...
For stricter enforcement.
2019-01-20 20:12:12 -05:00
8ac64d0090
[iter] Fix sorted_iter iter class
2019-01-20 20:12:12 -05:00
93615b9598
[iter/meta] Add hb_is_sorted_iterator()
2019-01-20 20:12:12 -05:00
92f25db1e8
[iter] Remove stale comment
2019-01-20 20:12:12 -05:00
40c24fd4a6
[iter] Port Coverage towards iter_t instead of array_t specifics
2019-01-20 20:12:12 -05:00
d552b6818c
[meta] Move typename around
...
We'll see if bots like.
2019-01-20 20:12:12 -05:00
f64ea8fc65
[meta] Move code around
2019-01-20 20:12:12 -05:00
aa2ab4f061
[iter] WHitespace
2019-01-20 20:12:12 -05:00
851fbb23ea
[iter] Port Coverage::serialize to hb_is_iterator
2019-01-20 20:12:12 -05:00
06a44e2e53
[iter/meta] Match hb_is_iterator<> using SFINAE
...
By specifying Item type, which is desirable.
2019-01-20 20:12:12 -05:00
bcb913efb4
Minor
2019-01-20 20:12:12 -05:00
859a880b08
[iter] Add back operator +
...
Too ugly to remove..
2019-01-20 20:12:12 -05:00
076faf7c18
[iter] Disable operator +
...
To see if it makes bots happy... This is frustrating.
2019-01-20 20:12:12 -05:00
a46874f1ab
[iter] Revert back uses of C++11 auto type deduction
2019-01-20 20:12:12 -05:00
0828db8444
[iter] Rename
2019-01-20 20:12:12 -05:00
037f735efd
[iter] Remove friend operator +, hoping to fix some bots
2019-01-20 20:12:12 -05:00
cb27918d0a
Use Null() instead of declval(), hoping to fix some bots
2019-01-20 20:12:12 -05:00
3d22900f62
[meta] Don't use template default arguments for functions
...
That's a C++11 extension apparently...
2019-01-20 20:12:12 -05:00
b89d20dd9f
[meta] Fix unused-function-template warning
2019-01-20 20:12:12 -05:00
df138da2e6
[iter/meta] Implement is_iterator
...
Removes use of auto type deduction again, which was not supported on many bots.
2019-01-20 20:12:12 -05:00
8570da1d74
[meta] Minor
2019-01-20 20:12:12 -05:00
442f4a5891
[meta] Move more code here
2019-01-20 20:12:12 -05:00
8c6cbbdfa3
[iter/meta] Add hb_is_iterable
2019-01-20 20:12:12 -05:00
576d5e2420
Don't use delegating constructors
...
Not all C++11 features are created equal when it comes to support...
2019-01-20 20:12:12 -05:00
e32bf39766
[meta] Add enable_if
2019-01-20 20:12:12 -05:00
e76a3cae0f
Add hb-meta.hh for meta-programming
2019-01-20 20:12:12 -05:00
5ec11ce13a
[iter] Clarify readonly vs lvalue iterators
...
lvalue iterators must declare __item_type__ as a reference.
2019-01-20 20:12:12 -05:00
2cbf5bf3a9
[iter] Test OT::Coverage iter
2019-01-20 20:12:12 -05:00
fd75d29f0f
[iter] Streamline vector iterators
2019-01-20 20:12:12 -05:00
570473a345
[iter] Make hb_sorted_array_t work as iter
...
Ugly, but does the job.
2019-01-20 20:12:12 -05:00
d6024794fb
Change hb_void_t implementation
2019-01-20 20:12:12 -05:00
cde31988c2
[iter] Mark Coverage iterator sorted
2019-01-20 20:12:12 -05:00
49161d411f
[subset] Take iterator in ArrayOf serialize
...
Still not satisfied with how I can enforce iterators only, but
seems to work for now.
2019-01-20 20:12:12 -05:00
e16884248f
[iter] Port Coverage iterator to hb_iter_t
2019-01-20 20:12:12 -05:00
c68bca0f95
Add hb_pair_t<> and hb_pair()
2019-01-20 20:12:12 -05:00
8303a9b011
[Coverage] Ensure increasing coverage in iteration
2019-01-20 20:12:12 -05:00
50cd26d394
[Coverage] Mark iterator methods const
2019-01-20 20:12:12 -05:00
9df1a6eba7
[iter] Use operator bool in a few places
2019-01-20 20:12:12 -05:00
7788ac14a4
[iter] Remove redundant methods
2019-01-20 20:12:12 -05:00
3dea9affda
[iter] Test default-constructability
2019-01-20 20:12:12 -05:00
743ff09368
[iter] Implement friend opeator + (int, iter)
2019-01-20 20:12:12 -05:00
6dc4a1c9b1
[iter] Remove const_iter
2019-01-20 20:12:12 -05:00
f2b56af3ef
[iter] Remove hack for older compilers
2019-01-20 20:12:12 -05:00
2ea79e0340
[iter] Minor
2019-01-20 20:12:12 -05:00
fb053b6333
[iter] Rename random_access() to constexpr is_random_access()
2019-01-20 20:12:12 -05:00
2790aad28c
[iter] Add operator ->
2019-01-20 20:12:12 -05:00
d3976b7e63
[iter] Make them work, mostly
2019-01-20 20:12:12 -05:00
959bb58bdd
[vector] Add iterator
2019-01-20 20:12:12 -05:00
dd7c628ed1
Use enum for class constant
2019-01-20 19:51:08 -05:00
cf7edf52c3
[CFF] Use enum for tableTag
2019-01-20 19:49:59 -05:00
bd1318b8cc
Use static constexpr for large class constants
2019-01-20 19:47:52 -05:00
043b610fa6
Fix sign compare warnings
...
../../third_party/harfbuzz-ng/src/src/hb-map.hh(56,45): warning: comparison of integers of different signs: 'const hb_codepoint_t' (aka 'const unsigned int') and 'hb_map_t::(anonymous enum at ../../third_party/harfbuzz-ng/src/src/hb-map.hh:169:3)' [-Wsign-compare]
bool is_unused () const { return key == INVALID; }
2019-01-19 09:21:33 -05:00
ce317d0320
Fix warning
...
warning: '_WIN64' is not defined, evaluates to 0 [-Wundef]
2019-01-19 09:21:33 -05:00
0c2bd1b160
[dwrite] Fix delete-non-virtual-dtor warning ( #1550 )
2019-01-19 16:30:07 +03:30
89bcfb204c
Remove TRACE_COLLECT_GLYPHS
2019-01-18 14:59:18 -05:00
f13b6786f0
[pragma] Only add if GCC or clang
2019-01-18 14:53:54 -05:00
c2ea7a9da4
[directwrite] More fix
2019-01-18 14:20:45 -05:00
9714d3ec5c
[dwrite] Try to fix delete-non-virtual-dtor warnings
...
Fixes #1548 hopefully
2019-01-18 21:55:21 +03:30
0772c06f96
Remove tracing from closure
2019-01-18 12:53:47 -05:00
d9f6be3a61
Fix -Wundef errors with __GNUC__
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1549
2019-01-18 12:53:47 -05:00
28917e58f9
init interp_env_t::hintmask_size
...
fixes issue #1547
2019-01-18 09:43:51 -08:00
9b4e51b2e4
[pragma] Enable error -Wdelete-non-virtual-dtor
...
Currently fails directwrite backend.
2019-01-18 12:23:02 -05:00
e65272281c
[directwrite] Fix error
...
hb-directwrite.cc: In constructor 'TextAnalysis::TextAnalysis(const wchar_t*, uint32_t, const wchar_t*, DWRITE_READING_DIRECTION)':
hb-directwrite.cc:489:18: error: 'TextAnalysis::mText' will be initialized after [-Werror=reorder]
const wchar_t* mText;
^~~~~
hb-directwrite.cc:488:12: error: 'uint32_t TextAnalysis::mTextLength' [-Werror=reorder]
uint32_t mTextLength;
^~~~~~~~~~~
hb-directwrite.cc:282:3: error: when initialized here [-Werror=reorder]
TextAnalysis (const wchar_t* text, uint32_t textLength,
^~~~~~~~~~~~
hb-directwrite.cc: In function 'hb_bool_t _hb_directwrite_shape_full(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, const hb_feature_t*, unsigned int, float)':
2019-01-18 12:22:07 -05:00
b900f78088
[pragma] More cast-align whitelist
2019-01-18 10:08:23 -05:00
0d8b931bbe
[pragma] Allow cast-align in hb-font.cc
...
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:144:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:145:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = int]':
2019-01-18 10:03:43 -05:00
a25174a56b
[pragma] GCC diagnostic error "-Wreorder"
2019-01-18 09:59:36 -05:00
4660090569
[pragma] GCC diagnostic warning "-Wmaybe-uninitialized"
2019-01-18 09:53:16 -05:00
7a634d7d5b
[pragma] Massage more
2019-01-18 09:49:14 -05:00
16e5ba85b1
[pragma] More
2019-01-18 09:46:17 -05:00
2bd530d598
[pragma] Reorg again
...
https://github.com/harfbuzz/harfbuzz/issues/1546
2019-01-18 09:28:22 -05:00
c04272fac8
[pragma] GCC diagnostic ignored "-Wunknown-warning-option"
...
Try at fixing https://github.com/harfbuzz/harfbuzz/issues/1546
2019-01-18 08:49:45 -05:00
4d3c8f9685
[uniscribe] More warnings
2019-01-17 19:58:54 -05:00
6a5d2b21d8
[uniscribe] Fix warnings
2019-01-17 19:57:17 -05:00
5b13e458c3
Fix build
2019-01-17 19:52:32 -05:00
a77bd6bb89
[pragma] GCC diagnostic ignored "-Wclass-memaccess"
2019-01-17 19:33:41 -05:00
436c7b294a
[pragma] ignored -Wunsafe-loop-optimizations // TODO fix
2019-01-17 19:03:33 -05:00
e3b3181e9d
[pragma] error -Wclass-memaccess
2019-01-17 19:02:06 -05:00
1a6b97a491
[pragma] More
2019-01-17 18:55:03 -05:00
06e8091661
[pragma] More
2019-01-17 18:47:32 -05:00
1077e40bf1
[pragma] Flesh out more
2019-01-17 18:36:10 -05:00
7e6bd510fc
Use NNOffsetTo<> in rest of places
2019-01-17 18:24:18 -05:00
b1152d5e66
Use NNOffsetTo<>
2019-01-17 18:17:04 -05:00
205d72a198
Add NNOffsetTo<>
2019-01-17 18:10:38 -05:00
c99d13d860
[AAT] Comment
2019-01-17 17:56:27 -05:00
f39b5603ff
Comment
2019-01-17 17:50:01 -05:00
347ad454b8
[AAT] Remove unused code
2019-01-17 17:47:29 -05:00
b344d4385a
[AAT] Allow null in ankr lookupTable offset
2019-01-17 17:44:39 -05:00
14a560a245
[pragma GCC] Ignore -Wtype-limits
2019-01-17 17:42:44 -05:00
3f2daae630
More GCC pragmas
2019-01-17 15:27:31 -05:00
d6c5473e1f
Rename macro
2019-01-17 15:22:46 -05:00
a9946b7cfe
Add more GCC warning pragmas
2019-01-17 15:22:28 -05:00
868b0c0c2e
Move -Wcast-align to hb.hh
2019-01-17 15:18:18 -05:00
8874eef8ff
Add pragram GCC diagnostic ignored "-Wunused-macros"
2019-01-17 15:04:44 -05:00
cc8e9a436f
[AAT] Fully sanitize ankr table at sanitize time
...
Third try to fix access. Followup 6879efc2c1https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
2019-01-17 14:55:05 -05:00
6879efc2c1
[AAT] Fix anchor bound checking, again
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
2019-01-17 14:08:02 -05:00
a262eb3d0b
[aat] Minor
2019-01-17 14:06:32 -05:00
c986ca15a6
Improve overflow avoidance
...
Better fix for 480406cd3e
2019-01-15 13:58:19 -05:00
f401f85a5a
Remove assumption about Core Text working in 96 DPI
...
Core Text doesn't actually have a concept of DPI internally, as it
doesn't rasterize anything by itself, it just generates vector paths
that get passed along to Core Graphics.
In practice this means Core Text operates in the classical macOS
logical DPI of 72, with one typographic point corresponding to one
point in the Core Graphics coordinate system, which for a normal
bitmap context then corresponds to one pixel -- or two pixels for
a "retina" context with a 2x scale transform.
Scaling the font point sizes given to HarfBuzz to an assumed DPI
of 96 is problematic with this in mind, as fonts with optical
features such as 'trak' tables for tracking, or color glyphs,
will then base the metrics off of the wrong point size compared
to what the client asked for.
This in turn causes mismatches between the metrics of the shaped
text and the actual rasterization, which doesn't include the 72
to 96 DPI scaling.
If a 96 DPI is needed, such as on the Web, the scaling should be
done outside of HarfBuzz, allowing the client to keep the DPI of
the shaping in sync with the rasterization.
The recommended way to do that is by scaling the font point size,
not by applying a transform to the target Core Graphics context,
to let Core Text choose the right optical features of the target
point size, as described in WWDC 2015 session 804:
https://developer.apple.com/videos/play/wwdc2015/804/
2019-01-15 13:26:35 +01:00
0d2727f4fe
fix FDSelect fuzzing bug ( #1539 )
...
Rewrote struct FDSelect3_4.ranges as ArrayOf
Updated FDSelect3_4::sanitize () to call ranges.sanitize ()
nRanges now a function to return a reference to ranges.len
2019-01-14 18:23:17 -08:00
9f6172d669
Move _POSIX_SOURCE definition
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1308
2019-01-14 20:45:31 -05:00
480406cd3e
Fix assertion on address overflow
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=917031
2019-01-14 15:27:34 -05:00
7a6686a589
[AAT] Fix mort ContextualSubtable offset access
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12312
2019-01-14 15:09:14 -05:00
a3fa7d3336
[AAT] Fix ankr table access
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=918340
2019-01-14 14:37:36 -05:00
760303d411
deleted a duplicate fontdicts_mod.fini() call ( #1538 )
2019-01-11 15:27:35 -08:00
7b48641aa8
fix leak in subset_enc_supp_codes ( #1537 )
...
oss-fuzz issue 12310
2019-01-08 15:37:48 -05:00
97f67a3c3d
[ci] Enable more of GCC compile warnings ( #1533 )
2019-01-04 23:10:39 +03:30
26c5b54fb0
CircleCI: Test for Python 3 syntax errors and undefined names ( #1522 )
...
Catch missing imports and errors like #1520 and #1521
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org ) issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2018-12-31 07:00:43 +03:30
f4da28b1f1
Python 3 fixes to gen-os2-unicode-ranges.py ( #1521 )
...
In Python 3, __reload()__ was moved and __sys.setdefaultencoding()__ because the default is already utf-8. Also __Error()__ is an _undefined name_ and __Exception()__ creates a generic exception.
2018-12-30 15:28:34 +03:30
d092fb2719
Ouch! Fix build on C++<11
2018-12-30 01:53:03 -05:00
89949ed28d
Fix ubsan with passing nullptr to qsort()
2018-12-30 01:52:19 -05:00
357a0a7ad3
Fix build on C++ < 11
2018-12-27 18:29:23 -05:00
54c0a17310
[vector] Fix warning
2018-12-27 18:28:07 -05:00
1043ddbee8
[aat] Minor
2018-12-27 18:27:11 -05:00
71da9ca62f
[vector] Remove use of arrayZ() by using casts
2018-12-27 18:01:06 -05:00
fa333e34d6
[vector] Remove static_array
...
Was good idea, but with C++ types with constructor/destructor, was getting in
the way as compiler was destructing those items where it was not desired.
Since C++ does not allow zero-sized arrays, just remove it...
2018-12-27 17:56:22 -05:00
ab2258a419
[vector] Use allocated = -1 to signify failure
2018-12-27 17:45:05 -05:00
09fa536d89
fix lealk with cff2::accelerator_templ_t::topDict ( #1517 )
2018-12-27 11:33:09 -05:00
3b81442cd5
[vector] Change pre-alloced count from 8 to 2
...
I'm thinking about dropping it to zero, but that needs slight code changes.
2018-12-24 11:31:04 -05:00
d25a2f1496
Fix a few warnings
2018-12-23 20:34:24 -05:00
85003b594b
[iter] Fix warning
2018-12-23 20:34:24 -05:00
e4355b1ca1
[set] Add iter_t as alias to const_iter_t
2018-12-23 20:34:24 -05:00
33f8de6186
[set] Change to const_iter
2018-12-23 20:34:24 -05:00
f88fed5cd8
[set] Cache length in iterator
2018-12-23 20:34:24 -05:00
d0a706c7fd
Minor, remove redundant inline
2018-12-22 20:07:57 +03:30
ae6e348d64
Minor, tweak spaces
2018-12-22 20:07:57 +03:30
29f0b6bce7
CFF renaming ( #1507 )
...
* reimplement ByteStr as byte_str_t based on hb_ubytes_t
Unuse start_embed<ByteStr>
Also renamed SubByteStr to byte_str_ref_t
More renaming to come
* substr renamed to str_ref in line with its type byte_str_ref_t
* uncamelize non-table struct names
* uncamelized non-struct types OpCode etc
* add byte_str_t copy ctor
* test
* test2
* undo tests
* fix bot failure
* undo the previous change
* fixed tabs, added inline
* Revert "fixed tabs, added inline"
This reverts commit 21163c30e9
2018-12-22 10:47:04 -05:00
89d04129e2
[set] Actually derive iterator from hb_sorted_iter_t<>
2018-12-21 20:07:52 -05:00
fc35919d01
[set] Implement unified iterator
2018-12-21 20:06:17 -05:00
4911e67d2d
[set] Mark some internals protected
2018-12-21 20:00:52 -05:00
954b985422
[iter] Add hb_sorted_iter_t<>
2018-12-21 19:55:02 -05:00
b205105c9e
[iter] Change operator[] operand to be signed
...
To fix older compilers again (this was the case in hb_array_t).
hb-ot-layout-common.hh:1353: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-layout-common.hh:1354: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
hb-ot-layout-common.hh:1354: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-layout-common.hh: In member function 'bool OT::ClassDef::serialize(hb_serialize_context_t*, hb_array_t<const OT::IntType<short unsigned int, 2u> >, hb_array_t<const OT::IntType<short unsigned int, 2u> >)':
hb-ot-layout-common.hh:1490: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
hb-ot-layout-common.hh:1490: note: candidate 2: operator[](T*, int) <built-in>
2018-12-21 19:48:21 -05:00
25786f49c1
[array] Port to hb_iter_t<>
...
hb_array_t is its own iterator...
2018-12-21 19:29:00 -05:00
2a33ab0560
[iter] Change __more__ to fallback to __len__
2018-12-21 18:53:01 -05:00
474a12058d
[array/vector] Rename len to length
2018-12-21 18:53:01 -05:00
2fc1860a5b
[iter] Split hb_iter_t<> into hb_iter_t<> and hb_iter_mixin_t<>
2018-12-21 18:09:45 -05:00
865deeb3be
Adjust internal header dependencies
2018-12-21 17:46:10 -05:00
8e5c2bc60b
[Makefile.am] Minor
2018-12-21 17:29:11 -05:00
f419cef417
[iter] Include from hb.hh
2018-12-21 17:22:09 -05:00
7557e34872
[iter] Move hb_fill() and hb_copy() to hb-iter.hh
2018-12-21 17:21:19 -05:00
5e1840e031
[iter] Disallow copy-construction or assignment of hb_iter_t<>
...
Should only be done by subclass.
2018-12-21 16:39:57 -05:00
65e8bd56ad
[iter] Fix hb_copy() return value
2018-12-21 16:20:30 -05:00
40d71211a8
[iter] Add const_iter_t / const_iter()
2018-12-21 16:19:44 -05:00
aaddfaa57a
[iter] Make hb_fill() take collection type, not iter
...
Starting to get the hang of when take which.
2018-12-21 16:04:38 -05:00
7b4eea853c
[array] Add more hb_array() / hb_sorted_array() variants
2018-12-21 16:02:16 -05:00
09740148e3
[serialize] Use component_list by reference, as a supplier
2018-12-21 15:56:01 -05:00
3dbe1e364c
[iter] Add .random_access()
2018-12-21 15:53:09 -05:00
20f14b4aa6
[iter] Fix __end__()
2018-12-21 15:19:22 -05:00
95265aeab7
[array] Remove copy constructor
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1502
2018-12-21 15:12:55 -05:00
69d232eaea
Fix bot
...
C:\projects\harfbuzz\src\hb-uniscribe.cc(709): error C2666: 'hb_vector_t<OPENTYPE_FEATURE_RECORD,8>::operator +': 3 overloads have similar conversions [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
2018-12-21 15:08:06 -05:00
b9a51f5310
Minor
2018-12-21 15:05:00 -05:00
bdb6da7226
[iter] Fix test again
2018-12-21 11:20:27 -05:00
e952075248
Minor
2018-12-21 11:15:16 -05:00
35503d7d73
[iter] More prototyping
2018-12-21 03:03:46 -05:00
73c7a896d1
[iter] Make hb_fill() and hb_copy() take iterators
...
I'm still going back and force...
2018-12-21 02:48:28 -05:00
12e506fda4
[iter] Add hb_fill()
2018-12-21 02:47:04 -05:00
ad3ed58de5
[iter] Start prototyping hb_copy()
2018-12-21 02:25:58 -05:00
44af738d19
[iter] Showcase implicit casts
2018-12-21 01:59:37 -05:00
879faa2aee
Rename
2018-12-21 01:57:40 -05:00
aeb696a91c
[iter] Rename
2018-12-21 01:57:02 -05:00
8001e00a47
[iter] First sample use
2018-12-21 01:53:27 -05:00
19d2b5013d
[iter] Add bidirectionality
2018-12-21 01:20:04 -05:00
314d8698d0
[iter] Sketch new iterator design
2018-12-21 01:15:49 -05:00
f6d5f1e91c
[iter] Add empty test
2018-12-21 00:23:46 -05:00
b80b97b549
Revert "Remove unused hb-iter.hh"
...
This reverts commit 969ff3c7aa
2018-12-21 00:08:05 -05:00
a728c63a98
[vector] Add operator bool
2018-12-20 23:15:49 -05:00
bd36977392
Rename
2018-12-20 23:14:24 -05:00
e6ebc9b6f8
Remove unused typedef
2018-12-20 23:13:36 -05:00
4941e95f10
2.3.0
2018-12-20 21:48:57 -05:00
87f7c83fff
[serializer] Add operator <<
...
Not sure if we are going to use it. But might incentivize us to.
2018-12-20 15:54:17 -05:00
5b70074edf
Add hb_assign(obj, value)
2018-12-20 15:38:59 -05:00
6124123393
[serialize] Adjust ClassDef
...
[skip ci]
2018-12-20 12:26:44 -05:00
4220b7bdd7
Fix code on big-endian gcc / clang
...
Ouch! We need a bigendian bot...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1498
2018-12-20 11:48:45 -05:00
c87ee72232
Minor [skip ci]
2018-12-19 22:28:16 -05:00
5000a59a63
[saitnize] Minor
2018-12-19 22:27:09 -05:00
3ee4ea9456
Fix build on older Visual Studio versions ( #1499 )
...
* src/hb-cff-interp-dict-common.hh: Use ull for unsigned int64_t
The llu suffix does not work for older Visual Studio versions
(pre-2013), but ull works for all the compilers that we attempt to
support.
* test/api: Fix build on pre-C99 compilers
Ensure variables are declared at the top of the block.
* src/hb-dsalgs.hh: Add specialization for hb_is_signed<> for __int8
Pre-Visual Studio 2010 does not consider __int8 (which is typedef'ed to
int8_t) to be equivilant to signed char, so the compiler cannot find the
corresponding hb_is_signed<> specialization that is needed.
The interesting thing is unsigned __int8 is considered to be equivilant
to unsigned char, so as the other types (short, int, long) that we look
for here, so only the specialization for __int8 is added here.
This will fix builds on Visual Studio 2008 at least.
2018-12-19 22:26:54 -05:00
a62870506d
[sanitize] Use hb_static_size instead of ::static_size
...
https://github.com/harfbuzz/harfbuzz/issues/1496#issuecomment-448818112
2018-12-19 21:05:00 -05:00
0c9cd5d5f4
[test] Fix test-name-table.cc leak issue
...
Spotted it accidentally but wanted to see if is anything serious so went for fixing it
2018-12-19 21:18:30 +03:30
3d9d7dc4dd
[arrays] Add hb_ubytes_t for unsigned char
2018-12-18 22:11:23 -05:00
f1e95e40ed
[arrays] Remove hb_supplier_t<>
2018-12-18 16:49:08 -05:00
f9417af29b
[serialize] Propagate error from hb-face
2018-12-18 13:23:32 -05:00
9aebfb4182
[serialize] Streamline error propagation
2018-12-18 13:22:17 -05:00
969ff3c7aa
Remove unused hb-iter.hh
...
The ideas there are all part of hb-array.hh now. To be determined how we
want to use generic iterator patterns.
2018-12-17 22:43:00 -05:00
b1094fc2d2
[arrays] Minor tweaks to hb_supplier_t
...
I think I like to keep this hb_supplier_t thing separately from hb_array_t.
2018-12-17 22:41:04 -05:00
cf39c24205
[arrays] Rename Supplier to hb_supplier_t
2018-12-17 22:36:23 -05:00
6b5eaa7530
Hide hb_addressof()
2018-12-17 21:55:33 -05:00
6befa75cdf
Enable __builtin_* on clang
...
We'll see which old clang versions this breaks...
2018-12-17 20:35:45 -05:00
8d2d410256
Add hb_addressof() and use it to fix bug after hb_bytes_t merge
...
We cannot take address hb_bytes_t direction. We need to use the
newly added hb_addressof(), ala std::addressof().
2018-12-17 20:23:26 -05:00
49334f9b50
Enable system extensions in hb.hh
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1491
2018-12-17 18:27:36 -05:00
37c14bc745
Fix Solaris use after free ( #1495 )
2018-12-17 17:59:37 -05:00
483f2491e4
Remove define GNU_SOURCE
...
Not needed. We get it in our config.h automatically thanks to
AC_USE_SYSTEM_EXTENSIONS. Let's see whose build it breaks...
If we end up putting it back, we should add other things from
that macro and remove the macro.
2018-12-17 17:56:10 -05:00
87ff65aea1
Fix more warnings
2018-12-17 17:19:54 -05:00
f9d219a174
Fix Solaris Trailing comma in enum warnings ( #1490 )
2018-12-17 17:18:47 -05:00
244a8627f7
Lower coretext_aat shaper priority ( #1488 )
...
Related to https://github.com/harfbuzz/harfbuzz/issues/1478
2018-12-17 13:01:43 -05:00
e412008599
Remove redundant void from C++ sources ( #1486 )
2018-12-17 13:01:01 -05:00
7ace10078c
Minor, fix two more ArrayOf incorrect operator logic
2018-12-17 20:07:04 +03:30
a1240383aa
[arrays] Minor fix
2018-12-17 10:44:14 -05:00
381c3548e9
[array] Add cast operator to add const to Type
...
In lieu of constructor removed in previous commit.
2018-12-17 00:39:30 -05:00
15acf33c22
[array] Remove problematic constructor
2018-12-17 00:38:13 -05:00
470369a871
[array] Add arithmetic operators
2018-12-17 00:21:38 -05:00
6cd60c2f2a
[array] Return Crap instead of Null if Type is not const
...
Ouch!
2018-12-17 00:09:06 -05:00
94e72cf1c9
[array] Add operator *
2018-12-17 00:06:40 -05:00
68d4a5eee0
[array] Add constructor from fixed-size array
2018-12-17 00:02:42 -05:00
a4354d2fd3
[array] Organize
2018-12-16 23:57:27 -05:00
84c1865821
[arrays] Reduce Supplier<> even further
2018-12-16 23:52:17 -05:00
1bcc4fc9f3
Whitespace
2018-12-16 23:47:56 -05:00
f85f6e815f
[array] Add operator +=
2018-12-16 23:45:07 -05:00
7c0e3e9b2b
[array] Add constructor from hb_array_t<const Type>
2018-12-16 23:43:17 -05:00
92680361ec
[arrays] Move Supplier<> to hb-array.hh
2018-12-16 23:38:51 -05:00
2a3fa3f82f
[arrays] Remove unnecessary constructor from Supplier<>
...
Looks like operator hb_array_t<> from vector works here. :)
2018-12-16 23:33:03 -05:00
507cac4943
[arrays] Start moving Supplier<> to hb_array_t<>
2018-12-16 23:31:19 -05:00
1e2c98126e
[arrays] Remove unused stride from Supplier
2018-12-16 22:31:16 -05:00
0d0fe9df46
[arrays] Remove need of stride in Supplier<>
2018-12-16 22:31:13 -05:00
dcfa4a8d71
[array] Remove custom hb_bytes_t implementation
2018-12-16 22:31:13 -05:00
3656f56d47
[arrays] Minor
2018-12-16 22:31:13 -05:00
aa8f94714e
[array] Minor
2018-12-16 22:31:13 -05:00
5a552f7546
[array] Move hb_array_t and related types to hb-array.hh
2018-12-16 22:31:10 -05:00
01d06e34ff
Minor change to explicit_operator aesthetics
2018-12-16 14:27:43 -05:00
b2ebaa9afa
Remove redundant 'inline' from methods ( #1483 )
2018-12-16 14:08:10 -05:00
7251c77290
Whitespace
2018-12-15 21:00:55 -05:00
829b56b1a2
Whitespace
2018-12-15 16:20:13 -05:00
42a1012562
[subset] Actually subset GDEF
2018-12-13 19:39:59 -05:00
c9c746c7f6
[subset] Fix up ClassDef some more
2018-12-13 18:39:30 -05:00
7ee6128902
[subset] Fix ClassDefFormat1 subsetting
2018-12-13 18:32:04 -05:00
1b6d0c44b3
[subset] Sketch GDEF subsetting
2018-12-13 18:10:48 -05:00
705e2f5056
[subset] Implement for ClassDef
2018-12-13 17:48:42 -05:00
6e33a3955d
Minor
2018-12-13 16:40:01 -05:00
cc65901ca7
[serialize] Implement for ClassDef
2018-12-13 16:01:45 -05:00
e5309e4fd8
[serialize] Implement for ClassDefFormat2
2018-12-13 15:57:12 -05:00
c8b43cbe31
[serialize] Implement for ClassDefFormat1
2018-12-13 15:53:00 -05:00
5761031329
[subset] Minor
2018-12-12 21:21:26 -05:00
798e98c47b
[CFF] bad offset in Index ( #1476 )
...
* Update hb-ot-cff-common.hh
* fix bug
* bummer fix wasn't hit. refix
* additional sanity check
* Added test cases for oss-fuzz issues 11805, 11806
2018-12-12 21:08:15 -05:00
bcb4ecaf68
[CFF] check out of range FD index ( #1477 )
...
* add fd index checks to subr subsetter
also added oss-fuzz test case
* undid SubrSubsetParam::is_valid
because already validated by SubrClosures.valid
2018-12-12 20:36:01 -05:00
2cc993e035
[dispatch] Minor
2018-12-12 10:07:38 -05:00
602fbfe3c9
[sanitize] Fix sanitizing sublookup array
2018-12-12 09:56:47 -05:00
c78e4784fb
[dispatch] Minor
2018-12-12 09:50:18 -05:00
f9d211af1d
Revert "Minor fix re sanitize of Lookup subtables"
...
This reverts commit 7146718bef
2018-12-12 09:44:30 -05:00
7ee5c52345
minor style fix, use void in methods on no argument
2018-12-12 15:14:37 +03:30
7146718bef
Minor fix re sanitize of Lookup subtables
...
We were dereferencing Null pointers and trying to sanitize them,
which is not necessary...
2018-12-11 23:44:29 -05:00
ce069d1932
Minor
2018-12-11 23:07:48 -05:00
1aea869446
[subset] Map glyphs during SingleSubst subsetting
...
Ha!
2018-12-11 22:53:58 -05:00
41d1a1c10f
[subset] Minor
2018-12-11 22:48:27 -05:00
2aba2c6c73
[serialize] Break down assert
2018-12-11 21:21:13 -05:00
2941208f1e
[CFF] oss-fuzz issue 11690 ASSERT: substr.offset >= opStart ( #1461 )
...
* fix oss-fuzz 11690: substr.offset >= opStart
detect recursive subroutine call & handle as error
* fix build failure
* add minimized test case for oss-fuzz 11690
* removed asserts
2018-12-11 15:21:24 -05:00
333586245c
minimize use of assert: removed or changed to error handling ( #1467 )
2018-12-11 15:20:20 -05:00
9f3a51ddb9
[ucdn] Fix header
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1470
2018-12-11 13:38:05 -05:00
1683bb2c93
[glyf] minor
2018-12-08 13:57:39 +03:30
f7cfe99815
[os2] Move typometrics detection logic to the table ( #1465 )
2018-12-08 13:40:44 +03:30
47cf9a9633
Apply non-controversial parts of ot-style ( #1464 )
...
Things to be used in https://github.com/harfbuzz/harfbuzz/pull/1459
2018-12-08 10:20:25 +03:30
4d809696ef
fix for issue #1447 ( #1462 )
...
Added case for OpCode_BaseFontName. This opcode in spec but practically unused.
Added a comment for default case which can't be hit
2018-12-07 20:49:39 -08:00
1abd4fcaec
[fdsc] minor
2018-12-07 22:34:12 +03:30
59345cdef3
[CFF] Refix oss-fuzz 11714: set_blends (PR #1458 ) ( #1460 )
...
* pass subarray of stack to set_blends
* get_subarray to return a value, not ref
* restored error check (with tweak)
2018-12-06 13:36:26 -08:00
20245f0000
Fix likely check
...
Ouch!
2018-12-06 10:27:37 -08:00
d866e905fd
Add default value to first argument of sub_array()
2018-12-06 10:26:32 -08:00
f1352f7486
Add sub_array to hb_vector_t
2018-12-06 10:21:17 -08:00
ca23b71935
Add default-value for second arg of sub_array()
2018-12-06 10:21:17 -08:00
1ccbdcf73b
Merge branch 'master' into cff-check-blends
2018-12-05 21:37:38 -08:00
14d29a1043
check number of blends against args on stack
2018-12-05 21:33:29 -08:00
f95324a335
Merge pull request #1457 from harfbuzz/cff-varstore-sanitize
...
[CFF] oss-fuzz issue 11713 (CFF2VariationStore::serialize)
2018-12-06 08:33:44 +03:30
c31092ab34
sanitize variationStore in CFF2 against its size
2018-12-05 17:04:55 -08:00
34e3ef8ff3
Merge branch 'master' into cff-subr-sanitize
2018-12-05 15:50:05 -08:00
d9dabc00e9
Merge pull request #1454 from harfbuzz/cff-fixbcd
...
[CFF] fix oss-fuzz issue 11674: parse_bcd
2018-12-05 15:39:34 -08:00
6dcfda92c1
sanitize CFF1 & CFF2 global subrs
2018-12-05 15:07:46 -08:00
6708c5595f
fix oss-fuzz issue 11675 (ASSERT: count <= str.len)
...
Also added an additional error check to avail ()
2018-12-05 12:51:18 -08:00
2cb9d4c183
Merge branch 'master' into cff-fixbcd
2018-12-05 11:25:29 -08:00
a5fa843c74
fixed a bug with fractional part in a negative value
2018-12-05 11:18:16 -08:00
8394a6cb25
[os2] Make newer table fields accessible ( #1452 )
2018-12-05 15:23:41 +03:30
5ab086ebb1
[fdsc] Implement the table parsing
...
Related to https://github.com/harfbuzz/harfbuzz/issues/1337
May used in addition to an API related to STAT.
Lots of Apple fonts have it.
2018-12-05 14:48:31 +03:30
8f80e53341
[gasp] Implement the table parsing
...
May or may not be used in https://github.com/harfbuzz/harfbuzz/pull/1432
2018-12-05 14:48:31 +03:30
79e7e3445e
Merge pull request #1449 from harfbuzz/cff-fixcharset
...
[CFF] fix for oss-fuzz 11657: Charset overrun
2018-12-05 13:25:18 +03:30
cf4b7db6b1
Merge pull request #1448 from harfbuzz/cff-leak
...
[CFF] fix leak: oss-fuzz 11662
2018-12-05 13:23:23 +03:30
620d1ef588
fix unsigned long const
2018-12-05 00:36:11 -08:00
28dfb4c142
fix signed/unsigned comparison
2018-12-05 00:26:03 -08:00
f9cee08edd
use sized int types in parse_bcd
2018-12-04 23:58:26 -08:00
c01a5f32a3
refix
2018-12-04 23:23:23 -08:00
755fefc921
fix bug
2018-12-04 23:18:28 -08:00
0e81b153af
fix typo
2018-12-04 22:40:07 -08:00
85d4b15cd8
include float.h
2018-12-04 22:30:33 -08:00
5a7c371e4c
check overflow & clamp
2018-12-04 22:24:38 -08:00
32cc46c75a
[CFF] fix oss-fuzz issue 11670: NULL dereference ( #1450 )
...
* guard against no subr access
* code tweak
* add minimized testcase for oss-fuzz 11670 (Null deference)
2018-12-05 09:02:34 +03:30
d3d2f32c6e
fix oss-fuzz 11657: buffer overrun
...
Check overrun in Charset1_2::get_glyph
2018-12-04 13:51:26 -08:00
d0a250a7b1
Reuse hb_aat_layout_has_* logic in coretext-aat detection logic ( #1442 )
2018-12-04 23:42:13 +03:30
803d2f92dc
Merge branch 'master' into cff-leak
2018-12-04 11:01:26 -08:00
6ce8d10b45
add unlikely to error handling
2018-12-04 10:39:17 -08:00
0b952e6026
more leak fixes
2018-12-04 10:22:35 -08:00
9473463f5c
fix attempt for oss-fuzz 11662 leak
2018-12-04 09:58:48 -08:00
04f2ca9421
removed assert
2018-12-04 09:24:07 -08:00
c968869f21
Merge pull request #1441 from harfbuzz/cff-doublenum
...
use double as CFF Number implementation
2018-12-04 04:14:13 -05:00
c48f53d309
more double changes
2018-12-03 16:59:41 -08:00
5fff6ab002
additional precision made a difference in extents test
2018-12-03 16:06:58 -08:00
9e5180cd44
more double changes
2018-12-03 15:32:42 -08:00
9af33d7a2a
Number to use double for all types
2018-12-03 14:48:46 -08:00
01f628cf55
[aat] Expose hb_aat_layout_has_tracking API
2018-12-03 22:27:26 +03:30
d19b1680b5
[aat] Expose a couple APIs
...
New API:
+hb_aat_layout_has_substitution()
+hb_aat_layout_has_positioning()
2018-12-03 10:41:37 -05:00
84efe0438e
[aat] Fix division sign fallout
...
Happened after 11d2f49af8
2018-12-02 12:39:14 -05:00
2087f5a2a7
Add casts to hb_array_t<>
2018-12-01 20:04:45 -05:00
58d4d19947
Simplify build source list
2018-12-01 19:34:18 -05:00
11d2f49af8
New approach to change BigEndian casts to be int-sized
...
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
2018-12-01 13:12:21 -05:00
50e0273ab1
Change hb_assert_unsigned_t<> to hb_is_signed<>
2018-12-01 13:07:49 -05:00
c3a8b047aa
Revert "Change BigEndian casts to be int-sized"
...
This reverts commit eb5ddd32bf
2018-12-01 00:26:39 -05:00
be45677ab6
Minor
2018-12-01 00:04:29 -05:00
eb5ddd32bf
Change BigEndian casts to be int-sized
...
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
2018-12-01 00:03:01 -05:00
e8860fdcaa
Fix more warning
2018-11-30 23:38:24 -05:00
af349ee348
Fix warning
2018-11-30 23:20:50 -05:00
825df6dbc7
[CFF] Change spaces to tabs
2018-11-30 23:04:59 -05:00
592f39b3c4
[CFF] Whitespace
2018-11-30 22:54:57 -05:00
a2e8d1d455
Minor
2018-11-30 22:54:20 -05:00
5e64e0f532
Merge pull request #1113 from harfbuzz/cff-subset
...
CFF/CFF2 subsetter
2018-11-30 22:40:54 -05:00
09096aa89f
Use nullptr instead of 0/NULL. ( #1435 )
...
* Use nullptr instead of 0/NULL.
* Update test-name-table.cc
2018-11-30 22:22:49 -05:00
d8c6913765
undo 0u
2018-11-30 18:58:14 -08:00
2c859b3880
Merge branch 'master' into cff-subset
2018-11-30 18:47:34 -08:00
fb05908213
Revert ugly fixes
...
Now that we have 6daf45e0, revert cryptic hacks...
This reverts commit abd81ed4f59c6921c08cd39760cabffedd8e6c17https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-30 20:56:15 -05:00
dfad19ad5a
Make operator [] take signed int
...
The built-in operator takes signed int. So, match it, such that
the built-in is never a better or equally-good match to our operator.
Fixes "ambiguous overload" errors from gcc 4.2 and VS 2008.
See https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-30 20:56:14 -05:00
9483da145d
redo fixes
2018-11-30 16:59:41 -08:00
291da44823
yet another
2018-11-30 16:50:46 -08:00
b1821b9d09
some more
2018-11-30 16:31:01 -08:00
9784cff556
fix another pesky gcc error
2018-11-30 16:07:08 -08:00
23a797b443
silence picky gcc errors
2018-11-30 15:15:31 -08:00
9ae954f43a
Merge branch 'master' into cff-subset
2018-11-30 15:00:52 -08:00
fedd8e6c17
One more.........
...
I wonder if there's something better to do about these :(.
In file included from hb-ot-color.cc:31:
hb-ot-color-cpal-table.hh: In member function 'unsigned int OT::CPAL::get_size() const':
hb-ot-color-cpal-table.hh:118: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
2018-11-30 16:50:30 -05:00
bc5db9b080
One more....
...
hb-ot-vorg-table.hh:96: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:87: note: candidate 1: const Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) const [with Type = OT::VertOriginMetric, unsigned int PreallocedCount = 8u]
hb-ot-vorg-table.hh:96: note: candidate 2: operator[](const T*, int) <built-in>
2018-11-30 16:04:52 -05:00
d39760cabf
One more...
...
Sigh.
hb-ot-kern-table.hh: In member function 'int OT::KernSubTableFormat3<KernSubTableHeader>::get_kerning(hb_codepoint_t, hb_codepoint_t) const':
hb-ot-kern-table.hh:59: error: ambiguous overload for 'operator[]' in 'kernValue[kernIndex[i]]'
hb-ot-kern-table.hh:59: note: candidates are: operator[](T*, int) <built-in>
hb-dsalgs.hh:574: note: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::IntType<short int, 2u>]
2018-11-30 15:55:30 -05:00
9c6921c08c
More...
...
hb-ot-layout-gsubgpos.hh:1707: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
...
2018-11-30 15:16:57 -05:00
f998bb2086
More weird fixes
...
In file included from hb-ot-name.cc:29:
hb-ot-name-table.hh: In member function 'unsigned int OT::name::get_size() const':
hb-ot-name-table.hh:157: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::NameRecord]
hb-ot-name-table.hh:157: note: candidate 2: operator[](const T*, int) <built-in>
hb-ot-name-table.hh: In member function 'void OT::name::accelerator_t::init(hb_face_t*)':
hb-ot-name-table.hh:196: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
hb-ot-name-table.hh:196: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-name-table.hh:197: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
hb-ot-name-table.hh:197: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-name-table.hh:198: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
hb-ot-name-table.hh:198: note: candidate 2: operator[](T*, int) <built-in>
make[4]: *** [libharfbuzz_la-hb-ot-name.lo] Error 1
make[3]: *** [all-recursive] Error 1
2018-11-30 12:52:21 -05:00
abd81ed4f5
Umm. Cryptic, yes
...
In file included from hb-face.cc:35:
hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_compiles_assertion_on_line_388() const':
hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>]
hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in>
hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_instance_assertion_on_line_388() const':
hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>]
hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in>
hb-face.cc: In function 'hb_blob_t* _hb_face_builder_data_reference_blob(hb_face_builder_data_t*)':
hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:650: note: candidate 2: operator[](T*, int) <built-in>
hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:650: note: candidate 2: operator[](const T*, int) <built-in>
hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:651: note: candidate 2: operator[](T*, int) <built-in>
hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:651: note: candidate 2: operator[](const T*, int) <built-in>
2018-11-30 11:52:41 -05:00
0f32c95e14
Fix a few more sizeof(vector[0]) errors with weird compilers
2018-11-30 11:31:39 -05:00
88630a458b
Fix build for realz
2018-11-30 01:11:04 -05:00
346286d04e
Fix build
2018-11-30 00:44:40 -05:00
31f39cb41e
[post] Rename v2 to v2X
2018-11-30 00:38:08 -05:00
e3dd47e602
Move things
2018-11-30 00:32:12 -05:00
27a6b0a2f7
Fix build for realz
2018-11-29 16:29:30 -05:00
e2af4dd1ec
[uniscribe] Fix build
2018-11-29 16:03:24 -05:00
e7bd29ea11
Limit __builtin_bswap16 to GCC >= 5 as it was implemented on 4.8
2018-11-29 23:47:20 +03:30
ac0264717b
[coretext] Fix compile
...
Fingers crossed.
2018-11-29 15:07:44 -05:00
5c4fead734
Convert "static const hb_tag_t" constants to enum
2018-11-29 15:05:47 -05:00
9e4138c825
Convert misc "static const" constants to enum
2018-11-29 15:01:10 -05:00
44cbd2ea3d
Convert "static const bool" constants to anonymous enum
2018-11-29 14:56:27 -05:00
861bc75349
[vector] Make pointer cast explicit
...
Too bad this doesn't help MSVC 2008 build, as explicit operators are
C++11.
2018-11-29 14:34:44 -05:00
72955e6825
Hand-hold older compilers
2018-11-29 14:28:44 -05:00
000d4b128e
Make shaper's override_features() override user features as well
...
The override_features is used to override features that are normally
discretionary features, but in a specific shaper are for various
reasons desired to be bolted on or off, because they've been used
for inherent shaping. As such, it makes sense that they also
override user features. Ie. if user turned 'liga' on, we don't
want Khmer shaping to become broken... Or turn 'clig' off...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1310
2018-11-29 12:32:47 -05:00
a95d9d8c84
[khmer] Move 'clig' to overrides
...
Prerequisite for https://github.com/harfbuzz/harfbuzz/issues/1310
2018-11-29 12:32:04 -05:00
282ce7230b
Fix "typename outside template" issues
...
Nothing an extra template class wouldn't fix...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1419
2018-11-29 12:18:14 -05:00
dc41ecef85
2.2.0
2018-11-29 11:53:53 -05:00
7b85081be4
[icu] Minor
2018-11-29 11:34:22 -05:00
0bcb1de126
Merge pull request #1418 from gvictor/replace_icu_deprecated
...
Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT
2018-11-29 10:39:18 -05:00
471db3aa6f
workaround for issue #1417
2018-11-28 17:06:11 -08:00
32d291ae89
Merge branch 'master' into cff-subset
2018-11-28 16:27:45 -08:00
42a2b496e4
[kerx] Fix Format2 index calc again
2018-11-28 15:24:30 -05:00
a3267cf803
[kern] Fix kern table Format2 offsetToIndex
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1421
2018-11-28 15:06:01 -05:00
f9a9c0fd1e
[kerx] Fix ClassTable implementation for 'kern' table Format 2
2018-11-28 14:51:56 -05:00
5b4a789ca8
[aat] Towards adding two ClassTable's
2018-11-28 14:49:45 -05:00
987f418772
Merge pull request #1398 from Adenilson/bigInt01
...
Optimize harfbuzz big integer conversions
2018-11-27 17:40:32 -05:00
4e2a03b6b6
Comment
2018-11-27 17:40:09 -05:00
4a719a7f4c
Optimize harfbuzz big integer conversions
...
Profiling showed that type conversions were adding considerable cycles in time
spent doing text shaping.
The idea is to optimize it using native processor instructions to help Blink
layout performance.
Doing further investigation revelead that compilers may not use the
proper instruction on ARM 32bits builds (i.e. REV16).
One way to insure that the generated ASM was ideal for both gcc/clang
was using __builtin_bswap16.
Added bonus is that we no longer need to test for CPU architecture.
2018-11-27 13:43:05 -08:00
a85886fc77
Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT
...
Use of the deprecated API USCRIPT_CODE_LIMIT prevents harfbuzz
using the ICU4C as a shared library.
The API has been replaced by u_getIntPropertyMaxValue(UCHAR_SCRIPT)
2018-11-27 11:51:45 +00:00
574d888c8a
[aat] Ignore GSUB table of Muthu Foundry if they have morx table
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1410
2018-11-25 16:51:22 -05:00
4151c2848d
[GDEF] Move more code
2018-11-25 16:38:36 -05:00
4f21703f22
[GDEF] Move code around
2018-11-25 15:59:18 -05:00
4ed9fb1a00
[GDEF] Minor
2018-11-25 15:53:20 -05:00
926f512f35
[aat.feat] Rework API and implementation
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1346
2018-11-25 01:16:02 -05:00
84dacbca7e
[aat.feat] Add _MAX_VALUE to enums
2018-11-25 01:16:02 -05:00
3922aae162
[aat.feat] Minor
2018-11-25 01:16:02 -05:00
0f8e98eca2
[aat.feat] Whitespace
2018-11-25 01:16:02 -05:00
c225606833
[aat.feat] Port to SortedUnsizedArrayOf.bsearch()
2018-11-25 01:16:02 -05:00
52ae9867ef
[AAT.feat] Use lsearch for looking up SettingName's
...
They are not sorted.
2018-11-25 01:16:02 -05:00
44b9331f66
[aat] Fix include issues
2018-11-25 01:16:02 -05:00
b206133d1f
[aat] Move contents of hb-aat.h to hb-aat-layout.h
...
Since it was pages and pages...
2018-11-25 01:16:02 -05:00
2cb235d021
[aat.feat] Fix enum namespace
2018-11-25 01:16:02 -05:00
712762cabb
Minor
2018-11-25 01:16:02 -05:00
e20f81f4fa
[aat] Rename feat API a bit more
2018-11-25 01:16:02 -05:00
54f4c17f0a
[feat] Rename API uses of setting to selector
2018-11-25 01:16:02 -05:00
9c64b216ec
[feat] Apply renamings and add documentation
2018-11-25 01:16:02 -05:00
a8726cb483
[feat] Use bsearch
2018-11-25 01:16:02 -05:00
4009a05ca7
[feat] Address Behdad comments
2018-11-25 01:16:02 -05:00
19b6025534
[feat] Address @behdad comments
2018-11-25 01:16:02 -05:00
9212ec203c
[feat] Complete feature types list
2018-11-25 01:16:02 -05:00
fbad794bd2
[feat] Add feature iteration API
2018-11-25 01:16:02 -05:00
7a0471aa35
[feat] Turn AAT feature id into enum
2018-11-25 01:16:02 -05:00
b233fa4bc9
[feat] Rename records to selectors as @drott
2018-11-25 01:16:02 -05:00
a157b3e4eb
[feat] Apply @behdad comments
2018-11-25 01:16:02 -05:00
3aff3f822f
[feat] Apply @drott and @jfkthame comments
2018-11-25 01:16:02 -05:00
b791bbbae4
[feat] Apply @jfkthame reviews
2018-11-25 01:16:01 -05:00
95abd53758
[feat] Expose public API
...
* hb_aat_get_feature_settings
2018-11-25 01:16:01 -05:00
9326912941
[kerx] Fix crash
2018-11-25 00:27:23 -05:00
6ee401049d
Simplify sanitize set_object() / fix bots
2018-11-25 00:21:13 -05:00
c5a6b355e1
[kerx] Port to hb_sanitize_with_object_t
2018-11-24 23:49:23 -05:00
c405ed0509
[morx] Port to hb_sanitize_with_object_t
2018-11-24 23:46:15 -05:00
1e8994221f
Add hb_sanitize_with_object_t
...
Context manager.
2018-11-24 23:38:06 -05:00
b3c5affc05
Simplify sanitize set_object()
2018-11-24 23:34:34 -05:00
3d30972699
[aat] Skip terminator in VarSizedBinSearchArray<>
...
Fixes shaping with Apple Chancery on 10.13 again. In that font,
there was a terminator segment, that was tripping off sanitize().
2018-11-24 23:12:28 -05:00
4202a3cde3
Minor
2018-11-24 22:49:50 -05:00
1c2302bbf1
[debug] Print function in return_trace()
2018-11-24 22:32:17 -05:00
748198a671
Revert "[aat.morx] Remove set_object() business"
...
This reverts commit ae8ed58a6e
2018-11-24 22:16:59 -05:00
c8a2dc820e
Revert "[aat.kerx] Remove kerx subtable boundary enforcement"
...
This reverts commit 15905a2a29
2018-11-24 22:16:53 -05:00
9eeebd8dde
Revert "[sanitize] Remove now-unused set_object() machinery"
...
This reverts commit bbdb6edb3e
2018-11-24 22:16:47 -05:00
f47c5da0aa
[arrays] Use hb_array_t<> in all places with sub_array()
2018-11-24 21:36:57 -05:00
3246a8ebbd
[arrays] Merge ArrayOf's sub_array into hb_array_t's
2018-11-24 21:32:00 -05:00
bbdb6edb3e
[sanitize] Remove now-unused set_object() machinery
2018-11-24 17:15:38 -05:00
15905a2a29
[aat.kerx] Remove kerx subtable boundary enforcement
...
Have not encountered fonts needing this, but same reasoning as
for morx (see previos commit.)
2018-11-24 17:14:39 -05:00
ae8ed58a6e
[aat.morx] Remove set_object() business
...
With OS X 10.13 Apple Chancery fails to ligate if we limit each morx
sub-chain to its declared length. Perhaps their newer compiler does
object-sharing across sub-chains. Anyway, since that's a valid, if
unspecified, way to compile tables, remove enforcement.
Probably do the same with kern/kerx.
2018-11-24 17:14:09 -05:00
20edc70d53
[morx/kerx] Fix sanitize regression
...
Broke in 8dcc1913a1
2018-11-24 14:53:05 -05:00
ae96c98dfa
[color] Use SortedUnsizedArrayOf<>
2018-11-24 10:25:10 -05:00
4a3b20738f
[trak] Coment
2018-11-24 10:17:59 -05:00
918b1ee54d
[arrays] Add not_found to reference bsearch as well
2018-11-24 10:09:17 -05:00
d77a098b73
[arrays] Improve bfind() interface
...
Much more useful now. :)
2018-11-24 10:06:13 -05:00
8dcc1913a1
[kerx/morx] Make sure object length is sanitized before accessing it
2018-11-24 09:48:06 -05:00
70d80c90fe
[arrays] Port ArrayOf.qsort() and hb_vector_t.qsort() to hb_array_t
2018-11-24 09:48:06 -05:00
073d837aa2
[arrays] Port ArrayOf.qsort() to hb_array_t's
2018-11-24 09:48:06 -05:00
ad5c871d80
[arrays] Add copy-constructor to hb_array_t and hb_sorted_array_t
2018-11-24 09:48:06 -05:00
61de55bf49
[arrays] Port hb_vector_t.qsort() to hb_array_t's
2018-11-24 09:48:06 -05:00
e3face8e79
[arrays] Remove one flavor of hb_vector_t.qsort()
2018-11-24 09:48:06 -05:00
7c1600dcd9
[arrays] Add (unused) SortedUnsizedArrayOf<>
2018-11-24 09:48:06 -05:00
e700392f5c
[arrays] Port SortedArrayOf.bsearch/bfind to hb_sorted_array_t's
2018-11-24 09:48:06 -05:00
e604306f28
[arrays] Port hb_vector_t.bsearch/bfind to (new) hb_sorted_array_t's
2018-11-24 09:48:06 -05:00
268eca2492
[arrays] Port (unused) ArrayOf.lsearch() to hb_array_t's
2018-11-24 09:48:06 -05:00
830856ba6b
[arrays] Port hb_vector_t.lsearch() to hb_array_t's
2018-11-24 09:48:06 -05:00
96cf088980
[arrays] More
2018-11-24 09:48:06 -05:00
3e26c8d2b1
[arrays] Update ArrayOf.lsearch()
...
Currently unused apparently
2018-11-24 09:48:06 -05:00
22e1857b01
[arrays] Change argument type of cmp called by hb_vector_t.bsearch()
...
Towards consolidating all array bsearch/...
2018-11-24 09:48:06 -05:00
30cb45b3ea
Change ArrayOf.bsearch() return semantics
...
Towards consolidating all array bsearch/...
2018-11-24 00:48:26 -05:00
5cd9546ba7
Minor
2018-11-24 00:46:07 -05:00
fd94e729cb
Whitespace
2018-11-24 00:46:07 -05:00
bb2a206508
Assert that item-type of arrays have static size
2018-11-24 00:31:40 -05:00
690d9eb83d
[vector] Rename
2018-11-24 00:29:22 -05:00
ba38378fd4
[aat] Minor
2018-11-24 00:27:57 -05:00
39b9d63b01
Add hb_static_size(T)
2018-11-24 00:25:40 -05:00
f99abcc379
Add template-function convenience macros
2018-11-24 00:24:01 -05:00
ec83b2228e
Add null bytes for CmapSubtableLongGroup
2018-11-23 19:59:31 -05:00
e2ffb33a53
Remove lsearch for small TableDirectorys
2018-11-23 16:24:28 -05:00
04f7e55369
[arrays] Add as_array() to hb_vector_t<>
2018-11-23 16:07:43 -05:00
c514f65181
[arrays] Add as_array() to ArrayOf<>
2018-11-23 16:04:56 -05:00
9552f4ef0d
[kern] Don't enforce length of last subtable
2018-11-23 15:24:17 -05:00
018ba46e4d
Don't canonicalize '@' to '-' in language tags
...
Fixes #1406 .
2018-11-23 13:21:22 -05:00
748962264a
[aat] Disable mark advance zeroing if kern table has state-machines
...
Geeza Pro for example, relies on that for fancy mark positioning.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1405
2018-11-23 11:10:17 -05:00
3d2b98ef14
Minor
2018-11-23 10:58:43 -05:00
22798e93c4
[use] Minor clarification
2018-11-22 22:47:51 -05:00
a2d6c1075a
Minor tweak to FLAG64
2018-11-22 22:40:57 -05:00
8280459e74
Merge pull request #1291 from harfbuzz/use-reordering
...
[use] Fix reordering
2018-11-22 22:39:12 -05:00
e4a4555d1e
[cmap] Move code around
2018-11-22 22:17:49 -05:00
758c9d68e2
[morx/kerx] Limit range to subtable when sanitizing
2018-11-22 22:16:12 -05:00
a9fe787a11
[sanitizer] Add reset_object(), make set_object() do bounds-check
...
Affects morx/kerx run-time only currently. Will adjust their sanitize next.
2018-11-22 22:12:36 -05:00
2c8188bf59
[kerx] Make sure subtables are non-zero-length
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11400
2018-11-22 22:02:19 -05:00
a9e0bdc35d
[GSUB] Don't flush glyphset during recursion in closure()
...
See comment.
Supercedes https://github.com/harfbuzz/harfbuzz/pull/1401
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11366
2018-11-22 21:30:04 -05:00
d0e81b2cc8
[set] Rename
2018-11-22 21:20:39 -05:00
e866910579
Enforce requiring null_size even if min_size is 0
...
This concludes null-size enforcement changes
2018-11-22 18:07:59 -05:00
4d4fd64ff4
Allow non-nullable OffsetTo<> to non-Null'able objects
2018-11-22 18:07:36 -05:00
fa9f585ec5
[glyf] Don't mark structs UNBOUNDED
...
See comments.
2018-11-22 17:56:51 -05:00
f47a60a754
Mark UnsizedArrayOf<> as UNBOUNDED
...
Since min_size is 0, Null() still accepts this type.
2018-11-22 17:53:29 -05:00
199a0f7b41
[ot-shape] Simplify logic
2018-11-22 17:31:07 -05:00
014e4980ed
Move
2018-11-22 16:21:49 -05:00
62890dee18
[aat] Zero mark advances if decided so even if there's cross-kerning
...
Cross-kerning can only take care of positioning vertically. It doesn't
adjust mark advance...
2018-11-22 16:20:29 -05:00
a201fa74cd
[aat] Tweak fallback positioning logic when applying morx
...
Such that for Indic-like scripts (eg. Khmer), we don't do any fallback mark
advance-zeroing / positioning, but we do for Latin, etc. Reuses preferences
of our script-specific OpenType shapers for those.
Fixes regression: https://github.com/harfbuzz/harfbuzz/issues/1393
Which means, fixes again: https://github.com/harfbuzz/harfbuzz/issues/1264
While not regressing: https://github.com/harfbuzz/harfbuzz/issues/1357
2018-11-22 15:52:29 -05:00
fa0bd8964d
[myanmar] Minor move
2018-11-22 14:46:39 -05:00
7dc561984b
[myanmar] If there's no GSUB table, pick myanmar shaper
...
Needed for morx+kern mark-zeroing interaction. All other scripts
work this way.
2018-11-22 14:45:46 -05:00
25f52f58c2
[myanmar] Remove myanmar_old shaper
...
Over time it has become the same as default shaper. So, remove.
2018-11-22 14:41:01 -05:00
eeed802b1d
Fix spurious gcc warnings
...
../../src/hb-null.hh:53:39: warning: enum constant in boolean context [-Wint-in-bool-context]
2018-11-22 01:53:36 -05:00
b96ecb9971
More
...
This makes more of the gcc spurious warning:
../../src/hb-null.hh:53:39: warning: enum constant in boolean context [-Wint-in-bool-context]
But not going to let that defeat correct code. Type to switch to clang
as my main compiler...
2018-11-22 01:49:12 -05:00
2737aa81e5
Fix up recent change
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1300
2018-11-22 01:44:27 -05:00
fffea5aff7
Minor
2018-11-22 01:25:34 -05:00
209b58ef73
Minor
2018-11-22 01:22:33 -05:00
3b9fd176e8
Disallow taking Null() of unbounded structs
...
Not sure I've marked all such structs. To be done as we discover.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1300
2018-11-22 01:18:55 -05:00
f2b91d6510
Use Type::null_size for our structs in Null(), sizeof() for other types
2018-11-22 01:10:22 -05:00
7dd945a876
One more time..
2018-11-22 01:05:17 -05:00
d062ad10de
Fix bots happy again, hopefully
...
So, our fallback static_assert cannot be had more than once per line
of source.
2018-11-22 00:39:14 -05:00
fb10c021c8
Revert alignof() == 1 check
...
Bots not happy with using "this" inside assertion...
This reverts 2656644887
2018-11-22 00:21:49 -05:00
8d778877b8
..
2018-11-21 23:46:09 -05:00
8cfeed9948
Minor
2018-11-21 23:42:31 -05:00
e5d954a2fb
Minor
2018-11-21 23:30:50 -05:00
e987059c61
Minor
2018-11-21 23:25:06 -05:00
a2b6d308a4
Remove DEFINE_SIZE_ARRAY2
2018-11-21 23:23:49 -05:00
2656644887
Check alignof() structs are 1
2018-11-21 23:23:21 -05:00
6321fdf704
Whitespace
2018-11-21 23:19:00 -05:00
ecdceea861
Merge pull request #1399 from harfbuzz/sharada-sandhi-mark
...
Fix USE categories for U+111C9 SHARADA SANDHI MARK
2018-11-21 16:12:32 -05:00
b89c7fd3dc
Allow defining HB_USE_ATEXIT to 0
...
That's better use of that value than requiring extra macro HB_NO_ATEXIT
2018-11-21 12:32:48 -05:00
b3d5b0a5d9
Fix USE categories for U+111C9 SHARADA SANDHI MARK
2018-11-21 11:35:44 -05:00
f48bb9a393
[var] Deprecated axis enumeration API and add new version
...
New version has axis flags.
New API:
+hb_ot_var_axis_info_t
+hb_ot_var_find_axis_info()
+hb_ot_var_get_axis_infos()
Deprecated API:
-HB_OT_VAR_NO_AXIS_INDEX
-hb_ot_var_axis_t
-hb_ot_var_find_axis()
-hb_ot_var_get_axes()
2018-11-20 20:46:14 -05:00
b2d803cef6
Remove newly-added -hb_ot_var_axis_get_flags()
2018-11-20 20:46:14 -05:00
736897d7a1
[var] Make sure hb_ot_var_axis_flags_t is int-sized
2018-11-20 20:46:14 -05:00
eab5d15f61
[var] Move code
2018-11-20 20:46:14 -05:00
1ecbf4d3e3
Merge branch 'master' into cff-subset
2018-11-20 17:19:05 -08:00
8295118279
Shrink the emoji table by merging adjacent ranges
2018-11-20 15:41:45 -05:00
be1828daaa
[var] Fix type of coords returned
...
Ouch. Wonder how none of the bots caught the float->int truncation.
2018-11-20 11:16:23 -05:00
831ba74382
Fix Codacy "issues"
2018-11-20 01:16:08 -05:00
3c7792ca32
[use] Fix reordering
...
Fixes #1235 .
2018-11-19 16:49:40 -05:00
587d49fc65
[fvar] Add named-instance API
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1241
2018-11-19 14:51:34 -05:00
46c0da820f
Fix build
2018-11-19 13:32:48 -05:00
56c9238d3d
[fvar] Rewrite sanitize
2018-11-19 13:09:53 -05:00
4a6a692e3e
[fvar] Use hb_array_t for axes
2018-11-19 13:06:44 -05:00
e009739601
[fvar] Minor
2018-11-19 12:53:53 -05:00
1a2eb108b8
[ot-var] Add hb_ot_var_axis_get_flags()
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1241
New API:
+hb_ot_var_axis_flags_t
+hb_ot_var_axis_get_flags
2018-11-19 12:36:56 -05:00
bd6b2ba1d3
[ot-var] Add flags
...
Unfortunate that we don't have room in hb_ot_var_axis_t to expose flags :(.
2018-11-19 11:34:56 -05:00
c076c7b85c
[ot-var] Use hb_ot_name_id_t
2018-11-19 11:30:40 -05:00
515f1a1614
Merge branch 'master' into cff-subset
2018-11-16 17:38:47 -08:00
a6da9b9415
fixed Charset format selection
2018-11-16 17:29:03 -08:00
e3a1a8350a
2.1.3
2018-11-16 16:53:25 -08:00
9714e114b8
Fix recent commits
2018-11-16 16:52:42 -08:00
0328a1ce41
Revert b4c6113032
...
Was causing more trouble than it solved. We use unsigned for indexing,
and it's not helpful to allow that wrapping to negative integers on
32bit machines. The only way we could work around it would have been
by accepting int64_t arg, but that's overkill.
Ignore the MSVC 2008 build issue. We don't support that compiler.
2018-11-16 16:48:28 -08:00
52f61cdb87
Detect over/under-flow in UnsizedArray::operator[]
...
Was causing bad substitutions in mort table because of WordOffsetToIndex()
producing negative numbers that were cast to unsigned int and returned as
large numbers (which was desirable, so they would be rejected), but then
they were cast to int when passed to this operator and acting as small
negative integers, which was bad...
Detect overflow. Ouch, however, now I see this still fails on 32-bit.
Guess I'm going to revert an earlier change.
2018-11-16 16:41:59 -08:00
6910ff03e6
[aat] Fix mort shaping
...
Ouch!
2018-11-16 16:11:02 -08:00
fdb29ab2b0
2.1.2
2018-11-16 15:38:11 -08:00
cff4c6087f
Fix vertical fallback space sign
...
Ouch!
Follow-up to cf203af8a3https://github.com/harfbuzz/harfbuzz/issues/1343
2018-11-16 15:04:41 -08:00
7a97f70740
Don't apply GPOS if applying morx
...
That's what Apple does, and it wouldn't degrade our OpenType performance.
Part of https://github.com/harfbuzz/harfbuzz/issues/1348
2018-11-16 14:46:40 -08:00
eafd515639
Prefer morx table if GSUB is empty (no scripts)
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1348
2018-11-16 14:45:56 -08:00
aa06574823
Minor
2018-11-16 14:31:05 -08:00
b6903bd6c4
ensure fdmap initialized as identity for single-FD (non-CID) fonts
2018-11-16 13:46:58 -08:00
b403be8ad9
Merge branch 'master' into cff-subset
2018-11-16 12:29:18 -08:00
b67a7c731f
drop dotsection as hint along with test case
2018-11-16 12:28:24 -08:00
50d1a41c08
[coretext] Hopefully the last one
2018-11-16 08:52:57 -05:00
0aab861f9c
[coretext] Another round
2018-11-16 08:43:25 -05:00
0809b76a9a
[coretext] One more try..
2018-11-16 08:29:47 -05:00
78bd447594
[coretext] One more try
2018-11-16 04:10:53 -05:00
fd27a23c82
[coretext] Another build fix attemt
2018-11-16 03:57:12 -05:00
729aedf0da
[directwrite] Fix build
2018-11-16 03:26:46 -05:00
cfb9771a3b
[coretext] Try to fix
2018-11-16 03:25:07 -05:00
e3e9547365
[coretext] Unbreak build
2018-11-16 02:55:29 -05:00
ce5da0f36a
[shaper] Rewrite shaper data code to be more template-driven than macro-driven
2018-11-16 02:52:20 -05:00
cb4bf85b14
[hdmx] Fix bounds checking
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11351
2018-11-16 02:02:24 -05:00
af727b4e62
[hdmx] Minor
2018-11-16 01:55:39 -05:00
9e9f16c92d
[subset] Remove invalid glyphs from glypset to retain
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1388
2018-11-16 01:48:26 -05:00
072c7aba92
use 2-byte offset instead of 4-byte for local subrs
...
more than enough since local subrs immediately follow its corresponding private dict, as the result 2-byte redunction for each font dict with local subrs
updated api test expected subset fonts accordingly
2018-11-15 15:41:46 -08:00
9d0231cfe7
fixed a subset bug when no font dicts reduce
2018-11-15 15:39:43 -08:00
11aa0468ac
[subset] minor, adjust spaces
2018-11-16 00:02:47 +03:30
d7c50ff0d6
[math] minor, adjust spaces
2018-11-16 00:02:47 +03:30
13735570f0
reject nested seac
2018-11-15 12:10:23 -08:00
c37aecd41c
Merge branch 'master' into cff-subset
2018-11-15 11:03:46 -08:00
ecdb77f0ae
fixed CFF1 subset of std encoding & non-std charset combo
2018-11-15 10:54:15 -08:00
cabe433fbb
[base] Add TODO items
2018-11-15 02:48:50 -05:00
3bf1ce748f
[shaper] Rename
2018-11-14 21:08:54 -05:00
c221dc0ba7
[ot-shape] Move code around
2018-11-14 19:57:19 -05:00
892ab37e7c
Merge branch 'master' into cff-subset
2018-11-14 13:54:07 -08:00
3787c07856
Implemented seac for extents & subset along with API tests
2018-11-14 13:38:03 -08:00
7867c2bad0
[STAT] Add table parsing ( #1384 )
2018-11-14 22:13:50 +03:30
48d16c2ab2
[hmtx] Fix signedness issue
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1248#issuecomment-438689499
2018-11-14 09:57:05 -05:00
29db2a44a6
[ot-color/svg] Note that it can be gzipped
2018-11-14 12:13:16 +03:30
3c3eb5ea9c
[aat] Disable fallback mark advance zeroing and positioning if morx applied
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1357
2018-11-13 21:10:10 -05:00
dc4225ccd1
Don't retry creating again and again in lazy_loader if create failed
...
Still does that if get_null() returns nullptr. Our shaper data objects
are like that. Shrug.
2018-11-13 20:48:46 -05:00
086235f593
Merge pull request #1382 from punchcutter/master
...
Change USE Category for Grantha Virama
2018-11-13 19:50:25 -05:00
2092f595c7
Merge pull request #1380 from kbrow1i/cygwin
...
Don't use Win32 API on Cygwin
2018-11-13 19:49:06 -05:00
c565fc3fb3
Change USE Category for Grantha Virama
...
https://github.com/harfbuzz/harfbuzz/issues/1379
2018-11-13 12:51:10 -08:00
475be9d5c6
Fix Windows build
2018-11-13 13:01:13 -05:00
fc44dea341
Use atomic ints for upem and num_glyphs on face
2018-11-13 11:54:33 -05:00
9579ed9755
Make atomic types' internal values non-mutable
...
This resulted from confusion previously...
2018-11-13 11:46:20 -05:00
c52d5bcd94
[ot-face] Add 'head' table
2018-11-13 11:41:29 -05:00
eee5b5ed04
Don't use Win32 API on Cygwin
...
Cygwin is a Posix platform to the extent possible. It should use the
Posix API except in special circumstances.
2018-11-12 21:07:34 -05:00
56f541d000
[shape-plan] Remove unused code
2018-11-12 19:46:37 -05:00
6c22f3fd95
[shape-plan] Implement fine-grained caching plans with user-features
...
Only tag, value, and global-ness of features are considered, not their
start/end offsets.
2018-11-12 19:26:01 -05:00
cc8428756a
[shape-plan] Cache shape plans with variations based on variation indices
2018-11-12 18:48:10 -05:00
8284cb9fb3
[shape-plan] Refactor more
2018-11-12 18:18:20 -05:00
1082338525
[shape-plan] Only use shape-plan key to initialize hb_ot_shape_plan_t
...
Such that we don't accidentally use info not in the cache key.
2018-11-12 18:05:02 -05:00
7ac03f88a2
[shape-plan] Minor
2018-11-12 17:50:30 -05:00
c7be933439
[shape-plan] Refactor some more
2018-11-12 17:49:15 -05:00
fc27777833
[shape-plan] Refactor more
2018-11-12 17:27:34 -05:00
566612295b
[shape-plan] Turn hb_shape_plan_proposal_t into hb_shape_plan_key_t
...
And include it in hb_shape_plan_t itself.
2018-11-12 17:19:45 -05:00
af123bd1b8
Add hb_memcmp()
2018-11-12 16:27:08 -05:00
65456bff37
[shape-plan] Minor
2018-11-12 16:21:21 -05:00
1db672a5e9
[shaper] Rename
2018-11-12 16:05:46 -05:00
274f4c726f
Rename check_array2() to check_array()
2018-11-12 14:24:36 -05:00
e014405a21
Rename check_array(array, a, b) to check_range()
2018-11-12 14:23:31 -05:00
c8f4cc4927
[kerx] Fix integer overflow in multiply
...
Fixes https://oss-fuzz.com/v2/testcase-detail/5754863779053568
2018-11-12 14:11:29 -05:00
1300f027a9
[kerx] Minor tweak on previous commit
2018-11-12 13:56:48 -05:00
d6666b3866
[fuzzing] Remove limited-edition build of libraries
...
Use normal, production, shared libraries.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1237
2018-11-12 13:21:14 -05:00
a549aa14a0
[kerx] Protect against stack underflow
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11367
2018-11-12 13:02:39 -05:00
41a8bc7fd9
Merge branch 'master' into cff-subset
2018-11-12 08:49:00 -08:00
0dfa584cb4
changed Adobe company name
2018-11-12 08:47:07 -08:00
3e284e02c2
[shape-plan] Minor
2018-11-11 22:51:34 -05:00
420c9de644
[shape-plan] Minor rename
2018-11-11 22:50:37 -05:00
77bd0a6458
Add variation coords to shape_plan proposal
...
This is the root cause of bug worked around in 19e77e01bc
2018-11-11 22:08:48 -05:00
9c767d075d
Minor
2018-11-11 22:03:15 -05:00
f521a28b4a
Embed hb_ot_shape_plan_t into hb_shape_plan_t
...
No other shaper will need shape_plan_data, by definition. So, remove
abstraction layer and always create hb_ot_shape_plan_t as part of
hb_shape_plan_t.
2018-11-11 21:54:10 -05:00
fabb012104
Remove wrong comment
2018-11-11 17:10:23 -05:00
1fd183ee1c
Finish off eecccc919c
2018-11-11 16:47:52 -05:00
1beacdded9
Minor
2018-11-11 16:35:28 -05:00
e88d47b7f2
Minor
2018-11-11 16:25:43 -05:00
55c66c7c56
Revert "Declare Null() constexpr"
...
This reverts commit 442a72d95a
2018-11-11 16:09:38 -05:00
98c6f03ccd
Minor
2018-11-11 15:54:20 -05:00
442a72d95a
Declare Null() constexpr
2018-11-11 15:51:23 -05:00
eecccc919c
Don't store to null object
...
Ouch :).
2018-11-11 15:48:47 -05:00
903856ab50
Remove unused function
2018-11-11 15:45:58 -05:00
0e0af11c62
[hdmx] Renames
2018-11-11 12:54:16 -05:00
da6aa3b033
Add hb_blob_ptr_t.destroy()
2018-11-11 11:40:57 -05:00
bb9abb4efd
[hmtx/port] Use hb_blob_ptr_t
2018-11-11 00:42:23 -05:00
0e2680a6e8
[cmap] Port to hb_blob_ptr_t
...
Although didn't need it...
2018-11-11 00:28:47 -05:00
0b0fad3ea8
[color] Port to hb_blob_ptr_t
...
Fix hb_blob_ptr_t::get_length () as well.
2018-11-11 00:26:55 -05:00
925b7a214f
Comment
2018-11-11 00:17:30 -05:00
dcb6386833
[shape-plan] Remove use of custom null object
2018-11-11 00:16:17 -05:00
109891d498
[shape-plan] Make null object all zeros
...
To remove custom null object next..
2018-11-11 00:15:08 -05:00
34185ff3bc
[blob] Use default null object
2018-11-11 00:12:30 -05:00
2ee1d9f555
[blob] Change null object memory mode to DUPLICATE
...
We never rely on that being equal to readonly. Just not being
writable. Maybe not even that given that the object is inert.
In prep for next commit, using default null pool.
2018-11-11 00:11:28 -05:00
5d0078a48b
Add hb_blob_ptr_t
...
Use in a couple of places. Push to bots to see how many unhappy before
I convert the rest.
2018-11-10 23:52:15 -05:00
e44046ec49
Minor
2018-11-10 22:41:35 -05:00
752bd8a192
[kerx] Fix Format1 tupleKern sanitization
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11312
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11305
2018-11-10 21:13:32 -05:00
f9e0552deb
[fuzzing] Make "make lib" faster and more usable
2018-11-10 21:06:56 -05:00
4674655841
Minor
2018-11-10 20:11:10 -05:00
a953b64750
Revert parts of previous commit that made clang unhappy
2018-11-10 20:10:03 -05:00
1d66cdcf77
Better fix for MSVC 2008
...
Follow up on b4c6113032https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-10 19:57:51 -05:00
fb2a037f54
Merge branch 'master' into cff-subset
2018-11-10 16:23:11 -08:00
b4c6113032
Try fixing MSVC 2008 build
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-10 16:35:39 -05:00
f2e942f302
Fix hb_bytes_t's unused template array constructor
2018-11-10 16:11:14 -05:00
6213a75b68
Add trivial casts to hb_bytes_t
2018-11-10 16:09:21 -05:00
8bb97d2ce1
Revert back hb_bytes_t.cmp() to the scheme it was
...
But fix UBSan complaint.
There's nothing in hb_bytes_t that guarantees lexical ordering, and
ordering by length first is much faster.
2018-11-10 16:00:51 -05:00
534e1d7694
Fix hb_bytes_t.cmp() for realz this time
2018-11-10 15:45:31 -05:00
929f07dbfc
Fix hb_bytes_t.cmp()
...
Ouch!
2018-11-10 15:39:07 -05:00
1d82b4761d
[colr/feat/trak] minor
2018-11-10 19:31:12 +03:30
3a9fa8c026
[qsort] Fix O(N^2) behavior if all array elements are the same
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11327
Reported as https://github.com/noporpoise/sort_r/issues/7
2018-11-10 01:58:26 -05:00
b308aaccf0
[post] Minor
2018-11-10 01:58:26 -05:00
4111c3b8cd
[post] Move sanitize close to data fields
2018-11-10 01:58:26 -05:00
e26e6dbb33
[post] Remove unnecessary hb_nonnull_ptr_t<>
2018-11-10 01:58:26 -05:00
6b8178c649
[glyf] minor
2018-11-10 02:42:08 +03:30
8798416587
fixed vstem handling (lack thereof) in check_width
...
bug exposed by U+2261 equivalence in SourceCodePro-Regular.otf
2018-11-09 08:59:18 -08:00
5f97fe9956
Fix a few MSVC 2008 warnings
...
https://github.com/harfbuzz/harfbuzz/issues/1374
2018-11-09 10:01:50 -05:00
f51bb6ee7b
Merge pull request #1358 from ebraminio/lcar
...
Hook AAT's lcar to _get_ligature_carets
2018-11-08 14:42:40 -05:00
b986fead0a
Hook AAT's lcar to _get_ligature_carets
2018-11-08 23:06:26 +03:30
2d987110c0
[aat] Minor
2018-11-08 21:46:26 +03:30
b989507fa6
[aat] Minor ( #1369 )
2018-11-08 20:48:54 +03:30
26c291aaa0
Merge branch 'master' into cff-subset
2018-11-08 09:06:49 -08:00
417963dd9f
got rid of Remap::fullset() as incorrect, redundant, inefficient
2018-11-08 09:01:20 -08:00
f90423847b
[just] Initial table implementation ( #1364 )
...
A starting point, its sanitization is not tested however
2018-11-08 19:17:02 +03:30
b8b00fb3c6
[aat] Support Lookup<OffsetTo<>>, needed by just and lcar ( #1368 )
2018-11-08 18:53:14 +03:30
15326826bf
[aat] Ignore cross-stream offset of deleted-glyphs
...
I think it makes sense to accumulate it, but Ned tells me that's
what CoreText does.
2018-11-07 21:58:04 -05:00
636a6833c5
fixed ends_in_hint bug
...
subr ends in hint itself should be regarded as hint
this flag should propagate to its caller if the call itself is at the end of the caller
2018-11-07 17:58:45 -08:00
517a1bac97
Merge pull request #1362 from harfbuzz/cross-kern
...
Vastly improve kern/kerx tables, including cross-stream "kerning"
2018-11-07 18:40:48 -05:00
b18a56a290
[kerx] Comment
2018-11-07 18:13:22 -05:00
4d74020694
Merge branch 'master' into cff-subset
2018-11-07 15:09:30 -08:00
e0c30b961d
merge with cff-subset branch
2018-11-07 15:08:55 -08:00
006386be3a
[kern] Implement negative state numbers
...
Let the fuzzing bots rip this code apart...
2018-11-07 18:04:53 -05:00
0996c0ff62
implented no-desubroutinize with CFF2 along with API test
...
replaced AdobeVFPrototype.abc.otf with a hinted (maually) & subroutinized copy
replaced expected results as well
2018-11-07 14:48:37 -08:00
29c5302376
[morx] Minor
2018-11-07 17:29:37 -05:00
385f78b312
[aat] Remove deleted-glyhs after applying kerx/kern
...
Finally: Fixes https://github.com/harfbuzz/harfbuzz/issues/1356
Test case:
$ ./hb-shape GeezaPro.ttc -u U+0628,U+064A,U+064E,U+0651,U+0629
[u0629.final.tehMarbuta=4+713|u064e_u0651.shaddaFatha=1@0,-200+0|u064a.medial.yeh=1+656|u0628.initial.beh=0+656]
The mark positioning (kern table CrossStream kerning) only works if deleted
glyph (as result of ligation) is still in stream and pushed through the
state machine.
2018-11-07 17:20:47 -05:00
1909072235
[aat] Add debug info to state machine
2018-11-07 16:42:16 -05:00
ca23567f41
Disable fallback mark positioning if kern table has cross-stream kerning
...
Happens even if the cross-stream kerning is for cursive attachment only. Oh well..
2018-11-07 16:19:51 -05:00
5cf6f94dfd
Don't apply both kerx and kern
...
Ouch!
2018-11-07 16:07:22 -05:00
41cff7afc9
Minor
2018-11-07 16:05:36 -05:00
9af983af24
[kern] Switch to dispatch
2018-11-07 16:03:09 -05:00
bc06e2805a
[kerx/kern] Add has_cross_stream()
2018-11-07 16:02:40 -05:00
ea579f9ccc
[kerx] Fix peculiar indexing that was needed previously
...
Not needed now that we use GPOS attachment for cursive kerx.
2018-11-07 15:50:23 -05:00
6ee6cd93d8
[GPOS] Only mark unsafe-to-break if kerning happened
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1365
2018-11-07 15:40:55 -05:00
501a364d9b
[GPOS] Add TODO item
2018-11-07 15:02:16 -05:00
7a9629f2f1
[kerx] Implement CrossStream kerning for non-state-machine subtables
...
Untested.
2018-11-07 14:52:57 -05:00
0eb4157011
[kerx] Disable backwards-kerning for non-state-machine tables
...
That's what the spec says for Backwards flag, only applicable to
formats 1 and 4.
2018-11-07 14:42:15 -05:00
b2f687c256
[kerx] Use GPOS attachment facilities for CrossStream kerning
2018-11-07 14:38:29 -05:00
e10a856eb2
[kerx] Format
2018-11-07 14:11:48 -05:00
649cc3ef27
[kerx] Don't disable crossKerning if kern feature is off
2018-11-07 14:07:13 -05:00
0c3b061ac2
[kern] Apply erlier, where GPOS/kerx are applied
2018-11-07 13:58:41 -05:00
f4bad0086e
[kerx] Implement tupleKerning for Format1
...
Untested.
2018-11-07 13:51:17 -05:00
39b4ef6f18
[kerx] Better sanitize tupleKerning
2018-11-07 13:48:45 -05:00
14772da06f
[kern/kerx] Share KernTable, renamed to KerxTable
2018-11-07 13:40:22 -05:00
c038f5be6b
[fallback] Minor
2018-11-07 13:35:06 -05:00
db6e658e8c
[kern/kerx] More towards sharing KernTable
2018-11-07 13:33:23 -05:00
89ec095979
[kern] Disable Format1 and Format3 for OT-style tables
2018-11-07 13:10:05 -05:00
ab57bcae0f
[kern] Minor
2018-11-07 13:04:21 -05:00
30af5b4a4c
[kern] Move code
2018-11-07 12:57:10 -05:00
1ff300464a
[kern] Massage more
2018-11-07 12:51:49 -05:00
8e9f6cd0fd
[kerx] More minor
2018-11-07 12:49:20 -05:00
f8c3df7d4a
[kern/kerx] Minor
2018-11-07 12:48:06 -05:00
f5e0a63a22
[kern/kerx] Towards sharing KernTable
2018-11-07 12:32:51 -05:00
330508497d
[kern/kerx] Minor
2018-11-07 12:27:44 -05:00
1a5ef84900
[kern/kerx] Share Format2
...
This, enables Format2 for kern table, which was disabled before.
2018-11-07 12:19:52 -05:00
8faec4e334
[kerx] Towards merging Format2
2018-11-07 12:16:38 -05:00
ae8fd0dbfb
clear stack after vsindex op
2018-11-07 09:16:12 -08:00
7fed7d80f7
fixed off-by-one error in CFF1 Encoding lookup
2018-11-07 09:09:13 -08:00
d5c0ca210f
[aat] Minor
2018-11-07 12:08:44 -05:00
e72e041c3c
[kerx] Rename
2018-11-07 11:56:36 -05:00
241ba7da51
[morx/kerx] Rename types
2018-11-07 11:51:40 -05:00
c808e444da
[kern/kerx] Share Format1 subtable
2018-11-07 11:47:12 -05:00
a244190afa
[kerx] Minor
2018-11-07 11:47:12 -05:00
2a72091196
[kerx] Minor
2018-11-07 11:26:57 -05:00
f5f4ca7871
[kern/kerx] Enable crossStream kerning in vertical
...
CoreText doesn't, but no reason we shouldn't do.
2018-11-07 11:21:09 -05:00
d5c88af4a2
[kerx] More towards sharing Format1
2018-11-07 11:20:14 -05:00
b693fd0dc6
[morx] Simplify
2018-11-07 11:10:24 -05:00
ce3451dc2a
[kerx] Towards sharing Format1
2018-11-07 11:02:04 -05:00
e890753ebb
[morx] Minor
2018-11-07 10:59:53 -05:00
5b17853547
[kern/kerx] Share Format0
2018-11-07 10:45:25 -05:00
c97dde5d55
[kern/kerx] Towards merge more
2018-11-07 10:39:39 -05:00
540ccc38b0
[kern/kerx] More towards sharing
2018-11-07 10:33:46 -05:00
d0f8f4c200
[kern] Move kern machine to hb-kern.hh
2018-11-07 10:25:25 -05:00
a6acff252c
[kerx] Towards sharing subtables with kern
2018-11-07 10:19:57 -05:00
befac337ca
[kern] Remove Override business
...
Not used in any fonts. Not well-specified when mixing kerning with
Cross-Stream positioning.
2018-11-07 09:53:50 -05:00
9d5027696e
[post] Return true on truncation
...
Client can check that buffer was completely filled out and reallocate.
2018-11-07 09:16:53 -05:00
7d91f07edf
[post] Protect against huge empty tables
2018-11-07 09:14:42 -05:00
5ed816ab59
[post] Minor
2018-11-07 09:13:51 -05:00
64f0becd89
[post] Fix bound checking
2018-11-07 09:10:55 -05:00
7ec694ddf2
Use non-GRID-fitted values for metrics ( #1363 )
...
* Use non-GRID-fitted values for metrics
See freetype/src/base/ftobjs.c:ft_recompute_scaled_metrics() and
the usage of GRID_FIT_METRICS inside.
Fixes https://github.com/behdad/harfbuzz/issues/1262
* Update hb-ft.cc
2018-11-07 08:19:36 -05:00
59e04e4231
[kern/kerx] Fix cursive joining
...
Tested with Waseem TTC:
$ hb-shape Waseem.ttc جحخج
[F1Jeem_R2=3@0,180+479|M1Khah_L2_R2=2@0,682+403|M1Hah_L2_R2=1@0,1184+403|I1Jeem_L2=0@0,1184+744]
2018-11-07 00:27:20 -05:00
8d0f797139
[kern/kerx] Fix "reset" magic value
2018-11-07 00:05:10 -05:00
0123976a0c
[kerx] Adjust CrossStream kern to match 'kern' table
2018-11-06 21:46:14 -05:00
80a33b9ac3
[kern] More tweaks
...
Solves a mystery or two. I'm fairly confident this is what CoreText does now.
2018-11-06 21:46:14 -05:00
564e8ac046
[kern] Adjust some more
...
Getting closer. So many open questions still...
2018-11-06 21:46:14 -05:00
4d003b8503
[kern] Add TODO
2018-11-06 21:46:14 -05:00
9810f0b80e
[kern] Minor
2018-11-06 21:46:14 -05:00
9c04b60583
[kern] In Format1, adjust how kerning is done
...
In a series of kerns in one action, kern all but last glyph forward,
and the last one backward. Seems to better match what CoreText is doing.
Test cases, with GeezaPro Arabic:
$ ./hb-shape GeezaPro_10_10.ttc -u U+0631,U+0628
[u0628.beh=1+1415|u0631.reh=0@-202,0+700]
$ ./hb-shape GeezaPro_10_10.ttc -u U+0628,U+064F
[u064f.damma=0@0,-250+-250|u0628.beh=0@250,0+1665]
In a later change, I'll make kern machine avoid producing negative kerns.
2018-11-06 21:46:14 -05:00
e8c4772463
[kern] XXX Negate CrossKerning sign
...
Not sure why, but seems to better match GeezaPro Arabic w CoreText.
Quite possibly I'm doing something very wrong...
2018-11-06 21:46:14 -05:00
01bf43ac01
[kern] Implement CrossStream kerning
2018-11-06 17:59:31 -05:00
b11830c09e
[kern] Improve Format 2
...
Still disabled.
2018-11-06 17:59:31 -05:00
c0383c6bb7
Minor
2018-11-06 17:59:31 -05:00
10e6f708f3
[kern] Minor
2018-11-06 17:16:23 -05:00
164eedd918
[kern] Minor
2018-11-06 17:16:23 -05:00
220a5991ba
[kern/kerx] Fix trace numbering
2018-11-06 17:16:23 -05:00
7b21319edf
don't reject empty Dict
2018-11-06 13:59:07 -08:00
43ee0e4d00
Merge branch 'master' into cff-subset
2018-11-06 09:57:17 -08:00
bfafe208da
[kern] Switch to dispatch
2018-11-06 12:13:20 -05:00
213fa3bf71
[kern] Refactor to include header in each subtable type
2018-11-06 12:13:20 -05:00
b0da2cd0b9
[kern] Some more
2018-11-06 12:13:20 -05:00
75b00b51c8
[kern] Renames
2018-11-06 12:13:20 -05:00
37f421c951
Minor
2018-11-06 10:03:38 -05:00
9139cc23ea
Fix link issue of some of the bots
...
e.g. https://circleci.com/gh/harfbuzz/harfbuzz/52410
2018-11-06 11:17:14 +03:30
98b37f0c10
[mort] Fix table detection logic
...
mort really needs some initial tests at least.
2018-11-06 09:16:28 +03:30
fa3ebf845f
Simplify some more
2018-11-05 23:34:07 -05:00
61f52231f4
[math] Shorten names a bit
2018-11-05 23:28:52 -05:00
737efbe655
[ot-layout] Simplify GSUB/GPOS access
...
This concludes simplifying table access to face->table.XXXX.
2018-11-05 23:26:29 -05:00
5e68cec179
[ot-layout] Simplify GDEF access
2018-11-05 23:23:57 -05:00
33b006cc51
[ot-layout] Simplify some access
2018-11-05 23:19:04 -05:00
db35409f0d
[ot-layout] Remove ensures
2018-11-05 23:11:46 -05:00
9198de7b9b
[ot-font] Remove ensure
2018-11-05 23:10:37 -05:00
ea6d9b661f
[ot-face] Remove a few ensures
2018-11-05 23:10:21 -05:00
0fe7a745c9
[ot-face] Simplify more table access
2018-11-05 23:10:18 -05:00
a35c92cbe7
[ot-face] Simplify table access
...
Yoohoo!
2018-11-05 23:10:16 -05:00
914b595f25
[ot-face] Include hb-ot-face directly in hb_face_t
...
Simplifying access coming next.
2018-11-05 23:10:12 -05:00
56ba998cdd
[cmap] Push get_nominal_glyphs down into cmap accelerator
2018-11-05 19:49:54 -05:00
36d85dce25
[cmap] Use hb_nonnullptr_t
2018-11-05 19:46:29 -05:00
8be74d8553
2.1.1
2018-11-05 18:47:22 -05:00
252632c477
[uniscribe] Fix use of deprecated API
2018-11-05 14:33:41 -05:00
bb380ec183
[cmap] Make null accelerator safe
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1146
2018-11-05 13:47:30 -05:00
f6fc5574d3
Add pointer magic operators to hb_atomic_ptr_t
2018-11-05 13:23:54 -05:00
f6e7cb51b1
Fix const-confusion in hb_array_t as well
2018-11-05 13:23:07 -05:00
0da22fb0ad
[null] Tweak hb_nonnull_ptr_t some more
2018-11-05 13:20:06 -05:00
03348ce005
Minor
2018-11-05 12:59:32 -05:00
b721fdae66
fixed leaks in CFF subr subset
2018-11-04 16:19:15 -08:00
85f5644e8e
added missing switch breaks
2018-11-04 14:17:30 -08:00
1682d1bbec
Merge branch 'master' into cff-subset
2018-11-04 13:25:41 -08:00
b605db2f65
[aat] Clean up ankr table include mess
2018-11-04 12:58:02 -05:00
17335a8161
Clean up buffer->swap_buffers() calls
...
That function checks for buffer->successful already. No need
to check at call site.
2018-11-04 02:25:07 -05:00
191ca0f15b
CFF1 no-desubr fixes
...
make sure charstring/subrs not ending with endchar/return handled correctly
if no local subrs, skip serializing Subrs op in Private
misc fixes
2018-11-03 22:42:22 -07:00
4eb52460c8
Fix >>
2018-11-03 21:45:39 -04:00
ae9ad1076e
Fix "Warning: extra ";" ignored."
2018-11-03 21:41:50 -04:00
d0163afb7b
Revert "Add operator char * to the naked array types as well"
...
This reverts commit db889c182e
2018-11-03 21:38:30 -04:00
c8f94a1ca6
Minor
2018-11-03 21:08:13 -04:00
1da4de7e7b
fix for subset fuzzer failure
...
A called subr must be freshly parsed or completely parsed. otherwise the prevoius parse must have terminated prematurely
2018-11-03 15:41:29 -07:00
0b0b38ec1e
Fix null accelerator's
...
Fixes all except for cmap. To be done separately.
Part of https://github.com/harfbuzz/harfbuzz/issues/1146
2018-11-03 16:16:31 -04:00
db889c182e
Add operator char * to the naked array types as well
2018-11-03 16:04:19 -04:00
d6fdae310f
Add operator char * to hb_nonnull_ptr_t
2018-11-03 16:02:03 -04:00
7430ff604a
Template casts in hb_nonnull_ptr_t
2018-11-03 15:59:13 -04:00
da408fce98
[blob] Allow null parent in create_sub_blob()
...
Like font and unicode.
2018-11-03 15:49:37 -04:00
fb0f30f55a
Add hb_nonnull_ptr_t
...
Towards fixing https://github.com/harfbuzz/harfbuzz/issues/1146
2018-11-03 15:41:32 -04:00
8d98c51d13
[kern] Third try fix access violation in Format3
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
2018-11-03 15:14:57 -04:00
f074da8c2b
[kern] Really fix access violation in Format3
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
2018-11-03 15:07:39 -04:00
93ef20a83b
Replace most uses of is_inert with is_immutable
2018-11-03 15:03:06 -04:00
0589787ff5
[kern] Fix access violation in Format3
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
2018-11-03 14:59:40 -04:00
5570c87f21
Port objects to use header.writable instead of immutable
...
Saves 4 or 8 bytes per object on 64bit archs.
2018-11-03 14:59:40 -04:00
ee351a38ec
[object] Add "writable"
2018-11-03 14:59:40 -04:00
b8a78ce201
[BASE] Improvements ( #1347 )
2018-11-03 22:28:30 +03:30
34b06d994a
fixed FDSelect size calcluation
2018-11-02 16:40:20 -07:00
481fdfdc23
Merge branch 'cff-subset' of https://github.com/harfbuzz/harfbuzz into cff-subset
2018-11-02 15:28:09 -07:00
1bc710a8c9
added CFF1 desubr api test cases & bug fixes
2018-11-02 15:28:01 -07:00
2c68f34bdd
[os2] Capitalize table tag and struct
...
Other tables follow the case of the OT tag, except this one.
2018-11-02 17:17:54 -04:00
8034d1dda0
[kern] Implement Format1
...
Also, implement backwards kerning for Format1 in kern and kerx.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1350
2018-11-02 14:48:04 -04:00
46b3885c1a
[kern] Set subtable on sanitizer
2018-11-02 14:43:38 -04:00
74c7a2c6c8
[kern] Respect more flags
2018-11-02 14:26:04 -04:00
9f880bad0d
[kern] Minor
...
We like check_struct() more.
2018-11-02 13:57:41 -04:00
04b82b181d
Remove pointer cast operators from ArrayOf<>
...
ArrayOf<>, unlike UnsizedArrayOf<>, has data before the array.
This was confusing. Remove.
2018-11-02 13:47:33 -04:00
f1df441bed
[kern] Comment
2018-11-02 13:26:15 -04:00
095f5add0b
[kern] Push apply loop to each subtable
2018-11-02 13:23:54 -04:00
949dad89a8
[kern] Remove accelerator
...
It wasn't doing anything.
2018-11-02 12:47:55 -04:00
0382b7184a
Use as_array in more places
2018-11-02 12:23:26 -04:00
91de9dfcf3
Fix &array_of<>
2018-11-02 12:16:51 -04:00
9b7cb13794
Fixup
2018-11-02 12:00:55 -04:00
6e06fe162e
[kern] Implement Format3
...
Untested.
2018-11-02 11:56:55 -04:00
c6ef5dbd5c
Add cast operators to hb_array_t
2018-11-02 11:51:21 -04:00
72462eb765
Add UnsizedArrayOf::as_array() instead of hb_array() template
2018-11-02 11:46:42 -04:00
1cf075ecb6
Add get_size to UnsizedArrayOf
2018-11-02 11:38:00 -04:00
a4a7a62389
[kern] Add buffer message
2018-11-02 11:16:43 -04:00
0b2870085d
removed unused code
2018-11-01 22:43:17 -07:00
6186dbf1be
added hb_subset_input_set_desubroutinize API
...
hooked up with CFF1 subroutinizer
a renaming
2018-11-01 17:25:23 -07:00
b1d0c58915
removed extraneous ;s
2018-11-01 16:33:46 -07:00
2840a104c1
tweaks to build with new merge
2018-11-01 16:18:13 -07:00
e600e5440b
Merge branch 'master' into cff-subset
2018-11-01 16:13:56 -07:00
de96e5c81c
[Crap] Avoid operator=
2018-11-01 18:14:41 -04:00
f9353bd68c
[aat] Rely on vector auto initialization
2018-11-01 18:05:22 -04:00
5a18d97b35
[aat] Remove unused forward declaration
2018-11-01 18:01:26 -04:00
82248b9287
fix leak attempt ^2
2018-11-01 10:36:50 -07:00
a9c305c2b0
fix leaks
2018-11-01 10:31:21 -07:00
049ce078e5
fix bogus width with --no-hinting
2018-11-01 08:46:21 -07:00
07ec792212
Warning fix
2018-11-01 10:31:19 -04:00
c32280b30f
[ot-layout] minor
2018-11-01 15:31:14 +03:30
d56e338a90
CFF1 no-desubroutinize + no-hinting
...
no-desubroutinize option is disabled for now
code cleanup (esp. CFF1 width handling)
bug fixes & renaming
2018-10-31 22:30:34 -07:00
52a00cd87f
[aat] Implement 'aalt' mapping
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1160
2018-10-31 19:06:08 -07:00
6e3ea269fa
[aat] Add 'afrc' feature mapping
...
https://github.com/harfbuzz/harfbuzz/issues/1342#issuecomment-434829028
2018-10-31 19:00:11 -07:00
40b19fd469
[aat] Fallback to old style "Letter Case" small caps
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1342
2018-10-31 18:51:45 -07:00
cf203af8a3
Implement space fallback in vertical direction
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1343
2018-10-31 18:27:09 -07:00
e01250230b
[hmtx/vmtx] Fix a crasher
2018-10-31 18:14:00 -07:00
36e90ef56e
[mort] Massage some more
2018-10-31 15:09:09 -07:00
cbaff4ef19
[mort] Some more
2018-10-31 15:06:12 -07:00
3087046d31
[mort] Refactor offset-to-index mapping
2018-10-31 14:59:14 -07:00
b9db610add
Minor
2018-10-31 14:22:31 -07:00
995bf6c6f8
[sbix] Rely on blob->as<> checking size against Type::min_size
2018-10-31 13:21:33 -07:00
4d4e526b5c
Improve blob->as<>
...
It's true that blob->as<> should only be called on null or sanitized
data. But this change is safe, so keep it.
2018-10-31 13:19:42 -07:00
5854d3fa25
[set] Warning fix with gcc 8.1
...
https://github.com/harfbuzz/harfbuzz/pull/1334
2018-10-31 10:42:49 -07:00
850a7af3a4
[ot-color-test] Remove the non-working exact strike size storing ( #1339 )
2018-10-31 14:20:23 +03:30
2e639c47c9
[aat] Fix older compilers by not referencing enum directly ( #1340 )
2018-10-31 14:20:14 +03:30
642c9dcf1b
[aat] Minor, remove extra semicolons
2018-10-31 14:02:37 +03:30
c962d5e714
[mort] Make ligatures work
...
./hb-shape Apple_Chancery_10_12.ttf "Th th ll te to tr fr fu fj"
[T_h=0+2308|space=2+569|t_h=3+1687|space=5+569|l_l=6+1108|space=8+569|t_e=9+1408|space=11+569|t_o=12+1531|space=14+569|t_r=15+1385|space=17+569|f_r=18+1432|space=20+569|f_u=21+1733|space=23+569|f_j=24+1098]
Part of https://github.com/harfbuzz/harfbuzz/issues/1331
2018-10-31 01:18:21 -07:00
c077989600
[mort] More Ligature work
2018-10-31 00:36:03 -07:00
431c6e496b
[mort] Some Ligature work
2018-10-31 00:15:00 -07:00
28b68cffe4
[mort] Implement / adjust Contextual substitution
2018-10-30 23:54:29 -07:00
11dbf0f129
[mort] More fixes]
2018-10-30 21:49:59 -07:00
e1552af95b
[maxp] Minor
2018-10-30 21:09:05 -07:00
0cf282a32e
[mort] Grind some more
2018-10-30 20:52:12 -07:00
90667b31bc
[mort] Hook up more
2018-10-30 20:15:28 -07:00
9346b1f158
[morx] Remove stale comment
2018-10-30 20:04:13 -07:00
f864ef215e
[mort] More massaging towards mort
2018-10-30 19:42:21 -07:00
2d9467340b
[mort] Fix version check in sanitize
2018-10-30 19:33:42 -07:00
c2527a1bc2
[mort] Make it compile / hook it up
...
Untested.
2018-10-30 19:26:39 -07:00
933babdc07
[mort] Fixup on previous commit
2018-10-30 19:22:43 -07:00
b053cabacd
[mort] Bring back mort generalizations
...
Started by reverting https://github.com/harfbuzz/harfbuzz/commit/1f1c85a5
Just a starting point, if we agree even mort can come back.
2018-10-30 19:18:06 -07:00
5cd544a621
Fix build
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1338
2018-10-30 19:16:00 -07:00
1019391046
2.1.0
2018-10-30 15:52:26 -07:00
bfd549daaa
Fix everything-bot
2018-10-30 14:47:27 -07:00
0e1ad5a075
[subset] Limit the number of scripts and langsys' that should be checked when collecting features.
2018-10-30 14:15:58 -07:00
a7aba99baa
[name] Rename hb_name_id_t to hb_ot_name_id_t
...
https://github.com/harfbuzz/harfbuzz/pull/1254
2018-10-30 14:04:09 -07:00
881e1054bc
fix various GCC function pointer warnings
2018-10-30 13:17:54 -07:00
dc9bd29fea
[CBDT] Implement Format18 get_extens
...
Part of https://github.com/harfbuzz/harfbuzz/issues/1327
2018-10-30 13:16:07 -07:00
a2a7422aaf
[CBDT] Bound checks in reference_png
2018-10-30 13:14:56 -07:00
0af3d176a6
[sbix] Fix memory leak in early return
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11210
2018-10-30 17:05:28 +02:00
138f9e0f25
Minor
2018-10-30 01:31:13 -07:00
f7a08cd41d
Fix extra semicolon issues and test that on CI ( #1330 )
2018-10-30 11:29:09 +03:30
7e998d193a
Fix spurious warning re uninitialized use
2018-10-30 00:52:22 -07:00
b186274362
[set/map] Fix uninitialized memory
...
I keep forgetting that primitive types are NOT initialized during construction. :|
2018-10-29 23:21:14 -07:00
4ef671f25f
[unicode] Fix a long-standing double-declaration warning
2018-10-29 22:46:19 -07:00
166ae8b0aa
Remove now unused hb_auto_t<>
2018-10-29 22:40:37 -07:00
56e0fd345c
Remove last use of hb_auto_t<>
2018-10-29 22:35:44 -07:00
ca5e5a4979
Port Coverage::Iter off hb_auto_t<>
2018-10-29 22:30:21 -07:00
3a4e5dd425
Remove a few unnecessary hb_auto_t<>'s
...
See a85641446c30247c4e948263f0f8c1147ed4efb9
2018-10-29 22:27:20 -07:00
67a22f377d
[set/map/vector] Make constructable, but not copy or assignable
...
Disable copy/assign on them, as they shouldn't.
Make constructor / destructor call init_shallow/fini_shallow,
and make those idempotent. So, these three can be constructed
on stack now and no init/fini call is needed. As such,
hb_auto_t<> is not needed anymore. I'll remove that separately.
2018-10-29 22:23:22 -07:00
ea0e51d1b1
Add HB_NO_CREATE_COPY_ASSIGN
2018-10-29 16:00:23 -07:00
5b563640b2
Remove HB_DISALLOW_COPY_AND_ASSIGN from hb_ot_shape_planner_t
...
It was arbitrary that this struct had it and not dozens of others.
2018-10-29 15:58:44 -07:00
14b353c185
One more iteration
2018-10-29 15:29:13 -07:00
c7c5df9ffd
Try fixing older bots
...
Older C++ doesn't allow struct-with-constructor in union.
2018-10-29 15:16:52 -07:00
be87959a67
[cmap] Minor
2018-10-29 15:16:38 -07:00
35d410f2ba
Remove ASSERT_POD
...
Newer compilers / language allows structs with constructor in union.
So, this was not actually testing anything. Indeed, the recent
change in DISALLOW_COPY *is* making some of our types non-POD.
That broke some bots.
Just remove this since it wasn't doing much, and I'd rather have
DISALLOW_COPY.
2018-10-29 14:45:44 -07:00
6f0454e176
Fix extra-semicolon warnings
2018-10-29 13:51:15 -07:00
a256a92b3f
Make Array types uncopyable-unassignable
...
Finally! Catches hard-to-find errors like this:
- const SortedArrayOf<SVGDocumentIndexEntry> docs = this+svgDocEntries;
+ const SortedArrayOf<SVGDocumentIndexEntry> &docs = this+svgDocEntries;
We implement this for our array types. This, in turn, trickles down
into all types that embed the arrays. So, as long as we define all
open-ended structs in terms of Array types (all can be done using
UnsizedArrayOf), this achieves the goal of making uncopyable all
structs that are variable-sized. Yay!
2018-10-29 11:40:21 -07:00
31cc1f74b7
[svg] Minor
2018-10-29 11:14:37 -07:00
1366bb9760
Fix g-i warnings
2018-10-29 11:01:25 -07:00
ae802c2c6e
[test-ot-color] Minor
2018-10-29 13:42:14 +03:30
7170e35096
Rename deprecated symbols list file name and clean it up ( #1328 )
2018-10-29 13:11:01 +03:30
9c692e5b8d
[test-ot-color] Use public APIs on the tool
2018-10-29 12:22:39 +03:30
fb525f8943
Rename dump-emoji to test-ot-color
2018-10-29 11:40:06 +03:30
81bcf47e9e
Revive dump-emoji
2018-10-29 11:40:06 +03:30
f10252b4b6
[svg] Fix incorrect array referencing
2018-10-29 10:29:58 +03:30
5eb251aab0
[cbdt] Implement strike selection logic
2018-10-28 23:16:13 -07:00
98bddbc8ef
[sbix] Minor
2018-10-28 23:14:15 -07:00
8cffee0577
[cbdt] Simplify more
2018-10-28 23:07:59 -07:00
574579d376
[color] Rename get_strike() to choose_strike()
2018-10-28 23:04:37 -07:00
e2ba96da4c
[cbdt] Refactor get_strike()
2018-10-28 23:01:57 -07:00
6983cca9c8
[cbdt] Minor
2018-10-28 22:46:18 -07:00
e998fb9fbf
[color] Round extents when scaling
2018-10-28 22:45:53 -07:00
c929ccfcea
[ot-color/png] Consider strike ppem on scaling
2018-10-28 22:40:40 -07:00
a8c9facf7a
[svg] Cosmetic
2018-10-28 18:33:10 -07:00
9c1460e568
[svg] Use SortedArrayOf.bsearch
2018-10-28 18:33:10 -07:00
18dd6363a5
[svg] Minor
2018-10-28 18:33:10 -07:00
4876c938a2
[sbix] Comment
2018-10-28 18:33:10 -07:00
519fca1014
[color] Minor
2018-10-28 18:33:10 -07:00
e8ff27c208
Minor
2018-10-28 18:33:10 -07:00
6562172381
[sbix] Use LOffsetLArrayOf<>
2018-10-28 18:33:10 -07:00
a3ddd8067f
[sbix] Add get_strike
2018-10-28 18:33:10 -07:00
95524ed9bc
[sbix] Remove sbix_len
2018-10-28 18:33:10 -07:00
69e9846452
[sbix] Fix get_glyph_blob() on Null object
2018-10-28 18:33:10 -07:00
4e0ee2af09
[sbix] Simplify ppem access
...
If struct members are simple and needed publicly, we make them public.
2018-10-28 18:33:10 -07:00
6ac9a4eaa3
[sbix] Simplify glyph_length calc
2018-10-28 18:33:10 -07:00
0730d62385
[sbix] Check glyph data end is in range
2018-10-28 18:33:10 -07:00
b76dc03108
[sbix] Reduce code
2018-10-28 18:33:10 -07:00
50fb02a219
[sbix] Check glyph id before looking into unsafe array
...
That 'Z' at end of imageOffsetsZ is a reminder that you should check...
2018-10-28 18:33:10 -07:00
a8cb9c73da
[sbix] Simplify 'dupe' handling logic
2018-10-28 18:33:10 -07:00
d7eb534e59
[sbix] Check offsets before proceeding
2018-10-28 18:33:10 -07:00
c8380bd3e4
[color] Remove more dump-emoji cruft
2018-10-28 18:33:10 -07:00
68f2c832c8
Remove dump-emoji
2018-10-28 18:33:10 -07:00
b46de42b3a
[sbix] Fix order of parameters
2018-10-28 18:33:10 -07:00
a91cda72ab
[sbix] Remove redundant parameter
2018-10-28 18:33:10 -07:00
c712005f55
[sbix] Add get_strike()
2018-10-28 18:33:10 -07:00
400bc3f030
[sbix] Remove a couple of extra checks
2018-10-28 18:33:10 -07:00
3770282c83
[sbix] Rename sbix_table to table in accelerator
2018-10-28 18:33:10 -07:00
7346841807
[cbdt] Rename reference_blob_for_glyph() to reference_png()
2018-10-28 18:33:10 -07:00
1f33b8525d
[sbix] Rename ugly reference_blob_for_glyph() to reference_png()
2018-10-28 18:33:10 -07:00
946b534419
[sbix] Fix uninitialized variables
2018-10-28 18:33:10 -07:00
01c7d53fb7
[sbix] Select best strike based on ppem
2018-10-28 18:33:10 -07:00
f9f26bff4c
[sbix] Move code around. Add get_extents()
2018-10-28 18:33:10 -07:00
48bc3039cb
[sbix] Check blob length against PNG header leangth
2018-10-28 18:33:10 -07:00
d3ec31a57c
[ot-color] More on PNGHeader fields
2018-10-28 18:33:10 -07:00
35fa3d3260
[ot-color] Apply Behdad comment
2018-10-28 18:33:10 -07:00
307d61867a
[ot-color] Make PNGHeader reading actually work
2018-10-28 18:33:10 -07:00
632e9af862
[ot-color] Implement PNGHeader and test it, it doesn't work however
2018-10-28 18:33:10 -07:00
38706a0746
[ot-color] Preparation for setting PNG width/height in extents
2018-10-28 18:33:10 -07:00
d6d6f3bc22
[docs] Add comment
2018-10-28 18:33:10 -07:00
3d4c1f6a41
[ot-color] Apply Behdad reviews
2018-10-28 18:33:10 -07:00
8ef0d2ef92
[ot-color] Apply Behdad comment
2018-10-28 18:33:10 -07:00
dbd419bede
[ot-color] Add public API for CBDT/sbix/SVG color Emojis
2018-10-28 18:33:10 -07:00
6ce49a921a
[name] Change hb_name_id_t back to unsigned int
...
d941f66c75 (commitcomment-31076011)
2018-10-28 08:26:30 -07:00
a4f4f5ba5f
[docs] Fix titles here as well
2018-10-28 08:23:36 -07:00
213b6dd335
[name] Make sure hb_name_id_t is int-sized
...
d941f66c75 (commitcomment-31068905)
2018-10-27 18:36:24 -07:00
1d40d72f29
[docs] Hook up hb-var
2018-10-27 05:01:01 -07:00
80d9a427cf
[docs] Document remaining sections
2018-10-27 04:58:32 -07:00
cf5fa57f00
[docs] Change section titles again
...
I think I like the uniform "hb-*" more.
2018-10-27 04:51:42 -07:00
04981ee05d
[docs] More
2018-10-27 04:47:41 -07:00
5dd86aa33b
[docs] Rename section titles to object names
...
More useful.
2018-10-27 04:47:41 -07:00
524fb70216
[docs] More
2018-10-27 04:47:41 -07:00
46072b7cb5
[ot] Fold hb-ot-tag.h into hb-ot-layout.h
2018-10-27 04:47:41 -07:00
00cf4e5eb6
[docs] Fill in some sections
2018-10-27 04:47:41 -07:00
55a19d73b4
Move HB_EXTERN
2018-10-27 04:47:41 -07:00
524e854c15
Merge pull request #1318 from ebraminio/png
...
Add a non-hooked _png _svg get emoji blob
2018-10-27 15:04:43 +03:30
8180c37df0
[ot-color] Remove _png and _svg public APIs
2018-10-27 14:54:08 +03:30
9aa6279a2d
[ot-color/png] Try to get image blob from sbix first options.aat is set
2018-10-27 14:24:58 +03:30
b42661ee91
[ot-color] Add some documentation
2018-10-27 14:15:38 +03:30
4ee3c8272c
[docs] Fix hb_name_id_t
...
Yep, was not recognized without this patch!
2018-10-27 03:18:45 -07:00
9435fb24da
[ot-color/png] Implement CBDT part
2018-10-27 13:47:11 +03:30
d941f66c75
[name] Make hb_name_id_t be the enum
...
This is like hb_script_t.
We had this exposed as unsigned int since 2.0.0 release in two APIs,
as well as hb_ot_layout_get_size_params() from earlier.
But since no one uses those (right?!), let's just fix this now.
2018-10-27 03:06:14 -07:00
40496a54a0
[name] Move HB_NAME_ID_INVALID into the enum
...
Don't know how to document anonymous enum members.
2018-10-27 03:06:14 -07:00
a8a55b9f89
[name] Move around
2018-10-27 03:06:14 -07:00
3b7e5f1313
[name] Rename hb_ot_name_get_names() to hb_ot_name_list_names()
...
And swap return value positions, so can be annotated for gobject-introspectin.
2018-10-27 03:06:14 -07:00
4025ad8043
Document new API
2018-10-27 03:06:14 -07:00
5e2a52f71a
[sbix] Remove dump method from sbix accelerator
2018-10-27 12:44:33 +03:30
0353ac6cde
Fix test-name-table on older bots
2018-10-27 12:24:53 +03:30
dc11a38107
[sbix] Set num_glyphs on accelerator
...
dump-emoji was broken without it
2018-10-27 12:15:25 +03:30
6a38fd68a8
[ot-color/png] sbix runtime memory check
2018-10-27 11:17:27 +03:30
ca645accb9
Comment
2018-10-27 00:39:31 -07:00
265ad408ca
[ot-color/png] Implement sbix part
2018-10-27 10:43:46 +03:30
7f5941e162
Remove stale comment
...
Ugliness was fixed in 30eab97a00
2018-10-27 00:06:48 -07:00
e7400c0275
[docs] Hook up new symbols
2018-10-26 22:24:40 -07:00
6aa019c4af
[morx] Fix merge_cluster to end at last ligature component
...
Don't assume current position was a component in the ligature.
2018-10-26 22:02:17 -07:00
00ae4be6bf
[morx] Fix bailing out ligation at end-of-text
...
Check was after a move_to, which wouldn't work.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11147
2018-10-26 21:59:20 -07:00
30eab97a00
Fix invalid memory read
...
Buffer might be relocated inside replace_glyphs().
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=895117
2018-10-26 21:54:40 -07:00
79b2fa62ca
[indic] Fix infinite loop
...
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=863044
2018-10-26 21:22:26 -07:00
39bd07aed5
Fix bunch of unused parameter warnings
...
Show up with gcc -O0.
There's a few more but those are functions that need to be filled in.
Maybe this is a lost battle...
2018-10-26 21:22:26 -07:00
b2e1ec374c
[subset] Fix warning
2018-10-26 21:22:26 -07:00
337ea0b717
[fuzzing] Remove HB_NDEBUG
...
Not sure why it ever was added.
2018-10-26 21:22:26 -07:00
c965eeadbc
[name] Default to "en" if language is not specified
2018-10-26 21:22:26 -07:00
3fd6e5dbef
[name] Add pre-defined nameIDs
2018-10-26 21:22:26 -07:00
20d0171d20
[name] Fill out most missing language codes
2018-10-26 21:22:26 -07:00
622b014faf
[name] Skip enumerating names with unknown language
2018-10-26 21:22:26 -07:00
2c39f359e4
[utf] Remove unused typedef
2018-10-26 21:22:26 -07:00
ce81c74298
[utf] Fix ASCII
2018-10-26 21:22:26 -07:00
327546e633
[name] Hook up ltag table
2018-10-26 21:22:26 -07:00
dc9a5f88b4
[name] Do record sanitization at run-time
2018-10-26 21:22:26 -07:00
a53d301b1c
[name] Minor
2018-10-26 21:22:26 -07:00
c442fd9a10
[name] Add src/test-name-table tool to show all font names
2018-10-26 21:22:26 -07:00
7007bd9dff
[name] Rebuild language list, include missing entries
2018-10-26 21:22:26 -07:00
68f172101c
[name] Fix cmp for invalid language
2018-10-26 21:22:26 -07:00
888a65615c
[name] Fix nul-termination bug
2018-10-26 21:22:26 -07:00
9b532e2ed4
[name] Add language mapping
2018-10-26 21:22:26 -07:00
e2f9b65775
[name] Start adding language support
2018-10-26 21:22:26 -07:00
6db6bbe64b
[name] Remove unused cmp function
2018-10-26 21:22:26 -07:00
4668a05006
[name] Hook things up
...
Accept Mac Latin name entries as ASCII as well.
2018-10-26 21:22:26 -07:00
69f5da0629
[name] More
...
It assumes all names are encoded in UTF16-BE. Other than that, and not
listing languages correctly, it's *supposed* to work.
2018-10-26 21:22:26 -07:00
64334aff8c
[name] Fix check
2018-10-26 21:22:26 -07:00
5531bd068e
[name] Flesh out UTF-X to UTF-X conversion routines
2018-10-26 21:22:26 -07:00
84811a06a2
[name] Fix for rebase changes to hb_array_t
2018-10-26 21:22:26 -07:00
1046b1938b
[name] Some more
2018-10-26 21:22:26 -07:00
b4d4d1ea78
[name] Return full string length from API
2018-10-26 21:22:26 -07:00
8d304ef7f9
[utf] Add UTF16-BE and UTF32-BE
2018-10-26 21:22:26 -07:00
a826a8730f
[name] Hide internal details from public API
2018-10-26 21:22:26 -07:00
e7c595a9f0
[name] More
2018-10-26 21:22:26 -07:00
75cd8c86bd
[name] Add hb_ot_name_get_utf()
2018-10-26 21:22:26 -07:00
c783d36324
[name] Pre-allocate array
2018-10-26 21:22:26 -07:00
c2aa409537
[name] Start implementing hb_ot_name_get_utf16()
2018-10-26 21:22:26 -07:00
740cde8991
[name] Implement hb_bytes_t get_name()
2018-10-26 21:22:26 -07:00
c3425f2401
[name] Add hb-ot-name.cc for realz
2018-10-26 21:22:26 -07:00
90420ed8cb
[name] Implement hb_ot_name_get_names()
2018-10-26 21:22:26 -07:00
9a6c87c17d
[name] Finish accelerator sorting
2018-10-26 21:22:26 -07:00
2157e56b34
[name] Start implementing public API infrastructure
2018-10-26 21:22:26 -07:00
0bf93ec0fb
[name] Add public API declarations
2018-10-26 21:22:26 -07:00
982c2f4a65
[indic/khmer/myanmar/use] Clarify clear_syllable
...
No logic change.
2018-10-26 15:40:45 -07:00
30f18039b3
[svg] Rename _svg_create_blob to _glyph_reference_blob_svg
2018-10-26 09:34:34 +03:30
5cb1ce8681
[svg] Collapse SVGDocumentIndex into SVG
2018-10-26 09:31:01 +03:30
4ceabb8c21
[svg] Hide start_glyph and end_glyph from API
2018-10-26 09:16:44 +03:30
c7a4e3dfb5
[svg] Add public API
...
* hb_ot_color_has_svg
* hb_ot_color_glyph_svg_create_blob
2018-10-26 09:16:44 +03:30
e98af6d1ed
[layout] Try to speed up collect_lookups some more
...
Barely made a dent :(.
2018-10-25 22:25:29 -07:00
eb44bfc864
[layout] Memoize collect_features
...
Fixes https://github.com/harfbuzz/harfbuzz/pull/1317
Fixes https://oss-fuzz.com/v2/testcase-detail/6543700493598720
2018-10-25 22:15:11 -07:00
84098b1639
[layout] Remove unintentionally added code
2018-10-25 21:33:12 -07:00
941600a9e0
[layout] Add hb_collect_features_context_t
...
Towards https://github.com/harfbuzz/harfbuzz/pull/1317
2018-10-25 21:26:56 -07:00
c237cdfcc7
[lookup] Fold another function inline
2018-10-25 21:17:30 -07:00
fe5520ddea
[layout] More prep work to memoize collect_features() work
2018-10-25 21:14:32 -07:00
e8e67503ff
[lookup] More prep work for memoizing collect_features
...
https://github.com/harfbuzz/harfbuzz/pull/1317
2018-10-25 20:48:20 -07:00
96828b97a8
[layout] Minor
...
We were returning the accelerator's lookup count. Returns table's.
They are the same except for OOM cases. Just shorter code.
2018-10-25 20:34:29 -07:00
73449cd213
[layout] Fold one function inline
...
Preparation for fixing https://github.com/harfbuzz/harfbuzz/pull/1317
2018-10-25 20:32:05 -07:00
ba5ca6a762
[morx] Use deleted-glyph, instead of actual deletion, in Ligation
...
Closer to what CoreText does.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1302
2018-10-25 17:46:07 -07:00
5c272e3613
[morx] Remove deleted-glyph at the end of processing
2018-10-25 17:39:54 -07:00
1bb8ed86d6
[aat] Minor
2018-10-25 17:33:48 -07:00
102af615f1
[aat] Start adding support for DELETED-GLYPH
...
https://github.com/harfbuzz/harfbuzz/issues/1302
2018-10-25 17:29:32 -07:00
955aa56b11
[vector] Make it act more like pointer
...
Add pointer cast operator and plus operator.
2018-10-25 16:50:38 -07:00
8d55e2adef
[set] Minor
2018-10-25 16:37:53 -07:00
64c32edfe1
[set] Make array access more explicit
...
Follow up on 94e421abbf
2018-10-25 16:35:36 -07:00
be746009e9
dropped support of legacy CFF CharString ops
...
along with test & font
2018-10-25 13:40:40 -07:00
21ede867df
Fix possible overflow in bsearch impls
...
From bungeman.
Fixes https://github.com/harfbuzz/harfbuzz/pull/1314
2018-10-25 13:19:58 -07:00
2ebf360102
Merge branch 'master' into cff-subset
2018-10-25 13:05:06 -07:00
94e421abbf
Remove some use of Crap in hb-set.
...
When hb_set_t::page_for_insert needs to insert at the end of the page_map
it ends up evaluating '&page_map[i + 1]' which has hb_vector return an
lvalue of a Crap so that nothing can be moved to its address. This turns
into issues with ThreadSanitizer on Crap when two threads modify different
hb_set_t instances. This can be avoided by using '&page_map[i] + 1'
instead.
2018-10-25 11:42:20 -07:00
ae9e8f292b
[vowel-constraints] Reset continuation on all dottedcircles
...
One of the was missed before. Not intentional.
2018-10-24 16:55:20 -07:00
401cdf0792
[ot-font] Fix sign of ascent/descent
...
Some fonts, like msmincho, have positive number as descent
in vhea table. That's wrong. Just enforce sign on ascent/descent
when reading both horizontal and vertical metrics.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1248
2018-10-23 17:00:49 -07:00
ba502dea1e
[morx] Fix cluster-merging when ligating
...
Only merge when actual ligature happened.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1305
2018-10-23 16:50:31 -07:00
aa5af8d041
Fix size calculation in DEFINE_SIZE_ARRAY_SIZED.
2018-10-23 16:04:21 -07:00
36c2c374bf
removed unused multi_val from DictVal
2018-10-23 15:11:09 -07:00
f33ad6d692
[aat] Fix up previous commit and add files
2018-10-23 14:31:51 -07:00
ffe3478448
[aat] Allow enabling/disabling features
...
Only works at entire-buffer range, not sub-ranges.
Test with:
$ hb-shape Zapfino.dfont Zapfino
[Z_a_p_f_i_n_o=0+2333]
$ hb-shape Zapfino.dfont Zapfino --features=-dlig
[Z=0+416|a=1@-21,0+264|p_f=2+433|i=4+181|n=5+261|o=6+250]
$ hb-shape Zapfino.dfont Zapfino --features=+dlig
[Z_a_p_f_i_n_o=0+2333]
Fixes https://github.com/harfbuzz/harfbuzz/issues/1303
2018-10-23 14:14:03 -07:00
8be0e5fd45
[ot-map] Minor
2018-10-23 13:39:50 -07:00
e8fccbc36b
Minor
2018-10-23 13:25:03 -07:00
76324d95ca
Shift code around
2018-10-23 13:09:30 -07:00
e1241636d6
Merge branch 'master' into cff-subset
2018-10-23 11:25:51 -07:00
cf92d6579e
[trak] Allow disabling tracking for ranges of text
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1303
2018-10-23 03:10:56 -07:00
8869436cb8
When parsing feature ranges, accept ';' instead of ':'
2018-10-23 03:07:48 -07:00
22ecefd88e
Make tracking optout possible using 'trak' ot feature
...
So '--features=-trak' or 'font-feature-settings: 'trak' 0;' can prevent
applying of tracking if used.
2018-10-23 02:57:55 -07:00
6d40eb8372
Touch up on previous commit
...
https://github.com/harfbuzz/harfbuzz/pull/1273
2018-10-23 02:51:42 -07:00
205737acdc
[use] Prohibit visually ambiguous vowel sequences
2018-10-23 02:25:08 -07:00
48ed598a35
[VORG] Hook up to hb-ot-font's v_origin
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/544
Test added with NotoSansCJK, eg. with U+FF38.
2018-10-23 02:21:27 -07:00
097ecfd4a9
[VORG] Add get_y_origin()
...
Unhooked.
2018-10-23 02:09:42 -07:00
6fb24d5e3e
[VORG] Add VORG table
...
Cherry-picked from cff-subset branch.
2018-10-23 01:59:43 -07:00
531f9822b2
[morx] Add a few debug messages to Ligature chain
2018-10-23 01:32:08 -07:00
0e5bcdef7f
[morx] Clear stack upon underflow when acting ligatures
2018-10-23 00:39:44 -07:00
792071de40
[morx] Leave ligature on stack after ligating
...
Test with Apple Color Emoji.ttf of ~66MB and following sequence:
./hb-shape Apple\ Color\ Emoji-old.ttf --font-funcs=ot -u U+1F468,200d,U+1F469,200d,U+1F467,200d,1f466
Should form full family if matching works correctly. It first makes
family of three, then makes family of four out of that and the last
two characters.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1292
2018-10-22 23:38:34 -07:00
8c78ced95b
Unbreak builds
2018-10-22 21:49:42 -07:00
8d689f8a7b
Add hb_array<>() specialization for UnsizedArrayOf
...
Related https://github.com/harfbuzz/harfbuzz/issues/1301
2018-10-22 21:33:18 -07:00
abfbba1911
Add hb_array<>()
...
Simplifies transient object creation.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1301
2018-10-22 21:27:45 -07:00
17ffbc070f
[color] Use Index for colorIdx
...
Doesn't matter, but matches the description.
2018-10-22 21:22:25 -07:00
07386ea410
Remove const and references when binding Null()
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1299
Removes anomaly I was seeing in cpal table trying to use implicit Null(NameID).
2018-10-22 21:21:17 -07:00
b18acab7bc
[color] Add HB_COLOR
...
Normally I would have added to_string / from_string like other types
have. But since we don't use hb_color_t much, I'm not going to do that.
Although, if we did, we could use it in hb-view to parse colors...
2018-10-22 18:20:57 -07:00
228f96c9d0
[color] Finish reviewing / revamping CPAL
...
Now to hb_color_t.
2018-10-22 16:55:12 -07:00
960267fc43
fix build attempt ^4
2018-10-22 16:37:39 -07:00
683fad0627
[color] Minor
2018-10-22 16:35:03 -07:00
14474d2104
[color] Rely on CPALV1Tail Null object
2018-10-22 16:31:13 -07:00
d7865107ea
Remove const from hb_array_t details
...
Will come in through <T> if desired.
2018-10-22 16:24:16 -07:00
f3336580dd
[color] Use hb_array_t in CPAL
...
Doesn't work though, ouch :(. Need to figure out if it's unreasonable
to expect Null(T) inside hb_array_t<T> to see the later specialization
of Null for NameID.
2018-10-22 16:24:16 -07:00
5ae18855d1
[color] Check for null CPAL arrays
...
We cannot use a nullable offset here though.
2018-10-22 16:24:16 -07:00
69ab72e4aa
[color] More CPAL rename
2018-10-22 16:24:16 -07:00
0befb06c46
[color] More CPAL rename
2018-10-22 16:24:16 -07:00
3600d20603
[color] Rename vars in CPAL
2018-10-22 16:24:16 -07:00
b11032afae
fix build attempt ^2
2018-10-22 15:52:37 -07:00
3d3df5575c
fix build attempt
2018-10-22 15:23:39 -07:00
0babf761c9
Adopt dump-emoji with latest unreleased APIs changes ( #1297 )
2018-10-23 01:33:45 +03:30
7997144b5f
[color] Revamp palette API
2018-10-22 14:22:31 -07:00
3bf91bd269
[color] Rewrite colr access
...
COLR table has one function: return layers for a glyph, and we expose exactly
that, so should just wire it through. Also use sub_array() for verifiable
safety.
Also, BaseGlyphRecord's null object is enough. We don't need to special-case
the not-found.
2018-10-22 14:21:23 -07:00
1de17bdb80
[colr] Add hb_ot_color_layer_t
...
We never return parallel arrays from functions. That's inconvenient
and hard to bind.
2018-10-22 14:21:23 -07:00
3b3668acc8
[color] Rename / reorder a bit
...
Implement has_data() for realz.
2018-10-22 14:21:23 -07:00
570b77f7d2
Merge branch 'master' into cff-subset
2018-10-22 13:06:47 -07:00
9085a72deb
[cpal] Touch up palette flags
2018-10-22 13:03:29 -07:00
ee11fae9d0
[color] Rename "gid" to "glyph"
...
We don't expose "gid" in API.
2018-10-22 13:03:29 -07:00
228fa71bf9
[colr] Move sanitize
2018-10-22 13:03:29 -07:00
d440c8d3fb
Add chromacheck Emoji test fonts and minor preparations ( #1294 )
2018-10-22 22:07:59 +03:30
857c58279e
Merge branch 'master' into cff-subset
2018-10-22 09:57:20 -07:00
b92b9d7e52
[colr] Move compare function into a static
...
Not sure if MSVC would be unhappy about this.
2018-10-22 10:17:31 +02:00
b6b171732a
[colr] Minor
2018-10-22 10:17:31 +02:00
a6ade3471e
[colr] Move sanitize() to right place
...
Sanitize always comes just before data member definitions, so
it's easy to cross-check.
2018-10-22 10:17:31 +02:00
24adc15757
[colr] Touch up a bit
...
When a struct is plain old data with no references, etc, it's okay
to mark its members public.
2018-10-22 10:17:31 +02:00
cc6e77ca98
[color] Fix documentation a bit
2018-10-22 10:17:31 +02:00
37ba2413c1
Minor
2018-10-22 10:17:31 +02:00
44f79b4bf8
Remove _palette_entry_count as can be done with _palette_colors
2018-10-22 10:17:31 +02:00
6795dcfc08
[test] Test hb_ot_color_has_{colr,cpal}_data
2018-10-22 10:17:31 +02:00
b8ee3a0ec8
[CPAL] Add palette entry and enable palette flag API
2018-10-22 10:17:31 +02:00
d4261b4bb6
Add API test for hb_ot_color_get_color_layers
2018-10-22 10:17:31 +02:00
456978d408
Address COLR/CPAL reviews and revive cpal_v1 tests
2018-10-22 10:17:31 +02:00
687f679b80
[color] Fix alpha channel value and adjust spaces
2018-10-22 10:17:31 +02:00
00e94ce24e
[dump-emoji] Formatting
2018-10-22 10:17:31 +02:00
e8a6f5b803
Add three macros for separating color channels
2018-10-22 10:17:31 +02:00
d4e928b142
[color] Minimal API for COLR/CPAL
2018-10-22 10:17:31 +02:00
1e39833ba8
[docs] Minor
2018-10-20 16:57:36 -07:00
a5ad8c658d
[docs] More fixes
2018-10-20 16:52:55 -07:00
314b1af74f
[docs] Fix warning
...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1260
2018-10-20 16:49:16 -07:00
b713c13977
[kerx] Implement tuple-kerning in Format0
2018-10-20 14:56:28 -07:00
0a3b7a0fb0
2.0.2
2018-10-20 13:14:07 -07:00
68b7050768
[kerx] Fix sanitize of KerxSubtableFormat2::array read
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11033
2018-10-20 12:20:57 -07:00
00fdbca4f6
[aat] Fix LookupFormat10 sanitize
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11060
2018-10-20 12:20:57 -07:00
1e55e21dea
Merge pull request #1283 from khaledhosny/cygwin
...
Cygwin fixes and CI build
2018-10-20 07:45:46 +03:30
7c2c8ac301
2.0.1
2018-10-19 19:39:58 -07:00
5a24ea15e0
Make more 'coords' params const.
2018-10-19 19:15:42 -07:00
08b7172969
[font] Fix parallel funcs passing to eachover in infinite-loop
...
Fixes test just added.
2018-10-19 19:12:33 -07:00
29d877518f
[kerx] Implement variation-kerning tables (without the variation part)
...
SFSNDisplay uses these. We just apply the default kern without
variations right now. But at least makes the default kern work.
2018-10-19 16:06:54 -07:00
f7c0b4319c
[aat] Implement LookupFormat10
2018-10-19 15:23:49 -07:00
30cbe6158d
Use O_BINARY instead of _O_BINARY
...
Cygwin does not seem to have the later
2018-10-19 22:46:40 +02:00
79b6356155
[trak] Fix extrapolation at end side
2018-10-19 11:00:20 -07:00
2352cc3539
[kerx] Whitespace
2018-10-19 10:17:02 -07:00
114f66dda6
Fix hb_map_is_empty logic
...
This needs reviewing
2018-10-19 20:23:36 +03:30
9df2fb1611
Add API tests for hb_map_t
2018-10-19 20:23:36 +03:30
c6eb5e852c
Don't report deprecated symbols as unused symbols
2018-10-19 20:23:36 +03:30
4594730f64
Remove redundant return at end of void-returning function.
2018-10-19 18:17:18 +02:00
8d1e479d1d
Use bool literals instead of 0/1.
2018-10-19 18:05:46 +02:00
257d0e5aa3
Fix typos.
2018-10-19 19:24:05 +03:30
51fba41cc9
Merge branch 'master' into cff-subset
2018-10-18 13:08:42 -07:00
8679d02b4b
implement flex ops for glyph extents/subset
...
also removed unused CSInterpEnv::move_[xy]_with_arg
fixed bug a width being left over on argStack with CFF1
2018-10-18 13:04:21 -07:00
3d9a0306eb
2.0.0
2018-10-18 05:58:17 -07:00
03e144135b
[ubsan] Use unsigned int instead enum where needed ( #1270 )
...
Actually the check is right,
On -myanmar.hh, on that particular switch, OT_C is indic_category_t
but OT_D is myanmar_category_t so we are mixing the types in one variable.
And on -arabic.cc, step can goes one number higher than step_t enum in the
loop so we are actually using it as an unsinged int.
2018-10-18 11:06:37 +03:30
f1ced9be37
More warning fix
...
Okay, let's see if the gods are happy now...
2018-10-17 23:06:53 -07:00
40606abd0c
Fix build
2018-10-17 23:06:37 -07:00
c406aca193
Fix warning
2018-10-17 22:58:43 -07:00
270a37c324
Kick bots
2018-10-17 22:42:47 -07:00
6da8ef3f9f
Fix some wierdness...
2018-10-17 22:37:34 -07:00
83780308b4
[aat] Fix sanitize slowdown
...
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11034
2018-10-17 22:34:16 -07:00
9e8a9b846e
[aat] Another try at fixing Lookup null objects...
...
Ugly as hell, and don't even understand why some bits are needed.
But the logic is sound.
2018-10-17 21:45:27 -07:00
9d42d70269
[trak] Fix calc
...
We were getting the first track record always. Ie. this line:
if (trackTable[i].get_track_value () == 0.f)
{
- trackTableEntry = &trackTable[0];
+ trackTableEntry = &trackTable[i];
break;
}
The rest is cleanup.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1263 for the most part.
2018-10-17 17:55:47 -07:00
1f34388e8b
Merge branch 'master' into cff-subset
2018-10-17 09:34:48 -07:00
2e7c716511
[buffer] Add an assert
...
See if it helps debugging https://bugs.chromium.org/p/chromium/issues/detail?id=895117
2018-10-16 18:35:03 -07:00
25fe7e7e10
[aat] Comment
2018-10-16 18:22:54 -07:00
26092bb3d1
"allow-none" annotation for "out" parameters
...
Fixes the following warnings:
hb-ot-tag.cc:330: Warning: HarfBuzz: invalid "allow-none" annotation: only valid for pointer types and out parameters
hb-ot-tag.cc:334: Warning: HarfBuzz: invalid "allow-none" annotation: only valid for pointer types and out parameters
2018-10-16 17:36:10 -07:00
49bdb54427
typo in gobject annotation - "in/out" should be "inout"
...
"in/out" should be "inout"
2018-10-16 16:41:12 -07:00
Behdad Esfahbod
Michiharu Ariza
David Corbett
Ebrahim Byagowi
Qunxin Liu
Garret Rieger
Nathan Willis
Maks Naumov
Jonathan Kew
punchcutter
Egor Pugin
Behdad Esfahbod
Khaled Hosny
Eric Muller
Adrian Wong
Stephan Bergmann
Martin Hosken
Evgeniy Reizner
Martin
Ken
Ken Cunningham
Tor Arne Vestbø
cclauss
fanc999
prrace
Behdad Esfahbod
👻
Bruce Mitchener
Adenilson Cavalcanti
Victor Chang
Ken Brown
HinTak
Simon Tooke
Ben Wagner