dacebcadae
Simplify unions
2010-05-10 19:45:41 -04:00
0eb9fc6e37
Change DEFINE_SIZE_VAR to DEFINE_SIZE_ARRAY
2010-05-10 19:01:17 -04:00
596e471aa5
Cleanup DEFINE_SIZE_VAR2
2010-05-10 18:48:29 -04:00
b961518b96
Simplify array access
2010-05-10 18:20:54 -04:00
ed07422c33
Further cleanup of sizeof
2010-05-10 18:08:46 -04:00
40cbefe858
Remove unnecessary casts
2010-05-10 17:47:22 -04:00
bea34c7cbb
Further cleanup of DEFINE_SIZE
2010-05-10 17:28:16 -04:00
b3651231bf
Remove ASSERT_SIZE in favor of the safer DEFINE_SIZE_STATIC
2010-05-10 16:59:57 -04:00
569da92bc6
Cleanup ASSERT_SIZE_VAR
2010-05-10 16:46:36 -04:00
65f46b0033
Simplify DEFINE_NULL_DATA
...
Using ::min_size.
2010-05-06 19:35:19 -04:00
e45d3f86f9
Start cleaning up get_size()
...
So we know when the size is static and when dynamic.
2010-05-06 19:33:31 -04:00
b157617644
Remove the last of SANITIZE macros: SANITIZE_SELF
2010-05-06 14:48:27 -04:00
4f252fedc7
Remove SANITIZE macro
2010-05-06 13:30:23 -04:00
41a93d2c1f
Remove SANITIZE_WITH_BASE
2010-05-06 12:55:14 -04:00
f5fab0c718
Remove SANITIZE_MEM
2010-05-06 10:26:52 -04:00
583d7f9586
Cosmetic
2010-05-05 01:49:22 -04:00
39840474af
Remove SANITIZE_ARG_DEF and SANITIZE_ARG
2010-05-05 00:23:19 -04:00
bb029af943
Remove SANITIZE_THIS
2010-05-04 15:28:52 -04:00
2226fc93d1
Rename SANITIZE_BASE to SANITIZE_WITH_BASE
2010-05-04 15:12:17 -04:00
4d4cce9626
Remove SANITIZE_THIS2
2010-05-04 14:57:55 -04:00
64d3fc8d0d
Cosmetic: Rename HB_LIKELY/HB_UNLIKELY to likely/unlikely
2010-05-03 22:51:19 -04:00
caff7db93d
Fix Device::get_size() calculation
2010-04-26 10:07:35 -04:00
f1aaa2a436
Add TODO
2010-04-23 15:19:50 -04:00
a0bb49c583
Add comment re bsearch effect on sanitize
2010-04-22 18:47:03 -04:00
3b2c2df41b
Cleanup Extension sanitize()
2010-04-22 16:51:42 -04:00
e77302c61f
Add comment
2010-04-22 13:34:00 -04:00
7c469c3ca4
Minor
2010-04-22 13:26:21 -04:00
dc228048a8
Remove integrity check in Tag sanitize
...
Serves no useful purpose.
2010-04-22 13:22:41 -04:00
19828ad42d
Sanitize shallow in Lookup since the generic SubLookup has no methods
2010-04-22 00:50:19 -04:00
e5546a4352
Watch for overflow in Array sanitize
2010-04-22 00:48:54 -04:00
4f5f1c34dd
Rename const_sub_array to sub_array since all consts are implicit now
2010-04-22 00:27:39 -04:00
0795b784dd
Cosmetic
2010-04-22 00:23:14 -04:00
2d98d3bbaa
Simplify Lookup sanitize
2010-04-22 00:19:30 -04:00
c755cb3e3a
Change header comment
2010-04-22 00:11:43 -04:00
62c0fd7573
Cleanup de-const-casting during sanitize
2010-04-21 23:30:48 -04:00
2cb08458f6
Rename const_array() to array() (overloaded)
2010-04-21 22:37:31 -04:00
e961c86c57
Convert NEXT() and ARRAY_AFTER() macros to templates
2010-04-21 15:56:11 -04:00
198facdc55
Use templates for const char * casts
2010-04-21 13:35:36 -04:00
ffd321afd9
Simplify Tag struct
2010-04-21 01:55:09 -04:00
00e23fcc6f
Cosmetic
2010-04-21 01:55:03 -04:00
a87072db5d
Fix Class operator return type
2010-04-21 01:54:57 -04:00
53d237ec63
Remove ASSERT_SIZE_DATA
2010-04-21 01:54:49 -04:00
4b8487d83e
Fix the mystery bug!
...
A couple bugs joined forces to exhibit the mystery behavior of
crashes / infinite loops on OS X / wrong kerning / invalid memory
access. Pooh!
The bugs were involved:
- Wrong pointer math with ValueRecord in PairPosFormat1
- Fallout from avoiding flex arrays, code not correctly updated
to remove sizeof() usage.
We strictly never use sizeof() directly now. And the PairPos code
is cleaned up. Should fix them all. Bugs are:
Bug 605655 - Pango 1.26.2 introduces kerning bug
Bug 611229 - Pango reads from uninitialized memory
Bug 593240 - (pangoosx) Crash / infinite loop with Mac OS X
We were also doing wrong math converting Device adjustments to
hb_position_t. Fallout from FreeType days. Should shift 16, not
6. Fixed that too.
There's still another bug: we don't sanitize Device records
referenced from value records. Fixing that also.
2010-04-21 01:41:29 -04:00
807b8aa486
Another C++ strictness fix
...
Pango Bug 602408 - Invalid C++ code breaks compile with Sun C++ Compiler
(Error: A union member cannot have a user-defined assignment operator)
According to the bug:
C++ Programming Language by Bjarne Stroustrup: Chapter 10.4.12 forbids
explicitly using of union members with constructors, destructors or assignment
operations.
So we use a set() method instead of the assignment operator. Ugly, but hey,
that's life.
2009-11-19 20:35:01 -05:00
d6387757de
Fix sanitize
2009-11-11 17:15:03 -05:00
48de3730cd
Fix previous commit, ouch!
2009-11-04 16:59:50 -05:00
e21899bc35
Fix array query API
...
The array query APIs now all do:
- Return the total number of items
- Take a start_offset, such that individual items can be fetched
- The _count IN/OUT variable always has number of items written
into the array upon return of the function
2009-11-04 16:36:14 -05:00
d3480ba37f
Don't use zero-sized arrays
...
It's not part of the standard and MSVC doesn't like it. It makes the code
a lot less elegant than it used to be, but I think it should work now.
2009-11-03 10:47:29 -05:00
6bec81aa3a
Cosmetic
2009-11-02 19:17:36 -05:00
aa87d95173
[HB] Fix lookup_flag ignoring
...
Reported by Keith Stribley on HarfBuzz list.
2009-11-02 14:40:48 -05:00
Behdad Esfahbod