Sanitize tab index in `Node:add_view` (#1651)

* Fix `Node:add_view` not adjusting tab index after removing `EmptyView`

* Clamp tab index in `Node:add_view`
This commit is contained in:
Guldoman 2023-10-23 23:58:02 +02:00 committed by George Sokianos
parent 6370968494
commit 05fbc48e03
1 changed files with 5 additions and 1 deletions

View File

@ -177,8 +177,12 @@ function Node:add_view(view, idx)
assert(not self.locked, "Tried to add view to locked node") assert(not self.locked, "Tried to add view to locked node")
if self.views[1] and self.views[1]:is(EmptyView) then if self.views[1] and self.views[1]:is(EmptyView) then
table.remove(self.views) table.remove(self.views)
if idx and idx > 1 then
idx = idx - 1
end
end end
table.insert(self.views, idx or (#self.views + 1), view) idx = common.clamp(idx or (#self.views + 1), 1, (#self.views + 1))
table.insert(self.views, idx, view)
self:set_active_view(view) self:set_active_view(view)
end end