Commit Graph

933 Commits

Author SHA1 Message Date
Francesco Abbate aa0b2bb5fc Fix crash problem with rencache and font access
In some cases rencache was using a FontDesc pointer that was actually freed by
Lua giving segfaults errors.

In addition, some FontDesc object were not freed in some cases if the
rencache_end_frame was not called when performing the "restart" command.

The invalid access problem can happen because rencache keep some pointers to
FontDesc object but these are Lua userdata that Lua can dispose of. This
situation is prone to hard errors and we should avoid to keep pointers to
objects managed by Lua.

To this purpose we use luaL_ref/unref to bind the FontDesc into the Lua's
registry while rencache need them. We still keeps pointer to FontDesc object but
using luaL_ref we are assured they will not be disposed by Lua.

Since we are using luaL_ref/unref to inform the GC about when the objects are in
use we can now finalize the objects directly when Lua collects them. Previously
the GC metamethods was issuing a FREE command to rencache and the font was
actually freed only from the rencache_end_frame function.
2021-05-21 23:38:54 +02:00
Adam Harrison 3a5f04fae5 Spelling mistkae. 2021-05-21 16:32:26 -04:00
Adam Harrison 18fe6576d8 Fixed meson build on Mac. 2021-05-21 16:31:31 -04:00
Adam 949692860e
Tokenizer cleanup (#198)
* Cleaned up tokenizer to make subsyntax operations more clear.

* Explanatory comments.

* Made it so push_subsyntax could be safely called elsewhere.

* Unified terminology.

* Minor bug fix.

* State is an incredibly vaguely named variable. Changed convention to represent what it actually is.

* Also changed function name.

* Fixed bug.
2021-05-20 21:58:27 +02:00
liquidev 78999cabe2
Improved Lua syntax (#201)
* improved Lua syntax

* added some missing cases with number literals
2021-05-20 19:02:40 +02:00
Francesco Abbate 84095fadc9 Merge branch master into dev 2021-05-20 13:51:35 +02:00
Francesco Abbate 60219007f1 Fix include for reproc header 2021-05-20 13:50:13 +02:00
Janis-Leuenberger b15914d664
Add default keymap documentation (#199) 2021-05-20 13:43:56 +02:00
Francesco Abbate a8e1e040ca Meson config to use reproc as external library 2021-05-20 13:40:11 +02:00
jgmdev 9b1b1a3820 Initial work to allow writing LSP client in LUA.
* Added an amalgamated C version of https://github.com/DaanDeMeyer/reproc
* Added lua binding of reproc accesible in the process package.
* Modified meson build to include reproc sources as src/api/process.c
2021-05-20 13:39:07 +02:00
Francesco Abbate a02691f18e Merge topic branch for tabs scrolling buttons 2021-05-19 22:59:29 +02:00
Adam b278306fc9
Changed deindent, so that if the deindent runs into an unusual line with a partial indent at the front, it'll still de-indent that. (#193) 2021-05-19 22:41:28 +02:00
liquidev 86a7037ed9
support for multiple groups in one pattern (#196) 2021-05-19 22:35:28 +02:00
Francesco Abbate a92d15fe30 Use all the available space for tabs
Use a tab's width larger than style.tab_width if there is enough
available space to display the number of tabs specified in
config.max_tabs.
2021-05-19 10:09:40 +02:00
lqdev ba4fbde33d fixed mixed indentation 2021-05-18 17:52:18 +02:00
Francesco Abbate ca05562cc0 Restore correct fontello configuration 2021-05-17 15:16:57 +02:00
Francesco Abbate 1fb01f36df Avoid overflowing tab rectangles when animating 2021-05-17 15:11:06 +02:00
Francesco Abbate 13529c28d4 Cosmetic variable name change 2021-05-17 13:37:05 +02:00
Francesco Abbate ba40bc0dfc Final adjustments to tab's rect computations 2021-05-17 12:14:01 +02:00
Francesco Abbate 838bbf8285 Merge branch PCRE (adamharrison) into dev 2021-05-17 10:54:57 +02:00
Francesco Abbate 92322986b8 Fix error with previous commit
Error was introduced with PR:

https://github.com/franko/lite-xl/pull/190
2021-05-17 10:16:55 +02:00
Adam 6e08c3321c
Fixed a bug where if detectindent is paired with another plugin that hooks the event, it'll overwrite the other plugin's functions. (#190) 2021-05-17 10:05:08 +02:00
Adam e43f1b9df9
Unified open and saving style. (#189) 2021-05-17 09:29:51 +02:00
Adam 85d0d684de
Truncated lines longer than 256 characters, and skipped to the relevant portion of the line to reduce slowdown and increase relevancy. (#185) 2021-05-17 09:16:20 +02:00
Adam e54ffc49ea
Added in keyboard shortcuts to the project search module. (#188) 2021-05-17 09:14:46 +02:00
Cukmekerb bd4efa14a2
add `of` keyword to language_js.lua and improve js string syntax highlighting in (#186) 2021-05-17 08:56:21 +02:00
cukmekerb 27aa162148 add `of` keyword to language_js.lua and improve js string syntax highlighting in 2021-05-16 10:57:54 -07:00
Adam c7b1a6f53e
Allowed for optional boolean to better match filenames. (#180) 2021-05-16 19:23:17 +02:00
Francesco Abbate 9c9fbe4c8b Add macos minimum OS variable in info.plist 2021-05-16 10:11:12 -07:00
Francesco Abbate b37c190db2 Add buttons to scroll tabs when there are too many
Use config.max_tabs to configure the maximum number of tabs that can
be shown. Beyond the maximum value scroll buttons will appear to scroll
the tabs.
2021-05-16 15:50:27 +02:00
Francesco Abbate 90e41daa99 Add tab animation and improve hovering update
Always update the tab hovering status using the Node:update
method. Previous behavior was to update only on mouse moved
events.
2021-05-15 16:57:20 +02:00
Francesco Abbate b223dbca6f Use unicode ellipsis to truncate tab's text
For proportional fonts is equivalent to three dots but it makes a
lot of difference for monospaced fonts.
2021-05-15 16:27:29 +02:00
Francesco Abbate f30dfc20fe More accurate tab width calculation
Ensure the right side of the right-most tab always end up at the
same position.
2021-05-15 16:26:15 +02:00
Francesco Abbate 50a4fc212f Do not truncate filenames in tab and use dots 2021-05-15 14:49:16 +02:00
Francesco Abbate e2fcc41b4a Ensure tabs don't extend beyond window's width 2021-05-15 14:17:36 +02:00
Jan 7d29052367
Update C Language file (#182)
retype struct symbol, add some preprocessor keywords
2021-05-14 19:05:58 +02:00
Francesco Abbate ea3a7e81be Fix problem with previous commit
Desastrous problem where core.normalize_path was removing the leading /.
2021-05-10 17:01:14 +02:00
Francesco Abbate 708c2983ef Create new document if file doesn't exist
If a non-existing file is specified with the command "core:open-file"
a new document is opened with the given filename provided the directory
already exists.

The flag new_file is set to true in the Doc instance.

The file will be actually created only when the "save" command is used.

The document will be marked with the "*" event when no changes are done
to mean that it is a new file and is not yet saved.

The function common.normalize_path now process the .. and . in the
filename. Before was not needed because system.absolute_path already
get rid of them but now we need to have the absolute path of files
that not yet exists so we cannot use system.absolute_path.
2021-05-10 16:44:27 +02:00
Francesco Abbate 0ce5680ef2 Remove duplicate normalize_path function
Use the function defined in the "common" module.

Move the check for not-nil filename from common.normalize_path
to core.open_doc. In this latter the filename can be nil if a
new unnamed document is created.
2021-05-10 13:08:39 +02:00
Francesco Abbate ba48cb1382 Fix problem in regex.gsub
The local n was not initialized and the "string" argument was shadowing the Lua's "string" module.
2021-05-07 10:44:38 +02:00
Francesco Abbate 1c6325b40f Merge branch 'master' into 'dev' 2021-05-07 08:25:35 +02:00
Adam Harrison a100a7b6a9 Fixed offsets, and passed through an additional parameter. 2021-05-06 19:53:03 -04:00
Adam Harrison 88c5424e0b Removed unecessary plugin. 2021-05-06 19:53:03 -04:00
Adam Harrison c0c6bc5be9 Replaced pattern-based commands with regexes. 2021-05-06 19:53:03 -04:00
Francesco Abbate b3f9faff4a Fix pcre2 meson build config 2021-05-06 19:53:03 -04:00
Adam Harrison 57b1adcec2 Fixed pattern variable. 2021-05-06 19:53:03 -04:00
Adam Harrison bf09582478 Fixed lines to conform to style guidelines. 2021-05-06 19:53:03 -04:00
Adam Harrison a66e1f1559 Added in keyboard shortcut. 2021-05-06 19:53:03 -04:00
Adam Harrison 272067124d Updated PCRE to use utf8, and created sample plugin. 2021-05-06 19:53:03 -04:00
Adam Harrison a9dd790321 Reworked files to conform to style guidelines. 2021-05-06 19:53:03 -04:00