walkero
/
nghttp2
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Don't check multiple in-sequence NULL in spdylay_frame_count_unpack_nv_space 

If we return negative error code in that function, it means frame will not
unpacked and ends up to lose any information the frame contains.
The spec says it should send RST_STREAM with PROTOCOL_ERROR, so we need
at least stream ID.
Therefore, the check should be performed in
spdylay_session_on_syn_stream_received().
This commit is contained in:
Tatsuhiro Tsujikawa 2012-02-05 21:57:55 +09:00
parent d0cd362852
commit d4c5f39cf9
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/spdylay_frame.c
View File

@ -118,11 +118,6 @@ int spdylay_frame_count_unpack_nv_space
} }
for(off -= len, j = off+len; off != j; ++off) { for(off -= len, j = off+len; off != j; ++off) {
if(in[off] == '\0') { if(in[off] == '\0') {
/* spdy/2 spec says it does not allow multiple, in-sequence
NULL characters */
if(off+1 != j && in[off+1] == '\0') {
return SPDYLAY_ERR_INVALID_ARGUMENT;
}
++nvlen; ++nvlen;
} }
} }