Commit Graph

2386 Commits

Author SHA1 Message Date
Even Rouault 433d4d30f5 T1: (failed) optimization attempt to use signed magnitude representation (#931)
Instead of using two-complement integer representation of data samples during
code-block decoding, use a signed magnitude representation to avoid comparison
branches in passes.

However the (best) timings show that it is actually slightly slower, or at
least no better. 51649 ms with this attempt vs 51536 before on MAPA_005.jp2
reencoded with default options.

Two variants with sign in msb (the default) or in lsb lead to similar
performances
2017-05-22 15:10:42 +02:00
Even Rouault 83d7a6d4a4 MQC: remove disabled MQC_PERF_OPT mode, which brings no performance improvements (see #923) 2017-05-15 14:11:47 +02:00
Even Rouault 4431fa7265 Add comments about non successfull attempt of implementing alternate INITDEC, DECODE and BYTEIN procedures (refs #921) 2017-05-15 14:09:51 +02:00
Even Rouault f7a126af61 Merge pull request #926 from rouault/reformat_h_files
Reformat: apply reformattin on .h files (#128)
2017-05-15 13:08:03 +02:00
Even Rouault 3c2972f924 Reformat: apply reformattin on .h files (#128) 2017-05-15 12:21:30 +02:00
Even Rouault 28d2eabca7 Merge pull request #919 from rouault/reformat
Add mechanisms to reformat and check code style, and reformat whole codebase (#128)
2017-05-15 12:09:45 +02:00
Even Rouault 0ecac46a1d perf_test.py: implement -i option 2017-05-11 20:18:42 +02:00
Even Rouault cde210be39 astyle.options: use non deprecated option name 2017-05-11 11:21:37 +02:00
Even Rouault 563bd8499e Reformat whole codebase with astyle.options (#128) 2017-05-09 20:46:20 +02:00
Even Rouault d4e54e9f35 Add mechanisms to reformant and check code style (#128)
Use an internal version of astyle (astyle 3.0). Scripts taken from QGIS.
astyle.options from https://github.com/uclouvain/openjpeg/issues/128

scripts/prepare-commit.sh can be used locally to automatically reformat
edited files.

Travis-CI will run scripts/verify-indentation.sh to verify committed files.
2017-05-09 20:46:16 +02:00
Even Rouault 8650b70e06 Merge pull request #918 from rouault/profile
Add profiling of CPU and memory usage (#912)
2017-05-09 13:16:53 +02:00
Even Rouault 05d58451a1 Add profiling of CPU and memory usage (#912) 2017-05-09 12:35:51 +02:00
Even Rouault e92fe29016 Merge pull request #917 from rouault/bench
Add performance benchmarking scripts
2017-05-09 12:33:07 +02:00
Even Rouault 328f076d26 Add performance benchmarking scripts
And run them by Travis-CI
2017-05-06 14:44:20 +02:00
Even Rouault 20291aad07 Merge pull request #915 from rouault/appveyor_fix_attempt
Fix retrieval of jpylyzer in AppVeyor
2017-05-03 12:41:02 +02:00
Even Rouault 04980a8c7b Fix retrieval of jpylyzer in AppVeyor 2017-05-03 12:03:00 +02:00
Even Rouault a18040e022 Merge pull request #893 from rouault/remove_tagtree_warnings
Remove warnings related to empty tag-trees.
2017-05-03 11:48:02 +02:00
Even Rouault e7ff1efb82 Merge pull request #899 from jwilk/man-warnings
Remove spurious .R macros from manpages
2017-05-03 11:46:45 +02:00
Even Rouault 807da629a6 Merge pull request #914 from alexwlchan/fix-readme
Escape quotes to ensure README renders on GitHub correctly
2017-05-03 11:46:01 +02:00
Alex Chan 4927b64766
Escape quotes to ensure README renders on GitHub correctly 2017-04-28 09:43:05 +01:00
Jakub Wilk cf08763c31 Remove spurious .R macros from manpages
Fixes the following warnings from man:

    `R' is a string (producing the registered sign), not a macro.
2017-03-05 16:13:18 +01:00
Antonin Descampe 8c33128369 Fixed CRLF auto conversion issue in openjpeg-data #655 2017-03-03 23:23:39 +01:00
Even Rouault a43f1bea62 Remove warnings related to empty tag-trees.
Decoding some valid .jp2 files like Sentinel2 datasets leads to warnings like:
No incltree created.
tgt_create tree->numnodes == 0, no tree created.
No imsbtree created.
tgt_create tree->numnodes == 0, no tree created.

Besides that, the image is correctly decoded. So there is no reason to emit
those warnings.
2017-02-13 12:36:45 +01:00
Antonin Descampe 7113c4e3bb Update THANKS.md 2016-10-03 23:47:10 +02:00
Antonin Descampe b8197de716 Update CHANGELOG.md 2016-10-03 23:45:44 +02:00
Antonin Descampe b079198838 fix abi-check and limit upload to website for master 2016-09-29 22:06:23 +02:00
Antonin Descampe 110d31891b fix abi-check 2016-09-29 21:44:38 +02:00
Antonin Descampe cc0c71c30b fix abi-check 2016-09-29 20:23:01 +02:00
Antonin Descampe 5695ac15ff Update abi-check scripts for v2.1.2 2016-09-28 20:59:10 +02:00
Antonin Descampe df5e8628f2 Update NEWS.md for v2.1.2 2016-09-28 20:58:55 +02:00
Antonin Descampe b0c0f0ff04 Update Changelog for v2.1.2 2016-09-28 20:58:34 +02:00
Antonin Descampe 9afc1699f0 Update version number for future release 2.2.0 2016-09-28 18:55:02 +02:00
Mathieu Malaterre 34dae137a9 OPENJPEG_NAMESPACE is configurable by user 2016-09-26 12:01:31 +02:00
Mathieu Malaterre 4d5c5e7c48 Remove typos from comments and man pages 2016-09-26 11:26:55 +02:00
Matthieu Darbois fac916f72a Fix PNM file reading (#847)
Malformed PNM file could cause a crash in opj_compress.
Checks were added to prevent this.

Fixes #843
Updates #440
2016-09-22 00:30:34 +02:00
Stefan Weil 8715ce2749 Fix some issues reported by Coverity Scan (#846)
* test_tile_decoder: Fix potential buffer overflow (coverity)

CID 1190155 (#1 of 1): Unbounded source buffer (STRING_SIZE)

Using a pointer instead of buffer of fixed size avoids the limit
for the length of the input file name.

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* test_tile_encoder: Fix potential buffer overflow (coverity)

CID 1190154 (#1 of 1): Unbounded source buffer (STRING_SIZE)

Using a pointer instead of buffer of fixed size avoids the limit
for the length of the output file name. This implies that the length
can exceed 255, so the data type for variable len had to be fixed, too.

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* openjpip: Initialize data before returning it

This fixes an error reported by Coverity:

CID 1190143 (#1 of 1): Uninitialized scalar variable (UNINIT)

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-09-21 21:15:25 +02:00
Stefan Weil 045aa4d9f2 Fix potential out-of-bounds read (coverity) (#844)
* query_parser: Fix potential out-of-bounds read (coverity)

CID 1190207 (#1 of 1): Out-of-bounds read (OVERRUN)

Variable i must be checked before testing query_param.box_type.

Signed-off-by: Stefan Weil <sw@weilnetz.de>

* jpip_parser: Fix potential out-of-bounds read (coverity)

CID 1190206 (#1 of 1): Out-of-bounds read (OVERRUN)

Variable i must be checked before testing query_param.box_type.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-09-21 13:17:09 +02:00
Antonin Descampe da94042481 Merge pull request #834 from trylab/issue833
Fix issue 833.
2016-09-20 18:59:30 +02:00
Antonin Descampe 31d44f0280 Disable automatic compilation of t1_generate_luts
Fix #831
2016-09-20 18:48:06 +02:00
Antonin Descampe 3aaeea7ce8 renamed USE_THREAD to OPJ_USE_THREAD
renaming to be consistent with previous OPJ CMake options
2016-09-16 17:54:12 +02:00
Matthieu Darbois 6e7616c83c Remove TODO for overflow check (#842)
The check was already done. It’s been simplified.
Reformat to get consistent style throughout the functions.
2016-09-15 23:51:34 +02:00
Matthieu Darbois 9a07ccb3d0 Add overflow checks for opj_aligned_malloc (#841)
See
https://pdfium.googlesource.com/pdfium/+/b20ab6c7acb3be1393461eb650ca8fa4660c937e/third_party/libopenjpeg20/0020-opj_aligned_malloc.patch
2016-09-15 01:57:53 +02:00
Matthieu Darbois f88c9974e2 Flags in T1 shall be unsigned (#840)
This will remove some conversion warnings
2016-09-14 23:46:46 +02:00
Matthieu Darbois 0954bc11e3 Fix some warnings (#838)
Fix warnings introduced by uclouvain/openjpeg#786
2016-09-14 00:12:43 +02:00
Antonin Descampe 1e69940955 Merge branch 'smuehlst-bit-fields-type' 2016-09-13 21:21:56 +02:00
Antonin Descampe f66e120452 Merge branch 'bit-fields-type' of https://github.com/smuehlst/openjpeg into smuehlst-bit-fields-type 2016-09-13 21:21:11 +02:00
Antonin Descampe d6d0f070e1 Merge pull request #786 from rouault/tier1_optimizations_multithreading
T1 & DWT multithreading decoding optimizations
2016-09-13 16:39:26 +02:00
Antonin Descampe f1f7c53308 remove ops 1.4 and 1.2 from abi-check to avoid symlinks in gh-pages 2016-09-13 16:21:38 +02:00
trylab 893143c8e1 Fix issue 833.
Add some overflow check operations.
2016-09-13 17:43:30 +08:00
Matthieu Darbois 805972f4c8 Add test for issue 820 (#829)
Update uclouvain/openjpeg#820
2016-09-11 19:47:32 +02:00