5624e4a25f
[trunk] Always report when decompression failed as return code value
2014-03-13 12:31:41 +00:00
320784659d
[trunk] Just in case this would be helpful for other, here is the code used to track issue 80
...
Update issue 80
2014-03-13 10:56:48 +00:00
51ab8cd67d
[trunk] Tweak documentation in t2.c. Be more verbose in case of failure.
2014-03-13 10:46:54 +00:00
237253d83b
[trunk] Add some documention in the pi code
2014-03-13 10:42:06 +00:00
fe100fb490
[trunk] Add debug code to extract decompressed image right before PCLR handling
...
Update issue 235
2014-03-13 10:35:41 +00:00
41add6882b
[trunk] Make sure to use 8bits buffer when applying the ICC profile.
...
Fixes issue 281
2014-03-12 14:18:25 +00:00
dd0d2c2f0a
[trunk] Add debug info to be able to test integration with littlecms
2014-03-12 13:55:41 +00:00
6b51d11d08
[trunk] Make sure when reading POC that number of layers (layer end) is within acceptable bound.
...
Fixes issue 80
2014-03-12 10:10:21 +00:00
59270c39a7
[trunk] Re-active old warning about missing SOP marker
2014-03-11 15:21:12 +00:00
db82cf7778
[trunk] Add debug info to track issue 80
...
Update issue 80
2014-03-11 15:17:39 +00:00
ddb1d57766
[trunk] Rework assertion to work on 32bits system
2014-03-11 12:56:52 +00:00
5dd770746b
[trunk] Fix remainings warnings on linux/32bits arch
2014-03-11 10:28:04 +00:00
fa436eb368
[trunk] Rework fseek ifdefs blockers, it breaks the 64bits behavior for fseeko
2014-03-11 10:27:01 +00:00
fcc658f106
[trunk] Fix compilation errors when JPWL and/or MJ2 are build
2014-03-11 09:11:35 +00:00
2e7b8fb9a1
[trunk] Another final round of fixes for sign conversion warnings.
...
Fixes issue 256
2014-03-10 16:43:04 +00:00
1778e2576e
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-10 16:17:12 +00:00
73c9e85642
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-10 16:17:01 +00:00
76557d2eb3
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-10 15:51:05 +00:00
c02c1432e8
[trunk] Remove a set of warning about sign conversion
...
Update issue 266
2014-03-10 14:15:27 +00:00
8411ed4f80
[trunk] Remove warning about sign conversion in color.c
...
Update issue 256
2014-03-10 14:05:25 +00:00
b01c1240cf
[trunk] Fix simple sign conversion warnings only visible on 32bits arch
2014-03-10 12:22:56 +00:00
9a52b30c3d
[trunk] Properly handle PGM file generation when fullpath is specified in the cmd line
...
This will break a very old behavior (since 2005), but avoid writing in un-expected places for users
This also make the behavior similar with PGX file generation
2014-03-10 10:52:09 +00:00
666ef53fd2
[trunk] Make sure to always initialize variable
2014-03-10 08:40:02 +00:00
e02ba05034
[trunk] Fix warnings about shadow variables
2014-03-10 08:25:08 +00:00
b478912910
[trunk] remove a warning when using strict prototype
2014-03-10 08:15:43 +00:00
2001932c56
[trunk] Remove 2 warnings about set but not used variables
2014-03-10 08:13:05 +00:00
f54de95802
[trunk] Upon failure, need to return proper return code
2014-03-07 17:23:19 +00:00
ffad2fbe55
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 14:14:31 +00:00
cc1354ebfa
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 14:00:47 +00:00
581d2ba8b4
[trunk] Rework r2597, make sure test suite is passing now.
...
Update issue 256
2014-03-07 13:50:58 +00:00
61348b20b4
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 13:43:15 +00:00
e619e06078
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 13:40:54 +00:00
4f84d1693a
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 13:37:45 +00:00
71d244a5b6
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 13:33:47 +00:00
f9a0f869e3
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 13:31:25 +00:00
33c472d734
[trunk] Redo r2623, and remove guilty section
...
Update issue 256
2014-03-07 13:29:35 +00:00
a8eb122c1f
[trunk] Revert r2623 for now
2014-03-07 13:14:26 +00:00
956b1a7697
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 12:06:00 +00:00
472ce19183
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 12:01:41 +00:00
740924fa61
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 11:59:29 +00:00
01b4bb5447
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 11:57:37 +00:00
ee3b02932a
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 11:43:50 +00:00
2a07d3d26b
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 11:28:34 +00:00
e238148d42
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 11:27:34 +00:00
9d21695476
[trunk] As reported by clang analyzer thoses values were never read
2014-03-07 11:20:59 +00:00
22d11a9ccb
[trunk] Remove mem leak and warning reported by clang
2014-03-07 11:17:51 +00:00
fc9248ea2b
[trunk] Remove simple warnings about format
2014-03-07 11:11:43 +00:00
c302979738
[trunk] Remove simple warning about functions not used
2014-03-07 11:08:35 +00:00
e4d077bc98
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 11:06:13 +00:00
76cd9b7f72
[trunk] Another round of fixes for sign conversion warnings.
...
Update issue 256
2014-03-07 10:25:16 +00:00
e71431ec78
[trunk] Fix simple warning about sign conversion
...
Update issue 256
2014-03-07 10:21:51 +00:00
7b335eb635
[trunk] Another of fixes for warning about sign conversion
...
Update issue 256
2014-03-07 10:19:39 +00:00
c0c086388b
[trunk] Fix warning about sign conversion
...
Update issue 256
2014-03-07 10:03:56 +00:00
048c8302fe
[trunk] un-deprecated opj_stream_destroy API, import patch manually
...
In some case user still want to be able to call opj_stream_destroy.
Fixes issue 227
2014-03-07 09:58:32 +00:00
a7b051b172
[trunk] Update memory management mecanism
...
Fixes issue 253
2014-03-07 09:44:32 +00:00
5f7ad58f48
[trunk] Remove self-assignement.
...
Fixes issue 273
2014-03-07 09:33:32 +00:00
016b9fc052
[trunk] Fix compilation in visual studio, inline cannot be used directly.
...
Fixes issue 272
2014-03-07 09:15:27 +00:00
37128c34a9
[trunk] Fix mem leaks reported by cppcheck
2014-03-07 08:48:47 +00:00
6790587db8
[trunk] Revert r2597 for now, since it breaks a lot of tests
2014-03-06 17:25:08 +00:00
445f696dc6
[trunk] Remove warning about sign conversion.
...
Update issue 256
2014-03-06 16:59:34 +00:00
dd5c3a9c8e
[trunk] Remove some easy warnings
2014-03-06 16:29:03 +00:00
0f45e38b52
[trunk] Remove warning about sign conversion.
...
Update issue 256
2014-03-06 16:26:24 +00:00
93bc3cb628
[trunk] Remove warning about sign conversion.
...
Update issue 256
2014-03-06 16:01:23 +00:00
7e64eb5414
[trunk] Remove some easy warnings about sign compare reported by gcc
2014-03-06 15:00:41 +00:00
4d5d1f0f66
[trunk] Handle cmap where direct use is specified (issue235_cmapsubbox.jp2)
...
I doubt the old code ever work. The new code copy the old codestream bytes into the new components (instead of copying the pointer).
Technically the issue235.jp2 file should be handled since I.5.3.5 specifies that:
...
If the JP2 Header box does not contain a Component Mapping box, the components shall be mapped directly to channels,
such that component i is mapped to channel i.
...
Update issue 235
2014-03-05 09:45:04 +00:00
1ef677f264
[trunk] Make sure to reject images such as 1336.pdf.asan.47.376.jp2
...
Fixes issue 267
2014-03-04 10:32:26 +00:00
07193e2a34
[trunk] remove more conversion warning in multi-lines macro.
...
C allow simple tricks such as to find those:
gcc -E tcd.c | sed '/^\#/d' | indent -st -i2 > clean.c
Update issue 256
2014-03-04 09:58:07 +00:00
f7da94610d
[trunk] Remove some conversion warnings reported by gcc
...
Update issue 256
2014-03-04 09:55:38 +00:00
872368d25c
[trunk] Remove another warning. ftell returns long int
...
Update issue 256
2014-03-04 09:32:19 +00:00
36320b4bf4
[trunk] Remove more conversion warnings.
...
Update issue 256
2014-03-04 09:30:07 +00:00
7185faa857
[trunk] Remove warning about conversion.
...
Update issue 256
2014-03-04 09:19:49 +00:00
51caff5dcf
[trunk] Revert portion of r2562, need to investigate issue.
...
Update issue 269
2014-03-04 08:40:06 +00:00
d643ff5dbc
[trunk] Remove remaining conversion issues in mqc.c
2014-03-03 16:11:41 +00:00
44ca89eff7
[trunk] Remove remainings conversion issues in t2.c + clock.c
2014-03-03 16:08:03 +00:00
7afad19c77
[trunk] Remove a simple warning about int -> float conversion
2014-03-03 16:02:36 +00:00
765c4ab4f4
[trunk] rework code to avoid a warning. this also remove a division and prefer bit-shift
2014-03-03 16:02:16 +00:00
24eca792ff
[trunk] Remove some more warnings about conversion
2014-03-03 15:55:27 +00:00
b1b17ee264
[trunk] Prefer compile time constant to avoid conversion double -> int
2014-03-03 15:55:06 +00:00
74600cfb14
[trunk] Review warning about types conversion, and add cast when needed
2014-03-03 15:47:23 +00:00
171ec1583d
[trunk] Remove some simple warnings about conversion
2014-03-03 12:13:11 +00:00
e92fe4c1a4
[trunk] Remove warning about cast double -> int. Instead use bit-shifting (compile time computation)
2014-03-03 12:01:36 +00:00
11f402b44a
[trunk] Remove easy to fix warnings about conversion
2014-03-03 12:00:24 +00:00
18049fe3e0
[trunk] Import left over from patch submitted as issue 225 (comment #14 )
...
Update issue 225
2014-03-03 11:48:27 +00:00
b330c10492
[trunk] remove some simple warnings about unused params
2014-03-03 11:40:59 +00:00
25255c4ed1
[trunk] remove all api with invalid FILE* parameters which could leads to issues when applications are compiled with different flags from openjpeg.
...
Fixes issue 198
2014-03-03 11:36:31 +00:00
16febebd28
[trunk] Explicitely trigger issue 229, there may be an impact in code execution. The assert may get removed afterward
...
Update issue 229
2014-03-03 11:30:54 +00:00
339952c2af
[trunk] Remove simple warnings
2014-03-03 10:41:13 +00:00
9863d8d1d2
[trunk] Avoid conflicting declarion for fseek in openjp2 vs fseek in openjpip
2014-03-03 08:49:28 +00:00
3c7a7a1675
[trunk] Remove deprecated functions.
...
Update issue 268
2014-03-03 08:30:36 +00:00
d14c475de7
[trunk] Remove warning about unused function
...
Update issue 268
2014-03-03 08:27:40 +00:00
a68a3feb60
[trunk] Remove deprecated functions (not called anywhere in the code base).
...
Update issue 268
2014-03-03 08:17:20 +00:00
a149502c01
[trunk] Remove some simple warnings about var being set but not used
2014-03-02 10:23:05 +00:00
decace60da
[trunk] Remove warning about -2147483648 (aka INT_MIN), causing this decimal constant is unsigned only in ISO C90
2014-03-02 10:20:57 +00:00
2c876b6765
[trunk] Remove simple warnings about comments, missing case in switch statement
2014-03-02 10:16:54 +00:00
6d0785a78f
[trunk] Fix compilation on MSVC compiler
2014-03-01 10:41:46 +00:00
ec593a2549
[trunk] Partially rework r2506, original patch from issue 171 was totally bogus (untested?) and did break most of the test (eg. p1_04 family)
...
convert.c duplicate a lot of code, this patch only adresses the PGX codec section of the code.
Update issue 171
Update issue 264
2014-02-28 17:29:28 +00:00
c53e2960a0
[trunk] Remove easy uint32 <-> int32 conversions
2014-02-28 16:01:07 +00:00
cf91ebf278
[trunk] Re-import chunk from r2458 that made textGBR.jp2 to fail otherwise
...
Update issue 225
2014-02-28 15:27:30 +00:00
fd5f21af00
[trunk] Rework r2458, instead we should reject 451.pdf.SIGSEGV.ce9.3723 since tile-parts are out of order (as per kakadu behavior).
...
Update issue 225
2014-02-28 15:24:33 +00:00
fc855084a0
[trunk] Really apply r2460 this time, but fix the original typo in the submitted patch
...
Update issue 225
2014-02-28 14:52:58 +00:00
1eb67ca49d
[trunk] Remove some simple warnings in opj_dump
2014-02-28 12:06:57 +00:00
7a89d731f7
[trunk] Merge final patch from issue 171 with code simplification. also handles signed case properly.
...
Fixes issue 171
2014-02-28 09:52:35 +00:00
a347262468
[trunk] Import patch from issue 218. No dataset to check, so blindly applied it.
...
Fixes issue 218
2014-02-27 17:21:00 +00:00
6a6fa7027a
[trunk] Import patch from issue 171. Only the imagetoraw part was not applied.
...
Update issue 171
2014-02-27 17:04:06 +00:00
7c120281c7
[trunk] improve command line parser syntax checking
2014-02-27 10:02:46 +00:00
8a4095b405
[trunk] add a sentinel in debug code
2014-02-27 09:56:06 +00:00
8f4d674442
[trunk] Add missing include dir for wx app
2014-02-26 14:04:03 +00:00
52440cc2e6
[trunk] Remove a simple warning about a cast
2014-02-26 12:54:02 +00:00
3fe9243e1c
[trunk] revert r2460 since it breaks ETS-C1P0-p0_03.j2k-decode.
...
Update issue 225
2014-02-26 12:33:49 +00:00
05dae25a22
[trunk] Revert r2453 since it breaks conformance test ETS-C1P1-p1_06.j2k-decode
2014-02-26 12:30:44 +00:00
23ea270881
[trunk] Import patch from sumatrapdf team. This handle testcase 1336.pdf.asan.47.376
...
Update issue 225
2014-02-26 11:27:01 +00:00
7247543da3
[trunk] Import patch from sumatrapdf team. This handle testcase 1888.pdf.asan.35.988
...
Update issue 225
2014-02-26 11:26:09 +00:00
37a8d2acc1
[trunk] Import patch from sumatrapdf team. This handle testcase 1851.pdf.SIGSEGV.ce9.948
...
Update issue 225
2014-02-26 11:25:27 +00:00
4a7ba87d99
[trunk] Import patch from sumatrapdf team. Start using new color space when found.
...
Update issue 225
2014-02-26 11:24:38 +00:00
51e3764519
[trunk] Import patch from sumatrapdf team. This handle some Part-2 compliant file, by being more tolerant in COLR box. No testcase for now.
...
Fixes issue 247
2014-02-26 11:22:34 +00:00
533d92aa8e
[trunk] Import patch from sumatrapdf team. This handle some testcase with no input dataset, but changes looks ok.
...
Update issue 225
2014-02-26 11:21:18 +00:00
19887b7b8c
[trunk] Import patch from sumatrapdf team. This handle testcase 2977.pdf.asan.67.2198
...
Update issue 225
2014-02-26 11:17:18 +00:00
005e75bdc3
[trunk] Import (ugly) patch from sumatrapdf team. This feels like a hack rather than a solution.
...
Fixes issue 226
2014-02-26 11:16:32 +00:00
5f3470fcd0
[trunk] Import patch from sumatrapdf team. This handle testcase 3635.pdf.asan.77.2930
...
Update issue 225
2014-02-26 11:14:27 +00:00
adb237cfa8
[trunk] Import patch from sumatrapdf team. Original commit is 5b0c9985e3359aca9b3fcfd94424166aa61a141a.
...
Update issue 225
2014-02-26 11:13:21 +00:00
29a29d6210
[trunk] Import patch from sumatrapdf team. This handle testcase 451.pdf.SIGSEGV.ce9.3723
...
Update issue 225
2014-02-26 11:11:33 +00:00
3a155ceda6
[trunk] Import patch from sumatrapdf team. This handle testcase 2.pdf.SIGFPE.706.1112
...
Update issue 225
2014-02-26 11:10:40 +00:00
7195a23a9d
[trunk] Import patch from sumatrapdf team. This handle testcase 1610.pdf.SIGSEGV.59c.681
...
Update issue 225
2014-02-26 11:09:59 +00:00
0ae6ff8018
[trunk] Import patch from sumatrapdf team. This handle testcase 2539.pdf.SIGFPE.706.1712
...
Update issue 225
2014-02-26 11:09:20 +00:00
241769dc2f
[trunk] Import patch from sumatrapdf team. This handle testcase 4035.pdf.SIGSEGV.d8b.3375
...
Update issue 225
2014-02-26 11:08:25 +00:00
4a39ee9bbc
[trunk] Import patch from sumatrapdf team. Add detection for testcase 1802.pdf.SIGSEGV.36e.894
...
Update issue 225
2014-02-26 11:06:18 +00:00
1dedf7f0cd
[trunk] Import patch from sumatrapdf team. Add a new function to check color box.
...
Update issue 225
2014-02-26 11:05:31 +00:00
70ede09310
[trunk] Import patch from sumatrapdf team. This patch adds new colorspace handling.
...
Update issue 225
2014-02-26 11:04:33 +00:00
3da30304fc
[trunk] Import patch from sumatrapdf team. This adds alpha handling. This patch changes ABI.
...
Update issue 225
2014-02-26 11:03:55 +00:00
c4317177f3
[trunk] Remove simple warnings about unused functions
2014-02-26 09:46:01 +00:00
e231a84b2f
[trunk] Properly store and use value returned by fread. Also invert nmemb and size in fread call.
...
Fixes issue 262
2014-02-26 09:40:19 +00:00
b56fb96b1b
[trunk] Fix invalid write access in JPIP code.
...
Fixes issue 261
2014-02-26 09:35:11 +00:00
563d238fa0
[trunk] Create a new static *_impl function to avoid a warning triggered by the deprecation mecanism
...
Fixes issue 257
2014-02-25 16:49:26 +00:00
7dd65e84e6
[trunk] Revert r2415 for now since it introduce large regression
2014-02-25 14:14:56 +00:00
e260ec6e9d
[trunk] Import commit 87b08a096bb8ad61f9dbe4811e208d9c9d7fe63b from ghostpdl
...
don't define lrintf for MSVC 2013 (fix compilation breakage)
Update issue 225
2014-02-25 14:03:30 +00:00
7ce3f3c1a6
[trunk] Import commit 4cee6ceab21025079f439bb152fb9d8ae8c5c832 from ghostpdl
...
Bug 694906: fix potential heap overflow in opj_t2_read_packet_header
Update issue 225
2014-02-25 13:50:29 +00:00
a466755bbb
[trunk] import commit 83dad6a76536222a3a51146f942e733a2e90ec52 from ghostpdl
...
fix potential NULL-pointer dereference caused by testing the wrong variable
after opj_realloc (happens only in OOM situations)
Update issue 225
2014-02-25 13:39:50 +00:00
901c9d8ae0
[trunk] Import commit fc884aee2b69c78500e65c3d05bf216791a9ea4a from ghostpdl
...
prevent heap overflow in opj_t2_read_packet_header
Also prevent a double-free of segment data under OOM conditions.
Problem found in a test file, 1802.pdf.SIGSEGV.36e.894 supplied
by Mateusz "j00ru" Jurczyk and Gynvael Coldwind of the Google
Security Team using Address Sanitizer. Many thanks!
Update issue 225
2014-02-25 13:38:32 +00:00
6145c82804
[trunk] Import commit 8ec8321df613986e8642e2975f7182072eb4be62 from ghostpdl
...
make opj_stream_set_user_data accept a NULL stream
for consistency with opj_stream_set_* which does so.
Update issue 225
2014-02-25 13:33:43 +00:00
876c02206d
[trunk] Import commit f4139d702559649e577a5df9cfd64b0ca6107a7a from ghostpdl
...
Several functions accept a buffer size but never actually check whether
the buffer overflows during reading/writing. This fixes all cases where
a size variable has explicitly been marked as unused (through a (void)
cast).
This was discovered while investigating an assertion caused by
7cc691f332f26802c64cdc47e17bff8b_signal_sigabrt_7ffff6d59425_2247_2509.pdf
among others.
Thanks to Mateusz Jurczyk and Gynvael Coldwind of the Google Security
Team for providing the example files.
2014-02-25 13:28:37 +00:00
3ca312033f
[trunk] Clarify raw input in openjpeg. LSB vs MSB are now documented.
...
Fixes issue 62
2014-02-25 10:35:07 +00:00
d847e477f0
[trunk] add missing private lib. Update issue 223
2014-02-24 17:22:48 +00:00
228e0a3d79
[trunk] Fix a simple mem leak
2014-02-24 14:55:32 +00:00
33d8f08964
[trunk] Fix a warning about type conversion. Use a trick where unsigned wrapping is legal
2014-02-24 08:52:44 +00:00
e826e9281e
[trunk] replaced fprintf with event_mgr in cinema-related stuff in j2k.c
2014-02-12 16:33:19 +00:00
780120c9a2
[trunk] moved logic related to cinema profiles in library (was in
...
opj_compress.c). This enables one using the library with its own
executable to easily ask for cinema profiles.
2014-02-12 16:16:21 +00:00
d6c0c85125
[trunk] added a warning when tif conversion changes input image bitdepth
2014-02-12 15:16:36 +00:00
c81fb397bb
[trunk]re-indenting convert.c
2014-02-12 14:56:49 +00:00
d143f49a66
[trunk] fixed another DCI compliance bug
2014-01-23 09:39:02 +00:00
ee3f2ffa19
[trunk] fixed several bugs in cinema mode (2K 24/48 fps, and 4K). Trunk
...
now produces compliant DCI code-streams.
2014-01-22 18:41:34 +00:00
Mathieu Malaterre
Antonin Descampe