Commit Graph

644 Commits

Author SHA1 Message Date
Ryan C. Gordon 1affc74230 From: Jorg Walter
To: icculus@clutteredmind.org
Subject: Bug in zip archiver
Date: Sat, 23 Jul 2005 22:19:09 +0200

Hi!

PhysFS has a bug in the ZIP archive module, function zip_find_start_of_dir.
Upon encountering a substring match, rc is set to a wrong value. The fix is
simple: swap both assignments like this:

[patch below  --Ed.]

Some additional info for testing: Symptoms when you encounter this bug: A dir
is reported as empty although it has files in it; prerequisites or
encountering it: two dirs, one a substring of another, like "data/txt" and
"data/txt2", laid out in a way so that variable "middle" points to a file in
txt2 at some point during zip_find_start_of_dir

By the way, if you're interested in where PhysFS is used: I found this bug
while writing a patch for DOSBox (http://dosbox.sourceforge.net) to support
ZIP files. And I'd love to see that enhanced PHYSFS_mount syntax in an
official release soon *hint* ;);)
2005-07-23 21:46:46 +00:00
Ryan C. Gordon 092abfdeda Removed old dir. 2005-07-13 15:23:02 +00:00
Ryan C. Gordon 68f832b9f7 Moved to zlib122 and security fix discussed here:
http://www.cve.mitre.org/cgi-bin/cvename.cgi?name=CAN-2005-2096
2005-07-13 15:22:08 +00:00
Ryan C. Gordon 12353f5346 Backport from devbranch: mingw support. 2005-06-13 01:16:13 +00:00
Ryan C. Gordon 804d364506 MacOS Classic fixes, MPW support, and removal of SITX for SIT (no SITX support
in the final Stuffit Expander for OS9, apparently).
2005-03-16 12:18:17 +00:00
Ryan C. Gordon e7a9d06206 Fixed untranslated string (thanks, Danny!) 2005-03-16 12:00:54 +00:00
Ryan C. Gordon cd065471c8 Spanish and Brazillian Portuguese translations. 2005-03-16 12:00:07 +00:00
Ryan C. Gordon ab1fd8a763 Minor comment fix (stable branch backport) 2005-02-15 22:30:28 +00:00
Ryan C. Gordon 73fc0593bf 2.0.0 backport: Fixed HOG archiver sorting/lookups (thanks Chris!) 2005-01-05 05:16:53 +00:00
Ryan C. Gordon df02d9722d Fixed some documentation/header comment typos (thanks, Gaetan!) 2004-12-16 16:25:42 +00:00
Ryan C. Gordon a63b842e24 CFLAGS fix backported from devbranch. 2004-10-30 23:47:00 +00:00
Ryan C. Gordon 791d52465c Removed .cvsignore files 2004-10-30 09:59:38 +00:00
Ryan C. Gordon 4b036dc0a2 strcpy/strcat fix, backported from devbranch. 2004-10-30 09:57:56 +00:00
Ryan C. Gordon c5bf5c15d7 PHYSFS_file is now PHYSFS_File to match 2.0 API (but has a typedef for
legacy support).
2004-09-26 13:37:42 +00:00
Ryan C. Gordon 7521634ee6 Updated. 2004-09-21 17:36:50 +00:00
Ryan C. Gordon 58fac19bb4 Backported buffered seeking fix from dev branch. 2004-09-21 17:34:27 +00:00
Ryan C. Gordon 969bf3d341 MacOSX build fix, backported from development branch. 2004-09-21 17:30:23 +00:00
Ryan C. Gordon c495f050e6 Forked stable 1.0 branch. 2004-09-21 17:27:55 +00:00
Ryan C. Gordon d43ca254c1 Last minute changes, fixes, and build system updates for 1.0. 2004-01-08 05:53:28 +00:00
Ryan C. Gordon 19f5b8651d Updated. 2004-01-08 05:52:41 +00:00
Ryan C. Gordon dd3008f799 Initial add. 2003-12-29 11:16:52 +00:00
Ryan C. Gordon 24c8651f7f Patches to get this building on Mac Classic again. 2003-12-29 08:50:21 +00:00
Ryan C. Gordon 56606fa65c Updated. 2003-12-29 08:49:58 +00:00
Ryan C. Gordon 81c06f3c9e Renamed from CWProjects.sit...moved from CodeWarrior 6 to 7, and archived with
Stuffit 8.0.2 (SITX format). Other tweaks in preparation for 1.0 release.
2003-12-29 08:46:28 +00:00
Ryan C. Gordon ee41546b4c Replaced by CWProjects.sitx 2003-12-29 07:44:18 +00:00
Ryan C. Gordon 46fe99b378 Minor OS/2 build tweak. 2003-12-29 07:42:51 +00:00
bhook 86dc6d9ebc Converted VC6 project to use zlib121, fixed some link warnings that
Z_PREFIX=1 missed by default, enabled Z_PREFIX=1 by default in VC6
dsp file, updated changelog.
2003-12-22 18:19:09 +00:00
Ryan C. Gordon 02866267d5 Updated. 2003-12-22 17:12:51 +00:00
Ryan C. Gordon ffb2e6ca45 Fixed search-and-replace fuckup (thanks, Brian!). 2003-12-22 17:12:00 +00:00
Ryan C. Gordon 6d45e5b718 Updated. 2003-12-19 01:53:06 +00:00
Ryan C. Gordon ce799b99a8 Added zlib_license_change.txt to EXTRA_DIST. 2003-12-19 01:52:07 +00:00
Ryan C. Gordon 564d485f82 Added zlib_license_change.txt to RPM spec (thanks, Edward!) 2003-12-19 01:49:12 +00:00
Ryan C. Gordon 4bbb4ea217 Updated. 2003-12-18 19:54:41 +00:00
Ryan C. Gordon f2ebb00ef9 Says Travis Wells:
"Meh. I just realized the wad archiver isn't considering ExMx or MAPxx entries
correctly, it treats them as files,when it should consider them directories,
and place the next 11 entries in that directory.Right now it's making it
impossible to open maps, since they all have the same names, they all overlap.
So it's not very useful right now.

...

Here's the patch to wad.c, it should now correctly place the map-files into
subdirectories."

Thanks, Travis!
2003-12-18 19:53:20 +00:00
Ryan C. Gordon efdc4ac8a6 Added Doom WAD support. 2003-12-15 04:01:18 +00:00
Ryan C. Gordon 3a5f64ff06 Updated. 2003-12-15 04:00:53 +00:00
Ryan C. Gordon f6234dbc2a Updated. 2003-12-08 12:38:10 +00:00
Ryan C. Gordon 9ac33cdcbe Fixed Win32 seeking on > 2gig files, other Cygwin issues. 2003-12-08 12:37:58 +00:00
Ryan C. Gordon 4e58f93af9 Updated 2003-12-07 05:39:54 +00:00
Ryan C. Gordon cd08ed589b Make physfs itself not link against readline and ncurses (just
test_physfs).
2003-12-07 05:39:23 +00:00
Ryan C. Gordon caf828b73d Updated. 2003-12-07 05:30:06 +00:00
Ryan C. Gordon c7fb2e4cba Upgraded internal zlib to 1.2.1 (thanks, Adam!) 2003-12-07 05:29:20 +00:00
bhook e3e3270b0f *** empty log message *** 2003-12-04 07:20:32 +00:00
Ryan C. Gordon 4f0b5d6e47 Updated. 2003-11-11 14:11:00 +00:00
Ryan C. Gordon 1822399aec Patched to compile on OS/2. 2003-11-11 14:08:32 +00:00
Ryan C. Gordon e04c24cbcd Updated. 2003-11-09 21:07:12 +00:00
Ryan C. Gordon 9dcb15fa2c Made QPAK archiver case insensitive again. 2003-11-09 21:06:15 +00:00
Ryan C. Gordon 09ef260209 Added internal function __PHYSFS_platformStrnicmp(). 2003-11-09 20:59:07 +00:00
Ryan C. Gordon 13d6a130fd Updated. 2003-09-13 02:30:55 +00:00
Ryan C. Gordon f49ab5f7d4 Updated. 2003-08-26 19:43:17 +00:00