Switch to "VAR in (...)" style in the code.
This is shorter and slightly simpler (it's clear only a single
variable value is being considered).
This eliminates many pylint warnings and
produces a minor improvement in the pylint score.
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Fix the source package.
We recently renamed "flawfinder" to "flawfinder.py" in the
source tree, but the "distribute" target then removes because
previously "flawfinder.py" wasn't the "real thing".
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Update test correct answers because we have a new version
number by repeatedly running:
make check; make test-is-correct
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
The --error-level option is useful in continuous integration (CI)
pipelines. Make it even more obvious in the documentation.
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
My SINCERE THANKS to yongyan-gh for the hard work to integrate
SARIF output functionality into flawfinder!!
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Flawfinder has a project-specific rule to put all code in one file.
That can be a pain for development, but the rule makes *deploying*
flawfinder really easy in some settings. Worse comes to worse, just
copy the file somewhere and you can run it!
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Modify "make install" to quote filenames
(in case a directory has a space in it), and
on Linux/Unix force the program's permissions to be executable.
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
Git patch format is slightly different from unified diff / svn diff.
The hunk format changes, and the function name is added after the last
@@. The regex has to be changed to ensure the hunk is recognized, so the
line numbers are correct.
As decribed in https://click.palletsprojects.com/en/7.x/setuptools/ shebangs only work in
unix and OSX (and in cygwin on windows). By using the entry_points mechanism
Python will handle all cross-platform issues making it useable for everybody.
Ignore LoadLibraryEx if its third parameter is
LOAD_LIBRARY_SEARCH_SYSTEM32, as this is safe.
This eliminates a false positive.
See:
https://github.com/david-a-wheeler/flawfinder/issues/26
Signed-off-by: David A. Wheeler <dwheeler@dwheeler.com>
David A. Wheeler
Greg Myers
Yong Yan
Robin Geffroy
Ben Spoor
Daniel Paul Searles
Charles Milette