41011a6ed7
Fix compiler warning about value unused
2010-04-28 13:33:09 -04:00
863df68e89
[object] Make debug code always available to the compiler
...
Such that we don't break debug build all the time.
2010-04-28 13:29:55 -04:00
1d52151a19
Minor
2010-04-28 13:20:31 -04:00
444fffb1ab
[blob] Make debug code always available to the compiler
...
Such that we don't break debug build all the time.
2010-04-28 13:16:38 -04:00
ba51b25c7b
Fix build. Ouch!
2010-04-28 13:10:36 -04:00
a92f0fda7f
Fix debug build
2010-04-28 13:09:40 -04:00
c165f25410
[object] Actually handle malloc() failure
...
Caught by John Daggett.
2010-04-27 23:28:10 -04:00
caff7db93d
Fix Device::get_size() calculation
2010-04-26 10:07:35 -04:00
66d6eb30eb
Rename Var to Obj
2010-04-25 23:01:45 -04:00
690b919461
Remove use of flexible arrays
...
Also remove wrong ASSERT_SIZE that would trigger only when not using
flexible arrays (which was the case on win32, but not with gcc).
2010-04-25 22:52:22 -04:00
1cebfbb063
Cleanup hb_face_create_for_data()
2010-04-23 20:49:18 -04:00
d6b3c83a90
Allow get_table() to return NULL
2010-04-23 19:59:53 -04:00
ad3653751b
Typo
2010-04-23 19:43:40 -04:00
990443e5f2
Remove lock_instance()
2010-04-23 17:53:32 -04:00
187454c595
Add different casts from pointer and ref to avoid bugs
2010-04-23 17:44:28 -04:00
efb324a46f
Remove GET_FOR_DATA macros
...
The major-version check is now handled by sanitize. If major
doesn't match, we reject and fall back to the Null object.
2010-04-23 16:28:27 -04:00
f1aaa2a436
Add TODO
2010-04-23 15:19:50 -04:00
33d4d4325e
Zero glyph metrics before calling user callback
2010-04-23 14:56:55 -04:00
4206e9511a
More warning fixes
2010-04-23 14:54:01 -04:00
ef66ebeabc
Remove unused parameter
2010-04-23 14:40:36 -04:00
1d720192b1
Fix compile warnings (HB_GNUC_UNUSED)
2010-04-23 14:39:10 -04:00
8dfdca599c
No need to keep blob in sanitize context
2010-04-23 14:07:34 -04:00
254933c397
When sanitizing, delay making writable
...
Before, as soon as we needed to make an edit, we tried to make the blob
writable inplace. That grows code unnecessarily though. We can simply
fail, make writable, then start again. That's indeed what the fallback
was doing anyway.
2010-04-23 13:57:10 -04:00
71e735e915
[blob] Fallback to copying if mprotect() fails
2010-04-23 13:48:06 -04:00
1aa4666b91
Cleanup OpenTypeFontFile
2010-04-23 13:32:03 -04:00
ae4190cafe
Properly define separate structs for TTCHeader and TTCHeaderVersion1
2010-04-23 12:33:02 -04:00
a065f471b3
Cleanup Extension lookups
...
Two things:
1. Allow nested Extension lookups. The offset is always positive, so
it can't loop circularly.
2. Move the check for all Extension subtables having the same lookup
type to the correct place. Before it wasn't really working.
2010-04-22 20:15:11 -04:00
a0bb49c583
Add comment re bsearch effect on sanitize
2010-04-22 18:47:03 -04:00
d632ec4000
Cosmetic
2010-04-22 18:42:05 -04:00
a3263aa773
Convert the last set of cast macros to templates
2010-04-22 18:42:01 -04:00
c38188a191
Remove unused macro
2010-04-22 16:52:09 -04:00
3b2c2df41b
Cleanup Extension sanitize()
2010-04-22 16:51:42 -04:00
1856184b93
Fail sanitize on major version mismatch
...
We handle major-version differences via get_for_data(), so sanitize
should never see a major version mismatch.
2010-04-22 14:21:17 -04:00
df3f505dcf
More sanitize cleanup
2010-04-22 14:11:33 -04:00
278a91f0cd
Minor cleanup of sanitize
...
Done with an audit of all sanitize()
2010-04-22 13:59:39 -04:00
9ac7dc73bc
Check for (impossible) overflow
2010-04-22 13:50:22 -04:00
9fc8684fd8
Cleanup ContextFormat3 sanitize
2010-04-22 13:37:58 -04:00
e77302c61f
Add comment
2010-04-22 13:34:00 -04:00
7c469c3ca4
Minor
2010-04-22 13:26:21 -04:00
dc228048a8
Remove integrity check in Tag sanitize
...
Serves no useful purpose.
2010-04-22 13:22:41 -04:00
8015a8c762
Don't sanitize raw table data
...
That part is performed by individual table sanitize.
2010-04-22 13:21:12 -04:00
c293581e96
Add coment
2010-04-22 11:20:28 -04:00
1faa76c6e8
Remove unnecessary casts
2010-04-22 10:54:26 -04:00
079dc40112
Avoid overflow in TableDirectory sanitize
2010-04-22 10:47:12 -04:00
fb5904ec93
Make casts more explicit
2010-04-22 10:43:30 -04:00
565c80bd29
Make sure semicolon is expected after DEFINE_NULL_DATA()
2010-04-22 10:26:35 -04:00
bb1e16335e
Improve Subst/Pos SubTable access and sanitize
2010-04-22 01:01:35 -04:00
81f2af40f9
Simplify Extension offset now that our int types have no alignment
2010-04-22 00:58:49 -04:00
19828ad42d
Sanitize shallow in Lookup since the generic SubLookup has no methods
2010-04-22 00:50:19 -04:00
e5546a4352
Watch for overflow in Array sanitize
2010-04-22 00:48:54 -04:00
4f5f1c34dd
Rename const_sub_array to sub_array since all consts are implicit now
2010-04-22 00:27:39 -04:00
0795b784dd
Cosmetic
2010-04-22 00:23:14 -04:00
2d98d3bbaa
Simplify Lookup sanitize
2010-04-22 00:19:30 -04:00
c755cb3e3a
Change header comment
2010-04-22 00:11:43 -04:00
243d20e011
More cast simplification
2010-04-21 23:57:01 -04:00
0dfcc13a46
Rename ConstCharP to CharP (overloaded now)
2010-04-21 23:41:26 -04:00
62c0fd7573
Cleanup de-const-casting during sanitize
2010-04-21 23:30:48 -04:00
dd15587056
Add more comments
2010-04-21 23:13:33 -04:00
c85c362067
Add comment
2010-04-21 23:12:54 -04:00
2467c669c2
Add comment
2010-04-21 23:11:45 -04:00
29c3f5e1b6
Improve comment
2010-04-21 23:01:00 -04:00
01c01618e9
Further simplify IntType struct defs
2010-04-21 22:49:56 -04:00
2cb08458f6
Rename const_array() to array() (overloaded)
2010-04-21 22:37:31 -04:00
2e2f43edf2
Remove ArrayAfter, use StructAfter in place
2010-04-21 22:30:36 -04:00
e961c86c57
Convert NEXT() and ARRAY_AFTER() macros to templates
2010-04-21 15:56:11 -04:00
198facdc55
Use templates for const char * casts
2010-04-21 13:35:36 -04:00
1922ffe701
Const correctness
2010-04-21 04:52:11 -04:00
e032ed9f75
Use templates for defining int typess
2010-04-21 04:51:55 -04:00
2c9fd2adce
Remove unused macro
2010-04-21 02:15:39 -04:00
7a52f28117
Rename macros
2010-04-21 02:14:44 -04:00
ffff7dc44c
Minor
2010-04-21 02:13:55 -04:00
f60f2166c4
Move macros around
2010-04-21 02:12:45 -04:00
649a4344ca
Remove unused macros
2010-04-21 02:11:59 -04:00
eba8b4f644
GNOME Bug 613015 - [HB] Does not sanitize Device tables referenced from ValueRecords
2010-04-21 02:04:02 -04:00
673a4efcbc
WIP
2010-04-21 02:02:57 -04:00
40d73bc68d
Improve comments
2010-04-21 01:55:20 -04:00
394bad41a7
Remove stale TODO item
2010-04-21 01:55:17 -04:00
9d3677899f
Use a function template instead of struct template for Null
2010-04-21 01:55:12 -04:00
ffd321afd9
Simplify Tag struct
2010-04-21 01:55:09 -04:00
00e23fcc6f
Cosmetic
2010-04-21 01:55:03 -04:00
a87072db5d
Fix Class operator return type
2010-04-21 01:54:57 -04:00
f9b3772798
Add couple consts to operators
2010-04-21 01:54:53 -04:00
53d237ec63
Remove ASSERT_SIZE_DATA
2010-04-21 01:54:49 -04:00
06558d2a74
Round instead of trunc
2010-04-21 01:50:15 -04:00
0e206de986
Fix warnings
2010-04-21 01:48:41 -04:00
d5943407a4
Fix debug build
2010-04-21 01:42:11 -04:00
12b27ed91d
Fix leak when duplicating blob
2010-04-21 01:41:53 -04:00
4b8487d83e
Fix the mystery bug!
...
A couple bugs joined forces to exhibit the mystery behavior of
crashes / infinite loops on OS X / wrong kerning / invalid memory
access. Pooh!
The bugs were involved:
- Wrong pointer math with ValueRecord in PairPosFormat1
- Fallout from avoiding flex arrays, code not correctly updated
to remove sizeof() usage.
We strictly never use sizeof() directly now. And the PairPos code
is cleaned up. Should fix them all. Bugs are:
Bug 605655 - Pango 1.26.2 introduces kerning bug
Bug 611229 - Pango reads from uninitialized memory
Bug 593240 - (pangoosx) Crash / infinite loop with Mac OS X
We were also doing wrong math converting Device adjustments to
hb_position_t. Fallout from FreeType days. Should shift 16, not
6. Fixed that too.
There's still another bug: we don't sanitize Device records
referenced from value records. Fixing that also.
2010-04-21 01:41:29 -04:00
9b39755d10
Typo
2010-04-15 14:00:25 -04:00
f85ec1c7da
Cosmetic
2010-03-10 04:14:40 -05:00
e48ed72230
[ft] Check stream->read instead of stream->base
...
The former is more robust. See discussion on freetype-devel.
2010-03-01 22:33:45 -05:00
917c227500
Make blob unlocking 64bit-safe
...
GNOME Bug 604128 - Applications crash when displaying Hebrew characters
2010-02-23 16:47:51 -05:00
ecd2e996d2
Improve the alignment for NullPool
2010-02-23 02:42:00 -05:00
bc7830e425
Use __attribute__((unused)) only with gcc 4 and later
...
See discussion at:
https://bugzilla.gnome.org/show_bug.cgi?id=610183
2010-02-17 15:14:57 -05:00
555d11273e
[GDEF] Fix bug in building synthetic GDEF
2010-01-26 12:58:59 -05:00
cd11a98fa1
Fix compile with older FreeType
2009-12-20 23:05:02 +01:00
7f7448a354
Indent
2009-12-20 21:42:14 +01:00
e70f45eb52
Revert "Fallback to 'kern' if no GPOS applied"
...
This reverts commit d740c8f78b
2009-12-20 21:26:24 +01:00
d740c8f78b
Fallback to 'kern' if no GPOS applied
2009-12-20 21:23:56 +01:00
2f78c17197
Remove glibism!
2009-12-20 21:03:11 +01:00
907e67da13
Oops, add file.
2009-12-20 20:59:51 +01:00
2014b8d110
Hook OpenType shaping up
...
Default features only for now.
2009-12-20 20:58:26 +01:00
196610ba4c
Pass features down
2009-12-20 19:02:23 +01:00
51f141a7f3
Avoid overflow
2009-12-20 18:22:52 +01:00
26d7a75752
Refactor hb_shape a bit
2009-12-20 17:58:25 +01:00
001fc2d2aa
Add TrueType kern support
2009-12-20 17:24:05 +01:00
2c1b85cf66
Direct unicode->get_mirroring directly
2009-12-20 16:29:17 +01:00
6a2ef5aa54
Do mirroring
2009-12-20 16:28:01 +01:00
0465e69832
Protect against NULL funcs
2009-12-20 16:25:18 +01:00
5ceefa1d8d
Add hb_unicode_get_*() functions
2009-12-20 15:29:16 +01:00
b8a53e44ce
We'll have to link to libstdc++ if linking to ICU, so disable test for now
...
We have to get rid of the ICU in main lib. Still thinking about best way
to do it.
2009-12-20 14:56:25 +01:00
314905d754
Explicitly track whether the buffer has positions
2009-12-20 14:50:42 +01:00
314b460d8a
Add HB_DIRECTION_IS_FORWARD/BACKWARD
2009-12-20 13:58:50 +01:00
bdd0ff5290
Make main.cc compile without glib
2009-12-15 04:07:40 -05:00
807b8aa486
Another C++ strictness fix
...
Pango Bug 602408 - Invalid C++ code breaks compile with Sun C++ Compiler
(Error: A union member cannot have a user-defined assignment operator)
According to the bug:
C++ Programming Language by Bjarne Stroustrup: Chapter 10.4.12 forbids
explicitly using of union members with constructors, destructors or assignment
operations.
So we use a set() method instead of the assignment operator. Ugly, but hey,
that's life.
2009-11-19 20:35:01 -05:00
8b9b866d3e
Fix warning
2009-11-19 20:27:57 -05:00
c65b26acf2
Use autoconf FLEXIBLE_ARRAY_MEMBER when available
2009-11-18 11:27:33 -05:00
d33f674cb7
Add Mongolian variation selectors
2009-11-18 09:47:44 -05:00
d6387757de
Fix sanitize
2009-11-11 17:15:03 -05:00
636f017e38
Remove obsolete TODO item
2009-11-10 12:56:35 -05:00
bf2b25dd85
Remove done item
2009-11-06 19:52:47 -05:00
4a86053159
Reverse buffer at the end if RTL
2009-11-06 19:52:01 -05:00
ff44f88df2
Handle shaping in non-native direction
2009-11-06 19:48:16 -05:00
b4b4272c8d
Oops, wrong change
2009-11-06 17:46:33 -05:00
52ea47767c
Change order of font and face for API consistency
2009-11-06 17:45:38 -05:00
f4f1fc970b
Remove debug info that crept in
2009-11-06 17:42:38 -05:00
aa196d6026
[GSUB] More ligature/component fixing
...
We can only reuse the ligid if it belongs to a previous ligature, not a
component!
2009-11-06 17:23:31 -05:00
25e7ef7046
Add _hb_buffer_add_output_glyphs() that takes codepoint_t*
2009-11-06 17:21:01 -05:00
9db8ad7531
Add hb_ot_layout_position_finish()
...
We expect buffer to be setup with default positions before GPOS.
2009-11-06 16:47:31 -05:00
edb54e9aec
Fix FT_Face finalizer call
2009-11-06 15:19:22 -05:00
3d14528b8b
Rename hb_buffer_get_len() to hb_buffer_get_length()
2009-11-06 15:13:17 -05:00
1ff7775051
Minor.
2009-11-06 13:52:57 -05:00
3648bdf5b2
Fix FT_Face generic finalizer
2009-11-05 20:17:53 -05:00
5a11c875d8
Cosmetic
2009-11-05 20:08:17 -05:00
44533e773f
Fix warning
2009-11-05 19:58:02 -05:00
bcc0406a52
include errno.h
2009-11-05 19:54:23 -05:00
799b3c375a
Add debugging to object lifecycle
2009-11-05 19:37:58 -05:00
25edb940ab
Cosmetic
2009-11-05 19:20:06 -05:00
850dc5bb55
Return 0 from get_glyph_nil
2009-11-05 18:26:52 -05:00
85555a9533
Initialize font->klass
2009-11-05 18:25:56 -05:00
bcd26bd7b1
Add TODO item
2009-11-05 18:03:26 -05:00
f4281e0a92
Fix ref counting
2009-11-05 17:58:41 -05:00
6358ff45ae
Add hb_ft_face_create_cached
2009-11-05 17:39:16 -05:00
2027f74b28
Add default positioning to hb-shape
2009-11-05 16:34:47 -05:00
c3f9f7e59d
Fix MarkMark issue with ligid and components
2009-11-05 16:16:14 -05:00
d0351314cd
Include stdio.h if debugging
2009-11-05 16:16:06 -05:00
2e33669291
Add hb_font_get_*
2009-11-05 13:55:41 -05:00
9bef3611f0
Rename [xy]_pos to [xy]_offset since we don't accumulate positions
2009-11-05 12:20:11 -05:00
2daa47e9cd
Cosmetic
2009-11-05 12:08:34 -05:00
2f50d87368
Start filling hb_shape() in
2009-11-04 21:07:03 -05:00
ae070b7d39
Add script and language to buffer
2009-11-04 20:29:54 -05:00
8a3511ac6c
Add hb_language_t as well as language/script conversion to OT tags
2009-11-04 19:45:39 -05:00
4591753ad4
Define ARRAY_LENGTH
2009-11-04 18:15:59 -05:00
214ac7c1ff
Another one
2009-11-04 18:12:32 -05:00
1e91434569
Minor
2009-11-04 18:12:09 -05:00
48de3730cd
Fix previous commit, ouch!
2009-11-04 16:59:50 -05:00
e21899bc35
Fix array query API
...
The array query APIs now all do:
- Return the total number of items
- Take a start_offset, such that individual items can be fetched
- The _count IN/OUT variable always has number of items written
into the array upon return of the function
2009-11-04 16:36:14 -05:00
3b59306b85
Finish FT glue. Rough and untested
2009-11-04 15:48:32 -05:00
7951279b4a
Implement nil font functions
2009-11-03 20:27:05 -05:00
8fb3d1aa4e
Start ft glue
2009-11-03 18:34:20 -05:00
d94647e2cd
Add ICU glue
2009-11-03 16:35:10 -05:00
b7dd4b945b
Fix hb_be_uint16()
2009-11-03 15:21:15 -05:00
cd7555eef2
Namespace MSVC defines in public header
2009-11-03 15:16:10 -05:00
5ebabecef3
Move unicode_funcs to buffer
2009-11-03 15:15:07 -05:00
d5a8e46099
[Makefile] Install hb-unicode.h
...
Separate OT headers also.
2009-11-03 15:14:40 -05:00
21d0fce3d5
Add check for not linking to libstdc++
2009-11-03 14:28:32 -05:00
ca95ce460a
Use the C linker, not C++ linker
...
Such that we don't link to libstdc++.
2009-11-03 14:18:33 -05:00
ffbe0a853d
More MSVC fixes from Jonathan Kew
2009-11-03 10:52:45 -05:00
d3480ba37f
Don't use zero-sized arrays
...
It's not part of the standard and MSVC doesn't like it. It makes the code
a lot less elegant than it used to be, but I think it should work now.
2009-11-03 10:47:29 -05:00
6bec81aa3a
Cosmetic
2009-11-02 19:17:36 -05:00
2f3e69f3cb
Fix build without glib, again
2009-11-02 18:53:15 -05:00
63a792a811
Update Makefile to build without glib
2009-11-02 18:34:26 -05:00
68a2c771e2
Build without glib
...
Thready-safety disabled in that case, until we add support for pthread, etc.
Fun...
2009-11-02 18:31:53 -05:00
cc4c096a7e
MSVC has no stdint.h
2009-11-02 18:14:48 -05:00
9a204c7ab5
Remove use of GINT16_FROM_BE
2009-11-02 18:11:55 -05:00
1f0ceeb8cf
Install library
2009-11-02 16:51:24 -05:00
29aa400183
Add build system
2009-11-02 16:34:59 -05:00
c09ed9801e
[HB] Add glyph_metrics typedef
2009-11-02 14:40:48 -05:00
91b1e03e03
[HB] Add point_index to get_contour_point()
...
Pointed out by Keith Stribley on HarfBuzz list.
2009-11-02 14:40:48 -05:00
aa87d95173
[HB] Fix lookup_flag ignoring
...
Reported by Keith Stribley on HarfBuzz list.
2009-11-02 14:40:48 -05:00
52e9a71d57
[HB] Add comment
2009-11-02 14:40:48 -05:00
f9c0a2dad0
[HB] Fix apply_lookup() loop
...
Part of Bug 595539 - Regressions in rendering certain Thai sequences with
OpenType font
2009-11-02 14:40:48 -05:00
c0ab43c058
[HB] Fix bug in chain_context_lookup() invocations
...
Part of Bug 595539 - Regressions in rendering certain Thai sequences with
OpenType font
2009-11-02 14:40:48 -05:00
e6bd4e93bd
[HB] Add TODO item
2009-11-02 14:40:48 -05:00
3e2401f6c5
[HB] Rename DEBUG to TRACE where appropriate
2009-11-02 14:40:48 -05:00
0535b50f43
[HB] Add GSUB/GPOS tracing
2009-11-02 14:40:48 -05:00
95e202403f
[HB] Allow enabling different debug facilities individually
2009-11-02 14:40:48 -05:00
37006bd1bd
Fix stupid array growing bug
2009-11-02 14:40:47 -05:00
9897749113
[HB] Simplify counting
2009-11-02 14:40:47 -05:00
81a5c4df94
[HB] Indent
2009-11-02 14:40:47 -05:00
c91facd83b
[HB] Bug 593231 - < c99 compiler dislikes ValueRecord
2009-11-02 14:40:47 -05:00
f0c7540c4e
Bug 592484 - invalid write in HB
...
Fix off-by-one.
2009-11-02 14:40:47 -05:00
b614b00472
[HB][glib] Make glib unicode funcs static
2009-11-02 14:40:47 -05:00
8b53461304
[HB] Fix more casts
2009-11-02 14:40:47 -05:00
9d2e02db74
[HB] Rename CAIRO_ in macro prefix to HB_
...
Hiss!
2009-11-02 14:40:46 -05:00
388ad037ff
[HB] Remove HB_MEMORY_MODE_READONLY_NEVER_DUPLICATE
...
Unlike the rest of the memory-mode enum, this one didn't only
describe the access mode of the input memory region. Remove it.
If someone wants to inhibit duplicating, they can lock the blob
and throw away the key.
Based on mailing list discussion with Carl Worth.
2009-11-02 14:40:46 -05:00
977eeb7144
[HB] s/writeable/writable/g
2009-11-02 14:40:46 -05:00
2f5931e404
[HB] Hide lig_id and component members of hb_glyph_info_t
2009-11-02 14:40:46 -05:00
6b600dd619
[HB] Fix typo
2009-11-02 14:40:45 -05:00
32c65a5ca3
[HB] Add font funcs prototypes
2009-11-02 14:40:45 -05:00
Behdad Esfahbod