b435ab7e29
Fix accessing tables from NULL pointer
2010-05-10 19:51:57 -04:00
fd671e0243
Remove unused macro
2010-05-10 19:02:32 -04:00
0eb9fc6e37
Change DEFINE_SIZE_VAR to DEFINE_SIZE_ARRAY
2010-05-10 19:01:17 -04:00
596e471aa5
Cleanup DEFINE_SIZE_VAR2
2010-05-10 18:48:29 -04:00
33afa4e2dc
Minor
2010-05-10 18:35:02 -04:00
b961518b96
Simplify array access
2010-05-10 18:20:54 -04:00
54842374c2
Fix check_struct to check min_size instead of sizeof
2010-05-10 18:13:32 -04:00
ed07422c33
Further cleanup of sizeof
2010-05-10 18:08:46 -04:00
a82ef7a893
Remove CastP completely
2010-05-10 17:55:03 -04:00
40cbefe858
Remove unnecessary casts
2010-05-10 17:47:22 -04:00
09766b1ec5
Make StructAtOffset take a pointer
...
Is safer.
2010-05-10 17:36:03 -04:00
bea34c7cbb
Further cleanup of DEFINE_SIZE
2010-05-10 17:28:16 -04:00
0abcc3b48c
Cleanup
2010-05-10 17:04:20 -04:00
b3651231bf
Remove ASSERT_SIZE in favor of the safer DEFINE_SIZE_STATIC
2010-05-10 16:59:57 -04:00
569da92bc6
Cleanup ASSERT_SIZE_VAR
2010-05-10 16:46:36 -04:00
65f46b0033
Simplify DEFINE_NULL_DATA
...
Using ::min_size.
2010-05-06 19:35:19 -04:00
e45d3f86f9
Start cleaning up get_size()
...
So we know when the size is static and when dynamic.
2010-05-06 19:33:31 -04:00
b157617644
Remove the last of SANITIZE macros: SANITIZE_SELF
2010-05-06 14:48:27 -04:00
4f252fedc7
Remove SANITIZE macro
2010-05-06 13:30:23 -04:00
41a93d2c1f
Remove SANITIZE_WITH_BASE
2010-05-06 12:55:14 -04:00
f5fab0c718
Remove SANITIZE_MEM
2010-05-06 10:26:52 -04:00
4ad2cc5dec
Rename check to check_range
2010-05-06 09:24:56 -04:00
1cd1e117d0
Remove SANITIZE_ARRAY
2010-05-05 20:15:14 -04:00
583d7f9586
Cosmetic
2010-05-05 01:49:22 -04:00
705e215268
Minor
2010-05-05 01:40:25 -04:00
b18eafd0f6
Minor
2010-05-05 01:39:26 -04:00
27e302dc8e
I keep changing my mind about this
2010-05-05 00:26:16 -04:00
39840474af
Remove SANITIZE_ARG_DEF and SANITIZE_ARG
2010-05-05 00:23:19 -04:00
b261e2ad5c
Remove trace from sanitize_shallow()
2010-05-05 00:20:16 -04:00
dfc8cbe854
Add hb_trace_t
2010-05-05 00:19:46 -04:00
20e3dd5d29
Make sanitize_depth variable automatic and not passed through function args
2010-05-04 23:32:49 -04:00
4a446ac351
Use function template for pass-thru argument
2010-05-04 22:56:20 -04:00
98daaf183d
Make _hb_sanitize_*() methods of the context object
2010-05-04 22:42:49 -04:00
bb029af943
Remove SANITIZE_THIS
2010-05-04 15:28:52 -04:00
2226fc93d1
Rename SANITIZE_BASE to SANITIZE_WITH_BASE
2010-05-04 15:12:17 -04:00
89da1346ec
Remove SANITIZE_OBJ
2010-05-04 15:01:45 -04:00
4d4cce9626
Remove SANITIZE_THIS2
2010-05-04 14:57:55 -04:00
be74284673
Remove SANITIZE_THIS3
2010-05-04 14:47:05 -04:00
fbab9f9bd8
Remove SANITIZE_BASE2
2010-05-04 14:42:10 -04:00
73c7dbf7f5
Remove SANITIZE2
2010-05-04 14:40:55 -04:00
c9f14687a3
Remove the NEUTER macro, move code to a method
2010-05-04 14:38:08 -04:00
30fa2821c2
Make internal method private
2010-05-04 14:28:18 -04:00
64d3fc8d0d
Cosmetic: Rename HB_LIKELY/HB_UNLIKELY to likely/unlikely
2010-05-03 22:51:19 -04:00
fa3b3d5844
Mark a couple functions as inline
2010-05-03 22:47:22 -04:00
6b84198f9d
Merge remote branch 'jrmuizel/master'
2010-05-03 22:46:52 -04:00
eaf29edb8f
HB_UNUSED is unneeded on static inline functions
2010-05-03 22:27:56 -04:00
f0abcd6940
Whitespace
2010-05-02 18:14:25 -04:00
33d13fdda9
Rename HB_GNUC_UNUSED -> HB_UNUSED
2010-04-29 13:56:44 -04:00
7d3a126334
Define HB_FUNC for portability to non-gcc
2010-04-29 13:54:01 -04:00
fa030175ca
[sanitize] Make debug code always available to the compiler
...
Such that we don't break debug build all the time.
2010-04-29 13:48:26 -04:00
602e4f8d55
Use const_cast
2010-04-29 02:28:54 -04:00
1376fb7bf9
[apply] Use a context object to reduce number of parameters passed around
2010-04-29 02:19:21 -04:00
173fde7087
Further simplify tracing
2010-04-29 01:47:30 -04:00
bc20045743
Simplify trace code
2010-04-29 01:40:26 -04:00
807c5b03a2
[sanitize] Make debug code always available to the compiler
...
Such that we don't break debug build all the time.
2010-04-28 23:28:07 -04:00
a92f0fda7f
Fix debug build
2010-04-28 13:09:40 -04:00
66d6eb30eb
Rename Var to Obj
2010-04-25 23:01:45 -04:00
ad3653751b
Typo
2010-04-23 19:43:40 -04:00
990443e5f2
Remove lock_instance()
2010-04-23 17:53:32 -04:00
187454c595
Add different casts from pointer and ref to avoid bugs
2010-04-23 17:44:28 -04:00
efb324a46f
Remove GET_FOR_DATA macros
...
The major-version check is now handled by sanitize. If major
doesn't match, we reject and fall back to the Null object.
2010-04-23 16:28:27 -04:00
f1aaa2a436
Add TODO
2010-04-23 15:19:50 -04:00
1d720192b1
Fix compile warnings (HB_GNUC_UNUSED)
2010-04-23 14:39:10 -04:00
8dfdca599c
No need to keep blob in sanitize context
2010-04-23 14:07:34 -04:00
254933c397
When sanitizing, delay making writable
...
Before, as soon as we needed to make an edit, we tried to make the blob
writable inplace. That grows code unnecessarily though. We can simply
fail, make writable, then start again. That's indeed what the fallback
was doing anyway.
2010-04-23 13:57:10 -04:00
d632ec4000
Cosmetic
2010-04-22 18:42:05 -04:00
a3263aa773
Convert the last set of cast macros to templates
2010-04-22 18:42:01 -04:00
c38188a191
Remove unused macro
2010-04-22 16:52:09 -04:00
dc228048a8
Remove integrity check in Tag sanitize
...
Serves no useful purpose.
2010-04-22 13:22:41 -04:00
c293581e96
Add coment
2010-04-22 11:20:28 -04:00
1faa76c6e8
Remove unnecessary casts
2010-04-22 10:54:26 -04:00
565c80bd29
Make sure semicolon is expected after DEFINE_NULL_DATA()
2010-04-22 10:26:35 -04:00
e5546a4352
Watch for overflow in Array sanitize
2010-04-22 00:48:54 -04:00
4f5f1c34dd
Rename const_sub_array to sub_array since all consts are implicit now
2010-04-22 00:27:39 -04:00
c755cb3e3a
Change header comment
2010-04-22 00:11:43 -04:00
243d20e011
More cast simplification
2010-04-21 23:57:01 -04:00
0dfcc13a46
Rename ConstCharP to CharP (overloaded now)
2010-04-21 23:41:26 -04:00
62c0fd7573
Cleanup de-const-casting during sanitize
2010-04-21 23:30:48 -04:00
dd15587056
Add more comments
2010-04-21 23:13:33 -04:00
c85c362067
Add comment
2010-04-21 23:12:54 -04:00
2467c669c2
Add comment
2010-04-21 23:11:45 -04:00
29c3f5e1b6
Improve comment
2010-04-21 23:01:00 -04:00
01c01618e9
Further simplify IntType struct defs
2010-04-21 22:49:56 -04:00
2cb08458f6
Rename const_array() to array() (overloaded)
2010-04-21 22:37:31 -04:00
2e2f43edf2
Remove ArrayAfter, use StructAfter in place
2010-04-21 22:30:36 -04:00
e961c86c57
Convert NEXT() and ARRAY_AFTER() macros to templates
2010-04-21 15:56:11 -04:00
198facdc55
Use templates for const char * casts
2010-04-21 13:35:36 -04:00
e032ed9f75
Use templates for defining int typess
2010-04-21 04:51:55 -04:00
2c9fd2adce
Remove unused macro
2010-04-21 02:15:39 -04:00
7a52f28117
Rename macros
2010-04-21 02:14:44 -04:00
40d73bc68d
Improve comments
2010-04-21 01:55:20 -04:00
394bad41a7
Remove stale TODO item
2010-04-21 01:55:17 -04:00
9d3677899f
Use a function template instead of struct template for Null
2010-04-21 01:55:12 -04:00
ffd321afd9
Simplify Tag struct
2010-04-21 01:55:09 -04:00
00e23fcc6f
Cosmetic
2010-04-21 01:55:03 -04:00
f9b3772798
Add couple consts to operators
2010-04-21 01:54:53 -04:00
53d237ec63
Remove ASSERT_SIZE_DATA
2010-04-21 01:54:49 -04:00
0e206de986
Fix warnings
2010-04-21 01:48:41 -04:00
d5943407a4
Fix debug build
2010-04-21 01:42:11 -04:00
4b8487d83e
Fix the mystery bug!
...
A couple bugs joined forces to exhibit the mystery behavior of
crashes / infinite loops on OS X / wrong kerning / invalid memory
access. Pooh!
The bugs were involved:
- Wrong pointer math with ValueRecord in PairPosFormat1
- Fallout from avoiding flex arrays, code not correctly updated
to remove sizeof() usage.
We strictly never use sizeof() directly now. And the PairPos code
is cleaned up. Should fix them all. Bugs are:
Bug 605655 - Pango 1.26.2 introduces kerning bug
Bug 611229 - Pango reads from uninitialized memory
Bug 593240 - (pangoosx) Crash / infinite loop with Mac OS X
We were also doing wrong math converting Device adjustments to
hb_position_t. Fallout from FreeType days. Should shift 16, not
6. Fixed that too.
There's still another bug: we don't sanitize Device records
referenced from value records. Fixing that also.
2010-04-21 01:41:29 -04:00
9b39755d10
Typo
2010-04-15 14:00:25 -04:00
f85ec1c7da
Cosmetic
2010-03-10 04:14:40 -05:00
ecd2e996d2
Improve the alignment for NullPool
2010-02-23 02:42:00 -05:00
807b8aa486
Another C++ strictness fix
...
Pango Bug 602408 - Invalid C++ code breaks compile with Sun C++ Compiler
(Error: A union member cannot have a user-defined assignment operator)
According to the bug:
C++ Programming Language by Bjarne Stroustrup: Chapter 10.4.12 forbids
explicitly using of union members with constructors, destructors or assignment
operations.
So we use a set() method instead of the assignment operator. Ugly, but hey,
that's life.
2009-11-19 20:35:01 -05:00
d0351314cd
Include stdio.h if debugging
2009-11-05 16:16:06 -05:00
1e91434569
Minor
2009-11-04 18:12:09 -05:00
48de3730cd
Fix previous commit, ouch!
2009-11-04 16:59:50 -05:00
d3480ba37f
Don't use zero-sized arrays
...
It's not part of the standard and MSVC doesn't like it. It makes the code
a lot less elegant than it used to be, but I think it should work now.
2009-11-03 10:47:29 -05:00
3e2401f6c5
[HB] Rename DEBUG to TRACE where appropriate
2009-11-02 14:40:48 -05:00
95e202403f
[HB] Allow enabling different debug facilities individually
2009-11-02 14:40:48 -05:00
8b53461304
[HB] Fix more casts
2009-11-02 14:40:47 -05:00
977eeb7144
[HB] s/writeable/writable/g
2009-11-02 14:40:46 -05:00
cd33cb9ed8
[HB] More minor shuffling
2009-11-02 14:40:43 -05:00
80e2aa2e1b
[HB] Move code around
2009-11-02 14:40:43 -05:00
3564ee5216
[HB] Correctly sanitize LigatureAttach
2009-11-02 14:40:43 -05:00
815a73e420
[HB] Fix possible int overflows during sanitize
2009-11-02 14:40:43 -05:00
ae728e51e9
[HB] Debug output for SANITIZE_MEM()
2009-11-02 14:40:43 -05:00
41895506cb
[HB] Use inline function for SANITIZE_MEM()
2009-11-02 14:40:43 -05:00
95528131b5
[HB] Use SANITIZE_THIS() when applicable
2009-11-02 14:40:43 -05:00
5ccf1ba339
[HB] Fixed signedness warnings
2009-11-02 14:40:41 -05:00
20b035dad4
[HB] Put C++ inline's back
...
Apparetly in C++, inline means a totally different thing.
2009-11-02 14:40:36 -05:00
284899ccbe
[HB] Add a NEXT() macro
2009-11-02 14:40:35 -05:00
7f96b39a9d
[HB] Fix bug introduced recently
2009-11-02 14:40:34 -05:00
bff3c0fde5
[HB] Remove clumsy macros and improve API
2009-11-02 14:40:34 -05:00
d0b657379b
[HB] Fix various XXX issues
2009-11-02 14:40:34 -05:00
9e826ea283
[HB] Fix unaligned access
2009-11-02 14:40:33 -05:00
71a8344a5e
[HB] Remove a few 'inline's, though the compiler mostly ignores them
2009-11-02 14:40:32 -05:00
9b76a290a9
[HB] Improve debug output
2009-11-02 14:40:32 -05:00
0d77ab8a73
[HB] Improve debug output
2009-11-02 14:40:32 -05:00
7acb389569
[HB] Improve debug output and fix mprotect bug
2009-11-02 14:40:31 -05:00
4f3ad9115a
[HB] More debugging output
2009-11-02 14:40:30 -05:00
8cd6fa28d1
[HB] Fix fatal Sanitizer bug
2009-11-02 14:40:30 -05:00
b28815c1f6
[HB] Add sanitize debugging facilities
2009-11-02 14:40:30 -05:00
7edb430f91
[HB] Rename open-types to open-type; beauty
2009-11-02 14:40:30 -05:00
Behdad Esfahbod
Jeff Muizelaar