444fffb1ab
[blob] Make debug code always available to the compiler
...
Such that we don't break debug build all the time.
2010-04-28 13:16:38 -04:00
ba51b25c7b
Fix build. Ouch!
2010-04-28 13:10:36 -04:00
a92f0fda7f
Fix debug build
2010-04-28 13:09:40 -04:00
c165f25410
[object] Actually handle malloc() failure
...
Caught by John Daggett.
2010-04-27 23:28:10 -04:00
caff7db93d
Fix Device::get_size() calculation
2010-04-26 10:07:35 -04:00
66d6eb30eb
Rename Var to Obj
2010-04-25 23:01:45 -04:00
690b919461
Remove use of flexible arrays
...
Also remove wrong ASSERT_SIZE that would trigger only when not using
flexible arrays (which was the case on win32, but not with gcc).
2010-04-25 22:52:22 -04:00
1cebfbb063
Cleanup hb_face_create_for_data()
2010-04-23 20:49:18 -04:00
d6b3c83a90
Allow get_table() to return NULL
2010-04-23 19:59:53 -04:00
ad3653751b
Typo
2010-04-23 19:43:40 -04:00
990443e5f2
Remove lock_instance()
2010-04-23 17:53:32 -04:00
187454c595
Add different casts from pointer and ref to avoid bugs
2010-04-23 17:44:28 -04:00
efb324a46f
Remove GET_FOR_DATA macros
...
The major-version check is now handled by sanitize. If major
doesn't match, we reject and fall back to the Null object.
2010-04-23 16:28:27 -04:00
f1aaa2a436
Add TODO
2010-04-23 15:19:50 -04:00
33d4d4325e
Zero glyph metrics before calling user callback
2010-04-23 14:56:55 -04:00
4206e9511a
More warning fixes
2010-04-23 14:54:01 -04:00
ef66ebeabc
Remove unused parameter
2010-04-23 14:40:36 -04:00
1d720192b1
Fix compile warnings (HB_GNUC_UNUSED)
2010-04-23 14:39:10 -04:00
8dfdca599c
No need to keep blob in sanitize context
2010-04-23 14:07:34 -04:00
254933c397
When sanitizing, delay making writable
...
Before, as soon as we needed to make an edit, we tried to make the blob
writable inplace. That grows code unnecessarily though. We can simply
fail, make writable, then start again. That's indeed what the fallback
was doing anyway.
2010-04-23 13:57:10 -04:00
71e735e915
[blob] Fallback to copying if mprotect() fails
2010-04-23 13:48:06 -04:00
1aa4666b91
Cleanup OpenTypeFontFile
2010-04-23 13:32:03 -04:00
ae4190cafe
Properly define separate structs for TTCHeader and TTCHeaderVersion1
2010-04-23 12:33:02 -04:00
a065f471b3
Cleanup Extension lookups
...
Two things:
1. Allow nested Extension lookups. The offset is always positive, so
it can't loop circularly.
2. Move the check for all Extension subtables having the same lookup
type to the correct place. Before it wasn't really working.
2010-04-22 20:15:11 -04:00
a0bb49c583
Add comment re bsearch effect on sanitize
2010-04-22 18:47:03 -04:00
d632ec4000
Cosmetic
2010-04-22 18:42:05 -04:00
a3263aa773
Convert the last set of cast macros to templates
2010-04-22 18:42:01 -04:00
c38188a191
Remove unused macro
2010-04-22 16:52:09 -04:00
3b2c2df41b
Cleanup Extension sanitize()
2010-04-22 16:51:42 -04:00
1856184b93
Fail sanitize on major version mismatch
...
We handle major-version differences via get_for_data(), so sanitize
should never see a major version mismatch.
2010-04-22 14:21:17 -04:00
df3f505dcf
More sanitize cleanup
2010-04-22 14:11:33 -04:00
278a91f0cd
Minor cleanup of sanitize
...
Done with an audit of all sanitize()
2010-04-22 13:59:39 -04:00
9ac7dc73bc
Check for (impossible) overflow
2010-04-22 13:50:22 -04:00
9fc8684fd8
Cleanup ContextFormat3 sanitize
2010-04-22 13:37:58 -04:00
e77302c61f
Add comment
2010-04-22 13:34:00 -04:00
7c469c3ca4
Minor
2010-04-22 13:26:21 -04:00
dc228048a8
Remove integrity check in Tag sanitize
...
Serves no useful purpose.
2010-04-22 13:22:41 -04:00
8015a8c762
Don't sanitize raw table data
...
That part is performed by individual table sanitize.
2010-04-22 13:21:12 -04:00
c293581e96
Add coment
2010-04-22 11:20:28 -04:00
1faa76c6e8
Remove unnecessary casts
2010-04-22 10:54:26 -04:00
079dc40112
Avoid overflow in TableDirectory sanitize
2010-04-22 10:47:12 -04:00
fb5904ec93
Make casts more explicit
2010-04-22 10:43:30 -04:00
565c80bd29
Make sure semicolon is expected after DEFINE_NULL_DATA()
2010-04-22 10:26:35 -04:00
bb1e16335e
Improve Subst/Pos SubTable access and sanitize
2010-04-22 01:01:35 -04:00
81f2af40f9
Simplify Extension offset now that our int types have no alignment
2010-04-22 00:58:49 -04:00
19828ad42d
Sanitize shallow in Lookup since the generic SubLookup has no methods
2010-04-22 00:50:19 -04:00
e5546a4352
Watch for overflow in Array sanitize
2010-04-22 00:48:54 -04:00
4f5f1c34dd
Rename const_sub_array to sub_array since all consts are implicit now
2010-04-22 00:27:39 -04:00
0795b784dd
Cosmetic
2010-04-22 00:23:14 -04:00
2d98d3bbaa
Simplify Lookup sanitize
2010-04-22 00:19:30 -04:00
c755cb3e3a
Change header comment
2010-04-22 00:11:43 -04:00
243d20e011
More cast simplification
2010-04-21 23:57:01 -04:00
0dfcc13a46
Rename ConstCharP to CharP (overloaded now)
2010-04-21 23:41:26 -04:00
62c0fd7573
Cleanup de-const-casting during sanitize
2010-04-21 23:30:48 -04:00
dd15587056
Add more comments
2010-04-21 23:13:33 -04:00
c85c362067
Add comment
2010-04-21 23:12:54 -04:00
2467c669c2
Add comment
2010-04-21 23:11:45 -04:00
29c3f5e1b6
Improve comment
2010-04-21 23:01:00 -04:00
01c01618e9
Further simplify IntType struct defs
2010-04-21 22:49:56 -04:00
2cb08458f6
Rename const_array() to array() (overloaded)
2010-04-21 22:37:31 -04:00
2e2f43edf2
Remove ArrayAfter, use StructAfter in place
2010-04-21 22:30:36 -04:00
e961c86c57
Convert NEXT() and ARRAY_AFTER() macros to templates
2010-04-21 15:56:11 -04:00
198facdc55
Use templates for const char * casts
2010-04-21 13:35:36 -04:00
1922ffe701
Const correctness
2010-04-21 04:52:11 -04:00
e032ed9f75
Use templates for defining int typess
2010-04-21 04:51:55 -04:00
2c9fd2adce
Remove unused macro
2010-04-21 02:15:39 -04:00
7a52f28117
Rename macros
2010-04-21 02:14:44 -04:00
ffff7dc44c
Minor
2010-04-21 02:13:55 -04:00
f60f2166c4
Move macros around
2010-04-21 02:12:45 -04:00
649a4344ca
Remove unused macros
2010-04-21 02:11:59 -04:00
eba8b4f644
GNOME Bug 613015 - [HB] Does not sanitize Device tables referenced from ValueRecords
2010-04-21 02:04:02 -04:00
673a4efcbc
WIP
2010-04-21 02:02:57 -04:00
40d73bc68d
Improve comments
2010-04-21 01:55:20 -04:00
394bad41a7
Remove stale TODO item
2010-04-21 01:55:17 -04:00
9d3677899f
Use a function template instead of struct template for Null
2010-04-21 01:55:12 -04:00
ffd321afd9
Simplify Tag struct
2010-04-21 01:55:09 -04:00
00e23fcc6f
Cosmetic
2010-04-21 01:55:03 -04:00
a87072db5d
Fix Class operator return type
2010-04-21 01:54:57 -04:00
f9b3772798
Add couple consts to operators
2010-04-21 01:54:53 -04:00
53d237ec63
Remove ASSERT_SIZE_DATA
2010-04-21 01:54:49 -04:00
06558d2a74
Round instead of trunc
2010-04-21 01:50:15 -04:00
0e206de986
Fix warnings
2010-04-21 01:48:41 -04:00
d5943407a4
Fix debug build
2010-04-21 01:42:11 -04:00
12b27ed91d
Fix leak when duplicating blob
2010-04-21 01:41:53 -04:00
4b8487d83e
Fix the mystery bug!
...
A couple bugs joined forces to exhibit the mystery behavior of
crashes / infinite loops on OS X / wrong kerning / invalid memory
access. Pooh!
The bugs were involved:
- Wrong pointer math with ValueRecord in PairPosFormat1
- Fallout from avoiding flex arrays, code not correctly updated
to remove sizeof() usage.
We strictly never use sizeof() directly now. And the PairPos code
is cleaned up. Should fix them all. Bugs are:
Bug 605655 - Pango 1.26.2 introduces kerning bug
Bug 611229 - Pango reads from uninitialized memory
Bug 593240 - (pangoosx) Crash / infinite loop with Mac OS X
We were also doing wrong math converting Device adjustments to
hb_position_t. Fallout from FreeType days. Should shift 16, not
6. Fixed that too.
There's still another bug: we don't sanitize Device records
referenced from value records. Fixing that also.
2010-04-21 01:41:29 -04:00
9b39755d10
Typo
2010-04-15 14:00:25 -04:00
f85ec1c7da
Cosmetic
2010-03-10 04:14:40 -05:00
e48ed72230
[ft] Check stream->read instead of stream->base
...
The former is more robust. See discussion on freetype-devel.
2010-03-01 22:33:45 -05:00
917c227500
Make blob unlocking 64bit-safe
...
GNOME Bug 604128 - Applications crash when displaying Hebrew characters
2010-02-23 16:47:51 -05:00
ecd2e996d2
Improve the alignment for NullPool
2010-02-23 02:42:00 -05:00
bc7830e425
Use __attribute__((unused)) only with gcc 4 and later
...
See discussion at:
https://bugzilla.gnome.org/show_bug.cgi?id=610183
2010-02-17 15:14:57 -05:00
555d11273e
[GDEF] Fix bug in building synthetic GDEF
2010-01-26 12:58:59 -05:00
cd11a98fa1
Fix compile with older FreeType
2009-12-20 23:05:02 +01:00
7f7448a354
Indent
2009-12-20 21:42:14 +01:00
e70f45eb52
Revert "Fallback to 'kern' if no GPOS applied"
...
This reverts commit d740c8f78b
2009-12-20 21:26:24 +01:00
d740c8f78b
Fallback to 'kern' if no GPOS applied
2009-12-20 21:23:56 +01:00
2f78c17197
Remove glibism!
2009-12-20 21:03:11 +01:00
907e67da13
Oops, add file.
2009-12-20 20:59:51 +01:00
2014b8d110
Hook OpenType shaping up
...
Default features only for now.
2009-12-20 20:58:26 +01:00
196610ba4c
Pass features down
2009-12-20 19:02:23 +01:00
Behdad Esfahbod