2008-12-19 22:15:18 +01:00
/*
2009-01-21 21:04:20 +01:00
* Cppcheck - A tool for static C / C + + code analysis
2009-05-30 07:48:12 +02:00
* Copyright ( C ) 2007 - 2009 Daniel Marjamäki and Cppcheck team .
2008-12-19 22:15:18 +01:00
*
* This program is free software : you can redistribute it and / or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation , either version 3 of the License , or
* ( at your option ) any later version .
*
* This program is distributed in the hope that it will be useful ,
* but WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the
* GNU General Public License for more details .
*
* You should have received a copy of the GNU General Public License
2009-09-27 17:08:31 +02:00
* along with this program . If not , see < http : //www.gnu.org/licenses/>.
2008-12-19 22:15:18 +01:00
*/
2009-10-25 12:49:06 +01:00
# include "tokenize.h"
# include "checkother.h"
2008-12-19 22:15:18 +01:00
# include "testsuite.h"
# include <sstream>
extern std : : ostringstream errout ;
class TestOther : public TestFixture
{
public :
TestOther ( ) : TestFixture ( " TestOther " )
{ }
private :
void run ( )
{
2009-03-28 07:49:47 +01:00
TEST_CASE ( zeroDiv1 ) ;
TEST_CASE ( zeroDiv2 ) ;
2009-08-23 05:34:19 +02:00
TEST_CASE ( zeroDiv3 ) ;
2009-08-30 21:02:09 +02:00
TEST_CASE ( zeroDiv4 ) ;
2009-03-28 07:49:47 +01:00
2009-01-05 16:49:57 +01:00
TEST_CASE ( delete1 ) ;
TEST_CASE ( delete2 ) ;
2009-01-08 22:08:14 +01:00
2009-01-18 22:19:02 +01:00
TEST_CASE ( unreachable1 ) ;
2009-01-15 17:57:51 +01:00
TEST_CASE ( sprintf1 ) ; // Dangerous usage of sprintf
2009-01-10 12:19:17 +01:00
TEST_CASE ( sprintf2 ) ;
2009-01-10 15:29:59 +01:00
TEST_CASE ( sprintf3 ) ;
2009-01-15 17:57:51 +01:00
TEST_CASE ( sprintf4 ) ; // struct member
2010-02-01 19:46:51 +01:00
TEST_CASE ( strPlusChar1 ) ; // "/usr" + '/'
TEST_CASE ( strPlusChar2 ) ; // "/usr" + ch
TEST_CASE ( strPlusChar3 ) ; // ok: path + "/sub" + '/'
2009-02-04 19:49:19 +01:00
2009-03-24 20:24:03 +01:00
TEST_CASE ( varScope1 ) ;
2009-03-24 20:59:56 +01:00
TEST_CASE ( varScope2 ) ;
2009-05-27 19:38:26 +02:00
TEST_CASE ( varScope3 ) ;
2009-06-12 16:17:51 +02:00
TEST_CASE ( varScope4 ) ;
2009-08-16 21:12:57 +02:00
TEST_CASE ( varScope5 ) ;
2009-09-17 21:05:12 +02:00
TEST_CASE ( varScope6 ) ;
2009-10-06 17:45:28 +02:00
TEST_CASE ( varScope7 ) ;
2010-01-21 18:50:56 +01:00
TEST_CASE ( varScope8 ) ;
2009-03-27 17:19:34 +01:00
TEST_CASE ( nullpointer1 ) ;
2009-05-10 08:43:16 +02:00
TEST_CASE ( nullpointer2 ) ;
2009-07-21 17:00:11 +02:00
TEST_CASE ( nullpointer3 ) ; // dereferencing struct and then checking if it's null
2009-07-23 14:13:46 +02:00
TEST_CASE ( nullpointer4 ) ;
2009-10-19 17:32:43 +02:00
TEST_CASE ( nullpointer5 ) ; // References should not be checked
TEST_CASE ( nullpointer6 ) ;
2009-11-01 12:08:37 +01:00
TEST_CASE ( nullpointer7 ) ;
2010-03-26 16:44:46 +01:00
TEST_CASE ( nullpointer8 ) ;
2009-06-18 22:26:21 +02:00
2009-10-29 21:34:43 +01:00
TEST_CASE ( uninitvar1 ) ;
2010-01-24 15:23:21 +01:00
TEST_CASE ( uninitvar_alloc ) ; // data is allocated but not initialized
TEST_CASE ( uninitvar_arrays ) ; // arrays
TEST_CASE ( uninitvar_class ) ; // class/struct
TEST_CASE ( uninitvar_enum ) ; // enum variables
TEST_CASE ( uninitvar_if ) ; // handling if/while/switch
TEST_CASE ( uninitvar_references ) ; // references
2010-02-05 17:35:18 +01:00
TEST_CASE ( uninitvar_strncpy ) ; // strncpy doesn't always 0-terminate
2010-01-24 15:23:21 +01:00
TEST_CASE ( uninitvar_func ) ; // analyse functions
2009-10-29 21:34:43 +01:00
2009-06-18 22:26:21 +02:00
TEST_CASE ( oldStylePointerCast ) ;
2009-07-25 00:36:15 +02:00
TEST_CASE ( postIncrementDecrementStl ) ;
TEST_CASE ( postIncrementDecrementClass ) ;
2009-10-04 10:05:58 +02:00
TEST_CASE ( dangerousStrolUsage ) ;
TEST_CASE ( passedByValue ) ;
2010-04-02 02:19:38 +02:00
2010-04-02 07:32:03 +02:00
TEST_CASE ( mathfunctionCall1 ) ;
2008-12-19 22:15:18 +01:00
}
2009-01-05 16:49:57 +01:00
void check ( const char code [ ] )
2008-12-19 22:15:18 +01:00
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
2009-01-05 16:49:57 +01:00
tokenizer . tokenize ( istr , " test.cpp " ) ;
2008-12-19 22:15:18 +01:00
2009-03-28 07:49:47 +01:00
// Simplify token list..
tokenizer . simplifyTokenList ( ) ;
2008-12-19 22:15:18 +01:00
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
2009-03-20 18:16:21 +01:00
Settings settings ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
2009-07-05 22:16:43 +02:00
checkOther . warningRedundantCode ( ) ;
checkOther . checkZeroDivision ( ) ;
2010-02-18 18:45:13 +01:00
checkOther . unreachableCode ( ) ;
2010-04-02 07:32:03 +02:00
checkOther . checkMathFunctions ( ) ;
2008-12-19 22:15:18 +01:00
}
2009-03-27 17:19:34 +01:00
2009-03-28 07:49:47 +01:00
void zeroDiv1 ( )
{
check ( " void foo() \n "
" { \n "
" int a = 0; \n "
" double b = 1.; \n "
" cout<<b/a; \n "
" } " ) ;
2009-05-31 21:48:55 +02:00
ASSERT_EQUALS ( " [test.cpp:5]: (error) Division by zero \n " , errout . str ( ) ) ;
2009-03-28 07:49:47 +01:00
}
void zeroDiv2 ( )
{
check ( " void foo() \n "
" { \n "
" int sum = 0; \n "
" int n = 100; \n "
" for(int i = 0; i < n; i ++) \n "
" { \n "
" sum += i; \n "
" } \n "
" cout<<b/sum; \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-03-28 07:49:47 +01:00
2009-06-05 23:33:13 +02:00
check ( " void foo() \n "
" { \n "
" int a = 0 ? (2/0) : 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
2009-03-28 07:49:47 +01:00
2009-08-23 05:34:19 +02:00
void zeroDiv3 ( )
{
check ( " void f() \n "
" { \n "
" div_t divresult = div (1,0); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Division by zero \n " , errout . str ( ) ) ;
}
2009-08-30 21:02:09 +02:00
void zeroDiv4 ( )
{
check ( " void f() \n "
" { \n "
" long a = b / 0x6; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
check ( " void f() \n "
" { \n "
" long a = b / 0x0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Division by zero \n " , errout . str ( ) ) ;
check ( " void f() \n "
" { \n "
" long a = b / 0L; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Division by zero \n " , errout . str ( ) ) ;
check ( " void f() \n "
" { \n "
" long a = b / 0ul; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Division by zero \n " , errout . str ( ) ) ;
check ( " void f() \n "
" { \n "
" div_t divresult = div (1,0L); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Division by zero \n " , errout . str ( ) ) ;
check ( " void f() \n "
" { \n "
" div_t divresult = div (1,0x5); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-01 16:00:26 +02:00
2009-09-01 21:06:46 +02:00
// Don't warn about floating points (gcc doesn't warn either)
// and floating points are handled differently than integers.
2009-09-01 16:00:26 +02:00
check ( " void f() \n "
" { \n "
" long a = b / 0.0; \n "
" } \n " ) ;
2009-09-01 21:06:46 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-01 16:00:26 +02:00
check ( " void f() \n "
" { \n "
" long a = b / 0.5; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-01 21:06:46 +02:00
// Don't warn about 0.0
2009-09-01 16:00:26 +02:00
check ( " void f() \n "
" { \n "
" div_t divresult = div (1,0.0); \n "
" } \n " ) ;
2009-09-01 21:06:46 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-01 16:00:26 +02:00
check ( " void f() \n "
" { \n "
" div_t divresult = div (1,0.5); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-08-30 21:02:09 +02:00
}
2008-12-19 22:15:18 +01:00
void delete1 ( )
{
2009-01-05 16:49:57 +01:00
check ( " void foo() \n "
" { \n "
" if (p) \n "
" { \n "
" delete p; \n "
" p = 0; \n "
" } \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-28 23:18:40 +02:00
check ( " void foo() \n "
" { \n "
" if (p) \n "
" delete p; \n "
" else \n "
" p = new P(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" if (0 != g->p) \n "
" delete this->p; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" if (0 != this->g->a) \n "
" delete this->p->a; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2008-12-19 22:15:18 +01:00
}
2008-12-20 23:24:11 +01:00
void delete2 ( )
{
2009-01-05 16:49:57 +01:00
check ( " void foo() \n "
" { \n "
" if (p) \n "
" { \n "
" delete p; \n "
" } \n "
" } \n " ) ;
2009-05-31 21:48:55 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (style) Redundant condition. It is safe to deallocate a NULL pointer \n " , errout . str ( ) ) ;
2008-12-20 23:24:11 +01:00
2009-01-05 16:49:57 +01:00
check ( " void foo() \n "
" { \n "
" if (p) \n "
" delete p; \n "
" } \n " ) ;
2009-05-31 21:48:55 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (style) Redundant condition. It is safe to deallocate a NULL pointer \n " , errout . str ( ) ) ;
2009-05-19 20:23:43 +02:00
check ( " void foo() \n "
" { \n "
" if (p != NULL) \n "
" delete p; \n "
" } \n " ) ;
2009-05-31 21:48:55 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (style) Redundant condition. It is safe to deallocate a NULL pointer \n " , errout . str ( ) ) ;
2009-05-19 20:28:25 +02:00
check ( " void foo() \n "
" { \n "
" if (p) \n "
" delete [] p; \n "
" } \n " ) ;
2009-05-31 21:48:55 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (style) Redundant condition. It is safe to deallocate a NULL pointer \n " , errout . str ( ) ) ;
2009-07-18 16:42:08 +02:00
check ( " void foo() \n "
" { \n "
" if (0 != this->p) \n "
" delete this->p; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (style) Redundant condition. It is safe to deallocate a NULL pointer \n " , errout . str ( ) ) ;
2009-09-28 23:18:40 +02:00
check ( " void foo() \n "
" { \n "
" if (0 != this->p->a) \n "
" delete this->p->a; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (style) Redundant condition. It is safe to deallocate a NULL pointer \n " , errout . str ( ) ) ;
2009-07-18 16:42:08 +02:00
check ( " void Foo::deleteInstance() \n "
" { \n "
" if (Foo::instance != NULL) \n "
" delete Foo::instance; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (style) Redundant condition. It is safe to deallocate a NULL pointer \n " , errout . str ( ) ) ;
2008-12-20 23:24:11 +01:00
}
2009-01-08 22:08:14 +01:00
2009-01-18 22:19:02 +01:00
void unreachable1 ( )
{
check ( " void foo() \n "
" { \n "
" switch (p) \n "
" { \n "
" default: \n "
" return 0; \n "
" break; \n "
" } \n "
" } \n " ) ;
2010-02-18 18:45:13 +01:00
ASSERT_EQUALS ( " [test.cpp:7]: (style) Unreachable code below a 'return' \n " , errout . str ( ) ) ;
2009-01-18 22:19:02 +01:00
}
2009-01-08 22:08:14 +01:00
2009-01-08 07:24:08 +01:00
void sprintfUsage ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
tokenizer . setVarId ( ) ;
2009-01-11 11:03:21 +01:00
//tokenizer.tokens()->printOut( "tokens" );
2009-01-08 07:24:08 +01:00
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
2009-03-20 18:16:21 +01:00
Settings settings ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
2009-07-05 22:16:43 +02:00
checkOther . invalidFunctionUsage ( ) ;
2009-01-08 07:24:08 +01:00
}
2009-01-08 22:08:14 +01:00
2009-01-08 07:24:08 +01:00
void sprintf1 ( )
{
2009-01-08 22:08:14 +01:00
sprintfUsage ( " void foo() \n "
" { \n "
" char buf[100]; \n "
" sprintf(buf, \" %s \" ,buf); \n "
" } \n " ) ;
2009-12-21 21:05:55 +01:00
ASSERT_EQUALS ( " [test.cpp:4]: (error) Undefined behaviour: buf is used wrong in call to sprintf or snprintf. Quote: If copying takes place between objects that overlap as a result of a call to sprintf() or snprintf(), the results are undefined. \n " , errout . str ( ) ) ;
2009-01-08 07:24:08 +01:00
}
2009-01-10 12:19:17 +01:00
void sprintf2 ( )
{
sprintfUsage ( " void foo() \n "
" { \n "
" char buf[100]; \n "
" sprintf(buf, \" %i \" ,sizeof(buf)); \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-01-10 12:19:17 +01:00
}
2009-01-10 15:27:31 +01:00
2009-01-10 15:29:59 +01:00
void sprintf3 ( )
{
2009-01-10 15:27:31 +01:00
sprintfUsage ( " void foo() \n "
" { \n "
" char buf[100]; \n "
" sprintf(buf, \" %i \" ,sizeof(buf)); \n "
2009-01-10 15:29:59 +01:00
" if (buf[0]); \n "
2009-01-10 15:27:31 +01:00
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-01-10 15:29:59 +01:00
}
2009-01-10 15:27:31 +01:00
2009-01-11 11:03:21 +01:00
void sprintf4 ( )
{
sprintfUsage ( " struct A \n "
" { \n "
" char filename[128]; \n "
" }; \n "
" \n "
" void foo() \n "
" { \n "
" const char* filename = \" hello \" ; \n "
" struct A a; \n "
" snprintf(a.filename, 128, \" %s \" , filename); \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-01-11 11:03:21 +01:00
}
2009-01-15 17:57:51 +01:00
void strPlusChar ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
tokenizer . setVarId ( ) ;
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
2009-03-20 18:16:21 +01:00
Settings settings ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
2009-01-15 17:57:51 +01:00
checkOther . strPlusChar ( ) ;
}
void strPlusChar1 ( )
{
// Strange looking pointer arithmetic..
strPlusChar ( " void foo() \n "
" { \n "
" const char *p = \" /usr \" + '/'; \n "
" } \n " ) ;
2009-05-31 21:48:55 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (error) Unusual pointer arithmetic \n " , errout . str ( ) ) ;
2009-01-15 17:57:51 +01:00
}
2009-01-15 18:12:33 +01:00
void strPlusChar2 ( )
{
// Strange looking pointer arithmetic..
strPlusChar ( " void foo() \n "
" { \n "
2010-02-07 21:44:11 +01:00
" char ch = 1; \n "
" const char *p = ch + \" /usr \" ; \n "
2009-01-15 18:12:33 +01:00
" } \n " ) ;
2010-02-07 21:44:11 +01:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-02-08 08:35:53 +01:00
// Strange looking pointer arithmetic..
2010-02-07 21:44:11 +01:00
strPlusChar ( " void foo() \n "
" { \n "
" int i = 1; \n "
2010-02-22 21:30:21 +01:00
" const char* psz = \" Bla \" ; \n "
2010-02-07 21:44:11 +01:00
" const std::string str = i + psz; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-02-08 08:35:53 +01:00
}
2009-01-15 18:12:33 +01:00
2009-01-18 18:42:41 +01:00
void strPlusChar3 ( )
{
// Strange looking pointer arithmetic..
strPlusChar ( " void foo() \n "
" { \n "
" std::string temp = \" /tmp \" ; \n "
" std::string path = temp + '/' + \" sub \" + '/'; \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-01-18 18:42:41 +01:00
}
2009-02-04 19:49:19 +01:00
2009-03-24 20:24:03 +01:00
void varScope ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
Settings settings ;
settings . _checkCodingStyle = true ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
2009-07-05 22:16:43 +02:00
checkOther . checkVariableScope ( ) ;
2009-03-24 20:24:03 +01:00
}
void varScope1 ( )
{
varScope ( " unsigned short foo() \n "
" { \n "
" test_client CClient; \n "
" try \n "
" { \n "
" if (CClient.Open()) \n "
" { \n "
" return 0; \n "
" } \n "
" } \n "
" catch (...) \n "
" { \n "
" return 2; \n "
" } \n "
" \n "
" try \n "
" { \n "
" CClient.Close(); \n "
" } \n "
" catch (...) \n "
" { \n "
" return 2; \n "
" } \n "
" \n "
" return 1; \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-03-24 20:24:03 +01:00
}
2009-03-24 20:59:56 +01:00
void varScope2 ( )
{
varScope ( " int foo() \n "
" { \n "
" Error e; \n "
" e.SetValue(12); \n "
" throw e; \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-03-24 20:59:56 +01:00
}
2009-03-27 17:19:34 +01:00
2009-05-27 19:38:26 +02:00
void varScope3 ( )
{
varScope ( " void foo() \n "
" { \n "
" int i; \n "
" int *p = 0; \n "
" if (abc) \n "
" { \n "
" p = &i; \n "
" } \n "
" *p = 1; \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-05-27 19:38:26 +02:00
}
2009-06-12 16:17:51 +02:00
void varScope4 ( )
{
varScope ( " void foo() \n "
" { \n "
" int i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
2009-08-16 21:12:57 +02:00
void varScope5 ( )
{
2009-09-29 23:56:43 +02:00
varScope ( " void f(int x) \n "
" { \n "
" int i = 0; \n "
" if (x) { \n "
" for ( ; i < 10; ++i) ; \n "
" } \n "
" } \n " ) ;
2010-01-12 19:34:33 +01:00
ASSERT_EQUALS ( " [test.cpp:3]: (style) The scope of the variable i can be reduced \n " , errout . str ( ) ) ;
2009-09-29 23:56:43 +02:00
varScope ( " void f(int x) \n "
2009-08-16 21:12:57 +02:00
" { \n "
" int i = 0; \n "
2009-09-29 23:56:43 +02:00
" if (x) {b()} \n "
" else { \n "
2009-08-16 21:12:57 +02:00
" for ( ; i < 10; ++i) ; \n "
" } \n "
" } \n " ) ;
2010-01-12 19:34:33 +01:00
ASSERT_EQUALS ( " [test.cpp:3]: (style) The scope of the variable i can be reduced \n " , errout . str ( ) ) ;
2009-08-16 21:12:57 +02:00
}
2009-03-27 17:19:34 +01:00
2009-09-17 21:05:12 +02:00
void varScope6 ( )
{
varScope ( " void f(int x) \n "
" { \n "
" int i = x; \n "
" if (a) { \n "
" x++; \n "
" } \n "
" if (b) { \n "
" c(i); \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-29 23:56:43 +02:00
varScope ( " void f() \n "
" { \n "
" int foo = 0; \n "
" std::vector<int> vec(10); \n "
" BOOST_FOREACH(int& i, vec) \n "
" { \n "
" foo += 1; \n "
" if(foo == 10) \n "
" { \n "
" return 0; \n "
" } \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-03-27 17:19:34 +01:00
2009-09-29 23:56:43 +02:00
varScope ( " void f(int &x) \n "
" { \n "
" int n = 1; \n "
" do \n "
" { \n "
" ++n; \n "
" ++x; \n "
" } while (x); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
2009-03-27 17:19:34 +01:00
2009-10-06 17:45:28 +02:00
void varScope7 ( )
{
varScope ( " void f(int x) \n "
" { \n "
" int y = 0; \n "
" b(y); \n "
" if (x) { \n "
" y++; \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
2010-01-21 18:50:56 +01:00
void varScope8 ( )
{
varScope ( " void test() { \n "
" float edgeResistance=1; \n "
" std::vector<int> edges; \n "
" BOOST_FOREACH(int edge, edges) { \n "
" edgeResistance = (edge+1) / 2.0; \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:2]: (style) The scope of the variable edgeResistance can be reduced \n " , errout . str ( ) ) ;
}
2009-03-27 17:19:34 +01:00
void checkNullPointer ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
Settings settings ;
settings . _checkCodingStyle = true ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
checkOther . nullPointer ( ) ;
2009-12-21 19:09:13 +01:00
tokenizer . simplifyTokenList ( ) ;
2009-12-06 18:41:28 +01:00
checkOther . executionPaths ( ) ;
2009-03-27 17:19:34 +01:00
}
void nullpointer1 ( )
{
checkNullPointer ( " int foo(const Token *tok) \n "
" { \n "
" while (tok); \n "
" tok = tok->next(); \n "
" } \n " ) ;
2009-08-11 17:18:01 +02:00
ASSERT_EQUALS ( " [test.cpp:4]: (error) Possible null pointer dereference: tok \n " , errout . str ( ) ) ;
2009-07-30 21:57:23 +02:00
checkNullPointer ( " void foo() \n "
" { \n "
" for (const Token *tok = tokens; tok; tok = tok->next()) \n "
" { \n "
" while (tok && tok->str() != \" ; \" ) \n "
" tok = tok->next(); \n "
" } \n "
" } \n " ) ;
2010-02-28 07:26:50 +01:00
ASSERT_EQUALS ( " [test.cpp:3]: (error) Possible null pointer dereference: tok - otherwise it is redundant to check if tok is null at line 5 \n " , errout . str ( ) ) ;
2009-08-01 11:30:37 +02:00
2009-10-08 10:55:37 +02:00
checkNullPointer ( " void foo(Token &tok) \n "
" { \n "
" for (int i = 0; i < tok.size(); i++ ) \n "
" { \n "
" while (!tok) \n "
" char c = tok.read(); \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-07 22:38:21 +02:00
checkNullPointer ( " void foo() \n "
" { \n "
" for (const Token *tok = tokens; tok; tok = tok->next()) \n "
" { \n "
" while (tok && tok->str() != \" ; \" ) \n "
" tok = tok->next(); \n "
" if( !tok ) break; \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-08-01 11:30:37 +02:00
checkNullPointer ( " void foo() \n "
" { \n "
" for (const Token *tok = tokens; tok; tok = tok ? tok->next() : NULL) \n "
" { \n "
" while (tok && tok->str() != \" ; \" ) \n "
" tok = tok->next(); \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-05 13:46:38 +02:00
checkNullPointer ( " void foo(A*a) \n "
" { \n "
" switch (a->b()) { \n "
" case 1: \n "
" while( a ){ \n "
" a = a->next; \n "
" } \n "
" break; \n "
" case 2: \n "
" a->b(); \n "
" break; \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-03-27 17:19:34 +01:00
}
2009-05-10 08:43:16 +02:00
void nullpointer2 ( )
{
// Null pointer dereference can only happen with pointers
checkNullPointer ( " void foo() \n "
" { \n "
" Fred fred; \n "
" while (fred); \n "
" fred.hello(); \n "
" } \n " ) ;
2009-06-05 02:39:36 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-05-10 08:43:16 +02:00
}
2009-06-18 22:26:21 +02:00
2009-07-21 17:00:11 +02:00
// Dereferencing a struct and then checking if it is null
void nullpointer3 ( )
2009-07-20 19:30:33 +02:00
{
2009-07-21 12:09:58 +02:00
// errors..
2009-07-21 17:00:11 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
2009-07-22 18:48:42 +02:00
" { \n "
2009-11-09 20:40:30 +01:00
" int a = abc->a; \n "
2009-07-22 18:48:42 +02:00
" if (!abc) \n "
" ; \n "
" } \n " ) ;
2009-08-21 12:42:40 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (error) Possible null pointer dereference: abc - otherwise it is redundant to check if abc is null at line 4 \n " , errout . str ( ) ) ;
2009-07-21 12:09:58 +02:00
2009-08-28 08:48:37 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
" { \n "
" bar(abc->a); \n "
" if (!abc) \n "
" ; \n "
" } \n " ) ;
TODO_ASSERT_EQUALS ( " [test.cpp:3]: (error) Possible null pointer dereference: abc - otherwise it is redundant to check if abc is null at line 4 \n " , errout . str ( ) ) ;
2009-07-20 19:30:33 +02:00
// ok dereferencing in a condition
2009-07-21 17:00:11 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
2009-07-22 18:48:42 +02:00
" { \n "
" if (abc && abc->a); \n "
" if (!abc) \n "
" ; \n "
" } \n " ) ;
2009-07-20 19:30:33 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
// ok to use a linked list..
2009-07-21 17:00:11 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
2009-07-22 18:48:42 +02:00
" { \n "
" abc = abc->next; \n "
" if (!abc) \n "
" ; \n "
" } \n " ) ;
2009-07-20 19:30:33 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-20 19:59:55 +02:00
// reassign struct..
2009-07-21 17:00:11 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
2009-07-22 18:48:42 +02:00
" { \n "
2009-11-09 20:40:30 +01:00
" int a = abc->a; \n "
2009-07-22 18:48:42 +02:00
" abc = abc->next; \n "
" if (!abc) \n "
" ; \n "
" } \n " ) ;
2009-07-21 12:09:58 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-21 17:00:11 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
2009-07-22 18:48:42 +02:00
" { \n "
2009-11-09 20:40:30 +01:00
" int a = abc->a; \n "
2009-07-22 18:48:42 +02:00
" f(&abc); \n "
" if (!abc) \n "
" ; \n "
" } \n " ) ;
2009-07-21 12:09:58 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
// goto..
2009-07-21 17:00:11 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
2009-07-22 18:48:42 +02:00
" { \n "
2009-11-09 20:40:30 +01:00
" int a; \n "
2009-07-22 18:48:42 +02:00
" if (!abc) \n "
" goto out; "
" a = abc->a; \n "
" return; \n "
" out: \n "
" if (!abc) \n "
" ; \n "
" } \n " ) ;
2009-07-20 19:59:55 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-23 19:59:29 +02:00
2009-07-29 11:17:22 +02:00
// loops..
2009-07-23 19:59:29 +02:00
checkNullPointer ( " void freeAbc(struct ABC *abc) \n "
" { \n "
" while (abc) \n "
" { \n "
" struct ABC *next = abc->next; \n "
" if (abc) delete abc; \n "
" abc = next; \n "
" } \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-29 11:17:22 +02:00
checkNullPointer ( " void foo(struct ABC *abc) \n "
" { \n "
" int a = abc->a; "
" do \n "
" { \n "
" if (abc) \n "
" abc = abc->next; \n "
" --a; \n "
" } \n "
2009-08-11 21:06:41 +02:00
" while (a > 0); \n "
2009-07-29 11:17:22 +02:00
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-19 10:54:10 +02:00
// dynamic_cast..
checkNullPointer ( " void foo(ABC *abc) \n "
" { \n "
" int a = abc->a; \n "
" if (!dynamic_cast<DEF *>(abc)) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-20 19:30:33 +02:00
}
2009-07-23 14:13:46 +02:00
// Dereferencing a pointer and then checking if it is null
void nullpointer4 ( )
{
// errors..
checkNullPointer ( " void foo(int *p) \n "
" { \n "
" *p = 0; \n "
" if (!p) \n "
" ; \n "
" } \n " ) ;
2009-08-11 17:18:01 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (error) Possible null pointer dereference: p \n " , errout . str ( ) ) ;
2009-07-23 14:13:46 +02:00
2009-08-28 08:48:37 +02:00
checkNullPointer ( " void foo(int *p) \n "
" { \n "
" bar(*p); \n "
" if (!p) \n "
" ; \n "
" } \n " ) ;
TODO_ASSERT_EQUALS ( " [test.cpp:3]: (error) Possible null pointer dereference: p \n " , errout . str ( ) ) ;
2009-07-23 14:13:46 +02:00
// no error
2009-07-23 19:02:14 +02:00
checkNullPointer ( " void foo() \n "
" { \n "
" int *p; \n "
" f(&p); \n "
" if (!p) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
checkNullPointer ( " void foo() \n "
" { \n "
" int **p = f(); \n "
" if (!p) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-23 14:13:46 +02:00
checkNullPointer ( " void foo(int *p) \n "
" { \n "
" if (x) \n "
" p = 0; \n "
" else \n "
" *p = 0; \n "
" if (!p) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-25 20:36:02 +02:00
checkNullPointer ( " void foo(int x) \n "
" { \n "
" int a = 2 * x; "
" if (x == 0) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-08-28 08:48:37 +02:00
checkNullPointer ( " void foo(int *p) \n "
" { \n "
" int var1 = p ? *p : 0; \n "
" if (!p) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-09-29 15:38:05 +02:00
checkNullPointer ( " void foo(P *p) \n "
" { \n "
" while (p) \n "
" if (p->check()) \n "
" break; \n "
" else \n "
" p = p->next(); \n "
" } \n " ) ;
2009-09-30 20:42:14 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-23 14:13:46 +02:00
}
2009-10-08 10:55:37 +02:00
void nullpointer5 ( )
{
// errors..
checkNullPointer ( " void foo(A &a) \n "
" { \n "
" char c = a.c(); \n "
" if (!a) \n "
" return; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
2009-07-23 14:13:46 +02:00
2009-10-19 17:32:43 +02:00
void nullpointer6 ( )
{
// errors..
checkNullPointer ( " static void foo() \n "
" { \n "
" Foo *p = 0; \n "
" if (a == 1) \n "
" p = new FooBar; \n "
" else if (a == 2) \n "
" p = new FooCar; \n "
" p->abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:8]: (error) Possible null pointer dereference: p \n " , errout . str ( ) ) ;
2009-10-20 20:57:38 +02:00
2009-12-21 19:09:13 +01:00
checkNullPointer ( " static void foo() \n "
" { \n "
" int *p = 0; \n "
" int *q = p; \n "
" q[0] = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (error) Possible null pointer dereference: q \n " , errout . str ( ) ) ;
2009-12-30 17:42:41 +01:00
checkNullPointer ( " static void foo() \n "
" { \n "
" int *p = 0; \n "
" int &r = *p; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Null pointer dereference \n " , errout . str ( ) ) ;
2009-12-21 19:09:13 +01:00
2009-12-31 20:00:20 +01:00
checkNullPointer ( " static void foo(int x) \n "
" { \n "
" int *p = 0; \n "
" int y = 5 + *p; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Null pointer dereference \n " , errout . str ( ) ) ;
2010-01-03 13:30:20 +01:00
checkNullPointer ( " static void foo(int x) \n "
" { \n "
" Foo<int> *abc = 0; \n "
" abc->a(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Possible null pointer dereference: abc \n " , errout . str ( ) ) ;
2010-01-30 14:40:33 +01:00
checkNullPointer ( " static void foo() \n "
" { \n "
" int *p(0); \n "
" std::cout << *p; "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Null pointer dereference \n " , errout . str ( ) ) ;
2009-10-20 20:57:38 +02:00
// no false positive..
checkNullPointer ( " static void foo() \n "
" { \n "
" Foo *p = 0; \n "
" p = new Foo; \n "
" p->abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-30 15:14:24 +01:00
checkNullPointer ( " static void foo() \n "
" { \n "
" Foo *p = 0; \n "
" if (!p) \n "
" return; \n "
" p->abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-29 09:17:07 +01:00
2010-01-03 15:35:32 +01:00
checkNullPointer ( " static void foo() \n "
" { \n "
" int *p = 0; \n "
" exit(); \n "
" *p = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-29 09:17:07 +01:00
checkNullPointer ( " static void foo(int a) \n "
" { \n "
" Foo *p = 0; \n "
" if (a && p) \n "
" p->do_something(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-14 20:02:38 +01:00
checkNullPointer ( " void foo() \n "
" { \n "
" int sz = sizeof((*(struct dummy *)0).x); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-23 09:15:30 +01:00
2010-02-22 21:30:21 +01:00
checkNullPointer ( " void get_offset(long &offset) \n "
" { \n "
" mystruct * temp; temp = 0; \n "
" offset = (long)(&(temp->z)); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-23 09:15:30 +01:00
// function pointer..
checkNullPointer ( " void foo() \n "
" { \n "
" void (*f)(); \n "
" f = 0; \n "
" f(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (error) Possible null pointer dereference: f \n " , errout . str ( ) ) ;
2010-02-25 21:55:09 +01:00
checkNullPointer ( " static void foo() \n "
" { \n "
" int *p = 0; \n "
" int *p2 = 0; \n "
" int r = *p; \n "
" int r2 = *p2; \n "
" } \n " ) ;
2010-04-04 11:24:52 +02:00
ASSERT_EQUALS ( " [test.cpp:5]: (error) Null pointer dereference \n "
" [test.cpp:6]: (error) Null pointer dereference \n " , errout . str ( ) ) ;
2010-02-25 21:55:09 +01:00
2009-10-19 17:32:43 +02:00
}
2009-11-01 12:08:37 +01:00
void nullpointer7 ( )
{
checkNullPointer ( " void foo() \n "
" { \n "
" wxLongLong x = 0; \n "
" int y = x.GetValue(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
2009-10-29 21:34:43 +01:00
2010-03-26 16:44:46 +01:00
void nullpointer8 ( )
{
checkNullPointer ( " void foo() \n "
" { \n "
" const char * x = 0; \n "
" strdup(x); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Possible null pointer dereference: x \n " , errout . str ( ) ) ;
checkNullPointer ( " void foo() \n "
" { \n "
" char const * x = 0; \n "
" strdup(x); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Possible null pointer dereference: x \n " , errout . str ( ) ) ;
}
2009-10-29 21:34:43 +01:00
void checkUninitVar ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
Settings settings ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
2009-12-06 18:41:28 +01:00
checkOther . executionPaths ( ) ;
2009-10-29 21:34:43 +01:00
}
void uninitvar1 ( )
{
2009-10-30 14:31:37 +01:00
// dereferencing uninitialized pointer..
checkUninitVar ( " static void foo() \n "
" { \n "
" Foo *p; \n "
" p->abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: p \n " , errout . str ( ) ) ;
2010-01-03 13:30:20 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" Foo<int> *p; \n "
" p->abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: p \n " , errout . str ( ) ) ;
2009-11-15 20:01:57 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int *p; \n "
" delete p; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: p \n " , errout . str ( ) ) ;
checkUninitVar ( " static void foo() \n "
" { \n "
" int *p; \n "
" delete [] p; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: p \n " , errout . str ( ) ) ;
2009-11-15 20:26:07 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int *p; \n "
" *p = 135; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: p \n " , errout . str ( ) ) ;
2009-12-27 17:20:34 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int *x; \n "
" int y = *x; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: x \n " , errout . str ( ) ) ;
2009-12-29 20:36:20 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int *x; \n "
" int &y(*x); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: x \n " , errout . str ( ) ) ;
2009-12-30 21:42:15 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" int x; \n "
" int *y = &x; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-03 08:03:28 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" int x = xyz::x; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-23 17:55:03 +01:00
checkUninitVar ( " static int foo() \n "
" { \n "
" int ret; \n "
" return ret; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: ret \n " , errout . str ( ) ) ;
2009-12-30 20:15:44 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" int a; \n "
" a = 5 + a; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: a \n " , errout . str ( ) ) ;
2010-01-10 09:09:37 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" int a; \n "
" a++; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: a \n " , errout . str ( ) ) ;
2009-12-25 19:45:21 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int i; \n "
" if (i); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: i \n " , errout . str ( ) ) ;
2010-03-28 21:27:06 +02:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int i; \n "
" for (int x = 0; i < 10; x++); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: i \n " , errout . str ( ) ) ;
checkUninitVar ( " static void foo() \n "
" { \n "
" int i; \n "
" for (int x = 0; x < 10; i++); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: i \n " , errout . str ( ) ) ;
2009-12-25 19:45:21 +01:00
2009-12-25 20:50:23 +01:00
checkUninitVar ( " static int foo(int x) \n "
" { \n "
" int i; \n "
" if (x) \n "
" i = 0; \n "
" return i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:6]: (error) Uninitialized variable: i \n " , errout . str ( ) ) ;
2010-01-09 22:26:05 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int ar[10]; \n "
" int i; \n "
" ar[i] = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (error) Uninitialized variable: i \n " , errout . str ( ) ) ;
2009-12-20 13:55:17 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" int x, y; \n "
" x = (y = 10); \n "
" int z = y * 2; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-30 14:31:37 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" Foo p; \n "
" p.abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-23 13:57:01 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" Foo p; \n "
" int x = p.abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-31 10:30:32 +01:00
checkUninitVar ( " A a() \n "
" { \n "
" A ret; \n "
" return ret; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-02 19:58:49 +01:00
checkUninitVar ( " void a() \n "
" { \n "
" int x; \n "
" int y = x; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: x \n " , errout . str ( ) ) ;
2009-11-03 17:03:53 +01:00
checkUninitVar ( " void a() \n "
" { \n "
" int x[10]; \n "
" int *y = x; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-11 19:25:01 +01:00
checkUninitVar ( " void a() \n "
" { \n "
" int x; \n "
" int *y = &x; \n "
" *y = 0; \n "
" x++; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-17 19:08:45 +01:00
checkUninitVar ( " void a() \n "
" { \n "
" char x[10], y[10]; \n "
" char *z = x; \n "
" memset(z, 0, sizeof(x)); \n "
" memcpy(y, x, sizeof(x)); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-02 16:28:15 +01:00
checkUninitVar ( " int a() \n "
" { \n "
" int ret; \n "
" std::cin >> ret; \n "
" return ret; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-02 18:31:22 +01:00
checkUninitVar ( " int a() \n "
" { \n "
" int ret; \n "
" asm(); \n "
" return ret; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-05 21:07:04 +01:00
checkUninitVar ( " void a() \n "
" { \n "
" int x[10]; \n "
" struct xyz xyz1 = { .x = x }; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-03-28 10:42:37 +02:00
// #1533
checkUninitVar ( " char a() \n "
" { \n "
" char key; \n "
" struct A msg = { .buf = {&key} }; \n "
" init(&msg); \n "
" return key; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-27 09:27:05 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" char *buf = malloc(100); \n "
" struct ABC *abc = buf; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-28 12:51:28 +01:00
checkUninitVar ( " class Fred { \n "
" public: \n "
" FILE *f; \n "
" ~Fred(); \n "
" } \n "
" Fred::~Fred() \n "
" { \n "
" fclose(f); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-02 18:16:44 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" int c; \n "
" ab(sizeof(xyz), &c); \n "
" if (c); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-13 19:37:55 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" int c; \n "
" a = (f2(&c)); \n "
" c++; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-03 18:49:13 +01:00
// +=
checkUninitVar ( " void f() \n "
" { \n "
" int c; \n "
" c += 2; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: c \n " , errout . str ( ) ) ;
checkUninitVar ( " void f() \n "
" { \n "
" char *s = malloc(100); \n "
" *s += 10; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Data is allocated but not initialized: s \n " , errout . str ( ) ) ;
checkUninitVar ( " void f() \n "
" { \n "
" int a[10]; \n "
" a[0] += 10; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: a \n " , errout . str ( ) ) ;
2009-11-06 16:02:13 +01:00
// goto..
checkUninitVar ( " void foo(int x) \n "
" { \n "
" long b; \n "
" if (g()) { \n "
" b =2; \n "
" goto found; \n "
" } \n "
" \n "
" return; \n "
" \n "
" found: \n "
" int a = b; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
// macro_for..
checkUninitVar ( " int foo() \n "
" { \n "
" int retval; \n "
" if (condition) { \n "
" for12(1,2) { } \n "
" retval = 1; \n "
" } \n "
" else \n "
" retval = 2; \n "
" return retval; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-04-02 08:35:05 +02:00
checkUninitVar ( " int foo() \n "
" { \n "
" int i; \n "
" goto exit; \n "
" i++; \n "
" exit: \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
}
2009-11-06 16:02:13 +01:00
2010-01-24 15:23:21 +01:00
// if..
void uninitvar_if ( )
{
2009-10-29 21:34:43 +01:00
checkUninitVar ( " static void foo() \n "
" { \n "
" Foo *p; \n "
" if (x) \n "
" p = new Foo; \n "
" p->abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:6]: (error) Uninitialized variable: p \n " , errout . str ( ) ) ;
checkUninitVar ( " int foo() \n "
" { \n "
" int i; \n "
" if (x) \n "
" i = 22; \n "
" else \n "
" i = 33; \n "
" return i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-10 18:05:55 +01:00
checkUninitVar ( " int foo() \n "
" { \n "
" int i; \n "
" if (x) \n "
" i = 22; \n "
" else \n "
" { \n "
" char *y = {0}; \n "
" i = 33; \n "
" } \n "
" return i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-14 08:00:17 +01:00
checkUninitVar ( " int foo() \n "
" { \n "
" int i; \n "
" if (x) \n "
" { \n "
" struct abc abc1 = (struct abc) { .a=0, .b=0, .c=0 }; \n "
" i = 22; \n "
" } \n "
" else \n "
" { \n "
" i = 33; \n "
" } \n "
" return i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-25 20:50:23 +01:00
checkUninitVar ( " static void foo(int x) \n "
2009-10-29 21:34:43 +01:00
" { \n "
" Foo *p; \n "
" if (x) \n "
" p = new Foo; \n "
" if (x) \n "
" p->abcd(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-29 22:51:08 +01:00
2009-10-30 18:28:01 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" C *c; \n "
" if (fun(&c)); \n "
" c->Release(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-14 20:37:54 +01:00
checkUninitVar ( " int foo(int x) \n "
" { \n "
" int i; \n "
" if (one()) \n "
" i = 1; \n "
" else \n "
" return 3; \n "
" return i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-01 20:12:39 +01:00
checkUninitVar ( " int foo() \n "
" { \n "
" int ret; \n "
" if (one()) \n "
" ret = 1; \n "
" else \n "
" throw 3; \n "
" return ret; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-01 19:43:02 +01:00
checkUninitVar ( " int f(int a) \n "
" { \n "
" int ret; \n "
" if (a == 1) \n "
" ret = 1; \n "
" else \n "
" XYZ ret = 2; \n " // XYZ may be an unexpanded macro so bailout the checking of "ret".
" return ret; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-02 09:08:36 +01:00
checkUninitVar ( " int f(int a, int b) \n "
" { \n "
" int x; \n "
" if (a) \n "
" x = a; \n "
" else { \n "
" do { } while (f2()); \n "
" x = b; \n "
" } \n "
" return x; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-30 14:52:20 +01:00
// switch..
checkUninitVar ( " char * f() \n "
" { \n "
" static char ret[200]; \n "
" memset(ret, 0, sizeof(ret)); \n "
" switch (x) \n "
" { \n "
" case 1: return ret; \n "
" case 2: return ret; \n "
" } \n "
" return 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-02-17 18:10:50 +01:00
checkUninitVar ( " int foo(const int iVar, unsigned int slot, unsigned int pin) \n "
" { \n "
" int i; \n "
" \n "
" if (iVar == 0) \n "
" { \n "
" switch (slot) \n "
" { \n "
" case 4: return 5; \n "
" default: return -1; \n "
" } \n "
" } \n "
" else \n "
" { \n "
" switch (pin) \n "
" { \n "
" case 0: i = 2; break; \n "
" default: i = -1; break; \n "
" } \n "
" } \n "
" return i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-03 13:30:20 +01:00
// while..
checkUninitVar ( " int f() \n "
" { \n "
" int i; \n "
" while (fgets()) \n "
" i = 1; \n "
" return i; "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:6]: (error) Uninitialized variable: i \n " , errout . str ( ) ) ;
2009-10-30 14:52:20 +01:00
2010-01-10 22:05:51 +01:00
checkUninitVar ( " void f(int i) \n "
" { \n "
" int a; \n "
" while (i < 10) \n "
" i++; \n "
" a++; "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:6]: (error) Uninitialized variable: a \n " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
// ; { .. }
checkUninitVar ( " int foo() \n "
2009-12-23 19:51:32 +01:00
" { \n "
2010-01-24 15:23:21 +01:00
" int retval; \n "
" if (condition) { \n "
" { } \n "
" retval = 1; } \n "
" else \n "
" retval = 2; \n "
" return retval; \n "
2009-12-23 19:51:32 +01:00
" } \n " ) ;
2009-12-30 11:32:46 +01:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-31 09:10:20 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
2010-01-24 15:23:21 +01:00
" { \n "
" for (int i = 0; i < 10; ++i) \n "
" { } \n "
" } \n "
" \n "
" { } \n "
2009-12-31 09:10:20 +01:00
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
}
2009-12-31 09:10:20 +01:00
2010-01-24 15:23:21 +01:00
// arrays..
void uninitvar_arrays ( )
{
2010-04-05 09:04:30 +02:00
checkUninitVar ( " int f() \n "
" { \n "
" char a[10]; \n "
" a[a[0]] = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: a \n " , errout . str ( ) ) ;
2010-03-16 19:09:37 +01:00
checkUninitVar ( " int f() \n "
" { \n "
" char a[10]; \n "
" *a = ' \\ 0'; \n "
" int i = strlen(a); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-03 21:02:16 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char a[10], b[10]; \n "
" a[0] = b[0] = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-08 07:31:01 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char a[10], *p; \n "
" *(p = a) = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-11-06 16:50:02 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char c[50] = \" \" ; \n "
" strcat(c, \" test \" ); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-31 16:36:56 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char s[20]; \n "
" strcpy(s2, s); \n "
" }; \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: s \n " , errout . str ( ) ) ;
2009-11-03 17:03:53 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char s[20]; \n "
" strcat(s, \" abc \" ); \n "
" }; \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: s \n " , errout . str ( ) ) ;
2009-11-06 19:06:45 +01:00
2009-12-22 21:07:56 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char s[20]; \n "
" strchr(s, ' '); \n "
" }; \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: s \n " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
}
2009-11-07 09:10:15 +01:00
2010-01-24 15:23:21 +01:00
// alloc..
void uninitvar_alloc ( )
{
2009-11-07 09:10:15 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char *s = malloc(100); \n "
" strcat(s, \" abc \" ); \n "
" }; \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Data is allocated but not initialized: s \n " , errout . str ( ) ) ;
2009-11-07 14:54:12 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char *s1 = new char[10]; \n "
" char *s2 = new char[strlen(s1)]; \n "
" }; \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Data is allocated but not initialized: s1 \n " , errout . str ( ) ) ;
2009-11-29 19:23:31 +01:00
2010-04-05 08:38:26 +02:00
checkUninitVar ( " void f() \n "
" { \n "
" char *p = malloc(64); \n "
" int x = p[0]; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Data is allocated but not initialized: p \n " , errout . str ( ) ) ;
2009-12-22 21:00:52 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" Fred *fred = new Fred; \n "
" fred->foo(); \n "
" }; \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-26 09:30:02 +01:00
checkUninitVar ( " void foo(char *s) \n "
" { \n "
" char *a = malloc(100); \n "
" *a = *s; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-26 16:21:53 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" char *a; \n "
" if (a); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: a \n " , errout . str ( ) ) ;
checkUninitVar ( " void foo() \n "
" { \n "
" char *a = malloc(100); \n "
" if (a); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-27 17:35:18 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" ABC *abc = malloc(100); \n "
" abc->a = 123; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-03-07 09:08:52 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" ABC *abc = malloc(100); \n "
" abc->a.word = 123; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-23 21:25:17 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" ABC *abc = malloc(100); \n "
" abc->a = 123; \n "
" abc->a += 123; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-27 18:00:43 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" ABC *abc = malloc(100); \n "
" free(abc); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-30 20:37:11 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" char *s = malloc(100); \n "
" if (!s) \n "
" return; \n "
" char c = *s; \n "
" }; \n " ) ;
ASSERT_EQUALS ( " [test.cpp:6]: (error) Data is allocated but not initialized: s \n " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
}
// class / struct..
void uninitvar_class ( )
{
checkUninitVar ( " class Fred \n "
" { \n "
" int i; \n "
" int a() { return i; } \n "
" }; \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-30 20:37:11 +01:00
2009-11-29 19:23:31 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" struct Relative { \n "
" Surface *surface; \n "
" void MoveTo(int x, int y) { \n "
" surface->MoveTo(); \n "
" } \n "
" }; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-09 20:05:06 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" static const struct ab { \n "
" int a,b; \n "
" int get_a() { return a; } "
" } = { 0, 0 }; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-02-20 09:35:57 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" int i; \n "
" { \n "
" union ab { \n "
" int a,b; \n "
" } \n "
" i = 0; \n "
" } \n "
" return i; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
}
2009-12-15 19:50:48 +01:00
2010-01-24 15:23:21 +01:00
// enum..
void uninitvar_enum ( )
{
2010-01-10 20:36:15 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" enum AB { a, b }; \n "
" AB ab; \n "
" if (ab); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (error) Uninitialized variable: ab \n " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
}
2010-01-10 20:36:15 +01:00
2010-01-24 15:23:21 +01:00
// references..
void uninitvar_references ( )
{
2009-12-15 19:50:48 +01:00
checkUninitVar ( " void f() \n "
" { \n "
" int a; \n "
" int &b = a; \n "
" b = 0; \n "
" int x = a; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-22 19:16:34 +01:00
checkUninitVar ( " void f(struct blame_entry *ent) \n "
2009-12-22 19:18:02 +01:00
" { \n "
2009-12-22 19:16:34 +01:00
" struct origin *suspect = ent->suspect; \n "
" char hex[41]; \n "
" strcpy(hex, sha1_to_hex(suspect->commit->object.sha1)); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-12-23 15:01:23 +01:00
2009-12-29 09:17:07 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" const std::string s(x()); \n "
" strchr(s.c_str(), ','); \n "
2009-12-23 15:01:23 +01:00
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
}
2010-01-08 21:24:48 +01:00
2010-02-05 17:35:18 +01:00
// strncpy doesn't always 0-terminate..
void uninitvar_strncpy ( )
{
checkUninitVar ( " void f() \n "
" { \n "
" char a[100]; \n "
" strncpy(a, s, 20); \n "
" strncat(a, s, 20); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (error) Dangerous usage of 'a' (strncpy doesn't always 0-terminate it) \n " , errout . str ( ) ) ;
}
2010-01-24 15:23:21 +01:00
std : : string analyseFunctions ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
std : : set < std : : string > f ;
2010-04-04 09:17:53 +02:00
CheckOther : : analyseFunctions ( tokenizer . tokens ( ) , f , true ) ;
2010-01-24 15:23:21 +01:00
std : : string ret ;
2010-04-02 07:30:58 +02:00
for ( std : : set < std : : string > : : const_iterator it = f . begin ( ) ; it ! = f . end ( ) ; + + it )
2010-04-04 09:17:53 +02:00
ret + = ( ret . empty ( ) ? " " : " " ) + * it ;
2010-01-24 15:23:21 +01:00
return ret ;
}
void uninitvar_func ( )
{
// function analysis..
2010-04-04 09:17:53 +02:00
ASSERT_EQUALS ( " foo " , analyseFunctions ( " void foo(int x) { } " ) ) ;
ASSERT_EQUALS ( " foo " , analyseFunctions ( " void foo(const int &x) { } " ) ) ;
ASSERT_EQUALS ( " foo " , analyseFunctions ( " void foo(int &x) { ++x; } " ) ) ;
ASSERT_EQUALS ( " " , analyseFunctions ( " void foo(int &x) { x = 0; } " ) ) ;
2010-01-24 15:23:21 +01:00
ASSERT_EQUALS ( " " , analyseFunctions ( " void foo(s x) { } " ) ) ;
// function calls..
checkUninitVar ( " void assignOne(int &x) \n "
" { x = 1; } \n "
" \n "
" int f() \n "
2010-01-08 21:24:48 +01:00
" { \n "
2010-01-24 15:23:21 +01:00
" int i; \n "
" assignOne(i); \n "
" return i; \n "
" }; \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
checkUninitVar ( " int f(int (*assign)(int *p)) \n "
" { \n "
" int i; \n "
" (*assign)(&i); \n "
" return i; \n "
2010-01-08 21:24:48 +01:00
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
checkUninitVar ( " int f() \n "
2010-01-08 21:54:24 +01:00
" { \n "
2010-01-24 15:23:21 +01:00
" char s[10]; \n "
" return bar(s); \n "
2010-01-08 21:54:24 +01:00
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
checkUninitVar ( " void f() \n "
2010-01-08 21:24:48 +01:00
" { \n "
2010-01-24 15:23:21 +01:00
" FILE *f; \n "
" fflush(f); \n "
2010-01-08 21:24:48 +01:00
" } \n " ) ;
2010-01-24 15:23:21 +01:00
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: f \n " , errout . str ( ) ) ;
checkUninitVar ( " void f() \n "
" { \n "
" Abc *p; \n "
" int sz = sizeof(*p); \n "
" } " ) ;
2010-01-08 21:24:48 +01:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-01-24 15:23:21 +01:00
checkUninitVar ( " void foo() \n "
" { \n "
" Foo *p; \n "
" x = bar(sizeof(*p)); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
checkUninitVar ( " void foo() \n "
" { \n "
" Foo *p; \n "
" x = bar(p->begin()); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: p \n " , errout . str ( ) ) ;
2010-01-11 22:28:07 +01:00
checkUninitVar ( " int foo(int x) { return x; } \n "
" void f2() \n "
" { \n "
" int x; \n "
" foo(x); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (error) Uninitialized variable: x \n " , errout . str ( ) ) ;
2010-01-23 07:57:57 +01:00
// using uninitialized function pointer..
checkUninitVar ( " void foo() \n "
" { \n "
" void (*f)(); \n "
" f(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (error) Uninitialized variable: f \n " , errout . str ( ) ) ;
2010-01-11 22:28:07 +01:00
}
2009-06-18 22:26:21 +02:00
void checkOldStylePointerCast ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
tokenizer . setVarId ( ) ;
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
Settings settings ;
settings . _checkCodingStyle = true ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
2009-07-05 22:16:43 +02:00
checkOther . warningOldStylePointerCast ( ) ;
2009-06-18 22:26:21 +02:00
}
void oldStylePointerCast ( )
{
2009-06-19 12:01:27 +02:00
checkOldStylePointerCast ( " class Base; \n "
" void foo() \n "
" { \n "
" Base * b = (Base *) derived; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (style) C-style pointer casting \n " , errout . str ( ) ) ;
2009-07-20 21:52:27 +02:00
checkOldStylePointerCast ( " class Base; \n "
" void foo() \n "
" { \n "
" Base * b = (const Base *) derived; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (style) C-style pointer casting \n " , errout . str ( ) ) ;
2009-06-19 12:01:27 +02:00
2009-09-24 22:46:08 +02:00
checkOldStylePointerCast ( " class Base; \n "
" void foo() \n "
" { \n "
" Base * b = (const Base *) ( new Derived() ); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (style) C-style pointer casting \n " , errout . str ( ) ) ;
checkOldStylePointerCast ( " class Base; \n "
" void foo() \n "
" { \n "
" Base * b = (const Base *) new Derived(); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (style) C-style pointer casting \n " , errout . str ( ) ) ;
checkOldStylePointerCast ( " class Base; \n "
" void foo() \n "
" { \n "
" Base * b = (const Base *) new short[10]; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (style) C-style pointer casting \n " , errout . str ( ) ) ;
2009-06-18 22:26:21 +02:00
checkOldStylePointerCast ( " class B; \n "
" class A \n "
" { \n "
" virtual void abc(B *) const = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-07-20 21:52:27 +02:00
checkOldStylePointerCast ( " class B; \n "
" class A \n "
" { \n "
" virtual void abc(const B *) const = 0; \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-06-18 22:26:21 +02:00
}
2009-07-25 00:36:15 +02:00
void checkpostIncrementDecrement ( const char code [ ] )
{
// Tokenize..
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
tokenizer . setVarId ( ) ;
// Clear the error buffer..
errout . str ( " " ) ;
// Check for redundant code..
Settings settings ;
settings . _checkCodingStyle = true ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
checkOther . postIncrement ( ) ;
}
void postIncrementDecrementStl ( )
{
2009-07-25 01:23:30 +02:00
checkpostIncrementDecrement ( " void f1() \n "
" { \n "
" std::list<int>::iterator it; \n "
" for (it = ab.begin(); it != ab.end(); it++) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (possible style) Pre-Incrementing variable 'it' is preferred to Post-Incrementing \n " , errout . str ( ) ) ;
2009-12-23 13:38:54 +01:00
checkpostIncrementDecrement ( " void f1() \n "
" { \n "
" std::list<int>::iterator it; \n "
" for (it = ab.begin(); it != ab.end(); it++) \n "
" ; \n "
" for (it = ab.begin(); it != ab.end(); it++) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (possible style) Pre-Incrementing variable 'it' is preferred to Post-Incrementing \n "
" [test.cpp:6]: (possible style) Pre-Incrementing variable 'it' is preferred to Post-Incrementing \n " , errout . str ( ) ) ;
2009-07-25 01:23:30 +02:00
checkpostIncrementDecrement ( " void f2() \n "
" { \n "
" std::list<int>::iterator it; \n "
" for (it = ab.end(); it != ab.begin(); it--) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (possible style) Pre-Decrementing variable 'it' is preferred to Post-Decrementing \n " , errout . str ( ) ) ;
2009-12-23 13:38:54 +01:00
checkpostIncrementDecrement ( " void f2() \n "
" { \n "
" std::list<int>::iterator it; \n "
" for (it = ab.end(); it != ab.begin(); it--) \n "
" ; \n "
" for (it = ab.end(); it != ab.begin(); it--) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (possible style) Pre-Decrementing variable 'it' is preferred to Post-Decrementing \n "
" [test.cpp:6]: (possible style) Pre-Decrementing variable 'it' is preferred to Post-Decrementing \n " , errout . str ( ) ) ;
2009-12-29 19:24:48 +01:00
checkpostIncrementDecrement ( " void f1() \n "
" { \n "
" std::list<std::vector<int> >::iterator it; \n "
" for (it = ab.begin(); it != ab.end(); it++) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (possible style) Pre-Incrementing variable 'it' is preferred to Post-Incrementing \n " , errout . str ( ) ) ;
checkpostIncrementDecrement ( " void f1() \n "
" { \n "
" std::map<int, std::vector<int> >::iterator it; \n "
" for (it = ab.begin(); it != ab.end(); it++) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:4]: (possible style) Pre-Incrementing variable 'it' is preferred to Post-Incrementing \n " , errout . str ( ) ) ;
2009-07-25 00:36:15 +02:00
}
2009-07-25 01:23:30 +02:00
void postIncrementDecrementClass ( )
{
checkpostIncrementDecrement ( " class TestClass; \n "
" void f1() \n "
" { \n "
" TestClass tClass; \n "
" for (tClass = TestClass.begin(); tClass != TestClass.end(); tClass++) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (possible style) Pre-Incrementing variable 'tClass' is preferred to Post-Incrementing \n " , errout . str ( ) ) ;
checkpostIncrementDecrement ( " class TestClass; \n "
" void f1() \n "
" { \n "
" TestClass tClass; \n "
" for (tClass = TestClass.end(); tClass != TestClass.begin(); tClass--) \n "
" ; \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:5]: (possible style) Pre-Decrementing variable 'tClass' is preferred to Post-Decrementing \n " , errout . str ( ) ) ;
}
2009-07-25 00:36:15 +02:00
2009-10-04 10:05:58 +02:00
void dangerousStrolUsage ( )
{
{
sprintfUsage ( " int f(const char *num) \n "
" { \n "
" return strtol(num, NULL, 1); \n "
" } \n " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Invalid radix in call to strtol or strtoul. Must be 0 or 2-36 \n " , errout . str ( ) ) ;
}
{
sprintfUsage ( " int f(const char *num) \n "
" { \n "
" return strtol(num, NULL, 10); \n "
" } \n " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
}
}
void testPassedByValue ( const char code [ ] )
{
Tokenizer tokenizer ;
std : : istringstream istr ( code ) ;
tokenizer . tokenize ( istr , " test.cpp " ) ;
// Clear the error buffer..
errout . str ( " " ) ;
Settings settings ;
CheckOther checkOther ( & tokenizer , & settings , this ) ;
checkOther . checkConstantFunctionParameter ( ) ;
}
void passedByValue ( )
{
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::string str) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:1]: (style) Function parameter 'str' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-04 10:05:58 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " class Foo; \n void f(const Foo foo) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:2]: (style) Function parameter 'foo' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-04 10:05:58 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::string &str) {} " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-04 10:05:58 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::vector<int> v) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:1]: (style) Function parameter 'v' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-04 10:05:58 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::vector<std::string> v) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:1]: (style) Function parameter 'v' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-05 10:59:28 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::vector<int> &v) {} " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-05 10:59:28 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::map<int,int> &v) {} " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2009-10-05 10:59:28 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::map<int,int> v) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:1]: (style) Function parameter 'v' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-05 10:59:28 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::map<std::string,std::string> v) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:1]: (style) Function parameter 'v' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-05 10:59:28 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::map<int,std::string> v) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:1]: (style) Function parameter 'v' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-05 10:59:28 +02:00
2009-10-06 23:04:54 +02:00
testPassedByValue ( " void f(const std::map<std::string,int> v) {} " ) ;
ASSERT_EQUALS ( " [test.cpp:1]: (style) Function parameter 'v' is passed by value. It could be passed by reference instead. \n " , errout . str ( ) ) ;
2009-10-04 10:05:58 +02:00
}
2010-04-02 07:32:03 +02:00
void mathfunctionCall1 ( )
{
2010-04-02 20:42:06 +02:00
// log|log10
2010-04-02 02:19:38 +02:00
check ( " void foo() \n "
" { \n "
" std::cout << log(-2) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value -2 to log() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << log(-1.) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value -1. to log() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << log(-1.0) << std::endl; \n "
" } " ) ;
2010-04-02 07:32:03 +02:00
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value -1.0 to log() leads to undefined result \n " , errout . str ( ) ) ;
2010-04-02 02:19:38 +02:00
check ( " void foo() \n "
" { \n "
" std::cout << log(-0.1) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value -0.1 to log() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << log(0) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value 0 to log() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << log(0.) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value 0. to log() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << log(0.0) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value 0.0 to log() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << log(1.0E+3) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << log(1.0E-3) << std::endl; \n "
" } " ) ;
2010-04-04 08:01:05 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-04-02 02:19:38 +02:00
check ( " void foo() \n "
" { \n "
" std::cout << log(1E-3) << std::endl; \n "
" } " ) ;
2010-04-04 08:01:05 +02:00
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-04-02 02:19:38 +02:00
2010-04-02 20:42:06 +02:00
// acos
2010-04-02 20:23:37 +02:00
check ( " void foo() \n "
" { \n "
2010-04-04 08:01:05 +02:00
" std::cout << acos(1) << std::endl; \n "
" std::cout << acos(-1) << std::endl; \n "
" std::cout << acos(0.1) << std::endl; \n "
" std::cout << acos(0.0001) << std::endl; \n "
" std::cout << acos(0.01) << std::endl; \n "
" std::cout << acos(1.0E-1) << std::endl; \n "
2010-04-02 20:23:37 +02:00
" std::cout << acos(-1.0E-1) << std::endl; \n "
" std::cout << acos(+1.0E-1) << std::endl; \n "
" std::cout << acos(0.1E-1) << std::endl; \n "
" std::cout << acos(+0.1E-1) << std::endl; \n "
" std::cout << acos(-0.1E-1) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << acos(1.1) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value 1.1 to acos() leads to undefined result \n " , errout . str ( ) ) ;
2010-04-02 02:19:38 +02:00
2010-04-02 20:23:37 +02:00
check ( " void foo() \n "
" { \n "
" std::cout << acos(-1.1) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value -1.1 to acos() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << acos(-110) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value -110 to acos() leads to undefined result \n " , errout . str ( ) ) ;
2010-04-05 19:35:56 +02:00
// atan2
check ( " void foo() \n "
" { \n "
" std::cout << atan2(1,1) << std::endl; \n "
" std::cout << atan2(-1,-1) << std::endl; \n "
" std::cout << atan2(0.1,1) << std::endl; \n "
" std::cout << atan2(0.0001,100) << std::endl; \n "
" std::cout << atan2(0.01m-1) << std::endl; \n "
" std::cout << atan2(1.0E-1,-3) << std::endl; \n "
" std::cout << atan2(-1.0E-1,+2) << std::endl; \n "
" std::cout << atan2(+1.0E-1,0) << std::endl; \n "
" std::cout << atan2(0.1E-1,3) << std::endl; \n "
" std::cout << atan2(+0.1E-1,1) << std::endl; \n "
" std::cout << atan2(-0.1E-1,8) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << atan2(0,0) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value 0 and 0 to atan2() leads to undefined result \n " , errout . str ( ) ) ;
2010-04-05 20:07:53 +02:00
// fmod
2010-04-05 19:45:33 +02:00
check ( " void foo() \n "
" { \n "
" std::cout << fmod(1.0,0) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value 1.0 and 0 to fmod() leads to undefined result \n " , errout . str ( ) ) ;
2010-04-05 20:07:53 +02:00
check ( " void foo() \n "
" { \n "
" std::cout << fmod(1.0,1) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
// pow
check ( " void foo() \n "
" { \n "
" std::cout << pow(0,-10) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " [test.cpp:3]: (error) Passing value 0 and -10 to pow() leads to undefined result \n " , errout . str ( ) ) ;
check ( " void foo() \n "
" { \n "
" std::cout << pow(0,10) << std::endl; \n "
" } " ) ;
ASSERT_EQUALS ( " " , errout . str ( ) ) ;
2010-04-05 19:35:56 +02:00
2010-04-02 20:23:37 +02:00
}
2008-12-19 22:15:18 +01:00
} ;
2009-01-05 16:49:57 +01:00
REGISTER_TEST ( TestOther )
2008-12-19 22:15:18 +01:00